From nobody Fri Jul 24 21:30:56 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65D9E471D13 for ; Thu, 23 Jul 2026 11:45:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784807150; cv=none; b=KTDd8TwC7/FXwRVlF+ptRxaUp82zeMCgNKrUCbjCqOBmTKC93ZEaYiVdCZe03wuOjocnZVZNcBzQd2h07Dp4twJXr8Z0no/JT4HJGnTUKYzOclYsJQnBO+xylhqDi/HuPcS26NeOBnyA7nkyHNY/47cBmDHSX1ePBxNosOcFiQw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784807150; c=relaxed/simple; bh=rnQRIx9nr5Pt9psdgxOkFunoRdX6Lj3wKYuEaoFGItM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HNO7PtmyIKJsTeGTrUO5QT5rxuCuDuO3lDGHygHo/wmqcT5aaY7kHSG9BCO9IMS4l7eo31XtFgZXEZs/IYJ8PXqt77lDIXKIcENbnmtOrpasTtmVAM3Rg1nfTSiNLjg6CXHcb0ZWnn9sOs+P6cqoyv3FJttRfTgpX8IQ3fVbdr0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=zRSwyafH; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="zRSwyafH" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2cab973140bso7113375ad.3 for ; Thu, 23 Jul 2026 04:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1784807146; x=1785411946; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=qW5FtRGSlPIuifYqC0uvc8wKrWKuGaKd/2/4BPZB+Yw=; b=zRSwyafHeEBVEgI0lXX37qd8vyO0T2BR5gC2Hah9+rBG8ExIARFVe6GB8Gk6ujmeh8 3rjss4wDFlLmdmLnZPULpwQutc+GDEMqJTugY7Yz9qV5Qy+t9+FGk4z/hssRNR9yeZO/ EmmwE2B8sBMwsvfYgb5hLjStarLm5ylj+DtDdQ9Y5P2K6SUqW//qkJIxBgagW4eMB1// VjnoToNZ1TY0Q/gF0jdBGSXm8eQYA0jMmCzA9SehQneUBJbOvy8j8B64G7D99uvSG/Dg RiVkQpapN4VG68nQqlxDFAabNwtbdwbf6UnNGeHo5VPf2L4VGzKcNCETRdwbUQuF3Z1O y7Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784807146; x=1785411946; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qW5FtRGSlPIuifYqC0uvc8wKrWKuGaKd/2/4BPZB+Yw=; b=SYpCd62qNsmYhIeCzsc/fQf29zf7rmIh4VqKr0d4jTVbS3xKUKjkiLtsYir6iXAm7S kkk5eEMUZLNDwsD9iHLC3K4hS7dA5nkWmQkM9mOGM9sia2d05ES9nk3Rb/n04uv7Ge9i 5E/rhTkJftmpqebkqwvp9/5u1a9TDo+bEtNHhM9kn+lAJagk59cbAFHfKfmJLpqaAcHF R8tc6D2Y8UMRssjVyMfl+JVTOyAWRYsOR+WSU/kikyBA5HTO5FltcOTGsTrsBH46HWSV LDxZk45b+Q6K1Di+kDMnxE3rqf30HK6Ss8YEdGpWcuEVrEKpWsQOSQjpl8GJ/mEUAWZe P/vw== X-Forwarded-Encrypted: i=1; AHgh+RoLYOf1hf3GX2g47FpjwNcnBlNuzOPHAOhtBsA0gDCDEhp5nT+Aem2Jci7XhLOyn2aRUGnOOOMFn5+eBGE=@vger.kernel.org X-Gm-Message-State: AOJu0YxSXZW52qAPeHCEdXn5+g2NdS3i53NcAqNVoQxTbUM87FUTNgcr 0/7udjtRCiuok65YWIm6Ai1W3ZF+O0v4ZasxQvNa46YZEAydN3zjmf880hCtCSYpnn+j9wMg2UG Y6WVDwndIlg== X-Gm-Gg: AR+sD13/CAuSqqVoJBvleggMDUxGLhvuQ/V81jiLPSBWKP543PksC0gOy0/ZVudpaUk UvpSvGlGcwZnQJgP8epoaDOq9waroVGSTZLFDiTEr/4mGKGqF5geZzG4iteUEQX6U+cD9plHMhm +SFF6rwJZHW9RKxFSu83D6PqBryJLkKEcXfJsnKsZ9GSPg1ore87IZ36wVoz9/YNIYr/LARpa3C fLQCRJRD6Kvi2ykxSKttpOtg0i6Lg4BCOYUQmq+bOJNXJckMBj0PDcr2MzxueM6rKCy8doQnExi mJT1KMIi8skMUsR1BSWe7eSRmzsTu1azGxnirrlsOH1sLcGBX5IFpAGLpTwWGh7KtH6LymzI5JO 3yViAe8bMrp8TIcHxjZP1mspT7pPZxZ7+44fLNPD8NLC9FShY7kN8oeR1c8iupJ7cZmHbsDjUsF f5v6me0RWSfKfW6lIUo65VrU39SEQD8/Txp9DFqUFqj7588rntEqOF6519eyLW7HbUvaAiwN0FC 9R9LNHx2/1OtOh32itOZyNllN19cd/z X-Received: by 2002:a17:903:3bc7:b0:2cf:4c0f:5116 with SMTP id d9443c01a7336-2cfa6c5e50bmr34449455ad.28.1784807146525; Thu, 23 Jul 2026 04:45:46 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2cf8f310644sm32175005ad.55.2026.07.23.04.45.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 04:45:45 -0700 (PDT) From: Abdun Nihaal To: pkshih@realtek.com Cc: Abdun Nihaal , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, rtl8821cerfe2@gmail.com, stable@vger.kernel.org Subject: [PATCH v2] wifi: rtlwifi: rtl8192du: Fix possible memory leak in rtl92du_init_sw_vars() Date: Thu, 23 Jul 2026 17:15:37 +0530 Message-ID: <20260723114539.136986-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated inside rtl92du_init_shared_data() is not freed in any of the subsequent error paths in rtl92du_init_sw_vars(). Fix that by adding a call to rtl92du_deinit_shared_data() in the error path. Fixes: b5dc8873b6ff ("wifi: rtlwifi: Add rtl8192du/sw.c") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal Acked-by: Ping-Ke Shih --- Compile tested only. Issue found using static analysis. v1->v2: - Avoid jumping to error path when rtl92du_init_shared_data() fails, since in that error path, the memory is already freed even on error. Thanks to Ping-Ke Shih for pointing this out. v1 link: https://patchwork.kernel.org/project/linux-wireless/patch/20260722= 121236.136754-1-nihaal@cse.iitm.ac.in/ drivers/net/wireless/realtek/rtlwifi/rtl8192du/sw.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192du/sw.c b/drivers/= net/wireless/realtek/rtlwifi/rtl8192du/sw.c index 7bafb051d5ec..88e8cc590c54 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192du/sw.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192du/sw.c @@ -145,8 +145,10 @@ static int rtl92du_init_sw_vars(struct ieee80211_hw *h= w) =20 /* for firmware buf */ rtlpriv->rtlhal.pfirmware =3D kmalloc(0x8000, GFP_KERNEL); - if (!rtlpriv->rtlhal.pfirmware) - return -ENOMEM; + if (!rtlpriv->rtlhal.pfirmware) { + err =3D -ENOMEM; + goto error; + } =20 rtlpriv->max_fw_size =3D 0x8000; pr_info("Driver for Realtek RTL8192DU WLAN interface\n"); @@ -160,10 +162,14 @@ static int rtl92du_init_sw_vars(struct ieee80211_hw *= hw) pr_err("Failed to request firmware!\n"); kfree(rtlpriv->rtlhal.pfirmware); rtlpriv->rtlhal.pfirmware =3D NULL; - return err; + goto error; } =20 return 0; + +error: + rtl92du_deinit_shared_data(hw); + return err; } =20 static void rtl92du_deinit_sw_vars(struct ieee80211_hw *hw) --=20 2.43.0