From nobody Fri Jul 24 21:52:28 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DC3E45D5EA for ; Thu, 23 Jul 2026 11:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805048; cv=none; b=BEkxJTWmbKEtD5Xczkw3o8hPgr1Aj4hbi6uNs8YcirNm4uo1pVeqo6xHzYCbmhatG7RjBgqlxMp0s6dd1S+TZq17f16A748MDc3ZEhLxLq8zyAqBg6L0JlpyfEmk/raWi3YVFX+sEfSDJN4/6B36V2EjXBJjMmdGCVXqegixdIo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805048; c=relaxed/simple; bh=AFBxKIBwTyZrAmGdQnJGgzy3nM1sTvnC25r+L1MwTS0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=caRdgj0RKuZgYuDCFE933wWsG+yl3kamxqmcxZVNsh7gcse3znib5+wuwSh7l33oNI5oZZ8sybx4djYDctU1Zs7XuCIdZKreSE7M+JUHQ8ESM8FUqtK+BnHfu0TgW4W6a2iANxBgSRuBb1zRzXfoFzFOt97D/361EfdZZpUhIt4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pbs8DL25; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pbs8DL25" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cee9b74ee1so3820985ad.3 for ; Thu, 23 Jul 2026 04:10:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784805046; x=1785409846; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mMkS67zlUschvqIwbn8/Rc0NE/xfd4xHXYatpnZ3xec=; b=Pbs8DL25VtrbFlGzWnytjNn6m6kGJRaPmSBl2Uw8X+l+unVYpWC2ekISjtxeKxCAYr CvChI9E9V91N/RGnULaLtql8f/W63bt0Gwb9TUSfq2Ia42JlXZ65AGaMkH23HPrZO8J/ /eyBdKj5h3v20KO0bZ/UKP94wL16qM9QZDlYiz+UhlqM8LBeadpWTjT1xzwO2allEUSw Eu21x5bLMBnaVOKzduOs6/bbZqOtspmUqIKqjLAFvqfbwKzvxtbmXCkPqq6ZoT2ckP+d IqfxRvK3e3CD8ox+S7N/eyau624AxknzJz9aWd7fyahKpjEPdimfADNGiUs8DI3R4xIv XO8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784805046; x=1785409846; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mMkS67zlUschvqIwbn8/Rc0NE/xfd4xHXYatpnZ3xec=; b=RJh+NF3v/gga7vYVGJ8rlczrSRb3yZYsjvgO/Nuyr3nEbIqrS8An/JX/RpuabhfITb pkzM7y2RDJsEsSsVgQS1pQrPexqjBKodRgpd/up7eVtvaaZbsYr70SPrmvNGTCfNE2Af SKEGxauNRPuPOm6BDUy3CPLVHATs5h9i2fszuDitUFUIruqADFS8YnkfWr0iiElTlmvn MCz7aGbONxpJ42fp4eSj4mVovCOxsQfkoeBYWIypkk+VXC+14c0+bLVCfu/T7kWcIm/N JLTQdfJcssQ1ne6xe168cX8rWyoPfcwnQY5wP1woM2ptHWClsvhuizlhzopzQ+C8VBVu ASdA== X-Forwarded-Encrypted: i=1; AHgh+Rof1akTrIVV1zdTjOobqrCjttnseH+mB5WsNpESSOzZ5CYcxpCT7XjcEeIyx4A27heSnFV6ZOgLqLwVbBk=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+Oda5ePgsa/XoXGZt/A5b9W4pyWl0nhcCVgPOa3Bde34SxGTx mzRDAeYdsXVsq1rsSWJlMLWgtXUvD4lrPcd/AF+wyXBZmcCTxGeDaj6N X-Gm-Gg: AR+sD11MN8qUOJBt8GramU23g7NRo/wplm1/tJVdovreifV3n+cGQQOogpcwhzOeEXh ro+dO/2RtDxSaMWZeu7428d00lazwdKrpLV5p0/GfycA/ibNUILcLZFwgHbAl6UflVz5d1jGx4P HPThB0Et2s8eV9+Cf3lF+vExXQ8Qio9n21UrxkH6VU4qlONh2KeVzeBgaofJiAJhWkrlV4q/A2M Qo9prvCCesUzu/KuNZa/ofOAfMzEmM3Qv4vf2ipXOU8V04PwibaYNKLC8nAcEJqTlP6TwyThFtX vgdYnBH5k+6Sq7RuyTkaDrVKt6mog28ReR1kX6RPIu7+dcqMGJoCHdH2eCiejrb/ae9S/1XBDK+ fIKdlQXJ+3mcCAmj1X8tnONUR5kJ5aJd51vYCDkYzhVC7r6NSUhiW8N/9alVWKks8quPPQtfty0 EdhjrRyXmLnat6v1AhEm7LJsNgd+NGCzmAA83K X-Received: by 2002:a17:902:db01:b0:2c8:2808:3ec4 with SMTP id d9443c01a7336-2cfa748ce6amr30066565ad.24.1784805046169; Thu, 23 Jul 2026 04:10:46 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f38a893sm31500805ad.77.2026.07.23.04.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 04:10:45 -0700 (PDT) From: phucduc.bui@gmail.com To: Hal Feng , Xingyu Wu , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Walker Chen , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 1/4] ASoC: starfive: jh7110-pwmdac: Remove unnecessary goto Date: Thu, 23 Jul 2026 18:10:11 +0700 Message-ID: <20260723111014.54071-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723111014.54071-1-phucduc.bui@gmail.com> References: <20260723111014.54071-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The error path after jh7110_pwmdac_runtime_resume() failure only performs a single cleanup operation before returning. Remove the unnecessary goto and return directly after calling pm_runtime_disable(), simplifying the control flow without changing the behavior. Signed-off-by: bui duc phuc --- sound/soc/starfive/jh7110_pwmdac.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/starfive/jh7110_pwmdac.c b/sound/soc/starfive/jh7110= _pwmdac.c index a603dd17931c..562936981cf0 100644 --- a/sound/soc/starfive/jh7110_pwmdac.c +++ b/sound/soc/starfive/jh7110_pwmdac.c @@ -486,16 +486,13 @@ static int jh7110_pwmdac_probe(struct platform_device= *pdev) pm_runtime_enable(dev->dev); if (!pm_runtime_enabled(&pdev->dev)) { ret =3D jh7110_pwmdac_runtime_resume(&pdev->dev); - if (ret) - goto err_pm_disable; + if (ret) { + pm_runtime_disable(&pdev->dev); + return ret; + } } =20 return 0; - -err_pm_disable: - pm_runtime_disable(&pdev->dev); - - return ret; } =20 static void jh7110_pwmdac_remove(struct platform_device *pdev) --=20 2.43.0 From nobody Fri Jul 24 21:52:28 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B382B46A605 for ; Thu, 23 Jul 2026 11:10:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805052; cv=none; b=AOjyKj4jVi0RZjYoSUC7nbF4FvdX7jnXcayhLlJkUjbAL05gMXGx262nKjtym26tXRuKZ5g2Jmdl9t0T5CFgGX8hmttiyDy5L5D9FgciBzsI7c6nLVXu9dLGCY7aiIoOP44ThtefzGQCv6zeE7lp+hzpOFLr5bx1HycFBwLgTnE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805052; c=relaxed/simple; bh=iy8ONyPJCb1ZN/9cQHu3wQNYtIFHjmssqrm535DhWUI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ejn2AZ6hf/C0EvVX/yU2JcMXcdMcwzIpyG9PLV3GE0ZQEM+UdaHzso2YaL/8A3qHENmZ49qYPbKSBsrPckQd43IpMppvNFBuz+QSzjvsJIQ3QRRauwZLvTpRX8glIlLS9owpVP4KwwsoSPbCSc4LK7r80HbmuCSJBWpcFwxqw5U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hdBCjsW1; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hdBCjsW1" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2cc7e86e7aeso5678925ad.2 for ; Thu, 23 Jul 2026 04:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784805050; x=1785409850; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=E7CMqpvoxTMssk1F2A6UdWgSY8o4WqonJW2ONWNcRiw=; b=hdBCjsW1HuPh4KqYTIlG21Knq8vJjo4a4tdtpjhzJcIyJZhjkjwo5R+jWkOo6UYd5k KvLUYMa8i8zEcm4phw+RBvbIsJuBUegXm5itCeKxJRcFApLPeykVtEx1mqAvkAwLF8oa jUK1KT4LnMhjRgU5+WLybFf8SzpC37p3sGneO3TdlhV4RybaBFUH1avAyWDPuYJBcn06 awUYkiicBHSC+H/W0SsichCYQg0E8PAK/KTBGpz7P7LfrZYXYwRW/YC3xMSsDlxL/+BZ a7qkdSJ3aIiBFYdF9IRaqFwfSjEpG8Dc/9ECuWUc5hYAWSblhOwBoUyrowug3WrL2w+C tfPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784805050; x=1785409850; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=E7CMqpvoxTMssk1F2A6UdWgSY8o4WqonJW2ONWNcRiw=; b=DdL9LPkL6Rc+9qSdXMTPrkcFQx0ohh8wDOjjFUsuVaObqnARczSeVcRKMO3LNZBr2i VXuG0H5xt7X2DiWvjynf64dougshyg2vYs5XJDxnThwBa+zJtbifr0NCxCK+kQJhi4h8 qR7sNrcqfDrlNNIkpUY2BYpw9KqlJPOl66GUZiuDun4QiK0Ax2E11/auewSJiEnCAipS PUlWAghXpKpDAdszjSvix3XEk5/kNi3aCyfTGfZXH6B/hEJSZYMtWZzVu26AekRFZzkI pJjXDGzUjIakPZPWP+tHfM9SPJdZXxEmGZ88qpkfiDg9wBvUIwgn08v3Nb1Y6GUciaJD 71vg== X-Forwarded-Encrypted: i=1; AHgh+RqNsB2cn6bsP6m/HjV4O3m6lBHFhYgf6yiVHLmheaZE2XbJIivJmkDOX6evF4fwFbgV+NJ9lb0WfCky1I4=@vger.kernel.org X-Gm-Message-State: AOJu0YyEcQwJE4sk99ub8bpOCicQZQ2dFWzIKLZcQUNCnuPPx0VA73xr 17ciaJo++Yr+8mDfa6NQnVIfN3eRdaIcYPkpy0POiqpJl4iG9E6FD2UV X-Gm-Gg: AR+sD11pPEANmzC9idqlb4pxLBses01xyhX5ZtHf4HYUr+OtBL+LublctKvtfqhdUHY SZyl4Sm3wn5WRZplTyR+bIEqVx3puCq7XxdaV7DDNlYuqwxeLKb96vVyIIGePeVscOJQNupnNSP nQsWoS19iOWqCcUbgOUP6icGf1s7cZeI3kbWEwde83n8GMUtLtECq8GXuS8kOi9OdsMdOYLR4e2 gIWP5DBCI1ONd99yg2F0KaRcxYPDh1iqAj9si421ApeIiJ2wdH2qYD4anFjgIIexX5cWgpIYffH aUkclF+JM2iCIN9oXmC2RiWvYGjm7JonxrUq5WR39DVKxCxcb+dtXmyxMZuxRfiA86oDjOYWUbM Ng0k1m9w8iUl7v/8zmmcn4s4ivNuKGShOlbbdmQglp6wEXumrZEUry+SBZkQnKQSXlbZMMWhf3h wNV1nM1XFfMO8e74rICKwg+3Ugyz4h4NPiHj7n X-Received: by 2002:a17:903:1aeb:b0:2ca:660:b1d with SMTP id d9443c01a7336-2cfa6b73ba7mr31684055ad.11.1784805049694; Thu, 23 Jul 2026 04:10:49 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f38a893sm31500805ad.77.2026.07.23.04.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 04:10:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Hal Feng , Xingyu Wu , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Walker Chen , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 2/4] ASoC: starfive: jh7110-pwmdac: Drop redundant error messages Date: Thu, 23 Jul 2026 18:10:12 +0700 Message-ID: <20260723111014.54071-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723111014.54071-1-phucduc.bui@gmail.com> References: <20260723111014.54071-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The called functions already log failures where appropriate. Return the original error directly and avoid duplicate error messages. Signed-off-by: bui duc phuc --- sound/soc/starfive/jh7110_pwmdac.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/starfive/jh7110_pwmdac.c b/sound/soc/starfive/jh7110= _pwmdac.c index 562936981cf0..5953c3a4e373 100644 --- a/sound/soc/starfive/jh7110_pwmdac.c +++ b/sound/soc/starfive/jh7110_pwmdac.c @@ -477,11 +477,11 @@ static int jh7110_pwmdac_probe(struct platform_device= *pdev) &jh7110_pwmdac_component, &jh7110_pwmdac_dai, 1); if (ret) - return dev_err_probe(&pdev->dev, ret, "failed to register dai\n"); + return ret; =20 ret =3D devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0); if (ret) - return dev_err_probe(&pdev->dev, ret, "failed to register pcm\n"); + return ret; =20 pm_runtime_enable(dev->dev); if (!pm_runtime_enabled(&pdev->dev)) { --=20 2.43.0 From nobody Fri Jul 24 21:52:28 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 600F645BD41 for ; Thu, 23 Jul 2026 11:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805058; cv=none; b=PvD+rYsUXw62plh5xhm9VKO1Wr+PunZXLOD/bAkQzZTWtlnQdz5aXCQknUI7lQZ3mi4lorEb9zwr8kYoTofkRteE9cWxKwcWQxU5nocmU1DfwAX3EkPV1/s8cX2FX50wN2X/5m/7N2a24c7ZPzeshvNy1e6GN2969xtgXQko+FI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805058; c=relaxed/simple; bh=zWsDJ9w00PvmiL5K7NvXHakKWbnnVtjba/fbAiRXx4M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EMIhqLdsvFvtjkKKyfyrAPFcxaszHdPY3onD1Jy9SscYMMwT4TqlbSi4ug5EcDCNmmCIq01YVV3BXZIo1pdgYm49nBnBM/6LAUCfRd6r9YnJW4sGMYGVfp+ArV7WL7KPmxcoTXPBM9RwwFN4ICsZhmv7q8VdLjB+K4VlHM+OX+A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VshNpWJo; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VshNpWJo" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2cad8076b01so6685135ad.2 for ; Thu, 23 Jul 2026 04:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784805053; x=1785409853; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XYqAoIaQg5nXDhd6691kkf7D6EBBcVp7XG5jEmvNbhA=; b=VshNpWJo1YJP4Ti8m6FvJNqA21m/0ind3uXRLwM4Gw6mE1G2XkzNDqNmrABe7yj9a/ CGE6Ppa0djprnMiQrOdazuk1LoOXzMPTAYUrg4VGYEDO3+l0z1l7UC6pbGG/dIcBkXc1 6FYwp2sH2LxFXGZ0VLFyGOA3qi3IWGGA2bticpOXd/sUdSvzp7dpnEqf8osu8gZcejTh nWlVMbbGoOgIcNLHjoB83FqJY8vkKzfVindNKNd0Zlso0w7/7imKefx5zime5GiMb8Tc ASEGAUXJTm05Kkeix8iFSfbrBTzGm/Oou1MEFcjh7+yCexWUlG57DUsm+l9uwrgOaNdt 3hJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784805053; x=1785409853; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=XYqAoIaQg5nXDhd6691kkf7D6EBBcVp7XG5jEmvNbhA=; b=iyVAczyna10nh3BPubn1eDlDMJvqetcd18SiEVOzVNDWt/Cgk3Spr7tuKOx+BIZ1qk JjErm5dDYoEhtC/Pj7jjxRB2uPY50nvPTeBaah2YJyWxrpWyGk0TaPULSnj4kaxWFLED 6sRmzWZYljW3QvHxr7+voVL/rBJPpM5XikAfmXy+nC+9pg5307XVn34yW8GpCBkFGVZ/ KZIoITVTTjOQvns7mFNToFUZRN0GzTWrLQR7us4tDF54lilfR7lWTJ0q7Cv//Dx6UQXG lqJBTQxMQx74F80RClutjPg8rlwbif22in00DinvrFvTWDvvoOZD1EyIuAWHNwWKqXE/ 3bpA== X-Forwarded-Encrypted: i=1; AHgh+RrwlPf0BP7AK5D5TJuzNpGqTJUh3CXgONiSekIChjNYc6+pBJ6P2KfvPvgt2FC4I1W9s39iX39NHa+qpGQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxaFYiogK0eKmYzW//0wajTeEC8HtLCT1y6mS2NIszuQwkndazz l8gBgpMHIyhyR8O7CVA5zAIKacTfomrien/tcNw3UNCx2PMheByy0jxA X-Gm-Gg: AR+sD12maQV0bn9PmvOOkpvbdY/BVLkjmyKoa3L00GZSmd+jMCIyqHeJ+0s2/lm0XVe njErUwq7NcBA1FsdcffZhdu/Y9tcOFLPk8a3Yw/aq9SgbIiUnrAGPe59kCbnrB4mV3KBgw40Jfb Zjoe+WTpCpQdB7GFl+JB+jMcZBj7js1Gzb8eho4s0M2Bo2wy6OSEEOtzG4rFrnThOp4CewGkUKo Sv/13LkHjAj3+8FfHlAPgfiBBOskcvjX+Kj4igbFdAEXPDtkWpogqMAH0NZFGSxFy/Gcu/V/ikk aWkveI7reC9lTn6ce/c9I+8IYQxLOgS212JVo+CvMUQoCFwfKrzrrQSBZhOyPJcueX3qQhiGHgf LD65o+ObHvQpXQygqRFBGTFULqJwO7+SCd20wc+HwBv45LjYtI4jLUWy1bLCmBVz3GH4Wae4Twu M8epSSchmBic/zJ2BhusEIxAVe1fl3gHZqy3ALhCGe9rm2l2I= X-Received: by 2002:a17:903:1250:b0:2ca:d91e:bfb4 with SMTP id d9443c01a7336-2cfa74e3b0dmr30593435ad.24.1784805052930; Thu, 23 Jul 2026 04:10:52 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f38a893sm31500805ad.77.2026.07.23.04.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 04:10:52 -0700 (PDT) From: phucduc.bui@gmail.com To: Hal Feng , Xingyu Wu , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Walker Chen , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 3/4] ASoC: starfive: jh7110_tdm: Remove unnecessary goto Date: Thu, 23 Jul 2026 18:10:13 +0700 Message-ID: <20260723111014.54071-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723111014.54071-1-phucduc.bui@gmail.com> References: <20260723111014.54071-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The error path after jh7110_tdm_runtime_resume() failure only performs a single cleanup operation before returning. Remove the unnecessary goto and return directly after calling pm_runtime_disable(), simplifying the control flow without changing the behavior. Signed-off-by: bui duc phuc --- sound/soc/starfive/jh7110_tdm.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/sound/soc/starfive/jh7110_tdm.c b/sound/soc/starfive/jh7110_td= m.c index afdcde7df91a..5365ebe44471 100644 --- a/sound/soc/starfive/jh7110_tdm.c +++ b/sound/soc/starfive/jh7110_tdm.c @@ -615,16 +615,13 @@ static int jh7110_tdm_probe(struct platform_device *p= dev) pm_runtime_enable(&pdev->dev); if (!pm_runtime_enabled(&pdev->dev)) { ret =3D jh7110_tdm_runtime_resume(&pdev->dev); - if (ret) - goto err_pm_disable; + if (ret) { + pm_runtime_disable(&pdev->dev); + return ret; + } } =20 return 0; - -err_pm_disable: - pm_runtime_disable(&pdev->dev); - - return ret; } =20 static void jh7110_tdm_dev_remove(struct platform_device *pdev) --=20 2.43.0 From nobody Fri Jul 24 21:52:28 2026 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4399846AEE8 for ; Thu, 23 Jul 2026 11:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805062; cv=none; b=OtoQeZvX0MNLeocPCYo2O+F6mgaJGuCr16mdnsmburYuAVrBJZnz8APp4aiXeITT/J954yt8Iq4fje/jFmnel8kMeD9+V0XbkV/Z0N0lAtAqtJFDDOXWPVzoNyUlbTe1DAmXxKk3BXM/MC94tIHB5W/WpAxbApKD4GITLEkJKYU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784805062; c=relaxed/simple; bh=7N9zuuD+31Nj6KRIPVdXvkaRC6VlFeTBZCFuP4lEjtw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BG24sVkNrdBtJM3TsdeTlYC4fSAxOowhW/kvZa4XVpM2gjVE2e0hk+mp8cJR+PJ+TAHieB179n36Wul2RcplVhhpzDk73GK60ZGi5m8ZKfre8bRgY4V5iFgkeybhZWtxyEvpRhuR2u1UkVnsLnwH3cl8wIP6aEE1nCNNlQISS7w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CbIPrqVh; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CbIPrqVh" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2ceed7018c8so3827605ad.1 for ; Thu, 23 Jul 2026 04:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784805056; x=1785409856; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OnMHtcI+qpC3YzUAbOGiPJG/5dyoFkJTHwb+5r+sq3Q=; b=CbIPrqVhOX6/7vEeRTG/WY9OwDDGK3bWEJMrvMIrpqfdxiKReCWqsbG24Kj75EoOw4 huJI9iJ7QfNp8syla8aWhotd1D5aIFLbChSYy8KvCB+7zjLCEeJRryKtUNoReQcBawzy b2RjWKpprJTvLaQS0MzPNss7xl9h90vzurNadFuOs74E+Fi1gAWJmW8YzOo86+M5bBLM /4zV9arpMTO8YyuOOlCKZFNxQIz47rMZFEd25Xy00kkbqMl2BXuKYJYF5iSGe4JlmLuz KR3ancHz3Uym3jPgvsVwVwGcfQEfRrbyRVkj28nHXB9Abkp822LGulXcHg3GRPIrVORR aH+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784805056; x=1785409856; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OnMHtcI+qpC3YzUAbOGiPJG/5dyoFkJTHwb+5r+sq3Q=; b=n7HPF2xjIIajHNBj9ZlgEuu53Vo9MwcMZWaxwAUmOGdf7DFwiJjRY+NwaTX6WR9DLn PCErgJphgqDASf3KN2+SsGQkJxVgub5lBdhUjcxRk3vdOOZdij07lHn4OmlntPh2gr74 CQqE586gSxmPr//IcaG4z2b+ayfElpOdFtM60JGgCw573weR7bxwIY/4mjk0Nl5PNrH/ eQWEdOVUZ+cIB19FUUcS84fhAR+1/HHJRR762eB8XxMKjoYeayel++OhPt/t8SQa9zXX I+IbGIM4Xoikz3jyzgb5fApOlpWsEM/O7g9NtSgvdhe9FEPSyayfJTQ+hZDSfEsFZie+ Jjng== X-Forwarded-Encrypted: i=1; AHgh+Rqr0ljjaf2Nn/R8K127y7BXIiqXixw49krA9g7ZKteDaXoEpor/1bw1L+fQ0AXUx/vefkpRS3HMX0nFziU=@vger.kernel.org X-Gm-Message-State: AOJu0YymW0CwgvCxi075Af3jBluajqiMd0eygBVYzj6cPppn0MECfUvU Ym38ByJTSLQerfYyak6a3/jP65KO63wHApdaHJ/104/JUCB48MplMPDR X-Gm-Gg: AR+sD12hg9gEuZJMjnqXxwyzp1v9tFeyMwj3hXpuVGcj1AkYUkz6v4lBcDSgweakSuj /BjcX7+6w4tIDHD013zmP2x27Sn1h3LhssQg793svKhEOQzw4vj/wnj1HkrHmoAuA2Odad3xtWb WVIYgAWElWX72H89CwGh5maPKnUOYMU+8eh0jFz66y6LzT74xb2gVw3pIo7aqIefOl9kodLczNs 6UrK4o2idZ3yuwLwmGdJFoSuKgObHdMOEFN9AMBmRGIinsj00z12lyC5iOb3HNu93NjIwbuGBYM g8m/CqHK4eWYhrsfKgX7/NPPRgoptakn8czDKI74fAlb7uoymwbNDGLU1psAKOTU2GiZV0gmkcS uAqB/qEVcG6CanifGvK0qaMPA1S0QmeO9NSBIDiYiEe62o/ocn6eaolm49KFxBUoqxaDJPTwoFH M0UwRNZNupkXQqkOQH41e3dYRsoX5glDKOCA96 X-Received: by 2002:a17:902:d4d2:b0:2ca:f21a:a6c5 with SMTP id d9443c01a7336-2cfa6a546bcmr31664385ad.1.1784805056158; Thu, 23 Jul 2026 04:10:56 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f38a893sm31500805ad.77.2026.07.23.04.10.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 04:10:55 -0700 (PDT) From: phucduc.bui@gmail.com To: Hal Feng , Xingyu Wu , Mark Brown , Jaroslav Kysela , Takashi Iwai Cc: Walker Chen , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 4/4] ASoC: starfive: jh7110_tdm: Drop redundant error messages Date: Thu, 23 Jul 2026 18:10:14 +0700 Message-ID: <20260723111014.54071-5-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260723111014.54071-1-phucduc.bui@gmail.com> References: <20260723111014.54071-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc The called functions already log failures where appropriate. Return the original error directly and avoid duplicate error messages. Signed-off-by: bui duc phuc --- sound/soc/starfive/jh7110_tdm.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/sound/soc/starfive/jh7110_tdm.c b/sound/soc/starfive/jh7110_td= m.c index 5365ebe44471..f7522bfbe8e6 100644 --- a/sound/soc/starfive/jh7110_tdm.c +++ b/sound/soc/starfive/jh7110_tdm.c @@ -559,10 +559,8 @@ static int jh7110_tdm_clk_reset_get(struct platform_de= vice *pdev, tdm->clks[5].id =3D "tdm"; =20 ret =3D devm_clk_bulk_get(&pdev->dev, ARRAY_SIZE(tdm->clks), tdm->clks); - if (ret) { - dev_err(&pdev->dev, "Failed to get tdm clocks\n"); + if (ret) return ret; - } =20 tdm->resets =3D devm_reset_control_array_get_exclusive(&pdev->dev); if (IS_ERR(tdm->resets)) { @@ -589,28 +587,22 @@ static int jh7110_tdm_probe(struct platform_device *p= dev) tdm->dev =3D &pdev->dev; =20 ret =3D jh7110_tdm_clk_reset_get(pdev, tdm); - if (ret) { - dev_err(&pdev->dev, "Failed to enable audio-tdm clock\n"); + if (ret) return ret; - } =20 jh7110_tdm_init_params(tdm); =20 dev_set_drvdata(&pdev->dev, tdm); ret =3D devm_snd_soc_register_component(&pdev->dev, &jh7110_tdm_component, &jh7110_tdm_dai, 1); - if (ret) { - dev_err(&pdev->dev, "Failed to register dai\n"); + if (ret) return ret; - } =20 ret =3D devm_snd_dmaengine_pcm_register(&pdev->dev, &jh7110_dmaengine_pcm_config, SND_DMAENGINE_PCM_FLAG_COMPAT); - if (ret) { - dev_err(&pdev->dev, "Could not register pcm: %d\n", ret); + if (ret) return ret; - } =20 pm_runtime_enable(&pdev->dev); if (!pm_runtime_enabled(&pdev->dev)) { --=20 2.43.0