From nobody Fri Jul 24 21:52:57 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAF58429CF0 for ; Thu, 23 Jul 2026 09:59:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800782; cv=none; b=T24qg//Gd/+gk4ss3Sfw2DAAwBRbP6HiB+2/IA3Rhqmg+Qa8fJjSiAvO/CTgBHEsDeGxeTd8GxfKb3bQ4fezkySnqwzwsm7462Diw5gorIg2E0BfyZ0PHpzObrrqnsEKc+mSMw+6hL+0L8NJehLjNcVdKPHefkD15OQggSEVAKI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800782; c=relaxed/simple; bh=GRrfxLRgNpKm6lsvifAkdPINzwR4tjY/umqSXWMqGeE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jvNb7Nf7viB62q6kPEQc5vv0DgZX4IMamUASfctOAuV+Fp0Ivi87bnr8T5hj/GdwtM4qG8ehFKN6t/MP98szPSkhgIJnrFEhw9j+16oYfj5CdoG5r99EhWldaJo/0gM0nLwjPyHda4+0vS5U/Mfo6SnavM/AFdK3RxavIq8EXxQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n/iFvvXu; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n/iFvvXu" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso5046195e9.3 for ; Thu, 23 Jul 2026 02:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784800779; x=1785405579; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=BrBCr7AbLc/6xolx1/6dBK5OEwK/e0MsPXsWHktbVcI=; b=n/iFvvXu9EBu14/PZpplrQX27zsaJuu2RfWmiJt5LiSvxKg7n92krtIY/pdE8FLxl1 ELjF/JjHRw0NBh/HfDAWmt1Yy+rl1YrCiH+hVXgLTAMbGCEdrR8sqE+I+RuBDkQX4SaD rdEm02VpZEYlxTQ/T5mu7IrmmW+9A6InNvzUtwSdZxe+XWp3F2+Hf54pqtHUePQ1cbHr HfjK/b8X9djInZk3ITxDS4S8sziZ9LJ6POEfA8rhRt68obO37jGZjVmoa+BEfZOA+Tw8 pBZNX+DBiYBSXeha9E/NQ8Z9rMczsms5gs1n/jZ7FPyd4km2LgVMos94qST5JtbsbI1a 9lfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784800779; x=1785405579; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=BrBCr7AbLc/6xolx1/6dBK5OEwK/e0MsPXsWHktbVcI=; b=Mf6k5Gf0+StvTG+4rW8vynwxNbtI3FBQgYZB3bM+u45YNeTSH1r7mKd5peHYHgIg/8 1B2ZBHq53e/pvaG81LwyWOX9QhEHqPoMhpnruRxaSu4K1cy4ViFKxMcRAdFh6HCg/W+f 5uibo81Y5X+eKHPNw/7rQ203YJZaAQOGTPKQIODcw71wPooiOW7OmrB0Q/j/IED2ZpKX /ZG3LmK8Xt9IdLr/g507QzNGcF+D17B2vXFiTdmgSePnScuNDGLOnF7REDTkI6k3UDzm ZH25vewY1sf42Z4/brH9qM69XKGoNtBRXa6JzIzbK42BEg5/xFgaw+PaZ8jFtJsP8hsh /+8A== X-Forwarded-Encrypted: i=1; AHgh+RpGmm3lqpnXd4luwSsWBJfJDc7PLvO1rPK1iuyTcdPIiN3bfk29LSNvfg+vCYAagzOPCH/gs+LSewqU53Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1NoQwi9ztaG7bhxQfaY9LsY13O4Fh7hIDMCJpZuJ1bqEGnQSx cl9qxSKj7wPYn3CFLdA/PQmuuiExhZFi7cwArOaqRWiCIKnP2NkeeHkg X-Gm-Gg: AR+sD10xxoUcAz6SE02BOFGwoHub/NgwZGM/mIey7PIyPiiSfvIAqIJ7jgnrarOsvWa xFfbM2r4mdghsdQnoXswSdr/hzWITmM7RCuYyi+1Gz9zmGBrKXEo0lMWS+IIYWk0E8uyu6zFsM0 GfE8tSGvMpLRqs3v0AEZGsX+a8IBs8R4opO7SRZZMdEUOcPpnqjj7CJ7MfdsL6Rf0Bsds5KjR4o /xzde/9Dw6DTW1dpc4OQ5W2cwNJaNrGWX7J1qMyMS/5lNbxw/mBJIIwbsI2NttiyI+tVZaN7/vN QbTD+kzpV48xDM/LJ5j8EjuN4MZReyzQ4ewXuvKRw1dM9TdIRxXlShBoy91PUFo0E77KmfMNIEB 5H1jZSfkqfoVaRg1wI/kMeF9PgXiLo5iEniDEJ0EJZR8m1O/cq40Wuf7HlCyhNnZgdwiLZAtEiL EEOjimQyx69WW+S8xSKqz18T/WBC0= X-Received: by 2002:a7b:cbda:0:b0:493:cd3f:d051 with SMTP id 5b1f17b1804b1-49573cffa67mr15330745e9.25.1784800778721; Thu, 23 Jul 2026 02:59:38 -0700 (PDT) Received: from LAPTOP-AVI.taile24b5.ts.net ([2a00:a040:1b7:4f41:a638:2cd9:2446:f69e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-495653c9d99sm212315585e9.12.2026.07.23.02.59.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 02:59:38 -0700 (PDT) From: Avi Weiss To: linux-can@vger.kernel.org Cc: Pavel Pisa , Ondrej Ille , Marc Kleine-Budde , Vincent Mailhol , Martin Jerabek , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Avi Weiss Subject: [PATCH net] can: ctucanfd: unmap BAR0 using base address Date: Thu, 23 Jul 2026 12:59:34 +0300 Message-ID: <20260723095934.181042-1-thnkslprpt@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" BAR0 is mapped into bar0_base, while cra_addr points to an offset within that mapping and is used for other purposes. Pass bar0_base to pci_iounmap(), instead of cra_addr, on the probe error path so the address returned by pci_iomap() is used for unmapping. Fixes: 792a5b678e81 ("can: ctucanfd: CTU CAN FD open-source IP core - PCI b= us support.") Signed-off-by: Avi Weiss Acked-by: Pavel Pisa --- drivers/net/can/ctucanfd/ctucanfd_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/ctucanfd/ctucanfd_pci.c b/drivers/net/can/ctuc= anfd/ctucanfd_pci.c index 625788fa8976..f845951c5d51 100644 --- a/drivers/net/can/ctucanfd/ctucanfd_pci.c +++ b/drivers/net/can/ctucanfd/ctucanfd_pci.c @@ -194,7 +194,7 @@ static int ctucan_pci_probe(struct pci_dev *pdev, pci_set_drvdata(pdev, NULL); kfree(bdata); err_pci_iounmap_bar0: - pci_iounmap(pdev, cra_addr); + pci_iounmap(pdev, bar0_base); err_pci_iounmap_bar1: pci_iounmap(pdev, addr); err_release_regions: --=20 2.43.0