From nobody Fri Jul 24 21:52:58 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011006.outbound.protection.outlook.com [40.93.194.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6724918D636; Thu, 23 Jul 2026 09:54:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800484; cv=fail; b=MS311cIUO7+Lb8f72sTOWpzwvjcWYwaNGudE4A9QsB8k7SIgbPgBnekV0T+3h9NUg+m+WOcSPulhZGCNr+5KQTWrJ11TfQBxMi4joUlcAYgT23Agp6lA8b7YdlRcJLEW4fyO4HbAbXIlpqK7Ke0/b9pd6vj8xfWaMUdkO6ol/hM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800484; c=relaxed/simple; bh=wPHsImfmtEe41G8iyeWq143SZFiEQhcc08P2sxjKJVI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lLd/wWRKIdbCbqgeD3t9PhZzYWD2yYOZ4QnF7tKw4dt+2kDjGCHamNG9A/ksiQXqFDbGYFccEN40Uo3hhqgbMa6d+g9dM7MDlr8tpnTXHSeoG+WDgk4fK2f6w0vSXmTQXf75OhC7nCr/gcbt1eptvcoDryC+1EhLES0W3SODcb0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=A0genaw+; arc=fail smtp.client-ip=40.93.194.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="A0genaw+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RdSovaRusZtP2cdp4Vd0atTSOvev9CTQRtPUoN9x1E3wpRal2x4CKQZXX5tB0PD0ywsQLkgZtlqNL38KFipmtDWNNWrHNnhAJ8bRBY39tRX2ovyxYOofY4tatZaan1MIKVB5nvvKIRE7D20p8L4k45FyARPIEwbbZXSXU1r+/vehlSZeW9SWEqpPNhRih82b9POYjU9dhoHiDZztVVmCIpQYgGkIzZsGaZZWDnAN8TS1zrxY01zRl0gwIZN9CRo/IaXhUiujaXYFs/VROVLqErtmI/boUUMTc0uWlGFHV7Wi88jL6lOQ268f0FYAJk6MV74N4zllbvtqaGLoSj8eSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WSaw6JxYXlPvpCrOt8rsSiZl3OVFFOfODDtMpbqYFl4=; b=Ff0nm+R7l7qiO/7AaRpZXcUfQmDEuZtkAS7rJUlBgccbpG3IKN1HXWupvUkD+JFZCTPsrBlHUNiJsevFUUr9RuiRFI743oNjfYWNKVRUWjh29/rA/jadsDo0m63PR476JYVtmvQ+yl/b4fcl7SNOAwTZzQDOJiCjyyE6xbGjXeVequq2LNAx74w9EGdlJLPR5VaSclxDmgMF3R3g26GVxef8GnL4Hxs0ejLZSG2bJ/v2ruxXPd2GZw/bpF6995bDx9HOCt/Pfzxz/6xkndkWt5jnhw2Kuqsne2WlPJpq2OwDdO1E6anMQgjTy8WT7ptawNDLhDJjtaJqsAjDIcxIcQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WSaw6JxYXlPvpCrOt8rsSiZl3OVFFOfODDtMpbqYFl4=; b=A0genaw+wuAuIEHAhqV2Lk0Baw8nu42wNvbAR4/dT6VfOQ+edVyGrdkQolo6vxFMvzl1uAHua3npMr/XyDZvVoQxucHNWR+bnWu06LBkBbmY5u+WItPqCtKsdmarwIsa4psJMSdanVFvm55xJ5Suj0ClhElvDdiR63Z1GqLVkLosnymOREOsfS7VhFGx4vROxABzjNpY3RVTlo36D2njJLPvLb2zx7+U+fWimwJgTyeV5u51hIkbqyInmAi4qQ0PIXn8o5j3grhnYXKPrDOawYbZMxYdpSTDggk305bMn/xlFDylhDcaGM6uXIvXHtgHR02awKsfwNFxTLIezvxS0A== Received: from MN0P221CA0009.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:52a::27) by CHAPR12MB999250.namprd12.prod.outlook.com (2603:10b6:610:300::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Thu, 23 Jul 2026 09:54:37 +0000 Received: from BL6PEPF00022573.namprd02.prod.outlook.com (2603:10b6:208:52a:cafe::5f) by MN0P221CA0009.outlook.office365.com (2603:10b6:208:52a::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.11 via Frontend Transport; Thu, 23 Jul 2026 09:54:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF00022573.mail.protection.outlook.com (10.167.249.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Thu, 23 Jul 2026 09:54:36 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 23 Jul 2026 02:54:21 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 23 Jul 2026 02:54:20 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Thu, 23 Jul 2026 02:54:14 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alexei Lazar , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , Erez Shitrit , Feng Liu , Gal Pressman , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Parav Pandit , Saeed Mahameed , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next 1/5] net/mlx5: HWS, Print more details for bad completion Date: Thu, 23 Jul 2026 12:53:45 +0300 Message-ID: <20260723095349.1890983-2-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260723095349.1890983-1-tariqt@nvidia.com> References: <20260723095349.1890983-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022573:EE_|CHAPR12MB999250:EE_ X-MS-Office365-Filtering-Correlation-Id: b4083bc2-65ae-4153-b8b6-08dee8a06814 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|82310400026|36860700016|23010399003|1800799024|6133799003|22082099003|18002099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: Pa7oZGdgI03mBDktcwzp7vSCBj21iRVP4iDig0nMJk2iT1aUc/XvXgQeo/vQciOKX6IHcYyMvw0bCVbke6/LoWReiQp2mYHT9+DsJiTN6P78Z3+GK4GtNQ2nLmrSg4OF7NqvW/eIjKB9IB73wyptIqVqDcGTo4+c4D2uZnnjlFAZyJmC8s68+KM0rfP1KQSBRSjLInk7+xHKd0tDilY9VMqpL6Q5sY8zrLTxCGx6nI1uUNKPGmzLZVL8WrccAJWpY5GWLailGewL988Mermp6Vd0sdnISyaNcdjPUi57IW/HK+D7aZAZJsmq/AYT1/rQF0TxvBuIU3UPO8d6I1dWqkuPyVEbMuexPNlvu61z7YQJ50jvxafkSaSK5rM2st0wP+PEvchN9FZER4a0hv5VN57co7HLcOiAQpzcUtulywl8vwUtEVAECVgJLpMFTx/ND4VCIK9MDrQvfuTN04TQj3B82E/kfxaNtxcxXtaps4hAMslDDpiEA43Yl6vUpHpW79OJnsdW9dmFK8gGUM16y1stYKhaYJ+XK7Jk6+31fPiJIv/vB2Dbv4sscYOgRjlQqU4up4XHF8+TqlSrHLQO3m3itzNPFjuXHb/OC8RBp7taTOxa1ttaaUSwgMsy9OpArNHVbTfpAq0qSkmcy8WGsxTsC4IMuB3SzdAXXH+m3jCDfWcD/4bPbiQKsSOtNyZh+gzHgPYZIGkaeWZm1LS2Ng== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(376014)(82310400026)(36860700016)(23010399003)(1800799024)(6133799003)(22082099003)(18002099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Se4haNCymQjTBzViUcOC+eedwEXzt0fHm/QktsQ5qJk6/P/XxneHUryJfYzcc7eTiiUyzPXmcb7r5O4Q5g3jPqC4dXy3Ov7M28aNFeqlx0nlFkoDd5FcB2ntsfqK0uGXJYm1a4cl10U9r7+ascViFpGz+UfXBhDYgKr0kTdb1c3cv+fPjrcrBQumLXgXuP25n/eF3vmb3yzrsO5y40GFuc00UiNTcqPW/LY74j+NY8e18nBCnes7yDsVAO7LI/jmadrM7AF3mjUtF31bOn/TkkSFdzQ5Falxd9pmsU4ekDfS0RTAPR6xz8VjacpqOgzz2Ujc+lWIKXVl4Z3SbbMrXj8q37365HpW/+Jr1iSytdmsYxkFKdRdqmqo4Zi4ruqXSYT+fJR770sMuUTFALLhIRlH5k39Nc9LKrpNCEE9HzvAWrwlhr6gsllNPH+jCyyR X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2026 09:54:36.9865 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4083bc2-65ae-4153-b8b6-08dee8a06814 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022573.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CHAPR12MB999250 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik When polling for completion returned completion with error, parse some more details: QP number and WQE count. Also, extract all the long value-to-string if conditions to a short value-to-string functions: do it for rule resize state, rule status, and syndrome. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- .../mellanox/mlx5/core/steering/hws/send.c | 68 +++++++++++++------ 1 file changed, 49 insertions(+), 19 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index aed009aec4fe..1c9206f74aaa 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -344,6 +344,36 @@ hws_send_engine_update_rule_resize(struct mlx5hws_send= _engine *queue, } } =20 +static const char *hws_rule_status_to_string(enum mlx5hws_rule_status stat= us) +{ + switch (status) { + case MLX5HWS_RULE_STATUS_CREATING: return "CREATING"; + case MLX5HWS_RULE_STATUS_UPDATING: return "UPDATING"; + case MLX5HWS_RULE_STATUS_DELETING: return "DELETING"; + case MLX5HWS_RULE_STATUS_FAILING: return "FAILING"; + default: return "NA"; + } +} + +static const char *hws_rule_resize_state_to_string(u8 state) +{ + switch (state) { + case MLX5HWS_RULE_RESIZE_STATE_IDLE: return "IDLE"; + case MLX5HWS_RULE_RESIZE_STATE_WRITING: return "WRITING"; + case MLX5HWS_RULE_RESIZE_STATE_DELETING: return "DELETING"; + default: return "UNKNOWN"; + } +} + +static const char *hws_gta_syndrome_to_string(u8 syndrome) +{ + switch (syndrome) { + case 1: return "SET_FLOW_FAIL"; + case 2: return "DISABLE_FLOW_FAIL"; + default: return "UNKNOWN"; + } +} + static void hws_send_engine_dump_error_cqe(struct mlx5hws_send_engine *que= ue, struct mlx5hws_send_ring_priv *priv, struct mlx5_cqe64 *cqe) @@ -352,6 +382,7 @@ static void hws_send_engine_dump_error_cqe(struct mlx5h= ws_send_engine *queue, struct mlx5hws_context *ctx =3D priv->rule->matcher->tbl->ctx; u32 opcode =3D cqe ? get_cqe_opcode(cqe) : 0; struct mlx5hws_rule *rule =3D priv->rule; + u8 syndrome; =20 /* If something bad happens and lots of rules are failing, we don't * want to pollute dmesg. Print only the first bad cqe per engine, @@ -364,26 +395,17 @@ static void hws_send_engine_dump_error_cqe(struct mlx= 5hws_send_engine *queue, =20 if (mlx5hws_rule_move_in_progress(rule)) mlx5hws_err(ctx, - "--- rule 0x%08llx: error completion moving rule: phase %s, wqes le= ft %d\n", + "--- rule 0x%08llx: error completion moving rule: phase %s (%d), wq= es left %d\n", HWS_PTR_TO_ID(rule), - rule->resize_info->state =3D=3D - MLX5HWS_RULE_RESIZE_STATE_WRITING ? "WRITING" : - rule->resize_info->state =3D=3D - MLX5HWS_RULE_RESIZE_STATE_DELETING ? "DELETING" : - "UNKNOWN", + hws_rule_resize_state_to_string + (rule->resize_info->state), + rule->resize_info->state, rule->pending_wqes); else mlx5hws_err(ctx, "--- rule 0x%08llx: error completion %s (%d), wqes left %d\n", HWS_PTR_TO_ID(rule), - rule->status =3D=3D - MLX5HWS_RULE_STATUS_CREATING ? "CREATING" : - rule->status =3D=3D - MLX5HWS_RULE_STATUS_DELETING ? "DELETING" : - rule->status =3D=3D - MLX5HWS_RULE_STATUS_FAILING ? "FAILING" : - rule->status =3D=3D - MLX5HWS_RULE_STATUS_UPDATING ? "UPDATING" : "NA", + hws_rule_status_to_string(rule->status), rule->status, rule->pending_wqes); =20 @@ -423,6 +445,15 @@ static void hws_send_engine_dump_error_cqe(struct mlx5= hws_send_engine *queue, " rule 0x%08llx: |--- syndrome =3D 0x%x\n", HWS_PTR_TO_ID(rule), err_cqe->syndrome); + mlx5hws_err(ctx, + " rule 0x%08llx: |--- QPN =3D 0x%x\n", + HWS_PTR_TO_ID(rule), + be32_to_cpu(err_cqe->s_wqe_opcode_qpn) & + 0xffffff); + mlx5hws_err(ctx, + " rule 0x%08llx: |--- WQE_CNT =3D 0x%04x\n", + HWS_PTR_TO_ID(rule), + (u32)be16_to_cpu(err_cqe->wqe_counter)); } =20 mlx5hws_err(ctx, @@ -433,13 +464,12 @@ static void hws_send_engine_dump_error_cqe(struct mlx= 5hws_send_engine *queue, HWS_PTR_TO_ID(rule), (be32_to_cpu(cqe->byte_cnt) & 0x80000000) ? "FAILURE" : "SUCCESS"); + /* syndrome is in the lower 2 bits of byte_cnt */ + syndrome =3D be32_to_cpu(cqe->byte_cnt) & 3; mlx5hws_err(ctx, - " rule 0x%08llx: |------- SYNDROME =3D %s\n", + " rule 0x%08llx: |------- SYNDROME =3D %s (%u)\n", HWS_PTR_TO_ID(rule), - ((be32_to_cpu(cqe->byte_cnt) & 0x00000003) =3D=3D 1) ? - "SET_FLOW_FAIL" : - ((be32_to_cpu(cqe->byte_cnt) & 0x00000003) =3D=3D 2) ? - "DISABLE_FLOW_FAIL" : "UNKNOWN"); + hws_gta_syndrome_to_string(syndrome), syndrome); mlx5hws_err(ctx, " rule 0x%08llx: cqe->sop_drop_qpn =3D 0x%08x\n", HWS_PTR_TO_ID(rule), be32_to_cpu(cqe->sop_drop_qpn)); --=20 2.44.0 From nobody Fri Jul 24 21:52:58 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011047.outbound.protection.outlook.com [52.101.57.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70F3942B303; Thu, 23 Jul 2026 09:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800493; cv=fail; b=GO/qnnmQwuUJBHFRFhk+LTgD6qiS2rgd3svzlYDx4X0sMk4ubRX72I6fKnNex9gInrS36XBsrGnszUswXuBocl1xU2BROENx/qIuM1/Fq6JZvWPt34NzpUm3GxO5BuyYoc0DMXqfz/iw7evWSf8YvlpsLlF/rfCgZSmImqWFrDQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800493; c=relaxed/simple; bh=Mxfhe/Da4T+vI328wT2fjEHCPrvd7d47KPDLZdDbuxk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rF4pjwCrN1nAsNPiK3a1LACI0UOEIc+VoV7Y1J0/0KgTPcZxcBrBwRfQAFrl5/USYZmZWu5+330KLHaMhp8dG2G2CfecW/MiOeqdEJ1LVDS7assbjL/KgfExBT8Pg9Os2eefJajJ03QTPzMJ+4lEFagGrvk87sWzj7fMVZnV9Yw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=e+XJtHB+; arc=fail smtp.client-ip=52.101.57.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="e+XJtHB+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WmNRnByws1sWK6uwYmgT6Y1TkqrNQfHqgaQZUwwOscMZZ36PGB7E0H2SFdz8qqJE5kB/eRjJKMUMwq6NL6oJPS1Xk6b1ucn5rMrku6y8wjru6aqlo7xwQTXIupJoCbQrt2FPhZf29Mj0IzkOozQliEXASSwAfIbCgQYTu9JapSOMXjBw8f4SPsynXxUKjTRStEtdxdhLnluRvxv8MCYlhf4w6kgJk0yPWuzYFMVh8H+Ro+u+VQE14qpYdtzhpPVf/EBjOVjM+0tmKAaNuEL5sZJzPW/KR0PfHp3kXFO80521Pu8HJWtK3FLT8Yz71Q5HMH1B7NLJcnzarnPRvumaUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Ons6JyUHk4+AWYjYbqBrqNhMuVVTF0AB9JWBgu4vmU=; b=wD1p5+3V+wtHcd0sH0NdSraLfKatwl1JMYDvGGS3jOXH0JEc4Uk76d1QrXKt6l/2qMt35+4/EdXRUk+mLyRThQT2MXt99KLXxFQopF7UuRp3ohUi1wK6OG2DIXtlgwhT4JH3TAnmtOxn+gkfb6+bgUBfh4mfkNNI+DbnUWNUgfbKgNeu3v6WFR83/ywABk+69BGiL/0umF/L2H8c0mceXfEvwGvUjqjEzDfgtVy2WvBkDqckIpm9jn6SHswRCmcOILzea8zrSSvSWrLmxi3rjcJgy+o/HYEi0+EzZ/QMYIri+cPEYpk4hia4gp3uIrOxEoSlCfE19HX/0A3fSTUeEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Ons6JyUHk4+AWYjYbqBrqNhMuVVTF0AB9JWBgu4vmU=; b=e+XJtHB+8e5mASj2Xcsk3A6GFqupPaUCIfvTI9HSia9lh0ZMWIQ9SC25MS/602v7tJuar9ObSr+os+Z0KCQuEl5V58IOEYWJq5XQI+F43umh3P/BnKttS8eLgB4XfporN0cb8H38wx4w9Aymw14FonMwLO85mtwhFj20rzqYWMxf+tZoSJCiaal20rl9Vni9l5pwfATSe6fhyk3rzHjQHMYrL2K7Yvum26tMCH5e3pIyPlBSYf16mu1g0sEVbGQyxEJUSiJtDFRcO6e4X5HvnmrK/cQOPjrwOKM51emvnwHywRMe+WL4ocvRz0LbMI+rPfUrniZEMbdDs6sz0cBUcQ== Received: from SJ0PR05CA0022.namprd05.prod.outlook.com (2603:10b6:a03:33b::27) by SA3PR12MB7976.namprd12.prod.outlook.com (2603:10b6:806:312::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Thu, 23 Jul 2026 09:54:45 +0000 Received: from SJ5PEPF000001E9.namprd05.prod.outlook.com (2603:10b6:a03:33b:cafe::37) by SJ0PR05CA0022.outlook.office365.com (2603:10b6:a03:33b::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Thu, 23 Jul 2026 09:54:45 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001E9.mail.protection.outlook.com (10.167.242.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Thu, 23 Jul 2026 09:54:44 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 23 Jul 2026 02:54:27 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 23 Jul 2026 02:54:27 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Thu, 23 Jul 2026 02:54:21 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alexei Lazar , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , Erez Shitrit , Feng Liu , Gal Pressman , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Parav Pandit , Saeed Mahameed , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next 2/5] net/mlx5: HWS, Log syndrome on STC modify failure Date: Thu, 23 Jul 2026 12:53:46 +0300 Message-ID: <20260723095349.1890983-3-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260723095349.1890983-1-tariqt@nvidia.com> References: <20260723095349.1890983-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001E9:EE_|SA3PR12MB7976:EE_ X-MS-Office365-Filtering-Correlation-Id: a5a0c913-ed39-4f23-9f54-08dee8a06c78 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|82310400026|36860700016|376014|7416014|3023799007|11063799006|56012099006|10067099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: Kdb76cX0nSks/bAQUDY8Sv4PuBkumlRxRTCjsasJGdGMIXAhi6eC0faSKb+qPINWMf4Igd9LptGE6/AtjTymVw/2eAjVmAE4Vo1J49SzfR76/7xhEHIlLy/X38zR2JNQ/V2pscam8BE8IgmrF3Y+DvC7pBpvyhmDEQdMQlVVzu0IrFxbu/ukrWQxuy07SzWcNm6/lx7+/ptq33HjOwdaKyWT/a6Lsb36m6SvGTKDo9oWTxncU0ef7PA4wyjCNd3X9xCEz4eQdfcW1Tuj2Z2zLMhNV0SVFtFkHSuNnGsjb0j0FHgLrKRi79Q1HEoKS+79/YidpgQZDNTAwZBZsZrnKGE0mYp5hjLxk6+3lD1X8sfapDIpD8MWlbvEBfV3qz2+s1yHG9cbVxt9JNT4g/IgGfgd5EBl6ESKwLPaH41DN2dj7/AIjfbxLyif/xSpNpd2dPhm3uMTu7sl5nwXrK7LF5ud2coQvXKaujeXbLQIFc0oz4uAS+EiagacBG0+G55sQ8cc1lZivkxm9nY4JPb57elscZR7BkWBfYnsvXcxuIGLDcAAzLu5rwc7fQlvZcN+YF4+QzNzpJgEjZrREEheYBlQ3UwbZ9JsqD3vTnZNKHv74KgEXaknsHW88EEVG+fRF5ykIGDkOrZM/gZTHDkeqY5xQ5Wl8BR7lq2hcT55Syo1VlL6+NvR1SRZzO4UdmiiuiIIk/2lgS+g6f+pyPQexg== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(82310400026)(36860700016)(376014)(7416014)(3023799007)(11063799006)(56012099006)(10067099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Yg+KJZj5T9MA8ZhTujKVy8HJhU+6G+b6Wj3Uka60vGLYmCQEJkZDpBdiAhfOJDDLFH20K6BOQOziNqmCOY4ON3nNhQ6Lc7R4kX9BOmChJEG4lvbg28J4oMDUBn+iTrFCYXuXwC7OLCR47kcnWC08XnXNdse1o4i9Eu0/dtEEwoR5S/ldnJTA7hf/YZ0GfM8igCudv1naWjXt6TqG3OgBG/V90HBxx4+e9E67Zcg6Lc0Aj2sricAJjT365P+55M8CgvQrDiCepRYTODoCCV/gcmj5qVTPZsHnCABFsg40J21K8t1CuxaeEh5QS9Y18oXe3YfSy4c1MI2NXzsy78yUCUTua/9zGuCQ9SHqek91GsZrHvyFDKgc9CUdGFpsnzSfuOzS1k8/KWd/l0WndlWpHJVlbJ93zSsh8OM+qBrrDijgDPJ/Siaqrv7PPDOYVidQ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2026 09:54:44.4130 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a5a0c913-ed39-4f23-9f54-08dee8a06c78 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001E9.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB7976 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik When mlx5_cmd_exec fails for STC modify, include the command syndrome from the output buffer in the error message to aid debugging. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- .../net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c b/d= rivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c index e624f5da96c8..c04ac970705b 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c @@ -611,9 +611,11 @@ int mlx5hws_cmd_stc_modify(struct mlx5_core_dev *mdev, =20 ret =3D mlx5_cmd_exec(mdev, in, sizeof(in), out, sizeof(out)); if (ret) - mlx5_core_err(mdev, "Failed to modify STC FW action_type %d\n", - stc_attr->action_type); - + mlx5_core_err(mdev, + "Failed to modify STC action_type %d, err %d, syndrome 0x%x\n", + stc_attr->action_type, ret, + MLX5_GET(general_obj_out_cmd_hdr, + out, syndrome)); return ret; } =20 --=20 2.44.0 From nobody Fri Jul 24 21:52:58 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011007.outbound.protection.outlook.com [40.93.194.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 240E74322F1; Thu, 23 Jul 2026 09:54:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.7 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800496; cv=fail; b=pBMASJi9GwD70uBffrNlw/vHoS1NwTzXffgpXGUW0GNLaGk47EfdfbO44g71/9KupCpRn8WS3wANYXWgMnWNk3zXQxQc8Dv80J17sRQS50UjKkcURA48KMptUZnOtrX0InTZ2hsHyFvxeQpTp6E+TeXiFNfsHh8B7xirutCRtlY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800496; c=relaxed/simple; bh=/GCqifligbeh/pm5JS4f1e4WhClbttnsEWTGKyv8m7Y=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pAjsFHhJObMt2ANy3Ap/WIK1xNKWgwLMyKB0dIcnVJxr/EBv08i2sax13PSRHyDEYdZxn5DIa8+SIMlHuQeerkj3hfhB53RTp9efeBHUwU/CF9hzfEOhqBHC/b/zoJfvoJ5Y61aurrfy+mogI5c2dx2wHo1y9Ifw62dyWVUZNEw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=n+TsUuGx; arc=fail smtp.client-ip=40.93.194.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="n+TsUuGx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eijcxFT+OkgGBEaRh/l+4g2cDv1g7/ugbSwKnwFoCgh/wA98gettbXsYTD6sS9sgkltTYaomM2Dm8nxrnUCMjSNkWR9SBkI35Wrsh8G/0JMBrwXUzeivcf27iDSr1ciO3JtiKua4EeyXZjuBKJ/wgpMUXy5woy/GrXcsjGuprSHOMJTJSAvSo5Yxa/MsKM6hLLgqM2JE9oxcRNuTFGNwkg1GpkEvf5xQQ28NavagQwA28bNl5IWvRSQkEsyMhYLxCHgyH+Y/rO4T6pIJusQ4oftu7xQ0oVCDZJeQjl7WGDMP2HsEDse9aZYyBI1YVyOB1fKuLAo2nxBgxsDIQRZmzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R2A0NGAxy8AMJNr03AXwLbFBp1YCre7sWvchJGAg7oI=; b=CJ8BPYSqiBpLoNKSNVMRs5VQa3hsZnx6NtaCIqG+fdPCBAQrnp9ALUH+SgExVs+bbRwisdK9qmfpj8Bt8jGxies4wg15GWwFApmZpkZG5nPQtONE4FG5/yyAArGhevwcg4BZGd/tZSDFQ1L2hTnUDF1wb05BB95PhqLpX0HIgYgsVI6+MDmrEPieg0+Ls/2WxwBxmadUGUpKyclFkRHrPEtmVp05wC9IlmlShErdpDD5eAKFTP6X1bCYSl7+WSYw0ED2+w98oxGkDInTx6sed4VbvXJPcC4XpriFZV1gKD8o22mtf8ebDtkycjjTAzGKG7G7PKRBsZZea4WWbi7dWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R2A0NGAxy8AMJNr03AXwLbFBp1YCre7sWvchJGAg7oI=; b=n+TsUuGxv6ptoVU7tuFbCuzImeYR0nGDbLC2YFZZWn86SEAQcmT/vRi3Lo1RY8vvMSv0IVkeef80u0mTkGE2JJNOj/xjFShk64fpX7knh2VaEn+nK6QOlyjzCOHcDTssIUjTPJmAxywpZMAucDSYUib+2IAJPBQVY2K8pXcIpWNsmZfFuv4Y0Bq2Jlc45AfpGk/ULGJqOlaOakKzIXAHQgJYEf4f2EakZU98m6+5jhMMfsGOc3jR5Mlmo6nMPH/8V/3C9l8ybaSs4h7iVMbWchjQyZnlmAAmh+aI23Ocgv/Btbb2DgdUXDhdvsNKUsrmMwbX4wsP4ChLpvnn4WlfXg== Received: from MN0P221CA0004.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:52a::11) by BY5PR12MB4049.namprd12.prod.outlook.com (2603:10b6:a03:201::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Thu, 23 Jul 2026 09:54:50 +0000 Received: from BL6PEPF00022573.namprd02.prod.outlook.com (2603:10b6:208:52a:cafe::af) by MN0P221CA0004.outlook.office365.com (2603:10b6:208:52a::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.11 via Frontend Transport; Thu, 23 Jul 2026 09:54:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF00022573.mail.protection.outlook.com (10.167.249.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Thu, 23 Jul 2026 09:54:49 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 23 Jul 2026 02:54:34 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 23 Jul 2026 02:54:33 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Thu, 23 Jul 2026 02:54:27 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alexei Lazar , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , Erez Shitrit , Feng Liu , Gal Pressman , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Parav Pandit , Saeed Mahameed , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next 3/5] net/mlx5: HWS, Set the num of queues only when alloc succeeded Date: Thu, 23 Jul 2026 12:53:47 +0300 Message-ID: <20260723095349.1890983-4-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260723095349.1890983-1-tariqt@nvidia.com> References: <20260723095349.1890983-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022573:EE_|BY5PR12MB4049:EE_ X-MS-Office365-Filtering-Correlation-Id: 8db3980b-12e1-46ea-72e2-08dee8a06f66 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|36860700016|7416014|23010399003|376014|18002099003|22082099003|10067099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: xUkUTiSWj7NP3ZyqxiZbHUyE+ElkXlWwiHm0OPqDF/j9swKzMIPKt1habLArXOlNaFIlg6Uf/2RuIAUkH6v4bw9mtlUdRv8nC3l5NJtucYyNPM9E5806a5lM7NclDyjINBEX+Vgac36q7xAHgoHNiuI4X7wn+jOQsY2K6Zsq/OupYnuTwCyT1HPpdtj/oB7D5JXOc+ZX9EspihIeWPUHRzOJQw3yJkRTECTXSI0kMxthEKkGd0AIKqTsExgRNV+y/mbLrL66vsM550takigT9q6VKAm/MBivC0HWV1mj17XsMX/53/osWX75J9EjEHIuLN1vVkY2Qn/YaRjMqBBhlnUmXL0wtCEpLc52bEqG/TLzqJvNwfxeuc4Fb8+D5ABfNCDmfdtuW1vhB2NITVxNMqYY6UIiQbMdJyX9O1owkaxu5O5RLmK278OgomRmS5N5ZrTN4Wy8Vz5Z1rUf5SEek0pjc7Oz3Px1AK7K80vgjnSo9XfnKQO5EV4Yvxsukv7VhnrwZcBqtLGBkoezvypQ1Db0oHz1coek/NC8oO+ipN+IsZKs46Kn4I25wZ4xaHcstPGT/jh23Nf/Nl8laSVb9ulBESPMmh1BvqNwWOPYf9+Iy4SLuxb0FbEigpkgMwitNZzcxwJhnM3vjhtJe89ZJVprSKB+a2DgENyfAfbuGt5w9tPVR+El2j967dHjudUkMLL0wXElTIEM8x3/QIGlZg== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(36860700016)(7416014)(23010399003)(376014)(18002099003)(22082099003)(10067099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XcNep5diC68FWz2GHiMroy5QyURTvi0ln5guYu+lG2zFdUNnxIdo7kgUcmpqiXqyRtI6nfqEdEjlCitCDnVI8SpBrTGMXSZfnIkEtKLDToACzCeZ9xqFTFgFVwUMlfj6RgJ0fyxTWRhx5xPlDIQdvLLGqa3K6ZxtfejkMsDpBI14C08v0lcE2xO6BPRrb8ZKGr4fDMU57wFGaH/gT1Y038w0C1CG8KEwr9Uw84BJlq2MIhJmWx3cAd6/LXnB8a01GIPev1/ABdIVlpjg+h1NxjrUrDslO71ir0xfEfeFVNPtMJp3qjRTPX+4I2tQXjjCXemZQecG8C2RD+tqsZWSpTzrs2wmJtS43azCwvmnHgfx99ria1tsSgU3+wOJ0Hi7UwlT28SmsHTuPJNreGGhKeJ58TsH69w7zN82ptiuJGbAxP+SjOpVp9xp5y30h1T3 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2026 09:54:49.2691 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8db3980b-12e1-46ea-72e2-08dee8a06f66 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022573.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4049 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik When initializing send queues, set the number of queues only when allocations are over. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c b/= drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c index 1c9206f74aaa..f0c3a2bda0c7 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/send.c @@ -1121,8 +1121,6 @@ static int hws_bwc_send_queues_init(struct mlx5hws_co= ntext *ctx) if (!mlx5hws_context_bwc_supported(ctx)) return 0; =20 - ctx->queues +=3D bwc_queues; - ctx->bwc_send_queue_locks =3D kzalloc_objs(*ctx->bwc_send_queue_locks, bwc_queues); =20 @@ -1134,6 +1132,8 @@ static int hws_bwc_send_queues_init(struct mlx5hws_co= ntext *ctx) if (!ctx->bwc_lock_class_keys) goto err_lock_class_keys; =20 + ctx->queues +=3D bwc_queues; + for (i =3D 0; i < bwc_queues; i++) { mutex_init(&ctx->bwc_send_queue_locks[i]); lockdep_register_key(ctx->bwc_lock_class_keys + i); --=20 2.44.0 From nobody Fri Jul 24 21:52:58 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013040.outbound.protection.outlook.com [40.93.196.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A6D34302F8; Thu, 23 Jul 2026 09:55:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800503; cv=fail; b=TtCQsD9AHKs+Vd9UsfLx7zbsy02jxWs6tzU1J4qYgAoQKFzvewjm8OpGNhQOB3Q532qTnLS1NVkvyUveSlu2W4GmTC+dL5dEiwdOzg91HVJf4ovXYfXIzbgh31hpUXrE6JWQ3oI0XKnIpuwA04OrOZbV8VWpSevrY4ItD2Iu1zI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800503; c=relaxed/simple; bh=TnylFoKrmjv1eYeTz5k/jvMBwAyLEYOnEr5M3WVDU+o=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=skJ8hsHPO5ZQCx+YwfNQHN7cMJsOtdmJBtGa6LzcUZRNahAldk7Ps6SnFuvLGxqYvpnSiVyABcd65xjn/K86dhgSbQdXIqtKr7zpobeMLBwV+Z1OEp5dOX1cp6ZdvQc1ZzGc8UmLWEHkhJZxKwEgYEw0C/CjevHXZszArUHpOz8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Lb9rtATD; arc=fail smtp.client-ip=40.93.196.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Lb9rtATD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B+kgD4meIiT8H6NrcoM9IuEtsebfPXkiFRkHGklvsXRGeBlL1Ogaor9NeKAJ+GPWSNFiLMSjtmS4zI9z6OwBFijzlYsBpZ+VyLuQ4QJKy1wiS6YwThXlmXDICZkTbpPh+B9hT796CpaRlPRrgFVBW54zMD8icjoUjipnGrGBWkFJwMRFdzXBNsWUyTkz5qVtdELNMRSavZc/thWSCsvVfWjTeVUO9BDK3ftrpWexaODwNkKgWPoKb5cq/vPCKEddHLUq5Gnwa10Tb2sHcysgo/5Gw+oL9ysZcDTbo13e4VdM1SMjKwhudWnWubqJU7nsVEcP4l02G7ruzn00pjj3KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zBDhENs1EkY+1i1zSEQDPdkSJlEuM8PtoR7uqhiHFHE=; b=Pw+E2nQ4idxwmSBd5scCWa3JDZtpXDcWs4igym0fRRBR9WovtKdSUEI4PqkiJrx5JHuEt8fqJNh+jBKYheg3ZGcHdmSJlLqZQ8H6I7G7Lt2q9RCdm8LllH3ykBF8lM28Xhg+nUuJQjxx03dmY7YyAHX5degldu2SdR9MofLUaYeFNHn8CrjrRpKF7P+xSv/xkNkce7YA7SoLA7WIPgF6JkcmE2Z9hxjY/SRhDE5s07QWGNHh1K4f8RdM2Zw18kk+dml0uYCQCMSNb925RsfiZyr5O79P38N+HDD5DWLEk8KltNpfhWn0an2R6KWElJ5plaz88jBIBRQVMjQX5Ic/hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zBDhENs1EkY+1i1zSEQDPdkSJlEuM8PtoR7uqhiHFHE=; b=Lb9rtATDGBG5p7eAsiV5RyFUOr86HTyQMh9pdQPhPFUBG2GtfSJ2DoipSA1hd9Aep0N0dBrBuN3Zaol50fV3kGYTgP8bVgaMsXF4WjVzCn48NrS3JT9Fx4P+/pHed+CrS0quD+1m5f1a1fwUNZnQ5P/lma5/cV1GP8lnRzKKFH1yI/DxdCmw4Eaopihvk+OtHeNRNn4gm4dpq6fYC4Av0TJIO7Km3vQlMSVfjhGdgP6cfUSKA1t+nMEyBF20/RtWXRbqQK+uAiDN/1y/aZyJmDQb3hn/WQUjQWrfhLCZMT/DEgTLHG+lJdZIIUC3fZyWp/4lIsQlw5HRoOMvWVzJaA== Received: from SJ0PR03CA0061.namprd03.prod.outlook.com (2603:10b6:a03:331::6) by DM4PR12MB7719.namprd12.prod.outlook.com (2603:10b6:8:101::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.11; Thu, 23 Jul 2026 09:54:55 +0000 Received: from SJ5PEPF000001EF.namprd05.prod.outlook.com (2603:10b6:a03:331:cafe::7c) by SJ0PR03CA0061.outlook.office365.com (2603:10b6:a03:331::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.11 via Frontend Transport; Thu, 23 Jul 2026 09:54:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001EF.mail.protection.outlook.com (10.167.242.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Thu, 23 Jul 2026 09:54:54 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 23 Jul 2026 02:54:41 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 23 Jul 2026 02:54:40 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Thu, 23 Jul 2026 02:54:34 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alexei Lazar , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , Erez Shitrit , Feng Liu , Gal Pressman , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Parav Pandit , Saeed Mahameed , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next 4/5] net/mlx5: HWS, Remove redundant MLX5_SET in RTC creation Date: Thu, 23 Jul 2026 12:53:48 +0300 Message-ID: <20260723095349.1890983-5-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260723095349.1890983-1-tariqt@nvidia.com> References: <20260723095349.1890983-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001EF:EE_|DM4PR12MB7719:EE_ X-MS-Office365-Filtering-Correlation-Id: ca3187b9-4e80-4255-d6a7-08dee8a072c0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|36860700016|82310400026|23010399003|1800799024|11063799006|56012099006|18002099003|22082099003|10067099003; X-Microsoft-Antispam-Message-Info: DJeF4XH9BvniyjsnyH41GIy0WQ9ON2AkPU+Qus6EaEz5LgNjhgIBDqMy7ZV9ouNdTvVkRKcW5v3fYYNLCMLLV8uIAdik+tO5S8P5kOJqjStN7uvkiJYxD6m3z+4PiYu6B7XIOGtgFsQ6/+UOxEVi1mcGbtl1VZ66We3MKk4vbHEngz19PD49HvN/EPhTJlUUYAVCotVnforNbhen3r6tL8TRy6GXOWp6IBYXx/5jEll48P/raynDBoci3xUMDnpFiDU4kNJqcrOul7LEIFfbBfcvP05fFcVuJoWrWV/B9dxqbcGkGMBuNCW+SiMW/vSrCVan8br0F+sFBwMRZabhFYBn1M2gQdoj/12nI17dG6XX5yql/JaFkYVoP8u4Gq7RziP/ifq7OI4210hHdkQBUYcsE9co30qEneLRYLxIG3izFQacHkRmDV7q27whO0PcHnceaf23GgZ5RZdL61+DOzlRPyMa2useVgQ+71FYr8mqbmzdPQnep+68kvznAcMRucn5/16PjE7TOBgkoolwrRDA0Vr5znIxTaswaWExJ9d2h91/i16CgvfDFxn6tC9AFZO5SdxDWs6SEXTwH0wzilVhpHXJyez2zi0fmLTkNKGCqrqK7125R/HAZnsHqFVTs6IC8SDFdIxXc2+vYNx9u0Ev/ivqFvwdK5vhBfuc9+YnQfbhXxkIoDFz4JSJNOOl5jHQ7ceidb9PRnLqdQSYEQ== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(7416014)(376014)(36860700016)(82310400026)(23010399003)(1800799024)(11063799006)(56012099006)(18002099003)(22082099003)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: EAkBBtXVtaGRuL91z9NZhjMnxsYVWkop1Ik8Xg9+QYBl/bmIjeHyBD0uO0pfHNqVN7cAAM0kYy4DhxZL/+0h8UyHsWTrCYumiiqSQ9sB3cgTUxYdJT8TjlA5bt637BG23KIDl/hJyJxBewg9GW1N0dVVUK/0Jxww3xSOfhyfNsSr2LuQUF8mPAB8WP6trRuFLojYvTptkVbwFBybQf99Nnst+MslUXy1d2ze2UlHXCN12fFak1g4MZr0TccJhpI6AGvn8xb2YmlSn+ejdZdezovNslHfmpqkaUzLjVS8dbt7G25cb5pw2l9GQIxAosCs7ykEvJSX47T2F7IiSr3x9EYbIQxIS81fNCMKC7qZA0dfahQtmbnjSq39fmjiqE446jOnS7JQHhqEK/sYvJbFijc86AYID5BhQIqb0J2n5fDqkytofzYXT15oIUwHnFj9 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2026 09:54:54.9560 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca3187b9-4e80-4255-d6a7-08dee8a072c0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001EF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7719 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Remove duplicated setting of field in mlx5hws_cmd_rtc_create(). Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c b/d= rivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c index c04ac970705b..c645b7e4bd98 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c @@ -398,7 +398,6 @@ int mlx5hws_cmd_rtc_create(struct mlx5_core_dev *mdev, MLX5_SET(rtc, attr, update_method, rtc_attr->fw_gen_wqe); MLX5_SET(rtc, attr, update_index_mode, rtc_attr->update_index_mode); MLX5_SET(rtc, attr, access_index_mode, rtc_attr->access_index_mode); - MLX5_SET(rtc, attr, num_hash_definer, rtc_attr->num_hash_definer); MLX5_SET(rtc, attr, log_depth, rtc_attr->log_depth); MLX5_SET(rtc, attr, log_hash_size, rtc_attr->log_size); MLX5_SET(rtc, attr, table_type, rtc_attr->table_type); --=20 2.44.0 From nobody Fri Jul 24 21:52:58 2026 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012030.outbound.protection.outlook.com [40.107.200.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BE3F4322F9; Thu, 23 Jul 2026 09:55:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.30 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800510; cv=fail; b=MG9KqWm5ETQjC0k3SbYYfYSyQxkNNF5l45rMgOvuR0aeIVYU4Zy/0Xtk5cmhWp/Yf/POO/vlSP/+ncXmItEUIWYa9qoph6A6cI6UtM/lCHbUKAnZbOr8lNTHUXepAIfQRQTXhtbVBVjj4u7ayzSqIn8rWHN/nmylYIAV/eXETGk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784800510; c=relaxed/simple; bh=FJTS/B7R95jR5UHIsdsptKHQRMtpQG2tDbFLwhGKZHA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HNZkUmaxMC5vJFh6WDurngowm/CllEC0VMKLXyXHioaQ6OWXTL2xsYMp8cCfOIZI7DEIbYy5AITjTGisXnrVv8J8FBSRn4sTz2Jc0OuolOSLOsoq+GlgNpoZFQG9yUyz7izUcnpEae+JIFP57AVa8NZp1uNjA+8jaIXO3HhooUA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=WswOrRH8; arc=fail smtp.client-ip=40.107.200.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="WswOrRH8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CvERqhXtlJClkQ2F8vB0VlArG/BzdGih/xGdf9kfhAmEZwyq7Rz3IK6VKMuDIN7pbhgLn0vds3mOxnO4Dsa8reHjnU8KxMp3ARUzOYMa1/C3mbaL3sPzzU7zfITDIm8YYqfqDDRJPCnjrDU7u3MdkI/5WDk/L+OHWgodGOEz5HwAeo+lCgCnO3bOQp+EefWuMQA0tSFDJEMfczixKvqynEv9md9y+0SLMkSV7op78coKnXderC1m3dx0xwdm5oN7NMp+HibEmuuAlGNeK+Z6rd3ap6Svy3n2WanykVWlbrCrKHBaK2UVKilLUQtFln9YEaIcXDajmoRNsO1FztNKgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9jgfT/ZE9xqPDL60vfhbKjiojprsy9cdxhR2JdmPyns=; b=XaCWfzIRNUHNKIDN/uXvoB0S/gZ/FU2iUiQ/IreIpONEPT3lbVl/nKLBMJ57LI9DSqcVccHtwye7zbbTEV5M+pVB/E6ksNJN+wkw7Qi7Q72jDgWJGAEjdFSe0ypxmjpLRlbUf7O8dH+DbLyk8wRu9exdS8MKNQ3hEdTDM1+4a84T+GlwXFU58uXrL6qVECaYf5rar1JssxUmb6EOFq5xOXTG3rMHEeLyjN5ZuaE+7qLdQtYkwCpqCRw+kmMGUK5I/M7xVFNU20hJQeuAq6PWxQ/k1BcQaezLfeef3NQ1GRmtyxptWR24Mr1t0F8MgwSGOV0g/muzWw65tVsbZ2mrYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=lunn.ch smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9jgfT/ZE9xqPDL60vfhbKjiojprsy9cdxhR2JdmPyns=; b=WswOrRH8AF6Tv9i80LBKx5Z2c5dQNMDoAbC3SCLIUllboXoavRTg4uLnHgesDJcAX36/mUQGh/iexTnJDwVxNElP5uSXOrcb5HWlEh+4ppxxx/PXXSvid4kppztVwIbIn/YZZ7Rt33FKVKw6FJWHjq9Aw8+Gers70h7/BPsoJ1ZncUaUV7ya4vMB4R36p0TJdGD+Br87feVcJIUtYOIvIElMQGHRV5+7TsPXacB3LvkZFCWlFMgs4P1QaqZz0gRuH9CZidR+YV9Ns8gZ2gK8XUB4BkeQ783Ytn9NMik/YswH9zPBlE0BZmjMsOEYXI1qDHI6QtWO6NBYP6h2A9ev0w== Received: from BL1P221CA0032.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:5b5::11) by MW6PR12MB8835.namprd12.prod.outlook.com (2603:10b6:303:240::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Thu, 23 Jul 2026 09:55:04 +0000 Received: from BL6PEPF00022575.namprd02.prod.outlook.com (2603:10b6:208:5b5:cafe::71) by BL1P221CA0032.outlook.office365.com (2603:10b6:208:5b5::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.11 via Frontend Transport; Thu, 23 Jul 2026 09:55:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF00022575.mail.protection.outlook.com (10.167.249.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Thu, 23 Jul 2026 09:55:03 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Thu, 23 Jul 2026 02:54:48 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Thu, 23 Jul 2026 02:54:47 -0700 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Thu, 23 Jul 2026 02:54:41 -0700 From: Tariq Toukan To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , , Paolo Abeni CC: Akiva Goldberger , Alexei Lazar , Alex Vesker , Cosmin Ratiu , Dragos Tatulea , Erez Shitrit , Feng Liu , Gal Pressman , Kees Cook , Leon Romanovsky , , , Mark Bloch , Moshe Shemesh , Parav Pandit , Saeed Mahameed , Simon Horman , Tariq Toukan , Vlad Dogaru , Yevgeny Kliteynik Subject: [PATCH net-next 5/5] net/mlx5: HWS, Remove redundant FW command when reading caps Date: Thu, 23 Jul 2026 12:53:49 +0300 Message-ID: <20260723095349.1890983-6-tariqt@nvidia.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20260723095349.1890983-1-tariqt@nvidia.com> References: <20260723095349.1890983-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00022575:EE_|MW6PR12MB8835:EE_ X-MS-Office365-Filtering-Correlation-Id: e33c0056-9c5b-4c06-8e8e-08dee8a077cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|82310400026|7416014|36860700016|23010399003|22082099003|18002099003|10067099003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: jJbA8iZ0zjQnLalT2YGm6PRV+kTN7F8yIC0C6bBGlO7uIoprrcPXiTqWVPEmkN5ZNMjKRkbIU+YA50hyLJ4bhs7LVeMkc8eks+zL47i/9L0eckmg2JLt6bLyF8Rp3ugiZPlWhjdfv/ZdnfDnMXiSMsI6f6dDs+MJdBbH+Bh5I8xxpJ4+992+6Z52P5AznMNSFbQybZzpBxw7apjJYHZHz6qc89yexbi/Aj2MYsL5idVXGfOUyH/s6W60tQXHyAqxZMN1Btxrvf+AZZibM2b5d4p4/O5wEFtZRPO/PqHsog0c3okrjQcdgQvj3mFR7JzVxVicIAjd5ZCjlHy98TA8+lAJ245BB2ZxSXOi4dnHZ6g/YC9qf3YUJ+yoElg9uC4a5s1UtXDiONE8/O8NYHL7xd4MxriKdjgdAzIfpGcsGkH7rP+P0g43H7386/Jstwnj5PYYm7Urhq5vwXOtq3oB8TQ/VAiG8JvVR5+bmx2/y01ymhpTgqEbTvH0DI97BPSe7TXwJmNmUUJJtIMHkgOvNFZhDdCGyB05Jd77lkh+sIiRFwbQVJHXyxnsXNLrCUlG41yQErrbYc77D/uxWrnhl4YZBFa9nwyTMROu0Lnkt3WX/RSzIZpUnudRXY15UNb7rCeyE0x4U79nFJo+V1mzHKg0NWmVns0lmkkacTIpQYHogS+l5u94UXgH3sjb19jRLAqkGKXLY/c9SSj5+zw6bQ== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(82310400026)(7416014)(36860700016)(23010399003)(22082099003)(18002099003)(10067099003)(11063799006)(56012099006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: //uWMbYen64uCyIvaFoG5QNrUF0T8t5dAFVgNqKFK22YQ+XEQJcIJrCA3GhvzKSWpWMyiLnR9RD/hNssYccn+Rr83WnD4/GnCQsCn0ubUVZ8YvalU9BstpfbvZndgJVObLheqom73rQqrS96cLAqx2MKqO/NpZRS+WCYphykxXIvrFC2y48dp/F9yhxSKJloNz3mHhBWj6+y76kJeQaHumxD3OUDe4SnNQI95dqmPwgWjyl4lXG96bCgiPZOgbOCP7iFcqqXmBXQOi8QC7g9iMTjU2tclJP/11oKAXcxgWMPUSoJP9CR/SOjmmDfeQG8AoOA/6LdHtQe8W9CB0MugnEcPj7jG7KoWTrET0e11QqcGqyd7x/08ejtTM2krNTfiDuG6kJLBFHIOd+4z6sD5Str+f+FEn7bY9nXZniUG8Zd7XdMzE00d7m3m4zB/jxS X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2026 09:55:03.3762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e33c0056-9c5b-4c06-8e8e-08dee8a077cd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00022575.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8835 Content-Type: text/plain; charset="utf-8" From: Yevgeny Kliteynik Remove redundant FW query that isn't really in use. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Erez Shitrit Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c b/d= rivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c index c645b7e4bd98..afe5818294d9 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/cmd.c @@ -1182,12 +1182,6 @@ int mlx5hws_cmd_query_caps(struct mlx5_core_dev *mde= v, capability.esw_cap.merged_eswitch); } =20 - ret =3D mlx5_cmd_exec(mdev, in, sizeof(in), out, out_size); - if (ret) { - mlx5_core_err(mdev, "Failed to query device attributes\n"); - goto out; - } - snprintf(caps->fw_ver, sizeof(caps->fw_ver), "%d.%d.%d", fw_rev_maj(mdev), fw_rev_min(mdev), fw_rev_sub(mdev)); =20 --=20 2.44.0