From nobody Fri Jul 24 05:22:04 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75F6D3BCD04 for ; Thu, 23 Jul 2026 06:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784788999; cv=none; b=EZC5cSLcvW9aVxuO+G8+yHnNQR0CNVUrsCFvGAaW4REex0Mco5ZM7tIh8Jg0ha3HNNwYGkg+abMW0p0ewDe3O5cBjThUncRCNw2+ShtWU0HiLYYe+2RZHWWoxSikFDneYTdhBqVeutqlMQNAkxpjpYoVAyVYCfMLONcVWRhmSjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784788999; c=relaxed/simple; bh=DFKhnqtY0aNYV2eR9lPnEc+ekJprQ8SVzkvbIn6H5mA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=B1h9hi5X0VokUU5WYMIw2Qz8ggttZhGMgsRi/Q2IMnuiN57A0z8mR3gUMxJW56jZPG/Q/BMgCg2yOtlVEg4mYp10A0ETdcQ5FltPMyyneXp25FLwofeMB15O9FngVlIouQa6sqLaS6ikIbIRCGfta3BmoXRKiJCY0nAGILeVD0s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hLZg6/83; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hLZg6/83" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-38dc69c74b8so258728a91.0 for ; Wed, 22 Jul 2026 23:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784788995; x=1785393795; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=iFJBH+l6Rr0QnYtUEX9bQo9WQo3rO+vvwx8dfmQ65rQ=; b=hLZg6/83XChXZJb89ZE0Qyc9+LO0LKJnBUxencH/yrTZVvn12T7t2ikGF0MipBzdmB AyZHH9mvvgRzLjHv04CAVfl3oAH164iRVBdIzEVyxYd4wE7F0pYsxmwJ2AAJR2zaj0YV zrnScm+VzpAOT1EzuOnvgLS5mUOMzztQ8Xy9z8AlOD4TLzZLo0Bf/ng+FnKrsnLB0Nc8 ZndYS9M63pmlMV3Rrws+TiWhHFHsyNQJZn05MGgQnJftC/nykOnUvx8Zkj5oqDWNx36b 93crLnhXn6nwmmmlAMv0I2eC399uWh1WjL0lnqINc/EwxDGU5qc53cMUzQphG0pLVzKc tJQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784788995; x=1785393795; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iFJBH+l6Rr0QnYtUEX9bQo9WQo3rO+vvwx8dfmQ65rQ=; b=Ilg/BYrYqTuTa+4nKg5oWGYYuzyHidoPKgi0w7KKP3VehQksbTu/EMJNcNhSMDoC/I CdRG+tVFDwDg70SlgLTM8JXdEcf4j73KgpuiRQVp1oWuBYeotwUdqqyglsvHAGrWrrcz ap8TiwrMOGWs/JBZ2ZC3vHGJSTm79f9NvVgNnLxI69InSkhkGe8jOZn2bet2yFqfbZw+ gXSYvGgEQu3PWWYQJGrC849ZImOvPaS5PdqnBRYvf5zvkMqppp/lXTfLMaDJriiQfCI/ VE5E1seT9y+Z7d8hrO6WZsAwBCybW/Z151fF6XuUtQzlZiIcFq+/R3EgVAuXf2sWnILF xqpw== X-Forwarded-Encrypted: i=1; AHgh+RoV/4FtS73uKZkt03ffLJ6C026RRY/IYinA1iNbPLbkGDtqM2keaPhJf1WwLM4/ye7Sbh9V7FMPsxcVjw0=@vger.kernel.org X-Gm-Message-State: AOJu0YzcFxIo7P5VPsKQGRggEqJZUY/q7ZuCeG/GkiaoPJQiB9aO7qGn A7fAYC+FHm5CYtMfgiDASnbQMWa4HDTqvrrWvPzT+COg0NbMqO6kPaLs X-Gm-Gg: AR+sD10JLaVDKyAPIZ1keBKd5NqvqZrB1XC8/9QlF3dQ3FDJ9SJITtNqI4mK4xJy+6w yj4GPpgGNrLLtRSfPtsN9bgQjhUPuEgNNM5ybjn755n7LIICT6gC2b3ZZfALPrFccwZH3P5mjI1 bw0DCEkK+AQiRrG3BRbwJeeH3uB8JWk3H8WhtQ3Q6RGdC/qGeet1c8nLJ3i1d/R2CyYXnwD9pwE YpSrwMzBjEwcQX1r348UGbwSoPK8OfhfNVOL6Z1VJ7z9I9fe+v7jHzIdOpeSj/ezUgxgF/M/pI9 NXCd9lwEuy5Skczh/bGgITmCrbzgqLNglaQ+I+IELhcYqaIhV4wQcXO//k5+VEog6coT1mY8qLo xLWWzbHUBS3OoFRcwx6/xxkact4r7d5ArYQm01VcWbDQ5NYDV50RMQnup+POfjcxL/+21CqD7ix EGzNXbjxgduxTi1Ecia38= X-Received: by 2002:a17:90b:4d91:b0:38e:76f8:fcbf with SMTP id 98e67ed59e1d1-38ec6a842b9mr1661047a91.31.1784788995132; Wed, 22 Jul 2026 23:43:15 -0700 (PDT) Received: from kernel ([45.251.35.26]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13d130ce035sm12643420c88.13.2026.07.22.23.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 23:43:14 -0700 (PDT) From: Mohamad Raizudeen To: bhelgaas@google.com Cc: skhan@linuxfoundation.org, jkoolstra@xs4all.nl, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Mohamad Raizudeen Subject: [PATCH] PCI: Fix 32-bit config write in Intel RP MPC ACS quirk Date: Thu, 23 Jul 2026 12:13:00 +0530 Message-ID: <20260723064300.8081-1-raizudeen.kerneldev@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The pci_quirk_enable_intel_rp_mpc_acs() reads a 32 bit DWORD from the MPC register, sets bit 26 (INTEL_MPC_REG_IRBNCE), but it writes it back using pci_write_config_word(). Because bit 26 resides in the upper 16 bits of the 32 bit register, a 16 bit write to offset 0xd8 completely drops the newly set bit. The quirk logs that it is enabling IRBNCE, but the hardware never actually receives the command. Fix this by using pci_write_config_dword() to ensure the full 32 bit value is written back to the hardware. Signed-off-by: Mohamad Raizudeen --- drivers/pci/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index b09f27f7846f..0d0cf6f86173 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -5361,7 +5361,7 @@ static void pci_quirk_enable_intel_rp_mpc_acs(struct = pci_dev *dev) if (!(mpc & INTEL_MPC_REG_IRBNCE)) { pci_info(dev, "Enabling MPC IRBNCE\n"); mpc |=3D INTEL_MPC_REG_IRBNCE; - pci_write_config_word(dev, INTEL_MPC_REG, mpc); + pci_write_config_dword(dev, INTEL_MPC_REG, mpc); } } =20 --=20 2.53.0