From nobody Fri Jul 24 05:21:42 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC417344D9D; Thu, 23 Jul 2026 05:08:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784783322; cv=none; b=XAUkVbwbPUeezkKaznFUH2Emj1d1cuzS19yvNnkajuZF+OhfM3b0xJ/ncHIu49i+LvUAQrJibZrM5LEvNAl2hCt7/ieC5MXftmFbhe3zAlvQx0M6EChjmhghLi78yDcv1KTc1EFu/akQPdKj+GwPrrnhBh7V5uEcDogNi+s/fTg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784783322; c=relaxed/simple; bh=685cKvKIaaJawmbnJ/7KQ9c2DK+5CR0l6HLwNXL1SSQ=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pzWKGFxXJq+qm9FDBHp5t+CHJRAMEOZCTl4RxXh9rZ7ub47Z0Dqc2+ko2fj0+XSaMb1u6LBXdYp1BToYTmK86zHIYs/a0S6hhFHbmhJIMtCsCguPEDfu+qbcf5TvYy9GsPNm5LT0fDbm8Bovx2edQtUpCqJV/ny90JecnKEoHCY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=dewSoMQP; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="dewSoMQP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1784783320; x=1816319320; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=685cKvKIaaJawmbnJ/7KQ9c2DK+5CR0l6HLwNXL1SSQ=; b=dewSoMQPg7Nb8ixumQOHrwZl/cOvzEceSC9rqxBTmn1YYJJED0BqF7fC yvhkNLZGEB78qe/tVvU+asClIpQPwhdTWbX5MONWFVZsRiQ0pgbFcVWrm +ltpob5lAau2yMdVkRmMjhJeNZEpA16l4LnYpigHjMf9RdweaX5YSQNTY LWojWa2B3iswT6Z6V7Srrzxhkzdm3YHB32kHKttGBr7eLrPAHjitqC3Hr MiUYcR0/2tCy94vZstNtZ+4Tmyjpzdu4bkPKVLsfCwCFUWGnLe6tRUtIS f08TKZtSnSIuyplMHODrsgNobsN1r2rs+k3jkajaAb0KUPT+dbgUw2lJ7 A==; X-CSE-ConnectionGUID: wxzQMndyRxOZljPjBOMKfA== X-CSE-MsgGUID: spDzIDAxSUSbnHX31cq35A== X-IronPort-AV: E=Sophos;i="6.25,179,1779174000"; d="scan'208";a="60182062" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Jul 2026 22:08:40 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Wed, 22 Jul 2026 22:08:40 -0700 Received: from che-ld-unglab06.microchip.com (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Wed, 22 Jul 2026 22:08:37 -0700 From: Thangaraj Samynathan To: CC: , , , , , , , , Subject: [RESEND PATCH net-next v5 1/2] net: lan743x: add RMII strap status detection for PCI11x1x Date: Thu, 23 Jul 2026 10:38:26 +0530 Message-ID: <20260723050827.694832-2-Thangaraj.S@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260723050827.694832-1-Thangaraj.S@microchip.com> References: <20260723050827.694832-1-Thangaraj.S@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Thangaraj Samynathan Extend pci11x1x_strap_get_status() to read the RMII strap bits from the STRAP_READ register. The is_rmii_en flag is initialized to false and updated based on the hardware strap only if SGMII is not already enabled. This ensures correct interface identification during adapter initialization. Update the netif_dbg() to report the selected interface as SGMII, RMII, or RGMII. Signed-off-by: Thangaraj Samynathan --- drivers/net/ethernet/microchip/lan743x_main.c | 12 ++++++++++-- drivers/net/ethernet/microchip/lan743x_main.h | 3 +++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/et= hernet/microchip/lan743x_main.c index e759171bfd76..3a418105cd11 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -42,6 +42,7 @@ static void pci11x1x_strap_get_status(struct lan743x_adap= ter *adapter) u32 strap; int ret; =20 + adapter->is_rmii_en =3D false; /* Timeout =3D 100 (i.e. 1 sec (10 msce * 100)) */ ret =3D lan743x_hs_syslock_acquire(adapter, 100); if (ret < 0) { @@ -73,8 +74,15 @@ static void pci11x1x_strap_get_status(struct lan743x_ada= pter *adapter) adapter->is_sgmii_en =3D false; } } - netif_dbg(adapter, drv, adapter->netdev, - "SGMII I/F %sable\n", adapter->is_sgmii_en ? "En" : "Dis"); + + if (!adapter->is_sgmii_en && strap & STRAP_READ_USE_RMII_EN_) { + if (strap & STRAP_READ_RMII_EN_) + adapter->is_rmii_en =3D true; + } + + netif_dbg(adapter, drv, adapter->netdev, "Selected I/F: %s\n", + adapter->is_sgmii_en ? "SGMII" : + adapter->is_rmii_en ? "RMII" : "RGMII"); } =20 static bool is_pci11x1x_chip(struct lan743x_adapter *adapter) diff --git a/drivers/net/ethernet/microchip/lan743x_main.h b/drivers/net/et= hernet/microchip/lan743x_main.h index 1573c8f9c993..1f8d9294a6ef 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.h +++ b/drivers/net/ethernet/microchip/lan743x_main.h @@ -36,7 +36,9 @@ #define FPGA_SGMII_OP BIT(24) =20 #define STRAP_READ (0x0C) +#define STRAP_READ_USE_RMII_EN_ BIT(23) #define STRAP_READ_USE_SGMII_EN_ BIT(22) +#define STRAP_READ_RMII_EN_ BIT(7) #define STRAP_READ_SGMII_EN_ BIT(6) #define STRAP_READ_SGMII_REFCLK_ BIT(5) #define STRAP_READ_SGMII_2_5G_ BIT(4) @@ -1072,6 +1074,7 @@ struct lan743x_adapter { struct lan743x_rx rx[LAN743X_USED_RX_CHANNELS]; bool is_pci11x1x; bool is_sgmii_en; + bool is_rmii_en; /* protect ethernet syslock */ spinlock_t eth_syslock_spinlock; bool eth_syslock_en; --=20 2.34.1 From nobody Fri Jul 24 05:21:42 2026 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B9EB341ABB; Thu, 23 Jul 2026 05:08:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784783328; cv=none; b=XRKqSv1rtK83cZApnuUjaxsDjDnjGyHMSlAOg/ybnm+2eiikNDIiJm4BQ7mS8NVA8t2L+BOdqzf7I/frBlB2lJXVkLX3gvUqf257vgAXN3ftGvRHYU12A6FVBCRPWw1HEXxXXRekrAxzljpk4uYuZyKaDfzX0TNarNF+WuyIsgs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784783328; c=relaxed/simple; bh=FjZ7hwck9Hacj/PcUVKtD8C9FfuKObhd9X7BROUX/es=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RAxZBvfP+mLZ0lTch7b/HEUCso03xGsKINyscbqTHGukXyuI9s23OH3POkZXOIEfLGgkC9e0PnlhB6EsqspvcBz1SusjbuY4i01/4PMLWw4u1cablOYD+95O+oRnb0KJWZMzeQAzKVpTg6Mg71guYZ4s2Ye+OI/DPlR/h3nF4Xw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=F95MHUCC; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="F95MHUCC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1784783329; x=1816319329; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=FjZ7hwck9Hacj/PcUVKtD8C9FfuKObhd9X7BROUX/es=; b=F95MHUCC5rwAF23+Q/eDxKz+TJ/37Gv7PYdaCxn/wNf6hS5Ze4351baG T5UdtAIxTr/NKS9Fhkc7hqu90UFCJDrexfnVz8kPj6tRiEVAcm55vtrDX OmqgNBnJd3BwnExM/ahjKU0wfZUiKXPbT/XF0f6QbfvsFqLqg8yo63/V3 nbrmryGxhmhzoXiZ6Os0j37jOCOqcLzphTV8otUr/XgEcfy4QJrDxLIJ3 s4V4u2bYQdIbaIT32rpYWYQXbf0Om6vOGmakUwU7JA1AQmQP+1kBKOdH6 QUZwJ27FF3M8SuTQKvJ/4SuZmrEh/CPq/Je110RYUkH4oHIsZ/dJ9MHiG g==; X-CSE-ConnectionGUID: NzAPWS/kTjOC8nn1DKwDvA== X-CSE-MsgGUID: MOLn/xMdTba9jLgu1gtcUQ== X-IronPort-AV: E=Sophos;i="6.25,179,1779174000"; d="scan'208";a="292422643" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jul 2026 22:08:48 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex1.mchp-main.com (10.10.87.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.43; Wed, 22 Jul 2026 22:08:45 -0700 Received: from che-ld-unglab06.microchip.com (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.58 via Frontend Transport; Wed, 22 Jul 2026 22:08:42 -0700 From: Thangaraj Samynathan To: CC: , , , , , , , , Subject: [RESEND PATCH net-next v5 2/2] net: lan743x: add support for RMII interface Date: Thu, 23 Jul 2026 10:38:27 +0530 Message-ID: <20260723050827.694832-3-Thangaraj.S@microchip.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260723050827.694832-1-Thangaraj.S@microchip.com> References: <20260723050827.694832-1-Thangaraj.S@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Thangaraj Samynathan Enable RMII interface in the lan743x driver for PHY and MAC configuration. - Select RMII interface in lan743x_phy_interface_select(). - Update phylink supported_interfaces and MAC capabilities. - Enable RMII via RMII_CTL in lan743x_hardware_init(). - Define RMII_CTL register and enable bit in lan743x_main.h. EEE is not supported with RMII on PCI11x1x: the hardware does not implement LPI signaling over RMII. Clear RMII from lpi_interfaces to prevent phylink from enabling EEE on this interface. Signed-off-by: Thangaraj Samynathan --- drivers/net/ethernet/microchip/lan743x_main.c | 23 +++++++++++++++++-- drivers/net/ethernet/microchip/lan743x_main.h | 3 +++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/et= hernet/microchip/lan743x_main.c index 3a418105cd11..24ae56a3c9ed 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -1402,6 +1402,8 @@ static void lan743x_phy_interface_select(struct lan74= 3x_adapter *adapter) =20 if (adapter->is_pci11x1x && adapter->is_sgmii_en) adapter->phy_interface =3D PHY_INTERFACE_MODE_SGMII; + else if (adapter->is_pci11x1x && adapter->is_rmii_en) + adapter->phy_interface =3D PHY_INTERFACE_MODE_RMII; else if (id_rev =3D=3D ID_REV_ID_LAN7430_) adapter->phy_interface =3D PHY_INTERFACE_MODE_GMII; else if ((id_rev =3D=3D ID_REV_ID_LAN7431_) && (data & MAC_CR_MII_EN_)) @@ -3190,6 +3192,12 @@ static int lan743x_phylink_create(struct lan743x_ada= pter *adapter) __set_bit(PHY_INTERFACE_MODE_MII, adapter->phylink_config.supported_interfaces); break; + case PHY_INTERFACE_MODE_RMII: + __set_bit(PHY_INTERFACE_MODE_RMII, + adapter->phylink_config.supported_interfaces); + adapter->phylink_config.lpi_capabilities =3D 0; + break; + default: phy_interface_set_rgmii(adapter->phylink_config.supported_interfaces); } @@ -3197,6 +3205,9 @@ static int lan743x_phylink_create(struct lan743x_adap= ter *adapter) memcpy(adapter->phylink_config.lpi_interfaces, adapter->phylink_config.supported_interfaces, sizeof(adapter->phylink_config.lpi_interfaces)); + if (adapter->phy_interface =3D=3D PHY_INTERFACE_MODE_RMII) + __clear_bit(PHY_INTERFACE_MODE_RMII, + adapter->phylink_config.lpi_interfaces); =20 pl =3D phylink_create(&adapter->phylink_config, NULL, adapter->phy_interface, &lan743x_phylink_mac_ops); @@ -3541,6 +3552,7 @@ static int lan743x_hardware_init(struct lan743x_adapt= er *adapter, { struct lan743x_tx *tx; u32 sgmii_ctl; + u32 rmii_ctl; int index; int ret; =20 @@ -3562,6 +3574,12 @@ static int lan743x_hardware_init(struct lan743x_adap= ter *adapter, sgmii_ctl |=3D SGMII_CTL_SGMII_POWER_DN_; } lan743x_csr_write(adapter, SGMII_CTL, sgmii_ctl); + rmii_ctl =3D lan743x_csr_read(adapter, RMII_CTL); + if (adapter->is_rmii_en) + rmii_ctl |=3D RMII_CTL_RMII_ENABLE_; + else + rmii_ctl &=3D ~RMII_CTL_RMII_ENABLE_; + lan743x_csr_write(adapter, RMII_CTL, rmii_ctl); } else { adapter->max_tx_channels =3D LAN743X_MAX_TX_CHANNELS; adapter->used_tx_channels =3D LAN743X_USED_TX_CHANNELS; @@ -3628,8 +3646,9 @@ static int lan743x_mdiobus_init(struct lan743x_adapte= r *adapter) adapter->mdiobus->name =3D "lan743x-mdiobus-c45"; dev_dbg(&adapter->pdev->dev, "lan743x-mdiobus-c45\n"); } else { - dev_dbg(&adapter->pdev->dev, "RGMII operation\n"); - // Only C22 support when RGMII I/F + dev_dbg(&adapter->pdev->dev, "%s operation\n", + adapter->is_rmii_en ? "RMII" : "RGMII"); + // Only C22 support when RGMII/RMII I/F adapter->mdiobus->read =3D lan743x_mdiobus_read_c22; adapter->mdiobus->write =3D lan743x_mdiobus_write_c22; adapter->mdiobus->name =3D "lan743x-mdiobus"; diff --git a/drivers/net/ethernet/microchip/lan743x_main.h b/drivers/net/et= hernet/microchip/lan743x_main.h index 1f8d9294a6ef..d9495cf96b41 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.h +++ b/drivers/net/ethernet/microchip/lan743x_main.h @@ -325,6 +325,9 @@ #define MAC_WUCSR2_IPV6_TCPSYN_RCD_ BIT(5) #define MAC_WUCSR2_IPV4_TCPSYN_RCD_ BIT(4) =20 +#define RMII_CTL (0x710) +#define RMII_CTL_RMII_ENABLE_ BIT(0) + #define SGMII_ACC (0x720) #define SGMII_ACC_SGMII_BZY_ BIT(31) #define SGMII_ACC_SGMII_WR_ BIT(30) --=20 2.34.1