From nobody Fri Jul 24 05:21:29 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 075FE256C84 for ; Thu, 23 Jul 2026 05:06:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784783171; cv=none; b=CBH5g2vAH3xFqxSkoDD6RL225j4d9e/dk+qZ5QU/xmLGXrXgHwtGEHaxSX/qnVF/as8bmKMaaG3ki+sbO2UnKvMV0hT3YoRpOxqORgmglr1hR5SOPvS5DHaZDGrPzInslMufLC2YlD2PQVXWPpALB/fMJerRY7vhFDzwwia14h4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784783171; c=relaxed/simple; bh=2fXuHKme6drbp9qxm9DooDlMKSKL7xE7RIRVe/fmm9w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=AizZ4/Fg4b8+bvH7DQcX84aIBnN6OS0O+DvzZ3g6UmWgoD/PuUq8WTPn1ZDivSqpY2DsBhdL96B5hxDF5UFgN+hsCgVv14zknUXz+4dzinP1fW2yGvOZ2KUuOxZsrPfe86ZbUTA717uGDmB++AKXw8SXGfRmBoTHQKR/tcfvRHc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=das/tErc; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="das/tErc" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2cab973140bso3129815ad.3 for ; Wed, 22 Jul 2026 22:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784783168; x=1785387968; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fskRTNmKCHuMx7B3elKsJMyK2dJDvII2EXTM/GUSwAI=; b=das/tErcaLNlGgKU8TNyvNgDokuePnw4stEiqg8wLbO8eOw8foxGfYzGQ3knYN2OoU nq+ZZIi8+CwiF0PHGwjrlAnMRwn0wEYCgtauePMYOtyT7hvz7ye4bydFXf55sMNsORjz 3HVqwA4+i5VARRBnLxIq8gBIJQ+LG5l/FLLLw7A7OGnZI7tYRMT7QX3RPHHAW6LruTUt FyxeBuQbFynoqMm3+SVTO4yzkX/K2Jtca73zcZ4vdOM0QdABtYfspxXit7BassOYO2hC FB476VeSUSOaeOyHSxnjfMMAevQeqt9ptp+5qu/7hO2a50kIfQkHF2xO/37Mzua4ML1J 0KvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784783168; x=1785387968; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fskRTNmKCHuMx7B3elKsJMyK2dJDvII2EXTM/GUSwAI=; b=CDEgeIuuv5ll2JLC1tmOqPGRb7pETZGLkeCiocXWFwdA3AZolP6LqOGpuPyxkUIVuo CvhHdOnLmkbux3d3pYYlrJ/HlbienBTg4JYiHq0de10fFJ7mY9s13RmbYiWivQUvad36 mz0Pg5vH/xn3b4lR3jxLwIqo3HUqrJ0Fcj+xe7WUSl9bvADYg7OGNPs1Abd6qVB1QsjB GlJQWDA1rcQrrLdy8DbrLs/lUAcLgugIApCLx0Y42hycENi3Tx5W2jZUfyPUOqB7Pyb4 0MBbLxTmGMfgLMK2kSWN3E7lzWn7H7EcU1t1W3GwkpQD5TVqowLZoAUVDqaoACZMBAX5 cZ/Q== X-Forwarded-Encrypted: i=1; AHgh+Rq5U3dwk1ShRbKjMUn39jrXvvb7KSDL1jgqgsI3mSVEdMXDJj/LKy3Xkl446IWAnSmBK5kE6uiyM7Z2bXI=@vger.kernel.org X-Gm-Message-State: AOJu0YwNj57C84Sv1CBBvqrYn0rFq7Pb7CppuccEEoxi7lB3XDtwslIV mW7R1cH6L01hDNeb/YKbgqMMcZNuZue0BQ0J4Xkf5PjbJ+1LKa/CakLD X-Gm-Gg: AR+sD13NSRdT/R2q3PtI5mmPpvv1m5swiQtvk3KuVapmD0tMhqUizbDAqJ+biQgpvrG YYwzAvVgNySigfQv6Y8tdsktf6b2fs+I7+ifEVIKoDd42tLLG4fzMKZMFYLOl3vuopYOtiPJPFM MSIrfB5AGrVfKTxD9yFQNuIxc+hjIYhN98i2W+AiyX0VjKjQPs15GSLczgBQ1qcI+C0WII9YM44 WTfMB6J+lhsxqzrFGLE7aE3HX2NoxLsJTYOyYscrkjqFr6Ri3mcCMZItU37Yxm7DkZhfz0LR2sM Uv+c+MabLeKHtRHhIDuU4A3yLSBZ+t2+TmQl2ZvDvlrWLkhcbdQx6a/IiIPsl7HrIwGDf/6M4Ph 2tkNEKPkpBibp4sM9iZwjxv3s9q0RSMjqH7bvJ8yleuPkvJoJMqeP7/n6wDSalO5EhgZ7aoC1D/ hDIrGwn2I+goVCbP1St6c5qISZiM9IGHRLKts9p00LYqjnptIXWJpaAj3WPh5lYqArhP1hsFEaK f1qYII/7cBF6g3+yF4JcpxMXIdQvL0UpF3S/1LdtDICf7t0/6i0Tmc= X-Received: by 2002:a17:902:fc43:b0:2c9:97a7:3276 with SMTP id d9443c01a7336-2cfa6c87f9fmr20526865ad.39.1784783168285; Wed, 22 Jul 2026 22:06:08 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e34]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf8f3b46absm25427275ad.80.2026.07.22.22.06.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 22:06:07 -0700 (PDT) From: Rosen Penev To: dmaengine@vger.kernel.org Cc: Ludovic Desroches , Vinod Koul , Frank Li , linux-arm-kernel@lists.infradead.org (moderated list:MICROCHIP AT91 DMA DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] dmaengine: at_hdmac: ioremap and get irq early Date: Wed, 22 Jul 2026 22:06:06 -0700 Message-ID: <20260723050606.283453-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The functions can return -EPROBE_DEFER. Call them before anything else to avoid doing extra work. Signed-off-by: Rosen Penev --- drivers/dma/at_hdmac.c | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index e5b30a57c477..2f6f5877fc3c 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -1943,11 +1943,20 @@ static void at_dma_off(struct at_dma *atdma) static int __init at_dma_probe(struct platform_device *pdev) { struct at_dma *atdma; + void __iomem *regs; int irq; int err; int i; const struct at_dma_platform_data *plat_dat; =20 + regs =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(regs)) + return PTR_ERR(regs); + + irq =3D platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + /* setup platform data for each SoC */ dma_cap_set(DMA_MEMCPY, at91sam9rl_config.cap_mask); dma_cap_set(DMA_INTERLEAVE, at91sam9g45_config.cap_mask); @@ -1968,13 +1977,7 @@ static int __init at_dma_probe(struct platform_devic= e *pdev) if (!atdma) return -ENOMEM; =20 - atdma->regs =3D devm_platform_ioremap_resource(pdev, 0); - if (IS_ERR(atdma->regs)) - return PTR_ERR(atdma->regs); - - irq =3D platform_get_irq(pdev, 0); - if (irq < 0) - return irq; + atdma->regs =3D regs; =20 /* discover transaction capabilities */ atdma->dma_device.cap_mask =3D plat_dat->cap_mask; --=20 2.55.0