From nobody Fri Jul 24 05:21:29 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE3F6351C3B for ; Thu, 23 Jul 2026 02:29:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784773794; cv=none; b=ulr8wODOzHfCohThGN7/GSyUR4sZIGrKXMWDJbUcZkjQ3weMYILi5K0c2drdYUcikehhUNJn+mfpowLQxXUgURdpIZE47duxaygGg2VZ27ziEw1Cs8EuiP2II4GZSeYcifdzfdz0pj2XHgXCFmXVwpUINW8Zn2g5eLJuKyc26d4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784773794; c=relaxed/simple; bh=NEg8NOM/txKpAiZI/WqqPFojv7JAFOLUG5hsaOzejZs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hKBRWvf2BGJ6pgo8GotKqhn0QbN52Wf/5LnmkzjQhFWCW4X4D9yTQ0enWpL0saSyjX0R//rO36+n6F4VFFscnPtq0BrCv+5xNoKs7jPwkDwaDJ6ppp+30nwZEeXPurZZy1SXzp/+BgTU8RpOC2SjyS3e9lxNtPVN75qqWV8tXws= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ENha5fJ6; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ENha5fJ6" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c9e7391839cso161845a12.0 for ; Wed, 22 Jul 2026 19:29:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784773792; x=1785378592; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=QinkvqfI7+Jiy6Z4UIF5B3VN+ppmenjr+Bmdci/f1Dk=; b=ENha5fJ6LOw5OzuJEm/50of8KEHGyUUvOyp2KMTsHZ41DWaUtrabffkQPhxZP+8GyL gVqlq1tGFuPXCdZ47QiUJGbLt8OQxkBTwiJ4EdO4qefZMJnhW8XMEQFQgTMf6xPixNfM h5VQNCDjJSsc/Vw3iClQncjKz2jV8INKlMzx3dQVSu8k6kp8iszyjoprh9BP4IjLeUYe KXFmd3A5IUjiaHIaV7TaCI6vexw5sFo0mKMsRRKlD95NhU/A9nMNs1dtXzxOTWzbSZ09 JmFp0yCxCTHFNjBkqJoL6gfO+ulIavfkdgOokEnNidB0JUo9Or4mr03o1rAM/zYl2SAY tTaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784773792; x=1785378592; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QinkvqfI7+Jiy6Z4UIF5B3VN+ppmenjr+Bmdci/f1Dk=; b=I46eRhtdxp5dcJE9+Hr2o2Xmw8Js6sQ/r7So148U45u4RkpWH87zv9KU97PPjZgfzW rrDlCWmnZ9Ocn3VamZxPM/BYjFR6Gkaq78SBpRxg1X6U2FPqm77VGXXicyd5ys2ku+aV aTSpBEge/IQOlweNgjD1TjHoKaIZiXtxr96lrcrCYJPdC++bO1b0hzPwhDB3NVbNbB5x MmuPyolbSIjNcMNknDVfPJMj5Thn7CwRytj77A41kJbJfRse5yED3vBUE4hpaH6yKBhB gKz8pxv2G4gk4Igi3LNDPxjQqMKBP6Orv7sT3siccJftCp8VGdmYc4eXU9e+VgDhom2v ce0w== X-Forwarded-Encrypted: i=1; AHgh+RoUyVswjjB/Aeic9uDjKtSYh83gCP9CTADPzylgkaNFAsn2BopHW7M+jYA68Eo4607LUtgaU9qDnGDJK54=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8GI5Hniq851CDD4ThDd2AIdD/aLFABZg5uEGV6Y8vYkyoM9sr m8BM4npBnGOSexUz+vtQoAwZ28+ryBz/wLtDF0n2dgRN2icBC2himIpXIHN8Fs8= X-Gm-Gg: AR+sD13PkUbvc/+VY9OQsfbu1jTJHAc1/s97LWeh5KHM6skmagD05mXxrUrWKcMRlS5 4IxsyoraKiSCqlGVPp2XtXyO9bAxpTNFl68L+T6akjTee8chXIP+I4AS3/q6LUMrnyIAZ14bfGs qBdZ8qGx+iw46K+Ou2wXk4VNBWJrj3aByEsXRSf32SNDmoDxopuPYND2QTQv3eggrG+wqB9mfl3 Lx1/cRDj4Elf3Abuh4/Ldf3kCbccIeYs4I+IvpArIVLy08b0C3Arq5wIa33k3wSGzWrM4GBaFXH bDHwC4zp1ZzPTdjj5ASs8DhBxcC0Cif2tudN4Xcc/H2GuG6UUrVorjwUPqWfS56VpfOGqYud0Li 7A6HkGV+phJFaEfUzsyxbb0T/SaLgxmo8Q9ypAlSG95SxqvOp5Z8YM4Knh3lws9/znI0j8i/ZhN kHLJAQb8LsIDWlVcOmZkarQCc7 X-Received: by 2002:a05:6a21:9090:b0:3c3:859b:9178 with SMTP id adf61e73a8af0-3c44b059c7emr1224805637.34.1784773791971; Wed, 22 Jul 2026 19:29:51 -0700 (PDT) Received: from t-rex ([2401:4900:addc:f847:290:7ec:f519:db36]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147e1c9289sm14127773eec.29.2026.07.22.19.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 19:29:51 -0700 (PDT) From: kr494167@gmail.com To: hvilleneuve@dimonoff.com, dmitry.torokhov@gmail.com Cc: andriy.shevchenko@intel.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Surendra Singh Chouhan Subject: [PATCH] Input: charlieplex_keypad - check gpiod_direction_output() return value Date: Thu, 23 Jul 2026 07:59:43 +0530 Message-ID: <20260723022943.9337-1-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Surendra Singh Chouhan charlieplex_keypad_scan_line() currently ignores the return value of gpiod_direction_output() when setting the active output line for scanning. If setting the GPIO direction fails (e.g. on I2C/SPI GPIO expanders or hardware errors), the function continues to sleep and read input values from an improperly configured GPIO line. Fix this by capturing the return value of gpiod_direction_output() and returning the error code immediately if it fails. Fixes: 2ca45e57ea02 ("Input: charlieplex_keypad - add GPIO charlieplex keyp= ad") Signed-off-by: Surendra Singh Chouhan --- drivers/input/keyboard/charlieplex_keypad.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/input/keyboard/charlieplex_keypad.c b/drivers/input/ke= yboard/charlieplex_keypad.c index d222b622c820..d46a2298e6da 100644 --- a/drivers/input/keyboard/charlieplex_keypad.c +++ b/drivers/input/keyboard/charlieplex_keypad.c @@ -77,7 +77,9 @@ static int charlieplex_keypad_scan_line(struct charlieple= x_keypad *keypad, int err; =20 /* Activate only one line as output at a time. */ - gpiod_direction_output(line_gpios->desc[oline], 1); + err =3D gpiod_direction_output(line_gpios->desc[oline], 1); + if (err) + return err; =20 if (keypad->settling_time_us) fsleep(keypad->settling_time_us); --=20 2.55.0