From nobody Fri Jul 24 22:18:15 2026 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B7E928CF4A for ; Thu, 23 Jul 2026 01:55:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784771718; cv=none; b=S7kebBdSJ0KbZoJBL3bKmRkgoZcbMXzp0XFvy8+iuHwZAq/5YE4U7PIaTGzD2eNXgKzbE9Ok7MKn1FQF6he9MUzs1pshX4BZT8UgZ4a6zmHmMQrdYEvEoyBHgiy3QeV4ePYIX3JIoYIcpk7xbNea5EJGvXb5CRYnYg6xDLaBRvs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784771718; c=relaxed/simple; bh=aM2iCNNXIhgCk369nu6oOzcyIKRphVW2QYLRwoiThPY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Lc1v5Z0mRMFlP9uoTUkZzqyw6rIbgLMR1v3k248JDGcSJQcy2ggloV2zyUuEom2sJTbqKx7tkw7NXuGAj3C7HCwzZusPnGXjwU0lwHp95TuOwJCTRpvUqrUsOWp91hPser8XmEPpPrqn0ZMB7yjkzhbmtAS/nuOrGG4SXCX14Xg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 884bb690863911f1aa26b74ffac11d73-20260723 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:7c6c1e6b-40f9-4332-9daa-343eac68a9e4,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:e7bac3a,CLOUDID:47046dd41517262187dfe5ac2bfd80b7,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:102|123|136|850|865|898,TC:nil,Content:0 |15|50,EDM:-3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,O SI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 884bb690863911f1aa26b74ffac11d73-20260723 X-User: yaolu@kylinos.cn Received: from localhost.localdomain [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 2125063251; Thu, 23 Jul 2026 09:55:08 +0800 From: yaolu@kylinos.cn To: harry.wentland@amd.com, sunpeng.li@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com Cc: siqueira@igalia.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Lu Yao Subject: [PATCH] drm/amd/display: fix wrong plane_count check in dm_gpureset_toggle_interrupts() Date: Thu, 23 Jul 2026 09:55:03 +0800 Message-Id: <20260723015503.32122-1-yaolu@kylinos.cn> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lu Yao The else-if branch in dm_gpureset_toggle_interrupts() condition was incorrectly checking plane_count !=3D 0, which is the same as the preceding if-branch and can never be true in the else path. Fixes: 8382cd234981 ("drm/amd/display: consolidate DCN vblank/flip handling= onto vupdate_no_lock") Signed-off-by: Lu Yao --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 9c564cd5edee..a11c64277d1d 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -3353,7 +3353,7 @@ static void dm_gpureset_toggle_interrupts(struct amdg= pu_device *adev, if (!dc_interrupt_set(adev->dm.dc, irq_source, enable)) drm_warn(adev_to_drm(adev), "Failed to %sable vblank interrupt\n", ena= ble ? "en" : "dis"); =20 - } else if (acrtc && state->stream_status[i].plane_count !=3D 0) { + } else if (acrtc && state->stream_status[i].plane_count =3D=3D 0) { /* DCN only needs to toggle VUPDATE_NO_LOCK */ rc =3D amdgpu_dm_crtc_set_vupdate_irq(&acrtc->base, enable); if (rc) --=20 2.25.1