From nobody Fri Jul 24 05:23:05 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3527358399 for ; Thu, 23 Jul 2026 03:00:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784775655; cv=none; b=Y2+7CDPXnkTHajPLLF2HO8AfnPegIRMfAN6KQCdS7p2bhV1ItjG8qopsnJ83Nedct2SY63pJJK51C/ttW1rZ0HwzvwDzneefL6mTHd0oZWYBPDQcZVW+R/9MAhviNGWKD1xSMLfLT3CgdsKlkwnGsAv0Lay4+yWeWBkGit+LwfM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784775655; c=relaxed/simple; bh=9krE9RKMENaD2J5nNh7HWek06yZPzFS1BDOuXgEvhrQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=o4FyVXhhVRTGf3UlyfjvTGBCeWeCDKykOa+59nPSq8D4cm63AtxrYb5tPOScITBgBIX3YE3dZapOcCdTUGM7RIVkbfkkHlju6z/bJGhde7DVfUWLLxcDBPidj9iv4b+cItxYY/uUyMjCVI5gXrGSgKJqVqe28GOcJAildzH8B1U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MLVlMVON; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V2zc01IV; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MLVlMVON"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V2zc01IV" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66N0X41p2658427 for ; Thu, 23 Jul 2026 03:00:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=kPSjRIyweAz12o/0zapMix hkVadFAjMDulal6oSaCak=; b=MLVlMVONMmM+VRHovivzFMyWTSQCUZLdaLA8zu iFg6jkuNXb6baMIWD1nG7i0HaumGmXVJwy6kkb3HOxc1P3CfgexHe1OG+FjImSd3 OrO1NmeuNgnY34Nze7aCmNpA2YGd28cAXpE2QCHGZHxMs8BngaKphd/cnP/BYMBh kkvqsooFp/Dof+AP6AOWsY/JyCS1SDR52E4PMItrkaqclRrsxZYPqupb+RNweClm +Tt/yMx13S6XdxLnF4FgJy4Yn0oyUYmPCFeo73J88z2+S5H7dsZXXe3lKaO0mkSv ljShDVnWk9E1efz5YEJRqWI1Sq5xZFqX3y3Rys2fNE2/lwRA== Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fk7b50nvx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Jul 2026 03:00:52 +0000 (GMT) Received: by mail-ot1-f69.google.com with SMTP id 46e09a7af769-7e9e0e71e05so221815a34.2 for ; Wed, 22 Jul 2026 20:00:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784775652; x=1785380452; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=kPSjRIyweAz12o/0zapMixhkVadFAjMDulal6oSaCak=; b=V2zc01IV2Hs4pD038L2HOrkTuBvPTAtI5HXLzNf3tgOOCg161maWZKnqphmE8e6jOO x2hP2q3kXaxsqOFn+sfBNR8Z7bny98wvVc3e9YgP1dmDTcZHPM0wwlfdAkToG/iK18Gf 3i22411O7gY+xuO2cYVMFDaDoEwi37KPscxjl8lY1zbTo60t7ZYm1z+POnU0hX0WgiV5 pMSNoSTksyljKnFmDtF0Pdav/Iqg2dFtZCkdjKeQCO7waY2DbR/xW/W33ErDHC5oRD2s HUF3oyfPt7tyliMUugn0/vJqkplF4kK2BR9CHpu/WEsuo2Pqn7FQMBDvHDibOoYzfxrY FUXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784775652; x=1785380452; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=kPSjRIyweAz12o/0zapMixhkVadFAjMDulal6oSaCak=; b=BQfvlHhRqxh7Zd3jorvp5jD02HxpFnlxl76PSAPs+ctF20AvN1hANLBCrS4nLzd3kC 8l4POiNU1mCroDPGssBnc8qSc4mJlbNbI1xbtmSi58DRyQvf3Hf78WWrd0dN8IUp6kAD SXrhQAFczxxdWpbZnWsU/QGC0+shT0toYm+PxXyxRK2S4CxTzIKxnVErL7vsEARv2TaV QwLwM3bmXwszeXQZtrfppiW8cTW5diW5GaGjFxe/EoDM8+C234sEwisxXvtY2mSZUx/S lm1Cvdap754JuW1LbA81q1R0gSBDv2nzgUA8ru+KvDds+YfZGfwDgx/1StKGEjQiIZlA aqrA== X-Forwarded-Encrypted: i=1; AHgh+RoLb32uCtErDT7koQYuMV4Do2wAmWFRItrVr0YrQsA5xjb4yZWtHZxOyNllHPf5kSCevp0YK/bDCCsddo8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3yyp2L6VzE6052A565uyrb4Y8uX2wDLnNibJoQ7BMdF6mmz6y 30MvDpU6J1FTOFBm3QIcSI+Px6QluIKn0rIoY+TPSFYNMzGrzi5Y+eXbCku8rT597HkhJAbXlC7 RHOmu9oHwFKUeevoDrAPPX1lN9wcwd7Wa0ZWgJGYnLZUYAqYsd0dS9sQVG99uXbyh4sY= X-Gm-Gg: AR+sD10+WNnXyt5xhnelIVNzxclAB07w3CYgviRQpkmEQ59WRg2EDRXo/xiCNELHFgy 92ic6vFXbaeOJbIBjHv/7qa/9v9+AeQoJcNCS8q3T0w+JwoQ5vlXOGMpx8ORzmWjDR5sgPpQoQ0 /VURE2DalK+oR5SSDxsExtaTuCflBej7CZA9JPhH4pWhxkRe+Oqfpfye0TmkvB5mnAVhEf5yYFv GUnk/Cq4MDB3uR/gWPSQUginFPj03HCBNQx826MZE9xeP6gG8RW+FeJy0+MovkLefZYJiIle0Y9 kMR8mmGdJ7gk6U9SybkP+Y2jG/wVuQ606J1RXb7ROicJDmHLIyC1h8JO6ZZKbX9DyyPLp+cV0Fg hhPIB2nILR0HDTLObZXs= X-Received: by 2002:a05:6830:700b:b0:7e9:eaf2:edff with SMTP id 46e09a7af769-7ee43e0c901mr942058a34.26.1784775652166; Wed, 22 Jul 2026 20:00:52 -0700 (PDT) X-Received: by 2002:a05:6830:700b:b0:7e9:eaf2:edff with SMTP id 46e09a7af769-7ee43e0c901mr942030a34.26.1784775651717; Wed, 22 Jul 2026 20:00:51 -0700 (PDT) Received: from [172.17.0.2] ([104.57.184.186]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ee29e0f1a5sm2583932a34.11.2026.07.22.20.00.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 20:00:50 -0700 (PDT) From: Bjorn Andersson Date: Thu, 23 Jul 2026 03:00:41 +0000 Subject: [PATCH] remoteproc: qcom: q6v5: Request shutdown if crash is triggered host-side Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260723-q6v5-host-side-crash-v1-1-23bd53db90a7@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIANiDYWoC/yXMMQ6DMAxA0asgz1hKLBHUXqVioMEh7gBtTCMkx N0JML7h/w2Uk7DCs9ogcRaVeSqwdQU+9tPIKEMxkCFnWiL8udxgnHVBlYHRp14jmkew1DjPobV Q0m/iIOu1fXW39f/+sF/OF+z7AcUgHiZ4AAAA X-Change-ID: 20260722-q6v5-host-side-crash-09f1256cef71 To: Bjorn Andersson , Mathieu Poirier , Gokul krishna Krishnakumar Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Andersson X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2146; i=bjorn.andersson@oss.qualcomm.com; h=from:subject:message-id; bh=9krE9RKMENaD2J5nNh7HWek06yZPzFS1BDOuXgEvhrQ=; b=owEBfAKD/ZANAwAKAQsfOT8Nma3FAcsmYgBqYYPaYzT2tK38jCYCKWVrqZ+cLlIE5JW5cGuhn jDdT4xEjFaJAkIEAAEKACwWIQQF3gPMXzXqTwlm1SULHzk/DZmtxQUCamGD2g4cYmpvcm5Aa3J5 by5zZQAKCRALHzk/DZmtxdGCEADUD+wv+2iGzRbbndsGdQJbBjOtz9CdEFnpz91HRYgHxGA3G5R 8T2eMnMriJOfX0Di8qohWrLgl385uh5CCnOoVpzfn2oRTGvdhJtuVEjcFVQn6b/SqQ2bAOHBUE5 bHbyMjj08+thkSX1MwtDXTaylq5P8P00s6KnqZM5emFka+LEzJCQFPNOrErSt8jDvqyJI2IlyEm PQw1cL4PlPjJX9vSVqClGwBxh3zBPP3r8uvZQy9/jDvYQpXNnuCLtzlHC/pQ9ryyoRhin29Zs2d gVKQoDl6KE1s1bJEJXdmgCRqbbpLK7k7+3ik0Gr4WwgUeBZtc+18YQ+bNBn1CuGhfXoqHICCgq9 u0OAQERW3ksR11hO5gH9sV5QwjVWOjJXTV5BuZJTplLzUrmJnl9IztP6QDSYND5YXHIQmoQqehd X6hcY7Fx3jYwrjGOxO1L1FRn9TKwslTT2KzhBSRcgxUKAzWPXMTMO7ManCVVL0B6K2kNZtzxaNp 0fUUpF5IZwvopI2C6rWS5gCY4sHQbOP4mdtLVkw17gCYM3+QQhhxfPT8SpVloSnkZEJB3n177MH 45XUTf3WaHBzE8TxQNFhuAOjiQq8YUy7tsou/vupKq04bF5ye14JFyklMOpxEEE1b5985q3XgA8 LbG5ydIjWUHw94hp6i4OCGuCcFq7GDyjLDw== X-Developer-Key: i=bjorn.andersson@oss.qualcomm.com; a=openpgp; fpr=05DE03CC5F35EA4F0966D5250B1F393F0D99ADC5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIzMDAyNyBTYWx0ZWRfXwSr7zmZul9E3 laJq6diGNsKoZUnsCb0TkGI0h2JvVVhPhUero62yvclZtVVidiLfJd4xIyO+3FKhXumJa09blyi vOTJt6IkRawPI2DMsnpQ5vIJyhjJjcjv6NL7sFfD9YXi0+XHA5cRE7TnwBZ3rTdY88GFJ6fLcAr 9aKdDFVX5V2Lbsp7RnyWI7mQtMRRNtsQOzUyZNyzZX47203n/0otNgXZos+w5OQQjrW4kHXZJEN KJwbaXiHkogyXsnq7iKLqW0ryXKl5jRhuNX+6jmQtJ+76i2B+yyvXig3zBBWgVnumfKPk1JzaWQ VoJzNT/Q6j50OyeU107BzOmceY9uiZhUPKyGULv9RQ++SkpwGK51CSjJEWvfsguB1bt1VZmYfoT HlTMmJ0R2X2uT+qVcxKYhztVEwoakk+RwiUrbMmSkhi67/JtdJ6mErtOZK6LBdIgH2bBntquPne TrFM/PRrnQGMV1epKPg== X-Proofpoint-GUID: hkiNr2a59tD9ETlV3z64RRKte5E1JunX X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIzMDAyNyBTYWx0ZWRfX/IeNrtkW3V7b 6Gub8AXgXwRRcDnCQ1L26sVW0qvp0dvJst40tH3GmhZbH4ASQtz8ufgY4PJoozxVml/dlUhlutf qUNRW5+Dc2E/RkGc5jtrIx4fqG4xKSM= X-Authority-Analysis: v=2.4 cv=btx8wkai c=1 sm=1 tr=0 ts=6a6183e5 cx=c_pps a=z9lCQkyTxNhZyzAvolXo/A==:117 a=DaeiM5VmU20ml6RIjrOvYw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=Bi8UBAkcxtFIQmh453wA:9 a=+jEqtf1s3R9VXZ0wqowq2kgwd+I=:19 a=QEXdDO2ut3YA:10 a=EyFUmsFV_t8cxB2kMr4A:22 X-Proofpoint-ORIG-GUID: hkiNr2a59tD9ETlV3z64RRKte5E1JunX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-23_01,2026-07-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 priorityscore=1501 spamscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607230027 rpmsg client drivers are allowed to invoke rproc_report_crash() on their grandparent when they determine that the otherwise seemingly healthy remoteproc has entered a functionally broken state. In the crash handling path qcom_q6v5_request_stop() is invoked, which is based on the current rproc state whether to request a graceful shutdown. But the current rproc `state` will be RPROC_CRASHED regardless of where the crash handler was initiated from, and empirical data shows that unless the firmware is taking part of the shutdown the system state is often left such that it's not possible to start the subsystem again. Use the `running` state in the q6v5 driver to make the decision instead, as this does represent the actual state of the firmware. This makes it possible to reliably trigger a restart from client drivers. Fixes: 3cc889eb83f5 ("remoteproc: qcom: q6v5: Avoid setting smem bit in cas= e of crash shutdown") Signed-off-by: Bjorn Andersson Reviewed-by: Konrad Dybcio Reviewed-by: Mukesh Ojha --- drivers/remoteproc/qcom_q6v5.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/qcom_q6v5.c b/drivers/remoteproc/qcom_q6v5.c index 1075ef4027b7..fe148b4b3775 100644 --- a/drivers/remoteproc/qcom_q6v5.c +++ b/drivers/remoteproc/qcom_q6v5.c @@ -229,13 +229,13 @@ static irqreturn_t q6v5_stop_interrupt(int irq, void = *data) */ int qcom_q6v5_request_stop(struct qcom_q6v5 *q6v5, struct qcom_sysmon *sys= mon) { + bool was_running =3D q6v5->running; int ret; =20 q6v5->running =3D false; =20 - /* Don't perform SMP2P dance if remote isn't running */ - if ((q6v5->rproc->state !=3D RPROC_RUNNING && q6v5->rproc->state !=3D RPR= OC_ATTACHED) || - qcom_sysmon_shutdown_acked(sysmon)) + /* A watchdog/fatal IRQ clears running; logical crashes still need a stop= . */ + if (!was_running || qcom_sysmon_shutdown_acked(sysmon)) return 0; =20 qcom_smem_state_update_bits(q6v5->state, --- base-commit: 290aaf24a551d5a0dce037e3fab30820f9113a10 change-id: 20260722-q6v5-host-side-crash-09f1256cef71 Best regards, -- =20 Bjorn Andersson