From nobody Fri Jul 24 22:17:34 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 261B9459AC7 for ; Wed, 22 Jul 2026 23:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784762137; cv=none; b=CepYnRvd3wfaC3SUAvHPOkcStTbqb5f50OnuRgTSUGrBMPOoBTfsY0OZSTXdT9YFbnJRXfHSbUNjvpVnERhxbOcxcYTzqe5NUZG+yh0CyatsZVFl79wY+d4Y0sgiw98F3akIuwoBOc651lPCKXu9TD2Dmv3fA32igD+z5hT02CE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784762137; c=relaxed/simple; bh=aCDnq0qzyxDiam31Skj1l/Kd6ie5IpEFzLKucDi3yrI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bcPxsLl7Nwm2swHBMP8rzgUv40dYHzMwVWfferbrmjHLumz/XMfbHz21890PDnBX9Z65zjuZdHk9EUfYnBlLnI00RrWDCcnTnhDSuHDqoNBPTY+8SIx8s5aHiaM0p/UlwMJQW2JwmoNn+Mol5uCE9ZgHJ3AMkRtyBS6dPVZAM9U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oeaBA8bo; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oeaBA8bo" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c966b9ee9cbso35852a12.1 for ; Wed, 22 Jul 2026 16:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784762135; x=1785366935; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=A666YiddBzubQJ14vmQH66RggGZrJM+23a2vA9KOgG0=; b=oeaBA8boReeT8VPMFDh/3VwVLpsvTHVSt66+brxhE0u9j1FfNa+0rR698i9OGhOOtX 70hTcqQRorbXWWw2EFAkmq4osfMKWFYOIZtqN/Xm1tSSKC5yot0zyrnvpqe4O2D6510n O6Y9svfr/seANZIYC/F1Y5pSKyo7yDxjclrVt2qZ0Hed/oO4UlyQbxyPddAWOCZQonus /vXVzxmLQwJADshA1ld1re1GYQ1P9ScTiB8xZj15cLl/gsf3KcvJWvyL2V6pQXbFXqtP fSCY8PCjKqed4anid3m6Hbm98CDJuAHQ4pYtcJ+XVVUERht/IhfbzhzTnRrN2fvuV6eC 4VzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784762135; x=1785366935; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A666YiddBzubQJ14vmQH66RggGZrJM+23a2vA9KOgG0=; b=W0ZBNS6BX8zn+9dfghsepYIKpdWY4kpe8eI2TSMjTG51+8H5q1BbslLZXJ2Hd+QENq Y5z+fWW7nWR1DBqIrUz15IGLqhvpT7L9N2Sa2BhdB4YhATsIGKWaocudW9AWHxsdZ1Yz uz/bC3fWFEI7x90MYU+dxzePms50FmfYWfzIloNEthxera7rqywMo16SAL00fGy5cWwc mhw62U4VQhZYPw+PqeX52GgoC5UGU6qIypnrQWcX+sb9W0JyJYSSD5dLLoa6tO1z5dDL EDB4mHMPi3JzpQb1J5Baze+cJPuKV6RbrG8ndab1cxO0CgiTa0Zgqlrkk48lym6tjLrE mdng== X-Forwarded-Encrypted: i=1; AHgh+Rpu+DpsOMhiu+knMj6jqH80ffvvcRIe++TUGcPkKSxBg8996i/+6rEizL3wfLrRKZ2jdQXRdIDPsNAdhRY=@vger.kernel.org X-Gm-Message-State: AOJu0YxCu+uFW5iPAQeqznMLAxEboc3dDDXHbrff4oSUeUiidPTGQZhr cd7d1Ei/bkGye3mNcXdGBYrFA4hoiheEtF9j8dnXKiCO5Gm7MTCKqFwJ X-Gm-Gg: AR+sD12UT1SOpNs4cCLx9+ZQ/HjXxB9J4P2cQIHArk8NkuTbeMwcfXqPpBF6PVV233w r9FAF5kER9YQaEhZpo9nFSGK3EAmGwLg76/PM24UOVcJ4pzTo4f/yIfos4QKwPch4Nex5W7iFJD 4nD+94N9yFias0BDboW+ciX84Un+ITEnz3GOONEybQDV0kRtHYEP9Y+8EpUU52NNiMpHrDhCRfX WwJzq+q2GIobozEfIiA/Z03h8bY3NvsIY5oCYMGHv57wah1QPlIljo/2/BWFNtKYLYNEuelzf7+ 7OzAos6wjBuovjWFt8a7OLWjni0cXCLKHEtMKeODS9VnxSD40glSmLCdJzugsP6HZXDPDToPwfk GerPIKTia8e8EignoT2us3QUap4I0pvZIqpAGXQsoz2hj58WTqbXjD02JfMJAs20mbnQbi8uoxm +7Xjy8N4SVtKAlnumck4m2G20W3NkxE1BFqGOiX833+umKIlvyIKTFAjhoNWZ0dTxzsC2L1D9MX sv14ssBvQdnKjOCOIrssqi39g+faW9o/DDcwBwoV7yqzisDnHhwv+ki0ZxIuz71KQ== X-Received: by 2002:a05:6a21:d82:b0:3c3:9557:3b47 with SMTP id adf61e73a8af0-3c44b202c16mr432634637.51.1784762135338; Wed, 22 Jul 2026 16:15:35 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbb8f1a8a2bsm1798981a12.22.2026.07.22.16.15.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 16:15:34 -0700 (PDT) From: Rosen Penev To: linux-pci@vger.kernel.org Cc: Kunihiko Hayashi , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Masami Hiramatsu , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-arm-kernel@lists.infradead.org (moderated list:ARM/UNIPHIER ARCHITECTURE), linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv2] PCI: dwc: uniphier: use fwnode API for legacy-interrupt-controller Date: Wed, 22 Jul 2026 16:15:32 -0700 Message-ID: <20260722231532.872962-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert uniphier_pcie_config_intx_irq() from the OF-specific to the generic firmware-node API: of_get_child_by_name() to device_get_named_child_node(), irq_of_parse_and_map() to fwnode_irq_get(), of_fwnode_handle() on the child node to passing the fwnode directly, and of_node_put() to fwnode_handle_put(). Unlike irq_of_parse_and_map(), fwnode_irq_get() returns a positive IRQ or a negative errno and never 0 (it rewrites 0 to -EINVAL), so check pp->irq < 0 and propagate the error. pp->irq is an int, so the negative value is preserved. Drop the now-unused np / dev_fwnode() locals, since device_get_named_child_node() operates on the device directly. Built for arm64 (defconfig + CONFIG_PCIE_UNIPHIER) with LLVM=3D1; drivers/pci/controller/dwc/pcie-uniphier.o compiles cleanly. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- v2: fix fwnode_irq_get() error propagation. drivers/pci/controller/dwc/pcie-uniphier.c | 25 +++++++++++----------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/contr= oller/dwc/pcie-uniphier.c index 297e7a3d9b36..29eb1b9abd26 100644 --- a/drivers/pci/controller/dwc/pcie-uniphier.c +++ b/drivers/pci/controller/dwc/pcie-uniphier.c @@ -14,7 +14,6 @@ #include #include #include -#include #include #include #include @@ -262,27 +261,27 @@ static int uniphier_pcie_config_intx_irq(struct dw_pc= ie_rp *pp) { struct dw_pcie *pci =3D to_dw_pcie_from_pp(pp); struct uniphier_pcie *pcie =3D to_uniphier_pcie(pci); - struct device_node *np =3D pci->dev->of_node; - struct device_node *np_intc; + struct device *dev =3D pci->dev; + struct fwnode_handle *fw_intc; int ret =3D 0; =20 - np_intc =3D of_get_child_by_name(np, "legacy-interrupt-controller"); - if (!np_intc) { - dev_err(pci->dev, "Failed to get legacy-interrupt-controller node\n"); + fw_intc =3D device_get_named_child_node(dev, "legacy-interrupt-controller= "); + if (!fw_intc) { + dev_err(dev, "Failed to get legacy-interrupt-controller node\n"); return -EINVAL; } =20 - pp->irq =3D irq_of_parse_and_map(np_intc, 0); - if (!pp->irq) { - dev_err(pci->dev, "Failed to get an IRQ entry in legacy-interrupt-contro= ller\n"); - ret =3D -EINVAL; + pp->irq =3D fwnode_irq_get(fw_intc, 0); + if (pp->irq < 0) { + dev_err(dev, "Failed to get an IRQ entry in legacy-interrupt-controller\= n"); + ret =3D pp->irq; goto out_put_node; } =20 - pcie->intx_irq_domain =3D irq_domain_create_linear(of_fwnode_handle(np_in= tc), PCI_NUM_INTX, + pcie->intx_irq_domain =3D irq_domain_create_linear(fw_intc, PCI_NUM_INTX, &uniphier_intx_domain_ops, pp); if (!pcie->intx_irq_domain) { - dev_err(pci->dev, "Failed to get INTx domain\n"); + dev_err(dev, "Failed to get INTx domain\n"); ret =3D -ENODEV; goto out_put_node; } @@ -291,7 +290,7 @@ static int uniphier_pcie_config_intx_irq(struct dw_pcie= _rp *pp) pp); =20 out_put_node: - of_node_put(np_intc); + fwnode_handle_put(fw_intc); return ret; } =20 --=20 2.55.0