From nobody Fri Jul 24 22:17:48 2026 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A9CD276028 for ; Wed, 22 Jul 2026 22:00:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784757630; cv=none; b=gDto1g3iPSzMw2SH9tRheqodBXYPtbYnbxjRP8edJvVyswFanvbgFyFcWnw7K1OKb5CqAfQK0XRzvxiaWcj+eDKcr0ERAp49L6CVC63QLdU0cbcRQKzEyNIqqsl9E+TrP1LwJU82/Nshf9ZhA0oT6RhqWMG7wp63MS2LoBBaBJw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784757630; c=relaxed/simple; bh=5/ZJZ8wFV6lwD9S37d19WLl3Lp+Qb8sMnjslMXqDyJM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=N9kbKZ/2YwcYp1wePOd+Vb+y2reGQd7wybhxWR5w2wQ0XMNQf7pSNBR5GnNzaSWTLwwzOfKaQq9ggkPG6AnJe+O5t8BVSspw7IW092J1ltsUiPUEq6FbAGZ+rh6NAF3hO3JOUSFcedxVy/slZYyYvBAjjhIGfjs7YmLLhKHlbBU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sNe5VXWr; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sNe5VXWr" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4955158f26aso30424945e9.3 for ; Wed, 22 Jul 2026 15:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784757627; x=1785362427; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hAmg9kvDp6fcRhAWqYJmRWgkw3aQP6ISOL7nDMeVy7Y=; b=sNe5VXWrFC+WnSNrN8D7+bs5HU+n1uoV66wnKFz/T/iH5SjqOeVhI/eJW3+VuUUDBi hyKT1r/t5FsDS5tRycTSjVFR/U9BZYS19A/hKAxYGO2MEn0crF/dRobhzCWNJK8RD3IR ZBcWYjgur195OTV0wVgojeh5/oScNQzV8OcTVBAjRVo0Vwb8+s7aUisT/xqXm6a6eE1D iTI3XOL7YIauPRc2RDhbRjkt4ClOp8cnRCvTKEnq6wm7RNNPUn1zW7BZfw3PnjTlWbcm FyclUr6tD2SL3f7X9fnlfdhF/ej7qylhIFk+Zvqfhirocntjx3KNkZGhvW8xMTROxCes 3SKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784757627; x=1785362427; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hAmg9kvDp6fcRhAWqYJmRWgkw3aQP6ISOL7nDMeVy7Y=; b=KirlQXyk12eVWMJbyRVbQMnGCN32pRoGl5oZk3Y4dGUy6HdAv8kVzUsprhff/W0jCu 2klP2wzPh0d9RGA3RTKc6eN99OvZhiFMXugXkqVDvuI+YktIyzV1GKFiS2FCMEhbVbK/ oSLFIU50ylRHyXlfbLHqg+qUMeXGqejHBxyRvrYZv/tCYmdHraniugWqAqEs8l3seEj1 YhMvSCQR16tziM+KDhHPnCLdM0NomQFemwC9DeMI7mvnUfURFKvQVrAtUKuJUdf9yLEZ VZ7wXBBAdTIJRYOyp9ma2bc1VU1emChGJRFHwIKe7B844nqVu8egZ9uusNuUjhjuQbqW 9uXQ== X-Forwarded-Encrypted: i=1; AHgh+Rrprnvjf03HM/1ZUr5EsUhiS9aTxhWVJBfAVMIx8LBK/MMwQlHKuhhMcvzbwTtzjreN7yZSq6l1dmm1dbo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/QZ7WCNnzsuG9skSxs7XySGVx/VdDPvXe4Mhi/eve7iPRiVii rP9WWKvfuzirhNpF7LSMtJTydAbsaNJb3oEtRAVjWK/7z51Kf/768qOf X-Gm-Gg: AR+sD10zwxpbhSRkMcIDJok5I0wjyGzoF/YomXPXo2vI4kcs0/JvWsMc/tgI9A3CpV7 pVrbEWywLAPnB7tcW/brvw0w+DSO53dyJR78AYygLjTPXWUFpvslKydm6Sa1gxXMNJZTSIK/dBw L8QxCfPZvqFr94HUzZX4O8DRS+iTcLmKDBoVDMwC/MnhKG0Tnki+TWUf6Dlar241083ERrU8hpP k6pzQjxNbcsKjt8K7ScrS4B4zRVRdI8p0ylNkyCTdBfoqhdEikNEpMu0R13LL97Lr2BatIBDhH/ uKyQ96CdyKriE7XouZ4MucQ39UvQ3xlnTqPQiM3vSNsR87POR4also+++nwQi8gVbt20N56z8Rx qhD+7214up7Eyg+zZKJDwicBOuj0oOlLHfm3dk8Xucx+Q/SuMjQaRzYUkfvQWayoMpOUgTyNHdy PFI4uKC0RqbgMKjfSCfE0/YyrieZLgRjt5H7ZXf7JaV4Kh9nwsXASg71iwDjeL9nAtRA== X-Received: by 2002:a05:600c:818f:b0:495:4f62:c9f5 with SMTP id 5b1f17b1804b1-49573cf6daamr3388225e9.24.1784757627049; Wed, 22 Jul 2026 15:00:27 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956b0395f7sm62532245e9.3.2026.07.22.15.00.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 15:00:26 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: deller@gmx.de Cc: tzimmermann@suse.de, wei.liu@kernel.org, ptsm@linux.microsoft.com, arnd@arndb.de, u.kleine-koenig@baylibre.com, hsukrut3@gmail.com, rob.github@jumpstation.co.uk, enelsonmoore@gmail.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH] fbdev: replace dead select with dependency Date: Wed, 22 Jul 2026 23:00:23 +0100 Message-ID: <20260722220023.196029-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" 'select' does not work on config options in a 'choice', so currently it is possible to enable FB_MB862XX_LIME without FB_LITTLE_ENDIAN. We cannot replace the 'select FB_LITTLE_ENDIAN' without also changing FB_FOREIGN_ENDIAN from 'select' to 'depends on', otherwise we will get a recursive dependency. Note that, if we remove the select / dependency, the kernel will compile with FB_MB862XX_LIME=3Dy and FB_LITTLE_ENDIAN=3Dn so if it would be better to remove the select, please advise as I do not have the hardware to runtime test this. This dead select was found by kconfirm, a static analysis tool for Kconfig. Signed-off-by: Julian Braha --- drivers/video/fbdev/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index 085d3a202148..1ed4506c0cb2 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -1717,8 +1717,8 @@ config FB_MB862XX_PCI_GDC config FB_MB862XX_LIME bool "Lime GDC" depends on OF && PPC - select FB_FOREIGN_ENDIAN - select FB_LITTLE_ENDIAN + depends on FB_FOREIGN_ENDIAN + depends on FB_LITTLE_ENDIAN help Framebuffer support for Fujitsu Lime GDC on host CPU bus. =20 --=20 2.54.0