From nobody Fri Jul 24 22:17:34 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D600827F017 for ; Wed, 22 Jul 2026 20:48:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784753311; cv=none; b=fJ+0PCEUpmPfksgs2X9gpqT2KVwsTu3DIpAZrwB0Nt+GU9GM8s2gGMz6Y9pcns/bTd8jXLXH8LyBza/FJnZiHaKaLESHEkJqQmQO4nOD7B8ddelH3B7OkicB3vOqhwz6PsyiPmIGeFUP4e456coXAnbKB7erfb9VwSjCpWTa/TE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784753311; c=relaxed/simple; bh=mSitop2Yppo+RSSuqzmHplr6SG0dXZVT1RxCGcJOeS8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pcNKjZ/byEdpx/M/sT/66rqsAsoHWHGz9U+kn4f+KFVFAuO9Z7Dsmtv0yJR8HKkMkZ+l0tDmQ6Y8xsmMzy3OgGq5HLODLg0mgb+V5QXbt2ib9GENjvFIpRfuhpdF2H/x0lmkcdvlKc5tfbfqBjzi2+OnIFMLrCMvvdCAcJ1sLfo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qzCLxrtG; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qzCLxrtG" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-84874b52eabso12749190b3a.0 for ; Wed, 22 Jul 2026 13:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784753309; x=1785358109; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=nA4HLdiCHLbuN5swnn9vYplFHWddQQAQ0EGVLN5lYxE=; b=qzCLxrtGknW2XpjKADDN4WFOohF8tO9h5t4S/p8CdBsCNlWWlGfF3jHykbBkRpTrPP 8HArhGg9iK66PjRA+Ne06fXm5CjVibWIf7AFIka/K3cm7Sa5FHOQiu1IukjB3GI9jjaQ CLhefe3KmjK8bDHZsy8DVxDRFCZGpUZCHzgkGuKdPtNbrOLMxr7SlIyr+SiQCbbta8nB AFusVLNJy6acJe2lF0xi0fVqqOBVLGAN7Sjcw5ZwUOu/pczlZCd8sBq0a55jmC4cHUQX B7/Dy+NHgE0MBdlXCT2RFAHj8atunnzwVRQ2nGfq/O27+DMPFOBp+6Nasi6pugmawpFw f/cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784753309; x=1785358109; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nA4HLdiCHLbuN5swnn9vYplFHWddQQAQ0EGVLN5lYxE=; b=h1Zp0ylNnUOyXjws6ecv+x8xxxYT18CtVRm8/uoscVIRdKg6REBFkq46tZQU7Wq03M cd/rfYblInjJbr4c3rbAFLRThchn3qkGsM9dR0IMumlI2/CcOhKmDgiv5meZi/6OoQe8 ffWv7re8pABTsLOp0/qOT+KKkza6N8Eg45BBdl5glqOBIo5NG36ebV/UELaMJ3rt2x9i bvg7IzX3bZJoVd+2t56qCSjvxRt1SSfAoUstGRGIa8doMD7Gxzk+v54tJE1H5N0Yp2w5 rqe57m99/2Zg07MWxVztSwD6hdhCY2P7P2e6AUjs9iM5efeqK2UFP6pS3EkVy5gO3TWK kBLQ== X-Gm-Message-State: AOJu0YxbKgR9m07Pp21mbMVhcs7aB0HZtLUWhrI2LvJ8ZwKGlCsMHdP7 I8YSVNY+TVa8cTh+Hy8GVYbki33Q4+MDSFNladZeuxQ0YqRdDVLZVDGEeRmKSw== X-Gm-Gg: AR+sD11X+qxReuxrOeQtAFVnGkLKBMlNFh+l4nmrrYPbcyAPqWpy8yBBWffqdTnDWR6 RfOKTjYsqQY+w0wpGs8lWSNU3fv27Olv8F57J7ulJuDcnfT+9fyFBPRTf7Ovf+rdC1MFqTTByqv cFzi+5FbDk2Xo3COh6Y33Hezpx7XNgTT3UqCg6raR3qYmo2pki3xEC88V8VYabV3mRDueqJQL9v pbWThetKxsivW2jvX7eV0BVAxZHSkf6RHK2ZqxHltX+fjFEbZKNSyJVlSCA6lSdKrJssOiWQH0f LMqw/NHgx+kpdhH3gkKBO/XUXnSnPL6DPcBVHF2NaD1GnimAs/38+XA6y9LyiE/Yjzt1YfEBoxw iFA9fQcjAVmDb6tMPKcOBGfzVUXnTEoch8rE7UTQFl/jqFQszFCvjKQ21VeizNMVDnC6ABEpBYM h9TYdFuQQfa3NMxA9aCXxNjZNUp0elAvRvmNRD5je+bxEHMYu31Zr5Kpq/71tx00BdkrPObrnWU im0gcfeT/awgGydPX47tTpHpxwY+eLlPKlF0FyK7cIwwJsWHEYJ0ks= X-Received: by 2002:a05:6a00:1706:b0:84a:6e0d:692d with SMTP id d2e1a72fcca58-84e2c181fc7mr434316b3a.46.1784753309310; Wed, 22 Jul 2026 13:48:29 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84e17602046sm1843277b3a.59.2026.07.22.13.48.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 13:48:28 -0700 (PDT) From: Rosen Penev To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] uio: fsl_elbc_gpcm: use platform helpers for resource and IRQ Date: Wed, 22 Jul 2026 13:48:27 -0700 Message-ID: <20260722204827.510133-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace the open-coded of_address_to_resource() in get_of_data() and the later ioremap() of the memory region with a single devm_platform_get_and_ioremap_resource() call in probe(). This requests the region and maps it once, instead of mapping it without a region request, and removes the redundant second ioremap. Similarly replace irq_of_parse_and_map() with platform_get_irq(), which returns a negative errno on failure (including -EPROBE_DEFER) instead of 0. Both substitutions are equivalent for a DT-backed platform device. The remaining OF accessors are now covered by linux/of.h, so the unused linux/of_address.h and linux/of_irq.h includes are dropped. No functional change; the GPCM window is not claimed by any other driver (fsl_lbc only of_iomap()s its own registers, and sibling eLBC-window drivers use distinct windows), so the new region request cannot conflict. Built for powerpc (allmodconfig + CONFIG_UIO_FSL_ELBC_GPCM) with LLVM=3D1; drivers/uio/uio_fsl_elbc_gpcm.o compiles cleanly. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/uio/uio_fsl_elbc_gpcm.c | 60 +++++++++++++-------------------- 1 file changed, 24 insertions(+), 36 deletions(-) diff --git a/drivers/uio/uio_fsl_elbc_gpcm.c b/drivers/uio/uio_fsl_elbc_gpc= m.c index 338dd2aaabc8..08cb150fb12f 100644 --- a/drivers/uio/uio_fsl_elbc_gpcm.c +++ b/drivers/uio/uio_fsl_elbc_gpcm.c @@ -45,8 +45,7 @@ #include #include #include -#include -#include +#include =20 #include =20 @@ -249,19 +248,12 @@ static int check_of_data(struct fsl_elbc_gpcm *priv, =20 static int get_of_data(struct fsl_elbc_gpcm *priv, struct device_node *nod= e, struct resource *res, u32 *reg_br, - u32 *reg_or, unsigned int *irq, char **name) + u32 *reg_or, char **name) { const char *dt_name; const char *type; int ret; =20 - /* get the memory resource */ - ret =3D of_address_to_resource(node, 0, res); - if (ret) { - dev_err(priv->dev, "failed to get resource\n"); - return ret; - } - /* get the bank number */ ret =3D of_property_read_u32(node, "reg", &priv->bank); if (ret) { @@ -288,9 +280,6 @@ static int get_of_data(struct fsl_elbc_gpcm *priv, stru= ct device_node *node, if (of_property_read_string(node, "device_type", &type) =3D=3D 0) setup_periph(priv, type); =20 - /* get optional irq value */ - *irq =3D irq_of_parse_and_map(node, 0); - /* sanity check device tree data */ ret =3D check_of_data(priv, res, *reg_br, *reg_or); if (ret) @@ -312,7 +301,8 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_devi= ce *pdev) struct fsl_elbc_gpcm *priv; struct uio_info *info; char *uio_name =3D NULL; - struct resource res; + struct resource *res; + void __iomem *base; unsigned int irq; u32 reg_br_cur; u32 reg_or_cur; @@ -323,6 +313,16 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_dev= ice *pdev) if (!fsl_lbc_ctrl_dev || !fsl_lbc_ctrl_dev->regs) return -ENODEV; =20 + /* map the memory resource */ + base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); + if (IS_ERR(base)) + return PTR_ERR(base); + + /* get optional irq value */ + irq =3D platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + /* allocate private data */ priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) @@ -331,8 +331,8 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_devi= ce *pdev) priv->lbc =3D fsl_lbc_ctrl_dev->regs; =20 /* get device tree data */ - ret =3D get_of_data(priv, node, &res, ®_br_new, ®_or_new, - &irq, &uio_name); + ret =3D get_of_data(priv, node, res, ®_br_new, ®_or_new, + &uio_name); if (ret) return ret; =20 @@ -349,7 +349,7 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_devi= ce *pdev) if ((reg_br_cur & BR_V)) { if ((reg_br_cur & BR_MSEL) !=3D BR_MS_GPCM || (reg_br_cur & reg_or_cur & BR_BA) - !=3D fsl_lbc_addr(res.start)) { + !=3D fsl_lbc_addr(res->start)) { dev_err(priv->dev, "bank in use by another peripheral\n"); return -ENODEV; @@ -371,26 +371,18 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_de= vice *pdev) =20 /* configure the bank (force base address and GPCM) */ reg_br_new &=3D ~(BR_BA | BR_MSEL); - reg_br_new |=3D fsl_lbc_addr(res.start) | BR_MS_GPCM | BR_V; + reg_br_new |=3D fsl_lbc_addr(res->start) | BR_MS_GPCM | BR_V; out_be32(&priv->lbc->bank[priv->bank].or, reg_or_new); out_be32(&priv->lbc->bank[priv->bank].br, reg_br_new); =20 - /* map the memory resource */ - info->mem[0].internal_addr =3D ioremap(res.start, resource_size(&res)); - if (!info->mem[0].internal_addr) { - dev_err(priv->dev, "failed to map chip region\n"); - return -ENODEV; - } - /* set all UIO data */ info->mem[0].name =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, "%pOFn", nod= e); - if (!info->mem[0].name) { - ret =3D -ENODEV; - goto out_err3; - } + if (!info->mem[0].name) + return -ENODEV; =20 - info->mem[0].addr =3D res.start; - info->mem[0].size =3D resource_size(&res); + info->mem[0].internal_addr =3D base; + info->mem[0].addr =3D res->start; + info->mem[0].size =3D resource_size(res); info->mem[0].memtype =3D UIO_MEM_PHYS; info->priv =3D priv; info->name =3D uio_name; @@ -421,16 +413,13 @@ static int uio_fsl_elbc_gpcm_probe(struct platform_de= vice *pdev) =20 dev_info(priv->dev, "eLBC/GPCM device (%s) at 0x%llx, bank %d, irq=3D%d\n", - priv->name, (unsigned long long)res.start, priv->bank, + priv->name, (unsigned long long)res->start, priv->bank, irq ? : -1); =20 return 0; out_err2: if (priv->shutdown) priv->shutdown(info, true); - -out_err3: - iounmap(info->mem[0].internal_addr); return ret; } =20 @@ -443,7 +432,6 @@ static void uio_fsl_elbc_gpcm_remove(struct platform_de= vice *pdev) uio_unregister_device(info); if (priv->shutdown) priv->shutdown(info, false); - iounmap(info->mem[0].internal_addr); =20 } =20 --=20 2.55.0