From nobody Fri Jul 24 22:17:34 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCB2333F59C for ; Wed, 22 Jul 2026 20:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784753208; cv=none; b=NIIqdSE71bWShbi61eld94UIVJYBUziiDW7gQrvJASkl1EV6h0QW14r+dyJlnyugEYIFD/gsGMEYccEFG98sIuiI9X72vne3OJj2UItsAq3ZH29qrc9l1wu16+QQo3uL5YUDCju8rq1ugqbNupNmzn9oGtyS9KI5jmcIN8iPLc0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784753208; c=relaxed/simple; bh=PeXIOyKaz0DZ+WMcNZyDsJa5j4VZrPReK3DmaeFUCAA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=d7+dcqMdo8Y9LqUDDqR9jDFCLiNuW7tOAWwjSTgTkzJUZ4iKrEeGey6D7RjEx2uG6E8RJIyLUvEoiazC4c5eGE1jJYFPKWHF+xL5ogbUmqiDj332k/be5ym7qjKNByIMfSv5fm9eCh4NLp2zCjpkTeLUi2jaM4021a3yRH2cVlE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IjTG4FyE; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IjTG4FyE" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-385ea3ce80dso13110748a91.2 for ; Wed, 22 Jul 2026 13:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784753206; x=1785358006; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=rJuQoK2RLmoQOUtCApw/BgcLgmg0HJ6NIMU5JaCgZHs=; b=IjTG4FyEViUcu6/n7Gt8vB6balFS00I1RFHqHtRpXutCuP8ZHRs7tgljXsJbs6TrPo /oaaGBLDdan6OQzRNaP25Qi4ryHKGQ+D/WYmqYpSUYt+qC7s7c9WtsMsaxkqHI1CqUK+ /O9nT8cTF+jZTdfNKDMBBRur597RMP9GbF5P3uEqGLeFK/pCIYWIvhb+Va4bqgrQFlEr d68o8h2JxkXVTwLdY0kE7eKoj0aXnHfxtUn/h45jeF0V19UdYGmJjAa/RONs6/ypi6g4 abodHo14TmUddTG6TsxhuVJfAtgEo6AbdHmECJunCrg0++MieQzStVMePoVsAwq7cLZQ tTJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784753206; x=1785358006; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=rJuQoK2RLmoQOUtCApw/BgcLgmg0HJ6NIMU5JaCgZHs=; b=tYU0wwnHFnsQCxhfT7iz6ZRA/ErybEczUZrSvQdfFpk06evZS+LCzRXyitVYP/B0mO WkSov1NvIAqZb9evAOipKP77v1WJzYYA9MJvX/fR3m8eH3dOo9D1kfJ/wcJ9/GfX31zY fvwhAoa5zLEV2bSI/fUO6DRH8Ebpe5f5OcnCjybM+9QRtxQD0LyVTs5C07hfePhszVy/ mbP59rCGW0uJBpXtm/450rzP8h4bnY9rYqMbTtcqHE2GNIh1B6mgjPSnS+gJSOYSbmvW PAax+fvp96vNZB4tlLr3/g2u0CX5vkctfZITTvfiNSFRCmvUdiOefVGAi/QgeW4Tjxf4 jilg== X-Forwarded-Encrypted: i=1; AHgh+Rrekp3okyFN0UsZVC0gGvz3ol0uQ/znQUJwOJCqx/VMh4Fz8lDZO56h7BQ5L4KFfL0xooT0TeBDj/SDCkg=@vger.kernel.org X-Gm-Message-State: AOJu0YydNTtliLJQ7xwUJKnuoVcs+tDdLN+0SVdcHIjI8jRewr/24dY9 B1QYifa/oumBoEjnlaHdlMopQKWy+wuIrfG3MVayfRMk/hqhV/ihnuLU X-Gm-Gg: AR+sD13HB5KIe3j4wUr4xymyky2nfrZlK6XqeRuc44C8LRQbUdoaLmWboCChcq1wkMh QkqJi4NPyOACCfaOyPD19+uRUiC+4xf2Z9phQKvPCcNaeh0uTNgUTjJqgjCxV+meRLlLCrinznV WdGOISYGRel9rkD7g2tYLxkWau/nQ6aS2ZX9z2jE3OpsTGoNFf8qNaot1hvBuBcyVNZSvKHIs4M NCEYSGPBJHfxJGuGZGzK3d1C3hc8qXwQN2r5kvy0b4/uZPRAtZmwZj3mEBjaLP2Wm2jGnyF5sKv b3kIaFSwcj5ob+bedV6VaX98+QKZgv/HLpkELDVmmf07jnFBtaKkLZC3B080X+Q2iOGPgeISfeG +S1oCguKWp0wniGDKp9B2iCemEHatniPjMn/roWEfhdLq+9aBDe2Vko3PUfkt7CQQZ0fexxRrmP MXTH1PSt0MIPLT4L19fBbaJnr2Cus4eBgPOO/tpKwklEFfIUUJdFBjZ8qsV/q1LdNX5DK36aeKg Wov1QsvAHi4DiO4fO6u3FuYw60HqbMyuLdNLooyXYJOfFPJV58u5eQ= X-Received: by 2002:a17:90b:2583:b0:37d:ee77:78ac with SMTP id 98e67ed59e1d1-38ec6529677mr298971a91.19.1784753206027; Wed, 22 Jul 2026 13:46:46 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e921ac370sm3840599a91.17.2026.07.22.13.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 13:46:45 -0700 (PDT) From: Rosen Penev To: linux-mmc@vger.kernel.org Cc: Ulf Hansson , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] mmc: moxart: use platform helpers for resource and IRQ Date: Wed, 22 Jul 2026 13:46:43 -0700 Message-ID: <20260722204643.502879-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace of_address_to_resource() and the following devm_ioremap_resource() with a single devm_platform_get_and_ioremap_resource() call in moxart_probe(). This requests the register region and maps it once, which is equivalent to the previous devm_ioremap_resource() behavior, and drops the now-redundant separate resource lookup. Similarly replace irq_of_parse_and_map() with platform_get_irq(), which returns a negative errno on failure (including -EPROBE_DEFER) instead of 0, and tighten the error check to irq < 0. Both substitutions are equivalent for a DT-backed platform device. The remaining OF usage (mmc_of_parse() and the of_device_id table) is covered by already-included headers, so linux/of_address.h and linux/of_irq.h are dropped. No functional change; the MMC register window is requested and mapped exactly once, so there is no overlapping region claim. Built for ARM (allmodconfig + CONFIG_MMC_MOXART) with LLVM=3D1; drivers/mmc/host/moxart-mmc.o compiles cleanly. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- drivers/mmc/host/moxart-mmc.c | 29 ++++++++++------------------- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/drivers/mmc/host/moxart-mmc.c b/drivers/mmc/host/moxart-mmc.c index 4a4d8b19b18c..28aed13549a6 100644 --- a/drivers/mmc/host/moxart-mmc.c +++ b/drivers/mmc/host/moxart-mmc.c @@ -26,8 +26,6 @@ #include #include #include -#include -#include #include #include #include @@ -555,8 +553,7 @@ static const struct mmc_host_ops moxart_ops =3D { static int moxart_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct device_node *node =3D dev->of_node; - struct resource res_mmc; + struct resource *res_mmc; struct mmc_host *mmc; struct moxart_host *host =3D NULL; struct dma_slave_config cfg; @@ -565,30 +562,24 @@ static int moxart_probe(struct platform_device *pdev) int irq, ret; u32 i; =20 + reg_mmc =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res_mmc); + if (IS_ERR(reg_mmc)) + return PTR_ERR(reg_mmc); + + irq =3D platform_get_irq(pdev, 0); + if (irq < 0) + return irq; + mmc =3D devm_mmc_alloc_host(dev, sizeof(*host)); if (!mmc) { dev_err(dev, "devm_mmc_alloc_host failed\n"); return -ENOMEM; } =20 - ret =3D of_address_to_resource(node, 0, &res_mmc); - if (ret) - return dev_err_probe(dev, ret, - "of_address_to_resource failed\n"); - - irq =3D irq_of_parse_and_map(node, 0); - if (irq <=3D 0) - return dev_err_probe(dev, -EINVAL, - "irq_of_parse_and_map failed\n"); - clk =3D devm_clk_get(dev, NULL); if (IS_ERR(clk)) return PTR_ERR(clk); =20 - reg_mmc =3D devm_ioremap_resource(dev, &res_mmc); - if (IS_ERR(reg_mmc)) - return PTR_ERR(reg_mmc); - ret =3D mmc_of_parse(mmc); if (ret) return ret; @@ -596,7 +587,7 @@ static int moxart_probe(struct platform_device *pdev) host =3D mmc_priv(mmc); host->mmc =3D mmc; host->base =3D reg_mmc; - host->reg_phys =3D res_mmc.start; + host->reg_phys =3D res_mmc->start; host->timeout =3D msecs_to_jiffies(1000); host->sysclk =3D clk_get_rate(clk); host->fifo_width =3D readl(host->base + REG_FEATURE) << 2; --=20 2.55.0