From nobody Fri Jul 24 22:52:04 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EFB5440A39 for ; Wed, 22 Jul 2026 16:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784738240; cv=none; b=HW1AxW0h3SAdtEMOsTHwh04F8LLG3sXO1y3ekf7+vnkJ2EhFkh9Q4XQLhV/2nOIN5s3WUCGAfUHcHQ41BH6dTA3jfCJMfO1FecsJNIv88HKRQPe7jYdE0e/bYYw0ToN7JjwfowsXdw0vcNod2qlArdBkRUa2upgOG/jaK1WY8NY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784738240; c=relaxed/simple; bh=O7YZSJohC2QjyBimpbFrdvngQLx/Jj/DTZkXWXd5Fnc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SgYbnLh2gENqXueRATk9RH7FYok9/CzU5Vjc9YNSyAjC87E42ndNnSfRUH7kMz8t4uT2gfre4v5dmIr3j5yMNp8/Q4ecJHpnGICjr+689msXaPULcNZa2+h6PzrbcOKVvm7JGC5aEihcvScNShnF1WVi6R8BoQ7uz8DJtjkLlCw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LjhM5dd5; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LjhM5dd5" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ceaf8a1265so129288815ad.2 for ; Wed, 22 Jul 2026 09:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784738238; x=1785343038; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=VkUZF3GUgBycLRVSuNCfQrxXc8ty9gReEhTHtUNTyK0=; b=LjhM5dd5OmUMIIM8bCD5fA5shs7B/Eq0HTObq+8Vy9QmCuefUKFrphsku+sI+DEVR+ bOTz44TvxVXKXbGP8IEWAHtP+qqAq+ubGtnI+PIvTk4cPKmSNk5R+ijzls5Yjltl4cVP x+f1/b/EPKHboi5oyviv8i4/RPnE19tW8vapPlWyS+mkWxC+fG0LMZJw3ZRwTlmZHBVC GNiwHYM3lQFNbtU066e8DA+I119MS9iSX8vwlkeiZRFsKwa03FBSrWyNL73pwfedRSIE r9udyGApAHXPRDR+Zb5y5Q2zzBwPM4zYI8e08RupZ5LSyBL/gjzy4HhCrE3U/ysHS8fA kRtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784738238; x=1785343038; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VkUZF3GUgBycLRVSuNCfQrxXc8ty9gReEhTHtUNTyK0=; b=bbOTHY6ytt1BPKX3gjZxnI7gWLJ4kcYW3pOKEsHIx66+YC+tKMB1BZLTQJBJ2tEbO1 zRmBFHEvXSqbMqxw58v6zjdXdRC8hdl6K2pZ189w6epOSk6XsGsqftDUQi/WaTwA00ec SdUr+jRKLeVPodW6jDbsaZPSOMhgNAtE4HB3MpKHENd6XJfJyfVmpFsaHPRmPfIr0xhH 3BwS+nN07/qlVPFaTLwENw8Rk+HI1h8I6hsNGFKKjovArLZINPp8eeF8idg1DIV2sKlL D+ViqPSy53+g0M22/q6OSWEetkdecTL4nxVH8w+qV0QRb8yOTpAwCrhRES45TQn4ycw3 lDnw== X-Forwarded-Encrypted: i=1; AHgh+Rpo+nWrrv5pqpqsyf0Z9uZFcxtxMXTRjFc/BMHVZa9fWE8+X2qN9/4pcaKeCcc5cfoEFpMGxrPZBU/NZSo=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2XXVoJaudvW2wmpUjSmmzc5hgycpmjXxCQidYNwPQd6ZnOsKl dz0bJyPmpV0h1c+YG2CQDo2OKBZ87dLqKf5gN/2xxmSH93ogmBHR3lweOaGl9XQ= X-Gm-Gg: AR+sD10pCXfqmY4CLQL3ES1I1btIBMnPwOHS+wqHh/ETmkMY+CR8IhVN2CN7oHqZC10 AC7F8a4H2UEDKJ1A4UZKc00lfywy4KCR3HtTrS39Y4Sb/WUKpp0/NOItABrMw+/FKjXgudvWj52 wUFl6YT0sfTKf9EXMIgCwQfGvXsT2Xba+8v5qrxWoFupeHj4etjs65yPKd1TKKx42LG+kO6rX+3 T8GcP3q6n+2a+Azk5r1WfSofyarqCtn8RLJnn8Nle6zJvHnvYhqvpmWMy+UiCgdbp8xcXtnPboT dYYmO1dSkahAF2GEvbmmz0l7aqKlelsD74PRMsTHAJCqDsX06S5qMB0o4S4OGaqr2nLFMgRIzBk VX2WELq1ZQRFswr8b+bIsgH8rC/H8su++VWczyt9kb1hLeCuDGQsuHv549YHrRfmIfmACdxrHTn IxgBMeUZ7XnPf1gcBpeapQRgHUlg== X-Received: by 2002:a17:903:1210:b0:2c9:d298:6c06 with SMTP id d9443c01a7336-2cf34a0a6c0mr244194615ad.25.1784738237761; Wed, 22 Jul 2026 09:37:17 -0700 (PDT) Received: from t-rex ([2401:4900:c212:546e:3d3e:f0d9:52c0:8a0]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc8b0cdsm10801506eec.11.2026.07.22.09.37.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 09:37:17 -0700 (PDT) From: kr494167@gmail.com To: cl634@andestech.com, wim@linux-watchdog.org, linux@roeck-us.net Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Surendra Singh Chouhan Subject: [PATCH] watchdog: atcwdt200: fix return value when watchdog is enabled Date: Wed, 22 Jul 2026 22:07:06 +0530 Message-ID: <20260722163706.14238-1-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Surendra Singh Chouhan atcwdt_get_int_timer_type() returned TMR_UNKNOWN (enum value 3) when CTRL_WDT_EN was set in the control register. Because atcwdt_probe() checks "ret =3D atcwdt_get_int_timer_type(drv_data); if (ret) return ret;", returning TMR_UNKNOWN caused probe() to return 3 instead of a valid negative error code. Fix this by setting drv_data->int_timer_type to TMR_UNKNOWN and returning -EBUSY via dev_err_probe() when the watchdog is already enabled. Fixes: e4e0848ad046 ("watchdog: atcwdt200: Add driver for Andes ATCWDT200") Signed-off-by: Surendra Singh Chouhan --- drivers/watchdog/atcwdt200_wdt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/watchdog/atcwdt200_wdt.c b/drivers/watchdog/atcwdt200_= wdt.c index 8e3b18aea368..b91c748b3603 100644 --- a/drivers/watchdog/atcwdt200_wdt.c +++ b/drivers/watchdog/atcwdt200_wdt.c @@ -274,7 +274,9 @@ static int atcwdt_get_int_timer_type(struct atcwdt_drv = *drv_data) regmap_read(drv_data->regmap, REG_CTRL, &val); if (val & CTRL_WDT_EN) { spin_unlock(&drv_data->lock); - return TMR_UNKNOWN; + drv_data->int_timer_type =3D TMR_UNKNOWN; + return dev_err_probe(dev, -EBUSY, + "Watchdog is enabled, cannot detect timer type\n"); } =20 /* --=20 2.55.0