From nobody Fri Jul 24 22:51:55 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0670432311 for ; Wed, 22 Jul 2026 16:15:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784736947; cv=none; b=kmDnD4DTDt7dArN49xzK4gwoIJAF0NmbP4Ffo+mtBGT4u/pkkEDPStqTVRpOFq2V5AyiJJxFgfAIPufwRSf4QiViuFK3vpxqLcr/2O8BZJE1gCRa9Wn8pIt7DrYL4UIrlb9UsB6U0KoypKr10Bq2dIpzdYrKMGvSMvEtICJ3N3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784736947; c=relaxed/simple; bh=1WjDDJIs2KpwQ8QZiN+WTOjS6oF6XQb/0PQCbzOEvpM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Wng6g70HDDUhbpLy3roYvZW0gWlSgJssQsiZKR0s1iMyknMjziNB9CZM0Razqfw8H5zHmFwJ9nQn9SK9qgM3ba2OXAxPqqI+3miJMsmnQ87piNx0azeaHkWh3QT8BgW2hSm/TYcZs3ZVaIEMuZSRDXjrd83h4r7NaXS85D7dgtc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UI1Si5cr; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UI1Si5cr" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-cbb662575d3so1356901a12.0 for ; Wed, 22 Jul 2026 09:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784736945; x=1785341745; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=J5y6lwPBQTK8Q5EI0nQrZABCngKWM2qP9sIU4ndSGI4=; b=UI1Si5cru3RwicWXcBwdSVSvgLSCfk+K1AqFRfwbu4Y3Kob2jP/227ixbu2Iuc3Rm1 tA9i1N63yFLtIsNQZfoDg8gkBWgu/je7dfhhdhUei3lD0xY9ZN3YOO5l884a52x+Mfbo 50bxBu/W6tVtDqhCZ19wvXMctkAqNetZBISpXu2smce+TBiTzVmpOzqYTKBbQfHGCCfX DoujCiWYUE4luT+kxBfV3imEwpoY5OvHSngRCT1WwbZHTnvh68Z+NdfBMQ+vbMnAlyPZ eD9TSxZdcEoAS8+tZxizfgldWZsh0MBOubzxmCRHQxgUzI3hhW/TZ7LrmYrRtdED+aqA TuiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784736945; x=1785341745; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=J5y6lwPBQTK8Q5EI0nQrZABCngKWM2qP9sIU4ndSGI4=; b=G6yGgonlT5PPhyl5J96wUOETRKJIwsLLyWp7XUOroTJp8i9fCfXiE6znODXdplTIPX XOR5K7KMlQOfVosMc9Dj6/sbio2wsVo/HEV1scMyu3f3ncXuekZkOuua5EJkeoWozhjF iOWcdCyaA7KVBTS3mIdZrVaD1sh+rPSLYBsyk7Y37c9aQ006123jJp6DdbDcoMbzNVPF 40kBk8CokhHFIBvuolLSKfy5BzY/mAV+x1fusbnkUuPoQzVRhCGsS5YdrjiHADBGZYEL 3NxRgtrF8GUpByj82xL0V6dKEliRVmiG1yXISB7Au+cyXPhlCbW2IxRNOzqYHzeQLJU7 wPxQ== X-Forwarded-Encrypted: i=1; AHgh+RorUP+34ZQBNFA2duermm7mIKO9ko0ABI/jjF+ioopsJkITUQe2BYciXv+tUZU3Gx163UJq7hVCdLBSBu4=@vger.kernel.org X-Gm-Message-State: AOJu0YwHyns2sK44cHiPR4ggzdIqH+z0yYjROKSAQkHYtE7Lm1jVd7Ca ZSfvvtJY4hjHgo0DSf5Mq8D7Gqf3396v8VUrubm4G4n872b3jWg+wAI= X-Gm-Gg: AR+sD12fatS3dkfLc28FoIkMvdSwneP8HE0BCVsY8ZlVL0FM+J7wq9PN632OeTbBV7R 3x2mEChtxlA+JWVzJeAJBAck8ejsBEZo55QeTtTpbIT5B3Kq1HEpIxC4+xXHb3Xf9FuhC1wI7vF SXUG6QkSYDbniG0zi7BTmALRGTFVkxdNXAQRBLQGm954F/SjCi+EscxQrYnBz3jZy66xcKlvw0z Nd5Vghf7cZlzYlYD+oynWrBUBUs0Qts9KwB2rUQHhFC5VP2mLbgjxLrnYqTXNJt8SDY4NVgQ4rY PCKC+WQigkBrpv8vd9GjvMF4OojYNg34S/B3zSE4TmTsGtbx5i9en2APuoOyrLQn0++PDOg7hWs lUzUO1Ye77Ib/m0dR6Ch2KkjA3/D06LcRUgllNjhcmcaiUb1w7Ba7+p8X7IPHK6ufzApL0VzixY 4xtp6TajT+tTsBwTQUXpmmGjkjwA== X-Received: by 2002:a05:6a21:6f06:b0:3bf:6c08:2b27 with SMTP id adf61e73a8af0-3c3ada195f6mr26726098637.47.1784736944935; Wed, 22 Jul 2026 09:15:44 -0700 (PDT) Received: from t-rex ([2401:4900:c212:546e:3d3e:f0d9:52c0:8a0]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc193f8sm21024650eec.1.2026.07.22.09.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 09:15:44 -0700 (PDT) From: kr494167@gmail.com To: lee@kernel.org, pavel@kernel.org Cc: kauschluss@disroot.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Surendra Subject: [PATCH v2 1/2] leds: rgb: s2m: Wire up of_match_table in platform driver Date: Wed, 22 Jul 2026 21:45:18 +0530 Message-ID: <20260722161519.9610-2-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260722161519.9610-1-kr494167@gmail.com> References: <20260722161519.9610-1-kr494167@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Surendra The driver defines and registers s2m_rgb_of_match_table via MODULE_DEVICE_TABLE(of, ...) but never assigns it to the platform driver's .of_match_table field. As a result, the kernel never matches this driver against a DT node with compatible "samsung,s2mu005-rgb", making the MODULE_DEVICE_TABLE entry dead code. Wire the table up so that DT-based probing and module auto-loading work as intended. In addition, validate dev->parent in s2m_rgb_probe() to prevent a NULL pointer dereference if probed without parent driver data. Fixes: 63ccd117f425 ("leds: rgb: Add support for Samsung S2M series PMIC RG= B LED device") Signed-off-by: Surendra --- drivers/leds/rgb/leds-s2m-rgb.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/leds/rgb/leds-s2m-rgb.c b/drivers/leds/rgb/leds-s2m-rg= b.c index d239f54eee90..7ac2b1160c1e 100644 --- a/drivers/leds/rgb/leds-s2m-rgb.c +++ b/drivers/leds/rgb/leds-s2m-rgb.c @@ -363,11 +363,18 @@ static const struct mc_subled s2mu005_rgb_subled_info= [] =3D { static int s2m_rgb_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct sec_pmic_dev *pmic_drvdata =3D dev_get_drvdata(dev->parent); + struct sec_pmic_dev *pmic_drvdata; struct s2m_rgb *rgb; struct led_init_data init_data =3D {}; int ret; =20 + if (!dev->parent) + return -ENODEV; + + pmic_drvdata =3D dev_get_drvdata(dev->parent); + if (!pmic_drvdata) + return -ENODEV; + rgb =3D devm_kzalloc(dev, sizeof(*rgb), GFP_KERNEL); if (!rgb) return -ENOMEM; @@ -415,6 +422,7 @@ MODULE_DEVICE_TABLE(of, s2m_rgb_of_match_table); static struct platform_driver s2m_rgb_driver =3D { .driver =3D { .name =3D "s2m-rgb", + .of_match_table =3D s2m_rgb_of_match_table, }, .probe =3D s2m_rgb_probe, .id_table =3D s2m_rgb_id_table, --=20 2.55.0 From nobody Fri Jul 24 22:51:55 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D63E439F6C for ; Wed, 22 Jul 2026 16:15:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784736953; cv=none; b=JfKp31qbVxHXWToz68heHlghPZ8OE6ISnDYnzVt9puJ3o5Nl291KsGTW8j7/9M52IMb/wxbZnGR7QF39n8/OX6IW7Nim+zhHodDEJo4/smmTCaPsbdBwQlau1F/kM4qIqNbauZrk5USuVBjUMwx+HqJPludzeizeYaSD5yHpprM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784736953; c=relaxed/simple; bh=/AWH4TVkzjZlmGyul2I4eG0vLDHnmIL4x+qTUTM31ZY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bAOJ53YsYs9CPTMrmN1U/ThgLutEwsTdAWQ60F+eyHkL48rc1hOEJFQemYvbRQnV/9pkRkTjUf7T8oDh3FQDvtMrbtl4/DnnbCU3Mofd1Z8cB73v3hJXVbhb4BOW77izK5vbTmcfUPZ6VcIDYU93VpcNj0Sc/fYpsKTtGYBPWEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QWbV94Tz; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QWbV94Tz" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cc61541f8cso76566855ad.0 for ; Wed, 22 Jul 2026 09:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784736951; x=1785341751; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=C4eG33ks6I0ktj16HGNoVGjOMuTcAcc6qdfPtWq1IkM=; b=QWbV94Tz2+K9Ceug2wHEZy4FXtC6OVaHztFjH4jXD3gxFux2qlAyw1KUFxUQ1QVjW0 3gYP9qAu/9j4vNxOjjnSVodAw+2YdWKKNTloiLfN50xyDUxAO6Z8rfWXoq1Tq//6pSI1 myk1WdnsH+YiBnxGe9yb9mUhxVLYcIqR4ut01e5BOM/mid7H2aR+6wmsSpBGK5GuRd0g uJ2SGJnW6DTIONyQG88SCS8r9chAcZA0ZF96KhvWZgYNsTHuyk7fD59lDsP4qXhRddC3 eRHU9wOFE7IHwrLIMtPSznsllVVqsfQEvtuWxwR0MCUKkGo0Mu5XE+hL4TqAGVQHCZ8r fbGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784736951; x=1785341751; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=C4eG33ks6I0ktj16HGNoVGjOMuTcAcc6qdfPtWq1IkM=; b=TRIcBXH+yJoYuGhR0SWBgFV4zwAeMETJzIWxIOsl3XdG782Xbg5027eA/0BlJgkcR3 eBLSYMXHyFnZaYOVhMCGiC1wRDPbmyV6KvQ/mtk1MeHAkxINDcp5VaD8IavPT7qVdPNr hwwQuY99c2i818WnDfE5ySXsgFZFIqI+Bd2Gw9RDYn+fjG2x/uIur1YwvGGlOHwhnzlv 4Mg4b5sfASwfC8olngqjNjP/NLYrWWyJpgKoNkh1+m3ti/MKX1g0a6iN7mdjJDAMUlVZ TcqftOAKH/3GXzVqcQIpIM4U79RGQBYgRZvC1kkxbrGSwQDRjaeeAvaZ+K9ZR3X7LNUz vplw== X-Forwarded-Encrypted: i=1; AHgh+RpmypHzelcjYuaaKlsQv0oNd3Pd4zZZz6BivDGC2OXDs/H2CL+MgGBzG4an7fZJx+gOf4XMJOfEckk+Agg=@vger.kernel.org X-Gm-Message-State: AOJu0YzXCv/TmAJz2ATYFyPthAF4hbu59t2Gi0nA/EJTFzfWM8DluhFh QDqUcL6hiEf6iRIW1uaJLIxJIti+6jY1TeTbhLr9FxATvzzoBkPuXFY= X-Gm-Gg: AR+sD12QdoUIUrmKM7ME98TdeMqsvu3XNnkArIJbl5Nh7BANPAzo/lXX1FhJEFdQC3b YWlxBDVurAMclJMencetc8RA9kl9GN9DMREr0fwZgWpKGKZpZ234f1sdT/hVcFUt6TYWorw6jDt BI0w/jHivMlhBs7TYICt1m/X7U6Peze1BYm5uWnpPEZ7y5hj42GxjHY0pLhX8ObKsKXpqRRIP93 KTrEBr0f2yzNVbNb4elggql8JmNm5MAI1ZCz4SFIkMIIY1qHKJFRaGPnUC1Mg7RCk6owe97OuN+ 0Lj70e0LAV4hKU8YtGNzhBFRkdYUrm1ehT1e6hLrvplP8UiLdKHmPuFHEoRyVBlan7zdL+o49n1 FouVLeTjWB61nYnjEIBAnFadx+/XsRQq7kRxuEa4GKU9cPwnJQfSEEI6L7lvUTsxs/4W4ausjaR 2aQSSNKlvhzYw5NaRgaDdazMSAh9GTQcoqnEL8 X-Received: by 2002:a17:903:384d:b0:2cc:10c1:352e with SMTP id d9443c01a7336-2cf8ddae3camr44679535ad.21.1784736951332; Wed, 22 Jul 2026 09:15:51 -0700 (PDT) Received: from t-rex ([2401:4900:c212:546e:3d3e:f0d9:52c0:8a0]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3147dc193f8sm21024650eec.1.2026.07.22.09.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 09:15:50 -0700 (PDT) From: kr494167@gmail.com To: lee@kernel.org, pavel@kernel.org Cc: kauschluss@disroot.org, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Surendra Subject: [PATCH v2 2/2] leds: flash: s2m: Wire up of_match_table in platform driver Date: Wed, 22 Jul 2026 21:45:19 +0530 Message-ID: <20260722161519.9610-3-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260722161519.9610-1-kr494167@gmail.com> References: <20260722161519.9610-1-kr494167@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Surendra The driver defines and registers s2m_fled_of_match_table via MODULE_DEVICE_TABLE(of, ...) but never assigns it to the platform driver's .of_match_table field. As a result, the kernel never matches this driver against a DT node with compatible "samsung,s2mu005-flash", making the MODULE_DEVICE_TABLE entry dead code. Wire the table up so that DT-based probing and module auto-loading work as intended. In addition, validate dev->parent in s2m_fled_probe() to prevent a NULL pointer dereference if probed without parent driver data. Fixes: 02149db273a9 ("leds: flash: Add support for Samsung S2M series PMIC = flash LED device") Signed-off-by: Surendra --- drivers/leds/flash/leds-s2m-flash.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/leds/flash/leds-s2m-flash.c b/drivers/leds/flash/leds-= s2m-flash.c index 6ee8db094611..6097c75b681b 100644 --- a/drivers/leds/flash/leds-s2m-flash.c +++ b/drivers/leds/flash/leds-s2m-flash.c @@ -279,10 +279,17 @@ static int s2mu005_fled_init_channel(struct s2m_led *= led, struct device *dev, static int s2m_fled_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; - struct sec_pmic_dev *ddata =3D dev_get_drvdata(dev->parent); + struct sec_pmic_dev *ddata; struct s2m_led *led; int ret; =20 + if (!dev->parent) + return -ENODEV; + + ddata =3D dev_get_drvdata(dev->parent); + if (!ddata) + return -ENODEV; + led =3D devm_kzalloc(dev, sizeof(*led) * MAX_CHANNELS, GFP_KERNEL); if (!led) return -ENOMEM; @@ -339,6 +346,7 @@ MODULE_DEVICE_TABLE(of, s2m_fled_of_match_table); static struct platform_driver s2m_fled_driver =3D { .driver =3D { .name =3D "s2m-flash", + .of_match_table =3D s2m_fled_of_match_table, }, .probe =3D s2m_fled_probe, .id_table =3D s2m_fled_id_table, --=20 2.55.0