From nobody Fri Jul 24 22:57:24 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 219E228CF5F for ; Wed, 22 Jul 2026 11:52:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784721148; cv=none; b=NRa4mAlCvPdJXBYj4WGviBq9I5Rm6UiZhgCZnRybe+6AKJGvxzOHUVJACTdcW/TA0m6ahcLd4/LRHwVFEhgWEvuwfnkGwF01AYU3MtWXUkR0rfwUZKBXOw7iBPF1WHhUMy9gxANDirHqzHoRDtr3omU3YXf8FfoJfc4r7f01R6g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784721148; c=relaxed/simple; bh=+C3ZRgNpPegs5K3UW4ksuKAEQAzCJx6g/de+0vlz5uE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=UVBXvx7YxYTkmsphO0NWr3Jmk88aRGprZY1jXCZDH4trygB0raErkzF5fyKr81CPauf25ZMqE6xajD/1X1C6aYoFLYfVJmSXRkqQJ693ep+d6Ntm+/v3GlMzELp+e4ujVLqB4uutX8g8d4uFR2cM54HceOoOHUPgxg3UL1gxnIg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=Lw8dFRDB; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="Lw8dFRDB" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38dd55ad76cso5027002a91.1 for ; Wed, 22 Jul 2026 04:52:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1784721145; x=1785325945; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=269EtdxCHJWuu+Iv/X7Dxw9E+WzL2+4KdhP0CYuICuU=; b=Lw8dFRDBYes7MJ5RSuEEiSREwIE0trIEsCSIsdRWahma9/oydnul51SfA70Qj6H52c BWHdc8j3T6rCefyuGUEZsI+lf8Gsgple44jlOgV7fXIYk74oAJKm1vDSJwstUlYdVoBs 0VE9SOnSdD2aYBsxQQj3cbDJS2GjCAqMZsIL/PvmFQ8tmjL3jje4ax24nHhBzmTz0BXJ 2qCQfFxZd2WnMdphDiAbwMHU6i9QXcqgcW+omdOOF7n+2z/rC3Y0dU/RIQg7h6PCbk0l sjlRWgHZGCTKMZpyVG/fiRGM9Eb76BcOC+AMtS8/yxyVIAI7u1zk/K6OgZAa5bg1n83L ZC2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784721145; x=1785325945; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=269EtdxCHJWuu+Iv/X7Dxw9E+WzL2+4KdhP0CYuICuU=; b=HqG9V7WR8qpSGHLbsOUKXz4t8zZnl139K4iqrI+9Taz6IbKAgHUNiNb3X2CfLzjtNZ STL/nlbD4hF+1D0sB/WQbB30Jj/dYNSbTh4BhZu+mmtSXlEgo00M1fbMn2rECvphRAWY KvLTrUw4NBuP7s+Cbo4/okWq6GRCorwnSheuEbWk45b5BBz8yaSncnT/p95YYDg34FTV rrLxrHbDPojyhoETHyB+Igyy/kKtQMuJ+6NB128yeMBHv/+14BNSXrpVXgEsY2HrHNVM C+ksmi/3rp1ofdzp1WWUQ+T5+3V01IuviSutXHqj14rAp+UVkRJTT2k4nOvaRCtBz239 z76A== X-Forwarded-Encrypted: i=1; AHgh+Rrr0cbUsYnV4PySqJuJAqiDn5471Lxs4nbA4cTvoVlhmfwDzND714Y4jeH8s9Ezp4VKep+untzcA52fkVc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/tHmM+vQYugA8YNa5wh/HPyjRcFETI07egrpTchlC+383/kuo NMUS/FMHttEpli8Wpse9fKxwsTwEkZlPfui6Wrj/isCBrO+SILn51STwmRs+lkrvYW4= X-Gm-Gg: AR+sD12ycggNlnPLAN56xJqGuIDhLWsBpb1X5v+iu52IKxJSSj7O2F2xy9/qBTVguZc MPTZTs+IEC3mU7q+7Q0jmX3VEIaukaZ1cOshfy0i19d/VsgAC6fCzQqHOYDTtoGjwNppWGQMYuU mjmdW74nzPQBz/N5Oil2z97DjxRpUY1gdeP82q1HdtQQphRzVLXUu/skcBkQWvABQo6kIfgc8Yq w60tNva3/GMYoVJv/y5CaiVgSYLHFZfaGGYyg9gSqa6NxtPTLn3+ISKDbQDna77lGW8AjN0Am24 hnLAlOW43u8MrDHz/WRgTrzx2Qj3iHZ3Cy/WVQ/0ufUQ4ejZQGSzPIkEVY/6doFF9x6UkvCbJWP GjbroZKImtVOzFjEmtadEjD1xGOmGltSYVkpGFlKVVQmQ+ySBilJUUUQUk4iaPo5P9LVx64/JaY bmzVas4bDRPBxzmeMkkLZJ/eotyhj5/foLNxISdg4qVpDsY6WGU0XlCqVPahN6D43YtfiC/u25m OfiaOGo9sa8PjmzmawqAG/2kuB13B7n X-Received: by 2002:a17:90b:1645:b0:38d:eaed:4adb with SMTP id 98e67ed59e1d1-38ea391acb0mr3383557a91.20.1784721145493; Wed, 22 Jul 2026 04:52:25 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-13d1300401fsm8434349c88.3.2026.07.22.04.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 04:52:24 -0700 (PDT) From: Abdun Nihaal To: pkshih@realtek.com Cc: Abdun Nihaal , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wifi: rtlwifi: pci: fix error path in rtl_pci_probe() Date: Wed, 22 Jul 2026 17:22:16 +0530 Message-ID: <20260722115217.131458-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the last error path in rtl_pci_probe(), the cleanup functions are skipped due to a wrong goto label. Moreover, the successful call to rtl_init_rfkill() and ieee80211_register_hw() have to be reverted. Fix this issue by updating the labels and adding the relevant cleanup functions to the last error path. Fixes: 0c8173385e54 ("rtl8192ce: Add new driver") Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/net/wireless/realtek/rtlwifi/pci.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/pci.c b/drivers/net/wirel= ess/realtek/rtlwifi/pci.c index 73018a0498b4..98365176a901 100644 --- a/drivers/net/wireless/realtek/rtlwifi/pci.c +++ b/drivers/net/wireless/realtek/rtlwifi/pci.c @@ -2227,13 +2227,16 @@ int rtl_pci_probe(struct pci_dev *pdev, rtl_dbg(rtlpriv, COMP_INIT, DBG_DMESG, "%s: failed to register IRQ handler\n", wiphy_name(hw->wiphy)); - goto fail3; + goto fail6; } rtlpci->irq_alloc =3D 1; =20 set_bit(RTL_STATUS_INTERFACE_START, &rtlpriv->status); return 0; =20 +fail6: + rtl_deinit_rfkill(hw); + ieee80211_unregister_hw(hw); fail5: rtl_pci_deinit(hw); fail4: --=20 2.43.0