From nobody Fri Jul 24 22:57:23 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F9BD4C0404 for ; Wed, 22 Jul 2026 11:07:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784718447; cv=none; b=UjJOmCZgaQ8d9VwrCpOTn7X5w+J9QV/myR99pT81eUzDvZVveRPCoUM5nNiZLin9PkGs0j+GWcwI8ZN390PMVOjveczkfxLqVvXGV0pcpeAJRM9EuG7cumTLu9ZCQ017dofDfkecPq992NYUbz0d8XfxJVHKud+3Vqo+wrbKBJI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784718447; c=relaxed/simple; bh=Gvq8bn9U5dieapHENn6/tVPX84MtSWPT3qgQXTSmcc0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TjiDmN3oj/pK5SoC6j20EYks9Pp1VgnfmulPEFfJdCD+NwqBqqREKfsAh4lbcaBeqAkKjqC5eeUFipcBWebH4cTalvXFOABP08vWIe7+22iUJnGhHMOu9DgzHPNuBMrmbkwfu/UXzSevXf8g4XOrX5sKVg2Mu2YwT5ON1DTSRgM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=nhul7KZ5; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="nhul7KZ5" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-c9e30214d8fso8827819a12.3 for ; Wed, 22 Jul 2026 04:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1784718441; x=1785323241; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Pn78C/RraBqASlFsZzfGipH4Pd/7ButyH44MMOGEmn8=; b=nhul7KZ5qD0HjlCk6J4jD9jUHvB5LRm5qIKfGa2iyt3dnJS4hHWlwHcQyqMc0o4Ds+ hxr2Nyg8o6004vR3tGdZFJEOuq2A9HE9NdzkWg2KD4i8kjndLQ/vqqkD/oDLFT25gqfE vfQg4asLj3/S463ZVccc+dRF9/EXrKEwwhyQIlr5ZwRLtS8er5Ps3MEQZuVXiMCLChmF Lp4Z0SwpTNZUT9JD5LZL5khVzTQbEoJVHe8R6DtlQ/RCaS3/YtG3O1yOI+zyrbpKsLWZ 3QZVQW2GP/z2BGxOAzXUcg39RCtlRPeGhP2A8RnSVzohQ0UcGTKlD7XKZPCO0GMF8YUX vEzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784718441; x=1785323241; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Pn78C/RraBqASlFsZzfGipH4Pd/7ButyH44MMOGEmn8=; b=Vq41LF7reYxObxuo5CfFABemLGvAKBvQGQ8WL8/PCWLc9tQFA5QVm9RknsnM3hliAs 6nymC5SSQ0SsaEgmnf7MI8/14y1uwN7KGHN070CByLBY+5w9VNpFByBM36/P5XqNLUav UTqLwb2HsHNVVeT1Tl6o3jzLthBU2CaUwG4bPC8+EUbAnXfURjWryzdaYK7+YDLvo5at euEzakHWfef7UG/he9CE43v8mXR1lPAiFCTUx0pZ5sju3BMHpZUfgzVyO4QHN000Xsco yCNplboKiVaUQcEspIlExJc37ypJgQBskoP++bwmy36SrSWVB4tS8EjkRrJrWG6ya22B gqDQ== X-Forwarded-Encrypted: i=1; AHgh+RpMEGL7RxnOmMBrnm3RoyYQ9/O5nryojfTgFaNE+GJ6uwTRMnMJTIZVfRQ3/PqYfO12WzKVQry/pbPANp4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyz21TWx40wvAWbcLOJ2wV9jcHodowcwfeuEW3ujcvmo8k3dWxd gkslFA1JVZHD7PUfIb/ub5tO5G4Z2b3bguhdp5YkTvl3d9GwKuJ5DVfVoQPRD0NN/JI= X-Gm-Gg: AR+sD10FCXTRd+2GbLKMpwuFJyreVDwnmCNzKHXg4wjD/nrZYAQP/lD/9i2RakzLmRO RoVEVdfXik4yF1nLUmXwqHnMPtdYoBN8qdv1u4fhU+3BF6Haoab3ZmkMyRk+LGEFIUA0xlMqlTb 70tUa8bA6K150amAmsUgN8x4Hk/0IB3EUYY1mGtK4Yt8QqL+NCa5Mg0rxBWyO7ncgRe04VoHL87 2V5zyKa1UsGCwAFG3iJI77PMs2X+iOnOAm4qBSf9lWl8ugQRnuKiNDJc49gkAb3vYjN4U3xSz34 L434YN5dsta1NaPnFmJ8mQTZ71YhTAQBGTKDVGJPh1Z/+gexNDWc2S6jbQIGQnKZgcOVnV1jZHG mn67z0Qb9aajmS4o1MLO9Pf/yjbijCzRhAY1SvLVvT3Lne3EiWpwmGslO0u1sRDvCoF/tG9tSES zxXISaOgNSQUP5w/odanpQn77qdnfky25NyjEmeOkadc7UEtLpB3pq8NxmVbBfOOxMAD8wZ3XQo ELBik7+Jq7Cir0PMLNQ3qv+sgBWpTPR X-Received: by 2002:a05:6a21:b94:b0:3bc:5284:5445 with SMTP id adf61e73a8af0-3c3ad7d7fc8mr25322681637.21.1784718441385; Wed, 22 Jul 2026 04:07:21 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id 5a478bee46e88-3147e07000fsm15952879eec.21.2026.07.22.04.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 04:07:20 -0700 (PDT) From: Abdun Nihaal To: arend.vanspriel@broadcom.com Cc: Abdun Nihaal , linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] wifi: brcmfmac: Fix memory leak in brcmf_sdio_read_control() Date: Wed, 22 Jul 2026 16:37:12 +0530 Message-ID: <20260722110713.115988-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for buf is not freed in some of the error paths in brcmf_sdio_read_control(). Fix that by adding vfree() calls. Fixes: dd43a01c5cdb ("brcmfmac: use dynamically allocated control frame buf= fer") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/driv= ers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index b725c64e5b5c..0900211ba2fe 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -1792,6 +1792,7 @@ brcmf_sdio_read_control(struct brcmf_sdio *bus, u8 *h= dr, uint len, uint doff) brcmf_err("%d-byte control read exceeds %d-byte buffer\n", rdlen, bus->sdiodev->bus_if->maxctl); brcmf_sdio_rxfail(bus, false, false); + vfree(buf); goto done; } =20 @@ -1800,6 +1801,7 @@ brcmf_sdio_read_control(struct brcmf_sdio *bus, u8 *h= dr, uint len, uint doff) len, len - doff, bus->sdiodev->bus_if->maxctl); bus->sdcnt.rx_toolong++; brcmf_sdio_rxfail(bus, false, false); + vfree(buf); goto done; } =20 @@ -1813,6 +1815,7 @@ brcmf_sdio_read_control(struct brcmf_sdio *bus, u8 *h= dr, uint len, uint doff) rdlen, sdret); bus->sdcnt.rxc_errors++; brcmf_sdio_rxfail(bus, true, true); + vfree(buf); goto done; } else memcpy(buf + BRCMF_FIRSTREAD, rbuf, rdlen); --=20 2.43.0