From nobody Fri Jul 24 23:32:06 2026 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82AF733939D for ; Wed, 22 Jul 2026 10:39:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716756; cv=none; b=B2a4vDuwd0w6qFphyffRZZz1ss1mcQYZFBJEXwM5MGM3b6+fHO0Cwc8X3y2Nc4ix6OPoFsQNU9FdqN831lxyAjesgP2sLj2I/71kaX4ewD1ahTEqgN7p5dehiUx2wvLMKTWm5jrcmXWQrHlI+PjCVxwiee6UtKD6V1XV5eZZwU8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716756; c=relaxed/simple; bh=qVkwbm5skxHmjijSQlwkYEBcOxBNQ7+31ovrvai2xds=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Dq7dGffsh2zyTUu5y/pWGqnn7RaoDg6xcgIy1igY/LsSyV1Azll8ZhTzmFqd0PeC6MM3iAC0h97VzLW56m7lRcqYIB6m0LNxYO8UP9c9nIaGp4UURXRFIM1iLyO/tr1H5qq8Fz8fNgfaCJItpaYHgoZ3B3xdVMZcL6ohWFhYrq4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=Y84w2YQj; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="Y84w2YQj" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2cf50c6f235so45682155ad.0 for ; Wed, 22 Jul 2026 03:39:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1784716753; x=1785321553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0Nme6Toj9C3wtO+kV+jhiXnrP22CDDJWcY5DQqOuABI=; b=Y84w2YQjPHNvZbIZaOnXVY03cU1FLLT4uo6G39NScqUCyfG77S+Xm+2FMusxSDp5Ta jqkg+HxyHfaDwgLaBKeD4aSnDF3jfAZHCuPdhGh9ga3rA5JrYvWv+ycjcT8tgJvI0Th3 Y7XVwh0NA/SwjK0kmHttTWIADe6ZumEsWinX1+HKov9zRk1rT3Xuy/yvFsPuD9jpKAEe bIUDdthVin3B15Lp/RRuwCie5cXAG0a1iqu8NGeag+1w28cqsa8w9gpI6NevwJWlWXNx JMohUqMI3ipkdHF94lwZxTzmv0+dXkO5tghMTKz3RdL41eo2zqpOIVeKQqGH3HmvK2Bu 6SQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784716753; x=1785321553; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0Nme6Toj9C3wtO+kV+jhiXnrP22CDDJWcY5DQqOuABI=; b=KyKVYW1+BeqnAo/A0MsNg8Co54thfsh24QFLZ1pVbxFHOlAIpELi/1IxU2UsaWT5Vx mFkTqozYnW1W89euNTH2JX194DWaYF2lGGrsCU2iTnRJ5q3aQZegb3CuLTmVNqSz7B1f CKMCjy+5vecKhOyk5XdgGJHPZpK384K6YOTBTRcXYC5CLPybMBna42KyKmm9/oNq5UV/ aMs03kTHQyfre7VJyHCC5WXhX1xiFR6WcbtL57345YRdE8gjyaCwbH97wWDaww+PisZA m7qALlj72bI4XtJGz5olXNYvhwp9TQmBApFmpWNU+pfZTFMYf27dcb/7+gVVFbp9mBIK hY6g== X-Forwarded-Encrypted: i=1; AHgh+RqGX3v3NfgVvIW3wv8Y4kvqkcrk/DnRY7Dy4V+fQ/YjbwM/xEZYaT7nQpo/u3YlZpVJe59ielSFXmwnKn8=@vger.kernel.org X-Gm-Message-State: AOJu0YyBM2z5y6YpaKkPlvjPKs12Qi6vUDMC2kyGpb8+Pn/pzbQpr/tF 6Oy71Lwr3WBticRnipgyGWzdk5DxkfryS5R8KqqGA7D0AsICJVd4ZUEnVTq9xLgIvF0= X-Gm-Gg: AR+sD12LefwQl/xUByeNCUrlrM3ECNYMw5rBHm2RNygBx3x2hT+T4EM4Tte7SXX9nri GSUDP05vAbRmD7uueZK4JlfCmem8XVlbH5uCfexxZ/WjyieLM6IsQoRn7x9SCrd4lcU+92M3+On MmoysAeHS6erLxvVm7nnymDyQsUcvYJc5BO4FWKvV2M+l9mlsvCNVfXUX0YGfkzO8thcpaNE3pg xvFdhwZodansxbv7aiYVZcTleKvZBih7A5iYaYFXnZcauK0b9VuZcdMZqBbyOynLWNRqEutvbA3 eNIWD1GkVrvMK/1q0vuITabm8zjAuDxbowyUHNjIYls/FQUzTXADwFmbzd3BeYCMsfJUamu0EKb Iu2N94zPKjoPC/XJXvJ3HuLW5ry/ijns9eJuQNedqob8kInVtlE4RYZW33vz7w1ZYXGmHRVZp05 FKOB2Eq6sZoPgzlJI5RC7783a5BnwDZDFC7HyveIKdW4q1sTLL3LvUF6/8xt7JzuoD+5jZ7O7B4 Yn2hglfrooavoCL/lREbI8kDjDiKkI/ X-Received: by 2002:a17:902:ef01:b0:2cc:d192:50b5 with SMTP id d9443c01a7336-2cf349aa87emr250699035ad.34.1784716753616; Wed, 22 Jul 2026 03:39:13 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id 5a478bee46e88-3147dc7d8fbsm9185429eec.10.2026.07.22.03.39.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 03:39:13 -0700 (PDT) From: Abdun Nihaal To: mkl@pengutronix.de Cc: Abdun Nihaal , mailhol@kernel.org, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] can: kvaser_usb: Fix memory leak in kvaser_usb_hydra_get_busparams() Date: Wed, 22 Jul 2026 16:09:03 +0530 Message-ID: <20260722103906.108571-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for cmd is not freed after the call to kvaser_usb_send_cmd() in both the normal and error paths. Fix that by adding a kfree() immediately after the call. Fixes: 39d3df6b0ea8 ("can: kvaser_usb: Compare requested bittiming paramete= rs with actual parameters in do_set_{,data}_bittiming") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c b/drivers/ne= t/can/usb/kvaser_usb/kvaser_usb_hydra.c index e09d663e362f..efbb7bed34c9 100644 --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c @@ -1626,6 +1626,7 @@ static int kvaser_usb_hydra_get_busparams(struct kvas= er_usb_net_priv *priv, reinit_completion(&priv->get_busparams_comp); =20 err =3D kvaser_usb_send_cmd(dev, cmd, cmd_len); + kfree(cmd); if (err) return err; =20 --=20 2.43.0