From nobody Fri Jul 24 23:30:20 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81C30339377; Wed, 22 Jul 2026 10:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716518; cv=fail; b=rDmrPOuFHf41tWIq/hrTbhBgC3LVznQwVRgf0rr0+IaxakZxxH3t8kT2DFVBoF4r+JwVZVVm0/zVa4j55W++s4ZqKgTPqR0J4/5LyTM8LAASIfXTGI/gcpSYwpm6PmsZps/FUPeKYHDQCeEHAS33DZyWUJaTJOlZrAqEvDPfnlM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716518; c=relaxed/simple; bh=qbBPJhj5kZ8UJhk/vPmyQJjTV+olhnNR3t9cAvTjWE8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rbRRM+taBqy+5jnGQCHlHrf628e2aJ8Sslgb+EFOUQpiGHXQt/Ga0W6Jng2SBnfb5NOU4NQsXJcUVYOOf+/pTTzgULNU+HaBQYFD978PBHFClo15RRhaxx2uIBVHDemnLLeCNaCUiKp4SbM7w61UtPLUcXcK9JayqYGeqkWGqRQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=iAM/8qtD; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=fEpXK+Ul; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="iAM/8qtD"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="fEpXK+Ul" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M5NoiM004689; Wed, 22 Jul 2026 05:35:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=1eg7I0hJGx9sY0p5u23DGN2povJ5Pd4LuKLV/45zv+E=; b= iAM/8qtDKczK9lS0GEt1xwZJijqr9tdaV/NIPvyHbHXoprculIDrbLORw1ug1Hs7 sfBZWgfUMKeCeewfz+L+KG4Ts9ZSoFw5r8RkzPRw39kLgGAim5FtKxr5Dj2zCUtv 8M94eK8wy+Vs9jTVd5BaXO+dWc+7+3S0lC9h9zdy7WCOwaYdpU1MAu++d1mHbjDI 773YZlBZs+KEUbo8WjGclXKKqofwpBItWUqBC7pZD/8ZjmRjvdpkv0c5K7RlpJlq yz+VXGW1oXWjjQBN5LS0RC1jGLNL+TzrbDIWcd9sMqzdKG3tsp31WYC8OQfttl1T CCh1gT5qpGMFPTrbuKcDlQ== Received: from cy3pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11023096.outbound.protection.outlook.com [40.93.201.96]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4fg6vynn2v-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 22 Jul 2026 05:35:10 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wnuc7L42xCGXYz4t3pGXyEMNopXQHQBFaIJZPXeKD40Omj5w5Uhrq/k2WPwvX06ilmPVbZsJQ/iCduTIf/3bpC6/6GIQ4Cadk6mWu6eUNvkyjYPsHHnRfCnmbVl3vIAegPx8gXxrfDiQE2E+a7N0cEejRS5nlYPzfLIYXCrrvk4iglTVr/Knz5x2sbDO2ShRfFrS/rxhtHM7VFWXPthSCA0t8c2fkUR7TPNg8C+UBEeOGa2qX9DmCAODtX+PKNHxJGO3NDKR23AQSClhh4ATsNmKji37TNJ07oKQTaYiFSV/pBUIQlH0AE0MezEXxcd8uDcRkJGb3ShS82IerUcPBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1eg7I0hJGx9sY0p5u23DGN2povJ5Pd4LuKLV/45zv+E=; b=tFzvPXlx7veHCeUS4rD5+49LHmOlGPfqNnQqpj6Gl5kzCe5A9LUZRsiaLAVNnVzFrWYzyqNAZN8MzvFfdzUObTlvIycRJNWWNfBydYADjMPg498ve3jprRcBG53RMqVeYX0tvXHBsTX/soBEXF+6en2SsHAaJ5SKT8AOnRLwMVglxAK2AJr1M3eLDjydYs7cxNzNg9hE1Y+7tUw/4+i3nu7nC48vVF0vOJh8w9eMAsC60TgfjEfG/EF+3cBZWwN8fJf8FuA8MNJJpAn4IRsZ4R1KLgHweh8oALryrCvrlkDSPc60iaD9rnT4plzNFbHfNEEZUe4MOamT6FLGyx5hvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1eg7I0hJGx9sY0p5u23DGN2povJ5Pd4LuKLV/45zv+E=; b=fEpXK+UlJbe+MiBRXk0lwijQuEnS1mSNP6W2bx7V8rFDTrmyU/1wNWLI3GXgA+I0dFTGbKDh28ZOrSA+8Ja+0zuZNsSul267wq/X3+9uTmFmTdWYe2cHq4tGxbv9sUtXpSh1Ns+cZIsXIh8FIIof5AFDCSR47QBGVIz/BarGohA= Received: from PH7P220CA0025.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:326::27) by PH7PR19MB7607.namprd19.prod.outlook.com (2603:10b6:510:26b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 10:35:06 +0000 Received: from MW1PEPF00016159.namprd21.prod.outlook.com (2603:10b6:510:326:cafe::27) by PH7P220CA0025.outlook.office365.com (2603:10b6:510:326::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Wed, 22 Jul 2026 10:35:06 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by MW1PEPF00016159.mail.protection.outlook.com (10.167.249.84) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.0 via Frontend Transport; Wed, 22 Jul 2026 10:35:05 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 4E9E9406545; Wed, 22 Jul 2026 10:35:04 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 2B2B182026C; Wed, 22 Jul 2026 10:35:04 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org Cc: lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 1/4] ASoC: SDCA: Correct pointer passed to devm_acpi_table_put Date: Wed, 22 Jul 2026 11:34:57 +0100 Message-ID: <20260722103500.872714-2-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260722103500.872714-1-ckeepax@opensource.cirrus.com> References: <20260722103500.872714-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW1PEPF00016159:EE_|PH7PR19MB7607:EE_ X-MS-Office365-Filtering-Correlation-Id: 690a21e9-dc33-434d-9d62-08dee7dce558 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|376014|61400799027|36860700016|11063799006|56012099006|10067099003|16102099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: klDx/8iSjHpOYUkhJzFXAJquSs0WIUYbF3ZLMz65x4qLh01ATjaLjN1ZBDRCF/9DyqAlWK0rE12PhEIxlsH0lWuZUTbTOryCoO4Dho0F8vNle4ZltjC7yazqhDoQxLlkvWlHCN5XgEkQO4iaO0XricvzldJXBeDhZ2auBl5JOKy+DT96CUtnfQfI4eRVMa4sTAilQQ9/YczMnLzUCqsHsfD/xyjeDla4Xdy6TIZimbsYXRmzDE0M82hHr7AYmdZ5WaqbPkvYQ/LT4xoBiaU/zU9AEhDZ35c5zw059YgkWgHDLBAEDD7cKOsv36ig61ClrPywIToNxHXAxLuBj3G42rM4XX5HP5QfYG4KL67kUzsmO+/dv565hkp+NF6FOwQiJOIaQeuhgzPeHsuLRHWkxmwLQknHW62AVABGyksdY59xF/WCHebrj5+JuqdGohWeSRrBPTciFR/Ht+WgQaT5a9LN1d7R2kcIaa/yQRMwJTkh6J1XJnbsl2ZH0uOjfs2K5eflIGopxYPdkjNzlt5FMLAEUzgVDkzUCeFt6d5EsYa/2zBPOdyMkNg8i1fw82yZGu93eYXSOU8vqw12a0yYfjsD4M9kzjiOhtAGKQuN+Ft0SMUqQJ/LsWVlXg5abOJaHfZCpKTOL5kkAkQUFQwiVIsjCiwODhxNf0XLwJOzvWOzTAkuCbWp/bac8XJ2gkZqsQsy8muqBuMWm69Y8JimTw== X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(376014)(61400799027)(36860700016)(11063799006)(56012099006)(10067099003)(16102099003)(22082099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: g/UJ3Dl5fwqdXvh2CIdgLa+wDJXJOxT9sz4Oyrkd6CveB0SzaO5GO1RsAXlKdepM/2WpZAFDJOjezOpvoiJhYWrjLMaPNwVsFWHOgqDI1dYnLTjiM+w4TCEZHIfrqCcV7lY6uTnjj5/O65draqNm69jLWvc2kUJb+CfSUGfUTHtOV8R9Gh2eZaPCSwJLKuRpyphNN6+1c4b9bX6E+U64a2y8x8cAOYcxNBGa36fHXkgW7XYudqAtGG2mUcAN2Z7WBY5jNGP5oKrzaSw6CaIEJk3KnurYPDUxy8ghk3a2vk8e55ZJ+tRjKFI/SdUwEycR2gyE370LoYTLbGzf9T2FbzhlgQK5JEelG/jBFZPLLWBXvYdkGk/TIE9Q7wGHGzR7JgPWL7yqCKvvQP1nqdTknM81KistvjNnNZCUJrqIhyYJ0rR/8yfW3dVFoaPlQEyD X-Exchange-RoutingPolicyChecked: eL99lLCvz3rtkQs1HZFPIjyu3yTE6kuqTuWIXkdhRScUipW4QnBpw0glrI32/ojLmFAfvHIRFr9W0m+W97Kj9In6oW/Co27kRGizd0ukAla9gb1rdbjdiI4HMgHCuZXjhArjhSf5kF1kl0iAfRfTfJSGkK6v4MEr5Ir50eU/ymsHYJgK4w/nKyG1A/w7yHIgjEY7ACK08liBrx8Xb4mOXKQvhWIorQzSSthRFGY0R4mg9568ana47wYNX/alfYG8QRsAzZGQTIOE+BDT9/d8JZHeWpu3X7KnH3xb3FroQHUGVr9jdfkQwVeb950vfuFspFbjQwHaqBcVu35mqmofVg== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 10:35:05.6607 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 690a21e9-dc33-434d-9d62-08dee7dce558 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-MW1PEPF00016159.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR19MB7607 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDEwMiBTYWx0ZWRfXxD0omoD1DSr3 UmPnGyuAFXRoRNxA59EsS4GV7arKn7uY05LuOzg8E1PN/BgihF6Vp0bD+huUpW9r00JEDLn42PL 5CcId4phn2rlkt1X5+5oV4CFvs9zy58= X-Authority-Analysis: v=2.4 cv=f5l4wuyM c=1 sm=1 tr=0 ts=6a609cde cx=c_pps a=8ytssxGH5sXDYVMDm1fH2Q==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=RAioF0-LDSMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=BkOAAOD83AWRy7kR8HYA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDEwMiBTYWx0ZWRfX79vxOuenkHML LYx+Aif88p3xDjwQJZUEgv9MSrFNH/nFWONMTcBNalPmMx9Xshn2Kofs2iPaFHzbPXvZQv00Eeg 7l1r9Mfhq6/9TTNKSuwN6PXoUq18OquNifltCHDNR6mihmjNfJLKpkbVSYntVd0bDLsjK07PVcv WsGQ1SuThIwuhfmpsfNbSo+uxrxAvmbSNkAOjy4rcOFP8w+YmSTQPPkXw4woOkN7NJpHi+Jcq4O 8mKvZEYDXGJn97vYoPYyH7hUa6sriOuJBhF4EIHQOcd7g4L0BQLeg7H8czWX4jyH+qzTqSw4tEE KtDsi3NEPXtsOlguwl80KvQh0uEL76ANyRZ+AwRaepa9PUlZCx2FFZ5xKw1mHwZ1U/a/J4EfQrx o7x/wj6OY755tyLGtOVggJByz3cIQA6qU7d7jYmiZ3yJFhhJ/NtyRqx39jrKAfLp/LseoLvr7UB +g7CsgJG5A10GoWujHQ== X-Proofpoint-ORIG-GUID: nbfeGca0Xw1UNmUm6Z35XOgvQDCXHHxi X-Proofpoint-GUID: nbfeGca0Xw1UNmUm6Z35XOgvQDCXHHxi X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" devm_acpi_table_put() takes a struct acpi_table_header * but the value passed in is struct acpi_table_header ** so the value passed to acpi_put_table() is actually the pointer not the table itself. Remove the extra reference to correct the passed value. Fixes: c4d096c3ca42 ("ASoC: SDCA: Add SDCA FDL data parsing") Signed-off-by: Charles Keepax Reviewed-by: Pierre-Louis Bossart --- sound/soc/sdca/sdca_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sdca/sdca_device.c b/sound/soc/sdca/sdca_device.c index 405e80b979de8..4bcd8d1fdff82 100644 --- a/sound/soc/sdca/sdca_device.c +++ b/sound/soc/sdca/sdca_device.c @@ -43,7 +43,7 @@ void sdca_lookup_swft(struct sdw_slave *slave) dev_info(&slave->dev, "SWFT not available\n"); else devm_add_action_or_reset(&slave->dev, devm_acpi_table_put, - &slave->sdca_data.swft); + slave->sdca_data.swft); } EXPORT_SYMBOL_NS(sdca_lookup_swft, "SND_SOC_SDCA"); =20 --=20 2.47.3 From nobody Fri Jul 24 23:30:20 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E95A9339393; Wed, 22 Jul 2026 10:35:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716519; cv=fail; b=AebzpPB8Rt9qk4YM8GwUfJlDL3gw3ClrKq2tkgmN8q82a8YbraHqqOcBwtIwdDz7yMEL5rsJtlVUfok3znGCtEezf8tOabZ3WLmmppjuBqQvPkPzzxpBl7RbrRT3UfHEsUvnklJ3CbYdH/AfTM5Y3YtLzAQoLE/gHbDf4ueScXY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716519; c=relaxed/simple; bh=9miyc0cpvB2dI5lVGNARr/J+Hpea86YeTPW/lFScVPo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=n4sC1kYuUnk8yjIUVU+egfhyG8aMKU4mdXDsTZnbpDgIggFibHS8lvvCFnNEBSKEzAFLqMsaJJPWxO9Vc05bWMbIcr3F1FuoPSw0Fj9hIWDP1c2tnsCVRgo6zEaCjr8mt3R1vjd5bMHp0SFTMd5oHKl5oHc5r/dmsQ9R9erh4Kc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=DwxeD6x8; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=XYWs8YOW; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="DwxeD6x8"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="XYWs8YOW" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LNXTP73629501; Wed, 22 Jul 2026 05:35:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=D9OJ5tbKbSG8d7lpSAErSS9Xo1hFZzA06j+4DBn5kyQ=; b= DwxeD6x8Fvy0Q6FgnWgUURefFuKSRzZLYOP8RNRUdojRREmbRhlnzhKfpp06IXtA O4PIefAFItoihYmXaOQhJO72f2/gX8p7Y8jY+ibsk6CwUoLaaDVdZaVeiecwbGOP ofx69KoD9J18T9WMMijDBAhq5E1YpgwN+I6+GgmDtJE7Awp+Qc2mFi+y3SUagg3/ +akXWMvO4eV2N6A5fvf0dcpFRttVqeHN3Ohow579VqAn3m+bdEqh0Lr/avYkED6U bH9oel6NUpMcJGMy7loO6/NNYME6NiZ2bAMY5quTe9aTxk472wMYUddNh/qUq+Mn aOCa68lS1xrc1M9D+EKMzA== Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11020100.outbound.protection.outlook.com [52.101.61.100]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4fg6vynn2x-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 22 Jul 2026 05:35:12 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B2jJhuXYGE6jikZmMbRPxYFgDTHa7Swd7UukzX7w/h33OnIxx8EGhMm0s4XLiqRiUcXgADEssS5hB4D/XJg54chNualy9IVpS/B7kemGGqHfKXiqsYwAjHiiYvG34LTHn55sIkcWILv7cvx9dZe4/lxDcDquUD1mRQHL9HjV8COrUuosopS1fL9jlPF079qcbueQmXya6Y6n90w6q0BuCYlDhb3ZsgAKA2HXsAKwNzQSebkabJrJUWUu5gWbRoXZ/S6dAHjbnbLRHFDdOjGfO6SojCvX/ZcJ7MugKfQkTVPJV5nenCOIKJaUzMM2NaFt8a08vq/swzsUOaoXfDMIMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D9OJ5tbKbSG8d7lpSAErSS9Xo1hFZzA06j+4DBn5kyQ=; b=jMA9t9bmnpl7jcmkCCNFTTqsgLIBk8mU/CyGjat/RjX5FzShfxQVUP8hWb3up9NKvJB1glmnkSgpyRBghJqxv+EQg05C/RQEQzEvnv+8cxK0kFTZ/Xys1ShgE9VFbkny7KQSogPFRDlzkWEB3eUpZXhX6N+BhguA1rtk3s3lYlVaWFOVlnqeVCznPdbfJlTKCUaz38EWnlWZ9EGLnGH0IZJVWl1lSazat5+A7NLpRU1EIez3D47Z8hh2Ac9hxrgkCWMhOh2OpKHB0z+7qaxXBon9cZKYzVXGkbB4AIiQ3N8o0R1FJ0pdCa/lgoSVJcsZ/sW53gol5kMVn2NU6nq3bA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D9OJ5tbKbSG8d7lpSAErSS9Xo1hFZzA06j+4DBn5kyQ=; b=XYWs8YOWb7BgWDKfSkSv5MmlznqpUX+MQwaOpesFje9xBGSbrtqwoUyjLvT9Nuw1BS/X8ZLjti+ydX9vhoyjxr6eixn3s8dR5n6EwB7RYTn0ki5vGbW1XDCQ8K6D7aWLNj4YLUe1V4t4FN/7cFRkANiOM9a7Fqp7KR4lZiA1/Sk= Received: from MN2PR08CA0014.namprd08.prod.outlook.com (2603:10b6:208:239::19) by LV1PR19MB8909.namprd19.prod.outlook.com (2603:10b6:408:2b3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 10:35:06 +0000 Received: from MN1PEPF0000F0DF.namprd04.prod.outlook.com (2603:10b6:208:239:cafe::77) by MN2PR08CA0014.outlook.office365.com (2603:10b6:208:239::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Wed, 22 Jul 2026 10:35:05 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by MN1PEPF0000F0DF.mail.protection.outlook.com (10.167.242.37) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Wed, 22 Jul 2026 10:35:05 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 52F45406547; Wed, 22 Jul 2026 10:35:04 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 2DDE0822542; Wed, 22 Jul 2026 10:35:04 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org Cc: lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 2/4] ASoC: SDCA: Always free firmware in FDL path Date: Wed, 22 Jul 2026 11:34:58 +0100 Message-ID: <20260722103500.872714-3-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260722103500.872714-1-ckeepax@opensource.cirrus.com> References: <20260722103500.872714-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000F0DF:EE_|LV1PR19MB8909:EE_ X-MS-Office365-Filtering-Correlation-Id: 33188f61-7e87-4b02-7864-08dee7dce528 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|376014|36860700016|61400799027|82310400026|56012099006|11063799006|10067099003|22082099003|18002099003|16102099003; X-Microsoft-Antispam-Message-Info: 1Qkyz8QoL4AN6vWpZddhz0eIL1CWyFeZirEn4FND+LX8eRy333G+7i5B2c4VJVqVOtLLkZ/awIuC/TYDzZVgVlhlcX/mw7hutvmvkM00YvnlUsUogDfgWYybNqWR0NyTxTMm1pEL5VMfYlky63D34IqzhsK2BmDGV6j+ixbt74NHvCEhMJxdigcktBN2Fs0gGe1v3wPgZf4JuXZl5bzfyH21XX5PjqTsouiVm57IApZUdBdYlHZYKfZLsaCGNGNNA0tz02QVCPh8o5BWWH/eifAqd+vqfBLSfQJW2DaR9CfoEPwutk7/jUYlnSaNukysqcyLkoBHCbaiWBaFtg3GxK2/MHl4X540jLQ149hbguordRbtJeBMnYO61PEXzPtGV5XQcFX4g7BH6sLZCA8QbWACnIwHny3XlemtreXOfRn87b8LHM5JnzE/RiRFF4dZlLH8reAbyIDqpM3a1tosnSJl3Mo3vNmNpKBw2JI1Q3Mfe0Zz4X9zlycQTtCea+sARkj9IB1v8WANiC/qi9Hgbd3iCWaOAQgpaG6FAWAWBsxPtTx7De8bYkXEaHmP11i08jzHtUTpIa4dMGfwBKxKdQKJ5ZuN6Nuy0VjphyABPdCi0cUCbTLC8F7ahy3L4MeA3kqdITvKuL3xPjsYH4i4nt/ToeH24uJ1DwCu6QOGqeSSZwCftd30tJFbXJKJbEcqE2gjwGp7TH9SaB82BtxiiA== X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(23010399003)(376014)(36860700016)(61400799027)(82310400026)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003)(16102099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fSHVjRFLpdJ9W+w5YHU+7ndmiWWI6mZ0TrH1+AQhtqwSVQ1NXQceecjn8EVA9gPKAgU7Pg2dErQrSeQVPAV51l+BkYjXuB6XxXhjzI0Mxzzrks7IGfSwBtB4RTzEOJiiDYxJvHQwKz7yB/HirNCGrRuJ6aMiG+FwB8Fxn+kYPbYSCdGMmGZmB7m185KV+PxpgBtTTSmXJC7tfU5i2cdseecgwWKLf3U7jFDCAYarNPrFHTfrP9ZZFHig11U7YYxaD8vaLQp/BXJ7evUZ7SlQHGWO6PDi6WOyzgeuEKycaMT29CavMGUkJLvL3nanCwdlMq3dF5O9ZEmQlwhZK2XKIeDX3kv2HryIGp/o38nSE2racWXxDB6ky+qFezbUkPnMSoU8zjAUJL1CU5H1k86G5cCvmRGIe5c4SRdWVpqfvTCX+uSxJJTd6Yh5dIThtRc3 X-Exchange-RoutingPolicyChecked: BXOA1qSz54aGaB3eh0v8VA+JaXCboGuqrvvqNpO6Hr0KTVbl92XqbpJF+fZtRgVjPAzwg/SHjxvY8iwTDdkgGQfhCKdhjVJlInEM4oncABON6vCM7Wd43xUCr1O9WDDlxK8qzK3lS9pTR8GPetmt1L/aFyPSV7KuzPBuynK32pQ71rjaMza5cxkaAES4KW+7F4v0uvkbnSeKikOLkAmwewXiagVdLQ9iH8C2vP8DDX1TyUxWcR02AVprkyLMwG2H9cfGIqXJIWeQV1Rp3rafCwtws3U8tlUkmJdGELxQ6w365tV4J4twE9q2UsUWR05s0IGcn/cgTKaE7ri8W4ypKg== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 10:35:05.4586 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 33188f61-7e87-4b02-7864-08dee7dce528 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-MN1PEPF0000F0DF.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV1PR19MB8909 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDEwMiBTYWx0ZWRfX4zLYNs1BEGda YQM5/hXJVEjU81tdezluIvnzyW8RtRE+neLsPGGnJXKnmSUYs/tVCVICaZUwJgXJBsiyMMVQzq8 xrAcVbBx7fESgyrzgNtrOMW6e3hxVSI= X-Authority-Analysis: v=2.4 cv=f5l4wuyM c=1 sm=1 tr=0 ts=6a609ce0 cx=c_pps a=jMJ9LDLnn2qgWNxml4ptOQ==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=RAioF0-LDSMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=2hlMXfdl9gbE-6Pf8VYA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDEwMiBTYWx0ZWRfX+JTpkFiuVJyx DG+8BHiI8zLYRg+skak3CJET06Tt6iB76MZdZ1s/1sQllFq4I8haHx+sGtC9MRuOnXK8swlf1YD T9wlWgWMhY4Ps4qlmkCA4xt9/2ATFTWocMdQ/xqJVltCkGCiULxkhqHK5fXA4Mc2aAhlgu4RO2W rP8T0xtrG6sKKVztsEgpHL1NWFUUtHE5uWVXFwbU721AVYhGu7ba0zInqXS3iznqcZq8dcCndxk rhNYYLoPVXZOXuhRl/u1K9T1Pc9IVo8N2qXFFwEwHjO6sbKQqqOVnc//LfIEUcg+6b5RHiQh8S5 Nhk39ZbzdF0x0jLkBFISEYV0yfmWq8biw+mwnx9cmUqTEuzqRYGTBHaP1oi+q6zY0a35QtYhRTB GenqufDg5C/t6MJaiZb12fSb1VC7zrrVoJHv9aNqPx5Y5S9nbYSk0COy8nlEPtixxemeWMi7o1P CL/ZqQc/PfBnOetzavw== X-Proofpoint-ORIG-GUID: Ycx9AkKqL3YrG6EEx0Xz0jrIYc6SCglp X-Proofpoint-GUID: Ycx9AkKqL3YrG6EEx0Xz0jrIYc6SCglp X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" In the case a disk firmware exists but is invalid and no SWFT firmware exists fdl_load_file() will return without calling release_firmware(). Update the code to call this to ensure the firmware is released on the error path. Fixes: 71f7990a34cd ("ASoC: SDCA: Add FDL library for XU entities") Signed-off-by: Charles Keepax Reviewed-by: Pierre-Louis Bossart --- sound/soc/sdca/sdca_fdl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/sdca/sdca_fdl.c b/sound/soc/sdca/sdca_fdl.c index 994821a6df617..60fdd406220d4 100644 --- a/sound/soc/sdca/sdca_fdl.c +++ b/sound/soc/sdca/sdca_fdl.c @@ -258,7 +258,8 @@ static int fdl_load_file(struct sdca_interrupt *interru= pt, =20 if (!swf) { dev_err(dev, "failed to locate SWF\n"); - return -ENOENT; + ret =3D -ENOENT; + goto error; } =20 dev_info(dev, "loading SWF: %x-%x-%x\n", @@ -270,6 +271,8 @@ static int fdl_load_file(struct sdca_interrupt *interru= pt, SDCA_CTL_XU_FDL_MESSAGEOFFSET, fdl_file->fdl_offset, SDCA_CTL_XU_FDL_MESSAGELENGTH, swf->data, swf->file_length - offsetof(struct acpi_sw_file, data)); + +error: release_firmware(firmware); return ret; } --=20 2.47.3 From nobody Fri Jul 24 23:30:20 2026 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7339346A15; Wed, 22 Jul 2026 10:35:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716521; cv=fail; b=SaDG+Gn9K6MePZ7D3VPUw0upj9ZlQF7hOygbKfeLADXGBFOy9qRegSFkqQ4EBTnMO7vgpcIqxfeBHIOzhaVgo+wU5YJPQ2KMqIEgf/q1z2Pqt2wZWm3qkJhkmZCVMGR1ltbaaNk5P0C7fsNB+Xp0OXsW3Pc5adcGu9suXn7A6KU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716521; c=relaxed/simple; bh=43U3XdnXSN0AnPPMDAnQFhmH+dfc8AQiAnfWGmyEIbI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lUh2lxBAUEZnL6ICqarH28yXQBxwm8Vf8MesUX07SFgelB9EgkRbYG4Xdugo/Rbt8CPHqGjQYgWe7RxkZF+5jfyjUlg757Ak4+VRYJRGOFbg281L9o1BzH3tdkxnw9l79uzmLYfENn0mofcgT0Xz/V14GytAN2FPAKJtSK2eaXo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=af3rF8y5; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=O+BkV05e; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="af3rF8y5"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="O+BkV05e" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M5NoiN004689; Wed, 22 Jul 2026 05:35:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=6+J97xPstaBoFc4QFETnttjH2F2Of5kutDtOgt3o2Dk=; b= af3rF8y5VtjAs+NgbKZgIDGkrnO/E2/eB5tYo6r6z4jZ+1zvHjLmZuYuYRMB6Wmj 6xVUY+3N578oA6Y4ORbxjn5UMfEVDAoOfWcPDojyj/6jHtuIedUEuXZC89ZpYoFF 1XMptHnDCbJTtzPNoYzVgi6VKzxWTUmW6dqGLak8+RRtLCKYK55TYXxifUc4uOKx 9LMwL3OJjEfoeMhRRRN3RaKSVUaFwvNg9p43T91EpdMkWb9dJ8chb3fSg6sh+BlB 6mWL/+3CWsD7nYLZVIbWjCEemZfNspuaMhRaDTFXCoJMq3TzaJvgEcL/ml2vqVHA tS5U2UmorGbn1kndPqDLhA== Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11020082.outbound.protection.outlook.com [52.101.46.82]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4fg6vynn34-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 22 Jul 2026 05:35:13 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=euAJeiTalR9rWQCy7qTQzLdUFItouOxWrDC72YX8NOwIgFi0oYS19dPUPR2vOrXuh5q/mcrQn4taa7sPeAxu33OffNQgVXHUXF8ks3S69WxYRPvLOUvk2Oz8MLcrcWPaz6sroyjFwxlKmr/ZTCZah74D9HZh+ifnAh+lWRtoDIG+iOXQvXYX48eIsuhKyYf5yWbDm8qwxTCHEmdmmY6+wfQdgKJXvbbuXwQfOhptq3f2XNbZH0RrjREI498oeyQgvG5eulXmFXJLkHGGFlXXUoo1RK2e58afmLTn5E/D0rRp0qnhpPzwPVs7UwwF1ifz1gkOsxz/pNvlVXyO4gz8MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6+J97xPstaBoFc4QFETnttjH2F2Of5kutDtOgt3o2Dk=; b=eprIUES7BDW/PZWyPA46JsAostQFms2I3BRPW9SeHfVMcnMHHLMtw5sy4ogq1fptpu0h4d6G9Z/IyQEx7gObyoooHC3O9nFXzwxty5i0RZSOMCD2UgA/3TrYN4t5AGHCaBoyqCqaB82Sj7Xtn73aJZGS+KcxvmvqzwkFEtHolxXNCwuGlzPGCF+Ks4v6vD9pqbBwKP8L083JPpSpz9mx+hOsMz1MKAfaEXzKt7deHT9OtS6YK75DIAoEyEszvpfBtU5KOpuCh6vq/v6+XZZepEmjYKO4mX6TFsl1ArqeA/WXUVZFS3CNg8KLSscVYZK8adKkQEEazoS/5/eAqaLWlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6+J97xPstaBoFc4QFETnttjH2F2Of5kutDtOgt3o2Dk=; b=O+BkV05evdfeHQmsLLiQ4Vmnzw4OrGmIQ2azMqxCeTc4v+MG2xXSClKWLpQ58KXsLgYrC8Qp5BtuCN2jgC3cMxQfn+zftQWtUGbBMUgI05BSLtlZHS1qdSBaJlXfvTzqG9/LYOOQzdLTHz+k1NlJ5PCzi/PO/OMAQWufjT2QTJg= Received: from SJ0PR03CA0053.namprd03.prod.outlook.com (2603:10b6:a03:33e::28) by BL3PR19MB6537.namprd19.prod.outlook.com (2603:10b6:208:3b9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Wed, 22 Jul 2026 10:35:07 +0000 Received: from SJ1PEPF000026C6.namprd04.prod.outlook.com (2603:10b6:a03:33e:cafe::1a) by SJ0PR03CA0053.outlook.office365.com (2603:10b6:a03:33e::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Wed, 22 Jul 2026 10:35:06 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by SJ1PEPF000026C6.mail.protection.outlook.com (10.167.244.103) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Wed, 22 Jul 2026 10:35:06 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 5767340654A; Wed, 22 Jul 2026 10:35:04 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 30322822544; Wed, 22 Jul 2026 10:35:04 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org Cc: lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 3/4] ASoC: SDCA: Make UMP message size check more robust Date: Wed, 22 Jul 2026 11:34:59 +0100 Message-ID: <20260722103500.872714-4-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260722103500.872714-1-ckeepax@opensource.cirrus.com> References: <20260722103500.872714-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF000026C6:EE_|BL3PR19MB6537:EE_ X-MS-Office365-Filtering-Correlation-Id: 51626240-2c02-40f5-305b-08dee7dce591 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|376014|82310400026|61400799027|23010399003|16102099003|22082099003|18002099003|10067099003|56012099006|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: RmbYB+IQPUMuGXi44lXCX/qsds+DWsPRbls9ETMufNtmGTvC17SOnHRDdXX+Y+9BWK4ARxgCzBkxllHliZlPCAiFPcXY0Bl7Lxn9AphIigmSMg+9e709YIRWJCFj+ex0qJYTlPuUeqtYGtydqfB4dxQRQIxtzLxGOgbQGJosEyOXfWJNaepsLnt19OP4H1x8sjb8zwf7jiKWd6dIG4Gawy4iYIpcAMLn6cHCyYzDRdt9YQ36JYqrTepUJSVvYfE9Cym7AmLSrX0JKgjMm9dIDw2JF/cwC9YwBxNrdeGXG7tbWzyiJ9+2U0vd8ZcRt+2areftuFnR2iD1MMlWYNfKvLpn/QTYdcFT0bsl3xb+TQXzZKu/3GVxpsT1EOi6JThQcJCCUAHnwlv2a0uKa2C6O8Fo5JyatC5ciJZnlzuXhmDpPFvLi6uG2QtKlXyWjfSmvPxi7nOVOdHlH4xW15esRfOaTfrqoqwzsGulde0N8rRhcTq+kMNvjphgAQtqKUaWXti2c63Ilx7KQQJRNDOKU3oXgMZE8CY69pcoD/0GP+nZlwHWsZr8ALwe2xQR+PpfBG/SR4Em8L37S0tsyrgWBkgQbdFlbxUF/BWnQCsHDXSrrOazKfk4J1Kn87Pm9tklFa7sPprL1fvB+YSTTtny+IYasj6qPNeZ8m6wEJn33jxhZ8nuw1zPZRI1aH7YpkEcwg5nxElS0yo60x/9OaxbZQ== X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(376014)(82310400026)(61400799027)(23010399003)(16102099003)(22082099003)(18002099003)(10067099003)(56012099006)(11063799006)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NbRkybnN3s4jl1s4WmTnyFaWxCQKOCQylTX0BN3flckE7c5GPVtXHpsmlhM1IPGkgtyKJIOnqcfcmESPiwT663Dg/urihw3+oBQ/zzeOtAZQfr9WW2DKnvwjEVJX4DYc36wjdbSD0S1UGuxuFvnJGKrKJHNDckdC2sQ8DT8OGmiaOUZA7uqGvxwklQzgPioGxJAOTeS+ZLOS77cu+WpjMHUi/FjEWXxPTblOW2F7uRjC6zb9ZRcE308KHDmW7RIu9OvbsDqpMQYQebxMY/P98jxQFfgNbFoNpa8X/9Et7VK0T05WxXF1e32DMwXaNUFUvxS8ihRJdvrPQcWV/C1BXTQj7di4LsCDZTK8xKrmlHEekhM68L1u7JR+stax/aGRk6Mcjnc5R76QR+0RYp/r8efKFRXCUCPgDrGk5pRdS4lcPqetuQm7T4y+EbPePity X-Exchange-RoutingPolicyChecked: jF8HmW2YUzs89T0V02zSESo6LkQ2qkbooQNcCrHcsYhSAl+hYUZao8/+O8cDmZMVRvM0YeeHs9Vac4v/NnGGdrJklUa9ZhQ3498wivSD/eE88fjR+frdP5RpfgzdfrpfzOqA145/pwRAWdK9MIqZ9No4EdjtGjyl/jKTTtrgrRJoA0LYe70aq3bgD12i5AVIMT7WiWc1ICbwEhUHD9ZVSgDHDYcqyj0fMxv0sfzYkqZJCxTCx/yEaYq1aBRuJDykr45PQv/fGMhYlmL7089FmVcu0DK4W62rHB1NyGK+AM2Z4dP7zBfg3KYet9UCBgjH49lo27X/ZYl/B4xjV4TbGw== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 10:35:06.0231 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 51626240-2c02-40f5-305b-08dee7dce591 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-SJ1PEPF000026C6.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR19MB6537 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDEwMiBTYWx0ZWRfX3QOnrnd+H0pF +77xc0bdkIL1g2RBWjaA6B8SGZR+4Rrygd3MieLSgh6JF9pxg/21uzE13MvQJJiXgc0Q6qarWbw 42rdhUIU9oMVq3+FEuA4e8zhYEiXY10= X-Authority-Analysis: v=2.4 cv=f5l4wuyM c=1 sm=1 tr=0 ts=6a609ce1 cx=c_pps a=SBNZrs1CJjyqcQ6ja0jd9g==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=RAioF0-LDSMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=w1d2syhTAAAA:8 a=7kdKIpNzXG54ww5W1h8A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDEwMiBTYWx0ZWRfXxk1x3CK9iq1J AQrdq9k50SzApnIV3mDVeFVc31Nfk/Sj20XwqfJCbxv6OCrU6JJlWn3760DozckoHOtYuTY0clC 7NyLfArEY1S60h15bYa8K5wsme4ROJ5equoXRUINSE50CVRn4XRVUQOsIPye2FvVHgMtNBvpcJl tCxyHuM7boGG2lOBbVsaVBCruMUIwkN0EuRll12WViRD/Ba+5Px290eJYq1vse44ACw5oYGEjVP 9/6NuSeWZ9jEMuq/tDk6Y5YR7vSb6s7fp1/BXOW5XojXozzfm9/5IOmSlsumN/2XrRHOZUhSNcx npS+00K+fnANdfx8ix6nFpjxodZJjC6Un0GC/88IYH+a9qdEsqhfM55ndWaFm9VilFxik/xoCK5 GsWdeD/XvbRtHXy3UPBwE3vtJ0az2uedA82uPN795MTDFanH1Sy+sKfs326iUiAf9kUk1v4392E SkRoI3lHdxhWdYkDWag== X-Proofpoint-ORIG-GUID: EqO-B1GL_cLNu-B4dJ9x7U97giNvmtVV X-Proofpoint-GUID: EqO-B1GL_cLNu-B4dJ9x7U97giNvmtVV X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" If message offset was larger than the buffer length the size check will pass incorrectly. Refactor the check such that it is more robust to invalid sizes. Fixes: daab108504be ("ASoC: SDCA: Add UMP buffer helper functions") Signed-off-by: Charles Keepax Reviewed-by: Pierre-Louis Bossart --- sound/soc/sdca/sdca_ump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/sdca/sdca_ump.c b/sound/soc/sdca/sdca_ump.c index a86bb28c6d0ad..82a8bf75bbca5 100644 --- a/sound/soc/sdca/sdca_ump.c +++ b/sound/soc/sdca/sdca_ump.c @@ -141,7 +141,7 @@ int sdca_ump_read_message(struct device *dev, return ret; } =20 - if (msg_len > buf_len - msg_offset) { + if (msg_offset + msg_len > buf_len) { dev_err(dev, "%s: message too big for UMP buffer: %d\n", entity->label, msg_len); return -EINVAL; @@ -207,7 +207,7 @@ int sdca_ump_write_message(struct device *dev, buf_len =3D sdca_range(range, SDCA_MESSAGEOFFSET_BUFFER_LENGTH, 0); ump_mode =3D sdca_range(range, SDCA_MESSAGEOFFSET_UMP_MODE, 0); =20 - if (msg_len > buf_len - msg_offset) { + if (msg_offset + msg_len > buf_len) { dev_err(dev, "%s: message too big for UMP buffer: %d\n", entity->label, msg_len); return -EINVAL; --=20 2.47.3 From nobody Fri Jul 24 23:30:20 2026 Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24A7B339397; Wed, 22 Jul 2026 10:35:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.152.168 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716535; cv=fail; b=AZV7uBLLoJ8Z3DzKtmsdaMs3k5QI5srnJkRu0TlMY8Wi6JVlsGSkMzFVfx1Wm/2ZxD4PY2JmRpUu2ySCGegLcFUJ0+0Kl8xYxMrwNCFpFTxeHKCc3d3QfO1azgrrioTbad9ktFsTap4xCF/eTuGjJmhZGgHAy8BnNJ9+GgaaXPY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716535; c=relaxed/simple; bh=3CUi1WHU0jRVV2OSXfHU4WhdL9D6cg3SaJ/hqqCnUqA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sodgk3J05bTvfeoGI8byR9tzZRo9rjjklHyImK39ePXJftdorgj3Fr8YwzRH/aaYp4e333D0FNbJgiHpXrBjRm13NmAwfRVjTcIe2cLzIk+QVeveuCk9Kt+fliTRSr6M1zsrLh+jP8lDpQ6hRPnnB2gWpfgpFTd0Pkln7+FIoA4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=JupiCXa3; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=cjLYr1Sq; arc=fail smtp.client-ip=67.231.152.168 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="JupiCXa3"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="cjLYr1Sq" Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M4f3PC2100112; Wed, 22 Jul 2026 05:35:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= PODMain02222019; bh=TUkFXAtLDkyPUb2lQxNEjQvyCINDtZ2huaxy7MUVvh0=; b= JupiCXa37iOtP141cWMAYNcDhqjDAOWex4yOEx/GfCBMQRkT27hvQCXdyp/8Z9iG MIPXID3ZhYbTOj9gYNbZUB0eQsHhgLtP9xtDI26t+J5RyMbumIfk1EsBNBGUJ36n kF1oUcPyu4fosI2Ej3UhRSbkI8zDaix+ZJqe9oI7mY75H6avSnaOu22SOtj+dhmV sbNPTc8MexYxBHW9m4aYjVkGsdFawTv2f6UE0CNRWCaWClrvX+opOVUiysOwBQoj V17LjyeY7GvzRpo0C3aFnVMnym/yeL1wr1iUK72yzZaA+5x3OR4wK9MSv8XVYlKz Sk8gmieea61MQ/BtNDqBew== Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11020074.outbound.protection.outlook.com [52.101.61.74]) by mx0b-001ae601.pphosted.com (PPS) with ESMTPS id 4fg5wfdku7-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 22 Jul 2026 05:35:13 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sodrU6X40OGBJTV3FLPU2/BpOr4BOoxmqY7erkZ5Q15CO+7o028v3UL4h9SQkkOzKKxzXfepIDHbKtFTfutV0XP05mEB75np1hWJzsjsi9Ie3fFLyCSFdo+mw7n8CEso17eg3uGwxim5kZWKY7q9ErXqr5kui5cHMqOpFWTo7M8W4/VFeHDif2wJeJG+BLUnGb6KT5TnvSVm2YzpW1woRvXCuA878P0SnCOqf5ta8bAL582MhIyO9xGFDdjAnlVXsLLNiCzQumhZcscWxfR8y1hNfj1St78PgGcZ+SisVfD+x+faZJTd0irpecUD+AR04VGc0KEIQ0VXs0zykruKgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TUkFXAtLDkyPUb2lQxNEjQvyCINDtZ2huaxy7MUVvh0=; b=BjYq654IzREodkv/Wh3N0oT4vtrXRN3HEdFEdAs+cSdmbR1I9lDssED3P2Lh8+ZwhB0aYWVfUJyc0OHcAMJm7/6+ed0FuJBUR0QR18A6oq1BUUO7vtcZPFPaLYcDYYo2OD1W119ZsBXcS1SiBXntsh/MGiEiZ9+BQpbqwpb7KhDIaP2jAT2vFIdgb9ZDOj31MnTAVzkxBFfuHQ1GFmDVK8QXqclZIcwxovsPMj06j74XAK4BRlg/UZ2P2vZ1WeW1fF5Du81QM9hSReuv76tx6eNiTlt4JMK2Aa9bovLbXrrNLxTYuZdUzovGpEXUuCR4Syp0jMEu06+os8E6RozsDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TUkFXAtLDkyPUb2lQxNEjQvyCINDtZ2huaxy7MUVvh0=; b=cjLYr1SqtGPlYxUbaj6cS25JGUrjUr0AFoFN5Js3qyI2YbCMJzCix8b3MNpSsJfRG+aPWlfazyhEzLERz3NAV5a8o8HH3ZOA7I6AdJdVGN5zXdi43PzIcIDKKOKPL9oU6t3KSessRmOJNSuR+RA2rooAehVWpq3sXvg40z1ZzlU= Received: from PH3PEPF000040A2.namprd05.prod.outlook.com (2603:10b6:518:1::56) by CO1PR19MB4904.namprd19.prod.outlook.com (2603:10b6:303:f0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 10:35:08 +0000 Received: from MW1PEPF00016160.namprd21.prod.outlook.com (2a01:111:f403:c903::2) by PH3PEPF000040A2.outlook.office365.com (2603:1036:903:49::3) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.5 via Frontend Transport; Wed, 22 Jul 2026 10:35:08 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by MW1PEPF00016160.mail.protection.outlook.com (10.167.249.91) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.270.0 via Frontend Transport; Wed, 22 Jul 2026 10:35:07 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 5B85A406554; Wed, 22 Jul 2026 10:35:04 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 325CD822545; Wed, 22 Jul 2026 10:35:04 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org Cc: lgirdwood@gmail.com, yung-chuan.liao@linux.intel.com, pierre-louis.bossart@linux.dev, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH 4/4] ASoC: SDCA: Ensure that Control Range is large enough for header Date: Wed, 22 Jul 2026 11:35:00 +0100 Message-ID: <20260722103500.872714-5-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260722103500.872714-1-ckeepax@opensource.cirrus.com> References: <20260722103500.872714-1-ckeepax@opensource.cirrus.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW1PEPF00016160:EE_|CO1PR19MB4904:EE_ X-MS-Office365-Filtering-Correlation-Id: b4365aeb-de9f-4df8-fdc9-08dee7dce66e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|36860700016|23010399003|61400799027|376014|16102099003|22082099003|18002099003|11063799006|10067099003|56012099006|6133799003; X-Microsoft-Antispam-Message-Info: +tGS6ZOr8tby0aLqZIRLJcX4u4uiLLTeXGIASDw+ERMOYICAeka9+OEqGjw8deeBftY29TN+UfdBfKWUvlUTCW7bKJvaTi/ugH/HPCu+DbJ/8JQ6PpumxyM0K06VMHPNIF2zhMyCdeejtE8ZFjKKnQbg0Js0A/KMle8oQGX3UbryGNPgFsWRArLRV0C+gjZBpJOLs6u5I4QAkueeEFGYcnG8jttDjRn99oYwVabENqOALROGq+ydyo1Zpnayg/yJaMu11oIVkSBBQNSbxHfp8pNkhuYSXkWUjsCqO5+IVUl8l6mEfAisV0U51tXEXHRbQQHDtos0JrKP9cF4qXRAZuIIUKwzcMZXFOQApM9nqluwX7GU9Rl39jX/bmIpcVbF3YF9nawhIIvyjVcqKRX4apKqI9Wbcp3S5c8vQ6wWGWmbxiNgwkMyYqC3FC/2YJEzX84h5z7tZbDRXyrxB2bDwQUAIU7tUWXPknhwkFGJHV6LBcTERj1cFMbk5za1XXgm0L5KNmtVsGWwtKYmSLgpv/VilKHyP16cv76abNI4iLZ7vvBM/V8t9JflFgRfscV4Ou7u+BZMcDcZQN997gTJ7eVUH2hpHxn27EXFD1Q0otg01qfflYcZHy1T/pdgwti2JPOjW6kxw+DyV2GnW/n3yuUiCbCEgz4VVbiUWdJ346o84cwMUOOs0h391G/wp6+jRKxNPzDF1HrcwtuTMUaVIw== X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(36860700016)(23010399003)(61400799027)(376014)(16102099003)(22082099003)(18002099003)(11063799006)(10067099003)(56012099006)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 4a04AK2bRy1KJFr/ean031j/lywWQz5peU5g4Ux/h8Mjj1YIix3ZKjkSXFPEAuhL8hIEGD/m99zdd1Yj7QyXTsrLO8daptN3ErxrT3L374qjsiaWi2RBczbedQr0MsrR2eRWOKuTQZwXc08zgApRBt48LDhUuXnJ1/4+kPqPv9zvbGrAySLzB0tQMrxZhEXBNXtOcUxW0TU6tD8mzq7DZLtUCfmeKC1iGkDH60nscY+jyodBueKyrdgP6c+KYrn2hNVV3uiH1K1rlTzOdtW27cJmsm+L9JJL0qlW5KrGz3ZurZnolF1Q4MlS3aRVFw+nv1FNHyDWshmCeO2VNmsD3jZI6S+pS3WnpIrMYZydOGF0odZR6EepoYj8aZCs/QPibf1Np0NqMDyCUqq35xlVCN1N8EZq8aqIibmuNNjCtf7+naLebuX3bbhJOpce1Ppe X-Exchange-RoutingPolicyChecked: davt7S4lqkYZFbXu45wJNZ4TD8KKu/N6XhQkkYKDvBVVkVSWCmv8HtfBrZ7k5LpHaj2lqAC5shOd7QooDnu9B4vuHPqwap7BOsNj2LvSkNUjGOAltPFeB2gmlQzLcEA0HBbFkeVZl/aizgpcEP9wMrZKBjaxWjqwQ4TkqWISqOoDe4/nmYDQQERqAmKSH5Kz7z4nRDXg3r32jMwAVowR1I8Urw+odgt0YS9vE64nx0ECk8dTimq7THL3ztTpyv/MHUJlVxHEcGV1ZfxWkJQ/nhkUMldhIOYi9Pp8JYp8JTNECCYofrnWc7ET08Rmx2p7yeRKNGVw4PotBZBlIjomQw== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 10:35:07.4850 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4365aeb-de9f-4df8-fdc9-08dee7dce66e X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-MW1PEPF00016160.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR19MB4904 X-Proofpoint-ORIG-GUID: qZ9D9fQvsAUAasqNMLg0Vzsg3JH42fiW X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDEwMiBTYWx0ZWRfX1FbctpHsoyPo xftkM+hacGy42TU1dilyw887G1wzBPbKbP4ckoWNKZob1SuklO5x8AN5qZ/K2BRnPfL+fYYjnc4 +TXK7zNqfRbQZIOgskKpzRU4DUyCIjs= X-Proofpoint-GUID: qZ9D9fQvsAUAasqNMLg0Vzsg3JH42fiW X-Authority-Analysis: v=2.4 cv=BdjoFLt2 c=1 sm=1 tr=0 ts=6a609ce1 cx=c_pps a=yYy2G489n0tWBFeUj/OB0w==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=RAioF0-LDSMA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=KfkQE9S9VqCBgivYGm0O:22 a=w1d2syhTAAAA:8 a=XlpbsVkl1wNVLzAopt4A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDEwMiBTYWx0ZWRfXxxXTlg8cHBe8 zKOePPlvjBcLYiHCnMQLrimnUBLiCDV5gUCvjyJdTmefXrLLLLL/YQEp8hTXmZqHGixoFfKpYIY bzrLPkTBoSOWf1J8XJ1KQ5IqJz02YBxdNyzms4TUPo+1Xxav97aCIw9utKxy4K5AtsRgBrxOXNp Ain/shMCG8s1gJK8DIIDskjeTjAvB/+1vGU6/m/vyX8C3527QvzBKrKQ4gVLerU00iDwb8T8RgH dFrQD0cTesb8PkJSpqm2Ygb2BcizT1oiRfe+EeaEs4XIiCs1gUFrtLY+Bx4LC5emOBoSCWAZ2ds N9JzfPVHyRvSmrokNOP+AIs/d8MwxybStxei5+f0GbteKaWC6AEPMEYhDBfPg/gIh8aYhfTKNFo 5ZpAPwsyAmuXt9raIoB8XxqdR1mbWXHZHo3ju+/Lz7kb/Ar81vZoJksVYCpEaDgVDhM7Rbvo/SR 0WSEkUDmFAnlqLgItqw== X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="utf-8" When reading the Ranges structure from an SDCA Control, ensure that the read data is large enough to encompass the required header before accessing it. Fixes: 64fb5af1d1bb ("ASoC: SDCA: Add parsing for Control range structures") Signed-off-by: Charles Keepax Reviewed-by: Pierre-Louis Bossart --- sound/soc/sdca/sdca_functions.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/sdca/sdca_functions.c b/sound/soc/sdca/sdca_function= s.c index 77940bd6b33c9..7a7a9f1a49389 100644 --- a/sound/soc/sdca/sdca_functions.c +++ b/sound/soc/sdca/sdca_functions.c @@ -855,6 +855,8 @@ static int find_sdca_control_range(struct device *dev, return 0; else if (num_range < 0) return num_range; + else if (num_range < 2 * sizeof(*limits)) + return -EINVAL; =20 range_list =3D devm_kcalloc(dev, num_range, sizeof(*range_list), GFP_KERN= EL); if (!range_list) --=20 2.47.3