From nobody Fri Jul 24 23:32:06 2026 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B866147DD47 for ; Wed, 22 Jul 2026 10:12:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784715151; cv=none; b=uqYWU7IZTRXxJv+MqfhNo+gUXOiodUzw/XEHpj7eW8c+oNyhicurUJnagN4zpWvHlEGU+0l7nW6XmEZoy/hs+0J8mWIENPhw9UafSse2M7AGu3VEygLwzpGOnWA2ozmJP4EM1F+IO1Eyu85tRgn7Is/teEOUwRrqMlyEkorFQ0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784715151; c=relaxed/simple; bh=+EO+/DM+UqXo1X+9c7qNvx+s5xrKmkfKbDX0PDh5eCA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ivb0O93dU2FQduMPCcDSDc/pvqbPPfSXdxGWNNs1TfsktrFGTUNi0THnUxAKsbLdod0tE3PtmInw5XmkF9Mv6etTBmJgiG7lGLoXsDkia4An78bDo2jF/MndXI8hhEcoJ+nTsBITRPS9KNMyRpwHEc0OjV8hA1/r7OH7zBUkyz8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=PugG/3xX; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="PugG/3xX" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-cb5a6aa8760so2683838a12.1 for ; Wed, 22 Jul 2026 03:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1784715144; x=1785319944; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=zSKRTMZROa7njeBdu59rhX1AOvMB9lBLaZAp5eIkHZI=; b=PugG/3xXJLXadBFoMbHAwq4I3H+uP000COGvuhY4GXkfIs85LmnThqljQkmHsDYyGv 0Q9CGcjfg+qQyLVSzWFTPkp3cjHong6qffP6GcCObTNk7hjjDKhm6QbnJlCeHqPW1vmj IwpeelW/CE+CPDowVctHz3zi3aTPTFHIgRSGmObb21+0WtQ86TsoUCw/uSCsILxLhR4z ccxYa+qAr3YHzanw0tqf7bHGwB5dNig6foqasT4b0vXTOynXz5QVLKpDKawxfO3biJSN pNPIQkYpWu+bRBT8IuEExkhx+D1sMj8YeW591lsd+mhZ1ktq1JG/AjjdhY+E7n2a7uFZ B3vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784715144; x=1785319944; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zSKRTMZROa7njeBdu59rhX1AOvMB9lBLaZAp5eIkHZI=; b=fR/BSr2WtRSPczRAMCIC5pJRlo18mj27Jw72ddT0sIlazhZ30rKjKGPb8YQJ8hK5GP 4rSUXZSe1MNlWk/7Wobe7Y5sHx9rV5iwzXOT2ZNqT+aF/2zTIewFH8LmjkjTrFDnNRHD yRx1d02Ad9IcJtGNrcX606f+oi4RQ4e7+HgVmKItlSIReOEn9rJ3nPjqYd9YAHkszecu kbXgxpvA3lkMxx+sSX2gComem4OrQFTHdcqavyf2zvagExXNusRn1J8oEkXEviDQGGjQ PcdkXrC4cCcc/blcP8O2tEY5DKXkXCp1UEZKFyqic6UTMignKEU38+fc1XzeKyQGbXIQ 58rw== X-Forwarded-Encrypted: i=1; AHgh+RrUFTP+miF4Lk8IF3rK1wjNTzpT/fmvxu7uZ1WTWutNXGDBOfgw5SS/X3YEOvz5FtMlSDWDRo7nLJ4Xbuc=@vger.kernel.org X-Gm-Message-State: AOJu0YzFDziMIDCKxwuXPZups4NNLQIhb9gr5ZgneuE/h6P8HpMF4lFQ kurvg32UJCpsWF1ZjDFXZWxprinq76K2scyxfmtwBBTRft4aMZ4+f0yhu9Dp8aVhuds= X-Gm-Gg: AR+sD11OWkjSTYLcq2ut8mWO6VOwUrNQmz+Qjak6+7XFsAS81NKTBEYbdqjHusbZaOV wfCpY9lPJqepltnKlZtWJjxjxp/rmd/oAq9XibSnLWElrqbEGQxj534kHSVRwkAbNluQVhLwmCo 6e7/m2WHxQfk6L4ll0T0PZVbycGscNChI6J/+qRXEB+yOClznFTqlx9C2d+1aS9dPZS4NtlFuYs iiDUKkj24BVucx5suMh3YG21tPXWL27Hg7mIYnk0HSkGR69x7Lnqzuhu7TZMy2ZR+WFEY9/DqYd sEcEsuX/QqMue4U4nA9jkmbu2pZNF5i4y49Fp9jXkYcsf8Vh3TiRZ1dB+6raUHDK+9SW43KzPUo blnS5T4aUXyapKwQphtW/1fzkVDqe1vwhCSt5uPQtMHY0xrI/FMcGx3c2UvKXUdoKdHNfuAKf9Y IGjT7lliMZhIdL2cuAjw9OnIPYMYeZjYfENa0oMfijdO8XclkCp5WvMeoLgxev1wAED1mWvTe/M rdkgdhlnZaaf2gdscg3swu6CzWejTmL6SBg0f6AFUw= X-Received: by 2002:a05:6372:a743:b0:3c3:cb39:669a with SMTP id adf61e73a8af0-3c3cb398792mr17162832637.73.1784715143594; Wed, 22 Jul 2026 03:12:23 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id 5a478bee46e88-3147e1c9289sm8012662eec.29.2026.07.22.03.12.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 03:12:23 -0700 (PDT) From: Abdun Nihaal To: bryan-bt.tan@broadcom.com Cc: Abdun Nihaal , vishnu.dasa@broadcom.com, bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v2] misc: vmc_vmci: Fix potential memory leak in vmci_event_subscribe() Date: Wed, 22 Jul 2026 15:42:13 +0530 Message-ID: <20260722101215.76680-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for struct vmci_subscription (sub) is not freed in the error path when have_new_id is false. Fix that by adding a kfree() call, and moving the read of sub->id to a point before freeing. Fixes: 1d990201f9bb ("VMCI: event handling implementation.") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal Acked-by: Vishnu Dasa --- Compile tested only. Issue found using static analysis. v1->v2: - Moved the new_subscription_id assignment to the point before the if/else to simplify the code, as suggested by Vishnu Dasa. v1 link: https://lore.kernel.org/all/CAF+opq15TtOnHaLvYr0TH18sCDEPbTYRTsFZM= cyjgvvLd_ARkw@mail.gmail.com/ drivers/misc/vmw_vmci/vmci_event.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_event.c b/drivers/misc/vmw_vmci/vmc= i_event.c index fffe068a26eb..c3ef3b98c432 100644 --- a/drivers/misc/vmw_vmci/vmci_event.c +++ b/drivers/misc/vmw_vmci/vmci_event.c @@ -179,16 +179,16 @@ int vmci_event_subscribe(u32 event, } } =20 + *new_subscription_id =3D sub->id; if (have_new_id) { list_add_rcu(&sub->node, &subscriber_array[event]); retval =3D VMCI_SUCCESS; } else { + kfree(sub); retval =3D VMCI_ERROR_NO_RESOURCES; } =20 mutex_unlock(&subscriber_mutex); - - *new_subscription_id =3D sub->id; return retval; } EXPORT_SYMBOL_GPL(vmci_event_subscribe); --=20 2.43.0