From nobody Fri Jul 24 23:30:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90A5E3242DF for ; Wed, 22 Jul 2026 06:32:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784701936; cv=none; b=pZ5peRbXiNuSn2PQSmmq/r2Ub7mNEte08QsgtxkQW8rfUPbH8NmpbZnq4dkM+8LXKGIGone5drfd7/wwiSc1JH0IC+Bl9o/3jQVWLUsq/RubyvCmoy+3ctHggDo/wSBs9FPNZZQ5UeAG/EXFplG74O3nb5EW0yqeTXei4l/NeCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784701936; c=relaxed/simple; bh=zmu+A/PZtm8cz8gJSBEyfjIP/y7B3d96X6LYCL9gJDk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=Vaj1DbhJhUOCSNxZZFE2d5m9zV6FgRRaX+8rES+BK4dvO1EyNx4Xd32CcvAHVBZRFtZSCxOZxAHMJEX7ogD7W8c8k8lwB1IU/NviK5WBMGziJtPtBDAMkKM5qh2DLeXjHO0Dw9Xjv1/peTZGP9nrV5GQYtaBCny6QgiKs+eaQW4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZPelsprP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZPelsprP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6A1521F000E9; Wed, 22 Jul 2026 06:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784701935; bh=5oqamf5vYO7nOO3geayZ3HnhE2HUHatoGZ6ODL3Jt+I=; h=From:To:Cc:Subject:Date; b=ZPelsprPsxfpnRQkp47bjjVCQq4n22h+0/kTqtV4XAtN2oaaSbnH1206mT8nqi0a+ s3VA1dU4CSBm6DKmpXrOW1g4ZvrCCHREEBBw5EMrFHYej1lnlYTp0c3qkEiidZA1wF WZ0VGHDe+/cJBKPCyYR5r5eIt0iJ0OJEzInUqaTbz6vOWk0YjwcJgr5A0pQK4sSwwJ 0PuXScYYDqWqWzHIhcWPHe+sYbfTMUkoeJpY8ilh9aAC53nryi+RPbTzUpPz73NLvK +K0pKiqiGwd/xT6sU0Ee0PF5rJRSvwsA//munScyKJn0xFWpNDdFbdW6nQkjTUqFBp JFgmjLwyZhDAA== From: "Jiri Slaby (SUSE)" To: alexander.deucher@amd.com Cc: linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , "Lakha, Bhawanpreet" , Harry Wentland , Leo Li , Rodrigo Siqueira , =?UTF-8?q?Christian=20K=C3=B6nig?= , David Airlie , Simona Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: [PATCH] drm/amd/display: use proper context for logging Date: Wed, 22 Jul 2026 08:32:10 +0200 Message-ID: <20260722063210.1144266-1-jirislaby@kernel.org> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable The same as the rest of the code, get_ss_info_from_atombios() uses calc_pll_cs->ctx->logger for logging. But calc_pll_cs->ctx is initialized only later in calc_pll_max_vco_construct(). Therefore, any output using DC_LOG_SYNC() leads to a NULL pointer deference in get_ss_info_from_atombios(). To avoid accessing the NULL context, use clk_src->base.ctx->logger in get_ss_info_from_atombios(). That context is initialized earlier in dce110_clk_src_construct() -- before get_ss_info_from_atombios() is actually called. This is done by temporarily redefining DC_LOGGER to CTX->logger. Before: dce110_clk_src_construct() did: -> sets clk_src->base.ctx =3D ctx; -> ss_info_from_atombios_create() -> get_ss_info_from_atombios() <- uses calc_pll_cs->ctx # BOOM -> calc_pll_max_vco_construct() <- sets calc_pll_cs->ctx After: dce110_clk_src_construct() does: -> sets clk_src->base.ctx =3D ctx; -> ss_info_from_atombios_create() -> get_ss_info_from_atombios() <- uses clk_src->base.ctx Closes: https://bugzilla.suse.com/show_bug.cgi?id=3D1271175 Closes: https://lore.kernel.org/all/a9ee54e6-2413-4156-9bde-d528ae3c63a3@ke= rnel.org/ Fixes: 1296423bf23c ("drm/amd/display: define DC_LOGGER for logger") Signed-off-by: Jiri Slaby (SUSE) Cc: Lakha, Bhawanpreet Cc: Harry Wentland Cc: Leo Li Cc: Rodrigo Siqueira Cc: Alex Deucher Cc: "Christian K=C3=B6nig" Cc: David Airlie Cc: Simona Vetter Cc: amd-gfx@lists.freedesktop.org --- Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c b/driver= s/gpu/drm/amd/display/dc/dce/dce_clock_source.c index ecb8493ec523..d3f7aa853e3a 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c @@ -1513,6 +1513,10 @@ static const struct clock_source_funcs dce110_clk_sr= c_funcs =3D { .get_dp_dto_frequency_100hz =3D get_dp_dto_frequency_100hz }; =20 +/* calc_pll_cs->ctx is set only after get_ss_info_from_atombios(), unlike = clk_src->base */ +#pragma push_macro("DC_LOGGER") +#undef DC_LOGGER +#define DC_LOGGER CTX->logger =20 static void get_ss_info_from_atombios( struct dce110_clk_src *clk_src, @@ -1526,7 +1530,7 @@ static void get_ss_info_from_atombios( struct spread_spectrum_info *ss_info_cur; struct spread_spectrum_data *ss_data_cur; uint32_t i; - DC_LOGGER_INIT(); + if (ss_entries_num =3D=3D NULL) { DC_LOG_SYNC( "Invalid entry !!!\n"); @@ -1631,6 +1635,8 @@ static void get_ss_info_from_atombios( kfree(ss_info); } =20 +#pragma pop_macro("DC_LOGGER") + static void ss_info_from_atombios_create( struct dce110_clk_src *clk_src) { --=20 2.55.0