From nobody Fri Jul 24 23:31:00 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C05D22538F; Wed, 22 Jul 2026 04:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784693329; cv=none; b=LIC6ReX54OBj5wJ7WThQ2ZYrDiAOum9ddxBiZDGp/s88lb6GdSmPuF15ZELTVpUaB5N38vA2VjYTIxYP2yJvRaBFn5nPI08BMf+9p2G+UhbCQmx3iV+fi2mV0lQ4pmgAIXOUmoOcjUDNXmABX+VxAaFfwgYAGleXOmIjZX6kL/0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784693329; c=relaxed/simple; bh=mJWPBTk42GjAAL3YN42tiIDa1ZL9P4CXlpRkyMqnSOQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nDBkGhY6p+v1nnBqfyyiOTKsXcLGrh/5duhAWsEuQaHBOSuyqddUNwqlnIpjkwYJoUhErYF0Vfm8yVag15+MuUhMWrVXuT6JKQKfz+dUXp2caX1ccK5FXnjLwlQ5qmT/XKDPxvEySplSfS041r5jm9losu0Un578tnoraIv2900= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.245.140]) by APP-05 (Coremail) with SMTP id zQCowAAHKkNAQmBqvge7AA--.34195S2; Wed, 22 Jul 2026 12:08:33 +0800 (CST) From: Pengpeng Hou To: Inki Dae Cc: Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Alim Akhtar , Peter Griffin , Joonyoung Shim , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Pengpeng Hou Subject: [PATCH] drm/exynos: limit G2D GEM map count Date: Wed, 22 Jul 2026 12:08:32 +0800 Message-ID: <20260722040832.80135-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAAHKkNAQmBqvge7AA--.34195S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Cr18CF4ktryfGFyDKFWfKrg_yoW8CryDpF 43Gry2y3y5XayxtFWIyanY9Fy5Wasaka9FgF4xC3s7uF1qvF18X3WrtFy2qa45urWfJr4j yr1DAas7uFy7A3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9Y14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVWxJr 0_GcWle2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_JrI_JrylYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lFIxGxcIEc7CjxVA2 Y2ka0xkIwI1lc7CjxVAaw2AFwI0_Jw0_GFyl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x 0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2 zVAF1VAY17CE14v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF 4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWU CwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCT nIWIevJa73UjIFyTuYvjfUFg4SDUUUU X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ Content-Type: text/plain; charset="utf-8" exynos_g2d_set_cmdlist_ioctl() accepts cmd_buf_nr from userspace and later uses it to index the fixed reg_types array while validating GEM mapping commands. The existing G2D command-page limit is much larger than that array. Keep ordinary commands bounded by the command-page capacity, but bound GEM mapping commands by MAX_REG_TYPE_NR before storing or validating them. Perform the checks before taking a command-list node so an invalid request cannot consume an entry from the free list. Fixes: d7f1642c90ab ("drm/exynos: add G2D driver") Signed-off-by: Pengpeng Hou --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exyn= os/exynos_drm_g2d.c index e92a4d872c41..2dfea16f32cb 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c @@ -1151,21 +1151,17 @@ int exynos_g2d_set_cmdlist_ioctl(struct drm_device = *drm_dev, void *data, int size; int ret; =20 - node =3D g2d_get_cmdlist(g2d); - if (!node) - return -ENOMEM; - - /* - * To avoid an integer overflow for the later size computations, we - * enforce a maximum number of submitted commands here. This limit is - * sufficient for all conceivable usage cases of the G2D. - */ + /* GEM mapping commands also populate fixed-size buf_info arrays. */ if (req->cmd_nr > G2D_CMDLIST_DATA_NUM || - req->cmd_buf_nr > G2D_CMDLIST_DATA_NUM) { + req->cmd_buf_nr > MAX_REG_TYPE_NR) { dev_err(g2d->dev, "number of submitted G2D commands exceeds limit\n"); return -EINVAL; } =20 + node =3D g2d_get_cmdlist(g2d); + if (!node) + return -ENOMEM; + node->event =3D NULL; =20 if (req->event_type !=3D G2D_EVENT_NOT) { --=20 2.50.1 (Apple Git-155)