From nobody Sat Jul 25 00:03:09 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013000.outbound.protection.outlook.com [52.101.127.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8807353EEB; Wed, 22 Jul 2026 03:46:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784692014; cv=fail; b=WfV0+lqgr1jaz97rCVHuVsYaYy7e4nGALd11kt12O2HCR4aDJ3p3NPPLcwN/Aj4FQiU3X16K0fj28A8qWVMSDFVWJbfNLRZI0cFseRH1P+2BaiCy4lBp2Lz4C4D0RiYkY7krvZ5r56Xo3qamdeMB0A3fvVlCQIa3rDquhf+pJlE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784692014; c=relaxed/simple; bh=t/U3R7QDxza6dWO2ZVVBCR6qC1nbEvYCe0umneWbYqk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=E1PU7DS7g0enBHTGBgyN6oZlCMpEdt3qYg8bCPtgD0H0yDtN2CqbLvB7JkUexdIhVrWiqxxrqtIZMMyQmHwxThjcKtC/01XAh1eS8UNygk1Q+/DRpVxvUwnzNHb5PEj7KigAbwTc7j7J2v7JjNy+Tar/B1r8ez8iLYnTNIpZxFg= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=H12FtwFf; arc=fail smtp.client-ip=52.101.127.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="H12FtwFf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t9qdMMkWc7IVUoI6LNjvHHlC+kUJUpdioWyDAQ7RiFl8/EGMbqIlnEtF2VkEDgaN5Y8eeXrV483xhc/JPbQHDlWlbzUwUoY5XR2Rtb2cj8DWEOAeh1Vu9a4h5ZW7tm/l9fbfSbJfOFd757YzSJlchFaphHOSi16tz/W4h0M6SNju/sIKIH9D1FIzJq5XpPVJNsxaExC2u+CnJSdAAsfTLS7jfZGZUByFbGcvHFoEFh15pXDze8397JNap1eTHy57I3Zhe/cfoOcB4yroIyFJk81rBnt2+2K6lqR4I9B4ZKzStxDGWhkY7QKi1hzm3qhNQM6FxCW1BCfvrYFq67x+kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2mXb72vozSrT0IfdD1hAMlbl8Z7Fgp4Cg+Gvfb3bZ9Y=; b=MS3vnb/mp3+VtH8g74+TXBbpdMhDGD7JvzvLR7qhBYVRgzj4u/5sEKpIOI3spEAGSVVZVqxrK7Nh9jmg5xiBu96I0XwPqyKJ6goc+sMN0p8CtPJMn5LHbi0y3O1SVqJXSaD+3lGJF0YfuG87luoDZf16bfpMN5UU/j7Di72jTtSezbcq0gIS+lXKXV2H21afzKzoohB5KpYG3fOSdPR1kLA8XYcx4fvIWy3Cev7h+L3754U56+LL9kv5hEHzN57N4mf/e+VFPM3BJdS3exRhrQ41PWRj9CRml2sIp0jPD5WWx+qCk5VnJYWvRklgSwpIO5b4g06TFNCBIUZKthR/zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2mXb72vozSrT0IfdD1hAMlbl8Z7Fgp4Cg+Gvfb3bZ9Y=; b=H12FtwFf3rzFaF48nMNKJgSOacKK9aBWgO0uXDNfMHG4oAO58qwGRZnW8yIpnz4MWwILpoLMBjF3rmNX3lrSFSdAFcukG+UNqOJudKKemtAv3Ha1MU6iKWA5MiJAvUkO7r4v2O/EvAW4tQHGZIbrHrbekKcG/D85tpK9ijf1+OtUWSSLwd6nb1Xi7JwlTzAwTynFPzJtaoj8yAOmkz35o++o135mFAuXJcR/aG63Fog1SIsH33EEMPxb2eO7GYRXaPIjEkYGHf7paHkYbNYT0kyc/3CrJV/S1JVzdgcA/+/U+B9bmqOOL5j+2Riyz0WMrYQkekNjtYLx0POSchZclQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEZPR06MB8863.apcprd06.prod.outlook.com (2603:1096:101:33a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 03:46:48 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 03:46:48 +0000 From: Pan Chuang To: Al Cooper , Broadcom internal kernel review list , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org (open list:BROADCOM BRCMSTB UART DRIVER), linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS) Cc: Pan Chuang Subject: [PATCH 1/5] serial: 8250_bcm7271: Remove redundant dev_err_probe() Date: Wed, 22 Jul 2026 11:43:29 +0800 Message-Id: <20260722034342.316755-2-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722034342.316755-1-panchuang@vivo.com> References: <20260722034342.316755-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0131.jpnprd01.prod.outlook.com (2603:1096:400:26d::19) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEZPR06MB8863:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f74de55-bc62-462a-2ca6-08dee7a3db7b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|366016|376014|52116014|38350700014|11063799006|56012099006|10067099003|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: sTGgsF7z34KRr9ZIuaHQ6isJKGyYDgP0/57D3ugaPteL683CsBAwW2n+ktP+VDl+0ZKosYZ9Dk8o5YoxDc9KQizXECW+oGPO61i7XQiiMT7lOMcSZmpMkSINZf0d9qUxImhRM82xa6dxrrhl9KIu8njs8UTeOlEULJuJrE7ibGM7W2pK5p+AMv2qRCXvunm8xiw0eXaJW2qdvnXQ6AvQ7ICkfi9huJ8mn7pc3KgLM7bT/aTTiSQiTe2f9PR6ziwNrJzxbH4KeHnCXDvL1hWWLNANUMZBTox6TyRMuONVxWFJwN6A/XCeIL/bIE5uR3imtr4jkXxNbYNZmeGJ0D+32N4KtF11QWO7wt381aD3MBj2U3pNy8AEDxox297UHhHD3wsOq4A4eoFk+M8GTN2usEffDfF69ZSGYXU5Nj83wTLZDZFxOeD9l0eKdlPYtDv1OpPqRg3jkO6xKX6R69krhlGx6fByrNcJO2qjfZw4ohOHImx/8DDLsRDnqLHIzVYXLv1KxDfj4yPPbNZBuJGQOfsjbG35rA12GZkoZJTW4MNKlczM6PYw7nS+qFnRDzPK5XeIcJacl1T4TCHvrfA9B9xUfPGAS64ZYV6HicRhHjV+ugIo5f1A6xyOIiP2Cr+n3+SnnM0LlAmvbMnm21VTHGdqkudMGv6fzhild7iPUiD5TX5j7ai81LrYBTKv1QkJQTQXX7+R+vfjFJ2kvspy2VsM3jiNJ32BaweCjJ2P6Fg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(366016)(376014)(52116014)(38350700014)(11063799006)(56012099006)(10067099003)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HR1vzsc6MTxsO1q3bDxCBZaO0jRxdN5c3UajiHh0PysAWoxHaILbk5Ovygc5?= =?us-ascii?Q?kCrDmSKR8yvYbQvC800dHp5fH0cobm+X/WL/mNoEX9DWwd6/SeXucbLaLROi?= =?us-ascii?Q?iS2Rf8cAqU7T3ffObOs+v1vVpHIoPj7xhEidhbU5Yn8x7/ehaKS5XjfOkDw9?= =?us-ascii?Q?0tW+8RIhpnOyuWh5A5ZXFCI9KU14EAc/Z95i54FwWHK5Y6YBceXqLf4dXa/l?= =?us-ascii?Q?xLdU00ejrLwEtqCWgDoJ+bNkpTV1JcH43lGWvrxxR6dNI4QbUGar7YAlHzkn?= =?us-ascii?Q?Rb6cjIG/LFxwFtzkCDCjvQvHfnYgBp1Z21MXkHLendwAC1ybrvMI1LX3kQt3?= =?us-ascii?Q?yFowvZX6FQivGZqwsXtBi9cghqfy/C16zaf9AXXakZ2zWp1WoM76r5K4Y9nv?= =?us-ascii?Q?AMKTK8PeGFBdhxRJs3vWm02rjbXWVeOKvk9iQigKmn9ddpHyGxy+EC5r6cFl?= =?us-ascii?Q?XRcPyPzrp5cyPslMReVSOSYinK7G3BPI+zIfjEr+KJr6bLZ72pwgSWscEXz2?= =?us-ascii?Q?qhvryeiEVQYKj0Fu52kd9vvFVFX3R+XGsnbOJ7/qaZx+hQyLf/vQGLgxWdqJ?= =?us-ascii?Q?0vjhTD1VE/ON0VE0RHuNJQMz5arLLyjvexMd6MrzC6UPyZQU3CIos3UaOgod?= =?us-ascii?Q?PXPeMpfE2ZLZbie5+onTHhe8NGeGEQalB206tYr3lZO5YAMxTlwFJRciawqt?= =?us-ascii?Q?K48bOj77K0t7ASrfb+tTzK3a9ZRzrja+yjdyVnGpw1hyqC/Pf5MHsSsxpfth?= =?us-ascii?Q?2Ue3aFpUBH+vy69ZIRNez84oCU9Z4jo/efKGSoa/gHJ0UME2jgNiJL+By3/T?= =?us-ascii?Q?cauJtULVFrqm3b3w7PL36pwzmTVJxtcYRSDhRjvUPzvuCo/JG0effG3XJBfh?= =?us-ascii?Q?SeAjFfDK/364hxi0xAwHVvkNG72CdXF5ROWaWnBOSjsMvw++xy96tunq0n0I?= =?us-ascii?Q?rOqdLiDiPKqRIel1cDULZj6fLtZ8Tp8xjg8hngEAgi5b66/3eca/rSWPK90U?= =?us-ascii?Q?Nl7OvTtO2nCLo/HpFka+woTNISbT+pDDwMw7vCjbVHF6Trpu2/Teq6Whn7Tz?= =?us-ascii?Q?DAl8PMeAXCWLliLgXWSb/+fJuFk2pekJYLZDJ4vREDTd6rlHbtPRlCw/ohUw?= =?us-ascii?Q?TYSR1ajS9dDAF0sxguZfwdjb3R4M4cMZsT5r2ghkmiI+QAIawKQyQu6TE6t/?= =?us-ascii?Q?NW2bYDlI1bWO8tkccwHdcNWfRi/5iOjKU1SAqFhQIriPvvJwDHfJ9wIFhe/z?= =?us-ascii?Q?jVe6YzgIq5KoFM/DmBcm4fqVPV8wejtIdb0H/H84fL6+/XduBc2GzdeR3zX3?= =?us-ascii?Q?yt1qENDx6kWMj5R9NX2tor7UghMY5xz7zfMNnfZsjrCtUimTODXB/8J14j88?= =?us-ascii?Q?ORE/Xc+DOFfnRzJxQ80NihGehm6GGqFfwpmgKjhBwV0xzH8ZGFKIQJ0Vk3Rd?= =?us-ascii?Q?BgsjD4125K1XShUd+n1Pz8QOj4jsjEMgzGwcZ5Vn2ZhtSyvDzDFFUrJGqZtH?= =?us-ascii?Q?YqmMXIvJity5/fmCc19BlT1G7vQBL7fmqIVSm3ovlWCh9Nsg/Iis+oVLbDfM?= =?us-ascii?Q?DvptBg1aWwgciGPiaMYtPeW6X8npZ0VDV8Dwnhgwa5sSpvO9QScQuiTmvnkj?= =?us-ascii?Q?4D0fRMSV79siC2OaS2/yIL58u6PY5qrQll1usWZt4y13r2kqxsLrcuUXonNn?= =?us-ascii?Q?9hwaTCK1U+23fJIJdosec/XkWm2QTgGU8plmbcgM/il6PpXks0ibrMZUbfzQ?= =?us-ascii?Q?75KJwJttxw=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f74de55-bc62-462a-2ca6-08dee7a3db7b X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 03:46:48.2782 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uJxOt9hXxAhG5aj3aRhZ3vsAhThSy4Em2KgdZXgK1aNHj7Rg8TCbHHC+WOz6CCko6FjG0CVuTcOLz+R6atyDsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB8863 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err_probe() call. Signed-off-by: Pan Chuang --- drivers/tty/serial/8250/8250_bcm7271.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/82= 50/8250_bcm7271.c index 742004d63c6f..cb7d594d263e 100644 --- a/drivers/tty/serial/8250/8250_bcm7271.c +++ b/drivers/tty/serial/8250/8250_bcm7271.c @@ -1099,10 +1099,8 @@ static int brcmuart_probe(struct platform_device *pd= ev) } ret =3D devm_request_irq(dev, dma_irq, brcmuart_isr, IRQF_SHARED, "uart DMA irq", &new_port->port); - if (ret) { - dev_err_probe(dev, ret, "unable to register IRQ handler\n"); + if (ret) goto err1; - } } platform_set_drvdata(pdev, priv); brcmuart_init_debugfs(priv, dev_name(&pdev->dev)); --=20 2.34.1 From nobody Sat Jul 25 00:03:09 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013000.outbound.protection.outlook.com [52.101.127.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32E9C3E835F; Wed, 22 Jul 2026 03:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784692018; cv=fail; b=eCm6RNKy5AnLGy7wkkLELVrNK1PrxKpUu32dtkivdU11fPEYPvGaKov23x3nP0wmcoRU/P9s7vPOBo/uRqKSLNQvd8S1QNX6vVNcI5yc1lbC6Sr/pixt9Y7rG6h2QRVFgCZA0S40PrObJQ9XLRz79QB/StlMV/iqiM9W3hcFyDs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784692018; c=relaxed/simple; bh=YWfAage6qAzi3Tlh7IuiZUt1J4/80C8ldjkXl/4xgfw=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=YDpwiBXZPV6MhFcF3HFDmeiedh0M6MuukfN5jReHA5ocZElmZjNOnOliaHUo/fFUkJZTvvzA4bUYg11xVD8e/vG5OiBdNuk2UZKo1UiErRwi6fy1KjCCtf/QNq+RoJ2B57Px3jO1N02BYAwyqm4ZKccVLoci4o9coWDyaDABJqk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=CtOZ2B3b; arc=fail smtp.client-ip=52.101.127.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="CtOZ2B3b" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=L5gr1N4bFDy0JxGqS4l0jY4tprQ/9s2p6i3L0NqeXTIvBcjmkrBddd6/eqm6hvzVv3S5n4AjcjJdNaxb0ZuNRfv2TrZ0A+ij1eKGIGYJFrM6qp7HwvAg0igNTEd6+8wGMu4ZZ5qCQIhgUdXmFornS0UxkHQhjhUgSfnKR6RFuS6Xkp/66pIsJX8eeZFGl/NC0t26dHWI8GEnWkLwwKjI7rdSOfnXEGqpht0hBh9s0C3lzRDVLQ9phAMhxCYxtsnTQGbhtaguKQCRyX5nuZReUTyl9RkaLWI6aNJdT+Qgb8taircDOuRaJBo7WwdItg0r8qWtDnTog0VwViH0Anw86A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eXsFUedM3bC2oR7kFlvCdtbhigWYbkfccQEtrdp7LkA=; b=CHSKZmBvIaHoNrv1q4CCJOK/h4BsaXbL8iympD+/a3R1eJTgEPu7ZbnJeNeTYLtXmCKWBqoaqfFfBiad0iIb9J/xu5xadKxsCnZ7KaebeasuVQC0Mf8zn05U7EQTUqQei5aEf8uH/vsBlMszm0ZXIHBSESjjJX9befezZIkiKaAo7FHFG36niR0WR9H9K42BYA91QT1W0wUvARE36E5tQeoS3Is2X6VXfFlEs7ZhdGB1450e0htZvtFuaSfErs8fZn/ethM5uSg2lxOz05CokN7Pry1IF1vvWrA7phMIhENEaW3twf/G0Me3da/F44HG2rzjrCFjHIq9f4nzQP53uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eXsFUedM3bC2oR7kFlvCdtbhigWYbkfccQEtrdp7LkA=; b=CtOZ2B3bRKSTAuRNnfxHH5kJ7F28CHa3/nYU1gz0zNH1qGXpFFid60R/kX+Ln5go7hBe5Ygdr5//tMwi4xpiL/xPgmWraPTszsDgdN6qKtL1o7mLu8QpG7tC9hFhRv5zMyweTN+ovTEUMmR0g830iTdy4cqHyP5KY5+s505lvf3ZeXHQjZgjQBq601ntzsE+vvPUdR2UpzgSin/Kz7J71aO7Xz+If6JA57ZezrrrHwM5V9OQqyb7cnfVSWXy0oowRaxMN60aq65iSvttqnid2PSCSuJ83JQJyky0hEFg8i3rtZ0olyl4TYCuf+npUIStwLLtKBZ/qC56z1xu98eM3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEZPR06MB8863.apcprd06.prod.outlook.com (2603:1096:101:33a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 03:46:52 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 03:46:52 +0000 From: Pan Chuang To: Greg Kroah-Hartman , Jiri Slaby , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sherry Sun , Robin Gong , Pan Chuang , linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS), linux-serial@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS), imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE) Subject: [PATCH 2/5] serial: imx: Remove redundant dev_err() Date: Wed, 22 Jul 2026 11:43:30 +0800 Message-Id: <20260722034342.316755-3-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722034342.316755-1-panchuang@vivo.com> References: <20260722034342.316755-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0131.jpnprd01.prod.outlook.com (2603:1096:400:26d::19) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEZPR06MB8863:EE_ X-MS-Office365-Filtering-Correlation-Id: 0749b530-2a0e-4de8-069b-08dee7a3de12 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|366016|7416014|376014|52116014|921020|38350700014|11063799006|56012099006|10067099003|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: e4svmrCMjymqGbzjqcZC3XcmNUumbPe0Ndq/hjz+aKNTfzIDZ8pqJ499Xt3pRF/Zpjd/r80o7wwfQI388GXWbJm8FCGuKQ1RBuAEO9RC77LFW1r+HaULJ1O4WLV/u4d3QztXa7V6prNV5+GGN9cNylS1nMM5Qwwg12PfuN1zbZuUx6xGzoy6IoJW6LGWuMBv5nDYU1m1ardS5O7zTMbS48/vwyD/F2manFCju2Rw6SkptZxTSjhbvfmIgkyX7B/lDm3X1qh3y/jVL55eErhiFYYLndpS2uKB0F6TUAq2qtdgUSPfJM589mhuLi7DUvTTBwr5tA7GVph/O8Mmj7Vb+eSbKQb+vAXlXTQwHTHpRmC5XBPe6/Og7BQBZuqEybO5UfQgcfkt/mcAcQhQBL4pLOtTDaMZNHH3EhA7bROJnARRPFee6XiIY4OpTl4k1CeZpWNm3Ohyev6wJRdvLED3sH9JYEhF/v6p8mAOA7mu2vBKnujDZJ92pfF29JlZHwGukRUUuz40Mutyb6EqpzIurqNybfLTzC4hoLmGMJSfH+oQuZfl1P4DNVQH/0ipEklka9Q4QN5VI820cuGIXLvkH348vC25qykr2/uiNmymInTq28e2m/LBX7UclaVcgQm80cWcdhLTWWx3vJ29Oor+cxOF6t07Urmx5/7hWdKhSKF8K3WiU0bXlCf0eYmFg+OT5D6cqpu6xCi2Syc2vjtkVEljO5zWF3RuaGzuuXQ2vd2X7UP9AUlp1IjVmLutjcZ4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(366016)(7416014)(376014)(52116014)(921020)(38350700014)(11063799006)(56012099006)(10067099003)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?epWgFiz9PEtsKElrqqLp+w1ogMsMKQdCLXr+nVW3umtEhPZ6MeWrPiV0mY4p?= =?us-ascii?Q?xs8InjA9wwST1XjT4bgNBo3KK18jCJCYvFGRm2qMGo+F9mUZf0V8B/jIFYc0?= =?us-ascii?Q?OfbssALTqUnRxyd5h0MsnzNgtZNyxzyP0C0YKVEAv+4Ej9lZ6d3nuO5ZEVrc?= =?us-ascii?Q?TvtPcbzkU46YDDobViqC3+Kw+3ZcaMkI6PjoOQABiovqb6dm+buW+Oh98/kr?= =?us-ascii?Q?W+u8T3LdviwOX3E4tZIsYYWSWsQnG/3sDtQ0AYA9K0f01ckP0DidsqySHng+?= =?us-ascii?Q?v6afag5g+flrGGu41mjqn4Km50PalBPi2UvAxLn6CzFrTP8DOQWrLgPImkRG?= =?us-ascii?Q?44/0M49xGcf6alIad+Cg8C6O5ntxXynh9aCnmH2VGeDMeHkkASsHEszBFJSw?= =?us-ascii?Q?+JgGJ5rrzOIaaal4FXC4kLT4upXZnosGDgOwsPALiYjZZdv2OprwirjrBHT4?= =?us-ascii?Q?2IJ4qKxqFpfAoOmHBowR9OiBlMjPmT9KEE9v4hp5q12I2XW0RZX2PoSO0ZMH?= =?us-ascii?Q?ZM38OmovjEH3RfMiLlFk5iVbFwxXRimgmpS2J3+V8OLRfWj2CiZTrqxFDgik?= =?us-ascii?Q?HjAIp5X/CrOJOmf5TxE5aerO16jotkIz6MF+Mnv816s8Cehyy2lg77NIY+OX?= =?us-ascii?Q?y1Mq986hEOQnWGjKifn90FVwpkexpM5k8dUO1ZGPr4DdE74pTgDCwVPCGVRN?= =?us-ascii?Q?Kkn3XYhExnu7+pwzQGF9/SSZGvymGZNPNZbWvgRFxKiOMSVp4fVhYbj1CprK?= =?us-ascii?Q?NXWs1HgCjY9NK7w+TyBcYh+7hHNxWW2unpFW+uT1ZuR76PxMqk1BeZPrLs7u?= =?us-ascii?Q?wr40vRSjBUkrVmcdc8UuFBIMA9a0opv0qBxEieC8RHXaM2Uub2FCHbG63Kes?= =?us-ascii?Q?hk3RfGj8uUKB7jEf6SjsCvgqW32N0jajtZbxYG9YZ3clHPY2sYEb3lRe+CgN?= =?us-ascii?Q?XLH5ndlA0OoUWw6VdKUu3pMLx7K/3pNT8eHyCFpFMEaX+X79HOPo/wH+r3AH?= =?us-ascii?Q?uNu6ZMqn+DgEAOpwzLZ9MqcisAL2W3Fz/K3xWiRjCFfJ+TAXIrID249oCXR4?= =?us-ascii?Q?fTa4DiGl5SjKpGkw0R+BocPxhsAUlAJTPL2h4AdbeiuQ3zssOBXXzeoPcXtl?= =?us-ascii?Q?nCP+jL3gxkS3TKQ5jBeJ6PBQn0XfqyGMwHgYYYPAJ6UiHZ2Jy3msEezotDxU?= =?us-ascii?Q?kDPwTo9g0Lm0/fZ0ad4ZE1Il/kplFQTrNMXYr+b5TYOCz9ZnN+lCqqQZGX0N?= =?us-ascii?Q?z9oz39j9jb85VyiUyF5x8b4LT6SKnVZ/mMaN3AX9InKJsQrstWSYV5bMQUQl?= =?us-ascii?Q?FiHXIeDFitm060cWhjNKqhMJZWJ+W35rEnO8Ln5zIJ7f5CfecXe/9lKeHwUH?= =?us-ascii?Q?YsVTCrqB/ywdcfjIaSRklK2p1xazHMybXpqKwI0NrK9V38LCBi1gr8BmzgWj?= =?us-ascii?Q?pXHv90Ir/mmZWAklDplrXHPLPUDZ/oaHOzZPcWeSZ9uELnT8yX6VOcWgXHcl?= =?us-ascii?Q?CtK6Ivd+ERHRPZGBrscUlbBGVMKPCvqTvWoxljREj2o7WFpGGrDoNBI0W5FZ?= =?us-ascii?Q?gabYO0MYEPA+9Sv7MK93B4MYM7Pi6vKF1qfsx7SoZ5VxZJJUmU3Sk82Guefn?= =?us-ascii?Q?9tbH/rlVvaxQlYUtJ/toX+2GUaPLunuVzCDfncSh/sM6LTq1ncYLKHAlvZxm?= =?us-ascii?Q?Pet95vOTn8btj9P5wuCUCC/2GGyVGFqSRf3xmfMJi72hCWucMCNMPtYClsZE?= =?us-ascii?Q?+L4jybW0Zg=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0749b530-2a0e-4de8-069b-08dee7a3de12 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 03:46:52.5872 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8jUtR/iuNCTrBke0yZN63J6UtT4z1euIgq5POeok5o3fLW0ORg9c0bbb8mKlX9vmQQ5wj3nldBo+EUORpqQ+Uw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB8863 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/tty/serial/imx.c | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 251a50c8aa38..95fdb60e06a7 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -2602,34 +2602,23 @@ static int imx_uart_probe(struct platform_device *p= dev) if (txirq > 0) { ret =3D devm_request_irq(&pdev->dev, rxirq, imx_uart_rxint, 0, dev_name(&pdev->dev), sport); - if (ret) { - dev_err(&pdev->dev, "failed to request rx irq: %d\n", - ret); + if (ret) goto err_clk; - } =20 ret =3D devm_request_irq(&pdev->dev, txirq, imx_uart_txint, 0, dev_name(&pdev->dev), sport); - if (ret) { - dev_err(&pdev->dev, "failed to request tx irq: %d\n", - ret); + if (ret) goto err_clk; - } =20 ret =3D devm_request_irq(&pdev->dev, rtsirq, imx_uart_rtsint, 0, dev_name(&pdev->dev), sport); - if (ret) { - dev_err(&pdev->dev, "failed to request rts irq: %d\n", - ret); + if (ret) goto err_clk; - } } else { ret =3D devm_request_irq(&pdev->dev, rxirq, imx_uart_int, 0, dev_name(&pdev->dev), sport); - if (ret) { - dev_err(&pdev->dev, "failed to request irq: %d\n", ret); + if (ret) goto err_clk; - } } =20 imx_uart_ports[sport->port.line] =3D sport; --=20 2.34.1 From nobody Sat Jul 25 00:03:09 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013000.outbound.protection.outlook.com [52.101.127.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD5D13E9F8E; Wed, 22 Jul 2026 03:46:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784692021; cv=fail; b=I7/il5j+mQqUz2upPXg3I0vbstLix9nqjCLgkKnD9UJgvyerbpS5FREtgHBKqEscmf1SFlzuA3c4/d1kaLwqo6FNQFqf/mLKburufx2TRYTWWeM2NHK/RQTqKmC7f1JeswmaUql42SUsIk/ACGTpCI8wQjXTrTj4SzqGhRnR0Kc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784692021; c=relaxed/simple; bh=JBVv4XR2/V8x2lEkRQ2hU9oc5J2MFu9Ds9YtLSYQ7Bs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=VKiOWF+APgstzGMtfoXem6OCRUAfc2htMje8WOsSW3eZ8x3XMkZoQgthRb4aacwmnmTYDnxzZ3vhe5bWLzP7ve/3VlYnO5hf+IS4DB0z2BbUW1W2QyecSk1PFSUdpUUNss2MDQQGYeaQ9LFpfHRAMg8T4dVqW73Xl+k6onB1clA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=IHle0Ejz; arc=fail smtp.client-ip=52.101.127.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="IHle0Ejz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=tdEYg6Em7vKKhkH6hTxQB8V+MDRc3cW4BQqp12z5OmzeZrctYCb4nHeFh3jcAevZ5KktSxCSyxT9jLItXtWN2hZ3Df6I8cvjgNpxzu5yywKlTtCivZA4gRn9HJXCJYoymO+6SXh5GqJV3BqluXQUACYl76z3Du0g1VIPcRiNXhXY5RrjRl7Vb6q4zknj9jfsRWwaIhxVJ/Fn9umw48mBHHDVKXX8aMEnt8jTP4GcU75thNfneZxyN6t5CP52hbl7qeMZ5itNg6ciBnCIGsq/sCJ8I2X9XgkimHrxCe8Qun+pHFH4IoxwMEDdw3S0aEMkyh5mCTvbiKoP67QMHPUt4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G+aGVhrOI6bMbWQ+jyup82pLEm06n0X3E4QdbpW4kgU=; b=Q3oql+rzcG4yAFzvazAlJBSswO7T5mkzbZajCTY+WRL7gVs3H6+I+MdCw0Tne2vpXkVnFYCanLKoen9EzEIXlMRgHCpVPQVsUv5NFCnLBwoPJ35sHEsmIad6UWHNP4mcw2YWFCdWwrSxkB838RR1L0eZ76no0oaxib1tV+/Q14U8owsVQ/QqngFmF/TH1IeAzsOlNzJtLu6t7814vQLUvfsvggB6czXnJxSLur9SO7wGT7m69VshBa2us4CKB/a79CkrIp7vdL6hvvStIRXj4ecb8eMsCtJsr6E/HiVtVwJ1ZGZ4TGD5vdFfUchwmzRpXs4/UhJhrVfwhhrca7PlKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G+aGVhrOI6bMbWQ+jyup82pLEm06n0X3E4QdbpW4kgU=; b=IHle0EjzOGQrNVctRp66FpbiClTm4y521+B+QOAguS21tklAKcZnwvowCfitNvT2AP56dYO3u69aKthYfoeLslFp6OoHpODOSiHFoR1tDBw4gexZRAOakvL//KBvmk4pkT+Dyetvh0AHcEORi88SabzeUi7VnBj96Euzd+ijvc9xzof2+8IZEWsq5cvfVnJxUIj9orQVbBUi3BHCyLGz/EndRnnrnPn5fU0IuFazfHEdVv9TgFZMRD1v8S1arcuoh8u5OWRmkTfANZUCs+Hr1YZrd6KZfXfeu1AgVbMvZgnzr7Tr00AoqzbTWdDHpD9DXRev8Ic/LdQzMRArBxwdAw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by SEZPR06MB8863.apcprd06.prod.outlook.com (2603:1096:101:33a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 03:46:53 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 03:46:53 +0000 From: Pan Chuang To: =?UTF-8?q?Pali=20Roh=C3=A1r?= , Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS), linux-serial@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS) Cc: Pan Chuang Subject: [PATCH 3/5] serial: mvebu-uart: Remove redundant dev_err() Date: Wed, 22 Jul 2026 11:43:31 +0800 Message-Id: <20260722034342.316755-4-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722034342.316755-1-panchuang@vivo.com> References: <20260722034342.316755-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0131.jpnprd01.prod.outlook.com (2603:1096:400:26d::19) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|SEZPR06MB8863:EE_ X-MS-Office365-Filtering-Correlation-Id: 98b1946a-25a6-4ab8-d5d1-08dee7a3dec9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|366016|376014|52116014|38350700014|11063799006|56012099006|10067099003|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 64Ct3SIH230ppppRtwO3E/Gu30Ods48srDAKSk79RRh/D/3ILvwv7HGfeLxR3P/AJwtw4+LcCqUhquL2vUSuxhl/A7a8sudIvhaB34h1ZwT97+hh8rEFdlCJ3KgjhX2CUSEw1L4Dm8mn0zGwZ53sxDslAT0UUctNUsM1M8n5FMTRDHQMZ8VCY3j/N0Q+HLdi36s75rFzORuU+NF1z5/cbyafqqUWQGQL5XidLbj5ObRkqCbqE0JvmErs65a7wUCLSQsTDNEAUn14cxVbE0dsUzAOvpBamxaG4144JdyumD44OlsqLfgPsI1swn30ztN5eo/vR5/mixXekhdzabAGUjh8LZK2tqqyvGZfbWvvnQmiwbDt14X86p1y0Vzoq7uBh09gpx32P25KDzHfTJyLSPj76Ge4RgDJtO9/LS9HVap1m1XgNgcLOkyznxLvl5yszLS0WKzTCk6E2RQ25O9N0EJzOnD5h0W32yQm2YtUkhGdGljtHDJImr/KE/MKxi3w/P009RiCEX3rUjak5d5WJxFg7ZlD/5mTS2vylI98skQt+pUMZQGPwrUD8zA9n+z2lzE4dX+ovGtZPDabLHdYLSzfM5FR2vmU+d2GF65lwbz2VD2E7zOYxEBUcU+1ruh8FiTkuHFEuKHoz36QESa5UYlm2bbdMPl0KWX+PgkqJDRitGKE8r83/1OQT51ciS+2Xh2tigULMzjEJIhl2Hde/Jfci6+bLgH/6QvVqEHnm2k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(366016)(376014)(52116014)(38350700014)(11063799006)(56012099006)(10067099003)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?manR91W7YlAxsJG2U0DRqrBqUjU2oqzHR9sbbe6FGQRhWxLIxwKIVoyJSvL3?= =?us-ascii?Q?+oyYMGQyTyk7JEX2cufBgZp/xOqHkRTQa0L3izpIOqto5Xt4PA5wC+GDyvNp?= =?us-ascii?Q?ggj0s0tZss2nLPlLbR6AEik1Qhu3XWCZxSgZfW/l4kebjaobLVgjlHNw/CUT?= =?us-ascii?Q?VACqY9elFEGrqaDig5NQUVL2nSfeJhLR18Pwig8NKS+22RzRJ1cFnoLHo2iz?= =?us-ascii?Q?/irP6jDpqXmjDxIyfZBKD0iZR8BQQgjjfCyK92PY5OADmNFHs3Sjb1J52Iad?= =?us-ascii?Q?yMZIs/LVbdXLGEk40rh6VXx3mBWCv1uGqCdOvyqxgtHGGxNokC/xlnidVwPP?= =?us-ascii?Q?jVn/TRsi3qv+qckCeBP5IRoIaBIkkiWNM88FtM/gE3VtZ9WJRnvB8WO5fc8y?= =?us-ascii?Q?YRGvUyW12yWywjh0XVOhgRGuAluxyVFRQmG0HQyp1N+EGMUp4TuJ10WXix/z?= =?us-ascii?Q?+zlyACeiu0ap7ZdWFc6O+gm7RvZrBbCxhAGEiEM1mpfWRXXq6uEvEDhdci+P?= =?us-ascii?Q?QP4kxRSYvjWER6xScwys6o/yNhh4F3hyarBHUNXMW8TPo9d/2dSCINWYyPXB?= =?us-ascii?Q?6YArCJyIGy3xg/dg7elB6bjF1+I94brh2GF5mxJHeSspUuED6rmOKOzpssJE?= =?us-ascii?Q?4PeOrA947MWWlp33FyKh7gRlp7qJd9Q37fCEX9cvpTUac+K6d9iiIa5wCUiE?= =?us-ascii?Q?GXFcxIjgQP6pISGJzxf1fHNwLaKQQ9AtX4qb8im2hvAjO4e+f86YM+3QdHV3?= =?us-ascii?Q?u1IzANYySEfKaYT+xkDFSpZe5WeEQjV9aL/BMZmP5iBQ4eFFd12TjJv+KxpV?= =?us-ascii?Q?zdf+a2io7Dg90nVKKQWod2PipT+G446EP/ey5IvFXczrqFpvtRrQxYavYSFC?= =?us-ascii?Q?aKJe8jH7CJqDn0u/xQgc8TPTJXEu55W/m2pQ/Yn8EySczpUBe6YjcP9OzMYF?= =?us-ascii?Q?YMGX0nuku92tGmhwY13CPkZj7TXcK0TvLaeK0mcSnda4cduy3vPpUTvqWpZW?= =?us-ascii?Q?BmMiGk756HLjwsfUJfV0/OGt8XGGv9q/bjqY7j5cIaDhCNVEycfH9t5RCdTu?= =?us-ascii?Q?+yhppMBcGoQO06nwSe9BwjoUiNwhkHw9CP3RjUKkRlcEZ4b/8XflbfoX7B4d?= =?us-ascii?Q?vO0zGl8u99+LUE14EJvch8JgN6JDpYz3T7kO5PAVXw6l29+FyUJt06/x7wbd?= =?us-ascii?Q?rO0LjxwAhrudlUOUv+QBBt8w6dggbkJ/1WlEJO5KlIZt6dRmo0C98yIdjzSF?= =?us-ascii?Q?GCLk49CfWC9UKasUk68jaWpUkcjOvB8EKzkkSKQMAwrzj3VED6bKjBINZT0m?= =?us-ascii?Q?G+alWCv7Q6cpoBkbWtDHDmvPOAL7LRkUVWOnseyhiBVAGKlbritQrq5pRwTf?= =?us-ascii?Q?Uf4TwpV/2VKZGK2ao1zmIwWFlOFNxea//vtaRJDLICLrKWKdLGWpqTEAB41N?= =?us-ascii?Q?ywT1HlhaxPAAbXbrTu6WMrKm1lWhj+HUKhd12w1/rH85F3kAYyehJdIntbSS?= =?us-ascii?Q?I6Ydct8gbxN9tjG5gAhgNQQY2c7LQauGZa5FC/5TZWx1yMDeW+EXn7pEMejo?= =?us-ascii?Q?n/6GR0KA13rQ9l2XqRz986U6J8VIbHKvaJFrvXxPhHnLqW2T47zoHSb/tcod?= =?us-ascii?Q?9vS+9+AKiZWFuIM3JpF++Lwxl55xLdSB73e7fWi8zDFph8bgCK3Ylagnkrys?= =?us-ascii?Q?ut3tcE+ekiM0zU7rb+ywobCNxe8dQqvKTqJ5uZkSDhJayk3T/b3pfLzHFZPs?= =?us-ascii?Q?sjZ7ANsKzw=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98b1946a-25a6-4ab8-d5d1-08dee7a3dec9 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 03:46:53.7964 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YDFefycnXAJz1Jv6IGcvqQV8dz0AUCwGd5+vy1CQnorDfybrW+WayqMGC3yffvO7vTXzkwzWeW+xjckWIo7+gA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB8863 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() calls. Signed-off-by: Pan Chuang --- drivers/tty/serial/mvebu-uart.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uar= t.c index 8e52be2b34ea..33ea496c93b2 100644 --- a/drivers/tty/serial/mvebu-uart.c +++ b/drivers/tty/serial/mvebu-uart.c @@ -404,29 +404,21 @@ static int mvebu_uart_startup(struct uart_port *port) ret =3D devm_request_irq(port->dev, mvuart->irq[UART_IRQ_SUM], mvebu_uart_isr, port->irqflags, dev_name(port->dev), port); - if (ret) { - dev_err(port->dev, "unable to request IRQ %d\n", - mvuart->irq[UART_IRQ_SUM]); + if (ret) return ret; - } } else { /* New bindings with an IRQ for RX and TX (both UART) */ ret =3D devm_request_irq(port->dev, mvuart->irq[UART_RX_IRQ], mvebu_uart_rx_isr, port->irqflags, dev_name(port->dev), port); - if (ret) { - dev_err(port->dev, "unable to request IRQ %d\n", - mvuart->irq[UART_RX_IRQ]); + if (ret) return ret; - } =20 ret =3D devm_request_irq(port->dev, mvuart->irq[UART_TX_IRQ], mvebu_uart_tx_isr, port->irqflags, dev_name(port->dev), port); if (ret) { - dev_err(port->dev, "unable to request IRQ %d\n", - mvuart->irq[UART_TX_IRQ]); devm_free_irq(port->dev, mvuart->irq[UART_RX_IRQ], port); return ret; --=20 2.34.1 From nobody Sat Jul 25 00:03:09 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013046.outbound.protection.outlook.com [52.101.127.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24E5C3E8357; Wed, 22 Jul 2026 03:47:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784692022; cv=fail; b=K5UcpccAPLk0aRTKauQVYMCZGlL2A2zuna3Cd8scv0mQovLXNK45BcjAt2EhoCAzAEd0xjJ9JVQ3rq4gLiv4QElh12yGUT9/+hXQ2ik6jg4vinNckIMmUqkjNTzLud/HmUvPoArWFD+dVYL1WYNYAb2XQU7x9JoIi4IeavRv5N8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784692022; c=relaxed/simple; bh=8V0XQLoQZFuNI7gFIzJ+gpQXYIKO3xCZEIpu1qgmjdQ=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=AZSW3rWP4XhO/GMNXRZSFHS5vDLe5j2EUSR67emsv1cqBBUSPCtEHgfQaMuUvx7rEmF142XrWs+DJtqQ3BrwM3W5EsHrpyanhVQmUNt9w/HrUscNFrOWApYDxYOIqC/SIG/XGaChN2L5kiluI4OEX5exB+LIzU+si5SZZES5sKw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=TdTc1aKz; arc=fail smtp.client-ip=52.101.127.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="TdTc1aKz" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=phrvA3mL8+Ha/H+dhubcWPINkbi/q1g4AevVeRfH6+Yx+wxLV3IVkAgA//EbaNj3N9GXv/ROoq8NjswxxBFIErY56770WecnDRthQEqdsyA7H0ZJAQOtDzph4he6p+m2nhOJ3LtZUKZ4Md60KueaUUEUczsPHtYu9w+nlwGi7xM34JzDMDws7RSX2JE9Yu4aU+ZZqQwil9Or7FJBQXIRbx5wRwE+TcU3Q3w+accf1hMI+U34RZK3Rjw7yNWtQuOIu6V4QYo6cx13mkn8JBHqxUL97etUHRWkqxXF5dWscaNqpVr9JhvWHhmXR68KjxCh0+h2cJtn+/rCozgwiapROQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/3AlypvLYtyd8ZPK7lNMMBHLPTrgEUelntuPN/0zfXs=; b=u3KOm1TDYQAf/OZHbRFXZcTXRsq9gyu+gVeErL8pbtDt7IJBy9WcaC1axCaAsRfc+ux39BqZD4IAMLg/Gn9Nn3gOiRkFIrZP2QjTXkt0eSWfKhBQlDmAdcTh58syxKlZXSQ/rmQazywnBH43X375rd+splWGGthcbrnToLJNrzrj33/Et7ArRsrtL0eeYHam1bEozKoMoSgyKZRIZdaV+um6Qc6Wn4Q/lh31vw5vPL/LwQWJTqCB+he7qO/tre+fx/azVByVWgBoYzUCbBeMrZqBPcV7BGgn4knKTNihlMLLmEL+Mz8hxrdThl7ocIiSC9uH0EpIxUkfQWQE1TAv4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/3AlypvLYtyd8ZPK7lNMMBHLPTrgEUelntuPN/0zfXs=; b=TdTc1aKzEgVBN6Ar+g5Nc/3hprx12Lz70cG777SOZdNjm/BzAvvGzfggyf4E46imYapxW4CPmotQI45WD2rJvdfuKRW30PzXN09WUv7hsvaVR8ENQw7JqA/XXtqpbFWIf017MHeqt4NY27gJb195NqSCp6pr4rUJBrVkaGWOmrUO8jL0ohMUEoGjR1ybgoHfSEHFBMYuu2emAy/XDb21auQSCO9M1H1bBy6hFDYcx6Ktql2gbgXrmcLwCdpZFu1y0IyisYu9bop/Qd3PG0TGl6R2gOKLc1LSfgR+amEsSJFctm2Ko7J6CJ0KVja9XlJF9C4Hi7iNYvZCi2ff/nwECQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KUYPR06MB8988.apcprd06.prod.outlook.com (2603:1096:d10:99::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 03:46:58 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 03:46:57 +0000 From: Pan Chuang To: Greg Kroah-Hartman , Jiri Slaby , Pan Chuang , linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS), linux-serial@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS) Subject: [PATCH 4/5] serial: mctrl_gpio: Remove redundant dev_err() Date: Wed, 22 Jul 2026 11:43:32 +0800 Message-Id: <20260722034342.316755-5-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722034342.316755-1-panchuang@vivo.com> References: <20260722034342.316755-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0131.jpnprd01.prod.outlook.com (2603:1096:400:26d::19) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KUYPR06MB8988:EE_ X-MS-Office365-Filtering-Correlation-Id: c22fc2fa-f94f-4665-010a-08dee7a3e0ec X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|52116014|376014|38350700014|11063799006|56012099006|10067099003|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: we2CfLMb/tGmIz8/n2Bs/Ot4i0/diAaotGI2bQSrsirp+lYGQ1fsIiy1TqJsNSxI+zBul5sxJBVG7GpmXtK3SEuuj/nlvHzX970gsdV5Jo6Ed+224i7nfkYudb0cAEFewjm/Qie5eowQnchlVFG9OO+qHKamaQO2IQUmjuro1iB0a9TbEIkDoiMRbyqVeHOtkEW+l+Cu/h8Rbx/PQl+/RTU2g+8GwamL1EGOnDDwJBL5qlSI3SohRLEDYDs83ryM9Nd6XCeRANl1dKF3YDmw6sKIcjFEi7I+7PvOYD8pVdX0sATGg6m2ZoePbOnXFOxOUnlUBcbsaKpvsXOlpOfR00w2FEz9yHKIf09XeyADSViRe9CM2TAKMzgc8PEifz+kSOuMPAOw4X6XAkuHbwxYqFLNmOK4AhBUE8Pn4Vc6JYLdgk4185+TpCaSw4xgoOgGwriY+AW0Ue27aoGUQMhj7aRhBM90W6OTlcat1IDc0kJgzu8w3kouu/xVltMYzBZCinriUsKCjbX2YJaQYn6s0DqETL4bHLrQ/y/5+Igx8Yq8QzyDHRLpvHrPRCqzK5EjBhCbSkED46T1EixJrSVDj2qcreBF5CwK4sJslpjE/TOkQ6ujI2Tk8ja7X9aMM8mHvbGV+tNWQyBhFq1y8KS6ci4U/V8qw/5YF8wVz7o3OuVRwAt5uoPDUryR5LlL2kxVTH47Hg9u4T1kfmIRvpgSQGySUMXkB4CJ6uyqGyo7KcE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(52116014)(376014)(38350700014)(11063799006)(56012099006)(10067099003)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q0hGa4ZyyMH8jc8Kn1WWI4y/SR23NWGPpQHqA+DAMYg21O71mkZUgR7tNwZB?= =?us-ascii?Q?yBzoA/oOFqrzOb6aRIohNx24f87Qz2YUeP7XCmtDaUdqiHjbkp34bYGxJniQ?= =?us-ascii?Q?/RxZLFP6t5opDUQuVT8MexeqSILpjfNt8VoyR+oFBtUZU5CjImopuEzfSlqk?= =?us-ascii?Q?BRlBS6DTI2sesrl+eQRZx+34EnIB7VsuhQ6yU0kwW3a2UVL0mw3nL2svGlt1?= =?us-ascii?Q?oPxsffBendemwIDGPOvp4haE/8MtIIiu1RtOTY+XFrF6MIa92FGvHmh92/vb?= =?us-ascii?Q?3fbh9v1EJvuozwyu3Zu2WvIs+U+MA2C3M30o6Z92en8ax+eURbFIR0GfSTe3?= =?us-ascii?Q?nyB9kdXPecFBVGPbxG2yW0Om3KdvrtV+Eucw1HwS384RNjhFlcQur6T/w5vl?= =?us-ascii?Q?DurwDv1Jj4dCbxlkNu1VGrvWwnt5d0H17/62gBapHI83s902UURdNRIn8Fg4?= =?us-ascii?Q?BlpFO4T4R9EdPp2IxDqXaz7QVKUGbf6Go5HHCl3UPuo8NdHfIhOxqehy5WDP?= =?us-ascii?Q?G4rr3zG4eZcAJ8oyRWh2pjkpxhOl5nX7hukBItdJf1B0vXHPfYYycPB1WdNj?= =?us-ascii?Q?/ptgssflWHXHhPiLL6tZa7Aq/UpAOwE2FbbEwhGxhXwWzTpmrgzGXpmWNyWd?= =?us-ascii?Q?OCubJ+/b2JButr6BgrwPLNSIn3RPhs4lOFJ6kx/TFFP91LLGgOUHnALov0sg?= =?us-ascii?Q?/v28b2c/d3X3d+jKyHtMNhp+a8SrEi9KLKcRtEzKcT0brb35Oe5qn6qeilwv?= =?us-ascii?Q?5VJmowfEC4CwLDdyFZQ3Vb4MC0ewZ+MyAU5C0R4dbUlZoRxdKXoUiFzMyfKY?= =?us-ascii?Q?nLWhucOPmqgMB3dD/JANokPW72mN+T8rhQ+KjSR9+Dx9NsxiCcY/pEBIcT3n?= =?us-ascii?Q?NAlPoyDGayW0wAHXg0f2u8nl05XhDrCQGY4vJYVSznUKt6Mo2xGIS4BicXjA?= =?us-ascii?Q?rYhHw5UxZLqlBOxlUzdGm4emv09079rqK38D6Gz8wakXwviX70JhToeIxA/S?= =?us-ascii?Q?UjFChuXjBJ2lsZO5Uw+mEtAvptrcqOcIQ5Hh1rq/jQj1swQGPKZXQlKcL+f0?= =?us-ascii?Q?Gk9zsMUv4O3lW3anbHwp3kHECR4dc7yFkW53hq/xWSFiWISLqpZWF65bmkBy?= =?us-ascii?Q?X/m46/hB6ApkMLe9yG58Xrg06NbNT5TF+8KJvhnVkkdkirPA7XnSytJ70aIP?= =?us-ascii?Q?yfVZ16yFqE6JErjb77qTv4741zz/03U9XXQT6LSSfgNizDUlnrQr5Y14Rx3/?= =?us-ascii?Q?AY+GyBo5hH+FcH4IBDmsHWhJnc6IYeZNwBCCLCl7fxRCDoIgLb7oA64y1mZj?= =?us-ascii?Q?oNGlTy4+GPjjFyGTzzPuNrTqyDCQWOTZ1Byt29n0eUc1QUj5uAUTg/WmH3Df?= =?us-ascii?Q?dqSEByemmHUHend12+qfdoW4mGX01Pt8vZJ4uBHOhqgKjHD8thrLqMl3L/OZ?= =?us-ascii?Q?rXSYWtxfRAFcOuTXogcmms5P1ROB3vZ2rNp6hddMWbNaWnRvEsL1E1tjT8Fa?= =?us-ascii?Q?A8/Uj3go9YuU+YnBDTlX+4zTJdXsquid7mA3jybLyaNDbc0r7m+1/JN+jZrE?= =?us-ascii?Q?CCcLluE21BOwVy1TEDgzwqtmB/Zmw6uHNnqTVslAnVXrJ8LN6hzn68HAgMoo?= =?us-ascii?Q?U0NchcfGzwc4ni14ipWcQ0qe17d18PPsRfqouhaej5OhyvisuiI/OZOWvDEa?= =?us-ascii?Q?/PpHlIZE94QGMB8Dwkhf8evTrc/66ju/3jb/BP2zjEYy07PWLNbL1a9wSRZp?= =?us-ascii?Q?LCmlUl00+w=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: c22fc2fa-f94f-4665-010a-08dee7a3e0ec X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 03:46:57.4000 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XaSGUEimlMH9iCnIYAhemgR74XRyWNgNPxd4N/1YUWSSVcCUX1iSRv2yjcLh2VCzP83+Y1IAD3ZnICqn1x46wQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KUYPR06MB8988 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang --- drivers/tty/serial/serial_mctrl_gpio.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/se= rial_mctrl_gpio.c index 7b02c5ca4afd..dff13a9f2614 100644 --- a/drivers/tty/serial/serial_mctrl_gpio.c +++ b/drivers/tty/serial/serial_mctrl_gpio.c @@ -256,9 +256,6 @@ struct mctrl_gpios *mctrl_gpio_init(struct uart_port *p= ort, unsigned int idx) gpios); if (ret) { /* alternatively implement polling */ - dev_err(port->dev, - "failed to request irq for %s (idx=3D%d, err=3D%d)\n", - mctrl_gpios_desc[i].name, idx, ret); return ERR_PTR(ret); } } --=20 2.34.1 From nobody Sat Jul 25 00:03:09 2026 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11013046.outbound.protection.outlook.com [52.101.127.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB41D3E929C; Wed, 22 Jul 2026 03:47:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784692024; cv=fail; b=pQ4vktizP4TtvWGBDIVqrTuOVtuMXaNf1S/qHgIiF66EyUQhU08ijsFO/YNSOvZrUnTgT/hyxFosDgUMe79ZiRDr9CAorr3XMMX3PJDou3XW7/pcjELVbbuipDtjeYe7wjyWlqwLcvLi2eyB7V63o974w1zGlxBWrvb5XBjtVl8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784692024; c=relaxed/simple; bh=LqWE6OUVSdhcwYqvI5P4A0YfvWMysjsBn/7nIOA66fY=; h=From:To:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=R5c4YX8JCuYSDyT5+/FhB19ZDcLapfFEEzTYLLZuhzhACuFcg4GcrhfDFmKHuE/i7AIjufbT4XAc4SqGGW+Ur7BGh8caOvyWqQtx6KrE16TE4tJB25jcAwrxNJCFxvFlv47cDvqgY6g84BMJa/5wNnIte5yYDYd06BYm9y77SKY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com; spf=pass smtp.mailfrom=vivo.com; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b=GUUnwWYq; arc=fail smtp.client-ip=52.101.127.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=vivo.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=vivo.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=vivo.com header.i=@vivo.com header.b="GUUnwWYq" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=htKmq/HvbggPBeK7Q2zaFSoCsXPCVWituCtu/2WcbgZqyEqp1VWlOE/3c/6QVIffyvszEi0QF4PfGXKe2JPcbfP5idejDjzLubolnUBtkbK0+MWZXdBwX9qt6Kurh0v980rDALoAwGjSerotXAtYlewc2CiFzSPzYbS+5rPAf5bz2uLBxEDjh/yk+qNrBS+eqtBjaxDr2FRjcvrbQxjyfxAm5nybFIMEEn2lnSXFSNvgsTfmk+9iFztU9YLrFcDZN6fEkurx9xgTMFqqpPio6KlSWvMN2dQ/fI0Qy2l++Lj7mE0QeR3KGsd8mXT9UYlg+jf7dKCV/lIAkCVOzRLN/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+odOIMr8bqlxYLyjsaqZmink5+eFUshLJX/oB6CHpUA=; b=wridVZZasaAoaQwkjjkcrTA5NUqUVyaEGtG9Nj1rgve/6A5lMuaVSRBA0lU0U00wc5gTbPEQF8QsDKV4mEMtbpZaWKVnn7E9vLZqulsNBJzOM6MsjAHvTr3M0tH8Xjt/Wiguhl5UCvMAhMHnGkNqyqrbHM/45j0zXNhJT3FPqrrpLorwuBPIa04bAGbAsZWebgcMT8eCn7gExeUv5U7ES+nv0DJtaH4v/3LhT/oOKFHF51qpiRZ6gspop9KSheGlnZWETRPOelAW/6flY0aFVlvVc/t4jvn/d2SOka+f2aOVpReRpv2E+RfzNk1DO46ahvpEEOH6FVtD99Xki4wiEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+odOIMr8bqlxYLyjsaqZmink5+eFUshLJX/oB6CHpUA=; b=GUUnwWYqDQidqa+pWpeCXGGUme049u0cC1lcNRzy6YVXxpZ+3rnZJ7X3h1j8NiU0GdGET20TgMSj1S+AW40OtAZcoc9jo9j0dTAyE+2sgnpRW9B3hcq3DMyRl9u7IjegLATnhymMWdeQZngMrgCov1y55FrMh3CgnZQjKBzslfMktXqJ8loX0g5gQ83bMJm0Z+Orx1xUqNKwEW2PKEAwKxyMUBXz0f2SqnoRRwYxY1uF99YrlgGTveEJ8dqAoDw2TEe0Dddhh0fvHQboVcTouIAwmLIoharxcaTec8ZEOcroEQa7fqkGff8KS4M6eH+piMVvsWd/kwVR1uvL9om59g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by KUYPR06MB8988.apcprd06.prod.outlook.com (2603:1096:d10:99::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 03:47:01 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 03:47:01 +0000 From: Pan Chuang To: Greg Kroah-Hartman , Jiri Slaby , Orson Zhai , Baolin Wang , Chunyan Zhang , Pan Chuang , Cixi Geng , Wenhua Lin , linux-kernel@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS), linux-serial@vger.kernel.org (open list:TTY LAYER AND SERIAL DRIVERS) Subject: [PATCH 5/5] serial: sprd: Remove redundant dev_err() Date: Wed, 22 Jul 2026 11:43:33 +0800 Message-Id: <20260722034342.316755-6-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260722034342.316755-1-panchuang@vivo.com> References: <20260722034342.316755-1-panchuang@vivo.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCPR01CA0131.jpnprd01.prod.outlook.com (2603:1096:400:26d::19) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|KUYPR06MB8988:EE_ X-MS-Office365-Filtering-Correlation-Id: 0a0ff994-8f8f-4675-df8a-08dee7a3e354 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|366016|52116014|376014|921020|38350700014|11063799006|56012099006|10067099003|6133799003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: FHxVY2s1xTsGtRLWabXhf8ZIhMjkFjF6qct5nMc278zzTMH9UvIwhebhRVJaHab15oxIkQPAwnvGFyD6oh//u5F0lMNExVkjo36qgyef/LJRE2lmS9aqL/AasLGHTJzAmSj11EQDgRNTa7a7zlgjc+rIWpK/2RSQOkaSsc3S9CUSOtDvF+aKeoqpmHyz1NCf247GJ6C966AgXNlzbswOUHX4oUn7FvE7pwVfja8rDWoGuEXD17tdpqQgbggaTFhMJa0I2Dnlu5h54UhoDh8a0MqglGy8FHmrNj75F51hrKQoJsSllnYpwA+2dxOSnaIMvs2BWUSQtgW6uw8WMj7oo1kbpqZ/oZmXXfqTzNCVKRoQsk4smfCNNfwA/RJBogYD1SfY9+C7naHLEKIL+Rd6V/nwfBzuFoVdt5nfDdusd1W8+WzguUldDCWViIc6I/lBdIy9qqjml+jpWnrcF0LgXSmKb/dtiySDHW+5C8L9qy21etbFwU5BUCGSPXWWzgGQvtDTMZh3zDdDv2c4HMaAJpiCWGTT9tXvZoUN+ytRHnLDfM5JDHgvnQMLIOcT94juSjyB6lX/r/AdYRvCrO/PRx9Krep10oCLiZJomSurFzFV6Uj04kyDCqykEZ+fHEtKI1TkhiUrLgN5AAIH6g5Io1Ta2aOlhm15De2AVFPK2GpBf9YQXYGhxS0o3ogflxhE4WITemisoi98b/fW1NID0QnQJl+RPyOpM21sJJSM0WHehwjeEYjkd40mXmpYzduM X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(366016)(52116014)(376014)(921020)(38350700014)(11063799006)(56012099006)(10067099003)(6133799003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cU2IQRpe+2n+d0ljmlg6+IzBX4QKMbBPngVtEBWMsr/VnZQiVleX8XBSFiHn?= =?us-ascii?Q?UaFN4o88Vlz17feC86L0XFpfdG6EokVy8mF8lPaB64IZ5Ls9oQt4blaX+thU?= =?us-ascii?Q?Fe+gV4AJq1AnzMU9cOAkLI4tInqD6w734efGJ6Krre1kkQpyFPIJfzeTkAlG?= =?us-ascii?Q?Qd7Wgh9/3pQn5vD2LeUaejuxLBc34R0+Pugez2UCFPjmfBOxds84EZVacCax?= =?us-ascii?Q?ffEkH2s4u/I5wXK07wP3PjZdGFFKqhnAT59Wqhdn9NXd+vPzo+YlcbPH7xSX?= =?us-ascii?Q?rAEPos4Tm2poE/TV6SjcuMv1oOljJPb5G4USm0qr/x0nZQ2sf+PPuxMSeyZv?= =?us-ascii?Q?ULZzX1+bQ++m5by1rY5WIn2hnAdHjdwkAsvUJrUYiBZ7feWZKLRyFbv5wSSI?= =?us-ascii?Q?qJtRsxIKkzmCAuoSuN9rIfewHdx4wt25H6nvEfzfZPku/WipNrWNuO3jy0ib?= =?us-ascii?Q?BqyCtKP5MscictcTk/DMzRrt1gr8BLz3qvKl3IUXNsFyqPpnK8WyL2DQj0CE?= =?us-ascii?Q?aUmZalPloTtEhh705aVf8AmkZNoNN5MBz+Ybhlx72l5V58hnBuJZ6ax2zPx1?= =?us-ascii?Q?OKSbdvM9OX4rR+wCAYggUaOdGQQJgm3wil990coYQc9LMwh6mfHWAbtcitJp?= =?us-ascii?Q?Z4CDsmEDIUWw3Repm4W0Q6fS5rCK9L5FhcagmXwEvnm25HbX3WIz+kLksroj?= =?us-ascii?Q?hQXMVFXXDTA/xZDa2nGE9gZlazmk2qeMkvZ6HcDTsNZMtQfaWcq4hSAAewAs?= =?us-ascii?Q?qtciO9uofcYMeGi6j5IpDH5lfLD7mrF0vV4hSQ+VjyorU8vQyeDY/sK166bj?= =?us-ascii?Q?xajhtUpCDr0hORJtfZOuFv46Lr9+ibSk7g1IA/NJrNpmAjmToG//J+3DGv8A?= =?us-ascii?Q?HAcV5BztlVWgjkDI9INlNM6cYh3kukRZ7/g8iw0K6mCBGaVhFHueFn9uCAys?= =?us-ascii?Q?ZMaXJMrcRAy/k687ZJcFLzjN4sUVoipgBUWQXmc7SAygGHCacXj5Q5MuOd9f?= =?us-ascii?Q?5hBkO4RAFdeRDxoyzGk2whsBHMvLo4folxaoWsriTaxiNu4ZU2gkaiCqYgpa?= =?us-ascii?Q?JmOrudZCDA1+iF43CWGLSswgQG6e7FRBrVskhRMyLzVeakFP1HFrgmkdJrjE?= =?us-ascii?Q?zMlT+JV/NkLMqy6AAV0ex86QoI0XeuGcTPCcAMOvInZWVRVWA2O8pS7Y/dn5?= =?us-ascii?Q?j1dWqsXXBGNGEIDPwJi0iNtYVw2cbCgcu3Y9Wlgr3HvesJZaR12aIVx/s/74?= =?us-ascii?Q?lKCuJpJjyd/J/CBrKODVIDo6DdXvGGmUVhIIZDltS6gSnVnfpkBcDhUWYJO0?= =?us-ascii?Q?O2E+FAxki1idFgw5TILkNObeD3Zgr8r2FohBy7wM9WwEZoDdRsH2PY5gNtvB?= =?us-ascii?Q?QF4muby59VgGgo0tuU0f18koviPKbOjWy/bDzoksVhsgIgfqL0iajRhHW3yc?= =?us-ascii?Q?F5kG62teKdaNyi9+Vu8ZpT2QSjCMnH9G2/anymDpHD4wqBK3sAagMNvDGb3H?= =?us-ascii?Q?1kZoxBnomdpnXrtalnw5LOuLOia2GmV3G+DuzI3/ZPnlqcaig1d2PxtcZOEj?= =?us-ascii?Q?uXxjOWEFxz8AtDa+G10/zuyru6chJZi2Q6U+VvkFEUIWhZmFdFwWEVhly23d?= =?us-ascii?Q?JyB05MP4SB9eGEyxh7Q8Xw5YdR1wuX3043zLd7DGl/dvSF/PMr+77sD7WYWA?= =?us-ascii?Q?HSQfwR+Aut2vApedILYKTFjeRHBZfg6nyfMkCXYha3cL0hxTr/DYDyeSr4Ng?= =?us-ascii?Q?v3mNjHE2Dw=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a0ff994-8f8f-4675-df8a-08dee7a3e354 X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 03:47:01.4874 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ItnmrkV9WQZ80ZVv37e7Uq90t4COyrN7i81iPQOdj4babtg3E6aVsBL7bHyUY7tZbahWCMYezsQXk3Oo5NgwEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: KUYPR06MB8988 Content-Type: text/plain; charset="utf-8" Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() automatically logs detailed error messages on failure. Remove the now-redundant driver-specific dev_err() call. Signed-off-by: Pan Chuang --- drivers/tty/serial/sprd_serial.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_ser= ial.c index 092755f35683..3fdf5939a62c 100644 --- a/drivers/tty/serial/sprd_serial.c +++ b/drivers/tty/serial/sprd_serial.c @@ -741,11 +741,8 @@ static int sprd_startup(struct uart_port *port) =20 ret =3D devm_request_irq(port->dev, port->irq, sprd_handle_irq, IRQF_SHARED, sp->name, port); - if (ret) { - dev_err(port->dev, "fail to request serial irq %d, ret=3D%d\n", - port->irq, ret); + if (ret) return ret; - } fc =3D serial_in(port, SPRD_CTL1); fc |=3D RX_TOUT_THLD_DEF | RX_HFC_THLD_DEF; serial_out(port, SPRD_CTL1, fc); --=20 2.34.1