From nobody Sat Jul 25 00:02:22 2026 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC4EF3D669D for ; Wed, 22 Jul 2026 03:36:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784691402; cv=none; b=dK1I2uI0TCLH1c9ygq+1899kTvnh5GaqhGcJK+Csig2AhHsoHnh8/dwGTAtssD1sVXmm8H3keJps1+mpZj6Z8ABjpPK4zYHZ6Qrs9TfZ+XRcDDFas7OAIHCnxqTjtkTVgdVvNmIOcAtMc0SbaWhXlr/fKScZyoikgG+Bol7BXlE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784691402; c=relaxed/simple; bh=1TltuWnybZZt+k74AbIku8Gr6n8qILGVs4/kgPzm7Ow=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iBODAoiRNmIurFIvytCTZih72gZKFH7Yowh1YKjVHRCnSVxX5lMMmTiuS0lDzYUpnwAcBeyOsWeFqG6agmg4kN5+7uX+Kxdn1iyldwwhTM+kQSrXqntqEjdbPaTUqfJ55TEywHZYEJV84QUJ3dLrJtVv41x5l26tNGKQzV6sMGU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lcBRGIMN; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lcBRGIMN" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c9b373d5af0so9127564a12.2 for ; Tue, 21 Jul 2026 20:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784691400; x=1785296200; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=7NHyhDTZjnyF9Jy1uHqpnZ3KtVUroBokJdvpUJqEFWk=; b=lcBRGIMNPxfANXX1Xs3OSvTSapkcv77+mMRJyknb57Cs33NeRTjfWvdNjFxyTQ5+FQ pgVPx4epqhDG0Q9G2ekfGWhCa48e39fBPqVwM9TzllSHM6bht9f1yhXpWPgUMxJYpHpU kdBFeQLoLW76Gf2b4nTfKnVYg5BT1TubDJvQJLwtytMGh+LG0NLTpRK6nAdJTJlwhDdR nrWrKHMwTLRB2kv4mtuv3xdFwRtaev9f58PBf9QdVtEn8mN0R19gFvCo1RURTuF1DG5a PL3o31Xgkdb6hPrxq/F5gDEtotcEJdA9yiFZB9bipOPyBuwUWlU3xddd5u7o/hajicpY c7Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784691400; x=1785296200; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7NHyhDTZjnyF9Jy1uHqpnZ3KtVUroBokJdvpUJqEFWk=; b=Nbtnrh7PquqNdWV+lrT7/WhhTcg/VO2Ute4dhVuXjux2j4LfyJecDYEMybKLhd2Y/U 7w1Uumu2NzwJQNsMHZTnTkjJYjWjuI+NiJ6SDmxe/0u9ny6RINmkqIJjS+Nu9/YyvWdg LVi+2UuSxpVSKBnvTfb6jBUVHiPQFSg0uo1QGYDZY3rFgB0UVv5AkU0dY0a6Mom0NI10 uj3Qmili75fnzXesdSJanUJ3E5LeLZi5/fhKW05VkgCUZAHK9St9fO3Q1S33RQERhDt8 LDB9zKan2cVZXULGxJfR82gsbgJzhX41sR+GHq2f5pfH9L9xffs5aA0nRIOu0zC9mEP1 4Bzw== X-Forwarded-Encrypted: i=1; AHgh+Rox8+OFQmZohphB/y2bES1a14MNZfr/bPvmelpGp2Nt6rfIVIDHcDfcXWId9JELL0dZksm8RYjzzEgOs3s=@vger.kernel.org X-Gm-Message-State: AOJu0YyJTmwSqt/i73aXSqIyUq+AmIgK+lM6JbvPhFnhemFwQ9DFRBhc tFpOnKHqZtFl6j46GVb69SkUtQbenel59lHeBnhm9oSgtrBgqibbRdE= X-Gm-Gg: AR+sD11gorredcgZrgEPLxqZa763tHeHVpcSfZjs+ZIRRPa+K3ooZsiBGigUjVwbCJa GIXEoroTcd+/cT8LleWoe4QLLr9kypOXhyYho495aTHjYEgTHum/RVM9xMrUDB1KiroXBIbliCu rM8Y6Q4IYz1gEo++rHNte6hWxXEVoh755MyAm0RfoSEtslFXysu/jCA5iVxMMwyHqzr4hsXFu/k FSzUVoBtJBTDpFm0jkSHyO2OL5RRiSnrvTr8R8KXhCBoxLqRKtRNHLJVQu32i/l0ELRjY4wehG5 0y/ZqIoAMQ9UVseIjAmGprGlFeO557SMoADEt4RfJgJhX2DL2MZmNg4RItqYQ67aUEX9m4QeYvt NEj9tPvgGDSYO+RY+a4DhTjyq8VaMX13vMhxoBZQp7RtvnMdDTU2lgPDtXts5jpfacSYgYVBcjf n+1QgGVPLf9U6nX+U2a4+E4fOHguo= X-Received: by 2002:a05:6300:808c:b0:3c4:2cf9:28a1 with SMTP id adf61e73a8af0-3c42cf93a4fmr1420862637.46.1784691400038; Tue, 21 Jul 2026 20:36:40 -0700 (PDT) Received: from t-rex ([2401:4900:adaa:53ec:4dd9:f3bc:714a:d631]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13d13015052sm1561599c88.5.2026.07.21.20.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 20:36:39 -0700 (PDT) From: kr494167@gmail.com To: ioana.ciornei@nxp.com, vladimir.oltean@nxp.com, vkoul@kernel.org Cc: neil.armstrong@linaro.org, davem@davemloft.net, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, surendra Subject: [PATCH] phy: fsl-lynx-28g: propagate PCVT enable errors Date: Wed, 22 Jul 2026 09:06:19 +0530 Message-ID: <20260722033619.10647-1-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: surendra lynx_28g_set_mode() currently ignores failures from lynx_28g_lane_enable_pcvt(). It then updates the lane mode and reports success even though the protocol converter may remain disabled. Propagate the error and leave the previous lane mode intact so the caller can handle the failed reconfiguration. Fixes: 8f73b37cf3fb ("phy: add support for the Layerscape SerDes 28G") Signed-off-by: surendra --- drivers/phy/freescale/phy-fsl-lynx-28g.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/phy/freescale/phy-fsl-lynx-28g.c b/drivers/phy/freesca= le/phy-fsl-lynx-28g.c index 38afcd081a2a..1fe406adc83c 100644 --- a/drivers/phy/freescale/phy-fsl-lynx-28g.c +++ b/drivers/phy/freescale/phy-fsl-lynx-28g.c @@ -1003,7 +1003,9 @@ static int lynx_28g_set_mode(struct phy *phy, enum ph= y_mode mode, int submode) =20 lynx_28g_lane_change_proto_conf(lane, lane_mode); lynx_28g_lane_remap_pll(lane, lane_mode); - WARN_ON(lynx_28g_lane_enable_pcvt(lane, lane_mode)); + err =3D lynx_28g_lane_enable_pcvt(lane, lane_mode); + if (err) + goto out; =20 lane->mode =3D lane_mode; =20 --=20 2.55.0