From nobody Sat Jul 25 00:02:24 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010047.outbound.protection.outlook.com [52.101.56.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E36A386562; Wed, 22 Jul 2026 02:11:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.47 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784686278; cv=fail; b=bAbv0mud/ne5ECmgjkD7zwJOircULqHfbDn8s877l/H/Kmf4ByNMrEPVDc4wnCujZ2OYhkTimtqyO744UbCd6ITHl6kCRMMznLijtLs67Vy6AT2IgAMR4STNYcYOP2dOiOLj8UH9cJi6zKha4MtumRwkkMhEeJ8bN/HKQsSVNUw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784686278; c=relaxed/simple; bh=i29OkurGWsNYRNbJXNmL/sCpn7mrRAnG7Ax2dCKl+G8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ECy+o9QVk7PwZUwni1eLyTWGNcutGM8IOSePeh1tNHJDzf8nVR28NAuoRAABk5MYJrVSvG17BOIRF2BjZ9ihST3xVk4Nq9X0ovtpmPUlk0wnsm5yZ04apnppXoO/nF0dRTdvMyU6xMRb1cIUF2jtU/OnxRQLgqkCL3+9etrc5r0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=N8UHYn8h; arc=fail smtp.client-ip=52.101.56.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="N8UHYn8h" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ccxz64L+tqPrmlJ/WPNAiotWEBSJseOOZOWyGbAR/bnhFLTwIut7KJ7/43BizX5Z5M12YYhahQ2dv2IPQ/YyCz64DtZJfAlL6Iytz43hewC74y3QL3jL16BUgk5CMp0vAp69Dc+XTO/9gQZAjXMHIkLtpw6JcG2yN262Q0/cRPHZ+CyPYX4A85zVBoCnK1dCcB4BEgGEx5ZwVECTI3U6O/vouK0tIWDLSWs2b0lDLrpvehp+Ahj6VeZBm5HcXbvjFNMceat+x9zF5BxZc7lPscx/fQKHT8yKiJCQ1YiAIMdN4GCKx/OejD4nQgGnxNRpWd82ayYPgY9J6yXlPgJZtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2JhYm05UbULVkteQ5Ssl4FTIusgPNlwBXxldVT9SnqM=; b=QkVimGNwZnfFCZCphNBLfKPkFE6n3v7huZQMpFYHzqJnN6wTGwsTmMv/LbrrOwNk9SQBhOqu4sy6aXZskODkWA21kSmxKzyL3nSWOzhKt5/IfMO7V2eEup5fxS9LfU6w+swJfOLkATz1Id2KE7b1V0psQbXDEiTJPtNzZun+oDDjlA1QfemuJ+kzpHszHtOgpd/zsmiTFTTuxrBDIqfZey18InBGuE+AX5trWCO5hlVnzIJliDhrs2H7D3BCu6mJt8w/xwmE3f7voLU7N9u6DVLyKH9IaLRpx4JKMgEjqxG9PkvKQudycug5YecL7/lKYxkaVkAGcamraMzA5+XOlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2JhYm05UbULVkteQ5Ssl4FTIusgPNlwBXxldVT9SnqM=; b=N8UHYn8h8d+9PG3m9SKuX6LKQU/6+V7/t6Z7SNytWJAyV+ntV955S3KQVANF1CMA7tE+q+F1jPFSqWaooqCvSDBQlZc38bI55504FCBzWD6Pz7K5bANKypdcYHhevkaGP4NIL2I+1PF4f+G5KT2ANd5fKT3kpfqkW/xqF7IAZTuIp4p0hx4vTt7IsYqvjsLKCobsTOUxsWRlpiNDmxpx7rVGx442JrjhT2BVASKS4y8o9YsYkU9EONXTRSgtuFwAVZ1ir2xa968+96fCBSs4wnH5C4vSBGWHZQAZCrgRlOt/5gKN6vSAz9MgTf+hR2rp+R7R692vFKXh8oVeeD43Nw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2370.namprd12.prod.outlook.com (2603:10b6:207:47::27) by SA0PR12MB7002.namprd12.prod.outlook.com (2603:10b6:806:2c0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 02:11:12 +0000 Received: from BL0PR12MB2370.namprd12.prod.outlook.com ([fe80::86cf:c3ec:2cf5:74c8]) by BL0PR12MB2370.namprd12.prod.outlook.com ([fe80::86cf:c3ec:2cf5:74c8%5]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 02:11:12 +0000 From: Richard Cheng To: tony.luck@intel.com, reinette.chatre@intel.com, x86@kernel.org Cc: Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, newtonl@nvidia.com, kristinc@nvidia.com, kobak@nvidia.com, kaihengf@nvidia.com, fenghuay@nvidia.com, ltrager@nvidia.com, Richard Cheng Subject: [PATCH 1/4] selftests/resctrl: Add MBA schemata info selftest Date: Wed, 22 Jul 2026 10:10:54 +0800 Message-ID: <20260722021057.9370-2-icheng@nvidia.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260722021057.9370-1-icheng@nvidia.com> References: <20260722021057.9370-1-icheng@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TP0P295CA0053.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:3::8) To BL0PR12MB2370.namprd12.prod.outlook.com (2603:10b6:207:47::27) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2370:EE_|SA0PR12MB7002:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e8f31ac-56b7-4c9f-7b04-08dee7968066 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|6133799003|56012099006|11063799006|10067099003|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: 7ehfvtodw0TA1Us6rTlN1SapxNSG6BYDwfIU+MWq8dQswKGuvFxAkiiSX+LBU0L54QK6KXUQF3pbpZLJg8mUi0q2Lmt8Pxjop+YS+3epeazDr9cZaY/RU3qyoHH5fDMeyuaC20wF9ZCzbskCErnxk1y7R027rh8ihjvVkGLsVlIOrQJ1V8XVS/7E2wRpDNT+lJDfsd3Q2CG4d77Ksz81fgG/jihebNPt2HJr2fg/+vLf6p8AqWYdw7XOYr3AdTk/Cx0jqP8+zUW7PJU9fYDHkeVuTrbsrpK/vSi+IKWynYaiwN8TWZ2QJvzi8XInoo/NfDGi8jSX4fPayld2+kZCEiDfZ8/EzFHceGMOm7Uy3LEbCEI5rO87e9Qau0bDsl6c0NN80hfflDxhH1rjV9ycMjMtQtcxXs40RZ81HyP2HuoYwlDcXrvaQrK3VD7ZJXIJPhHNXRUrso85nuWdHfelmflFcEnkDN5JpdzbuUgTQRaAQEv+wy5PyIq3Y8VXChe0calb2GeYZrOO49fE4muOdoawPM5Y+dKHUtyrMPTsy92Phn410hKpqcarywCb0R+s88qUnW2x05nSbSALuncuBERQxEYa0vzXGisT4D2bcpqOiry0ZZI+Yt/IcovzOO9AKm0EN05Wy5803PmcB5er/DnepfzEMh5Gc+2IcqUpr4c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2370.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(6133799003)(56012099006)(11063799006)(10067099003)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GPTZRQdNfWboLVC73mtlh5VNfmvNCsePovbeQxk8W/gWDepZdcszR+dcLFNo?= =?us-ascii?Q?a0CKbL9GLTHL89UrKoXSljbVfvc9x72s0+X77ReW+k2b1pvFPvpiwqs8+7d7?= =?us-ascii?Q?pRAOEoV3twh+thTCV5W1fDIQT0kE/CkEwpcHeS6klchWN8OmIWxmT1iMkr90?= =?us-ascii?Q?mpLEUYl3bcSCQCosW5AuVQulnBlnN0px618OvCtoANwjzFtBXvcsE1MPQXm1?= =?us-ascii?Q?N3r0BWzETMEu8mKvMHbJNyIcMDleVyhryNHU2G1zai/vFjFVRqtkkWY5oWj7?= =?us-ascii?Q?JIoVPZqEB4pzV1nZFLk54lZ+F/aH09wqco16ZfrU8QBXipScTG1D7I1Ksypn?= =?us-ascii?Q?jxZ10jY6vp2b7Abk3QNHJjsuSJfXk9zuVqup4O+YR5cngsYHIYpg7ykY41Yb?= =?us-ascii?Q?gUslUlZK5OSFZZs45u24ICoHgin1UusqelGI9TxrSiR4MmUl5c1N55WsQepT?= =?us-ascii?Q?7EsFKnvetldBs2NA2om6BRGiVZDggO1NGiOv+QSSXzM3c+9NsHDXLmoSOV09?= =?us-ascii?Q?JRZwVvLDYxHZIeIa2czU2aVqEUhQ0liau0Q/hbjq+Uthts6B15otTZW4lX9l?= =?us-ascii?Q?YVq7TXWwo5hWoBof8j4H6BbcZunWg45ZlQA6mptxAbfuXluj/kH28qkDwQ+Z?= =?us-ascii?Q?EO9JTHWif2vCYDSr8Nq7//1ivko9zbij6tEzIHta9MIQTVvHg5F5RuTUfq/l?= =?us-ascii?Q?L6Fr0uemf+gR+cNXnxJ9frcVAHE4RRbObH8KHw0IfCGfIKZplhCByC/RoDXh?= =?us-ascii?Q?T+qqNXvlc8Jth7qg+ELTZJTFnKNQxxA2i37AEg9a3OeugJB5u7ds0mSXdA1q?= =?us-ascii?Q?+QvZxO87u5FablkXgNzJ24KRfO+mrKQZslMOZCoH5v+lCOlszQQUoJxzEfLl?= =?us-ascii?Q?qPlN9amLIMrXPkr9EzvPsKdDg9WiE9FcVy+XoyNgASj4yHjgQY3L0V96OhNM?= =?us-ascii?Q?nuW9IVeAlKRJJB6SSkzKwCqTb1tfHL/Vp4NrsMCzzi1IeULeQUHF48HIxUvt?= =?us-ascii?Q?y8BRbPTifleTXgg1dpwa1eSIeaJ2tPgWiDqoVYGZ4H0xcFLibyyqfvW5xmSd?= =?us-ascii?Q?IbnFGk6+uUzLUjVIViABvTh+ZAJkG942tkloQRYHtUZmG/g3GQMz1n3DjeVr?= =?us-ascii?Q?AC157LCOVnaJNzpENxcViw/8TS+JRjIxyaCAsKRiDA/16TFwLh3JQkkyl+UH?= =?us-ascii?Q?EqTJwDBt4uZoF+5r9hVPITtnTC2vdULW94CMnqjB0AvbyGkTI+a6CnSEN6ZO?= =?us-ascii?Q?Zyc01/7Fk41VC3FocG2mLx1ie16i6P0gpno44r3xyyYwDoYLK7kG4NsSZ/IS?= =?us-ascii?Q?oOcDIHmPXAFQ5mQFbtmq50x3i2mxN+sAPCuyL2vS49XQIXRYs4nz2Jz6l4pz?= =?us-ascii?Q?qlkQuqZ2aue04xDH/ZlQ+fg60qcq9PFprSlNGwqFL9maMqbBkPFyY2ftZfFe?= =?us-ascii?Q?5dsGmmLAVEW2ye00yF8P8RdKY2j/qboEcTOwuQD8rMv9vGx+fhUBHE6Cw4Yv?= =?us-ascii?Q?LqibK51dNTNlEgYHG7Nbg/FbWoGfUkJ2vDfj/BLaWtJL6+eHzXLtR2Ek3w+E?= =?us-ascii?Q?KKAgrJtgNuKgIadwI0QxX5z1KBnCbfAw3wmaJ3sRQ4/ZFAh97cuZtEJmu2AK?= =?us-ascii?Q?bd3PioWhgbyDjcLMBsRhGnnIAHNV8dgzXPS/Tzdax/gYiu/SQO/wq6bvI0Vx?= =?us-ascii?Q?9EKzRpxj952XbXuAysQK8C5wZy/BmNxWZ2uEBv9FM5znLFYe7vd2uwoZsozw?= =?us-ascii?Q?uh/YRnXZ7w=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e8f31ac-56b7-4c9f-7b04-08dee7968066 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2370.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 02:11:12.0587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bVtd5ro8tGY5HmJ0g8B1ISaQxzEUfg8XTVp0dXjXI90LKHVNP20SuQg27+Tcpj5mk1soLjQYPO93T8lqgVsbdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7002 Content-Type: text/plain; charset="utf-8" The existing MBA test is Intel-only: it validates the MB monitor against the iMC PMU, which doesn't exist on ARM MPAM, so the MB allocation control interface goes untested there. Add a feature-gated MBA_SCHEMATA group. Its first case, MBA_SCHEMATA_INFO, reads info/MB including bandwidth_gran, min_bandwidth, num_closids and the default schemata through the resctrl filesystem and every domain resets to the maximum. resource_info_str_get() and resctrl_get_schemata() helpers are implemented to assist the test. Signed-off-by: Richard Cheng --- .../selftests/resctrl/mba_schemata_test.c | 152 ++++++++++++++++++ tools/testing/selftests/resctrl/resctrl.h | 3 + .../testing/selftests/resctrl/resctrl_tests.c | 1 + tools/testing/selftests/resctrl/resctrlfs.c | 121 ++++++++++++++ 4 files changed, 277 insertions(+) create mode 100644 tools/testing/selftests/resctrl/mba_schemata_test.c diff --git a/tools/testing/selftests/resctrl/mba_schemata_test.c b/tools/te= sting/selftests/resctrl/mba_schemata_test.c new file mode 100644 index 000000000000..b92011e42726 --- /dev/null +++ b/tools/testing/selftests/resctrl/mba_schemata_test.c @@ -0,0 +1,152 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Memory Bandwidth Allocation (MB) schemata / control-interface tests. + * + * These are deterministic, userspace-driven ABI integration tests for the + * resctrl "MB" control plane as exposed by ARM MPAM. + * + * Each test case is a separate struct resctrl_test sharing the "MBA_SCHEM= ATA" group. + */ +#include "resctrl.h" + +#define MB_MAX_DOMAINS 64 + +/* + * Worst-case length of an MB schemata value string ("=3D;" per d= omain), + * sized for MB_MAX_DOMAINS so a full line is never silently truncated. If= a + * platform exceeds this, resctrl_get_schemata() returns -ENOBUFS (we fail= , not + * silently verify a prefix). + */ +#define MB_SCHEMATA_LEN (MB_MAX_DOMAINS * 16) +#define MB_PERCENT_MAX 100 + +/* + * parse_mb_schemata - Parse a percentage MB schemata value string. + * @vals: "id=3Dpct;id=3Dpct;..." (modified in place by strtok_r) + * @ids: output array of domain ids + * @pct: output array of percentages + * @max: capacity of @ids / @pct + * + * Return: number of domains parsed, or -1 on overflow / parse error. + */ +static int parse_mb_schemata(char *vals, int ids[], unsigned int pct[], in= t max) +{ + char *save =3D NULL, *tok; + int n =3D 0; + + for (tok =3D strtok_r(vals, ";", &save); tok; + tok =3D strtok_r(NULL, ";", &save)) { + int id, consumed =3D 0; + unsigned int p; + + if (n >=3D max) + return -1; + /* + * Strictly validate the whole token as "=3D": %n records + * how far sscanf advanced, so a non-NUL byte there means trailing + * garbage (e.g. "0=3D100junk"). Domain ids are non-negative. + */ + if (sscanf(tok, "%d=3D%u%n", &id, &p, &consumed) !=3D 2 || + tok[consumed] !=3D '\0' || id < 0) + return -1; + ids[n] =3D id; + pct[n] =3D p; + n++; + } + + return n; +} + +/* + * the MB resource advertises a sane, self-consistent + * control contract and the default group resets to the maximum on every d= omain. + */ +static int mba_schemata_info_run_test(const struct resctrl_test *test, + const struct user_params *uparams) +{ + unsigned int gran, min_bw, num_closids, pct[MB_MAX_DOMAINS]; + int ids[MB_MAX_DOMAINS], n, i, ret, fail =3D 0; + char vals[MB_SCHEMATA_LEN]; + + /* bandwidth_gran must be in [1,100]. */ + if (resource_info_unsigned_get(test->resource, "bandwidth_gran", &gran)) + return 1; + if (gran < 1 || gran > MB_PERCENT_MAX) { + ksft_print_msg("Fail: %s bandwidth_gran=3D%u out of [1,100]\n", + test->resource, gran); + fail =3D 1; + } + + /* min_bandwidth must be in [0,100]. */ + if (resource_info_unsigned_get(test->resource, "min_bandwidth", &min_bw)) + return 1; + if (min_bw > MB_PERCENT_MAX) { + ksft_print_msg("Fail: %s min_bandwidth=3D%u > 100\n", + test->resource, min_bw); + fail =3D 1; + } + + /* num_closids must allow at least the default group plus one. */ + if (resource_info_unsigned_get(test->resource, "num_closids", &num_closid= s)) + return 1; + if (num_closids < 2) { + ksft_print_msg("Fail: %s num_closids=3D%u < 2\n", + test->resource, num_closids); + fail =3D 1; + } + + /* + * Default group: the schemata must carry an MB line with one entry per + * domain, and every domain must reset to the percentage maximum (100). + */ + ret =3D resctrl_get_schemata("", test->resource, vals, sizeof(vals)); + if (ret) { + ksft_print_msg("Fail: could not read %s schemata line (ret=3D%d%s)\n", + test->resource, ret, + ret =3D=3D -ENOBUFS ? " - line truncated, buffer too small" : ""= ); + return 1; + } + n =3D parse_mb_schemata(vals, ids, pct, MB_MAX_DOMAINS); + if (n < 1) { + ksft_print_msg("Fail: could not parse %s schemata \"%s\"\n", + test->resource, vals); + return 1; + } + ksft_print_msg("%s default schemata has %d domain(s)\n", test->resource, = n); + for (i =3D 0; i < n; i++) { + if (pct[i] !=3D MB_PERCENT_MAX) { + ksft_print_msg("Fail: %s domain %d default=3D%u, expected %d (max)\n", + test->resource, ids[i], pct[i], MB_PERCENT_MAX); + fail =3D 1; + } + } + if (!fail) + ksft_print_msg("Pass: all %d %s domain(s) default to %d%%\n", + n, test->resource, MB_PERCENT_MAX); + + return fail; +} + +/* + * MBA_SCHEMATA group feature check: the MB resource exists and uses the p= ercentage + * schema. Non-percentage MB (e.g. x86 mba_MBps) and platforms without MB = skip. + */ +static bool mba_schemata_feature_check(const struct resctrl_test *test) +{ + char fmt[64]; + + if (!resctrl_resource_exists(test->resource)) + return false; + if (resource_info_str_get(test->resource, "schema_format", fmt, sizeof(fm= t))) + return false; + + return !strcmp(fmt, "percentage"); +} + +struct resctrl_test mba_schemata_info_test =3D { + .name =3D "MBA_SCHEMATA_INFO", + .group =3D "MBA_SCHEMATA", + .resource =3D "MB", + .feature_check =3D mba_schemata_feature_check, + .run_test =3D mba_schemata_info_run_test, +}; diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/self= tests/resctrl/resctrl.h index afe635b6e48d..a6ad25a08ae5 100644 --- a/tools/testing/selftests/resctrl/resctrl.h +++ b/tools/testing/selftests/resctrl/resctrl.h @@ -201,6 +201,8 @@ int get_full_cbm(const char *cache_type, unsigned long = *mask); int get_mask_no_shareable(const char *cache_type, unsigned long *mask); int get_cache_size(int cpu_no, const char *cache_type, unsigned long *cach= e_size); int resource_info_unsigned_get(const char *resource, const char *filename,= unsigned int *val); +int resource_info_str_get(const char *resource, const char *filename, char= *val, size_t len); +int resctrl_get_schemata(const char *ctrlgrp, const char *resource, char *= buf, size_t len); void ctrlc_handler(int signum, siginfo_t *info, void *ptr); int signal_handler_register(const struct resctrl_test *test); void signal_handler_unregister(void); @@ -246,5 +248,6 @@ extern struct resctrl_test cmt_test; extern struct resctrl_test l3_cat_test; extern struct resctrl_test l3_noncont_cat_test; extern struct resctrl_test l2_noncont_cat_test; +extern struct resctrl_test mba_schemata_info_test; =20 #endif /* RESCTRL_H */ diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testin= g/selftests/resctrl/resctrl_tests.c index dbcd5eea9fbc..5d45ac95d988 100644 --- a/tools/testing/selftests/resctrl/resctrl_tests.c +++ b/tools/testing/selftests/resctrl/resctrl_tests.c @@ -21,6 +21,7 @@ static struct resctrl_test *resctrl_tests[] =3D { &l3_cat_test, &l3_noncont_cat_test, &l2_noncont_cat_test, + &mba_schemata_info_test, }; =20 static unsigned int detect_vendor(void) diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/se= lftests/resctrl/resctrlfs.c index b9c1bfb6cc02..8b428a22496d 100644 --- a/tools/testing/selftests/resctrl/resctrlfs.c +++ b/tools/testing/selftests/resctrl/resctrlfs.c @@ -400,6 +400,127 @@ int resource_info_unsigned_get(const char *resource, = const char *filename, return 0; } =20 +/* + * resource_info_str_get - Read a string from + * /sys/fs/resctrl/info/@resource/@filename + * @resource: Resource name that matches directory name in + * /sys/fs/resctrl/info + * @filename: File in /sys/fs/resctrl/info/@resource + * @val: Buffer that receives the first line on success + * @len: Size of @val + * + * Reads the first line of the file, stripping a trailing newline. + * + * Return: =3D 0 on success, < 0 on failure. + */ +int resource_info_str_get(const char *resource, const char *filename, + char *val, size_t len) +{ + char file_path[PATH_MAX]; + char *end; + FILE *fp; + + snprintf(file_path, sizeof(file_path), "%s/%s/%s", INFO_PATH, resource, + filename); + + fp =3D fopen(file_path, "r"); + if (!fp) { + ksft_print_msg("Error opening %s: %m\n", file_path); + return -1; + } + + if (!fgets(val, len, fp)) { + ksft_print_msg("Could not get contents of %s: %m\n", file_path); + fclose(fp); + return -1; + } + + fclose(fp); + + end =3D strchr(val, '\n'); + if (end) + *end =3D '\0'; + + return 0; +} + +/* + * resctrl_get_schemata - Read the value portion of a resource's schemata = line + * @ctrlgrp: Control group name, or "" / NULL for the default group + * @resource: Schema name (e.g. "MB", "L3") + * @buf: Receives the text after ":" on success + * @len: Size of @buf + * + * The schemata file holds one line per schema, e.g. " MB:0=3D100;1=3D1= 00". + * On success @buf holds the value part, e.g. "0=3D100;1=3D100". + * + * Return: =3D 0 on success, < 0 on failure (including the line not being = found). + */ +int resctrl_get_schemata(const char *ctrlgrp, const char *resource, + char *buf, size_t len) +{ + char schema_path[PATH_MAX]; + char line[4096]; + size_t rlen; + FILE *fp; + int ret =3D -ENOENT; + + if (ctrlgrp && *ctrlgrp) + snprintf(schema_path, sizeof(schema_path), "%s/%s/schemata", + RESCTRL_PATH, ctrlgrp); + else + snprintf(schema_path, sizeof(schema_path), "%s/schemata", + RESCTRL_PATH); + + fp =3D fopen(schema_path, "r"); + if (!fp) { + ksft_print_msg("Error opening %s: %m\n", schema_path); + return -1; + } + + rlen =3D strlen(resource); + while (fgets(line, sizeof(line), fp)) { + size_t linelen =3D strlen(line); + char *p =3D line; + char *nl; + int w; + + while (*p =3D=3D ' ' || *p =3D=3D '\t') + p++; + /* Match ":" exactly so "MB" !=3D "MB_HLIM"/"MB_MON". */ + if (strncmp(p, resource, rlen) || p[rlen] !=3D ':') + continue; + + /* + * fgets filled the whole buffer without reaching a newline: the + * schemata line is longer than @line and was truncated, so we + * would only see a prefix of this resource's domains. Fail + * loudly rather than silently verifying part of the line. + */ + if (linelen =3D=3D sizeof(line) - 1 && line[linelen - 1] !=3D '\n') { + ret =3D -ENOBUFS; + break; + } + + p +=3D rlen + 1; + nl =3D strchr(p, '\n'); + if (nl) + *nl =3D '\0'; + /* Likewise refuse to return a truncated value into @buf. */ + w =3D snprintf(buf, len, "%s", p); + if (w < 0 || (size_t)w >=3D len) { + ret =3D -ENOBUFS; + break; + } + ret =3D 0; + break; + } + + fclose(fp); + + return ret; +} + /* * create_bit_mask- Create bit mask from start, len pair * @start: LSB of the mask --=20 2.43.0 From nobody Sat Jul 25 00:02:24 2026 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010046.outbound.protection.outlook.com [52.101.85.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 473CB3803DF; Wed, 22 Jul 2026 02:11:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.46 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784686284; cv=fail; b=i/P3tdxn+1YUrexoorwAPgiZ+MtzY0/RSzy0iZq1YjYjBklg+WWFwPEzdMPNS/mPhs+u654xqN+FRJ1JMKUaPB7ySALQMVo5R2Ki5zCEHdv8Sw5LIaqNNIY0MNx+gGHexTXan1fX6Fe53BvXafagOMu4pVAixG0XCOvV7ct8dgs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784686284; c=relaxed/simple; bh=PVmjkhDy7t/mP0CBxEJIpc0vOONwSiXjTqFUv0LswhQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=bJfVl50HsmmHupViPqYLc+IL5cmaL4E04cRK/JFM1VRG+3jm8yA28trBakhD0DgoER6Vvak8+Yz9lSbgEi1HCgr2x3GIuEMXLlYNDxR0orFq+YOg3FG8fIipmU/+IgeBkVfcqlKVM/XfVra4BSbNVRRoTxbHFuSE/0KmUUCLXD8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=NvvYx6fK; arc=fail smtp.client-ip=52.101.85.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="NvvYx6fK" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=H5JAatd1/ixCRDd39Pw3JjSX3BJJtzN1WR5CtDHQujsy2u4k7bEmbFjnH7SkuTGMRm+/6EkZdDZSYLE93nV+Mt+L/MLbDFZ311iKJkQDqRLdgXD0DAPRvlrhy4H6MUimdb37yNadmTuO3ue3bBURw5aVmQPsjIFOxqjzYy7dZ/trVgJigMSFpWGO/rFNl2gJbi/vUNl7PjDSG3739AeKMDNqjKOt/+Nrd++yv8eG8Kiv1IF+ycesFrItM04k2RlKr9W2/io45iEFBEK+2Dhn2PfGqF3d6Yu07m7V0GHMQ9nnN5u63HfRYa5BNnoGpsjiyYsQEKeSEO73O3yrfXleSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t+C6R7OjklUGbR/MA/vk4YgAEs2qYDJg2gLSaLDgqko=; b=q3FVcff5ihrk5vV3uj941gqWJjmkICahq/sdTBKuv2CHL0WPJtbg32CADpVTHQfTNuS2AphgHoOmTi3YXs44GupIb2yyWWyLmIEk3Lh0pxtxErQcwKzHCSsRWE65h+UAN5+bz3Ip3v5YWgVtDEKHFwMdbZkBrOVplODFfTYGLgD042LCC821Cx+j7YjgoDDq91s9UiTusEW2VNf6xgdOtZmsEknxXjqrY4XuE0CdKAtAPLRCrlZ+NV7Tlu8p2ygsZvIlJB17FCXSCK7pyOikzK6JIlGVHlGhfvH4STMfhBBpL0GpsMiiUEQpOM8dl0Fot5e4vBABVfL2Zxafhx2dSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t+C6R7OjklUGbR/MA/vk4YgAEs2qYDJg2gLSaLDgqko=; b=NvvYx6fKh003bWWrrf7iznZFkp/cHICQpRg1azBdr9EX/eqggGYt8Xwv7hlUMHdIfnsqfuOl6TWiWFl8G9rmceuQm1zrVw0StrPya/juUuCSdKLSSpN2T/zdq/qXtxUPZjFWSvPCPDGnC6AsRran+IK5oPIObdhiAqJBgz/h6dsH5maF3r8O/bABH+czckfAFDE8vqURJ/QhDMKAeH1zArye5a87dc7iOEeqMG/FAs+fe6r1oDt7QU5UvKZuHWqAR0PwUR5c3RiyFF4VDC0k0nTX20y4OduxpXHmgef/n2DJyhXAlH2hPEhlOE1BmzaWGOpdTsj3/RgbuBKE42aKQw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2370.namprd12.prod.outlook.com (2603:10b6:207:47::27) by SA0PR12MB7002.namprd12.prod.outlook.com (2603:10b6:806:2c0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 02:11:20 +0000 Received: from BL0PR12MB2370.namprd12.prod.outlook.com ([fe80::86cf:c3ec:2cf5:74c8]) by BL0PR12MB2370.namprd12.prod.outlook.com ([fe80::86cf:c3ec:2cf5:74c8%5]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 02:11:20 +0000 From: Richard Cheng To: tony.luck@intel.com, reinette.chatre@intel.com, x86@kernel.org Cc: Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, newtonl@nvidia.com, kristinc@nvidia.com, kobak@nvidia.com, kaihengf@nvidia.com, fenghuay@nvidia.com, ltrager@nvidia.com, Richard Cheng Subject: [PATCH 2/4] selftests/resctrl: Add MBA schemata write/read-back selftest Date: Wed, 22 Jul 2026 10:10:55 +0800 Message-ID: <20260722021057.9370-3-icheng@nvidia.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260722021057.9370-1-icheng@nvidia.com> References: <20260722021057.9370-1-icheng@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TP0P295CA0052.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:3::14) To BL0PR12MB2370.namprd12.prod.outlook.com (2603:10b6:207:47::27) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2370:EE_|SA0PR12MB7002:EE_ X-MS-Office365-Filtering-Correlation-Id: 35b623c5-6ee4-43e4-f4d9-08dee7968508 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|6133799003|56012099006|11063799006|10067099003|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: q2NwPZcgsCFLUOb6o6dUABT8SIc2eREG8Hr7VwAlL7qoLXgaopOfWZOuufLqGXISMWSG05fVt0pOLUEviY9ZLK3VsMjfzci3SC/d9aw2f9VFEArxaH4PiF1lAKncSg31mE8iwMTgnpA/pmLOx6iGFkJ3xyM7bPLBikx28w/w3tcv2QiEFcHxHr4FzfTx92zLk74JZz4b9Lk3UkYTHw6+MHEquWuSnwZvGattOtXn6mMzliUlw9hsqBXSvHbr1va7OT6I3r3rnSu7GwFS2xdK25TQKew0cLq11cZmtDlLBPRApg2X+BqWKhtlo5c6OELcM8bmbEXfAlQb1060lRtpjZxJyr3UUqWvopPiaABrJJWtNX59Lr8PD0fBhloV/RI05B8Kd0MLifpV9gb2CugsJFsYPvOrVt+5zY88nW27BcOR/OWPMcbd6zAkm4qRoHKuHNvl9n1TnnMQM0cYUYXFEX/j6iQDtS+mNfX6NT+pBu68WzqOtXeT3w/xN74qDqeaiA8M6g39gKf+O9/hi+MSUt8VvhvVepulCmpjjYzqS3tUlljhoi3n9tbE6ckEpNsEPIJiPp+IJMJC9KaG7Egvo1uDb22wKz8QMqo0GX/7jxPRiu47mPg2OJZEVQuBVSNjHzsyBA84pks9eYsfc2Qb452MvE6/Pfu7FZyIaW+SU2o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2370.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(6133799003)(56012099006)(11063799006)(10067099003)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VS5C1HC3EQ3+EfbwCZ0tEhrRZqsM1e9VR/tI+XZV2/iR3K9/zW/WxTu773X4?= =?us-ascii?Q?mfeZsOAG6lRETGaXc/OPhAl4D54IldJ2D43NnjUssBPUX2xZE37bwfR/BzOv?= =?us-ascii?Q?xEghwAeQbJdttybyzG3jSXJX12cZYI8WFjS4x0G7uZhu0Q7k5qEO3WXFueth?= =?us-ascii?Q?hBcFB3sHbzxbvvPmdaXSiam80ZR3L4odpgHcaHNx+mcU1IqChg4Sok6sTGiT?= =?us-ascii?Q?CQbHAyGjvRBuq+goFpQaM80ErU2yanUrRcGtLrLfRPRyZF46WsfQa2AgfIIS?= =?us-ascii?Q?oDbpo1MlyCgTgBu//sNrtiLlsXGVclmQxai7i6NWd1v4SnLlS36opiMPBftZ?= =?us-ascii?Q?2EoWMhU1jaThG99UV7nIjjnucOSkYHyLAwKNkBEI2t+Qsi9PLS4l7lH6YZMA?= =?us-ascii?Q?fUevd1FAS+krPFd1bEZcAbe9FiuNfSTXGfRQ3373e0UiNBIbSdN4u5Eohgdl?= =?us-ascii?Q?K+0wOcN697aS+MW/9Dy685JS/A59hO04f+srbohGzkZaLzM+Y46kbg5UIR9y?= =?us-ascii?Q?vzc0tzaq2jY07wicFhvQpG0R162k3YtBEhvgz43qy1UoWvTzKjyRDxZEm8Kx?= =?us-ascii?Q?BJI02NElfcADarriofFFM1l9rh3y7XH52oMfHoakn4PDXwrlMcAE9obM1a4Y?= =?us-ascii?Q?MjobztOJEvtDUrITm22jaoNlniwHXdc6mCqVyCq085y0V9YbCh8t8nJFHtyC?= =?us-ascii?Q?POf85Gdf7nCbDUiItfnS1cP3EbP1W/bagycjQWW2vi5spA9K3XYuEkebzqul?= =?us-ascii?Q?w8zTSrlp2g24QlFvoLnI/7NpZK7cWPr6MynPmMNZhbzRve1AvT+DsMDqOCwS?= =?us-ascii?Q?o5u2sFbyUAmWGDvmPG/ypNsXxwPv7dTOfAzn2FhxsVGk3shwXwDTwve7y++Y?= =?us-ascii?Q?clIfajalaV7IAbNO2J/NSHillr5n2Rq08mKYYUl5NxS1aBphYXBD7pR2y4fL?= =?us-ascii?Q?IuQPZvdKDTawfgtLvSJsYO6WwzAR+8Sla4oxJdpQuMKP2TRzU9L+tcbJ9boc?= =?us-ascii?Q?V5rhQmR7ygnAmshMPUUORahCRgBO/xFTea/omSEv0iEwQADx58M/zPbjTbIs?= =?us-ascii?Q?JSVhLnroT9phXxUCouZSXH2EU/IT/QbCJZuBG+rKBP3OnAsndwSMA/FSwZA7?= =?us-ascii?Q?WNrIz51te6grBaFKYeLCZxeWELCoCXj7zP5S73OwvbOiWn6kDi56lXPudrNp?= =?us-ascii?Q?QxbC00g1OZZOi8BMUxkfDg3CcbKhCK3lW6QBk+sm1SRA3I6Y84F/j8zIOsuL?= =?us-ascii?Q?1JXKGsLqQbsI50WM9OkRk4V6VgayZ2XkZG4U86ddItVrkCmpHGvtA11w917E?= =?us-ascii?Q?ASWsgpaKIPnZV2wzet4/I/j/nE4Cmoge6m0CGaGnFhUkhB/OQ1bB2bhoy1xp?= =?us-ascii?Q?ofwUecVvjJ8nbNgrKjNeObNuWBgjsPImyUGXbLfq9xXl9nam9G8naA8uWaAJ?= =?us-ascii?Q?hZOo8uqrnpxn7o89d1LWU+ZhalMOH1zr1dDucfkcToUbit9w8ofxTQvgaVSy?= =?us-ascii?Q?gcyZfSMCzJDutquEoUNF3CV54GYi8qjFfx6o8rDiySZaPB8GSFhVxTEBG8a/?= =?us-ascii?Q?vtD7h1S0Zf2qQkSVPYzHLwshYIGZV23dBkc5khvW/qbnSVnoAd+hdyCH+Us5?= =?us-ascii?Q?plQGnxFI/ZW96CCjJOPPfavwV2pXGNVNIiMvNUofIPSt2gB3oy1+amKbyHI0?= =?us-ascii?Q?Qf8CDTk5MC9/NPArfP1S/ql/l4zXUVQgTrjWM21tUc4+1FAIRlvbTISM2l7G?= =?us-ascii?Q?Kzo9iPn5ow=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35b623c5-6ee4-43e4-f4d9-08dee7968508 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2370.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 02:11:19.9674 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pm4trL/z41GeTlCo7G4bpTm36bDo0k4Bf5WMyPZl8X/ONa4k7xbxbm7ni8dKDElWy/+WG9GvZQzie2um1LND0w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7002 Content-Type: text/plain; charset="utf-8" Implement MBA schemata rw test, in a temporary control group, write a few legal percentages to each MB domain, read each back through the schemata then restore the maximum and remove the group. Domain ids are taken from the schemata. Add a resctrl_write_schemata() helper for the raw write. Signed-off-by: Richard Cheng --- .../selftests/resctrl/mba_schemata_test.c | 115 ++++++++++++++++++ tools/testing/selftests/resctrl/resctrl.h | 2 + .../testing/selftests/resctrl/resctrl_tests.c | 1 + tools/testing/selftests/resctrl/resctrlfs.c | 36 ++++++ 4 files changed, 154 insertions(+) diff --git a/tools/testing/selftests/resctrl/mba_schemata_test.c b/tools/te= sting/selftests/resctrl/mba_schemata_test.c index b92011e42726..ff101b814982 100644 --- a/tools/testing/selftests/resctrl/mba_schemata_test.c +++ b/tools/testing/selftests/resctrl/mba_schemata_test.c @@ -150,3 +150,118 @@ struct resctrl_test mba_schemata_info_test =3D { .feature_check =3D mba_schemata_feature_check, .run_test =3D mba_schemata_info_run_test, }; + +/* Read back the percentage for one MB domain from a group's schemata. */ +static int mb_read_domain(const char *ctrlgrp, const char *resource, int d= om, + unsigned int *out) +{ + unsigned int pct[MB_MAX_DOMAINS]; + int ids[MB_MAX_DOMAINS], n, i; + char vals[MB_SCHEMATA_LEN]; + + if (resctrl_get_schemata(ctrlgrp, resource, vals, sizeof(vals))) + return -1; + n =3D parse_mb_schemata(vals, ids, pct, MB_MAX_DOMAINS); + for (i =3D 0; i < n; i++) { + if (ids[i] =3D=3D dom) { + *out =3D pct[i]; + return 0; + } + } + + return -1; +} + +/* + * writing a legal percentage to a domain takes effect + * and reads back, and restoring the maximum works. + * Domain ids come from the schemata directly. + */ +static int mba_schemata_rw_run_test(const struct resctrl_test *test, + const struct user_params *uparams) +{ + static const unsigned int cand[] =3D { 10, 50, 90 }; + unsigned int gran, pct[MB_MAX_DOMAINS], receive =3D 0; + int ids[MB_MAX_DOMAINS], n, i, j, ret, fail =3D 0; + char vals[MB_SCHEMATA_LEN], grp_path[256], line[64]; + const char *grp =3D "mba_schemata_rw"; + + if (resource_info_unsigned_get(test->resource, "bandwidth_gran", &gran)) + return 1; + + /* Enumerate the real MB domain ids from the default schemata. */ + ret =3D resctrl_get_schemata("", test->resource, vals, sizeof(vals)); + if (ret) { + ksft_print_msg("Fail: could not read %s schemata line (ret=3D%d)\n", + test->resource, ret); + return 1; + } + n =3D parse_mb_schemata(vals, ids, pct, MB_MAX_DOMAINS); + if (n < 1) { + ksft_print_msg("Fail: could not parse %s schemata \"%s\"\n", + test->resource, vals); + return 1; + } + + snprintf(grp_path, sizeof(grp_path), "%s/%s", RESCTRL_PATH, grp); + if (mkdir(grp_path, 0755) && errno !=3D EEXIST) { + ksft_print_msg("Fail: mkdir %s: %m\n", grp_path); + return 1; + } + + for (i =3D 0; i < n; i++) { + for (j =3D 0; j < (int)ARRAY_SIZE(cand); j++) { + snprintf(line, sizeof(line), "%s:%d=3D%u", + test->resource, ids[i], cand[j]); + ret =3D resctrl_write_schemata(grp, line); + if (ret) { + ksft_print_msg("Fail: write \"%s\" (ret=3D%d)\n", line, ret); + fail =3D 1; + continue; + } + if (mb_read_domain(grp, test->resource, ids[i], &receive)) { + ksft_print_msg("Fail: read back %s domain %d\n", + test->resource, ids[i]); + fail =3D 1; + continue; + } + if (abs((int)receive - (int)cand[j]) > (int)gran) { + ksft_print_msg("Fail: %s domain %d: %u%% -> %u%% (gran %u)\n", + test->resource, ids[i], cand[j], receive, gran); + fail =3D 1; + } else { + ksft_print_msg("Pass: %s domain %d %u%% -> read %u%%\n", + test->resource, ids[i], cand[j], receive); + } + } + + /* Restore the maximum and confirm. */ + snprintf(line, sizeof(line), "%s:%d=3D%u", + test->resource, ids[i], MB_PERCENT_MAX); + ret =3D resctrl_write_schemata(grp, line); + if (ret) { + ksft_print_msg("Fail: restore write \"%s\" (ret=3D%d)\n", line, ret); + fail =3D 1; + } else if (mb_read_domain(grp, test->resource, ids[i], &receive) || + receive !=3D MB_PERCENT_MAX) { + ksft_print_msg("Fail: %s domain %d not restored to %u%% (received %u)\n= ", + test->resource, ids[i], MB_PERCENT_MAX, receive); + fail =3D 1; + } else { + ksft_print_msg("Pass: %s domain %d restored to %u%%\n", + test->resource, ids[i], MB_PERCENT_MAX); + } + } + + rmdir(grp_path); + + return fail; +} + +struct resctrl_test mba_schemata_rw_test =3D { + .name =3D "MBA_SCHEMATA_RW", + .group =3D "MBA_SCHEMATA", + .resource =3D "MB", + .feature_check =3D mba_schemata_feature_check, + .run_test =3D mba_schemata_rw_run_test, +}; diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/self= tests/resctrl/resctrl.h index a6ad25a08ae5..75d1ad5c6968 100644 --- a/tools/testing/selftests/resctrl/resctrl.h +++ b/tools/testing/selftests/resctrl/resctrl.h @@ -203,6 +203,7 @@ int get_cache_size(int cpu_no, const char *cache_type, = unsigned long *cache_size int resource_info_unsigned_get(const char *resource, const char *filename,= unsigned int *val); int resource_info_str_get(const char *resource, const char *filename, char= *val, size_t len); int resctrl_get_schemata(const char *ctrlgrp, const char *resource, char *= buf, size_t len); +int resctrl_write_schemata(const char *ctrlgrp, const char *line); void ctrlc_handler(int signum, siginfo_t *info, void *ptr); int signal_handler_register(const struct resctrl_test *test); void signal_handler_unregister(void); @@ -249,5 +250,6 @@ extern struct resctrl_test l3_cat_test; extern struct resctrl_test l3_noncont_cat_test; extern struct resctrl_test l2_noncont_cat_test; extern struct resctrl_test mba_schemata_info_test; +extern struct resctrl_test mba_schemata_rw_test; =20 #endif /* RESCTRL_H */ diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testin= g/selftests/resctrl/resctrl_tests.c index 5d45ac95d988..9b3ac0437bf9 100644 --- a/tools/testing/selftests/resctrl/resctrl_tests.c +++ b/tools/testing/selftests/resctrl/resctrl_tests.c @@ -22,6 +22,7 @@ static struct resctrl_test *resctrl_tests[] =3D { &l3_noncont_cat_test, &l2_noncont_cat_test, &mba_schemata_info_test, + &mba_schemata_rw_test, }; =20 static unsigned int detect_vendor(void) diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/se= lftests/resctrl/resctrlfs.c index 8b428a22496d..1196418461b5 100644 --- a/tools/testing/selftests/resctrl/resctrlfs.c +++ b/tools/testing/selftests/resctrl/resctrlfs.c @@ -521,6 +521,42 @@ int resctrl_get_schemata(const char *ctrlgrp, const ch= ar *resource, return ret; } =20 +/* + * resctrl_write_schemata - Write a raw schemata line to a group's schemat= a file + * @ctrlgrp: Control group name, or "" / NULL for the default group + * @line: Full schemata line without newline, e.g. "MB:0=3D50" + * + * Unlike write_schemata(), the caller supplies the exact + * ":=3D", so this works where the domain id is n= ot the + * CPU's L3 cache id (e.g. ARM MPAM, whose MB domains are NUMA proximity i= ds). + * + * Return: 0 on success, or -errno on failure (e.g. -EINVAL for a value the + * kernel rejects). + */ +int resctrl_write_schemata(const char *ctrlgrp, const char *line) +{ + char path[1024], buf[1024]; + int fd, len, ret =3D 0; + + if (ctrlgrp && *ctrlgrp) + snprintf(path, sizeof(path), "%s/%s/schemata", RESCTRL_PATH, ctrlgrp); + else + snprintf(path, sizeof(path), "%s/schemata", RESCTRL_PATH); + + len =3D snprintf(buf, sizeof(buf), "%s\n", line); + if (len < 0 || (size_t)len >=3D sizeof(buf)) + return -EOVERFLOW; + + fd =3D open(path, O_WRONLY); + if (fd < 0) + return -errno; + if (write(fd, buf, len) < 0) + ret =3D -errno; + close(fd); + + return ret; +} + /* * create_bit_mask- Create bit mask from start, len pair * @start: LSB of the mask --=20 2.43.0 From nobody Sat Jul 25 00:02:24 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012039.outbound.protection.outlook.com [52.101.43.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E39038A29A; Wed, 22 Jul 2026 02:11:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.39 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784686291; cv=fail; b=uJjk396YPbyEZJBwi9zb3I5iK+Isnns8+JoHhH4L6ATgKZ7mLTRNK8N3Mmp7nU0z2KRfMOJf/V/WOwPzEgTV0476BT29MqngXAebXnWVtrKjW5HIGuGbcXqymqV+6n7fesCSyU8odgbDm5mdizO6fogHFYLdNhz/0iuSSAQc52A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784686291; c=relaxed/simple; bh=PwKf3tr93Cmnbhgm8PipTJ8557uQpLpqXdn/sazBx+0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ZG4JUh0Nch8kDqq+oIyfCDIpaH6qOh6D/FGJ6kr7EDOx9q1KUwmiXRl2+sw6ze4Iip+OY4j3zzfWa4ikRgZMvoSZM/5Ui8AxLxUopb3Bux1sIF6Ka8J1hJE9pGKh0WjYsoRhierfeJgpkpXYNOksBDsOZb5LWm/K3uZWLlGIUhQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=Y24EqHJf; arc=fail smtp.client-ip=52.101.43.39 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="Y24EqHJf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gay0azygFBZZjFoJVjCjRPQ0hOfImE6ryci3B1IVgxIIqt7ZxYfH4MaKUF/quH8g5rzsr7gMgujbFaLe3Pf0N2TBRaEOdMrdOM107HAVjb5V5a/0Cma43an/B4muWPT2kNKR0PghdI/RrbMRremMYlQPNy7iDlmcvYz2tzwVy3M1d71fyyuhDu9hH11OuQyvJ1HFz+Pj7NWw5qYqpy9y2uNeQhvj6PpD112WW5pguv0EGYU1bKyN7wxQXLWHIYYHZGnYp6KaqMBNdAZqefeLBapRthskxJyRIRld+n10NTIh/R5vFLZEt5it8IuSdA8UUhaHbocDfVjLSTd5BW8PMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8W2SMfMKXgt09qZxhINxhoeDQ2X2jMqZLLnG73TycKo=; b=SAGJJ9JgxhK0ZAhIFU2fPW1zOFxvKhfhHP2+PzTzjvmF5cWFloybrzi/OdgQ9yVXML5YKgGXwUypev1Ko8bwYT9MRLklDBqG4GAuhGTaYcONUsH+nkgokWv3Vu96Vd1dfSqqWj5gozaHhVBYykLQiwOqXKJLYG6UznG4seXcFZiMKHZBNGPEmmfAVOEvlbCirlDm8JHiNaL+VtphI6ih9GUspKQZCacwXSW2uamdMq5TSQ8W/1QtyyVwUe8eZlU6EXQ+tmuOFzLy6YNGCLPdpzfNjb2pGfnKhJcGcg16YQS7yJ9pbI70ymUgXAzD9zeCz6bfegOcNr7k2QXy7jQPYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8W2SMfMKXgt09qZxhINxhoeDQ2X2jMqZLLnG73TycKo=; b=Y24EqHJfWZzJN4AOY38/4PdMBY20bkSrI7/AAgDBBMqRgJEnLgPurznNL8R/wiVtD/5GEhkrVous9KryPZSo5Y00TPbN5uRbrzBHPCq3Vr74N0nGMVIz95nGA0UDTvcYgzqoHDuyj2iAsJgaZnK2rtSkDnMRYt9dVOL1hoFKMafZurH37Z0zoj0GgRdCgGt4zzZD72PGj+kcKwhLpaANafLO9HW0xpF08RhcYIcXjDRrDfvXZJXSBdAxGcnvTLbO1WE7ijEikTaF63k+ch2N9a3U8+pXrjnJjLm5vPQkCNll6VW7PiCZPg7IlLOKY4ZdVkGf9NMz4OJ+2bEyPqdJbQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2370.namprd12.prod.outlook.com (2603:10b6:207:47::27) by SA0PR12MB7002.namprd12.prod.outlook.com (2603:10b6:806:2c0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 02:11:27 +0000 Received: from BL0PR12MB2370.namprd12.prod.outlook.com ([fe80::86cf:c3ec:2cf5:74c8]) by BL0PR12MB2370.namprd12.prod.outlook.com ([fe80::86cf:c3ec:2cf5:74c8%5]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 02:11:27 +0000 From: Richard Cheng To: tony.luck@intel.com, reinette.chatre@intel.com, x86@kernel.org Cc: Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, newtonl@nvidia.com, kristinc@nvidia.com, kobak@nvidia.com, kaihengf@nvidia.com, fenghuay@nvidia.com, ltrager@nvidia.com, Richard Cheng Subject: [PATCH 3/4] selftests/resctrl: Add MBA schemata invalid-write selftest Date: Wed, 22 Jul 2026 10:10:56 +0800 Message-ID: <20260722021057.9370-4-icheng@nvidia.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260722021057.9370-1-icheng@nvidia.com> References: <20260722021057.9370-1-icheng@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TP0P295CA0047.TWNP295.PROD.OUTLOOK.COM (2603:1096:910:3::13) To BL0PR12MB2370.namprd12.prod.outlook.com (2603:10b6:207:47::27) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2370:EE_|SA0PR12MB7002:EE_ X-MS-Office365-Filtering-Correlation-Id: afc8580f-f8b8-4d43-d0ef-08dee796896e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|6133799003|56012099006|11063799006|10067099003|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: tkY/RDTuwLgrqukDo8sibom7uBXRxYwkqNmKesqjmq+kck6gqPwXGHQN7Wq3G7dyA2MpPZvyXqMrQQG3tgRqdY7cgtv69YionLuGl5MaqafsrFIvLm6Lr90RJtpRdCGGI6xmDAjvDk03WR1YZAZ3+qEF+K86Bv3nREV4AVtaXP8/n6gMhWI4c5CTPYiiYk4lu/v8/pEy02wpRzPMUXIGrF7c5A48ElG6Um7DaH/V8SKxGskTwnuHUDkNYhmPrbedhmYEDwmPZtp9FiZzgCbH5jG6wCEah/ywFEt4JX6mW3Am+DsTsFvpfw9Da4s20QLM/RqWPmko8y7TdDiD4X+XlNMWx7MvBaH27mVuNI51jRqdwt417CKX8h12wBVZ7R2+7kwu6B4D/fLudwG3/aCCaDsUYkCvLq1MfRZe39KvkbtvcaQvrUSmNLv+79B6sYQfteFX4FtWzShAmDBbE38Cwz94wGBBAnt261WNsPK/OCmzhEcxBdgRK94YE2GySKOAwwMgwePvB5y/bhwYsAM1ti2pIKaduraHchvWwX3JppUx9/chFSXVVuMxx2CrlcUlzp/0JtDr2TQ9HfSmsxjMngPdE5bjVvAFHIfV5FlxWOhnRtfj4USSzekQZ+Ut/EErzSqkUaot1zDNYfQ44BWwHRwym8ZRTqMeE34WZeiYbRA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2370.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(6133799003)(56012099006)(11063799006)(10067099003)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HdXPvbkXVN+5pKotZ3Hcxuo7JW/2wtxFOIiFgeb+zXqg36e6g6NNS7doG1aJ?= =?us-ascii?Q?aIJb7L3Md2PnUTS7oBPwB7yt8vFud2XRPsju8iF/rb+c22i2iFebr+9amErH?= =?us-ascii?Q?PFZMMwseL5h90RdVuOCVrOM/h0bkdna+yH7CEQHSjm7+KVFaZwdQblGsjHzX?= =?us-ascii?Q?oXzRv/TJZHcygtzDWvAGlPnLnMv3e5aTxrKaX8IoidaDcaJCYY12prTEqykN?= =?us-ascii?Q?euR7e8xj/coCtvDGGn75fIM4P8P5B2IqiDIV85CttR/6axlXOwa9kxaTHSDT?= =?us-ascii?Q?HH7jA2HHGAqzcIrZFY5cDYazwCBJS2QukMfftB8SU83CJ1OKdkYNdM4Q0K4X?= =?us-ascii?Q?M+W07SgWxtTPUXVPcCjYVfRRbJFrSR1oCHrPEiyt5wElKHxMPc0j6gMjoYmz?= =?us-ascii?Q?zWTzgZ+MRYTUfoKyZTIdYVDqe9wugA5rzf+OZcRXYZ4LpM28V7tMQhsOuKZh?= =?us-ascii?Q?HlhcXx7cQcoM8iXnCPWbZl/x8BbswImK2sSEJZDKiNszqiYvgu/ieaTVp9WL?= =?us-ascii?Q?BJKOtBT1NntR/17In9QbREv2dBgpjEME76ZuarK1P+OgBmK0XOWk7Ecw+CyD?= =?us-ascii?Q?HFsTamV/AHRLJPPNsClIyPqlIkDhihRMxOKoNpDJ4TcMKPR1EtVjS/O8vpPR?= =?us-ascii?Q?ysOSTMH9lL5enQOchpIrS6KGp9z1HjU/PxhPfDIfRUUZTbZ9qVJjmAjjuoXj?= =?us-ascii?Q?KzX8wS7aAFDLgpyJsjQGq9a2JGUXwqY/+kbgAlUI2I9xczxCyrqSBGaVLCne?= =?us-ascii?Q?PGHe5cavDBCkKi3u5BT8ju1gczi8AiInoVETCWMBfzMoJhmvisV9JIZxYRur?= =?us-ascii?Q?6ohpfzKLAawj+8x+jfpNh0dmOVkZvKT4sKYTGGg5kuUhOt2PgZP54fjMo0LK?= =?us-ascii?Q?v6G7r/4xtkPoOUpi6HMy7Y65sAQviTx2ZYvDcgJHK7sSw6mu7eLNTNGDZ2mU?= =?us-ascii?Q?xpHJnOJtO8oi9/2z0/ZafQU2bCarEiqpEi1nn5uh/ZEg7cmVEyT6WwrgG9sx?= =?us-ascii?Q?5ptorEW0pFpKxSgrxpmYQhflOeruDmD3EwaHGnnnU0auXTwyWDi7gRxH52zA?= =?us-ascii?Q?PEwbQPOnMMqNCSbvOI2TBQzo5Ru71DvOvscrQSx9uxBgfyb4dHw250X42a3g?= =?us-ascii?Q?NtP7lWdOSpq1Yy2Y/5uiLEr0Uq29YtzrSnT0PAn0khOaG219cbyDBy9BNhd5?= =?us-ascii?Q?g4pbIkO+mxzGt8GRysZ50I8dPsiv0fib0004xce/0hMGWZqafxlRfMaU0djA?= =?us-ascii?Q?M01IagKikeR8Q+34tIEtmnXjw0bmYncenge0/5N/brXb3+EyugJgsKkerZ1I?= =?us-ascii?Q?wHNvQnC2ZSnq4aai7xcGzRNcM+5x+Dmo3JkVb5Pxl5ZMU2b3iUey5JDthuM/?= =?us-ascii?Q?vchOeTtJde2xNQPbar50xcP14INZX/zXAcJ66Z6HxkRMKO9V9QXx3PkSDOWh?= =?us-ascii?Q?k8+eoI4eimjVAT+HHDMnMvHWte/63ovsqWKQdyMNt4zYyEjwhu2cgsFmzddR?= =?us-ascii?Q?M8JMH3Ge1eWQJv86cYRzVmgWnvbnXTIGACG+0zt1MTS7ytVRyKKRHshUXGk/?= =?us-ascii?Q?wk2N4wx8NG8tNxBNoNt0OjU6+QiJrcZfpvr3JYqOFie2SxNE/2OBg1fl/dAJ?= =?us-ascii?Q?s2f6rRFzJMNLwzEz3wj7yuxB6Wwl/JjoLYk2YVdyWeOp6T2sgNtetI23IR2i?= =?us-ascii?Q?xQ+OGsplsTqEzIfZ123ai+9kBMGQIREHLIIH3V76cDDJngBh2Zz39TnaVpSt?= =?us-ascii?Q?L+vS9qSm4g=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: afc8580f-f8b8-4d43-d0ef-08dee796896e X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2370.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 02:11:27.4337 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a/HIzbqT7BSjBi3GvWic+WpKFkebsvPxPqfD2lDYpungZ1WZJdAm+fLsPfLsUx9PhluTSJ+TDvQXA1QyQTCddw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7002 Content-Type: text/plain; charset="utf-8" The resctrl ABI requires invalid MB schemata writes to fail and report a diagnostic in info/last_cmd_status. Add MBA_SCHEMATA_INVAL. In a temporary control group it writes an out-of-range value 101, malformed values abc, -5, and a non-existent domain id, asserting each write fails and last_cmd_status contains the expected substring. The bad-domain case checks errno only, as the kernel does not update last_cmd_status there. A final write of the maximum percentage must succeed and report "ok". Signed-off-by: Richard Cheng --- .../selftests/resctrl/mba_schemata_test.c | 123 ++++++++++++++++++ tools/testing/selftests/resctrl/resctrl.h | 1 + .../testing/selftests/resctrl/resctrl_tests.c | 1 + 3 files changed, 125 insertions(+) diff --git a/tools/testing/selftests/resctrl/mba_schemata_test.c b/tools/te= sting/selftests/resctrl/mba_schemata_test.c index ff101b814982..0cd257dcec91 100644 --- a/tools/testing/selftests/resctrl/mba_schemata_test.c +++ b/tools/testing/selftests/resctrl/mba_schemata_test.c @@ -265,3 +265,126 @@ struct resctrl_test mba_schemata_rw_test =3D { .feature_check =3D mba_schemata_feature_check, .run_test =3D mba_schemata_rw_run_test, }; + +/* + * Read the first line of info/last_cmd_status. + */ +static int read_last_cmd_status(char *status, size_t len) +{ + return resource_info_str_get("", "last_cmd_status", status, len); +} + +/* + * invalid schemata writes (out-of-range value, malformed value, nonexiste= nt + * domain) must be rejected with a diagnostic in info/last_cmd_status, and= a + * subsequent valid write must still succeed and report "ok". + */ +static int mba_schemata_inval_run_test(const struct resctrl_test *test, + const struct user_params *uparams) +{ + /* Rejected values and the stable last_cmd_status fragment expected. */ + static const struct { + const char *val; + const char *substr; + } bad[] =3D { + { "101", "out of range" }, + { "abc", "Invalid MB value" }, + { "-5", "Invalid MB value" }, + }; + unsigned int pct[MB_MAX_DOMAINS]; + int ids[MB_MAX_DOMAINS], n, i, ret, bad_dom, fail =3D 0; + char vals[MB_SCHEMATA_LEN], grp_path[256], line[64], status[256]; + const char *grp =3D "mba_schemata_inval"; + + /* Enumerate the real MB domain ids from the default schemata. */ + ret =3D resctrl_get_schemata("", test->resource, vals, sizeof(vals)); + if (ret) { + ksft_print_msg("Fail: could not read %s schemata line (ret=3D%d)\n", + test->resource, ret); + return 1; + } + n =3D parse_mb_schemata(vals, ids, pct, MB_MAX_DOMAINS); + if (n < 1) { + ksft_print_msg("Fail: could not parse %s schemata \"%s\"\n", + test->resource, vals); + return 1; + } + + /* A domain id one past the largest real one cannot exist. */ + bad_dom =3D ids[0]; + for (i =3D 1; i < n; i++) + if (ids[i] > bad_dom) + bad_dom =3D ids[i]; + bad_dom++; + + snprintf(grp_path, sizeof(grp_path), "%s/%s", RESCTRL_PATH, grp); + if (mkdir(grp_path, 0755) && errno !=3D EEXIST) { + ksft_print_msg("Fail: mkdir %s: %m\n", grp_path); + return 1; + } + + for (i =3D 0; i < (int)ARRAY_SIZE(bad); i++) { + snprintf(line, sizeof(line), "%s:%d=3D%s", + test->resource, ids[0], bad[i].val); + ret =3D resctrl_write_schemata(grp, line); + if (!ret) { + ksft_print_msg("Fail: invalid write \"%s\" was accepted\n", + line); + fail =3D 1; + continue; + } + if (read_last_cmd_status(status, sizeof(status))) { + fail =3D 1; + continue; + } + if (!strstr(status, bad[i].substr)) { + ksft_print_msg("Fail: \"%s\": last_cmd_status \"%s\" lacks \"%s\"\n", + line, status, bad[i].substr); + fail =3D 1; + } + } + + /* + * A write to a nonexistent domain also fails, but the kernel does not + * record it in last_cmd_status, so assert on the write error only. + * Use the maximum percentage so the rejection can only be due to the + * domain id. + */ + snprintf(line, sizeof(line), "%s:%d=3D%u", + test->resource, bad_dom, MB_PERCENT_MAX); + ret =3D resctrl_write_schemata(grp, line); + if (!ret) { + ksft_print_msg("Fail: write \"%s\" to nonexistent domain was accepted\n", + line); + fail =3D 1; + } + + /* + * The rejected writes must not break a following valid write. + */ + snprintf(line, sizeof(line), "%s:%d=3D%u", + test->resource, ids[0], MB_PERCENT_MAX); + ret =3D resctrl_write_schemata(grp, line); + if (ret) { + ksft_print_msg("Fail: valid write \"%s\" (ret=3D%d)\n", line, ret); + fail =3D 1; + } else if (read_last_cmd_status(status, sizeof(status))) { + fail =3D 1; + } else if (strcmp(status, "ok")) { + ksft_print_msg("Fail: valid write \"%s\": last_cmd_status \"%s\" !=3D \"= ok\"\n", + line, status); + fail =3D 1; + } + + rmdir(grp_path); + + return fail; +} + +struct resctrl_test mba_schemata_inval_test =3D { + .name =3D "MBA_SCHEMATA_INVAL", + .group =3D "MBA_SCHEMATA", + .resource =3D "MB", + .feature_check =3D mba_schemata_feature_check, + .run_test =3D mba_schemata_inval_run_test, +}; diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/self= tests/resctrl/resctrl.h index 75d1ad5c6968..c32ab5c2cc56 100644 --- a/tools/testing/selftests/resctrl/resctrl.h +++ b/tools/testing/selftests/resctrl/resctrl.h @@ -251,5 +251,6 @@ extern struct resctrl_test l3_noncont_cat_test; extern struct resctrl_test l2_noncont_cat_test; extern struct resctrl_test mba_schemata_info_test; extern struct resctrl_test mba_schemata_rw_test; +extern struct resctrl_test mba_schemata_inval_test; =20 #endif /* RESCTRL_H */ diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testin= g/selftests/resctrl/resctrl_tests.c index 9b3ac0437bf9..7a7184783e6a 100644 --- a/tools/testing/selftests/resctrl/resctrl_tests.c +++ b/tools/testing/selftests/resctrl/resctrl_tests.c @@ -23,6 +23,7 @@ static struct resctrl_test *resctrl_tests[] =3D { &l2_noncont_cat_test, &mba_schemata_info_test, &mba_schemata_rw_test, + &mba_schemata_inval_test, }; =20 static unsigned int detect_vendor(void) --=20 2.43.0 From nobody Sat Jul 25 00:02:24 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012013.outbound.protection.outlook.com [52.101.53.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE4D438837A; Wed, 22 Jul 2026 02:11:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.13 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784686303; cv=fail; b=rL4XFnymGKe+h0QXmg5C5gJW20LrTIHhJGgFWFHm6lwm6Czofcu8G6OgxlbyH9amj0IEeBxsNwTtZlalKaImcRTdOtXbfDAuj/Dmtjs5JYxxRVSWVvqu+3NjXd6OHTsAIWTf7OleubwS8Sw0LSS/SXDvKWpWreN14nLW9Q41o/g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784686303; c=relaxed/simple; bh=un02zgr1R/vkA7VsHRIgIv+Ucw/6O/ERlqi2pq92510=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=hwTHdHW/06srPJA5Tl0F4fQo5YMmQST3o9gwMunmE/3X4C0WRiK6cxqtz114pRtgSkA8ptP/L7LiJS+PB/UEPG8n89B0jKMNqKgFhSAJMU4KO2S8pe50f+rtLPPmAOu5xHejZoPVOkkhIWny0UVOHASh/GVMAKbvPwUbMMTobEY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=X7Lf1fpB; arc=fail smtp.client-ip=52.101.53.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="X7Lf1fpB" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EmlWH2d9XsXSut4B8BlvMnOO6m/PvMt2ZnpHHKx6AaPIHAJxKBZY+7ag6A6TKUyF0EQfZZ/6u+6Siv91+eb3M0bnJ85nlfH6TdHmpUZ5eP+hrISk7beKCNQSiEWAIayaFClapuQIgnmNJb0rxxQRBcPeTAjBSZ30GFNH+bn88i0POYQx6kqeQnPp8/OxPAuYORg12BBKZjeYGCc0lfOZsa9zr5rPB0cpiyspvbf6l6Jgrd1pZQQT8uZm3NzLQwjtxKvTv90exw4IkUs2EKvOKdz0tPth8pJn+Pr/9khyWs7FHhYz8wUPAW4SZPMKxShgUaOYKuBx5+yGhEFMTpyhlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k2D/1XotN6bRxKpLwJDygg/g4BzaPq9S8H08EeUMjnw=; b=BezCvYJUaZouyyZdFFBqT2vvGipS5s5w94YGiBk8vlNwSjDlAyopuPxsjGfpGNLLfVXBl1o5Ckg5tYtmeX2rCZbUEjR8/9oGUDu01TpmyL1C2lxm3nenEuGN4n3VGtnXj6woyx3OQhx7vrP1wcyA52iAPOGQL1ildn+fPpQ+nOjomGKpeLfKY8hIJolEQNU+8zU4QeriS4w2rh/4vyVwiLmUxJdUrW7KtbVMoME3ctnkQtGwHDT/+KiYMSjWHeAs4DYcoYcgP/btONv15r8BBqJzPBoVmup4KOPrpn81YU3iTt6gRQSvhcF5VGpIELszTvcgVo5s5lyD6S/uQMN4eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k2D/1XotN6bRxKpLwJDygg/g4BzaPq9S8H08EeUMjnw=; b=X7Lf1fpBtS8/G1jN7+B57YrWxetPRSw6x49dd5Y798jim6b2ksMx5tHjx6ZOy0fGWvk9ZqQDh2DaoBX0vH0GNJESKH109uQ9BRJonHY4uxAfeqX/31iH7jFeN9n53x061li3Iui6fq4bLOLkM+sV6P/65mhKjjsjA1Jf1OEBGJ4dtvZNynA7uW4XeqFy08X2bFFloNC6ANloLcjKy4dDH3RCKKVcu7Ry+GzL1Lzl5rIvGYJDC1cqmQeRFpkLTldMTfmSz/Y7aB4s/2QQTlmw9n/mLl/iGUWvr3ymHaAj1/i7V2F29f76iHuSxSwIx5tjnpDdnUTKBT86OaEOo5FlEQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2370.namprd12.prod.outlook.com (2603:10b6:207:47::27) by SA0PR12MB7002.namprd12.prod.outlook.com (2603:10b6:806:2c0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Wed, 22 Jul 2026 02:11:37 +0000 Received: from BL0PR12MB2370.namprd12.prod.outlook.com ([fe80::86cf:c3ec:2cf5:74c8]) by BL0PR12MB2370.namprd12.prod.outlook.com ([fe80::86cf:c3ec:2cf5:74c8%5]) with mapi id 15.21.0245.009; Wed, 22 Jul 2026 02:11:37 +0000 From: Richard Cheng To: tony.luck@intel.com, reinette.chatre@intel.com, x86@kernel.org Cc: Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, shuah@kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, newtonl@nvidia.com, kristinc@nvidia.com, kobak@nvidia.com, kaihengf@nvidia.com, fenghuay@nvidia.com, ltrager@nvidia.com, Richard Cheng Subject: [PATCH 4/4] selftests/resctrl: Add MBA schemata per-group isolation selftest Date: Wed, 22 Jul 2026 10:10:57 +0800 Message-ID: <20260722021057.9370-5-icheng@nvidia.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260722021057.9370-1-icheng@nvidia.com> References: <20260722021057.9370-1-icheng@nvidia.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: KL1P15301CA0051.APCP153.PROD.OUTLOOK.COM (2603:1096:820:3d::23) To BL0PR12MB2370.namprd12.prod.outlook.com (2603:10b6:207:47::27) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2370:EE_|SA0PR12MB7002:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e5e5b6e-db7a-4f0b-2ce0-08dee7968ecf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|23010399003|376014|1800799024|6133799003|56012099006|11063799006|10067099003|3023799007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: ovSV8J9w2ckyZ7D6Ad6PWdPMI18xt4B+OMIEKOZKPg9x1aZtKGG+KxxJnQGDe6Kx19tLT8lLsr/dN9zc0SH2kgg3zQ9uiNeyQD8n02+BgLjwQqvKfAV3TwjCBOMQaysKwXs2U0x80L41TT/iU/Ke57uWLmjjmQxyxvTytG5U9ihTsI3f8aqQDGkSrOxYu9gojXrXMDUG8KoYjur2/QjvEvH1UxujgGyQETJ8IwF/U4YCQuIwE2ivQB3UMeF38RExq3P690zAi1eYel394ZT7H0bxDtQmcRygb/EUn4MhkDciFoEBV1PW3zbtY1UAP001bC/wbkXoYNJgmKQCZ5lYVSYJnBNfvbyV88ieUWtqXJAknQt15azHeGa/zyTNxb5RNcUIE2EE9TepbwXBrQsCvX5nwnv1Pg3xXIg4rU7z4rs0QAcgKHETTzDnCQD20sAo1GteoJlTAdWID5SsGrpsBZ+wTr/pbKjNwWVqgf2NFD8ExqbSc6ICKLDPo2TK30JQJ2YyZM0KVI6Y6wvWHb1n4rmfBjfIP9JN0PwUyF38vhzIkIF3dJWbgN/DJ+v3KmPL80v4T/v1pDhYl6wiBq9TtLkdud2v0QS8fdcdLL1UUCHDuD5xCkwS1Cu4IbF+UoIyEatqEiuLhUzu9npvSKwMT5SyvFSrjCWu+hkvGj+dKwQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2370.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(23010399003)(376014)(1800799024)(6133799003)(56012099006)(11063799006)(10067099003)(3023799007)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q2swe4Rd2oukGNxfdH7zTpEmc6dF4CMXrRK9Xsb1WLXuGzE4o8zF3mrQB0RV?= =?us-ascii?Q?T5rY49hBfoAvQE8LUbyNms4dGgmythC7uoDzQ3DY58AzknEi/WE/Co4UDtQQ?= =?us-ascii?Q?f8WSoQSgpz8ExkYHhq7ZOwLTiHHL66BqeBDBbHxEygfN+VNqVOYwqIhqAB/K?= =?us-ascii?Q?z5Q9BDrSEl9vO4eNvjdDWPHCU0EVXnn+iZui3d8fyEJ/WCaxnnxugXaXzJ3P?= =?us-ascii?Q?Wiv2kInqovcaIQJb+1Di0e/N6mBxdcB9LBBo8iPRFxebsBZxvitTqQbXBNyx?= =?us-ascii?Q?/MKF13ypKdH516wZd2AqpkqQUwcJWDqUud/zI/SgnJBY9xPVuHZ/UGJPbebA?= =?us-ascii?Q?gbsLffpYGIOSUxLYUGTUHmfOxoOBcXafwu3OEIweMN49Zp7Zb+rOzGXoDS8j?= =?us-ascii?Q?l6f96ngm6qxCG2Y7ETim8SAeS8fQnKqQvsLi/d0zCLIjiOu7lFVzK6WKwlS+?= =?us-ascii?Q?b+ZobQyZFw1mMtVy1gq6M6WftzjmsjcaefdO+LYT8kA+TK1FHgKL4gZtnz+r?= =?us-ascii?Q?quLkgwwxTEdSETxYjgZpnQBXnWdnqk5R/gBz/RnHBQHQD7gL2emMXygYX9CJ?= =?us-ascii?Q?WH/Ttby3+K8i0d/439LnKzL71yI7pIZaq36hcfMP1CTx9pykEx+kyOtkQV0p?= =?us-ascii?Q?5123Q9ERdoupsUxkEBxJLyp5HZhEjl2cVeV/FgFsBC76f903KdFlWygNT7OC?= =?us-ascii?Q?lqksIXKvs6K+HpzrGyrl13YhRV5HZSE0PHtoxWqR1A5oCK6rgBidUQ44gqXR?= =?us-ascii?Q?VZ3S2/4GAzc8bviR1tyOcPjEoOsh66qgPMmRZVmtzQfPdNy4Wed/nRsOSkAm?= =?us-ascii?Q?/XuO6Elpl+IsLkG7jcWmtan5PSxZ3kFB5b8Eg7IlfjmaYj0gJdGTivUS0aoZ?= =?us-ascii?Q?9My+WLTz8cySL7qVfN1Hcsl5E1zh+FFF9WPuItOD0NohGXiuuXoMQQJcptrt?= =?us-ascii?Q?Vg8zUWpe5Co4owyRcsTzUFlbR7kX9FVVCCh9vQ3FBZlN+f9FESjwL1a6KM0A?= =?us-ascii?Q?jDxEC7Nkfee5k7939UZK4XzJmBGbWGh3Hkqol3CMTS4dyUZ31/w4Ya8A/Xo/?= =?us-ascii?Q?3ofzOMR25SiMMsD/WNJuURYZyokV9/lAZic1SzEZ3lHHAc1rlzPUPfKt/+kO?= =?us-ascii?Q?BSCKYwgeasjAY88QiFn4Bfde0x05umroOCkuICzxRz7T7H7lmwyWU55TLIrj?= =?us-ascii?Q?zbH0mSN7xoTzvfhyUT3Xuwf0E2fAy1P3llswppdY0WNzqVOyM1raY2FYTT0O?= =?us-ascii?Q?fVc0udv/K/QtgUQ/pCt+WCGnn6qvvahni1mkJiGO+ln6RBnDW1UlIrQfL2Lp?= =?us-ascii?Q?9ThuIVlX7MIDb3JW2WiEBH4yOWYBAAPHwrZC6YKbR0osmb/m44XB6FkXI5ya?= =?us-ascii?Q?GsPP0boYfZ/KcOhglSMKInm6F9NkK4z0YHMllsgWNG2U2NRwANL1ZF0GsYNS?= =?us-ascii?Q?Jsul+CclWBA8UCa1hRSxTKaim1gF39r0O1qoumnubuBLKL8OcfDasjjvWStU?= =?us-ascii?Q?vNWBXS1i9uOjCgg3SMasNuRQSiVjZMPkiaKpdu6VEQ2+RfA2t1tRRtG1CoZ7?= =?us-ascii?Q?ykUz/OzUCYsdh8xGFy8eRsV4dFYlal5ZSGV2oSvlSqsa9mkJm0zo2rP20jTi?= =?us-ascii?Q?x+LN4VmsC4kKq+V5tD8LUUjZHfw+iToxH0vZMwf9dgVOXFfqM5vjygKn7FEm?= =?us-ascii?Q?Oc9lOfEfILtYsfu/dJH9uDfWfXvb8Kz8CcAHTD1qKrN0WeyIvCeWEGybwd+x?= =?us-ascii?Q?7g7mfpK5Rw=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e5e5b6e-db7a-4f0b-2ce0-08dee7968ecf X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2370.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2026 02:11:36.9585 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jyBTcBe38+JBnuyCUlbhUULmDDSu0gHbQaVFeK6UTVrRes+Krv+HcuNZ/rJhzyo7B9Ft+leIU+lvkkCk/OS41w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7002 Content-Type: text/plain; charset="utf-8" MB cpas are per control group, implement MBA_SCHEMATA_ISOLATE test to verify a write to one group leaves other groups and the default group untouched. Create 2 groups, set the first to the max and the second to a lower cap, then read the first after writing the second, each holds its own value. The default group stays unchanged. The lower cap is gran-aligned and at or above min_bandwidth, so read-back is exact and provably below the maximum. Signed-off-by: Richard Cheng --- .../selftests/resctrl/mba_schemata_test.c | 131 ++++++++++++++++++ tools/testing/selftests/resctrl/resctrl.h | 1 + .../testing/selftests/resctrl/resctrl_tests.c | 1 + 3 files changed, 133 insertions(+) diff --git a/tools/testing/selftests/resctrl/mba_schemata_test.c b/tools/te= sting/selftests/resctrl/mba_schemata_test.c index 0cd257dcec91..d98946b831b1 100644 --- a/tools/testing/selftests/resctrl/mba_schemata_test.c +++ b/tools/testing/selftests/resctrl/mba_schemata_test.c @@ -388,3 +388,134 @@ struct resctrl_test mba_schemata_inval_test =3D { .feature_check =3D mba_schemata_feature_check, .run_test =3D mba_schemata_inval_run_test, }; + +/* + * MB allocations are per control group: two groups hold different + * percentages on the same domain without disturbing each other or the + * default group. + */ +static int mba_schemata_isolate_run_test(const struct resctrl_test *test, + const struct user_params *uparams) +{ + unsigned int gran, min_bw, low, num_closids, def_before =3D 0, def_after = =3D 0; + unsigned int got1 =3D 0, got2 =3D 0, pct[MB_MAX_DOMAINS]; + int ids[MB_MAX_DOMAINS], n, ret, dom, fail =3D 0; + char vals[MB_SCHEMATA_LEN], path1[256], path2[256], line[64]; + const char *grp1 =3D "mba_schemata_iso1", *grp2 =3D "mba_schemata_iso2"; + + /* + * Isolation works with any CLOSID count, but the + * default group plus the two test groups each need to hold one. + */ + if (resource_info_unsigned_get(test->resource, "num_closids", &num_closid= s)) + return 1; + if (num_closids < 3) { + ksft_print_msg("Skipping: num_closids=3D%u < 3, cannot create two test g= roups\n", + num_closids); + return 0; + } + + if (resource_info_unsigned_get(test->resource, "bandwidth_gran", &gran) |= | !gran) + return 1; + if (resource_info_unsigned_get(test->resource, "min_bandwidth", &min_bw)) + return 1; + + /* Enumerate the real MB domain ids from the default schemata. */ + ret =3D resctrl_get_schemata("", test->resource, vals, sizeof(vals)); + if (ret) { + ksft_print_msg("Fail: could not read %s schemata line (ret=3D%d)\n", + test->resource, ret); + return 1; + } + n =3D parse_mb_schemata(vals, ids, pct, MB_MAX_DOMAINS); + if (n < 1) { + ksft_print_msg("Fail: could not parse %s schemata \"%s\"\n", + test->resource, vals); + return 1; + } + dom =3D ids[0]; + + /* + * grp2's cap must stay provably below grp1's 100% even after the + * kernel rounds it to bandwidth_gran: align it here, at or above + * min_bandwidth, and expect an exact read-back. If no aligned value + * below the maximum exists, the two groups cannot be told apart. + */ + low =3D min_bw > 20 ? min_bw : 20; + low =3D (low + gran - 1) / gran * gran; + if (low >=3D MB_PERCENT_MAX) { + ksft_print_msg("Skipping: no %s cap below %u representable (min_bw=3D%u,= gran=3D%u)\n", + test->resource, MB_PERCENT_MAX, min_bw, gran); + return 0; + } + + if (mb_read_domain("", test->resource, dom, &def_before)) { + ksft_print_msg("Fail: read default group %s domain %d\n", + test->resource, dom); + return 1; + } + + snprintf(path1, sizeof(path1), "%s/%s", RESCTRL_PATH, grp1); + if (mkdir(path1, 0755) && errno !=3D EEXIST) { + ksft_print_msg("Fail: mkdir %s: %m\n", path1); + return 1; + } + snprintf(path2, sizeof(path2), "%s/%s", RESCTRL_PATH, grp2); + if (mkdir(path2, 0755) && errno !=3D EEXIST) { + ksft_print_msg("Fail: mkdir %s: %m\n", path2); + rmdir(path1); + return 1; + } + + /* Pin the two groups to different caps on the same domain. */ + snprintf(line, sizeof(line), "%s:%d=3D%u", + test->resource, dom, MB_PERCENT_MAX); + ret =3D resctrl_write_schemata(grp1, line); + if (ret) { + ksft_print_msg("Fail: write \"%s\" to %s (ret=3D%d)\n", + line, grp1, ret); + fail =3D 1; + } + snprintf(line, sizeof(line), "%s:%d=3D%u", test->resource, dom, low); + ret =3D resctrl_write_schemata(grp2, line); + if (ret) { + ksft_print_msg("Fail: write \"%s\" to %s (ret=3D%d)\n", + line, grp2, ret); + fail =3D 1; + } + + /* Each group keeps its own cap; reading g1 after writing g2. */ + if (mb_read_domain(grp1, test->resource, dom, &got1) || + got1 !=3D MB_PERCENT_MAX) { + ksft_print_msg("Fail: %s domain %d: %u%%, expected %u%%\n", + grp1, dom, got1, MB_PERCENT_MAX); + fail =3D 1; + } + if (mb_read_domain(grp2, test->resource, dom, &got2) || + got2 !=3D low) { + ksft_print_msg("Fail: %s domain %d: %u%%, expected %u%%\n", + grp2, dom, got2, low); + fail =3D 1; + } + + /* The default group must be untouched by either write. */ + if (mb_read_domain("", test->resource, dom, &def_after) || + def_after !=3D def_before) { + ksft_print_msg("Fail: default group domain %d changed %u%% -> %u%%\n", + dom, def_before, def_after); + fail =3D 1; + } + + rmdir(path1); + rmdir(path2); + + return fail; +} + +struct resctrl_test mba_schemata_isolate_test =3D { + .name =3D "MBA_SCHEMATA_ISOLATE", + .group =3D "MBA_SCHEMATA", + .resource =3D "MB", + .feature_check =3D mba_schemata_feature_check, + .run_test =3D mba_schemata_isolate_run_test, +}; diff --git a/tools/testing/selftests/resctrl/resctrl.h b/tools/testing/self= tests/resctrl/resctrl.h index c32ab5c2cc56..07a67ac9292c 100644 --- a/tools/testing/selftests/resctrl/resctrl.h +++ b/tools/testing/selftests/resctrl/resctrl.h @@ -252,5 +252,6 @@ extern struct resctrl_test l2_noncont_cat_test; extern struct resctrl_test mba_schemata_info_test; extern struct resctrl_test mba_schemata_rw_test; extern struct resctrl_test mba_schemata_inval_test; +extern struct resctrl_test mba_schemata_isolate_test; =20 #endif /* RESCTRL_H */ diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testin= g/selftests/resctrl/resctrl_tests.c index 7a7184783e6a..583ee97bac20 100644 --- a/tools/testing/selftests/resctrl/resctrl_tests.c +++ b/tools/testing/selftests/resctrl/resctrl_tests.c @@ -24,6 +24,7 @@ static struct resctrl_test *resctrl_tests[] =3D { &mba_schemata_info_test, &mba_schemata_rw_test, &mba_schemata_inval_test, + &mba_schemata_isolate_test, }; =20 static unsigned int detect_vendor(void) --=20 2.43.0