From nobody Fri Jul 24 22:54:53 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C48B94457AA for ; Wed, 22 Jul 2026 18:44:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784745900; cv=none; b=H8tO2uuNgl/BVjAucKfnNf4NmOpmVDPfOQsOI4Zuid7V43ruUCjXQV7L/xKpJs0HzaTa37tADlcLq0RPm+4x/AIylW1x4PCy6grLvSMg94Ol+JFPwbY79Cow5Qg1jaMG+bDLCh6tqENLhUNf5DGAgt3ATggUsJWLxR67ZDodTyQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784745900; c=relaxed/simple; bh=ISIwp/sXQobVv07RweLH6MaBMg/gxKujXMAO7JcPE94=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=LPgIjobcZpt1BLDGu/DCvstuvJm4WCfXZ8kAKrfpMjB7PG95XCTYZilgl0xv5w1X9ZnB6PLJV394B/Vk93+3mefU+DTdCg0lIijJARxgq07jxoxD7q6txtWp31OtAlsxeA2BAtsD8yLsCgjRjD1TAU8fdAB/vRFqskCK6Mz2Q6Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VnG2Zqb3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VnG2Zqb3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 17DE41F000E9; Wed, 22 Jul 2026 18:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784745899; bh=x44uhZbq2B9G2E9nG+czfwtCtF+7aytn//SENl8MBaQ=; h=From:Date:Subject:To:Cc; b=VnG2Zqb3URkf57II21CdKuzRq8Rny3mmyTDuzOgM5COBWIhT2h8jrvP9GFOo3Lti6 ePo6HWikoWfq/fG6d4ALd4SnanDRGFVGZQyl5fL7IYCJTSz/c33ld0TuUwly9J0DzN VJ7qR6bUgOt1eSCs2sla+y5Uro9SSORWEDynyIM4fXc2u0jAOLy0B5m1PGZDRkpEfQ bWETfre6N/5x/oWeyReX4VqwP3qntBd9CKMKMLXSByXWWvQippZjMxEuUZ88MVEtW2 CmZpzm30AJ9ZlvJ2qm+M2kr5mh8kr0qltv/Xh9/bAIHwqAuTE4Zs+9h2PSmU4HC+do z8fRaWy422GrA== From: "Lorenzo Stoakes (ARM)" Date: Wed, 22 Jul 2026 19:44:43 +0100 Subject: [PATCH] x86/elf: Correct comment for STACK_RND_MASK() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260722-fix-x86-comment-v1-1-605080af988d@kernel.org> X-B4-Tracking: v=1; b=H4sIAJoPYWoC/yXM0QpAQBCF4VfRXJtitUNeRS5Yg1GWdpGSd7e4/ Oqc/wLPTthDGV3g+BAviw1I4wjM2NiBUbpgUImiJFcKeznxLAjNMs9sN2x6ItKZzlLdQXitjsP kK1b1b7+3E5vtzcB9P5iL1JBzAAAA X-Change-ID: 20260722-fix-x86-comment-af666535315d To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Kees Cook , Andi Kleen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1357; i=ljs@kernel.org; h=from:subject:message-id; bh=ISIwp/sXQobVv07RweLH6MaBMg/gxKujXMAO7JcPE94=; b=owGbwMvMwCV2fu7ZrsZH9SKMp9WSGLIS+ecG7n9kZMMuPF3q2tay56W3fi+Xye355F829VIzS /7uyK4/HaUsDGJcDLJiiizPv4jvDxIJm9d5wd8NZg4rE8gQBi5OAZhIy3yGf2Zp2oYuyUuKJPbt 8dotlvZ3W9ffpwd/Hw1rvW946/8er7OMDB8ZFqXFur7a9CGKt+ijiGzquwa7fT0HugMmSU7u+q/ DwAkA X-Developer-Key: i=ljs@kernel.org; a=openpgp; fpr=E7F417BF5214569E89D04F46CF9DCD8A81E27F14 Commit 913bd9060195 ("[PATCH] x86_64: Increase the variability of the process stack on 64bit architectures"), merged in 2006, increased stack randomisation from 8 MiB to an ostensible 1 GiB for 64-bit systems. However the commit actually introduced a mask of 0x3fffff * 4 KiB pages which provides 16 GiB of randomisation, not 1 GiB. It appears Andi perhaps typo'd an additional 'f', as 0x3ffff would indeed provide the stated 1 GiB. Since this value has been in use for 20 years it seems sensible to retain it, so correct the comment instead. Signed-off-by: Lorenzo Stoakes (ARM) Acked-by: SJ Park --- arch/x86/include/asm/elf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/elf.h b/arch/x86/include/asm/elf.h index 0de9df759c99..4133c790e71a 100644 --- a/arch/x86/include/asm/elf.h +++ b/arch/x86/include/asm/elf.h @@ -322,7 +322,7 @@ extern unsigned long get_sigframe_size(void); =20 #else /* CONFIG_X86_32 */ =20 -/* 1GB for 64bit, 8MB for 32bit */ +/* 16GB for 64bit, 8MB for 32bit */ #define __STACK_RND_MASK(is32bit) ((is32bit) ? 0x7ff : 0x3fffff) #define STACK_RND_MASK __STACK_RND_MASK(mmap_is_ia32()) =20 --- base-commit: 248951ddc14de84de3910f9b13f51491a8cd91df change-id: 20260722-fix-x86-comment-af666535315d Cheers, --=20 Lorenzo Stoakes (ARM)