From nobody Fri Jul 24 22:56:49 2026 Received: from mx08-00376f01.pphosted.com (mx08-00376f01.pphosted.com [91.207.212.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 668744D2EEA for ; Wed, 22 Jul 2026 11:27:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.86 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784719637; cv=none; b=kvmntSAWUsuom4HEnIG3zCN+8lqpw+d4vU82URBLQJJDl2/LUOP03erwCzkfnYfBJvVjnOXeMw8UMArPywRmBnfAnJG1CM5LWTYOzGGb3oyEkfUIsCrhrSB6xQk75PwLiPH/nNV7gu7KSLy3AJmZJ8w1sOz6emORH1Nx7EQz390= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784719637; c=relaxed/simple; bh=Svlxwdjc9WGTLG1bXAPMylsnTSI1/i1Gh1bLMyPyUUM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:To:CC; b=ULJUqG+iTYkqJpXXphF/vJQXykOXszmIShedUPvlwtgW6+CFcc5NybuPtQo7wYLX3sLETuJP0Xawxdgi0Y1ciNNAnQExgse8Ic1y8oQHY7xCKI3S/24UnH0pBYaOdyFkVhXKDTrJbMDtonieK2pBeNBURyjgyqfALfHYDNhHz+g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com; spf=pass smtp.mailfrom=imgtec.com; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b=oo0bVt1M; arc=none smtp.client-ip=91.207.212.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=imgtec.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=imgtec.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=imgtec.com header.i=@imgtec.com header.b="oo0bVt1M" Received: from pps.filterd (m0168888.ppops.net [127.0.0.1]) by mx08-00376f01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66M903qg3443431; Wed, 22 Jul 2026 12:26:55 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=imgtec.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=dk201812; bh=pWpXer40vYq0sxg3exnyBDK pp/kqJuoPU9uwrT3v4vI=; b=oo0bVt1M60vxWH1mctj5NuPaWAdvDXFzQPOpPb1 udq1wLuYWsYPNr7ti7+6AD2gVSSIN36utggRHPNrHjTt+nY/KQdIk4EdB/hrkuB+ 0WsJ1W7RA6GW7oOd+FxAsdC7u0doUQhEObVqyx8FDTEcY6DfuLy8a3Y9cPnRVUB2 4n6buX8ygCwl2BBMnc1aiZtU9h2C9r81cBEbubSswCXvUnADCAtKdw99vpU2RQ7x moeos+hRHZF4iSiZXUUuUOvAbOlHFsns9Jak+89XSM83aO9itdgRLlzoXCqDXBOm 1Dpy7fDRKvwNLmNWRm6/KVzDBBDcLbIwaQNOOGWsRU/qtFg== Received: from hhmail01.hh.imgtec.org (83-244-153-141.cust-83.exponential-e.net [83.244.153.141]) by mx08-00376f01.pphosted.com (PPS) with ESMTPS id 4fhmy1hqmq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Jul 2026 12:26:54 +0100 (BST) Received: from [127.0.1.1] (172.25.128.225) by HHMAIL01.hh.imgtec.org (10.100.10.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.43; Wed, 22 Jul 2026 12:26:50 +0100 From: Brajesh Gupta Date: Wed, 22 Jul 2026 16:55:24 +0530 Subject: [PATCH] drm/imagination: Update the trace point pvr_job_submit_fw() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260722-b4-tracepoint-fix-v1-1-f75747fa591a@imgtec.com> X-B4-Tracking: v=1; b=H4sIAKOoYGoC/x2MQQqAIBAAvyJ7bkG3KOor0cF0q72YqEQQ/T3pO AMzD2ROwhkm9UDiS7KcoYJpFLjDhp1RfGUgTb0eiHDtsCTrOJ4SCm5yo97c2Bs/aGo91C4mrvp /zsv7fgyfeU1jAAAA To: Alessio Belle , Luigi Santivetti , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matt Coster , Donald Robson , Alexandru Dadu , Frank Binns CC: , , , Brajesh Gupta X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784719610; l=1997; i=brajesh.gupta@imgtec.com; s=20260417; h=from:subject:message-id; bh=Svlxwdjc9WGTLG1bXAPMylsnTSI1/i1Gh1bLMyPyUUM=; b=UiGIMnuPQTIwVuw09Dc8QmWgqTczl8q53mawlhNJ9eyBgWTBUkVgJzFtzKPb7dPHzj3J2T06k oTRDqVayCuwCPoFxgbrIFyXGkPh0oe83k3B7R+PozTC44xbNQvg4aoa X-Developer-Key: i=brajesh.gupta@imgtec.com; a=ed25519; pk=vDcrSP6vOpWKs914T986xUbB/vY0/cU7mRRb16MRkcg= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIyMDExMCBTYWx0ZWRfX33HD2AJTIwzD ilLx1qvnjsqjbaTWnG8XieDin6ys2fczo83xFjAuoOormzHbId886GXl0KTzo05rzmzrHdbC5No YJQIXDt3qFHwfKGUVf9qC5GIMDqvGlbiByHaXiiDet93HM+FQU38ibxPnOuvMBIlgIciNXRHTzU VkIziu3M+uHHa0vKI1Xql23OWGqEo7mtlnc3PoZQ46wxsqdXjfUwqn/QBThd40JwckKYJ9+fgbf z+Lzid5n0uAl1H54njVoJ56I7KiLKbV7IeVza22FWFrEefNUXl9ck0oTdDkNL+ET2MxmnTnVZiG iGWyxVsSoztQAPYa/dc7gORFNK9r/Ljobn+by+uDhD8+Sd6ei5aGjT9/nbQ/wM4L1Tx9jauGyNy SEO9g0qg6b15+/zslsZc0NkvrGV1269+kqrOV0hVr9ZtAboEKAfld30T4M+XJVylMBrkkV3jXO/ 9QNYQ3Xmi8Q3IZU5gjA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIyMDExMCBTYWx0ZWRfX88tVHmKRKZF7 AZ3PE66LK1/YZl4P1e6mAAA44649X0yqWRFY8LBphTbO7oC3lYKp6vgoBCNL1PnpydAcnE0V4vq Y4onfN587X2Ewqcs+TLrNu8rdEiPcHs= X-Proofpoint-GUID: RBvNLR1qqGHgdKnhEyYBSPBB8qcftXWo X-Authority-Analysis: v=2.4 cv=YIevDxGx c=1 sm=1 tr=0 ts=6a60a8fe cx=c_pps a=AKOq//PuzOIrVTIF9yBwbA==:117 a=AKOq//PuzOIrVTIF9yBwbA==:17 a=HYrZrZQ_E1YA:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=kQ-hrUj2-E3RCbRHssb7:22 a=qZQ2PDNLMSdLoqI-hfl9:22 a=r_1tXGB3AAAA:8 a=YitDbm3_Z1hgSwur4ngA:9 a=QEXdDO2ut3YA:10 a=t8nPyN_e6usw4ciXM-Pk:22 X-Proofpoint-ORIG-GUID: RBvNLR1qqGHgdKnhEyYBSPBB8qcftXWo Trace point pvr_job_submit_fw() is used to trace job submission to the FW. Currently it is recorded when a command is written to the Client circular buffer. Move trace recording after writing command to the Kernel circular buffer to better represent command submission to the FW. Fixes: c1079aebb4de ("drm/imagination: Add support for trace points") Signed-off-by: Brajesh Gupta --- drivers/gpu/drm/imagination/pvr_queue.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imagination/pvr_queue.c b/drivers/gpu/drm/imag= ination/pvr_queue.c index 941c017399fc..d13726401d92 100644 --- a/drivers/gpu/drm/imagination/pvr_queue.c +++ b/drivers/gpu/drm/imagination/pvr_queue.c @@ -726,8 +726,6 @@ static void pvr_queue_submit_job_to_cccb(struct pvr_job= *job) cmd->partial_render_geom_frag_fence.value =3D job->done_fence->seqno - 1; } =20 - trace_pvr_job_submit_fw(job); - /* Submit job to FW */ pvr_cccb_write_command_with_header(cccb, job->fw_ccb_cmd_type, job->cmd_l= en, job->cmd, job->id, job->id); @@ -802,6 +800,9 @@ static struct dma_fence *pvr_queue_run_job(struct drm_s= ched_job *sched_job) job->hwrt, frag_job->fw_ccb_cmd_type =3D=3D ROGUE_FWIF_CCB_CMD_TYPE_FRAG_PR); + + trace_pvr_job_submit_fw(geom_job); + trace_pvr_job_submit_fw(frag_job); } else { struct pvr_queue *queue =3D container_of(job->base.sched, struct pvr_queue, scheduler); @@ -809,6 +810,8 @@ static struct dma_fence *pvr_queue_run_job(struct drm_s= ched_job *sched_job) pvr_cccb_send_kccb_kick(pvr_dev, &queue->cccb, pvr_context_get_fw_addr(job->ctx) + queue->ctx_offset, job->hwrt); + + trace_pvr_job_submit_fw(job); } =20 return dma_fence_get(job->done_fence); --- base-commit: e5320be8a585a9286f231305d0d443d59c24e46c change-id: 20260722-b4-tracepoint-fix-0fc961d7023d Best regards, --=20 Brajesh Gupta