From nobody Sat Jul 25 00:11:03 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4515401A18 for ; Tue, 21 Jul 2026 17:27:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654845; cv=none; b=u5PrTG2FhW5n4p1E3zN38RXtkF9k1B7UqHrZdCUDN0FS6b4X44INPhUuWGiTe6Y15+HiQqSno79708MGqSI03RLxL5u7ozkX9OeC49Bxs54B+xgyOt/P0320CA4NMeXDKQYFAXMG8PuH24A/rRZXmIKpevcmTatTnEHKOXFoecw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654845; c=relaxed/simple; bh=SWocx1zV+cyb7BRIUwblLWB3TOFqoHLH0eZrzF7gFiM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=azOr2+mA9/UgV7Xi9sqqDaGEKkEIUDQ/h/C1hDMxkXxdfrJgcody0auO/ujewRaUzwJxEGqmUY7m3wYv2LbVhpAWA3oe03tkKOIznGsg8CBXUZegu/X7NlyE9bGpwZWY4KNrJE//UYFZ6NNh7A2dTjUNJDcDLgEj3LNpWlJVBPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aQZ5O27l; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aQZ5O27l" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47f707e5d75so1877270f8f.1 for ; Tue, 21 Jul 2026 10:27:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784654842; x=1785259642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=H9I5kwUNdI22d3Rq9mSVERh4Hdo8G6QxFzmLpwrynNI=; b=aQZ5O27l3X2V3zUdpDC1MDbdV+PVKLF2jBh6wN7x8FLkel2M5W6rz6rm8m6rprsN+W SVAVrkY7Se0cpeyoTl4Jnejh2NS5maDF1GMkNUPrj+0BuH0nywCoXctEd8hAdwuPB3gW 2+pp2zJTyChzCWeMbVHxr2ETUTOHibCbCtXRT9+mcZd7wuXIqRjYFf1reusScGsv3/N+ QjtCXgIdH2XrXB9gGorI7pWy5AQ9eLMPNA0rL1EbNai8D7Qbv3cX2SlqlhaRCtvSR/yX f3LFb1p8OLVQtwTYPMD3Ypt5pA+Y6kseyENCyQpZOUioNdV0929tFVv6NEDxOiU6wFpW tSLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784654842; x=1785259642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=H9I5kwUNdI22d3Rq9mSVERh4Hdo8G6QxFzmLpwrynNI=; b=fpBWSkPeQkBPukUGEdefgYYD5Cr9XufC3gHqfSolIoo7M4h5k3nX8Mtu/1p2Ilj8wa iZXmsDqcVt9B7lG9KNshMLsDNHWP4k16ah3lXlATQHP6dvhyNrnE2EEqx8lVUF4CYLv6 koAMTl9EfFAh1kQMALBQh5bJmCjZBBdTXxXd3rpmVLFMiu9aK22QbRpx8K7q5M8K4DLC rgPOtfvnf4IPKv/yuOwgKAFSseI0kUUBLHmNwVSR4sZX+JmpBpoV6+xc3ZKh4pHRkhNN 1HhlHY9QTmnPmbh1cuIU1M+51w+mCCaZjz7w+0PTKsixB0Hh1wTgHCkPEOXsWrMRXEgr KY8Q== X-Forwarded-Encrypted: i=1; AHgh+RpOQ6z+1tH1nmx9I9uJzEdlDBgw4IBoZzFZ4IciRJ5SsQAt6DECDkN5ycP9M4wvtXh/ah9KcMeeUv0vyIo=@vger.kernel.org X-Gm-Message-State: AOJu0YzpA9aPqPbdR+qIXYEuM8aKh/U7JCmwB1R81ug2tW2m5Aocua1y a5NrRyuwJUbraKMrs92S9FiHSZS3VIqgpadsb0qCS8ah8XR1JboPci4e X-Gm-Gg: AfdE7cm0ILR6LlCq0KYvgqVAaeDaG6TgfDxlhRu/U2CYiUzIyzy0CMWV5ofJXExykBU yiAuW0y2zTEMzr+xXgHZkjc3XzMe1NEdmKvHcydvd8M9vQZNKUD1PTIWnxoElb9udI6ZRaFil9C qMRw24sJCjgbWraxBv79T0i1LhHBOi3KTnxzWnw0jnCzggV12VR/+YczOF7b8P1If4opAzT1DMj InvwjwvyecjAA59byIhvb9oDBm7g9jnQD+uGS2uX1IkCsRc+PDf20VDebETjah9CuDtMuU+quJ0 2PG7Z9QgNTqFuZaNoLRcYmTdGj7GlI0JZrYPHiVqeK39yEnuxCJUV1u1lV6y+s8OTIr6f52Tc0w ukY7aBzA5mBi7oT6RrfsrlYTlIk8fucl7GmmAlOcpgiVKIBex2NZCre6U3doYNIiZ6wZC8tagYf fDWZo2CSWa+6a7xYD86TJ9lpl4yoB8uXPYQZkqnxlY0sITUqzO X-Received: by 2002:a05:600c:8284:b0:495:5d6d:d4f7 with SMTP id 5b1f17b1804b1-4955d6dd523mr129158855e9.24.1784654841621; Tue, 21 Jul 2026 10:27:21 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956a4f9a11sm7593595e9.4.2026.07.21.10.27.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 10:27:21 -0700 (PDT) From: Michail Tatas To: michael@amarulasolutions.com, neil.armstrong@linaro.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dianders@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Michail Tatas Subject: [PATCH v3 1/3] drm/panel: ilitek-ili9805: Use _multi variants Date: Tue, 21 Jul 2026 20:27:13 +0300 Message-ID: <20260721172715.602196-2-michail.tatas@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721172715.602196-1-michail.tatas@gmail.com> References: <20260721172715.602196-1-michail.tatas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert functions mipi_dsi_* to mipi_dsi_*_multi as per the gpu/todo file. The multi variant of these functions include improved error handling. Signed-off-by: Michail Tatas Reviewed-by: Neil Armstrong Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 51 +++++--------------- 1 file changed, 13 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/gpu/drm= /panel/panel-ilitek-ili9805.c index e6c483851f1f..7e9587afebbe 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c @@ -159,36 +159,23 @@ static int ili9805_power_off(struct ili9805 *ctx) =20 static int ili9805_activate(struct ili9805 *ctx) { - struct mipi_dsi_device *dsi =3D ctx->dsi; - struct device *dev =3D &dsi->dev; - int i, ret; + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D ctx->dsi }; + int i; =20 for (i =3D 0; i < ctx->desc->init_length; i++) { const struct ili9805_instr *instr =3D &ctx->desc->init[i]; =20 - ret =3D mipi_dsi_dcs_write_buffer(ctx->dsi, instr->data, instr->len); - if (ret < 0) - return ret; + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, instr->data, instr->len); =20 if (instr->delay > 0) - msleep(instr->delay); - } - - ret =3D mipi_dsi_dcs_exit_sleep_mode(ctx->dsi); - if (ret) { - dev_err(dev, "Failed to exit sleep mode (%d)\n", ret); - return ret; + mipi_dsi_msleep(&dsi_ctx, instr->delay); } =20 - usleep_range(5000, 6000); + mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 5000, 6000); + mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); =20 - ret =3D mipi_dsi_dcs_set_display_on(ctx->dsi); - if (ret) { - dev_err(dev, "Failed to set display ON (%d)\n", ret); - return ret; - } - - return 0; + return dsi_ctx.accum_err; } =20 static int ili9805_prepare(struct drm_panel *panel) @@ -211,25 +198,13 @@ static int ili9805_prepare(struct drm_panel *panel) =20 static int ili9805_deactivate(struct ili9805 *ctx) { - struct mipi_dsi_device *dsi =3D ctx->dsi; - struct device *dev =3D &dsi->dev; - int ret; - - ret =3D mipi_dsi_dcs_set_display_off(ctx->dsi); - if (ret < 0) { - dev_err(dev, "Failed to set display OFF (%d)\n", ret); - return ret; - } + struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D ctx->dsi }; =20 - usleep_range(5000, 10000); - - ret =3D mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); - if (ret < 0) { - dev_err(dev, "Failed to enter sleep mode (%d)\n", ret); - return ret; - } + mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); + mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000); + mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); =20 - return 0; + return dsi_ctx.accum_err; } =20 static int ili9805_unprepare(struct drm_panel *panel) --=20 2.43.0 From nobody Sat Jul 25 00:11:03 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01F883F12CE for ; Tue, 21 Jul 2026 17:27:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654847; cv=none; b=jKjlj0fQNhESeUCKjmdTdgZxcjdFv6OQUEVcln6R9eHrkS9KKQp0QoAO6nvNKW2CfwwgrzdpNWFyRzQH93jq+m3z5VH8AFOlKyCqPK8fRlJLNfUu6SSKw0yds/aB2k+pjpeD+V4r79+E6lshOZBwUOvyH32F7XRT+oZpLoQ5Ls8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654847; c=relaxed/simple; bh=I1dTygJQsyoiQv6rFmY4ka4EVu30QRdz61Msub57SYA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oRJOPKNUiugdy4U0j735apEFD8XzEYXG1ufq/pu6cszJcfzQqVAzbszc8H4iacvSFzLw+uwb3/kSyLH0gSbZqyKE0E8SdGtDJO9NBwlzw8SxO/F2ys/Lz+w+7NbzI6G3Iti5gOa6Og29L8p1pdfhFVM+3S+GfTh4Qo6tuo7e3R8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZF9vbn+K; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZF9vbn+K" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4955aa106b1so23982405e9.0 for ; Tue, 21 Jul 2026 10:27:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784654844; x=1785259644; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=IyowS+ZQ7dCHkaNuov8fuCaiCLBVCHZQSxPaLCWmj9E=; b=ZF9vbn+KH+WrdrkDaRmTvjEws31SakVPdB9Th29CrH9GXU1h6t1UFVOHkViJI1QoUe ex1056uLl8+giUyCMhZ6dQiUlrtL807F4uhZnM3vPrgMNPg1C0FLjErpGpBbE+euH9gT xg3QEfOlBjOxDdVbVuUnuBW2GrwIcmrMSxCGY95FBu6GH9/0R3Kr+B2M3QzXj9u3oOGT OvoGInuGlTYmGsmphLifXTLbGir03uliABh6f+wlZC7+jVcB3iN2vaBuTrcD67F90UrP A98MpeOeDXy2WUdJLqDYC13C4chNaaWl0is28AT8h7katVGAWvS2BTIsIn26/kMfHwGb Cu0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784654844; x=1785259644; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=IyowS+ZQ7dCHkaNuov8fuCaiCLBVCHZQSxPaLCWmj9E=; b=C34rlXVmocxOtKKBiRsfczIuaazs/i++s3TpTizwqhDWALaSf8RaaR3XKx0Di04pn7 TopPdzFucOh8uJ8VchI8w2XCuV1K1lozfvzAYGsOyR/KxDOgJz8mZCgd2hSTn5/XfeHN Iu+GOXP55dI3ZhXqcYN0f8FcrwkVm/uYarILZKfzu7ZT6f+DKoy4T5xEwqjWhn1fgQau HcVaLMeeUjPl/BbSS5cbA05Ms+sDRysiOkDSS8LyZqw9j7ZUuXGjzA/txDEhOejpOhvx f1+1XP3w4gGdxhJYBp7T6OyScdnJxDUZ9PXPxTHdZsP9a1SRX3tc4r4TEZkSm3/YKaZ3 b1JQ== X-Forwarded-Encrypted: i=1; AHgh+RqZL8MADXBy//zPBwCgI1mkmD4HwsQkAEuPSrUjoRUq3TY57OC9kiUEeua1cSJpPRuAq3bpy0RxVMRXcng=@vger.kernel.org X-Gm-Message-State: AOJu0YybSXM8C2tLoKa/hTLrs8GbudP9OMwruQlXaHI1Tp8tPwf5QwbJ AmiIsX6dZ3kjv1r6WMwXXp6c3i6ek+ax8ofiDpB1MD2tbMyeMzBONZvZ X-Gm-Gg: AfdE7ckQDOF3+ugMPsePqnHZYB3lGQ+8mJjZ3Mo1SYDUa+Fd5ExHTqz3l7m6yCZlc12 W/Mee22w9o2PgmXDxOodtk7DYe18w3JvhgkiZ1zFQR+OyKLBYiV19SWf0Zy/rmGyG3VDXM09Izx vUK2LqKNw/50Abm3tEXoLOnW6EnsKV3zB0zJEM8D2iq3ED0rppCICHBkaju69r2H7vqms+6MDYX po+TPF5//fWAYm3yHt0iG5r0DNriAxKTdx+At2PNMsa8NqvQz1+V3n168FDrkzXYthcmA+mJJhA ljGEnbmPhj3sfiRBSra1Tu7GzUt56Rzlv/jU0egN3sJ0cyrYgdXthypho/OvYNb1SZRx7yumm8+ 7VZ5sYFgxD7zbNFDKvlOaHPfDbc22p1wWIZNgOMGS8HJ5kLofBRcjjSqSWskPzxJHFVvuIeAReS 4JCmk6dTQsDbL+bUmdBH1svDJki4p1lDNfy+9PtwWPzpM6c1pL X-Received: by 2002:a05:600c:4445:b0:493:f262:b8 with SMTP id 5b1f17b1804b1-4954a3e374cmr209286655e9.1.1784654843942; Tue, 21 Jul 2026 10:27:23 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956a4f24bcsm12215465e9.1.2026.07.21.10.27.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 10:27:23 -0700 (PDT) From: Michail Tatas To: michael@amarulasolutions.com, neil.armstrong@linaro.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dianders@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Michail Tatas Subject: [PATCH v3 2/3] drm/panel: ilitek-ili9805: Use dsi_multi in init Date: Tue, 21 Jul 2026 20:27:14 +0300 Message-ID: <20260721172715.602196-3-michail.tatas@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721172715.602196-1-michail.tatas@gmail.com> References: <20260721172715.602196-1-michail.tatas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop the struct ili9805_instr and the init table and use init functions. Signed-off-by: Michail Tatas Reviewed-by: Neil Armstrong Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 160 +++++++++---------- 1 file changed, 76 insertions(+), 84 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/gpu/drm= /panel/panel-ilitek-ili9805.c index 7e9587afebbe..909661f67d26 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c @@ -25,22 +25,9 @@ #define ILI9805_SETEXTC_PARAMETER2 (0x98) #define ILI9805_SETEXTC_PARAMETER3 (0x05) =20 -#define ILI9805_INSTR(_delay, ...) { \ - .delay =3D (_delay), \ - .len =3D sizeof((u8[]) {__VA_ARGS__}), \ - .data =3D (u8[]){__VA_ARGS__} \ - } - -struct ili9805_instr { - size_t len; - const u8 *data; - u32 delay; -}; - struct ili9805_desc { const char *name; - const struct ili9805_instr *init; - const size_t init_length; + void (*init)(struct mipi_dsi_multi_context *ctx); const struct drm_display_mode *mode; u32 width_mm; u32 height_mm; @@ -56,65 +43,80 @@ struct ili9805 { struct gpio_desc *reset_gpio; }; =20 -static const struct ili9805_instr gpm1780a0_init[] =3D { - ILI9805_INSTR(100, ILI9805_EXTCMD_CMD_SET_ENABLE_REG, ILI9805_SETEXTC_PAR= AMETER1, - ILI9805_SETEXTC_PARAMETER2, ILI9805_SETEXTC_PARAMETER3), - ILI9805_INSTR(100, 0xFD, 0x0F, 0x10, 0x44, 0x00), - ILI9805_INSTR(0, 0xf8, 0x18, 0x02, 0x02, 0x18, 0x02, 0x02, 0x30, 0x00, - 0x00, 0x30, 0x00, 0x00, 0x30, 0x00, 0x00), - ILI9805_INSTR(0, 0xB8, 0x62), - ILI9805_INSTR(0, 0xF1, 0x00), - ILI9805_INSTR(0, 0xF2, 0x00, 0x58, 0x40), - ILI9805_INSTR(0, 0xF3, 0x60, 0x83, 0x04), - ILI9805_INSTR(0, 0xFC, 0x04, 0x0F, 0x01), - ILI9805_INSTR(0, 0xEB, 0x08, 0x0F), - ILI9805_INSTR(0, 0xe0, 0x00, 0x08, 0x0d, 0x0e, 0x0e, 0x0d, 0x0a, 0x08, 0x= 04, - 0x08, 0x0d, 0x0f, 0x0b, 0x1c, 0x14, 0x0a), - ILI9805_INSTR(0, 0xe1, 0x00, 0x08, 0x0d, 0x0e, 0x0e, 0x0d, 0x0a, 0x08, 0x= 04, - 0x08, 0x0d, 0x0f, 0x0b, 0x1c, 0x14, 0x0a), - ILI9805_INSTR(10, 0xc1, 0x13, 0x39, 0x19, 0x06), - ILI9805_INSTR(10, 0xc7, 0xe5), - ILI9805_INSTR(10, 0xB1, 0x00, 0x12, 0x14), - ILI9805_INSTR(10, 0xB4, 0x02), - ILI9805_INSTR(0, 0xBB, 0x14, 0x55), - ILI9805_INSTR(0, MIPI_DCS_SET_ADDRESS_MODE, 0x08), - ILI9805_INSTR(0, MIPI_DCS_SET_PIXEL_FORMAT, 0x77), - ILI9805_INSTR(0, 0x20), - ILI9805_INSTR(0, 0xB0, 0x01), - ILI9805_INSTR(0, 0xB6, 0x31, 0x00, 0xef), - ILI9805_INSTR(0, 0xDF, 0x23), - ILI9805_INSTR(0, 0xB9, 0x02, 0x00), -}; +static void gpm1780a0_init(struct mipi_dsi_multi_context *ctx) +{ + mipi_dsi_dcs_write_seq_multi(ctx, ILI9805_EXTCMD_CMD_SET_ENABLE_REG, + ILI9805_SETEXTC_PARAMETER1, ILI9805_SETEXTC_PARAMETER2, + ILI9805_SETEXTC_PARAMETER3); + mipi_dsi_msleep(ctx, 100); + mipi_dsi_dcs_write_seq_multi(ctx, 0xfd, 0x0f, 0x10, 0x44, 0x00); + mipi_dsi_msleep(ctx, 100); + mipi_dsi_dcs_write_seq_multi(ctx, 0xf8, 0x18, 0x02, 0x02, 0x18, 0x02, 0x0= 2, 0x30, 0x00, + 0x00, 0x30, 0x00, 0x00, 0x30, 0x00, 0x00); + mipi_dsi_dcs_write_seq_multi(ctx, 0xb8, 0x62); + mipi_dsi_dcs_write_seq_multi(ctx, 0xf1, 0x00); + mipi_dsi_dcs_write_seq_multi(ctx, 0xf2, 0x00, 0x58, 0x40); + mipi_dsi_dcs_write_seq_multi(ctx, 0xf3, 0x60, 0x83, 0x04); + mipi_dsi_dcs_write_seq_multi(ctx, 0xfc, 0x04, 0x0f, 0x01); + mipi_dsi_dcs_write_seq_multi(ctx, 0xeb, 0x08, 0x0f); + mipi_dsi_dcs_write_seq_multi(ctx, 0xe0, 0x00, 0x08, 0x0d, 0x0e, 0x0e, 0x0= d, 0x0a, 0x08, + 0x04, 0x08, 0x0d, 0x0f, 0x0b, 0x1c, 0x14, 0x0a); + mipi_dsi_dcs_write_seq_multi(ctx, 0xe1, 0x00, 0x08, 0x0d, 0x0e, 0x0e, 0x0= d, 0x0a, 0x08, + 0x04, 0x08, 0x0d, 0x0f, 0x0b, 0x1c, 0x14, 0x0a); + mipi_dsi_dcs_write_seq_multi(ctx, 0xc1, 0x13, 0x39, 0x19, 0x06); + mipi_dsi_msleep(ctx, 10); + mipi_dsi_dcs_write_seq_multi(ctx, 0xc7, 0xe5); + mipi_dsi_msleep(ctx, 10); + mipi_dsi_dcs_write_seq_multi(ctx, 0xb1, 0x00, 0x12, 0x14); + mipi_dsi_msleep(ctx, 10); + mipi_dsi_dcs_write_seq_multi(ctx, 0xb4, 0x02); + mipi_dsi_msleep(ctx, 10); + mipi_dsi_dcs_write_seq_multi(ctx, 0xbb, 0x14, 0x55); + mipi_dsi_dcs_write_seq_multi(ctx, MIPI_DCS_SET_ADDRESS_MODE, 0x08); + mipi_dsi_dcs_write_seq_multi(ctx, MIPI_DCS_SET_PIXEL_FORMAT, 0x77); + mipi_dsi_dcs_write_seq_multi(ctx, 0x20); + mipi_dsi_dcs_write_seq_multi(ctx, 0xb0, 0x01); + mipi_dsi_dcs_write_seq_multi(ctx, 0xb6, 0x31, 0x00, 0xef); + mipi_dsi_dcs_write_seq_multi(ctx, 0xdf, 0x23); + mipi_dsi_dcs_write_seq_multi(ctx, 0xb9, 0x02, 0x00); +} =20 -static const struct ili9805_instr tm041xdhg01_init[] =3D { - ILI9805_INSTR(100, ILI9805_EXTCMD_CMD_SET_ENABLE_REG, ILI9805_SETEXTC_PAR= AMETER1, - ILI9805_SETEXTC_PARAMETER2, ILI9805_SETEXTC_PARAMETER3), - ILI9805_INSTR(100, 0xFD, 0x0F, 0x13, 0x44, 0x00), - ILI9805_INSTR(0, 0xf8, 0x18, 0x02, 0x02, 0x18, 0x02, 0x02, 0x30, 0x01, - 0x01, 0x30, 0x01, 0x01, 0x30, 0x01, 0x01), - ILI9805_INSTR(0, 0xB8, 0x74), - ILI9805_INSTR(0, 0xF1, 0x00), - ILI9805_INSTR(0, 0xF2, 0x00, 0x58, 0x40), - ILI9805_INSTR(0, 0xFC, 0x04, 0x0F, 0x01), - ILI9805_INSTR(0, 0xEB, 0x08, 0x0F), - ILI9805_INSTR(0, 0xe0, 0x01, 0x0d, 0x15, 0x0e, 0x0f, 0x0f, 0x0b, 0x08, 0x= 04, - 0x07, 0x0a, 0x0d, 0x0c, 0x15, 0x0f, 0x08), - ILI9805_INSTR(0, 0xe1, 0x01, 0x0d, 0x15, 0x0e, 0x0f, 0x0f, 0x0b, 0x08, 0x= 04, - 0x07, 0x0a, 0x0d, 0x0c, 0x15, 0x0f, 0x08), - ILI9805_INSTR(10, 0xc1, 0x15, 0x03, 0x03, 0x31), - ILI9805_INSTR(10, 0xB1, 0x00, 0x12, 0x14), - ILI9805_INSTR(10, 0xB4, 0x02), - ILI9805_INSTR(0, 0xBB, 0x14, 0x55), - ILI9805_INSTR(0, MIPI_DCS_SET_ADDRESS_MODE, 0x0a), - ILI9805_INSTR(0, MIPI_DCS_SET_PIXEL_FORMAT, 0x77), - ILI9805_INSTR(0, 0x20), - ILI9805_INSTR(0, 0xB0, 0x00), - ILI9805_INSTR(0, 0xB6, 0x01), - ILI9805_INSTR(0, 0xc2, 0x11), - ILI9805_INSTR(0, 0x51, 0xFF), - ILI9805_INSTR(0, 0x53, 0x24), - ILI9805_INSTR(0, 0x55, 0x00), -}; +static void tm041xdhg01_init(struct mipi_dsi_multi_context *ctx) +{ + mipi_dsi_dcs_write_seq_multi(ctx, ILI9805_EXTCMD_CMD_SET_ENABLE_REG, + ILI9805_SETEXTC_PARAMETER1, ILI9805_SETEXTC_PARAMETER2, + ILI9805_SETEXTC_PARAMETER3); + mipi_dsi_msleep(ctx, 100); + mipi_dsi_dcs_write_seq_multi(ctx, 0xfd, 0x0f, 0x13, 0x44, 0x00); + mipi_dsi_msleep(ctx, 100); + mipi_dsi_dcs_write_seq_multi(ctx, 0xf8, 0x18, 0x02, 0x02, 0x18, 0x02, 0x0= 2, 0x30, 0x01, + 0x01, 0x30, 0x01, 0x01, 0x30, 0x01, 0x01); + mipi_dsi_dcs_write_seq_multi(ctx, 0xb8, 0x74); + mipi_dsi_dcs_write_seq_multi(ctx, 0xf1, 0x00); + mipi_dsi_dcs_write_seq_multi(ctx, 0xf2, 0x00, 0x58, 0x40); + mipi_dsi_dcs_write_seq_multi(ctx, 0xfc, 0x04, 0x0f, 0x01); + mipi_dsi_dcs_write_seq_multi(ctx, 0xeb, 0x08, 0x0f); + mipi_dsi_dcs_write_seq_multi(ctx, 0xe0, 0x01, 0x0d, 0x15, 0x0e, 0x0f, 0x0= f, 0x0b, 0x08, + 0x04, 0x07, 0x0a, 0x0d, 0x0c, 0x15, 0x0f, 0x08); + mipi_dsi_dcs_write_seq_multi(ctx, 0xe1, 0x01, 0x0d, 0x15, 0x0e, 0x0f, 0x0= f, 0x0b, 0x08, + 0x04, 0x07, 0x0a, 0x0d, 0x0c, 0x15, 0x0f, 0x08); + mipi_dsi_dcs_write_seq_multi(ctx, 0xc1, 0x15, 0x03, 0x03, 0x31); + mipi_dsi_msleep(ctx, 10); + mipi_dsi_dcs_write_seq_multi(ctx, 0xb1, 0x00, 0x12, 0x14); + mipi_dsi_msleep(ctx, 10); + mipi_dsi_dcs_write_seq_multi(ctx, 0xb4, 0x02); + mipi_dsi_msleep(ctx, 10); + mipi_dsi_dcs_write_seq_multi(ctx, 0xbb, 0x14, 0x55); + mipi_dsi_dcs_write_seq_multi(ctx, MIPI_DCS_SET_ADDRESS_MODE, 0x0a); + mipi_dsi_dcs_write_seq_multi(ctx, MIPI_DCS_SET_PIXEL_FORMAT, 0x77); + mipi_dsi_dcs_write_seq_multi(ctx, 0x20); + mipi_dsi_dcs_write_seq_multi(ctx, 0xb0, 0x00); + mipi_dsi_dcs_write_seq_multi(ctx, 0xb6, 0x01); + mipi_dsi_dcs_write_seq_multi(ctx, 0xc2, 0x11); + mipi_dsi_dcs_write_seq_multi(ctx, 0x51, 0xff); + mipi_dsi_dcs_write_seq_multi(ctx, 0x53, 0x24); + mipi_dsi_dcs_write_seq_multi(ctx, 0x55, 0x00); +} =20 static inline struct ili9805 *panel_to_ili9805(struct drm_panel *panel) { @@ -160,16 +162,8 @@ static int ili9805_power_off(struct ili9805 *ctx) static int ili9805_activate(struct ili9805 *ctx) { struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D ctx->dsi }; - int i; =20 - for (i =3D 0; i < ctx->desc->init_length; i++) { - const struct ili9805_instr *instr =3D &ctx->desc->init[i]; - - mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, instr->data, instr->len); - - if (instr->delay > 0) - mipi_dsi_msleep(&dsi_ctx, instr->delay); - } + ctx->desc->init(&dsi_ctx); =20 mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); mipi_dsi_usleep_range(&dsi_ctx, 5000, 6000); @@ -246,7 +240,7 @@ static const struct drm_display_mode tm041xdhg01_timing= =3D { }; =20 static int ili9805_get_modes(struct drm_panel *panel, - struct drm_connector *connector) + struct drm_connector *connector) { struct ili9805 *ctx =3D panel_to_ili9805(panel); struct drm_display_mode *mode; @@ -343,7 +337,6 @@ static void ili9805_dsi_remove(struct mipi_dsi_device *= dsi) =20 static const struct ili9805_desc gpm1780a0_desc =3D { .init =3D gpm1780a0_init, - .init_length =3D ARRAY_SIZE(gpm1780a0_init), .mode =3D &gpm1780a0_timing, .width_mm =3D 65, .height_mm =3D 65, @@ -351,7 +344,6 @@ static const struct ili9805_desc gpm1780a0_desc =3D { =20 static const struct ili9805_desc tm041xdhg01_desc =3D { .init =3D tm041xdhg01_init, - .init_length =3D ARRAY_SIZE(tm041xdhg01_init), .mode =3D &tm041xdhg01_timing, .width_mm =3D 42, .height_mm =3D 96, --=20 2.43.0 From nobody Sat Jul 25 00:11:03 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86786401A18 for ; Tue, 21 Jul 2026 17:27:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654849; cv=none; b=k2IUruDfDQH0bMZXaZfU312XN+An+nIIZ/ciQjXTc0k/7c/TZRLPCWlSwhzlBV+4baallOayXxx5UGk5Iq4dxqD/FVsPGSugK0BcNX011sU3khqWHVbu90tJLmZJioKsmI9DNbgFDDkGSfJIv0HNgYUkgNtRtYfmq6ebf3pdAxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784654849; c=relaxed/simple; bh=Osy/WzortmaPeFtWp8zjS+6Bs7ZhTUIJF6Y8tCnluT0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Mft/NMP6Bm0CPTX7U45wpqnufdFoNFBLYHqTE8Y04w92cVw0USitOLtQDLb1mu71WwIt6v8ua+Yp+CzEPB2QfXeIgQs7CZH489lolDzTiR44fV69UUZa1FshV/1NHfijwkfKAFduj6SWqFM8wIK+9t4IkLkEUpKahvcd7EFZHMw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NwUjrCHA; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NwUjrCHA" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-49548aebcd8so29984805e9.3 for ; Tue, 21 Jul 2026 10:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784654847; x=1785259647; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JLzCAfsGEIgUcEbUqrqY0ww6cKzEJHPvtWy4z538qTk=; b=NwUjrCHA39mQaznV+/l5Hrard2ahoGrdiCU3IOhircR7R1MzoocD7AJ/TO4QbkgZjS 6odLzMsnno9mTZJA1OjRqLPxcDHgHFs8dqx2ZNq6lBQMJBYsMHETyeJF8oBJFzSrNuXc pU+8eYZAj5lIlp0O8dtvfybjgVY7dhZtItJopDXv8jGosEgIoklT2fIQd+JH09iVuPQP H3K19OSZ/L/SbW+EQ9WXdsAE5EnuMmyj4E2Fd/9Q2NCYX3QFdOn6IvzPpC/uJ2LV5X8Z Zd18wY5MMtJb3xLj9T+ejnB//1EK2RPBOvmLJqJX0+F72Mhkg6+KxMj39MLiAtro49Cu gdOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784654847; x=1785259647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JLzCAfsGEIgUcEbUqrqY0ww6cKzEJHPvtWy4z538qTk=; b=YyNJvclBMIkeyLRpfiZVLGy6Qi/yS0whVY3LIeHi7FfQauFEehpY0/5AQ3dtzUzQgC tlyayc7+2DvC551HbbfAq8MvjI+zP7DV/doJL+zhylqwbcn99vxyLUi3kfpBwFtOI81m OGQdDLaOl3vzctZKFmlwZSst1oZi705onDMu48AZMfDiywzPXKmxb5FFfmz/M3Vc4/KL EhX9vkSA4nsieH2unEMqtGCMvmzox7nCnK+rCXUmBo/E+wACVdypdabyHjRGa4Iy0OtN 2J1auUIVkJm/Uxzd4pzC+PPxkzvspay0nEE79FlEgDK6kYXwI/GHEmOFn+vW+7918HWB 2z6Q== X-Forwarded-Encrypted: i=1; AHgh+Rr4Vv9F9JzyFZKADuQivkA+Ofx0gBapAkxtNCMOUwxjokyk1Vq9svktUV3FtbakqjfZ3hIZCoAJF68kJx0=@vger.kernel.org X-Gm-Message-State: AOJu0YzJbluPTVcXqDY7CgpkUM0ixQjSi7bBZ9esTqrMKCQXaQCjMK8m 1TtzpLGSuVN8olXXSR+K7F0V0ecbn4bPHy/8PUhlPhXNlPMFdC2cnbjRjkmabA== X-Gm-Gg: AfdE7cmVmRrGeR1mR+c08ZozN7AP08dVzbmXbZiXmOLtjn9pwPd9t4tk6jBCtn8RXL9 DDNaHV1jigt/P+Ar6W+tU8vsyBYydec8NjaFKkz+Q+2rmzXAWFPeS6y4qruoNdmsC+wNl7wlIT4 1hGjSlFdmYJJZKNi/qhdD/ogvOXrob4q4bCfHDCyCCSGoRAeFsZQ6IjjeuDjt5+NpAyq6pTR2Fj Cf6Bp0dqSCMvwGQIjGdL9QocSXce6jN4HAmHZOm3ujW8lS10yELsIz6ejiLRBVhWadpjhjcSI7z qa1bZMegN0il0Q9/qxxiIGvJdulRgn+LXsSaMcNOaGQt/+HXmleU7TupfjOyZhnZ5r6isdHYEgJ R06DPB9Kmv7P8F7ITdlbjZcbnBMiHqIU/F72yjfYK5A+Qv5YlXUdX/frTIdndJuM3cUGUOWJJnH asZlfEuUaqu6NcrLZnbwVyp9SkdhmhSWsxC52+h2h/SMZiAmPv X-Received: by 2002:a05:600c:3112:b0:495:472c:208d with SMTP id 5b1f17b1804b1-4954a41307cmr206826185e9.38.1784654846553; Tue, 21 Jul 2026 10:27:26 -0700 (PDT) Received: from michalis-linux (adsl-75.176.58.251.tellas.gr. [176.58.251.75]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63e49500sm43027137f8f.2.2026.07.21.10.27.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 10:27:26 -0700 (PDT) From: Michail Tatas To: michael@amarulasolutions.com, neil.armstrong@linaro.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dianders@chromium.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Michail Tatas Subject: [PATCH v3 3/3] drm/panel: ilitek-ili9805: make cleanup funcs void Date: Tue, 21 Jul 2026 20:27:15 +0300 Message-ID: <20260721172715.602196-4-michail.tatas@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721172715.602196-1-michail.tatas@gmail.com> References: <20260721172715.602196-1-michail.tatas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Make cleanup functions return void since no one is checking their return values Signed-off-by: Michail Tatas Reviewed-by: Neil Armstrong Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-ilitek-ili9805.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c b/drivers/gpu/drm= /panel/panel-ilitek-ili9805.c index 909661f67d26..a8d501be3e9b 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9805.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9805.c @@ -150,13 +150,11 @@ static int ili9805_power_on(struct ili9805 *ctx) return 0; } =20 -static int ili9805_power_off(struct ili9805 *ctx) +static void ili9805_power_off(struct ili9805 *ctx) { gpiod_set_value(ctx->reset_gpio, 0); regulator_disable(ctx->dvdd); regulator_disable(ctx->avdd); - - return 0; } =20 static int ili9805_activate(struct ili9805 *ctx) @@ -190,15 +188,13 @@ static int ili9805_prepare(struct drm_panel *panel) return 0; } =20 -static int ili9805_deactivate(struct ili9805 *ctx) +static void ili9805_deactivate(struct ili9805 *ctx) { struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D ctx->dsi }; =20 mipi_dsi_dcs_set_display_off_multi(&dsi_ctx); mipi_dsi_usleep_range(&dsi_ctx, 5000, 10000); mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx); - - return dsi_ctx.accum_err; } =20 static int ili9805_unprepare(struct drm_panel *panel) --=20 2.43.0