From nobody Sat Jul 25 00:10:55 2026 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86F9F46D579 for ; Tue, 21 Jul 2026 16:07:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784650055; cv=none; b=njcoJzEAUbHQLrzZYRN0pkhAdNwoo2/TqklrylC2SeQ5UrtZs916ORHBYfQsI8NHyvqs8rmj6kqY8ONHdxiCTGRDFRPtjJzjle0nlSszFuStColaeSxHfkmoTR+dxXKav0EAaIgi0GFPl8OzPm0h7Dichtw2DduJlajNOv2pJpQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784650055; c=relaxed/simple; bh=LKiBtk8t9+PWD5595iIkKaCbgIxDrNhX1two6J10epA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=QLkB26w3K95KejFJWifAv5HYXcMHSFyrhSyhBeczOBn32fpmIFryTQipOqK7n/1s3s1Pr8DU5Ij6ws6u7ywXmgqCDCXNI2xCgrcQEsJD4WupQhAmqTmdhXbrX18VgVf/cV5MRiRm6lLtP/QCnnFqzDzq3cBJty1mCfg5BUWwb7c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mc0N526t; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mc0N526t" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-848479c9bd5so5374500b3a.3 for ; Tue, 21 Jul 2026 09:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784650054; x=1785254854; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=f9/QfEhkjBILio+lgT24Y9aK+Mw9oxGGyofW64Y99NU=; b=mc0N526tMNVY0qjmUyD5yuQG3zXI6NXu8Xx8vw3rp7H3tp4KADYrlS+skYKnh+dUPd QceLUjIM3MDLBcDVkcK9D41sPQ/KYPKyHtGYI48vB0NwuQRy3gMBw5D9pUYtsKCI3mp3 P2YIa6BvKUIBq9hBkL5GEQJGpyKY+YAMVEyeVTHoD6h3rWre57pFwBa+1nZn9Jvttvh1 ulXmLz4GZ18YpIIYP7rc9GAIQhKbVXHshNLEsxhH4iGdXXAWpeQHJzO0gpidSRmdxh2I u+QUjntyhjsDqYvL3A/zM4ypVfHgJLVwfqiUAjvxj3IhaV1g+MEMUxTs87cNaw2j3hoL xdJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784650054; x=1785254854; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=f9/QfEhkjBILio+lgT24Y9aK+Mw9oxGGyofW64Y99NU=; b=l06GwwIRhXMAUCm2/BFckw77J42he4M4BLg64dV3yLfbBAGpsWlgvYeU1V+S0YeP+A t5bveqWsLs/o73di2VsEfUp3spYL/CjortibsxqIAT1Hnvy5iTvih+3RFfIsovDpgXjC tfB00mpTNg5xI3MS6iSbh1ra0eMhFIALnsYr1ZKM0cLoa7UyFC9H5fy+YJOZJ97C+13O tqMaCFtlRlHuC+zzEMo04jtSH51l26q+DlBdf0e8oCCWrsOlfxt8BxFh01fGXKVbPTgF +kw8U1vnfk8L0Er00RwHJpbnfARwEwAW9PtXcyI5h6KETG2Kwim6dl1M6+ELfvmPWVvx NASQ== X-Forwarded-Encrypted: i=1; AHgh+RpLC/e8bEnJ6g9XXoa1WwVkA6TCDU2FarTAtdByfu8Ytp4lUv/JHGH4ByXDPRqlWKuCiNpjpo4CdRU/iqE=@vger.kernel.org X-Gm-Message-State: AOJu0YzHzn0yuIpfetYMj1DOha1UnL5RxPU2ovhIZTh7qEt5LHKVz85m PjZzzMhq9eg9G+esWs+NbB7s69Kimk6vCWg70OM5bpk1WLmC/QyhWfQJ X-Gm-Gg: AR+sD10vNL8xFTdDlxCrfYiHP73A5hQjn3iIVvjYxBoTr3X9YNgg0p6YVRFctZrjOwj Y7S1NszCIkDowTRLWViXUslF+bK5b8lhmNnxfxY6RzEKiildIt91D02dka3EZs0+Q87z2Eyv6PB 3FqTJR7joHo0+m+/AXmcHqaI7Kv501/q4JC7Sr5nP29c5Wlh+lUwteLN+SNBhtpHBeKQkKq7OFf ei/cMHh7JKQSfe5wlHEy348ndKxB971b9JORDm31c6F5Lg2go9R+iW2UkpgbqR+i8215WoHAkny /FfEAchIopnDu9NJoBFbu7UqKHO7GtTD4MEReEL8AMogOB78MCLtz0h2Dq0lvUQi2pOxMeIrstT ULs/R06E7LQPxOpzsjp7FOfL/bbAThPSSDpFR7PUGObKaSBL7gNwaIcVqgjBI5aDWMXpYMOfzK+ eIhXdftHrxJbcqK4Blly736W2Z5WARYGxRr03Dq4NMn4aWTgNYV04fwQ== X-Received: by 2002:a05:6a00:1382:b0:84a:2ec8:fca6 with SMTP id d2e1a72fcca58-84c29494781mr19243421b3a.52.1784650053640; Tue, 21 Jul 2026 09:07:33 -0700 (PDT) Received: from colten.. (61-227-26-231.dynamic-ip.hinet.net. [61.227.26.231]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2af6ea1csm7841747b3a.49.2026.07.21.09.07.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 09:07:33 -0700 (PDT) From: ColtenOuO To: Greg Kroah-Hartman Cc: ColtenOuO , Hans de Goede , Michael Straube , Nikolay Kulikov , Andrei Khomenkov , Jennifer Guo , Minu Jin , Khasar Munkh-Erdene <02khasar@gmail.com>, Mohammed Rizwan Kaniyate , linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] staging: rtl8723bs: remove unnecessary else after break/return Date: Tue, 21 Jul 2026 16:02:32 +0000 Message-ID: <20260721160236.80963-1-jun930436@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" checkpatch.pl flags an else clause following a branch that already returns, in enqueue_reorder_recvframe(). Restructure the if/else-if/else chain into sequential checks to remove the redundant else, with no change in behavior. Signed-off-by: ColtenOuO --- drivers/staging/rtl8723bs/core/rtw_recv.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rt= l8723bs/core/rtw_recv.c index 86c5e2c4e7dd..79bd56a5d6cd 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -1783,14 +1783,12 @@ static int enqueue_reorder_recvframe(struct recv_re= order_ctrl *preorder_ctrl, un pnextrframe =3D (union recv_frame *)plist; pnextattrib =3D &pnextrframe->u.hdr.attrib; =20 - if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num)) - plist =3D get_next(plist); - else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num)) + if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num)) /* Duplicate entry is found!! Do not insert current entry. */ - /* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */ return false; - else + if (!SN_LESS(pnextattrib->seq_num, pattrib->seq_num)) break; + plist =3D get_next(plist); } =20 /* spin_lock_irqsave(&ppending_recvframe_queue->lock, irql); */ --=20 2.43.0