From nobody Sat Jul 25 00:41:54 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F3803FB072 for ; Tue, 21 Jul 2026 14:41:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784644916; cv=none; b=GwaldKRdiN5LOtKj6aPXQd72MjdhxiHw2ia3jV9xMITj95PcFEuWo6DQDeL3rYx4lVShk9ppP+uT+MVTTRPQjdS+6tTd7tKrgD1uzlk7/9XH7W+t6jIJIka1MoDTFgUu/7uC5j3oRBJQC9N3BBnNiqVj04lCgIzvaWaijwVQPzY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784644916; c=relaxed/simple; bh=4/VXWgsIRIKfrVHunlg8WMDRE+QLI3xVo05RjJxnkwE=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Ucca0n3MlIUf/oerEWnLf46zPy92ll5jePLr+zSpa/0acrb86naxhY7wnfd81EMxh0D2b9/APOaZzG6zIj58BRNoQnph6z5RJl+Apj7DLlTMUjAfC0YOqui+13OQCW+SY+QLPi1y+ZiJp80M4SW7M3MWs3tWjnvHALvRVN7b68Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=V5D+ev3T; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="V5D+ev3T" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-845c92bc464so7087739b3a.2 for ; Tue, 21 Jul 2026 07:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784644915; x=1785249715; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YAwfc5iFE/E+WtAWO7/fCyQvb8Oo2HFdE/v5P8GpI9A=; b=V5D+ev3TFS8adlNMISbPmTPOjrVQBd7yQhzN4yxinPOadXIxMCv5AeOUElfaXhbKmO D5m7JyDpEitvl2WRi+7LlkgFnlwfod8o59F54Z1osD04+55+El5dGw31h3LoKZzT83Xq /B9iXPj99a6G215x8ZTDoTBDlA+gW778IypZ0wK0rkZD8CX6cOls5VkntaEAk4ynzmvq V4Yas/Xm3uv7fIZoO5Q4MWzJ6o6ESBS/RFgNlrC56tzmo4IWHSvq9DHsa3CCstdWiDwC PTK/3ZZqeYUPKBBRx4gtb3HtOZ1FnTr5ZJzShL1qpSleTiwmEAI3jRTyaVkQw8gXsGdC 4law== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784644915; x=1785249715; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YAwfc5iFE/E+WtAWO7/fCyQvb8Oo2HFdE/v5P8GpI9A=; b=rcnbCw08wEpYO4F1+ExGew7gYs65MWPdgAB30rQy2hZV9SJn5sKF/YwUr8mc6QsQh/ gV1STqNS/y2zXhXQb7EPhwer12OU32bXk6dOI0a6Ba8DZl/4e9lHhXDwgCxrHEsvRxy7 EvxSYQ6C3veJTqYQLJPooo9JZ/7CLzo93rYzvw5w4xvjSvyWcWstksRIrpL7JeV7shC1 r7tkOb/yjuLt7gHJoXHgSiO9SeKnoAjEOeopAihie9SWFhKIv32+wku6ULgOpJeHru6S PHKK8mTp4JLTl7z/HnUxU9qXNNhXmEZmxg7kLN9XBIyu4zCfKHuMP6SAlGYBdZbw7oGh x/Ew== X-Forwarded-Encrypted: i=1; AHgh+RpasfEZ581WusB68XmTJl/PMTLiT8qNKii3E2jLcOT/sIavxtc9JP7huQ+YS6sQakxJRZwWs79BMLg89yQ=@vger.kernel.org X-Gm-Message-State: AOJu0Ywtwlr6rYogj9Rvs+LFcHmUid9ggYlyceBgYEck/nq7arY2cNOo i4VD3s33iukV61NYFw2/uwgm4JBSRDOQ89PRl6b4aZjY5EqrVIKt0G0= X-Gm-Gg: AR+sD13dm8vUsglxgtDea/UlpT2LxdcVNoAkxE6fXI0/XOMFlzeqdcnyBS/Vj/fQmS5 MOamnMzacY/l+y/ZqeD6CDRwxfaRQG4UHsAcjgDTO+uFbHzfDxc8NXkRYh2rV5UHNzERH686AD5 Zt7+jHElZmI6iHg9q4y3UmGyqvqL45kquQgL72+modeYA1tuTSsDXlxDDc84q4uEo/X3UbPyI// kTh3OqJ62YoqzUY0UqB6WWS4Bg24ySpVn62sbrJuRqDSJuDpoGfzfIwsIMANHtce1MGOnDKw2LS KEUz4P+FjI3ZPgXPuzBUnju4VpyDVvZvMOoK475Yk+Vso0mGf0wSb806Eha4oGkD+9S6OfG6/2F zOAWWr21uY7BuCPOXUvexZqrs7Y9Rwe5w5NdIdCl0QIRHzOTQ99EoOK/IRAEJUkP7d7d3Iw9r4+ W8Xe0pbwKpR9Gqibs0iOkbP0AkWJ7e7ts5Gp4QcKR3iNV5d+pLVjK9H0YD6auwdbVg8olsLRdFR LYNoG8sqcbw388Y6WLWxwVkmeZDWea/bccCI6ik X-Received: by 2002:a05:6a00:1c82:b0:845:c6fc:2821 with SMTP id d2e1a72fcca58-84c292a3dc9mr19309918b3a.22.1784644914563; Tue, 21 Jul 2026 07:41:54 -0700 (PDT) Received: from localhost.localdomain ([14.5.152.27]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2adcc78asm7649075b3a.23.2026.07.21.07.41.51 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 21 Jul 2026 07:41:53 -0700 (PDT) From: Myeonghun Pak To: Andi Shyti Cc: Elie Morisse , Shyam Sundar S K , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] i2c: amd-mp2: Unregister callback on adapter add failure Date: Tue, 21 Jul 2026 23:41:47 +0900 Message-Id: <20260721144147.31150-1-mhun512@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" amd_mp2_register_cb() stores the platform I2C context in the MP2 PCI driver's callback table before the adapter is registered. If i2c_add_adapter() fails, probe returns and devres frees the context, but the PCI driver can still dereference the stale pointer from its IRQ and system-sleep callbacks. Unregister the callback before returning the adapter registration error. Fixes: 529766e0a011 ("i2c: Add drivers for the AMD PCIe MP2 I2C controller") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/i2c/busses/i2c-amd-mp2-plat.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-amd-mp2-plat.c b/drivers/i2c/busses/i2c= -amd-mp2-plat.c index 188e24cc4d..9fdd6a5fb8 100644 --- a/drivers/i2c/busses/i2c-amd-mp2-plat.c +++ b/drivers/i2c/busses/i2c-amd-mp2-plat.c @@ -316,8 +316,10 @@ static int i2c_amd_probe(struct platform_device *pdev) =20 amd_mp2_pm_runtime_put(mp2_dev); =20 - if (ret < 0) + if (ret < 0) { dev_err(&pdev->dev, "i2c add adapter failed =3D %d\n", ret); + amd_mp2_unregister_cb(&i2c_dev->common); + } =20 return ret; } --=20 2.47.1