From nobody Sat Jul 25 00:52:55 2026 Received: from mail-wm2-f10.google.com (mail-wm2-f10.google.com [74.125.225.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACAC232C302 for ; Tue, 21 Jul 2026 13:16:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.138 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784639766; cv=none; b=Mo2r5Vwx6BOMtF72LJqvp85O/c/q45KQEVu371I9sACLEb1BN6510A4nnEsQ4QrUrUSHVVwX8ZdWu6X5Sp9XneWHs8YfABMRpkrx6s+9Jqw3cJ2n4N7fecN30bmfHS9lXD6f8TxIVEhx0inUtPl5McsnfakLvKMAu37XBF3Fguc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784639766; c=relaxed/simple; bh=ShlZ5obsck/3HU07BN59h2dm0lLPILvV9svgtTgtavw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tPav5Lx2YSPqFMDQtEceP3EXBdVDH8jlUukSfleyzTpDPM1DudZgdMV1ExCHWzrLpCctyYzVVU6QhXdD3Xo6spsudHh8ufGT3PJsbV8+Pfk/ltCsJDLF0HSok1OyRLvBDT5HSMjiphmhuHYKp4QoTLu3uZCrnyxGkLRpcUQDUqQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VqyPuBLC; arc=none smtp.client-ip=74.125.225.138 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VqyPuBLC" Received: by mail-wm2-f10.google.com with SMTP id 5b1f17b1804b1-495459712d2so13279065e9.1 for ; Tue, 21 Jul 2026 06:16:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784639763; x=1785244563; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xYmx6dayCLYwlqwxf5du5VlxFHj5ZAoU7EJ7K2Lsb+c=; b=VqyPuBLCC3Isi9e4gGIeBTChPXTarQeYPoUKuV5msIxwhFo93ShB0S73rHfGkGHObf BAQ+9bxttN/NfwfjBtGLduUca0gohJpWBa626rD7Nv5CcUQ0xr4dtj2YifL6V0NJErfx GKFJ+hCxFWIGBpxwmGe8SdFEy1qgKCdNHVi12RMw/KUmbOSUwQSTXX48PcPQO2c1DOFo qssXzwEeT7bFcVgjoqcvP0dOzRcMqDaxKZo+vBSp39ew5aACdLROZ/zbpkwavZUGJE9P aBbsvwz+kwaswe5devxo/YmkihoTRGY26bMmloAQ389T0ISC2JEUTI5cwx2r5jACzPcL 617g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784639763; x=1785244563; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xYmx6dayCLYwlqwxf5du5VlxFHj5ZAoU7EJ7K2Lsb+c=; b=XAqqeHT87VVwnztatBsBC7J6XZ9iRSifabmQq6FwZmB+Dlpi48MaOXCpfb89wM0Gor QT3axFhcO2cqrJwuWhhrmhKQoSt5r9AIpcKNIs9yA4H5fUQbm/G4wmi1u3sMrXeghLWS CTPoamCLpcOdfghSuTptil1k1n7JDgcOJWKeWIkdERUnM7nf4fQT2nxdiQ//EWI9hO9s 12smF9zGiwhqRVul1celj9c7lCORNknQFEBM/tPu/wrhLN/9oDebx+OeWMYao2Za14tl IxQsmmanfQx/MlkqFOb+hZgrUl/swyHVaq/V+tlHtKGsnmnzzdukXXNCe8lwzi97jm2x aX1Q== X-Forwarded-Encrypted: i=1; AHgh+RoN5grmNuPTjl2vfqE/ae+yu5SptGM+LBlE2g41armnpye/DD0brQATcqStp0IKcZ9QMtW0jSjBl3Sas/M=@vger.kernel.org X-Gm-Message-State: AOJu0YxxcD1oeco75/ES8MebLGKIjz0GFu7+jPia5AAS6PawIlNbAx0W Q0o9TK0NC1EY1ZQtS7DKhpGLhBGtSBqOS1YKmRv/zVGKfRIX437b4WLi X-Gm-Gg: AfdE7cnJBN+K7LcCqI8BL9czhbUMK3Emfgbw9uojxGEa/yOumCr14Qc/TfKwc+TSgvU 4X7q1LU7ZPAoKpTOmhhjYFTIm6JrXTIqALcYmvYguQMukcvSA3QOnJHvLCujSTTW/Q1A0lM3hZz RTbIybDf8G5Ub13GOkwRzJjjcq1dPf9bY5wwaaAtjrbF+TIfx7A705tv6caH1N/CrQXHl2AwKWE SaC4HRUL43THi2A4dhsi20qqmKgX1Lst3hHZYLWnegbZ8jjxYiRhuGep7g7pSBaTfzBOgt7+768 O96/jz+dSF5v4UjaRqCdINtAl2R6eRl5IHNJW12G71/w+aZddsm6Yjj8wxkrPBZBN7O8cfk7+sO cJt2F48G3pXa/77itCWrgRs0dmtcbTTwC0X/MUmn2ounFQ0lavQ3f2fFdxyeEYmTES5AtzXqwJI OzXMG0LXtn X-Received: by 2002:a05:600c:c097:b0:495:5a91:8027 with SMTP id 5b1f17b1804b1-4955a9182a8mr118618585e9.5.1784639760966; Tue, 21 Jul 2026 06:16:00 -0700 (PDT) Received: from workstation.. ([182.180.105.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4956547323bsm70923635e9.4.2026.07.21.06.15.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 06:16:00 -0700 (PDT) From: Ali Tariq To: Daire McNamara Cc: Ali Tariq , stable@vger.kernel.org, Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Minda Chen , Conor Dooley , Mason Huo , linux-pci@vger.kernel.org (open list:PCI DRIVER FOR PLDA PCIE IP), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2] PCI: plda: Fix resource leaks on error paths in plda_init_interrupts() Date: Tue, 21 Jul 2026 18:15:22 +0500 Message-Id: <20260721131522.594267-1-alitariq45892@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260721130034.560632-1-alitariq45892@gmail.com> References: <20260721130034.560632-1-alitariq45892@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" plda_init_interrupts() initializes IRQ domains and creates IRQ mapping but does not unwind them when later step fails. If platform_get_irq() or either irq_create_mapping() fails in plda_init_interrupts(), the domains are never deinitialized. If irq_create_mapping() fails, port->intx_irq stays initialized. Add shared error handling labels for error paths to deinitialize IRQ mappings and IRQ domains. This issue was found by automated review of sashiko-bot Fixes: 4602c370bdf6 ("PCI: microchip: Move IRQ functions to pcie-plda-host.= c") Fixes: 76c911396807 ("PCI: plda: Add host init/deinit and map bus functions= ") Link: https://lore.kernel.org/linux-pci/20260718120701.DF4111F000E9@smtp.ke= rnel.org/ Signed-off-by: Ali Tariq Cc: stable@vger.kernel.org --- Changes in v2: - Added PCI subsystem prefix to the subject line, no functional change. --- drivers/pci/controller/plda/pcie-plda-host.c | 30 +++++++++++++++----- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/drivers/pci/controller/plda/pcie-plda-host.c b/drivers/pci/con= troller/plda/pcie-plda-host.c index cda8fdb088fd..a2d7079aec73 100644 --- a/drivers/pci/controller/plda/pcie-plda-host.c +++ b/drivers/pci/controller/plda/pcie-plda-host.c @@ -419,6 +419,8 @@ static int plda_pcie_init_irq_domains(struct plda_pcie_= rp *port) return plda_allocate_msi_domains(port); } =20 +static void plda_pcie_irq_domain_deinit(struct plda_pcie_rp *pcie); + int plda_init_interrupts(struct platform_device *pdev, struct plda_pcie_rp *port, const struct plda_event *event) @@ -440,14 +442,17 @@ int plda_init_interrupts(struct platform_device *pdev, } =20 port->irq =3D platform_get_irq(pdev, 0); - if (port->irq < 0) - return -ENODEV; + if (port->irq < 0) { + ret =3D -ENODEV; + goto err_irq_domain_deinit; + } =20 for_each_set_bit(i, &port->events_bitmap, port->num_events) { event_irq =3D irq_create_mapping(port->event_domain, i); if (!event_irq) { dev_err(dev, "failed to map hwirq %d\n", i); - return -ENXIO; + ret =3D -ENXIO; + goto err_irq_domain_deinit; } =20 if (event->request_event_irq) @@ -459,7 +464,7 @@ int plda_init_interrupts(struct platform_device *pdev, =20 if (ret) { dev_err(dev, "failed to request IRQ %d\n", event_irq); - return ret; + goto err_irq_domain_deinit; } } =20 @@ -467,7 +472,8 @@ int plda_init_interrupts(struct platform_device *pdev, event->intx_event); if (!port->intx_irq) { dev_err(dev, "failed to map INTx interrupt\n"); - return -ENXIO; + ret =3D -ENXIO; + goto err_irq_domain_deinit; } =20 /* Plug the INTx chained handler */ @@ -475,8 +481,11 @@ int plda_init_interrupts(struct platform_device *pdev, =20 port->msi_irq =3D irq_create_mapping(port->event_domain, event->msi_event); - if (!port->msi_irq) - return -ENXIO; + if (!port->msi_irq) { + dev_err(dev, "failed to map MSI interrupt\n"); + ret =3D -ENXIO; + goto err_dispose_irq_mapping; + } =20 /* Plug the MSI chained handler */ irq_set_chained_handler_and_data(port->msi_irq, plda_handle_msi, port); @@ -485,6 +494,13 @@ int plda_init_interrupts(struct platform_device *pdev, irq_set_chained_handler_and_data(port->irq, plda_handle_event, port); =20 return 0; + +err_dispose_irq_mapping: + irq_dispose_mapping(port->intx_irq); +err_irq_domain_deinit: + plda_pcie_irq_domain_deinit(port); + + return ret; } EXPORT_SYMBOL_GPL(plda_init_interrupts); =20 --=20 2.34.1