From nobody Sat Jul 25 00:56:32 2026 Received: from mail-wm2-f8.google.com (mail-wm2-f8.google.com [74.125.225.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99EFC30FC21 for ; Tue, 21 Jul 2026 13:01:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.136 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784638879; cv=none; b=V4lS4uJIF9TzkGLVrliBEmBjaU0BHsD/lYPsJczDFda7SqTW4fjILFibVgqM5rC5MIotTQ3WPTaR762WmLU1FtQxqAZdEbNHE3vAuLiKQtnOTUH+JPenOm5aO4P1UV+n6mpamHarORadogEdFVJhlXl1QoEpEdSRqyQuKYsJY/A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784638879; c=relaxed/simple; bh=KuuEpbTst1n9P77orwaO7ugukPK7pW0UmKogjRLG0ZA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=mCSdGtCQqcGyeUU/ZUYutK1H2XzHBXyz6I72oUDgbq6ltnIi0WRGy+DSoRt575+mdOVSvWUY8m/gF1ZYv5JN72sDNlCsqJHwifWv6ya4t3542HFEzIKvufa3j5dFbNz0NG8xNxRzTWBKpAJ2OcAOTMQCJvrrhZtQnWMEj/+kfsY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=h3SlYIce; arc=none smtp.client-ip=74.125.225.136 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h3SlYIce" Received: by mail-wm2-f8.google.com with SMTP id 5b1f17b1804b1-49550b004f9so10820965e9.1 for ; Tue, 21 Jul 2026 06:01:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784638876; x=1785243676; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dXsaj5sMjmALSo9ZqMQjjSEH9mwAn1wAoVJp06uCuZg=; b=h3SlYIceTm86o+fN01kt1Lid8cpiism6DqKPz740XN3QP7V0DQeQ6V0tmlGp1enpzI OAsc68txNI/L6zBycaf17YJSxJfmW1pxiRV9J0WxA5+iXcvpwN8xfId7JfZIwuC4HR61 XbBWSOoggjN4WcS8+IdpKwZs/G0EymnOhHDwAX0t/wqvoQbwe++eY0qaOGGFg+gxJH8L LjQMS+ah7XJtpYBL6WJkY5i1C3o3AsAGjjAcitn/pdpppnSJjWUx/lcgt3yR7eI9cdMB gsOBC0rS3oICcEjwwxSXjSTiAe+3PQ5mqz6CBAe1NzzB2NwlP8+2Jjr+4tq4h1nBmRQn M3EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784638876; x=1785243676; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dXsaj5sMjmALSo9ZqMQjjSEH9mwAn1wAoVJp06uCuZg=; b=MLx684pY6x/5UsHACAp3kL2zbwSpqpUajaP12NLyQOjbvj4pzewyCwegGLkNfifBAx orU1ULBMdyfqLOGYjp5UFae0SWEP3/nXExd5o3E6uQpoXy27gZi6XhHv32+2NbFX2m+m oMr0yHmnpioLpPO8c5B6AiKBJNJCpQCvjMFw8GRSpB+dof1mBrQxQiCgNHJbalztRE0E 3Stx2JlD/CFWgI0q0w96tfeV+84Qcm/WimZ4EmK7QvoWknxaJSQaWxYgMokDV1GZzV0J JUfr1RlGykagR0zwTlXK2myCxDaZlHl877n96JzImMBjGltPsMQpl+ws4hLMqcLOA0j4 antA== X-Forwarded-Encrypted: i=1; AHgh+RqyKQq+STrHSS/4hW85uuxdbqErExcEhfv3Cu4kVmJS9QwjlXGTgW3Ti6zeNJ6P/QqIrfB3U1yMcAdhyYI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6mXFJQilwBPpyQLxZyubVtT+j3KiL7G4tX4LtawRfJ+5btaPH azO9x6PAPolUN+ouUOOdPUvefl+iXCsa2EWl9lpeEQEuYB5CDfRwYSk1 X-Gm-Gg: AR+sD11bks6uYu5OrxigGfI/Gl3I1qtP4ygPZWH/iMlrApvO6AdWPanQuu7jLNPHaLN DMfpUwrRuiiS3N9tiAMNL8ei62KI4UPFsRupveQ1kn0c9vv7VYSWiu75GjldyG5u4QPtW7nyYXQ cQYhQDUIk3LyEUimCMsXUJ2vrTx747GN2PusU+gfowzNMA2S6jkYWhXJDOl3qQjoNc8vpij7US/ M7dgetVcOt210XmTTr/Y8x1YgSzZ/kF5WBm4GT/Lc5O+L26Zi/D0Tw8e++w5BA0lu+gFlSJhyiu GUKVEcFofhhkXlnQJtB2OIY5Kn/CDXG1c4MeljEYLm+1S5fvIcXxdAY2hhXYjFjCQBsIcLZbxQ+ tqOvmk+WXatk7SIV0HB1MMiyAM2FEbJVdy3OqDZci4rP5By2hXpFw7KTA8PLDuCrXWkV9L5p4eA pWfwhJXMc= X-Received: by 2002:a5d:59c1:0:b0:47f:77e4:37cc with SMTP id ffacd0b85a97d-47f77e437f6mr11752032f8f.1.1784638874842; Tue, 21 Jul 2026 06:01:14 -0700 (PDT) Received: from workstation.. ([110.93.227.81]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63e519f4sm37252791f8f.14.2026.07.21.06.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 06:01:14 -0700 (PDT) From: Ali Tariq To: Daire McNamara Cc: Ali Tariq , stable@vger.kernel.org, Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Minda Chen , Conor Dooley , Mason Huo , linux-pci@vger.kernel.org (open list:PCI DRIVER FOR PLDA PCIE IP), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] Fix resource leaks on error paths in plda_init_interrupts() Date: Tue, 21 Jul 2026 18:00:34 +0500 Message-Id: <20260721130034.560632-1-alitariq45892@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" plda_init_interrupts() initializes IRQ domains and creates IRQ mapping but does not unwind them when later step fails. If platform_get_irq() or either irq_create_mapping() fails in plda_init_interrupts(), the domains are never deinitialized. If irq_create_mapping() fails, port->intx_irq stays initialized. Add shared error handling labels for error paths to deinitialize IRQ mappings and IRQ domains. This issue was found by automated review of sashiko-bot Fixes: 4602c370bdf6 ("PCI: microchip: Move IRQ functions to pcie-plda-host.= c") Fixes: 76c911396807 ("PCI: plda: Add host init/deinit and map bus functions= ") Link: https://lore.kernel.org/linux-pci/20260718120701.DF4111F000E9@smtp.ke= rnel.org/ Signed-off-by: Ali Tariq Cc: stable@vger.kernel.org --- drivers/pci/controller/plda/pcie-plda-host.c | 30 +++++++++++++++----- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/drivers/pci/controller/plda/pcie-plda-host.c b/drivers/pci/con= troller/plda/pcie-plda-host.c index cda8fdb088fd..a2d7079aec73 100644 --- a/drivers/pci/controller/plda/pcie-plda-host.c +++ b/drivers/pci/controller/plda/pcie-plda-host.c @@ -419,6 +419,8 @@ static int plda_pcie_init_irq_domains(struct plda_pcie_= rp *port) return plda_allocate_msi_domains(port); } =20 +static void plda_pcie_irq_domain_deinit(struct plda_pcie_rp *pcie); + int plda_init_interrupts(struct platform_device *pdev, struct plda_pcie_rp *port, const struct plda_event *event) @@ -440,14 +442,17 @@ int plda_init_interrupts(struct platform_device *pdev, } =20 port->irq =3D platform_get_irq(pdev, 0); - if (port->irq < 0) - return -ENODEV; + if (port->irq < 0) { + ret =3D -ENODEV; + goto err_irq_domain_deinit; + } =20 for_each_set_bit(i, &port->events_bitmap, port->num_events) { event_irq =3D irq_create_mapping(port->event_domain, i); if (!event_irq) { dev_err(dev, "failed to map hwirq %d\n", i); - return -ENXIO; + ret =3D -ENXIO; + goto err_irq_domain_deinit; } =20 if (event->request_event_irq) @@ -459,7 +464,7 @@ int plda_init_interrupts(struct platform_device *pdev, =20 if (ret) { dev_err(dev, "failed to request IRQ %d\n", event_irq); - return ret; + goto err_irq_domain_deinit; } } =20 @@ -467,7 +472,8 @@ int plda_init_interrupts(struct platform_device *pdev, event->intx_event); if (!port->intx_irq) { dev_err(dev, "failed to map INTx interrupt\n"); - return -ENXIO; + ret =3D -ENXIO; + goto err_irq_domain_deinit; } =20 /* Plug the INTx chained handler */ @@ -475,8 +481,11 @@ int plda_init_interrupts(struct platform_device *pdev, =20 port->msi_irq =3D irq_create_mapping(port->event_domain, event->msi_event); - if (!port->msi_irq) - return -ENXIO; + if (!port->msi_irq) { + dev_err(dev, "failed to map MSI interrupt\n"); + ret =3D -ENXIO; + goto err_dispose_irq_mapping; + } =20 /* Plug the MSI chained handler */ irq_set_chained_handler_and_data(port->msi_irq, plda_handle_msi, port); @@ -485,6 +494,13 @@ int plda_init_interrupts(struct platform_device *pdev, irq_set_chained_handler_and_data(port->irq, plda_handle_event, port); =20 return 0; + +err_dispose_irq_mapping: + irq_dispose_mapping(port->intx_irq); +err_irq_domain_deinit: + plda_pcie_irq_domain_deinit(port); + + return ret; } EXPORT_SYMBOL_GPL(plda_init_interrupts); =20 --=20 2.34.1