From nobody Sat Jul 25 00:56:30 2026 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010050.outbound.protection.outlook.com [52.101.69.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38B26449ED6 for ; Tue, 21 Jul 2026 09:56:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784627800; cv=fail; b=Tisna47tTcabrnK4G7lYZW2mlP4YiYZ6bspBG7XOwN6a1KRRYMoUW8vdYuwBkYRo85ufT4EqEreNTFV9Ls+V5v3OCl61KVXmqGUvhaQM01H3CCx0zgLPPthfdVwWPk23fKniajztRJfpjSi/4ZrkidEEjH/ScmflY7IcRv10mfs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784627800; c=relaxed/simple; bh=Im8N01U9r1mg+E83y2EfbPMp9Xoc77a28Uh6EgoYjC0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=l3vKoyx/hUzQ/PFnEpRfI8WExgSF0kuTD425TArlM2cHbYy/IvD5/dabyGSmIpgZpjg9KJsvFxWrQCL8YCTkss6Z1XiLLxW2IlNQEA27jiTizB+leO27w2BVSJiw+z+r6OLsdT9YXhwfviDBhevC3eNOYx6uXWWyJ4WHiZ9cLpw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=oPTaQexg; arc=fail smtp.client-ip=52.101.69.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="oPTaQexg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dnwqCDS8t6vc7wmJIALKBfQveu8KUG1nYj9EVJUYVsRbmCOW+uLYcXOHDdCORLC0iD7tPraPs/xVXb82yqCJrYA1Qo1hmAlkwXmdRIadmiatWnYl20sI6aSoi3jT6UuaX7/hK/5qmJd2/KMhjRQOhfC3aeTXIpXd9fQSUKtwslncXOJydvh/cuSKKSoTA1+kETMiX2DepSlG9j7YubGnfJKOM836dRyWbHypjy/b+GGA4cOjZn0zyOaOXZhoqn90Kznjy9MsXWF4mc5pligw3uPSe8akEofNWRUaozBUm4KsZ7VE/zmbq6sVVWGMw5fML4Czd+08IhSWINRL11pAyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tEXQ1bWxrYNBN3Q+HyzyS9+SvHvQC2veSRCOTGZrk5E=; b=a8QPdi7JZ/7SqIv8YLzRHxTyUuWcO+fZdFXmlxuL/NltKpwzj2s+Zb7MPQBE5bwSMsSQE5gC6zOO5X3NQhj5pBk+4K0Ty8TBVfyHEBpCPEtg4PYGwR6poUiR+BOXnvWTtGi6FIcaHtL7LxzlB+I9DF+N0amt48Qfza6Bcm9sZ7iL8ZXRIHsFQlcaY4yrtCuGCMBTtfu348j69CbixHO5zbl0qcAWxdMiELRD1cPy+LxQoneTOLxn6l8at7ksu0A3ppef5qayipBGGnpsOCpoor1OloT2ohEDNvHKNMXZ4ZzHgf7SvwZCYwGRqI914PQDU369u9LF+SZDg/2608kRCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tEXQ1bWxrYNBN3Q+HyzyS9+SvHvQC2veSRCOTGZrk5E=; b=oPTaQexgwnEmUnyiKEtNDgcfAU+dtdYDT2eCCxUz7UMGIVUybWN2AJwwoqBTfEOyCWGvXU2w05GZiPrKzLm7y3wdn5hQa2ofKBVp9CzKQe/TJe9LmZNKztOUhpGPZKNS8DD5APqDyYiCQZv82LHlVBhcFVL9ks9fHXr4NEBr6rHsPiXnj1S3FfgnO/nlPGvkMFnPdNynLYJvnp/3CvQ8s0UJS4kUOhJP0s0LFmsP4GaS4imDDmOp4O/p9PoNqwabTeTJF4R5C1AEaDr/rb2Y3VTI3fDvRkK3og1Al3oSK0n9gXP6JzY9LR7ImXjhIn0FMIALcR7ReFeiJ/1h+IhWrA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from VI1PR04MB9738.eurprd04.prod.outlook.com (2603:10a6:800:1dc::10) by PAWPR04MB11611.eurprd04.prod.outlook.com (2603:10a6:102:50a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Tue, 21 Jul 2026 09:56:36 +0000 Received: from VI1PR04MB9738.eurprd04.prod.outlook.com ([fe80::33e2:39d5:e3f4:580c]) by VI1PR04MB9738.eurprd04.prod.outlook.com ([fe80::33e2:39d5:e3f4:580c%6]) with mapi id 15.21.0245.009; Tue, 21 Jul 2026 09:56:36 +0000 From: robby.cai@oss.nxp.com To: lgirdwood@gmail.com, broonie@kernel.org, andreas@kemnade.info Cc: linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH 1/2] regulator: fp9931: Fix VPOS/VNEG voltage selector table Date: Tue, 21 Jul 2026 17:59:58 +0800 Message-Id: <20260721095959.1855436-2-robby.cai@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260721095959.1855436-1-robby.cai@oss.nxp.com> References: <20260721095959.1855436-1-robby.cai@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR02CA0045.apcprd02.prod.outlook.com (2603:1096:4:196::21) To VI1PR04MB9738.eurprd04.prod.outlook.com (2603:10a6:800:1dc::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR04MB9738:EE_|PAWPR04MB11611:EE_ X-MS-Office365-Filtering-Correlation-Id: 6bd72338-368b-4eee-f802-08dee70e5a52 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|19092799006|376014|366016|56012099006|11063799006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: oC4P+YzlTK58zQgnRjTzh+0KIFPnlFeZZdVVpzaS6CS2jm37hq1PizO4NrTbFqen+zf+8CwmlgkmKDMJfpE80z0K8Nd3Q8kDE13wN26lCwBO2mh5HOeFyaNoc8+rt2t8bIAN4n5rjmnX13GxF4u46uTtnK/oqYOogPWI0pVyQN2Ef7Fo2p/iKfFWa/0vUQBD8gmja2LLT4pvisgxjWoDTgE8WZ5xy0Xt9Gq/uv28IH4AnkwRW+vkRCVQHedY12BTQcbbk3fXW9CMpJHX85ibutw/JBSw8BJl69ZeT83is2VKCT4XuFluZFVtCNgjRDkKSBPIAhkO0CilXonQTacFdvwd/GiLP3gceGu7gHPo1K8yXpP7M6tHhg/vJwzfFhEhhT8JGB9zVr0Ls6p7KRRxRcpj0xSK42EdJFX1suj6HCsyucLPSW1fdnVnxe3z3fbGeHFCJ432IBMAHoSL1Z5P7DajECzWlDBi+1lb5mL5xoQa5/n7tPMzQTRrD/btSE66la3NA/5u610Ty5wUJWh4la7tCzzBbKif3m1qAs36f4yXPhZnOiruFkLRQfrqQP/WtJ/Hxz/E9avBqjj+cut1AxmyCggewlFiMRjvhfFtJqxl/NznWZNQm9rvqARQ0FD7XuAnYDRiIKOfTo690pZng0yV/Mo8ddfiZ6sIOToZ8Ck= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB9738.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(19092799006)(376014)(366016)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gyfw1B8UN/DvwTZhleTI/t6rTa/y+fImBVza9Ktwc9UufCet22ewPWSGMj2e?= =?us-ascii?Q?2GRayY0yPnD5u8cBUzzvEiciWzy3J2ac8sJbdeEmB7VO9+KCpsoI6Ugiy+iS?= =?us-ascii?Q?LzzZMZk9aIrGLK35hJcgLnOrIYdVqhb1f2PP09QwnNjnXokJ216L57tGC0W3?= =?us-ascii?Q?uxAXRZ0r4opfTamcaRSvkJE3hthknLzhGDi2M7eiIU0Mfosq6a9Wq/D8HvuZ?= =?us-ascii?Q?sxu+4hIEk90eAEi8IpGU2GkOVMb3c/DbJcKH8P12xuums7vpJfBwm6o08gdL?= =?us-ascii?Q?BPwAyBpJ+Sjk66+uXaU/joEVxrG1gGce4hsNZSnJz6WMGTjvNUzQVdK47sBO?= =?us-ascii?Q?LEDHoNkf3TDzpl92clyn6PVBdW0yZcMiGMyl/4WImW3CHIOU6A3v9cKwG+Bc?= =?us-ascii?Q?/JOt68WMXj35PCdDdVG1lkNoVhNYGuBJV8/4B4q2EPxIf3F0cqGBoAvVIPYL?= =?us-ascii?Q?f9PQwSRdY2AMlzeD7l01+DxHsSWxP+jcsp/3/IZnGu5WLL48HblZZCm05pNJ?= =?us-ascii?Q?lUmNGPIpVfRvI1APlbsOQKViaNdpEa6v1J68PReruiNTmfVy1/Gx/+XQBYlT?= =?us-ascii?Q?hnipwGMm7MYjVtIF3H4F6gwes1HXAe7bOqf1UyU2bqAqtm68dgtC0fpzhDm5?= =?us-ascii?Q?jgJgGq8ClqIdYHqMGTplp9yHD8zgDTSihPB5dsgYNjWGaAp6NP+fhMmpa+A2?= =?us-ascii?Q?GYSh4BRv8mgkKhB4wjsSpdjpG14LtzdCkzsBAwcAPZAbGCVBQJmjHKTJhGo4?= =?us-ascii?Q?6JZTKXnrHVRogpMKDCVRnBKQHlapC7eGp4SRg0zpXBoOG+vc23kgTe9ibsKQ?= =?us-ascii?Q?92H83Um53vvbde+eeYeyhjB+hYNXXMAWtCOg2wlyeZgcxp/mNkNJ1DyIbZBk?= =?us-ascii?Q?Oxqasy5nLN8JL3xWA8cxGTTbxzuIyE9U9Hv/zQhm8xkrHAbwfD0INJOL08VG?= =?us-ascii?Q?W8dZ91OfdLZRz2FPzGpAkaxYEqcZfJ/GIxsYP0guX7iWsJpusKICf2rrBD9n?= =?us-ascii?Q?cRIP0sp4ENbI0NK7H22bzEZxCrgiK929RPpEWCIOLsUDER3qIulQ2JDeotke?= =?us-ascii?Q?+XfBFJDd0vmMutibGRDa6RA1T2DBEiRMG/rPupvPd70vTHGvqPlQNnwgkFCD?= =?us-ascii?Q?js2Qgjmq/UoMMtTBrOYFfe1OPK1/+5ZkuAS4erNGH1DanJxRjpkCyvFohlvL?= =?us-ascii?Q?9ZvE//lIlR9/4uu4wxfSws0H77jNquUcIzuFpxjbElpUN5SuvosfRs7Ww4Hi?= =?us-ascii?Q?vj/qIL+pXxyCjzIoyjgSz/uTBYl9CidkNIIbTwTMwbt8POP6gBT9UnLkAn6q?= =?us-ascii?Q?nTA7o7Z4GXo4gTTGO2zfQ1UR1Cb4d93IjXjqaJ3z/h+DC5oBQifhNBPnk1pq?= =?us-ascii?Q?4TZJTAaq1uF8wV/+q1CksvyzmgtahqdlmPfvvQN+z6J/dSDopJv+PCb99HO3?= =?us-ascii?Q?eWOT1jQ2BL7haihAPlVNSCb0yNsXTeUmTDvUoiehQb0QTSI7jPZiwWsWLU/j?= =?us-ascii?Q?77SoHrJ98lqcRw68II3ZFe4OsrmcvuHZYCSxLAVMKCwyhg9y6tu/JjyVjZ3T?= =?us-ascii?Q?56qox7saX8pnJxQJ5k8xztWW+u5zELgrlJH2YjTN16OUJVuB6rLIApaTd6xb?= =?us-ascii?Q?zzr77i0xHxscLlh1qdk8zvbAI685cJW3Hw/Vxt33s4r7qlLViZmKz2tt7ek8?= =?us-ascii?Q?xTA7ktXEUuobyitEAmnkV4fZv+mQ5MVs2rmRQbHgT/QQWuXe9JCiNX/Idtka?= =?us-ascii?Q?K699KswU5mJY4ofK02Xz9y/S7ugJvNdwrx5Ube+gDWPFCnf4OqMw?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bd72338-368b-4eee-f802-08dee70e5a52 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB9738.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 09:56:36.6851 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B0NfsNqf1HlSscXnKS/Dci87a6bLTy8QfiY2DZv2apfNCDgqv93cF04u2w2311UOfiuWFcZQFcfPUBl4UPmpthjNS9sFLU5or4dw7AyReUH4YKbe8XVt4+TJKKMhuqq4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB11611 Content-Type: text/plain; charset="utf-8" From: Robby Cai The VPOSNEG_table[] mapping does not match the FP9931/JD9930 datasheet. The datasheet defines the VPOS/VNEG voltage mapping as: 00h-04h -> 7.04V (-7.04V) 05h -> 7.26V (-7.26V) 06h -> 7.49V (-7.49V) ... 28h-3Fh -> 15.06V (-15.06V) However, the current table maps selector 0x05 to 7.04V instead of 7.26V, causing all subsequent entries to be shifted by one position. Update VPOSNEG_table[] to match the documented register encoding. Fixes: 12d821bd13d4 ("regulator: Add FP9931/JD9930 driver") Signed-off-by: Robby Cai --- drivers/regulator/fp9931.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/regulator/fp9931.c b/drivers/regulator/fp9931.c index 002b41f53eff..5eee21034f6b 100644 --- a/drivers/regulator/fp9931.c +++ b/drivers/regulator/fp9931.c @@ -42,7 +42,6 @@ static const unsigned int VPOSNEG_table[] =3D { 7040000, 7040000, 7040000, - 7040000, 7260000, 7490000, 7710000, --=20 2.50.1 From nobody Sat Jul 25 00:56:30 2026 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013026.outbound.protection.outlook.com [40.107.159.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A91C3C4176 for ; Tue, 21 Jul 2026 09:56:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.159.26 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784627806; cv=fail; b=W6dINV9kNTqJdC1tnbWYCLjZoaFstqhEuwazYQBI+RbOZaUi73sCiBEODpQjIpPXObUobvD4/brj7fNcHp+qPh/wFRnCQ/fi9atzty8pV0al4oFhp9LwErMkxR4nsRct5buM3MJNFzNN38T7bnykMllYQoBe/PjGH9EhQoEWv2k= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784627806; c=relaxed/simple; bh=yexmuZCrannarbTN+sbEBJVvqyBMJ/Y2F3Jtgq9YBTY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=aRiP6RjFzy2RoCONPYJCGrOcR/QAexNo6vMxpXplyOhzli3Ort0O7U6fokiMfKDkstsCeXjYNnQ0AiNBeeGuT7b3g+UN3Djpav6tYZC0q5616VJi+ZjOipqQWKUO2ZQyLq0+gfCESAmzLbLIBnjrcH7ROxX+VusSKHXBesLyvwc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=q/LARnNj; arc=fail smtp.client-ip=40.107.159.26 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="q/LARnNj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QWdNBm/rElEMsNR3KxEmsskB7zjXRy03DVdbGF+d+KOieR+bRG0su7BQA2UeVWxOScGzwSGHahMMsb9ocBC81+C8NyPuc2BTqgq9/PxKgBXsz7vPbK8+xoJOZxRjLLFPGgBeXAh4bXnW9ogz7vAZsyn+z4vICarsbyYyTO26k/FW2KTQqJDhie+YfwlN7FuH7Pk2YJt2VGZ1CTH28pLRVHeaqUgAdMoPONLT4W7tVuLyJTrjeMrqCmeEUa7QPr/biIVJvmgg4IuwbWOLp9tlaYIney0s0gAE1Nk/SehzuyQ6G3ktQYv2Vj4/rsOdNH094FGCmR1tI97CNz3clcW14w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q1CFbJHBcjKAENGI0ZEUmqAA1rVoy0I0tZrvoxyHbOo=; b=E6xu0DdvOHY0QnOkGxmIEPi62GlNgtSEHdcQEeJksMiMjvbpyj2WxvCLpNwIaEkE/jAb4eu7QhXtibwpCbN0eWZQOc4Gmj3wW6fLApn648EdCCYfJFh4CElwJ/AD8Zfi6f5twN93t7u2yi47a53wMAvxBMZwCg5yNaG5leV5vOCxoYVFsFLbMFnR7r3gjdAOT4llmCWiIQJObgglGGlUBn4+LHFOZbDJtT1rzPE0W2+KjP4iKSYvIfpFUOXysQNPqflJPJLBqTbRYptTSoVkqvB+8J3Xiaki5tCQtos12AJvISaEz1H79QbRREQolbEag+z1Uac6q7HzqNqWxIz3Tg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q1CFbJHBcjKAENGI0ZEUmqAA1rVoy0I0tZrvoxyHbOo=; b=q/LARnNjOFl3x0DlpgbS9qRm1nSLh7DPcR/opouOSbWo/iwt/oq+iqbAFr/rRREN1+fUhsfDqRp6bhMfsWwkdBHqNGJhCUTKMqeqswynLIovjgoionCzH7U+e2mraE6cfLDzOhqMhbvBaVxQJp24RHSObHBaxzbhWbD0ltZEev1VYLc8z4kO30iAk3HXvd4IxKUJSN7UtjxZeZfTgmX8TldW7hIHmp8mtDOUmrZ39dyUBbJIZKmQJXC+UQMIcV4g82FhGrl06VoPJWR1KP9wLknvAbVh3nTlh1ytujizIDMVkKOliV0x/EZeALcO5u5b8zQBy8G8kIRBbdlDzqKYfw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from VI1PR04MB9738.eurprd04.prod.outlook.com (2603:10a6:800:1dc::10) by PAWPR04MB11611.eurprd04.prod.outlook.com (2603:10a6:102:50a::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Tue, 21 Jul 2026 09:56:43 +0000 Received: from VI1PR04MB9738.eurprd04.prod.outlook.com ([fe80::33e2:39d5:e3f4:580c]) by VI1PR04MB9738.eurprd04.prod.outlook.com ([fe80::33e2:39d5:e3f4:580c%6]) with mapi id 15.21.0245.009; Tue, 21 Jul 2026 09:56:42 +0000 From: robby.cai@oss.nxp.com To: lgirdwood@gmail.com, broonie@kernel.org, andreas@kemnade.info Cc: linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH 2/2] regulator: fp9931: Fix Runtime PM usage count underflow in v3p3 ops Date: Tue, 21 Jul 2026 17:59:59 +0800 Message-Id: <20260721095959.1855436-3-robby.cai@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260721095959.1855436-1-robby.cai@oss.nxp.com> References: <20260721095959.1855436-1-robby.cai@oss.nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR04CA0016.apcprd04.prod.outlook.com (2603:1096:4:197::7) To VI1PR04MB9738.eurprd04.prod.outlook.com (2603:10a6:800:1dc::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1PR04MB9738:EE_|PAWPR04MB11611:EE_ X-MS-Office365-Filtering-Correlation-Id: ab5aac02-64bd-4983-94cc-08dee70e5e0c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|1800799024|19092799006|376014|366016|56012099006|11063799006|5023799004|10067099003|22082099003|18002099003|6133799003; X-Microsoft-Antispam-Message-Info: ERsp+2ONbxw79MSjl3sh2iL/LwxLCkUq8DXqlOIxYaSBaiabXgtKKSI91SV13C6lm4fpQpj0SvYtWaZ7YBb8Pdq5/MVxv1YxSAfTV69rQtPQceD78w2CsYbJLMlzl0AlCvbf34H962q025cFyOiVKCbDTlFeRaC2N3N+FXCE0u6/YW/s6R8LLiBIzlc3Rm+H99kdWB7t0gF29uoTsP18UM53aGvNq4LklJurFZcZ6X+Zuf9cUQrB9bSwSBBQnCTgVK+JhiOJIeztSdgbkzU+0Db+XI+qt4gYnlu67rVbnDWxhKM0AcR4PWYQ0q6C7/yxisWQVBFrp9CcfT73oSk7hyTatO5uGeqrB45rDHiBnRARCW/TYqXuzBQ27GVeSm7ADyhUmIfmqyasRcV9DeHvTQFBgE7YrBJMCaer3CYW552liTYnocrNzTWqb2y3XVmCO9B1pEm02api6b1QFvDtApYXnnyQbsQxitiH8okgUHzFe4P90MFg9xwT/xBX3I8k7S4fTyFTsHAF8YPunTVcWwZl7u1qO30FpkFPk5jduoODJZ/IUZDPBzmfntahTed+6SOqqYea5P41qxI39RkryfVXjGvhaNVgQx3NLvoz2fz/5iVIluF8jEAHo0ydhnTH1qeXoN5V0xvpg1u0Y4E2fJ6XezAxdr3E4LGVXzxahGk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB9738.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(23010399003)(1800799024)(19092799006)(376014)(366016)(56012099006)(11063799006)(5023799004)(10067099003)(22082099003)(18002099003)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+ZoXS0JrZ6p8Usi0kYdwm3cIe7lZlPhw3nBPEyQBtlmv6p+XQcFu2KX61vb9?= =?us-ascii?Q?Hlg8/wgKz2GRuiqOELWJQbRM2ieHL0Rp1FtPdvl3zoIVsZeE+sHwu44tz2yE?= =?us-ascii?Q?djbaAaW+drFk6A0OC8FSzieW9X/MmpuySIra3JXCC31JC5QqmYTir0upJUm2?= =?us-ascii?Q?UTuUzasxepttWyLHTLC659ZaxVzRrA1/fbHRcwLPmPqfc4jxiKtCrftk5Bj9?= =?us-ascii?Q?5t1wuDLbR7vhPRW+GTCDv1Zf1pvdozE2uO8ZNNmSK52VOMlMGd8aTPt1/7wj?= =?us-ascii?Q?0x97ZKYMl90trHRMLFe5uy5gGnIu7tz4BqxZqoxxNi+YhfOFskODEX4kp2eo?= =?us-ascii?Q?nwjXHXjJi9Xs5Qt+75pzifTyVTLFZ/5riA40E8ID2tfASS/HlD7w6vIUjo4S?= =?us-ascii?Q?f7NHX8J3OmwedBjcbkkKytkSiNd076p8ymsjsUdxGN3jIlGTLN9JXlKzAsj3?= =?us-ascii?Q?qtUMGyMrdK9bLo1dl894Jvh88GBr1/mykLwbcrSdaj5TpHYWT//JZzjSKG+Z?= =?us-ascii?Q?Bi7h5RAO57DaK8dD6NVwC96bfzwttZbIeUG5Pf6gn/g+77Wdd3an/sQ+zWJ1?= =?us-ascii?Q?LeNbXTGuEXmtymH4tDxmjDwbNpzTr1aJpGbw7gLFI+CL84lmyPG+eXKKUzmD?= =?us-ascii?Q?UPqdBSQF3eNjvd7rUn8tchW4TwLV7XyK2GlKHYSjVMwMtzObkmoS/vjVIITg?= =?us-ascii?Q?J2eNcN8C8Ca1cMHGRY3wg2yhCXIW+n8QpfSfERVCsweutx6l+pjdHdlF6/bl?= =?us-ascii?Q?rM/cOkXh6YfJ8OXb24GsF2HYunsXsccYYqcblhysj1+saIerJtL9Al1m0vZq?= =?us-ascii?Q?2imPDOhEA4BeUOjaKghW4+S/9FTzd0eunpdYRXl3Q7kpYTb1vDyKtn1R02ZT?= =?us-ascii?Q?YvXA7DeuuK3yHQsPDngcSsz0TyTGA+zN5xVuyNYbtLDMfI3RxwBFkzJZJ69R?= =?us-ascii?Q?+rggFC20kF9MOYuS1Kg1n9TFL2eP3ty3uUAwh39IeTYIXAZZpgNn4eZRcQUl?= =?us-ascii?Q?0SRZaKKjm2J7o5uR6Fdrq41M5wksl5+qUcV99QAdWwwmm50r3x0mXkFf5TZN?= =?us-ascii?Q?/oHiLmDKJHJxGmJFgZLqovNdjVl9Suuik/gOYc8LObepZUMayRTbdJOC7lec?= =?us-ascii?Q?rzhmRiggB+zD5y+z6gTzYXn5UVvo8rwidnbomYd92IjsI4v+Ks3cqyhJRzfY?= =?us-ascii?Q?rVYYaXN8GcszFbtidjOnPsraEdABD1OLCff3QSvzXj5iLYcGiKihfBNzjexN?= =?us-ascii?Q?GMTBPAr0bR+UzKA7KH0BW2LQ5MGfDkdbBL8dN2rpz/8KU7N0fMaGASUNTI8d?= =?us-ascii?Q?KTzNUBFU/8rqewUHEWehzJJvzIbxubEAd+wgSTvel+SPY0Fc24pZjiHSvB3g?= =?us-ascii?Q?GFRvWdEiLmq7Sq7a/wfhERIWw4JhnXkhqO/jf/sbd17e5hqsdNHub2oklXAH?= =?us-ascii?Q?mwQoI69viJ6ZF4P6vC9hqfLEMbiLL6jutmgsmyVm2sRAAQjca/5KehEFQmEv?= =?us-ascii?Q?u/A1pNzg+FhavqnRJIkax3CQuhWL+4RoZzU6k8KsjoJc7P3paKdOlIShcEHM?= =?us-ascii?Q?ygm2dTlOBEULPPd8Nf9Yljqnw9VJsvV4G9J3AdIDhoL6FJqwKU0SH5wTbWfD?= =?us-ascii?Q?NDF1lK987Mz5il0Eq/rLoBcKYEP/EZUzB462ySex4DouLbulkr1VrEpT2+wQ?= =?us-ascii?Q?h68ifXSFhaYwV/a7do8SUKBsnZU1+K54fbkeHNwMPAJ27dXkxYCjwpV2PVkb?= =?us-ascii?Q?9GTxgcE3FJaSM9UXMtivJ1b624SZYEDtXyyagJS+s15s9X23obLt?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab5aac02-64bd-4983-94cc-08dee70e5e0c X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB9738.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 09:56:42.7536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NMUzEtEJH6uyb6uMBvMtxVDFXo/JfNp0B+ETOTQisDdd99+IlY4XbSNHARcMgyg/ZPxVsCiwO2gJkwQ8+0vczUI1Uemp3LxTWaXmo39oMd3TJU/Be0WGd1LSsvOgkNU2 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB11611 Content-Type: text/plain; charset="utf-8" From: Robby Cai The fp9931_v3p3_enable() and fp9931_v3p3_disable() callbacks currently acquire a Runtime PM reference when V3P3 is enabled and release it when V3P3 is disabled. This assumes that Runtime PM references remain associated with the V3P3 regulator state. However, FP9931 regulators share common device-level Runtime PM state and references may be released through other regulator paths, such as the VCOM control path. In addition, the regulator framework may invoke disable callbacks during cleanup even when no corresponding enable callback was executed. As a result, fp9931_v3p3_disable() may call pm_runtime_put_autosuspend() when the device runtime PM usage count has already reached 0, triggering: fp9931 1-0018: Runtime PM usage count underflow! Fix this by scoping the Runtime PM reference lifetime to the register access itself, pairing pm_runtime_resume_and_get() and pm_runtime_put_autosuspend() within each callback. Fixes: 12d821bd13d4 ("regulator: Add FP9931/JD9930 driver") Signed-off-by: Robby Cai --- drivers/regulator/fp9931.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/fp9931.c b/drivers/regulator/fp9931.c index 5eee21034f6b..3ffba6fb75ff 100644 --- a/drivers/regulator/fp9931.c +++ b/drivers/regulator/fp9931.c @@ -243,8 +243,7 @@ static int fp9931_v3p3_enable(struct regulator_dev *rde= v) return ret; =20 ret =3D regulator_enable_regmap(rdev); - if (ret < 0) - pm_runtime_put_autosuspend(data->dev); + pm_runtime_put_autosuspend(data->dev); =20 return ret; } @@ -254,6 +253,10 @@ static int fp9931_v3p3_disable(struct regulator_dev *r= dev) struct fp9931_data *data =3D rdev_get_drvdata(rdev); int ret; =20 + ret =3D pm_runtime_resume_and_get(data->dev); + if (ret < 0) + return ret; + ret =3D regulator_disable_regmap(rdev); pm_runtime_put_autosuspend(data->dev); =20 --=20 2.50.1