From nobody Sat Jul 25 01:24:24 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11E8F3BAD9F for ; Tue, 21 Jul 2026 08:26:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784622369; cv=none; b=MikR9OkV8NxpcrFohSu8TVdRg8OPNkeWmRcHHBCIlInh2droCbQuAC+1V04Qx1aWm5pz8D81mcrInOiiVrqFprneR3Gg6hRv2FKIsTQbXhg02RwyYy4uSjGscieNFVIxiLo4NKzoWEhcUnABJtXGH+yV3l6/a6cJUAj0kwNWrxE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784622369; c=relaxed/simple; bh=JkMHTvniZhqe2oXMPPAGLmNJZHBXlNQ+NTN1FpBLCHA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=plVvFRZ7GRIEgG/ryCiLy8g4nvlziQ/L6Wbz9kkeWd9zYGalKQa4ugb/JzWBs91hJeTyMWSvnae50inHn4hHmP+ww1TLwcYW5woBnF9J28wcdF/pZJD8PlNH6vpnpTuL95bi6/P4C/s+xJtPZ0hZ3tKuLL70gYVILUVzuukHj9U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KNL0fGjb; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KNL0fGjb" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-38de840f2f0so7086584a91.0 for ; Tue, 21 Jul 2026 01:26:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784622366; x=1785227166; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=ZJM3h7TT9K/6v0G9mwCxA2nXNujpb9Aox1csSxS/kdg=; b=KNL0fGjb84z7auuOxltmZg9EDucWbcvrdIYsYUKO1ZT3ar3a+BhSNWzcrBd8vsjGop EkC5clgZhNaZMv5Bv43Eo1eDIGFBQH6MeVPamuw1nqDsMgHJQ52aDFGHitUOPijS06Rz F4POrnrCtKzVWeJkIIeFC/B/PeUGVjJYiMuwBo2dbko4Thk5rmsIW46fPu0YXPVc8QFw eiwipCJKy8lRu78kWY9tinhqinn47HNbkKVPtC/Xttb0v+8dxdJdQZtzJ+gRyeVx5HSD s+S9u5w894LDsvGsOFbmcdj2B53ToGRhuCUMyuBu2HfKPxAy91LEAWXbWkSkttQMtaJD 7gEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784622366; x=1785227166; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZJM3h7TT9K/6v0G9mwCxA2nXNujpb9Aox1csSxS/kdg=; b=bau0Rdo3p1MBaKez5qXa/MBelmvkvgJ/WdnsYft266HYsf50GaYZunj6vV9/m9y60l C7t92h2D0U8MBrntyJ7Fy3NLlZlhQduD9hOUSrdvoNY/RMjx4I5pBrccRenZIpXlFUaq oFmKXMeRm2YnNjs353IPrpYkmQTCaCj+khWUlW0+CMEAVz7/BlWeYpwdCTSFqEeJGN6T ecn8xea7qc1UgJDlsRlOBvi+m2LLS4GaSGZtH2eovoKPapsKusqZveH6Z27q4J9lAsR/ L2CglmMbPA6T3CeEWb1hTmHXullf+msrt4NJM9VXFD/4ldZtwjV2JUb4kx9EQlwDFS3F lthA== X-Forwarded-Encrypted: i=1; AHgh+Rqf3rN2HsvF1/tub1+ANz8Jxoq2rpt8mcwEVhrULOXhpMurC8PBsXJrCpWOadIoBZHOnk5X/DkqZdLY0FA=@vger.kernel.org X-Gm-Message-State: AOJu0YzZDBxhSZuibFFlysqkK2UWSJIeIXXQ8SXPvccxQHICsvoVve2t fRhpt2qqcZpL7TFR96Y/Z5LnRE7lXnPZe/AORXcIG1ZJJPkWIQdNz2o= X-Gm-Gg: AR+sD13/F3f6XvZJqRxTf2RFEx8BnPS4VdC4k5P27YuwGh+CeZlnjaz4VSfp49QZzTE K/40LFRxEh15I+4A3subvmn/jmlRZY2E1Zl2GABViaSRSlNLExDsyWBPZeZFKE/BtwKbwiLtZWV gL9BO6vM92bhzhXvxlNAK+UgGDxw2K6uLHefXGZqJjADdVb1g0I8W3YCUQwwU2LOhNRi9jKN2SA rGrgouh5iwgUM1SFksLx9XQZfL5JM4OtgWoi0rUTQxxdElfFR7VX6F7X3JmYRTmjONTgENkm+BA 9RQW218LE0z9WZg64kOxJ4tuDQsEWt9DsdV4AAD9qj5xM5sP+Z3GFHhrMDxhiido6rZVQD20Gxc 6qUNhdvNrIIiZ/6hjvW4y8qmOGz8TPtATfj6qB41atntqqXk00eda6givT+rP5qTh36JCds3mCK w62u/s5iHsErg2YpUQmIhf3WV6LPFgAwjrGsPjoNmyANV30BJH+n1Ez4OVyjv9tAqxpYHADGRWh a1BmuQe1EuDd40IlYSmJWCCojf6V87nezlz/osu X-Received: by 2002:a17:90b:3d90:b0:38e:7d77:2fbb with SMTP id 98e67ed59e1d1-38e7d77308dmr8036694a91.32.1784622366306; Tue, 21 Jul 2026 01:26:06 -0700 (PDT) Received: from localhost.localdomain ([14.5.152.27]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e92300651sm1079283a91.4.2026.07.21.01.26.03 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 21 Jul 2026 01:26:05 -0700 (PDT) From: Myeonghun Pak To: Cheng Xu , Kai Shen , Jason Gunthorpe , Leon Romanovsky Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Myeonghun Pak , Ijae Kim Subject: [PATCH] RDMA/erdma: Fix CEQ tasklet use-after-free on removal Date: Tue, 21 Jul 2026 17:25:45 +0900 Message-ID: <20260721082545.47395-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Each CEQ interrupt handler only schedules eqc->tasklet. The tasklet calls erdma_ceq_completion_handler(), which reads the DMA-coherent EQ ring through get_next_valid_eqe() and updates eq->dbrec through notify_eq(). erdma_ceqs_uninit() frees each CEQ IRQ and then destroys its EQ. free_irq() prevents another hard IRQ and waits for an in-flight handler, but it does not drain a tasklet that the handler already scheduled. The tasklet can therefore access eq->qbuf or eq->dbrec after erdma_eq_destroy() frees them. Clearing ceq_cb->ready does not synchronize with a tasklet that already passed the check at the start of erdma_ceq_completion_handler(). Kill the tasklet after free_irq(), when no handler can schedule it again, and before erdma_ceq_uninit_one() releases the EQ buffers. Fixes: f2a0a630b953 ("RDMA/erdma: Add event queue implementation") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Acked-by: Cheng Xu --- Found by static analysis only; not tested on ERDMA hardware. Testing on hardware, particularly device removal while CEQ interrupts are active, would be appreciated. drivers/infiniband/hw/erdma/erdma_eq.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/erdma/erdma_eq.c b/drivers/infiniband/hw= /erdma/erdma_eq.c index d5b9d19882b2..a8784e07acd6 100644 --- a/drivers/infiniband/hw/erdma/erdma_eq.c +++ b/drivers/infiniband/hw/erdma/erdma_eq.c @@ -220,6 +220,7 @@ static void erdma_free_ceq_irq(struct erdma_dev *dev, u= 16 ceqn) =20 irq_set_affinity_hint(eqc->irq.msix_vector, NULL); free_irq(eqc->irq.msix_vector, eqc); + tasklet_kill(&eqc->tasklet); } =20 static int create_eq_cmd(struct erdma_dev *dev, u32 eqn, struct erdma_eq *= eq) --=20 2.47.1