From nobody Sat Jul 25 01:35:28 2026 Received: from BL0PR03CU003.outbound.protection.outlook.com (mail-eastusazon11012003.outbound.protection.outlook.com [52.101.53.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 399043644A1; Tue, 21 Jul 2026 04:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.53.3 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606956; cv=fail; b=t20HP9JPWPQ8+KOJBZKDcMq7/GaxTVc1TLBswLcVrcyK4B5wxtfIS27oSYOCZgedaCyIZP0uQvRpgCPdU+URZWPHMZndXdNDAp5iNvFtixyDkhlUrewZI+4I2zT5JztGLceeUfFaHXTiswrfCovA44hWI7Namf+BRCidyBMuVMQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606956; c=relaxed/simple; bh=JqcDKy2xbgxavswn4nfFXMG01yGkosVARFYJykh05mU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cAp/Rxgdthzklr2dVwBGlT2fdR5UFUnRs1y6n+jGI80AJwDRMnhVViZsnDIZ8Qif8/xlyT3O8TZn3vzXnkWfQU6I3lwKMtoNP+VTLXnhjGHZ5WdBHo3gTCuMjqOLF0pzA5onNCqbWEqtlJGyXJVblP80SDgkHLu5i3ydWVnB84g= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=cdOhYEhk; arc=fail smtp.client-ip=52.101.53.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="cdOhYEhk" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TYuRAL6y7ShpI9rF0qg3vfdEBQ+nrFzSZN/75AkMmgYmB3UNqn8UwK2RxTYw3aCHR1Rf4S2ChGbmVWgx5bxgejmm0A9Eoc3eZzUy/uQ15Tb5pkSYGfkiUfQjSM0U4qp0zty3WHfkipaTeM4i6CSo4Bow+EHgLCGaiZelfHEE/7EuPCSW3mbD+sdplxxQSPdOTLxJXm1wCiUJ0k0NJzWPlvDmA+Ol/7VL1ipP5LSrlXeZkigMfyq8jrixLLzikXB++Q1Afe0IQAnDQEZ8cfkjNADuXtI+gpKrTv/cNszSnX4YBfL31ehkSq+T2LHjnVGKO+mpNRMIDdqiPpGzx1ZXuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E3HhTQ3KDMGn8KeLJKTWHxM3Z/uH2oQelCJEK3n4yMM=; b=padw2Cpimykqe9OTIx88RYmqZVbRPo1zB6ZnenvUDwlpHgxxAD3BSqEK0/h95cq+eky8ILh+qp4BKuRnpYKByK7hh8cU1FRgz63oHAztojI1m8KK4sevXVDatKjSN7CIpaxEORxnv/CefmPMaC9VO3Ic/eIHb6chq9ctt4FbgWSnUSZCzA0vv9yMTEbyMLX95+HxT4jT5U8VByk6s4U9+hmF61+QoWDBSuA4jIt7Qx2qBwDq/6NJXQEhZv9KL0dj4oEv9r6iI1aFGJ1DKnZoR7yw5I0v0m0UW20kHPJtczxzRyv0VJuyZw2qQEObRKOlg/bQ1hp69E8zV/ODpt62/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E3HhTQ3KDMGn8KeLJKTWHxM3Z/uH2oQelCJEK3n4yMM=; b=cdOhYEhkI9kE/CSs20DJLiMuy5VSLrGqMr8ArOC9Q+RigOUqSVcL2jhw3I472xPuYk13zFSj7dYIqhhs3UgDs/A/uIffTTNCBflPcTyCjYpLar1xzYjftoRZpABcg0wGYUxqG4A6+U7U/jLpoBbDnGynilYZ0EybclhH6NyWSAYuNH8gbTYOu6F395FjgCO0ayNC6Qsm8K8EK3CVlnSxwlXJjgIWgS1YBP9j8k2ciKw4jU5tGWLQAN1KlMrkIEgeBBcwttoEZ/ihY+a09vBKZPwnKGn1LXfpQm5UvM2y+d7RCKQa2K4aHKbsNt4SRsfW7NwEF3zM6xv0SV4jXviR3A== Received: from SJ0PR13CA0189.namprd13.prod.outlook.com (2603:10b6:a03:2c3::14) by BL1PR12MB5779.namprd12.prod.outlook.com (2603:10b6:208:392::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Tue, 21 Jul 2026 04:09:06 +0000 Received: from CO1PEPF00012E82.namprd03.prod.outlook.com (2603:10b6:a03:2c3:cafe::51) by SJ0PR13CA0189.outlook.office365.com (2603:10b6:a03:2c3::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Tue, 21 Jul 2026 04:09:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF00012E82.mail.protection.outlook.com (10.167.249.57) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:09:04 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 20 Jul 2026 21:08:43 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:08:43 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:08:38 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 01/12] dt-bindings: i3c: Add mipi-i3c-static-method to support SETAASA Date: Tue, 21 Jul 2026 04:07:49 +0000 Message-ID: <20260721040805.1696503-2-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00012E82:EE_|BL1PR12MB5779:EE_ X-MS-Office365-Filtering-Correlation-Id: 9a83a0ff-097b-45ff-cf23-08dee6ddcdf6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|1800799024|23010399003|7416014|376014|22082099003|18002099003|3023799007|56012099006|10067099003|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: mv1KXHX4Mp9pKxYvKthDSip0u2GbY/LLg3/89jmvFmiUS4pMx313cRyVTscnMmNAzja7uWQfy8pm2FePQnZidC1BB8jhMYk74EsWE0JEkklGAz8eRybTqinO82EGSeL+ySPowkUudCgJNoXJsptnnIQK1eXIyeVA22sYOvvVtaAyXOANDD9/+yVvKI5Nhvc8BbX66SAXZ4BfgJS9ZlsAMw2vthq8LkD9mAbbH6TIe/B7K6xJu/X1vd1JgNL9LZHINPW2fw+SYz2st1xEExn1ZCc0rTqe62vmt3lvH7TLmUplAaSoS3gUd5peDDOFFkiEy+qTC7Le66eHbipnb91ZSsNPkRTrycUa03UP1pxJE7Oe92eqRwQI23IVHrK1mDkU6el9QfVn+aJ9bjBztbvMCrwe3l2HEVCv4O6Ahaebc0tgNeXe+URoR2T8G1Wpknq6CVv/HN6xGl9Tr7RnwHJ/TsLWRuu+Gyza3S6Nwe9sfanS+t7KuzVftykCWp1VhogyJo5VMjJ72IrW0GhiqqZsCcL8nWEBtf4o/EVXNM7szd2/jOHf/ACRXm5h53okYuw+lq3eoGt3XOZNHnXtiYu60nTekQPyDj0h9WxcqQ9nub6unVoct/ag1vuNvg6NfF6QzdvEz9XwEHdfM8gbFMigJCMKCu37bE6QZn31qE4xJUxC73haplGDO7EeefErrKcpdF3hYfSpI9PROhbfbkpX5w== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(1800799024)(23010399003)(7416014)(376014)(22082099003)(18002099003)(3023799007)(56012099006)(10067099003)(11063799006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JDnE8kqi9XEqkAyqre1is7Zr0VJrs66wLQXNsjRM//0ivLh5+cb7FIVkRsjZJk3eE/51HI5beYI7vg5GXf2ZzqRpIwMeSfAOITZ3FG1RtunrQn/r1djF3yqrQgHLlI+XdxJ2WQiSbVu9d7+YwGcysNlLTa/61MMGKWe9rmc5B7isc3XV4QnjKFDnpXZBa9m8GEEjmVVlK4V6NEELhEkB30wtere4Ab9sKml13u4fdUHmYzUtQ9ghm3/1Jz7v8K33CciVMqGK20l4qcDJVG3iXcyx4MC41L2qZFeC8iKSgNYkl540NJSmd8edA2uam1pSWnsD5xP9eDj31pKEw6s8CXXCT9W/H0fWqqobNaoqEQZgQcneg7YT6Ph4GKOwh9iPLvmc89pO2hmI73N95HdZkrWs6gqq252rfd0ZM6xXcngf9LCp7WdxaixKssTBuv4L X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:09:04.9479 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a83a0ff-097b-45ff-cf23-08dee6ddcdf6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00012E82.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5779 Content-Type: text/plain; charset="utf-8" Add the 'mipi-i3c-static-method' property mentioned in the MIPI I3C Discovery and Configuration Specification [1] to specify which discovery method an I3C device supports during bus initialization. The property is a bitmap, where a bit value of 1 indicates support for that method, and 0 indicates lack of support. Bit 0: SETDASA CCC (Direct) Bit 1: SETAASA CCC (Broadcast) Bit 2: Other CCC (vendor / standards extension) All other bits are reserved. It is specifically needed when an I3C device requires SETAASA for the address assignment. SETDASA will be supported by default if this property is absent, which means for now the property just serves as a flag to enable SETAASA, but keep the property as a bitmap to align with the specifications. [1] https://www.mipi.org/mipi-disco-for-i3c-download Reviewed-by: Frank Li Reviewed-by: Rob Herring (Arm) Signed-off-by: Akhil R --- .../devicetree/bindings/i3c/i3c.yaml | 36 ++++++++++++++++--- include/dt-bindings/i3c/i3c.h | 4 +++ 2 files changed, 35 insertions(+), 5 deletions(-) diff --git a/Documentation/devicetree/bindings/i3c/i3c.yaml b/Documentation= /devicetree/bindings/i3c/i3c.yaml index e25fa72fd785..5603f2e7807d 100644 --- a/Documentation/devicetree/bindings/i3c/i3c.yaml +++ b/Documentation/devicetree/bindings/i3c/i3c.yaml @@ -31,10 +31,12 @@ properties: described in the device tree, which in turn means we have to describe I3C devices. =20 - Another use case for describing an I3C device in the device tree is = when - this I3C device has a static I2C address and we want to assign it a - specific I3C dynamic address before the DAA takes place (so that oth= er - devices on the bus can't take this dynamic address). + Other use-cases for describing an I3C device in the device tree are: + - When the I3C device has a static I2C address and we want to assign + it a specific I3C dynamic address before the DAA takes place (so + that other devices on the bus can't take this dynamic address). + - When the I3C device requires SETAASA for its discovery and uses a + pre-defined static address. =20 "#size-cells": const: 0 @@ -145,7 +147,31 @@ patternProperties: Dynamic address to be assigned to this device. In case static ad= dress is present (first cell of the reg property !=3D 0), this address is= assigned through SETDASA. If static address is not present, this address = is assigned - through SETNEWDA after assigning a temporary address via ENTDAA. + through SETNEWDA after assigning a temporary address via ENTDAA.= If + SETAASA is used, this property is not used, and the static addre= ss itself + becomes the dynamic address. + + mipi-i3c-static-method: + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 0x1 + maximum: 0x7 + default: 1 + description: | + Bitmap describing which methods of Dynamic Address Assignment fr= om a + static address are supported by this I3C Target. For each define= d bit + position, a set bit indicates support for that method and a clea= red + bit indicates lack of support. + + Bit 0: SETDASA CCC (Direct) + Bit 1: SETAASA CCC (Broadcast) + Bit 2: Other CCC (vendor / standards extension) + All other bits are reserved. + + This property follows the MIPI I3C specification. The primary use + of this property is to indicate support for SETAASA, i.e Bit 1, = but + will allow other values mentioned in the specification so that it + mirrors the specification. SETDASA will remain as the default me= thod + even if this property is not present. =20 required: - reg diff --git a/include/dt-bindings/i3c/i3c.h b/include/dt-bindings/i3c/i3c.h index 373439218bba..78b8c634aad8 100644 --- a/include/dt-bindings/i3c/i3c.h +++ b/include/dt-bindings/i3c/i3c.h @@ -13,4 +13,8 @@ #define I2C_NO_FILTER_HIGH_FREQUENCY (1 << 5) #define I2C_NO_FILTER_LOW_FREQUENCY (2 << 5) =20 +#define I3C_ADDR_METHOD_SETDASA (1 << 0) +#define I3C_ADDR_METHOD_SETAASA (1 << 1) +#define I3C_ADDR_METHOD_VENDOR (1 << 2) + #endif --=20 2.43.0 From nobody Sat Jul 25 01:35:28 2026 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011033.outbound.protection.outlook.com [52.101.62.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5EF9D379C3C; Tue, 21 Jul 2026 04:09:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.33 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606975; cv=fail; b=QVp242qCCS6HHQ1k5dAkrDu4M5J+HHCM7twJeHTphGcuunE1KBwLOz94bV5HlZp4TFAjKR841KFchPNCwjcRJZJkJtK0QxVRizVZwIn28Bft+hI3mPQlgPMvhgECjUIBJQYWo5i7EacOltHv55Zt8n7KPmXmOH+ca19OxdAxNQk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606975; c=relaxed/simple; bh=YEIqOiGJFfMwB9eeqhdXDzdmBHNfbPRMMBAsJJJ+DAY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lA33GQCkUBrWSYkqRmkfYwbtH628hl3103jpBHtSsrKs93sRtMnNlTyzKKmuMd3wjODEUhzRFePLW6tBSvE2slvZAyf2H8KpTLB2XWlkJk9TzSGi14TK/w9zqpr1ot4EMocxNFyjPcKUcEttzMg1Z7blSjga5CovkJBxi5KNUvs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=oszy8fEO; arc=fail smtp.client-ip=52.101.62.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="oszy8fEO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qGfkeCSf3MpDDAicxLRj/LOj9GsqrqNRXYFDYobO7VKLAkUCQNDpKyGCoARKpakJ38WIw7m/JMCT8qmCfBvj8j6Qz7iOl2xJBZgq6XobKgsiV6UyKmtyOsFrGOhCTU5lvJDXjo4egsv7sPPaRUDPZZTRnRSEz26DUcSMs/H1XRAaTNVuRY210xmg4IerTDvecoNLy2SYYeRuxYMkOkcvff6GFDpgYy1qJvQUGOlWQELDcMQ5dsLDG32ZY+4Fsed4+/NDrqGZGcJsOPxRfS0PT+ALIGehLtYdg3eiB4ZABVEuC3nnI1dOpqwnZBY4gaA2B3Bbz5GtKJBzrQU/yw3Z4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LNIpXwL2xFo3r30scGGx0jDCO7cC68olMAJd8271DKo=; b=x5U5vtkXYu6DL923w6oOs/RF21FKpGuPiavOC6pVjRtughzHUeeWPWFZoYcDtoQac3pWWOBXCZ/HHF7Q4rzqCa+9N9AT6yzIdww1o3CUan8yNF5/O0HcSLDkmodKBuNnBgararoALPFysCrvWKJauyWglTi1jPZd0VripBKOAL7mUdzq3Xfg4CFbVsLaL+WTzGKiK/gEQPhFY03vpXZpmD6YXjiFR3GAXUs2h/jttPf+9YAYwQ0vY7NTHgkkX1OcyKtR4j4d6BVsFZ1mCSt6nxGtveA8htOGCkrgJS7g745okM2XHgOr22zDkQ8swjzutCbMilJjfiJirM7B97vPwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LNIpXwL2xFo3r30scGGx0jDCO7cC68olMAJd8271DKo=; b=oszy8fEOD/snDz/4ZpCcpIrtdHf4Tc89QKRqtjY9wiedjcMp3GgU7460zZ2gKNSRLaEcH/XectmAZD5qni4x5Lg/usIQu6GahNlUH8R9dXlD1RU3FrwkwwjSTupE/O8H2XEnUsITYCS15cGWEAeZGylJsqCocQg0gHout8OvOtGA99NUpdziKly3V30JcR7SX/l2wPnZJ4USOM7LLFtj7wGU6W6GwBjmmz4gDRnHbSZ52VdT7ZydUSBdfvVCAwN5FOLa8xv5rRB2IO+5N/f282vadPCKJcow+E7G/SIpy2BgN16iNRBF+9fz4b2oxqpb8aiRmUUTGVvg7mvC0SCEoQ== Received: from SJ0PR13CA0021.namprd13.prod.outlook.com (2603:10b6:a03:2c0::26) by CH2PR12MB4165.namprd12.prod.outlook.com (2603:10b6:610:a4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.10; Tue, 21 Jul 2026 04:09:21 +0000 Received: from CO1PEPF00012E7D.namprd03.prod.outlook.com (2603:10b6:a03:2c0:cafe::7c) by SJ0PR13CA0021.outlook.office365.com (2603:10b6:a03:2c0::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Tue, 21 Jul 2026 04:09:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF00012E7D.mail.protection.outlook.com (10.167.249.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:09:20 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 20 Jul 2026 21:09:03 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:09:02 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:08:58 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 02/12] i3c: master: Use unified device property interface Date: Tue, 21 Jul 2026 04:07:50 +0000 Message-ID: <20260721040805.1696503-3-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00012E7D:EE_|CH2PR12MB4165:EE_ X-MS-Office365-Filtering-Correlation-Id: 0d653b87-c79c-4ce4-809c-08dee6ddd71b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|23010399003|36860700016|82310400026|376014|7416014|56012099006|11063799006|10067099003|22082099003|18002099003|6133799003; X-Microsoft-Antispam-Message-Info: r+q+i+W2LmW0lqfpOncUG5/QvMT55msqsHtoOn5b97tcwqh5c8fDrqHDYD8oZVoKJUV8+2EsacTGXcl+bBoJWCv0dO705YjbiTb9c+tea6jxdXYtv5GjAaCdWcHOxMEn/ixNEdYwvT2DqRmA4HBxtEO/e379b+rT+wZn8mVfpNFVeztfp7tvdn06xtEGD8WCU6TyaLOZOTxmZZm9vz5sm+2HISUM6QqPM4vtXQqkxfMO6RIaOtmMouZ0PyUaM2YcTyedTvcYMGo3IXRdDSmJ+IB+N7zK1E7+9RNzSEajFG/VkQflljLG+IzTDnuYW18W3i0OYTKX5hHQVOkCMa8cXDyoVYOhyYnuovAgEiXbAxKnyre/n/3cAyUwSJaRirnd4qViYLpY48O78+2MvQbUMbm7aW01Jwe3SVd9S4fMswEKYWwnayAVlR9uKH21wAulVmi5O6MJ5rBf7fdTxCgIfc9eFjSVVe3UMVFonNyIxSOc8uEI++j9aHDdsoznaKUsoDeKal/S9J/lazsuWd0FlSGPBwssCKl6qPLWSb8yJBv5v0i+6nukn315vrI48XuRoqSbk9j17hcVlEWCTEBE2HCeWupyUnVVgksdQWABRIHrZT5QFWmoEdyCheZJvX1VR/kKYvZ9xfgrdbCeLMXX5ElwLgHc1MGVUoxRW1HFX7Uodpb3FxFLYNKePIBmxfmsBTGyGuQnv5fSkUvITYI8Wg== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(1800799024)(23010399003)(36860700016)(82310400026)(376014)(7416014)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: y/B3TDVnSgXbnQbz1mINuhNLwhu4ETAqNUgY1vDww4qexZM+MfXI7J7rHeDECQka/MITgGK8Co3Pj4YrPKWJJjuBXkWDZWgslhJ7FsFZ7VTWRAQAKou2uk0vD1f4pZnYF1vHPACTja4tO5qDOWeXYjG8wxlUtMskwV2eY+r64xPZKm+K3J8J4JQNciTmmOA4Qm2ZEES0T+gmrX0E9XIH6ErmAYsFfQnWqDXWOqCE7p7M+kQioF2Dw9Gt8ifGbzR9JIOwO06ME5tnc3arOMfD9da6OnTNRkkuSFTys5a4EFl9Y3tpZ0spaxVL9OOPPdZuwQebR3Y7X3V03xXSbze16LmPYN4tOM+0zihrT43VeXovA8vMXyNp0nRfEVKFMuejRaffQZZE5FjAO78mkCZcR3k/KWiKGEkpu9VqHDe02PfhXG5PSLUSoapxHUO4gceO X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:09:20.2762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d653b87-c79c-4ce4-809c-08dee6ddd71b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00012E7D.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4165 Content-Type: text/plain; charset="utf-8" Replace all OF-specific functions with unified device property functions as a prerequisite to support both ACPI and device tree. Reviewed-by: Frank Li Signed-off-by: Akhil R --- drivers/i3c/master.c | 77 +++++++++++++++++++++----------------- include/linux/i3c/master.h | 5 ++- 2 files changed, 46 insertions(+), 36 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index f1be38a640ca..4b3d9628bc39 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -13,10 +13,12 @@ #include #include #include +#include #include #include #include #include +#include #include #include #include @@ -491,7 +493,7 @@ static void i3c_bus_cleanup(struct i3c_bus *i3cbus) mutex_unlock(&i3c_core_lock); } =20 -static int i3c_bus_init(struct i3c_bus *i3cbus, struct device_node *np) +static int i3c_bus_init(struct i3c_bus *i3cbus, struct fwnode_handle *fwno= de) { int ret, start, end, id =3D -1; =20 @@ -501,8 +503,8 @@ static int i3c_bus_init(struct i3c_bus *i3cbus, struct = device_node *np) i3c_bus_init_addrslots(i3cbus); i3cbus->mode =3D I3C_BUS_MODE_PURE; =20 - if (np) - id =3D of_alias_get_id(np, "i3c"); + if (fwnode && is_of_node(fwnode)) + id =3D of_alias_get_id(to_of_node(fwnode), "i3c"); =20 mutex_lock(&i3c_core_lock); if (id >=3D 0) { @@ -837,7 +839,7 @@ static void i3c_masterdev_release(struct device *dev) WARN_ON(!list_empty(&bus->devs.i2c) || !list_empty(&bus->devs.i3c)); i3c_bus_cleanup(bus); =20 - of_node_put(dev->of_node); + fwnode_handle_put(dev->fwnode); } =20 static const struct device_type i3c_masterdev_type =3D { @@ -1044,7 +1046,7 @@ static void i3c_device_release(struct device *dev) =20 WARN_ON(i3cdev->desc); =20 - of_node_put(i3cdev->dev.of_node); + fwnode_handle_put(dev->fwnode); kfree(i3cdev); } =20 @@ -1928,7 +1930,7 @@ i3c_master_register_new_i3c_devs(struct i3c_master_co= ntroller *master) desc->info.pid); =20 if (desc->boardinfo) - desc->dev->dev.of_node =3D desc->boardinfo->of_node; + device_set_node(&desc->dev->dev, desc->boardinfo->fwnode); =20 ret =3D device_register(&desc->dev->dev); if (ret) { @@ -2620,8 +2622,8 @@ EXPORT_SYMBOL_GPL(i3c_master_do_daa); #define OF_I3C_REG1_IS_I2C_DEV BIT(31) =20 static int -of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, - struct device_node *node, u32 *reg) +i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, + struct fwnode_handle *fwnode, u32 *reg) { struct i2c_dev_boardinfo *boardinfo; struct device *dev =3D &master->dev; @@ -2631,9 +2633,13 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_co= ntroller *master, if (!boardinfo) return -ENOMEM; =20 - ret =3D of_i2c_get_board_info(dev, node, &boardinfo->base); - if (ret) - return ret; + if (is_of_node(fwnode)) { + ret =3D of_i2c_get_board_info(dev, to_of_node(fwnode), &boardinfo->base); + if (ret) + return ret; + } else { + return -EINVAL; + } =20 /* * The I3C Specification does not clearly say I2C devices with 10-bit @@ -2649,14 +2655,14 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_c= ontroller *master, boardinfo->lvr =3D reg[2]; =20 list_add_tail(&boardinfo->node, &master->boardinfo.i2c); - of_node_get(node); + fwnode_handle_get(fwnode); =20 return 0; } =20 static int -of_i3c_master_add_i3c_boardinfo(struct i3c_master_controller *master, - struct device_node *node, u32 *reg) +i3c_master_add_i3c_boardinfo(struct i3c_master_controller *master, + struct fwnode_handle *fwnode, u32 *reg) { struct i3c_dev_boardinfo *boardinfo; struct device *dev =3D &master->dev; @@ -2679,7 +2685,7 @@ of_i3c_master_add_i3c_boardinfo(struct i3c_master_con= troller *master, =20 boardinfo->static_addr =3D reg[0]; =20 - if (!of_property_read_u32(node, "assigned-address", &init_dyn_addr)) { + if (!fwnode_property_read_u32(fwnode, "assigned-address", &init_dyn_addr)= ) { if (init_dyn_addr > I3C_MAX_ADDR) return -EINVAL; =20 @@ -2696,14 +2702,14 @@ of_i3c_master_add_i3c_boardinfo(struct i3c_master_c= ontroller *master, return -EINVAL; =20 boardinfo->init_dyn_addr =3D init_dyn_addr; - boardinfo->of_node =3D of_node_get(node); + boardinfo->fwnode =3D fwnode_handle_get(fwnode); list_add_tail(&boardinfo->node, &master->boardinfo.i3c); =20 return 0; } =20 -static int of_i3c_master_add_dev(struct i3c_master_controller *master, - struct device_node *node) +static int i3c_master_add_dev(struct i3c_master_controller *master, + struct fwnode_handle *fwnode) { u32 reg[3]; int ret; @@ -2711,7 +2717,7 @@ static int of_i3c_master_add_dev(struct i3c_master_co= ntroller *master, if (!master) return -EINVAL; =20 - ret =3D of_property_read_u32_array(node, "reg", reg, ARRAY_SIZE(reg)); + ret =3D fwnode_property_read_u32_array(fwnode, "reg", reg, ARRAY_SIZE(reg= )); if (ret) return ret; =20 @@ -2720,25 +2726,25 @@ static int of_i3c_master_add_dev(struct i3c_master_= controller *master, * dealing with an I2C device. */ if (!reg[1]) - ret =3D of_i3c_master_add_i2c_boardinfo(master, node, reg); + ret =3D i3c_master_add_i2c_boardinfo(master, fwnode, reg); else - ret =3D of_i3c_master_add_i3c_boardinfo(master, node, reg); + ret =3D i3c_master_add_i3c_boardinfo(master, fwnode, reg); =20 return ret; } =20 -static int of_populate_i3c_bus(struct i3c_master_controller *master) +static int fwnode_populate_i3c_bus(struct i3c_master_controller *master) { struct device *dev =3D &master->dev; - struct device_node *i3cbus_np =3D dev->of_node; + struct fwnode_handle *fwnode =3D dev_fwnode(dev); int ret; u32 val; =20 - if (!i3cbus_np) + if (!fwnode) return 0; =20 - for_each_available_child_of_node_scoped(i3cbus_np, node) { - ret =3D of_i3c_master_add_dev(master, node); + fwnode_for_each_available_child_node_scoped(fwnode, child) { + ret =3D i3c_master_add_dev(master, child); if (ret) return ret; } @@ -2748,10 +2754,10 @@ static int of_populate_i3c_bus(struct i3c_master_co= ntroller *master) * on the bus are not supporting typical rates, or if the bus topology * prevents it from using max possible rate. */ - if (!of_property_read_u32(i3cbus_np, "i2c-scl-hz", &val)) + if (!device_property_read_u32(dev, "i2c-scl-hz", &val)) master->bus.scl_rate.i2c =3D val; =20 - if (!of_property_read_u32(i3cbus_np, "i3c-scl-hz", &val)) + if (!device_property_read_u32(dev, "i3c-scl-hz", &val)) master->bus.scl_rate.i3c =3D val; =20 return 0; @@ -2806,7 +2812,7 @@ static u8 i3c_master_i2c_get_lvr(struct i2c_client *c= lient) u8 lvr =3D I3C_LVR_I2C_INDEX(2) | I3C_LVR_I2C_FM_MODE; u32 reg[3]; =20 - if (!of_property_read_u32_array(client->dev.of_node, "reg", reg, ARRAY_SI= ZE(reg))) + if (!fwnode_property_read_u32_array(client->dev.fwnode, "reg", reg, ARRAY= _SIZE(reg))) lvr =3D reg[2]; =20 return lvr; @@ -2925,7 +2931,8 @@ static int i3c_master_i2c_adapter_init(struct i3c_mas= ter_controller *master) struct i2c_adapter *adap =3D i3c_master_to_i2c_adapter(master); struct i2c_dev_desc *i2cdev; struct i2c_dev_boardinfo *i2cboardinfo; - int ret, id; + struct fwnode_handle *fwnode =3D dev_fwnode(&master->dev); + int ret, id =3D -1; =20 adap->dev.parent =3D master->dev.parent; adap->owner =3D master->dev.parent->driver->owner; @@ -2934,7 +2941,9 @@ static int i3c_master_i2c_adapter_init(struct i3c_mas= ter_controller *master) adap->timeout =3D HZ; adap->retries =3D 3; =20 - id =3D of_alias_get_id(master->dev.of_node, "i2c"); + if (fwnode && is_of_node(fwnode)) + id =3D of_alias_get_id(to_of_node(fwnode), "i2c"); + if (id >=3D 0) { adap->nr =3D id; ret =3D i2c_add_numbered_adapter(adap); @@ -3235,7 +3244,7 @@ int i3c_master_register(struct i3c_master_controller = *master, return ret; =20 master->dev.parent =3D parent; - master->dev.of_node =3D of_node_get(parent->of_node); + device_set_node(&master->dev, fwnode_handle_get(dev_fwnode(parent))); master->dev.bus =3D &i3c_bus_type; master->dev.type =3D &i3c_masterdev_type; master->dev.release =3D i3c_masterdev_release; @@ -3254,13 +3263,13 @@ int i3c_master_register(struct i3c_master_controlle= r *master, master->dev.coherent_dma_mask =3D parent->coherent_dma_mask; master->dev.dma_parms =3D parent->dma_parms; =20 - ret =3D i3c_bus_init(i3cbus, master->dev.of_node); + ret =3D i3c_bus_init(i3cbus, dev_fwnode(&master->dev)); if (ret) goto err_put_dev; =20 dev_set_name(&master->dev, "i3c-%d", i3cbus->id); =20 - ret =3D of_populate_i3c_bus(master); + ret =3D fwnode_populate_i3c_bus(master); if (ret) goto err_put_dev; =20 diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h index 4d2a68793324..a16deb04b2e1 100644 --- a/include/linux/i3c/master.h +++ b/include/linux/i3c/master.h @@ -177,7 +177,8 @@ struct i3c_device_ibi_info { * @pid: I3C Provisioned ID exposed by the device. This is a unique identi= fier * that may be used to attach boardinfo to i3c_dev_desc when the device * does not have a static address - * @of_node: optional DT node in case the device has been described in the= DT + * @fwnode: Firmware node (DT or ACPI) in case the device has been + * described in firmware * * This structure is used to attach board-level information to an I3C devi= ce. * Not all I3C devices connected on the bus will have a boardinfo. It's on= ly @@ -189,7 +190,7 @@ struct i3c_dev_boardinfo { u8 init_dyn_addr; u8 static_addr; u64 pid; - struct device_node *of_node; + struct fwnode_handle *fwnode; }; =20 /** --=20 2.43.0 From nobody Sat Jul 25 01:35:28 2026 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012045.outbound.protection.outlook.com [40.93.195.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A477831AF2D; Tue, 21 Jul 2026 04:09:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.45 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606982; cv=fail; b=M7uX0KBBk05Rqe6ZGXlvBOOYf25gdQqeNRXr5B+J1K5sH6W/uOnDtWzBBAkoRuFWf6WRSfNTLkz8V/pptj2W0OZkRQ+FPMmpWWndSInlqDZepFhApp36lrpagMOFzUn+DvIjpsXzfHoMN7LP/p5gqjuWRY1aWXsq5yx9sF4+9SA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606982; c=relaxed/simple; bh=mZAldA9p7Wn9wYizbdcuGQVPv8XxWSam0hxtchVzceA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m8UNjgfxwThnMn+gYSD1xAazArKWGI+OR3b2f0U31QchxftLFk4MD6Wqp12WFbGHJXhmuJAATz54WNHQcKTuBmDYPmQtkngVgMfTg6sdgvaMDdUi+2BKHVzFVt4spMysXWikq4d5f3nFSN1ALD/zyyi01D8eX1L5C89jSkUytvI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=nJWDE4F3; arc=fail smtp.client-ip=40.93.195.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="nJWDE4F3" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m8g9550DDg1tjcgxDaVuAFTkwF++s/AC40P11JBLlA9m+/CA+WKXW3mfFLN0rOaHRxx8MiptCfUh5FRzYclmzbECUgg/ed28EscoSQxKndln6kuQUAWKwCUK8WTQE6qgubjSNlpDpUoPNE8F0riPl5b1/BlNqGUuHyGQzbSIwBiRNsXz/tRxsaGTffDwDFxZX+wI2w1k/yp3YigQBrmF7mCgm03QMUgTf3pBeurSPoUKSNLVxk3I/ljfP5rpHIsSc+JQNsdTghMfdRd/SMXZ6jxrwu6JiAB89CQ4sdayHkLRT70E2mjTlW246/SCqH/1CCFiDgril4qlHqJUt+VSCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5tM29QjlfxY6WHV5Mq090YXd/R2iTJTveeFBrOS3eug=; b=VYthu5Ugcam/ohivc/pFd+skD+N40uwHVG9R3j4SZ2FI0WuihytDwPiE5rbQs+HGgtngnSfH4AjK1+21PybQMtLYb4EWHGCJX1D308j9j8/qZjCHXq1AsA7S3R6IhhCsMzoulWWlVewRyVCzjJJ8mkeGskvhVLMpltuitQbUva08BvIq2BLRIAtGMVjpW/F9rC7Mzo0MpS/Kuu7Twuq43BYpcQIIT+FrckUH0jeWnj76c+WlLSNh+vdsRDZ2vFNhwVVL7qjvbN/W+wNGbn4CkuG8UeAb7iRfLjh23Zy2rNTjkNWcM/8Fa1Uv29NlZKVXiXito1sbrGP3cTRMCg5k5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5tM29QjlfxY6WHV5Mq090YXd/R2iTJTveeFBrOS3eug=; b=nJWDE4F3kkd8duYL9Y+o8fY0THfw5YBpb0CWH3w8M+FdHCbJBO7wVS7WlNvgy6mFCjPKdTpXu6elzcQ27Oc5F+FJMiZL/e0T0h4Ipebl9xwkzZol5bwJg9WOaX6IDqHPHPKbvUyxMQeWqNOFzz0hP4oTaHDU43WFfsx3/ZLf0vCw4S4A4OAtYCQJIuVMZX4mi458PeDapCC4cfw/sdOflwp7WIa3Yf1IYW2kTCUtmQT30405LYUO9jzkkPydYM/nx2wpvcKDimYeH8vfwamtG9W02hSic3Kr85QRqdaUikB042OaK9u9tWa5fRiMKmBo7X2xIwtr8Ie9tPktZRBkfw== Received: from SJ0PR13CA0008.namprd13.prod.outlook.com (2603:10b6:a03:2c0::13) by IA0PR12MB8896.namprd12.prod.outlook.com (2603:10b6:208:493::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Tue, 21 Jul 2026 04:09:31 +0000 Received: from CO1PEPF00012E7D.namprd03.prod.outlook.com (2603:10b6:a03:2c0:cafe::35) by SJ0PR13CA0008.outlook.office365.com (2603:10b6:a03:2c0::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Tue, 21 Jul 2026 04:09:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF00012E7D.mail.protection.outlook.com (10.167.249.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:09:27 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 20 Jul 2026 21:09:10 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:09:10 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:09:05 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 03/12] i3c: master: Support ACPI enumeration of child devices Date: Tue, 21 Jul 2026 04:07:51 +0000 Message-ID: <20260721040805.1696503-4-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF00012E7D:EE_|IA0PR12MB8896:EE_ X-MS-Office365-Filtering-Correlation-Id: 6f32ed76-44a3-4af8-c4f6-08dee6dddb51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|7416014|376014|36860700016|82310400026|1800799024|13003099007|10063799003|56012099006|11063799006|10067099003|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: ajRC0S9fal+JTHc1/iZiVi4XCJFlRAQ9ky9atBkwsFB/aCLh2Il2wFP85pFLevu/ra2EERIAW+VyfFNDUOWH6kzaIPopeldrCSkDZbTF3DpORWhxXoPSVf8GoekyyNccM4jFNf1z6VLyvnfFg+UT1O+CLrjIsCk4cuX3vPJbWHLKPGoKo4phsUTUTfxoyyTqheKJ5mYKpEtpQBycCajY7P8UZoRzqrvlV34k3j/AKliL6LG0pR8YEf65tOZk28+k/FQ27OBoMFZyd1cicHZZCVp/URo3rjid2A09SIR6ELBa2bum3ygnrY6f+WwsoQ6zu+IoC7KHBGrdbleZbwA6gbpzM2zq9GH045VtNCp7rbllysMOuyXmT6mFEIlnwzGWLiUpXxRC2maNU8V06ONd52qpNuOuWDT4FZgFaZUJsvGMm8Fk93h4wEDJLGcePQjcEnot2i1/vnCDy0/1MrnyBaZma7ASHoKQ2oExLu8QXDLQ3iVX/h28dcUSTKfup1EXjrDE7D3l2hRW0UGx4FCda0yc4DoXnMWRGNMIGBr0sexAxkfS8mK0yxSTDXwWWxBaNrn2k+p6Y0Gzk5aYvhu8+Wo9+O+nOK72gJ8p/9RzVcTgJfjM/KFM6a+BtGBQgQiT/CV5tPms63AZCgf2eG5xonpYjxqPCTfu+v82wIK96ydDxl0fnAIWh0h9E4WhkxdkX06xttme4uPvNUbZWkwiPQ== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(23010399003)(7416014)(376014)(36860700016)(82310400026)(1800799024)(13003099007)(10063799003)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Dv5QyeMdaq9Fh5hc6sFHHozj42wI6WjmaMPW2xeqXKA7Cx1XpGjNp1uoz2FlvRnAVhmciO8ApK+6vBsO7/4Zhl/zEW7ZQqwU0IJYpRFmKG66xDppjz9dxOuLFyM/MUjzPWFj4W9rpSgH6ji3WRzCaaZIf7+1TjHHso/YCp0v+OCaTuEMtkAWzT78eUt9u8zZnV8pzo4ZllscRSKWojIN64a478u5oW1f3C2JV7yxtoqZ8X2lNetMHE7+nJtIvVRTujewSa+fAV5r1VHwwz510LPKMQVbElhMyVcb2qXLa2YtCqZqglLKwOWHlIixymlZXT4vFrb+lFxFrtV7Y8ZJd3m9YlfXsivemEdeEtcc9bosgTcuVeYlIUL9FIvrOE0H2Ns5LtqBR6U0pIeYlAJwfC6u8WraZaNm3EWycLao1QJpoVL5gQvUtUPecNFYX53t X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:09:27.3431 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6f32ed76-44a3-4af8-c4f6-08dee6dddb51 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF00012E7D.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8896 Content-Type: text/plain; charset="utf-8" Although the existing subsystem allows host controllers to register through the ACPI table, it was not possible to describe I3C or I2C devices when using ACPI. This is because the driver relied on the reg property to retrieve the PID, static address, etc., whereas ACPI uses _ADR or serial resources to describe such devices. Read _ADR and LVR from ACPI resources and extract the data as per the ACPI specification for an I3C bus. Also read mipi-i3c-static-address as per the MIPI DISCO specifications [1] to get the static address to be used. Enable describing I3C or I2C devices in the ACPI table. This is required if the device uses a static address or if it needs device-specific properties. [1] https://www.mipi.org/mipi-disco-for-i3c-download Reviewed-by: Frank Li Signed-off-by: Akhil R --- drivers/i3c/master.c | 151 ++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 143 insertions(+), 8 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 4b3d9628bc39..623c6b2247d9 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -5,6 +5,7 @@ * Author: Boris Brezillon */ =20 +#include #include #include #include @@ -2621,6 +2622,55 @@ EXPORT_SYMBOL_GPL(i3c_master_do_daa); =20 #define OF_I3C_REG1_IS_I2C_DEV BIT(31) =20 +#ifdef CONFIG_ACPI +static int i3c_acpi_get_i2c_resource(struct acpi_resource *ares, void *dat= a) +{ + struct i2c_dev_boardinfo *boardinfo =3D data; + struct acpi_resource_i2c_serialbus *sb; + + if (boardinfo->base.addr || !i2c_acpi_get_i2c_resource(ares, &sb)) + return 1; + + boardinfo->base.addr =3D sb->slave_address; + if (sb->access_mode =3D=3D ACPI_I2C_10BIT_MODE) + boardinfo->base.flags |=3D I2C_CLIENT_TEN; + + boardinfo->lvr =3D sb->lvr; + + return 1; +} + +static int i3c_acpi_add_i2c_boardinfo(struct i2c_dev_boardinfo *boardinfo, + struct fwnode_handle *fwnode) +{ + struct acpi_device *adev =3D to_acpi_device_node(fwnode); + LIST_HEAD(resources); + int ret; + + boardinfo->base.fwnode =3D acpi_fwnode_handle(adev); + acpi_set_modalias(adev, dev_name(&adev->dev), boardinfo->base.type, + sizeof(boardinfo->base.type)); + + ret =3D acpi_dev_get_resources(adev, &resources, + i3c_acpi_get_i2c_resource, boardinfo); + if (ret < 0) + return ret; + + acpi_dev_free_resource_list(&resources); + + if (!boardinfo->base.addr) + return -ENODEV; + + return 0; +} +#else +static inline int i3c_acpi_add_i2c_boardinfo(struct i2c_dev_boardinfo *boa= rdinfo, + struct fwnode_handle *fwnode) +{ + return -ENODEV; +} +#endif + static int i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master, struct fwnode_handle *fwnode, u32 *reg) @@ -2637,6 +2687,15 @@ i3c_master_add_i2c_boardinfo(struct i3c_master_contr= oller *master, ret =3D of_i2c_get_board_info(dev, to_of_node(fwnode), &boardinfo->base); if (ret) return ret; + + /* LVR is encoded in reg[2] for Device Tree. */ + boardinfo->lvr =3D reg[2]; + } else if (is_acpi_device_node(fwnode)) { + ret =3D i3c_acpi_add_i2c_boardinfo(boardinfo, fwnode); + if (ret) { + devm_kfree(dev, boardinfo); + return ret; + } } else { return -EINVAL; } @@ -2651,9 +2710,6 @@ i3c_master_add_i2c_boardinfo(struct i3c_master_contro= ller *master, return -EOPNOTSUPP; } =20 - /* LVR is encoded in reg[2]. */ - boardinfo->lvr =3D reg[2]; - list_add_tail(&boardinfo->node, &master->boardinfo.i2c); fwnode_handle_get(fwnode); =20 @@ -2708,8 +2764,8 @@ i3c_master_add_i3c_boardinfo(struct i3c_master_contro= ller *master, return 0; } =20 -static int i3c_master_add_dev(struct i3c_master_controller *master, - struct fwnode_handle *fwnode) +static int i3c_master_add_of_dev(struct i3c_master_controller *master, + struct fwnode_handle *fwnode) { u32 reg[3]; int ret; @@ -2733,6 +2789,74 @@ static int i3c_master_add_dev(struct i3c_master_cont= roller *master, return ret; } =20 +#ifdef CONFIG_ACPI +static int i3c_master_add_acpi_dev(struct i3c_master_controller *master, + struct fwnode_handle *fwnode) +{ + struct acpi_device *adev =3D to_acpi_device_node(fwnode); + acpi_bus_address adr; + u32 reg[3] =3D { 0 }; + int ret; + + /* + * If the ACPI table entry has _ADR method, it's an I3C device. + * Otherwise it may be an I2C device described by an I2cSerialBus + * resource. If no I2cSerialBus resource is found, ignore the entry. + */ + if (!acpi_has_method(adev->handle, "_ADR")) { + ret =3D i3c_master_add_i2c_boardinfo(master, fwnode, reg); + if (ret =3D=3D -ENODEV) + return 0; + + return ret; + } + + adr =3D acpi_device_adr(adev); + + /* For I3C devices, _ADR will have the 48 bit PID of the device */ + reg[1] =3D upper_32_bits(adr); + reg[2] =3D lower_32_bits(adr); + + fwnode_property_read_u32(fwnode, "mipi-i3c-static-address", ®[0]); + + return i3c_master_add_i3c_boardinfo(master, fwnode, reg); +} + +static u8 i3c_acpi_i2c_get_lvr(struct i2c_client *client) +{ + struct acpi_device *adev =3D to_acpi_device_node(client->dev.fwnode); + struct i2c_dev_boardinfo boardinfo =3D {}; + LIST_HEAD(resources); + int ret; + u8 lvr; + + lvr =3D I3C_LVR_I2C_INDEX(2) | I3C_LVR_I2C_FM_MODE; + + ret =3D acpi_dev_get_resources(adev, &resources, + i3c_acpi_get_i2c_resource, &boardinfo); + if (ret < 0) + return lvr; + + if (boardinfo.base.addr) + lvr =3D boardinfo.lvr; + + acpi_dev_free_resource_list(&resources); + + return lvr; +} +#else +static inline int i3c_master_add_acpi_dev(struct i3c_master_controller *ma= ster, + struct fwnode_handle *fwnode) +{ + return -ENODEV; +} + +static inline u8 i3c_acpi_i2c_get_lvr(struct i2c_client *client) +{ + return I3C_LVR_I2C_INDEX(2) | I3C_LVR_I2C_FM_MODE; +} +#endif + static int fwnode_populate_i3c_bus(struct i3c_master_controller *master) { struct device *dev =3D &master->dev; @@ -2744,7 +2868,13 @@ static int fwnode_populate_i3c_bus(struct i3c_master= _controller *master) return 0; =20 fwnode_for_each_available_child_node_scoped(fwnode, child) { - ret =3D i3c_master_add_dev(master, child); + if (is_of_node(child)) + ret =3D i3c_master_add_of_dev(master, child); + else if (is_acpi_device_node(child)) + ret =3D i3c_master_add_acpi_dev(master, child); + else + continue; + if (ret) return ret; } @@ -2812,8 +2942,13 @@ static u8 i3c_master_i2c_get_lvr(struct i2c_client *= client) u8 lvr =3D I3C_LVR_I2C_INDEX(2) | I3C_LVR_I2C_FM_MODE; u32 reg[3]; =20 - if (!fwnode_property_read_u32_array(client->dev.fwnode, "reg", reg, ARRAY= _SIZE(reg))) - lvr =3D reg[2]; + if (is_of_node(client->dev.fwnode)) { + if (!fwnode_property_read_u32_array(client->dev.fwnode, "reg", + reg, ARRAY_SIZE(reg))) + lvr =3D reg[2]; + } else if (is_acpi_device_node(client->dev.fwnode)) { + lvr =3D i3c_acpi_i2c_get_lvr(client); + } =20 return lvr; } --=20 2.43.0 From nobody Sat Jul 25 01:35:28 2026 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012006.outbound.protection.outlook.com [40.107.200.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE7AB37A830; Tue, 21 Jul 2026 04:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.6 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606991; cv=fail; b=gD5R9Bhr8YPqpDyxNvPkaYNTPymNqvoDUNggSule4Ggx8pOyDnvJ3amRbMm3SX3ceKZtw2DVI0lrwOLqFL61LPAStskgEA9D23W70Ot0hBCneMGMsQeCWvYaaSXjLvp/CnocM/ImLBQSXLlFwbQtarp4BvIHM3rmvFXc4LZWrzI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606991; c=relaxed/simple; bh=NNEQFtuJEazhQS0xMjvCnBK25S3y13Cp6HMiTnn4Kzg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OvWvDPsgKCYu5ywIG9tVQfjZ/PkiX25dGVj75bsTshwSCpc/gED9Bp75HPvaxyMaXutkqw5cL1YWE9bE82jNjn1QwrAFgqKzxnN6Zda54YEbS75sdqDCGn8iKbViLJtZV8aiqmASiL6SO13qqJxnzW1913wB7BKk9E/jiL1eXJ4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=ahYxH61d; arc=fail smtp.client-ip=40.107.200.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="ahYxH61d" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=gMimxcHOMe2vD8rbyS50fPFNExayHHPV9i7vaI1nqRwDEbOFNFekl/1aeInVeVeI7rvgvDaCLZb3pniCGKz67gXIVSJCdP05sY9qvAAuS73Qc0tP1jM5mgvNOuizXm1M4WkgKXJpgsXEV3hC1Om+6e19dwATs4vToLTydpMvFRvIlleHUqdnEiytdBYBSXwzVYjzjdjeupirE3t/v9BsQER6+ahOjdBVHG1A0pEVjvL2ckM008VK14s3RcKhgFtwOL0vL8LZkJgyH5w8g78q8Bcj1cbumqXQxsBF1Q4/yhh6pGTJO5D6VbR9txuCQYx27J/9ZhTLYZvB1zOKnPd3JA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RKtedArzqpORfxTFslWjlQOjWlrGCvUH93J1jOEP9pg=; b=Svc0m1rdah+H1o9V/C/fvpb8enKVMKt3KMwAm/N4bg8TPA+UPsPfOkFzoTH5CNS52vcpGhI8mhJ8TBqyj2BtR2kv5mg+lhxnXW49jJUwYIEurNYxwOOzwOIOV+ira4bbUcc8/fMowLT7B11OuwBdLcdt5nEGLUmC7JaaPI86V5l6O27FsUTSlF76pnLocgGCRyeNvKVAxJNB/sQ66h+2iccpn/kfCJZpllXlFASLBVqc88sar083QgJ8bx+h/s/zaWXD5NUM0AU7yszOAlsrwyX/hPXwTPJ65Si2KOk5Pb8WnKARjj1zpmH72/6Cd6HyGtHYRChmt3kxtnSUMH70bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RKtedArzqpORfxTFslWjlQOjWlrGCvUH93J1jOEP9pg=; b=ahYxH61djrBfh3yQT2zSOko47YO25rdpPJTUR/BSXamGd00j9lzL6urCfCoG2QVHbHJE38Kzr7JVIF4taaj2uTkZAQ9XRaoqWB4VN0dewwEkGXDgMmenb74xtLl7npMiVKTWF8jFiriB6/vSTFVEza1L+hp2lmLFdGMU+BmiVaO+9NtUVUZkRO3RMXcYyQBaxIbjzb8dA0vqubHbnBQlUktKOeR72Nqy5ezYbG6et+PDvlGZzvqqA1mLkzISMePsm7XpJoptyOQLogRouLSMSkWDz7ibNwl03POLl9y6ps18zjfNPKa0uqGSKDgBRPPNsV7bMdiNT95uKFU+BW7y4g== Received: from BL1PR13CA0085.namprd13.prod.outlook.com (2603:10b6:208:2b8::30) by PH8PR12MB7373.namprd12.prod.outlook.com (2603:10b6:510:217::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Tue, 21 Jul 2026 04:09:38 +0000 Received: from BL02EPF0001A104.namprd05.prod.outlook.com (2603:10b6:208:2b8:cafe::1d) by BL1PR13CA0085.outlook.office365.com (2603:10b6:208:2b8::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Tue, 21 Jul 2026 04:09:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF0001A104.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:09:37 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:09:20 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:09:20 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:09:15 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 04/12] i3c: master: Add support for devices using SETAASA Date: Tue, 21 Jul 2026 04:07:52 +0000 Message-ID: <20260721040805.1696503-5-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A104:EE_|PH8PR12MB7373:EE_ X-MS-Office365-Filtering-Correlation-Id: ded1cf30-a0de-4e9b-e724-08dee6dde140 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|36860700016|7416014|376014|1800799024|3023799007|6133799003|10067099003|5023799004|56012099006|11063799006|13003099007|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: vsLBgjAeZI/tfWsAWOvvvz65e0U4SqCwvVOxzLjRhbbc3P8BCswh+1vdinQxj6F/KRIXJKUkQ/XhuHCXySKW27PXeL1Xf8qbajVGnVCdeCMhdkXhI4rfVIzxN/oL3TDnyv2GaHfFr1hsmuDQgSBWba8tlh+vfJDbz+t2ZM0is70RsPZDAGuwoT6t+GZASEd4Gb6dP7HxiwnTMwI0pzb7wqXX2ULL5XlLDeCP5p2BseJUU8S+oIO/FmcE0amB8KWjqeVo8p3JtIQs33v27TrKqhUsrplzuYWrvJP+CrSGiMKMSBOhgNQTw59Q4LSLHtw9nPpnEbKXyYKb4fTnSC167XoClVv30ggvqZ/lZMBKxTE/qxNtyzHarNecKWK3lw/uH/hD75aUhDo45YslEiUHtYtzH+4GgoREsDLLqX3U4QV3xbr06/ZrU/3c2f/OwE0NWWyYlGNrASKt/tfGpIl6mGR8Ys1+apoTUDERbY8bmEkhR8I4YnGmU+tqGRt9qBCxdIDHvpHb3zVowwLnP3sGykjO3zle31KUXwQlJhckrdvluPic4OhwiEftzH43ZARFBm/r8D3PmP5q8y98Sk8uwHkUjYObxkaGC0rpd2VhhhlQMqaBGfmZeYRoeXWh24uJi/vXfKlX6l0XNbgqkEjGvB0ceLC0zaThDgjPbXtiqSVCb0a528s6CDFJq1S8qMgxzwNgiwRFV9NBH9dLisq39A== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(36860700016)(7416014)(376014)(1800799024)(3023799007)(6133799003)(10067099003)(5023799004)(56012099006)(11063799006)(13003099007)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XyDB2NYmyDIsBfw/7vsRQn/gXOFGXwzi1r7QkwPYW3+kIank9GwWgUci6rUlYWcTuI+P/Zh0xQc7fbXtCWHuS50ZQgQesAh7S9tYKYxQxwootNvF802sS7gdUzvF5fkla069e+6BlCI3+RdGBagfX+lO5gQTKexd1SbHGH7rqnkxlKL8ZWXOMTvetgbACwjr2O4o/tGfwYKR9L8JzV3AGzjODQnG1HlfH8vRJJGyBrtURb1iGGqOdoSuyMU5vcauW3+BhwAQDeEMP0LYwYxzjWdzRYXaIH6uMHi2VthbwTxNVErU+d/9bT+mwr7umNGMF2/3x90ng+2e8x3MJF2PMUe6m1jMaBVtS0Pf85lLeUq5eeYn87Y+T2abNzPpfc1NQCzU9CffMAqZn/Fs4bp8ZNcRN3QuyMCQ7moVLPWP2Kgtp+2G5P8oPHd8GuOHC3vY X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:09:37.2563 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ded1cf30-a0de-4e9b-e724-08dee6dde140 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A104.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7373 Content-Type: text/plain; charset="utf-8" Add support for devices using SETAASA, such as SPD5118 and SPD5108 attached to DDR5 memory modules that do not support ENTDAA. Follow the guidelines proposed by the MIPI Discovery and Configuration Specification [1] for discovering such devices. SETAASA (Set All Addresses to Static Address) differs from standard I3C address assignment that uses ENTDAA or SETDASA to assign dynamic addresses. Devices using SETAASA assign their pre-defined static addresses as their dynamic addresses during DAA, and it is not mandatory for these devices to implement standard CCC commands like GETPID, GETDCR, or GETBCR. For such devices, it is generally recommended to issue SETHID (specified by JEDEC JESD300) as a prerequisite for SETAASA to stop HID bit flipping. [1] https://www.mipi.org/mipi-disco-for-i3c-download Signed-off-by: Akhil R --- drivers/i3c/master.c | 98 +++++++++++++++++++++++++++++++++++++- include/linux/i3c/ccc.h | 1 + include/linux/i3c/master.h | 15 ++++++ 3 files changed, 113 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 623c6b2247d9..b18dda89c473 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -5,6 +5,7 @@ * Author: Boris Brezillon */ =20 +#include #include #include #include @@ -1102,6 +1103,51 @@ static int i3c_master_rstdaa_locked(struct i3c_maste= r_controller *master, return ret; } =20 +/** + * i3c_master_setaasa_locked() - start a SETAASA procedure (Set All Addres= ses to Static Address) + * @master: I3C master object + * + * Send a SETAASA CCC command to set all attached I3C devices' dynamic add= resses to + * their static address. + * + * This function must be called with the bus lock held in write mode. + * + * First, the SETHID CCC command is sent, followed by the SETAASA CCC. + * + * Return: 0 in case of success, a positive I3C error code if the error is + * one of the official Mx error codes, and a negative error code otherwise. + */ +static int i3c_master_setaasa_locked(struct i3c_master_controller *master) +{ + struct i3c_ccc_cmd_dest dest; + struct i3c_ccc_cmd cmd; + int ret; + + /* + * Send SETHID CCC command. Though it is a standard CCC command specified + * in JESD300-5, we are not defining a separate macro to be explicit that + * the value falls under the vendor specific range. + */ + i3c_ccc_cmd_dest_init(&dest, I3C_BROADCAST_ADDR, 0); + i3c_ccc_cmd_init(&cmd, false, I3C_CCC_VENDOR(0, true), &dest, 1); + ret =3D i3c_master_send_ccc_cmd_locked(master, &cmd); + i3c_ccc_cmd_dest_cleanup(&dest); + if (ret && cmd.err =3D=3D I3C_ERROR_M2) + ret =3D 0; + if (ret) + return ret; + + /* Send SETAASA CCC command */ + i3c_ccc_cmd_dest_init(&dest, I3C_BROADCAST_ADDR, 0); + i3c_ccc_cmd_init(&cmd, false, I3C_CCC_SETAASA, &dest, 1); + ret =3D i3c_master_send_ccc_cmd_locked(master, &cmd); + i3c_ccc_cmd_dest_cleanup(&dest); + if (ret && cmd.err =3D=3D I3C_ERROR_M2) + ret =3D 0; + + return ret; +} + /** * i3c_master_entdaa_locked() - start a DAA (Dynamic Address Assignment) * procedure @@ -1878,6 +1924,22 @@ static int i3c_master_early_i3c_dev_add(struct i3c_m= aster_controller *master, if (ret) goto err_free_dev; =20 + /* + * For devices using SETAASA instead of ENTDAA, the address is statically + * assigned. Update the dynamic address to the provided static address. + * Reattach the I3C device after updating the dynamic address with the sa= me + * static address. It is not mandatory for such devices to implement CCC + * commands like GETPID, GETDCR etc. Hence, we can return after reattachi= ng. + */ + if (i3cdev->boardinfo->static_addr_method & I3C_ADDR_METHOD_SETAASA) { + i3cdev->info.dyn_addr =3D i3cdev->boardinfo->static_addr; + ret =3D i3c_master_reattach_i3c_dev_locked(i3cdev, 0); + if (ret) + goto err_rstdaa; + + return 0; + } + ret =3D i3c_master_setdasa_locked(master, i3cdev->info.static_addr, i3cdev->boardinfo->init_dyn_addr); if (ret) @@ -2272,6 +2334,19 @@ static int i3c_master_bus_init(struct i3c_master_con= troller *master) i3c_master_early_i3c_dev_add(master, i3cboardinfo); } =20 + /* + * SETAASA is a broadcast CCC. Issue it after SETDASA so that devices + * configured for SETDASA (or supporting both methods) are assigned + * first, matching MIPI DISCO guidance to prefer SETDASA when both are + * available. Targets that already have a dynamic address ignore the + * later SETAASA broadcast. + */ + if (master->addr_method & I3C_ADDR_METHOD_SETAASA) { + ret =3D i3c_master_setaasa_locked(master); + if (ret) + goto err_rstdaa; + } + ret =3D i3c_master_do_daa(master); if (ret) goto err_rstdaa; @@ -2723,7 +2798,7 @@ i3c_master_add_i3c_boardinfo(struct i3c_master_contro= ller *master, struct i3c_dev_boardinfo *boardinfo; struct device *dev =3D &master->dev; enum i3c_addr_slot_status addrstatus; - u32 init_dyn_addr =3D 0; + u32 init_dyn_addr =3D 0, static_addr_method =3D 0; =20 boardinfo =3D devm_kzalloc(dev, sizeof(*boardinfo), GFP_KERNEL); if (!boardinfo) @@ -2741,7 +2816,19 @@ i3c_master_add_i3c_boardinfo(struct i3c_master_contr= oller *master, =20 boardinfo->static_addr =3D reg[0]; =20 + if (!fwnode_property_read_u32(fwnode, "mipi-i3c-static-method", &static_a= ddr_method)) + boardinfo->static_addr_method =3D static_addr_method & + (I3C_ADDR_METHOD_SETDASA | I3C_ADDR_METHOD_SETAASA); + if (!fwnode_property_read_u32(fwnode, "assigned-address", &init_dyn_addr)= ) { + /* + * When a device advertises both SETDASA and SETAASA, an explicit + * dynamic address selects SETDASA (MIPI DISCO prefers it); drop + * SETAASA so it is not used for this device. + */ + if (boardinfo->static_addr_method & I3C_ADDR_METHOD_SETDASA) + boardinfo->static_addr_method &=3D ~I3C_ADDR_METHOD_SETAASA; + if (init_dyn_addr > I3C_MAX_ADDR) return -EINVAL; =20 @@ -2751,6 +2838,14 @@ i3c_master_add_i3c_boardinfo(struct i3c_master_contr= oller *master, return -EINVAL; } =20 + if (boardinfo->static_addr_method & I3C_ADDR_METHOD_SETAASA) { + /* For SETAASA, static address is taken as the dynamic address. */ + init_dyn_addr =3D boardinfo->static_addr; + } + + /* Update the address methods required for device discovery */ + master->addr_method |=3D boardinfo->static_addr_method; + boardinfo->pid =3D ((u64)reg[1] << 32) | reg[2]; =20 if ((boardinfo->pid & GENMASK_ULL(63, 48)) || @@ -3385,6 +3480,7 @@ int i3c_master_register(struct i3c_master_controller = *master, master->dev.release =3D i3c_masterdev_release; master->ops =3D ops; master->secondary =3D secondary; + master->addr_method =3D I3C_ADDR_METHOD_SETDASA; INIT_LIST_HEAD(&master->boardinfo.i2c); INIT_LIST_HEAD(&master->boardinfo.i3c); =20 diff --git a/include/linux/i3c/ccc.h b/include/linux/i3c/ccc.h index ad59a4ae60d1..a145d766ab6f 100644 --- a/include/linux/i3c/ccc.h +++ b/include/linux/i3c/ccc.h @@ -32,6 +32,7 @@ #define I3C_CCC_DEFSLVS I3C_CCC_ID(0x8, true) #define I3C_CCC_ENTTM I3C_CCC_ID(0xb, true) #define I3C_CCC_ENTHDR(x) I3C_CCC_ID(0x20 + (x), true) +#define I3C_CCC_SETAASA I3C_CCC_ID(0x29, true) =20 /* Unicast-only commands */ #define I3C_CCC_SETDASA I3C_CCC_ID(0x7, false) diff --git a/include/linux/i3c/master.h b/include/linux/i3c/master.h index a16deb04b2e1..2dc139a217bf 100644 --- a/include/linux/i3c/master.h +++ b/include/linux/i3c/master.h @@ -174,6 +174,14 @@ struct i3c_device_ibi_info { * assigned a dynamic address by the master. Will be used during * bus initialization to assign it a specific dynamic address * before starting DAA (Dynamic Address Assignment) + * @static_addr_method: Bitmap describing which methods of Dynamic Address + * Assignment from a Static Address are supported by this I3C Target. + * A value of 1 in a bit position indicates that the I3C target + * supports that method, and a value of 0 indicates that the I3C + * target does not support that method. + * Bit 0: SETDASA + * Bit 1: SETAASA + * All other bits are reserved. * @pid: I3C Provisioned ID exposed by the device. This is a unique identi= fier * that may be used to attach boardinfo to i3c_dev_desc when the device * does not have a static address @@ -189,6 +197,7 @@ struct i3c_dev_boardinfo { struct list_head node; u8 init_dyn_addr; u8 static_addr; + u8 static_addr_method; u64 pid; struct fwnode_handle *fwnode; }; @@ -517,6 +526,11 @@ struct i3c_master_controller_ops { * @boardinfo.i2c: list of I2C boardinfo objects * @boardinfo: board-level information attached to devices connected on th= e bus * @bus: I3C bus exposed by this master + * @addr_method: Bitmap describing which methods of Address Assignment req= uired + * to be run for discovering all the devices on the bus. + * Bit 0: SETDASA + * Bit 1: SETAASA + * All other bits are reserved. * @wq: freezable workqueue which can be used by master * drivers if they need to postpone operations that need to take place * in a thread context. Typical examples are Hot Join processing which @@ -552,6 +566,7 @@ struct i3c_master_controller { struct list_head i2c; } boardinfo; struct i3c_bus bus; + u8 addr_method; struct workqueue_struct *wq; struct work_struct hj_work; struct work_struct reg_work; --=20 2.43.0 From nobody Sat Jul 25 01:35:28 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011041.outbound.protection.outlook.com [40.107.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 54AB73815D5; Tue, 21 Jul 2026 04:09:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.41 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606998; cv=fail; b=meKlkRHAns1Ftt8r3uaidZroYGrdZzwijmlc95j8xC9KSlPFVjnpacyL6ZZaFv+x0jMQy93X7Ru2lP6Xp1BPckVBH6CYUpJLoLrq2Dje8F9DgHX7Cp3FGXLBcLMV2cnXHbb4u7EUQZMZEN8TKlXtE8bDW3aEBjsZm+xtD4Cq6JA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784606998; c=relaxed/simple; bh=8vwx60oPtu54qGE2WiOjCk9EDV3oLvXNz+QUZxdrnk4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=D3MfqrX5GlEmXbO1xu6FvZ6lkXM8OkR9K/fRUoRBjR/KxWv1Oiyf+BX/Y2BTJHT9opxZl7ecFXhUsWrp+7JsnT7Ls/vSXCdj7gmSXgqJBlwelh2zfZZeRExO9M6eWpw23jvsXyQ2VD3Q6PyJFsA96OXwIzfiNwUMRW3XUKxgz0w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=op4goMzx; arc=fail smtp.client-ip=40.107.208.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="op4goMzx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jmi4WNmd7S4bvsaiyrOImiM39bL9D6dbLNDPaQPwq6gFTEzvNNZ6S2oM+PdE2dPc24orGcZnGXKuaDj+rt4JYf6N666xQbjHpn5SdQqWxMkoUNTJQ3wRk0n3P83lht9xRKaYHQU8JWq5g6xVcSj/+3pC4UmTJ8ilsx8ufVS2ll5HjH8BtheHGsuexWLyh7d52miJE6EkMgSSIFAlJT+LD1rlscH7TLecWtUH46kjzs6svZKb0B2BJ7vtRXc8d2tpmrS6jnXbT5Bq9Um0anQVV2K1HfuAsc7AQQHjZH4vNoV0UnJdpfTBeri2jShwLji6AwX/obCDQcnBgrJvV77cEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d0KvMEGdivcyfi4VJcwy8JfhNT/9IT9/puyMMiZKxYg=; b=iAjNV1/aBmS38iQC57dpkcht94HFm/tDr6DHd9xBbHhxo7gieJVWDUdJRa0NY5Rdwyext/rQp+xsL2QvLCQhIl6nGUYPZDhpDbKLeo766LLlhBXuqsGgSsejara3PjVJLWBzWj4G2Z1e35Il5D+bL3bsMTdq6pFcs+WTBHzaanFm6CzVNZbkCH8sc+4a0jlJl8QpMNrYkMt1hvdGDMkZn2zZCr8GCYpQ02hHhUp52yZAHX5WfUuXSHneHLiEsdd3L7rmB8wp2dg3JhPsw1xGE1beTruOPV6clt2VpTMmqWLQqYRO1JzHMIvIBP4F0HZv0Strd/W51x5KO6ACnc5vDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d0KvMEGdivcyfi4VJcwy8JfhNT/9IT9/puyMMiZKxYg=; b=op4goMzx7A9NaICn8wGBPrxA4LUEbYwl0k8HVQlL0dxDHfDm/DM01VaAAD0ACp+fjypIf2Qb15wAWJ48JYC56dwtF64pKRt2KkdJhuTi41OZq9CFwR5Z0AXWyAEh83oQtq29s+5arkZ/m+RhXZivszObqg9nnMGuut9b2XXRpYU7f/bF0/vgtqdJKrWtFgtwtNpXXam2xXeShMabF1YoGl2WQzabWGm89iqYpFfItjjGHgHpFBkLCntGOtKbJMMlqWHOA02frfk0hq35I9f7kD3Bc0joT8R0iVggeOzWFSfx1/9owdqY3mst4AdqDgCjQftovsaxf2DcCVbhiumMRQ== Received: from IA4P220CA0001.NAMP220.PROD.OUTLOOK.COM (2603:10b6:208:558::14) by SA3PR12MB9091.namprd12.prod.outlook.com (2603:10b6:806:395::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Tue, 21 Jul 2026 04:09:49 +0000 Received: from BL02EPF0001A103.namprd05.prod.outlook.com (2603:10b6:208:558:cafe::7) by IA4P220CA0001.outlook.office365.com (2603:10b6:208:558::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Tue, 21 Jul 2026 04:09:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF0001A103.mail.protection.outlook.com (10.167.241.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:09:47 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:09:31 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:09:29 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:09:24 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 05/12] i3c: master: Add support for devices without PID Date: Tue, 21 Jul 2026 04:07:53 +0000 Message-ID: <20260721040805.1696503-6-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A103:EE_|SA3PR12MB9091:EE_ X-MS-Office365-Filtering-Correlation-Id: 87b6c412-75f7-4948-f300-08dee6dde79f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|7416014|376014|82310400026|1800799024|56012099006|11063799006|10067099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: kN3xtrWy8QAiJPPjNN8HBCAxenyj4OWZzZjEpUiRRZaIXSbv6b47ROXgY/eJC6+rVN68JysWENos5h8WH+cO4VVYkc2a6SmpnJexN7zPERf6Fd0rJ8cOgXzFzvKq15tedjzfcUWf9FjcoRA1u1Xn5MeWe3lXk8YkbPZAE856WGkEXZxTlAaDh+Ftcfcv93+sGmYF9oygVqA5iBD2IipLvLvxzmq121LsFQbsZ1UPhefjM+U/Eu6eTZQ7+nvSyoLflZBz61JvM4fcjjI0IPiElCD0JHmWZrSdO0spv5Pb/HEfNCc0ugu1zuVDk49iSexrg9gIXYzxTPsbqejbPRVLxvblDAnWoq8aGGiuK92O6iLJO1XTnlZ270ZS8rrp8+sp6OGli1RYmRhRqB9wC9AargCx+KJ+pfryWq2PBRhtcKYB8jZlMAIKxfWAzo8M75Hxy8eB7ZL6O+WxWvmp5RpDX80RD2JDz87006ETcgqvQvIlbjIpIhF1s69XL5wfiFTmTF4j2v97jFSTWVbVWpEFWs198EV8Iy+sMvwDYhs0GKYW0qDASwt6cl7wUNf96bTozriYCUtRk1nqE4S44BqZTfP/1yaJ0xCWkWXHzWE97EFCfk/GXMdaoITbYwm49kV5m6U1SFjVlYZOcXLQh5usPAG0Mn0gQtHVJzkwmvcYKX8IcNpRM3AYhxJhjuZjgSIkcq7krtT4Wj7J0UaFtiGiRA== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(7416014)(376014)(82310400026)(1800799024)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: xqjZcEpOhZ9dZpnx2IwMzKyb/t/pbWC4Mv4+zx7hOcupweHQbw0Cc/7FLFwueHk8SK3poYNZuXo7HEvYp2/0ObqLxcUjY6e5pCCIf+ct0UBuT80xU5uWOC6rYlFagTIDsbbh2feIwjfae/tnfzs5HK+BXb0GL+jEU1ionHNXHvcabo7FZV3z0WuszCHRGUowB3+DdQmWdegZ/J4RSFO4Uod2eQtsE51w1Lu73xaGV2fXj8GA+FaQc0t2b9zmBsu94nveYCb0ervc7j3LOTnTKlcAN5uKOb7DgecN6iEJUa/lV2cxcGPlqpCYgHtkXIaERo00CDXEI01kw3PwjWi1aHYkHcfYN/hSiJzLWFJNPfYwW8JrPcEVzo2f19VtEYywaYE1bqV5k3PZP8RLJ5flwY1nFaewmN+bx/sDP6XPHZtzhqZ8S5U3DKMmZKYhN8hQ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:09:47.9586 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 87b6c412-75f7-4948-f300-08dee6dde79f X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A103.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB9091 Content-Type: text/plain; charset="utf-8" Devices using SETAASA for address assignment are not required to have a 48-bit PID according to the I3C specification. Allow such devices to register and use the static address where PID was required. Reviewed-by: Frank Li Signed-off-by: Akhil R --- drivers/i3c/master.c | 52 ++++++++++++++++++++++++++++++++++---------- 1 file changed, 41 insertions(+), 11 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index b18dda89c473..7b2f819bf443 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1989,8 +1989,17 @@ i3c_master_register_new_i3c_devs(struct i3c_master_c= ontroller *master) desc->dev->dev.type =3D &i3c_device_type; desc->dev->dev.bus =3D &i3c_bus_type; desc->dev->dev.release =3D i3c_device_release; - dev_set_name(&desc->dev->dev, "%d-%llx", master->bus.id, - desc->info.pid); + + /* + * For devices without PID (e.g., SETAASA devices), use + * static address for naming instead. + */ + if (desc->info.pid) + dev_set_name(&desc->dev->dev, "%d-%llx", master->bus.id, + desc->info.pid); + else + dev_set_name(&desc->dev->dev, "%d-%02x", master->bus.id, + desc->info.static_addr); =20 if (desc->boardinfo) device_set_node(&desc->dev->dev, desc->boardinfo->fwnode); @@ -2389,8 +2398,18 @@ static void i3c_master_attach_boardinfo(struct i3c_d= ev_desc *i3cdev) struct i3c_dev_boardinfo *i3cboardinfo; =20 list_for_each_entry(i3cboardinfo, &master->boardinfo.i3c, node) { - if (i3cdev->info.pid !=3D i3cboardinfo->pid) - continue; + /* + * For devices without PID (e.g., SETAASA devices), match by + * static address. For devices with PID, match by PID. + */ + if (i3cboardinfo->pid) { + if (i3cdev->info.pid !=3D i3cboardinfo->pid) + continue; + } else { + if (!i3cboardinfo->static_addr || + i3cdev->info.static_addr !=3D i3cboardinfo->static_addr) + continue; + } =20 i3cdev->boardinfo =3D i3cboardinfo; i3cdev->info.static_addr =3D i3cboardinfo->static_addr; @@ -2404,8 +2423,12 @@ i3c_master_search_i3c_dev_duplicate(struct i3c_dev_d= esc *refdev) struct i3c_master_controller *master =3D i3c_dev_get_master(refdev); struct i3c_dev_desc *i3cdev; =20 + if (!refdev->info.pid) + return NULL; + i3c_bus_for_each_i3cdev(&master->bus, i3cdev) { - if (i3cdev !=3D refdev && i3cdev->info.pid =3D=3D refdev->info.pid) + if (i3cdev !=3D refdev && i3cdev->info.pid && + i3cdev->info.pid =3D=3D refdev->info.pid) return i3cdev; } =20 @@ -2848,9 +2871,16 @@ i3c_master_add_i3c_boardinfo(struct i3c_master_contr= oller *master, =20 boardinfo->pid =3D ((u64)reg[1] << 32) | reg[2]; =20 - if ((boardinfo->pid & GENMASK_ULL(63, 48)) || - I3C_PID_RND_LOWER_32BITS(boardinfo->pid)) - return -EINVAL; + /* For SETAASA devices, validate the static address instead of PID */ + if (boardinfo->static_addr_method & I3C_ADDR_METHOD_SETAASA) { + if (!boardinfo->static_addr) + return -EINVAL; + } else { + if (!boardinfo->pid || + (boardinfo->pid & GENMASK_ULL(63, 48)) || + I3C_PID_RND_LOWER_32BITS(boardinfo->pid)) + return -EINVAL; + } =20 boardinfo->init_dyn_addr =3D init_dyn_addr; boardinfo->fwnode =3D fwnode_handle_get(fwnode); @@ -2873,10 +2903,10 @@ static int i3c_master_add_of_dev(struct i3c_master_= controller *master, return ret; =20 /* - * The manufacturer ID can't be 0. If reg[1] =3D=3D 0 that means we're - * dealing with an I2C device. + * I3C device should have either the manufacturer ID specified or the + * address discovery method specified. Else treat it as an I2C device. */ - if (!reg[1]) + if (!reg[1] && !fwnode_property_present(fwnode, "mipi-i3c-static-method")) ret =3D i3c_master_add_i2c_boardinfo(master, fwnode, reg); else ret =3D i3c_master_add_i3c_boardinfo(master, fwnode, reg); --=20 2.43.0 From nobody Sat Jul 25 01:35:28 2026 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010067.outbound.protection.outlook.com [40.93.198.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D893038239C; Tue, 21 Jul 2026 04:10:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.67 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607010; cv=fail; b=g5Chn66nDT81VTcf/ulw3UQLC8buHqlXhzsi/Al8dxdmshVqDOLzq9oVF0wuUYfV5fu63sln4DXsTwme2oW4qhxLVQmx/sAdBXs8Gptt+hemP72GOdQHbz+YH6LOLdTC+OGGCZfSUhr4iinOK1ZaNVfosAUUphdPFm9czJ+1Qng= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607010; c=relaxed/simple; bh=rZ+qdnjj/8lNOG7tPLQ2HW9zyhHyFHyl+//wFSSGE/Y=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nw7UVJbdn9csBHwVG4c3L7sGW4iRKJmW4WTa4I3cdjvySj6XS0bP4DXIvCaFM2SwStwGf+5A2P5sDO+xzptZqfp3J8mc95/xdnaro5uj40uhqbuK29Bq344Kn2aOVnIdUpVivWmtqD+QXle60e6U+ibtoUODMZT+DyEtbwe2c70= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=DX0XYqBx; arc=fail smtp.client-ip=40.93.198.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="DX0XYqBx" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NcFar59jo+9AZZ8esbVEhbP+xxiuO502bzl3xZiOaCml9VZuUJggiak6vvwEOMGoFvX5+56OOlKQhIRxig4IwVBjF8ozj+t8O/IcDsT51dbWsbX1LUU0I3FE/8N+q/J7IF0Z8etTutdnh+XcjsV4hgeINzWmk55rJJ0E9O2eOoaMi66wi50sd1PpV0tQh1Aq5Gmu0JJXNvBh4Sr7DrCL81j/EZczHE0942Ke9JUJRZhnMFfjsROx4AcF3vYCSpp6a/FKncdqZEhw5mXiHuKSRU4Tw0yX5z9KsTMGRWhmI2qwSwxuL2V/K54tsi9/5g8WgK/Ot7/RfNlSkWe1Nz/LlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RzU4edY5L5tlUhQvonXWMX8fnWw95mmqaeYsObMnS10=; b=TMI9Tbq+nsreUw94XVgiVJuTJqj8+fMka8Q75DU8h9XN7ciJ/JYSBtEfMvSUS/Vt82nYDPs3EGEcv0wk6plp138NtYy1zjrSMXltc4gvfTIdguHdS4ixNHs3PfcUCdux+fDWjZP5n4jKxC3OtIVZKuHYGekKPLoFsWk8xdBddEPeNOOEH91NVCvO/fSFYX86OKGH8Ex02h9zEm6aNO0T2Ne7ayfR/VcvHJx/dTsgnoVpZxu+aze7dhrQuOSVmHqyYbJlZvKyQzo+N1tWCyvcdGHB5oSwXyzjhSBtgB961UeFOBQH77gUJ1A8kHQoCfVDEmXsqAv2oln/F9RorRLLrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RzU4edY5L5tlUhQvonXWMX8fnWw95mmqaeYsObMnS10=; b=DX0XYqBxoWDsREBIMm03X+PWfYFNVoUmmzBnWKs7CrTcRIC2a/kT4jSO8yFmK42podbyQEz24WVPrf9eEbhesOxzQJ1bTj5NEyy0q3c9SOV0idgUmvY3KC08x4rMkUT6OxIbrpt98kEEMdHuRJOiZmsKUoTxqoBFbS6UUQuFjxQh3HcWgsbX6vENepz4niP66d/2T6F4r8qQgWpebYVNEc63rEZii1r03EK16LiPJyZp/6AT2dKzbhnS5J/kANbs+Kv7M7GEKKV7qbYbOyDzgk1CojPN7OM2ankpDGDoU7PPSQMyBx20jzX3uQMkcBhIbgDr3R06FPBnWNwNNhsxCg== Received: from CH0PR03CA0104.namprd03.prod.outlook.com (2603:10b6:610:cd::19) by DS2PR12MB9797.namprd12.prod.outlook.com (2603:10b6:8:2ba::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Tue, 21 Jul 2026 04:10:00 +0000 Received: from CH3PEPF0000000A.namprd04.prod.outlook.com (2603:10b6:610:cd:cafe::ad) by CH0PR03CA0104.outlook.office365.com (2603:10b6:610:cd::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.223.18 via Frontend Transport; Tue, 21 Jul 2026 04:10:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH3PEPF0000000A.mail.protection.outlook.com (10.167.244.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:09:58 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 20 Jul 2026 21:09:40 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:09:39 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:09:35 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 06/12] i3c: master: match I3C device through DT and ACPI Date: Tue, 21 Jul 2026 04:07:54 +0000 Message-ID: <20260721040805.1696503-7-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF0000000A:EE_|DS2PR12MB9797:EE_ X-MS-Office365-Filtering-Correlation-Id: e5cc349d-cbd0-4b5b-36be-08dee6ddee15 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|82310400026|36860700016|7416014|376014|1800799024|3023799007|10067099003|56012099006|11063799006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: +64zfNDV9uHwL/f09V8zNIzwE6bxGCu+6YTQmOB4Emy64mkhfqsa+7hjuGqRR2FomKC33t8fUokcQq45P6YosF3ALBq9n4+rTHzvGRMjDeebF8vEVzUbmqkY68BiJcSwoC5GrP/7zvLxO9O0GgO8GnAoe6FK4bQ2fJWx4fRhJ84yLfzKIglFian0PtwuqTpb7OWr/GqoJ3QW0Mr3DI9GXFAl2w3EQ6Q1FSrH1No4wFQ1rp0F8u5D4YXVbrzzFACoMZSiLl8QaxCuOEND2yV23AvIsPERf+iQpe600q+4F0Zn3LGRMQ3NCcn/FJLix80nAvVzoIdOWC0FUP2c2cyhfgPfZvwtVu7Wm/84guPGDMbRLVNf0DeUO+i9F/di1qJfDcOZfGDWC2H1p9PDQfQ58YmrAn5Je9ywdBBLnp/sPiBuoA5lICfdnowX1rDCpaLaZe4c7w++BPTCoFetdVByfZ8EosokKm64Xjer8hzEaUiliKd2nJdZQe8MzJhigOGJCYhGWi6fcFI/1MfSqvlnkjDCPExKtAy8rc+aLb5DHnMlu1NgitigBoQCB6/LGnu4yamO4PRUyvq8vD/9Y4IIaa16MqpVyRWwA8QMHP+B5VX42flHDL5c8Lfd6DroUypW9LKcAS3lRgdaHNeYj7DnRT4deClG9e4INQprHxtSuT957D3BzpfP9U4B4mpi7S8R+j772KizlTBYy7hZ2YCJ/A== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(23010399003)(82310400026)(36860700016)(7416014)(376014)(1800799024)(3023799007)(10067099003)(56012099006)(11063799006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: EG8peYeysYAlV3xomhuYDBg8TtUJzuAEwOxuiIV6Jq6A4jTaYFI9Legb8APTGzDfqJLvmhzkoA4XKqgH583IooXrITY4MVa5ok2BlaV2HlgkpH9FQWE4wLRVNn9WOjU1efwpV5bDl5DG+v7ruiVpPx4G1dU1kmbCp7wzYUl2wgHOfkDjAyzWmaZoqw+rfp3skHztuU8XdfWZ9gseW6X4E5erL+tsPxIdBeumhoQsicKShgJmSFFTdg3nKh/oIM781mJRdbKOCs5jgWRZX/0dAFIREPUF66lukfYFOAOri3sfUMhOB2wCcuDHRr4ppGcEOgHmjxavVY6lv2VK1S0XJGqiXIYeIsY3G4QcWqQHyF2oMb7yr2rhjARPmy/WKfEF/n3R7GcbkgbUwNjk9DAPSBiI0WKxobcZnXVuMPBU4RIwavEQDTDp9HZpUCa2/YeQ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:09:58.8102 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5cc349d-cbd0-4b5b-36be-08dee6ddee15 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF0000000A.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS2PR12MB9797 Content-Type: text/plain; charset="utf-8" SETAASA-based devices cannot always be identified by PID or DCR; the standard I3C id_table matching may not be applicable. Allow such devices to match through Device Tree or ACPI. Reviewed-by: Frank Li Signed-off-by: Akhil R --- drivers/i3c/master.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 7b2f819bf443..43bf530bc661 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -345,15 +346,32 @@ static int i3c_device_match(struct device *dev, const= struct device_driver *drv) { struct i3c_device *i3cdev; const struct i3c_driver *i3cdrv; + u8 static_addr_method =3D 0; =20 if (dev->type !=3D &i3c_device_type) return 0; =20 i3cdev =3D dev_to_i3cdev(dev); i3cdrv =3D drv_to_i3cdrv(drv); - if (i3c_device_match_id(i3cdev, i3cdrv->id_table)) + + if (i3cdev->desc && i3cdev->desc->boardinfo) + static_addr_method =3D i3cdev->desc->boardinfo->static_addr_method; + + /* + * SETAASA-based devices need not always have a matching ID since + * it is not mandatory for such devices to implement deviceinfo + * CCC commands. Allow them to register through DT or ACPI. + */ + if (i3cdrv->id_table && i3c_device_match_id(i3cdev, i3cdrv->id_table)) return 1; =20 + if (static_addr_method & I3C_ADDR_METHOD_SETAASA) { + if (of_driver_match_device(dev, drv)) + return 1; + if (acpi_driver_match_device(dev, drv)) + return 1; + } + return 0; } =20 --=20 2.43.0 From nobody Sat Jul 25 01:35:28 2026 Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011021.outbound.protection.outlook.com [40.107.208.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 852F53264C8; Tue, 21 Jul 2026 04:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.208.21 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607016; cv=fail; b=ENjvR9/2SizTNb7wyR/zQXPZplxiisceNjjL2noSeV5I619Cj4z0qUHyn+YXcnA+bPIyj+rCkgkmk6Sccypt3U5idAyDebAGU5VAqwfNcz80X5wdsS0CA2jMV8DB1gCdPRZc2y6O84Oox3hXstU41GmgOTHWurQBt18/ZQ0YyOE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607016; c=relaxed/simple; bh=cnBxZfKlFcPWDDScr3bRU6n4zC7SxOLBJhii9RPj3Vk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=s8MJCWtVtlVelLjhhmbWGnkzzhs0q14raK24c6Ci7qkt+9bSHLklDl0h9g4TKIgjS9H8OP/dSSATyGRsbL+qquvwTMqRhcfg5wlSAep90ffZUBwKx9AW/ZW+oRErcwG4iA0Cm9shv8fzf2/VTC7M+kjIp1ih6Q0WsWpEBRc9MAc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=KJgufUkR; arc=fail smtp.client-ip=40.107.208.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="KJgufUkR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rJ3So4n+DpXhBm+P5ambA9ZZToMe6/x+uL/ZA2zkzll+buGfKbVWbTlGgTOHWiRfx/mPL4PbXKKfB5Ku2OCHdr9H9w4HhT5Ll1ELGlPWIqsVkEBs5lNVPEzqORprYfpPkySJ9YXYBF6Vwhww73NCvhhGZp8gOwmSoqdfD3hXvZWpuPTqQIX7MR5IPhZtEBosiU9xE9mT0HuOytZ4Bfdb6ExMr4ODKRoy59OaRBC5u7caWxs7UAjsCvcvCT/sADHyzgLy+yeMkmKaYnugZ6rMaLRViKcoUOIzdWu4a/EF+iRGnGRi0zPLqu9oTKxkqM5kAKDwtDiv4EA+J4xql5Prmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=unGLf+Uxex8MrwG2kOJpiBdUwqjgd3Iqf3Br6rTj0JI=; b=vwFnJ/G0pAV0yHYz1w2j8hlOkmkZubw9x6oN6gfeM6aBacRemz2PMdm2RhxsArCxDwE1jLMv2k8YUKQ66o9vYG6EEUbZMKYouyc8z5GWcqIC9fnOvP6FeFzRQWf9H74D+vLOVeNImfEPvyuallt6LuDTTsq06/UdUfxcTlZoLQWjAJrNzYSpiUMRUzTq4bBM22Dlx/wCzaDHCH7s/nnLp007O4wVoPTx7She1ROVHfw6z78F4MQSPJBx58CXrxrWnPCmpNJD70HrRJmMawrHdFGADRVVNbRHN4Qzdl6pgM+0BhHTMra2jNf3hLRBs8sy0aRFOs+tQjNcxZPbH6k98w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=unGLf+Uxex8MrwG2kOJpiBdUwqjgd3Iqf3Br6rTj0JI=; b=KJgufUkRmOrGoilcEDkELcT1VBmgUVPaHmSMPDilYyQEJqDopOHesdyeaY+o8bLA4wlGKDb8/NiEcI/UcvyMD8e5Pu4Lp9Ohtb+7rfOLiZB+KDLDEcm/zJMYCq/XMQ8z+UrU5XOQJT+/AHC+iuqsyiFp/nuQH8/BvigYpftxKRSWPOj2VK3oQLp+8W8XQ/zpTE/svafBILFFssmzSptnt0m/y2rpab/sVLK02nvd9oxF5OL2Eco2I4nRArJSXIWUSGSeDHbZaIEQNCdk0ih6v1NFVJpW8YiWSmlieG3cVKmi3N+N57ZMX3SLfox23SmkRueH+bj8d9kz/izUwDyhrw== Received: from MN2PR08CA0008.namprd08.prod.outlook.com (2603:10b6:208:239::13) by PH7PR12MB6882.namprd12.prod.outlook.com (2603:10b6:510:1b8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Tue, 21 Jul 2026 04:10:04 +0000 Received: from BL02EPF0001A107.namprd05.prod.outlook.com (2603:10b6:208:239:cafe::1f) by MN2PR08CA0008.outlook.office365.com (2603:10b6:208:239::13) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.223.16 via Frontend Transport; Tue, 21 Jul 2026 04:10:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF0001A107.mail.protection.outlook.com (10.167.241.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:10:03 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:09:50 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:09:49 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:09:45 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 07/12] i3c: dw-i3c-master: Add SETAASA as supported CCC Date: Tue, 21 Jul 2026 04:07:55 +0000 Message-ID: <20260721040805.1696503-8-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A107:EE_|PH7PR12MB6882:EE_ X-MS-Office365-Filtering-Correlation-Id: ab9c6609-372a-47d2-2ee2-08dee6ddf10e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|23010399003|7416014|376014|82310400026|1800799024|56012099006|11063799006|10067099003|22082099003|18002099003|3023799007; X-Microsoft-Antispam-Message-Info: Xi1WjEM+G3zdYnVDyvpfV5glWfQDjvgtwd3MhWCS1PKg5zF8/nxjrMuyCPGLerWdCK68xRa+R25yCYQgtmcLN1moi79dFYt0vziQJPSbQ5+FhR5SIgV60kRdX8FT3eFzChvq0TzpDk5ik/GMVUz37p7itIuxmEz7gUGvFRyL77x0Xq7u+DZqp65nteCXUwa2nd78eGzSaTGcoRuQY6VkbLHWU/6oHUdEZGRm6QFaboCzm4DiP0jvheVsuLl4IVb+TX9mTYdc5AkXlUXb2IpXqtGDyys14ImLmRZH6KqDEUyGoufjYayay+mTJd8Ke1L/V2lrEGyoTSOK/O0DAJfKYxjEpi/8USPjhV8G4kOBXX0mdDv8H20mg8PPhDUGRWTMSrdRCGzXOORyDFxcsuq4/eYt2i3pt8xsE1fTlUX+WasorCl96aUUzQiecXh2Tg/TFl07wrXN+TMRhoP6aYOcQgjZAndMwXZLPvKDV/vcFrsvgAONvAvgk0Zejcp6Z9Qe/luxZnrODvoZDYtEF0jvD9syUT+wHeoqsTCBXzF+0rP5R9gYJYA/RuJXvbYBU6HbSD/Sk0BACi+2GEQ5kqyN4K3TqiBfDzmhXo5JKOqKKVeurZ5pa3AJCGKL5zYGx54Sm/ZpTgPGlFDZTaaizqnpLaPDoWGqiQausuJjL4CxsxMvdQmAnttZuIWC3CntSwMIbHLD5hDoZjNDPQvlaX5cBA== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(36860700016)(23010399003)(7416014)(376014)(82310400026)(1800799024)(56012099006)(11063799006)(10067099003)(22082099003)(18002099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: T78rbpwLC9OMj4LM3lD5e4Q9s/Z8QHE8hchFkL+lgwIvzur3UlwOrKaOTCr3KlezY3gvoOuZIzmmukPqoCozhJxOUiQQch4yYiPAoVbYwBWNb20jzU64W2qy3F8yfNwAwwMHBMJpIlohBqhAYh3U8tj58XwyZLRjjVZEbjS5H0vW7UYWqr6eBjlga6cOBlN0Li+SrjiqPd3+/U2vQ6JeQ1wcnwpyjXW9ri7N6qKkXciH8Fj9xpYY+nVErhgAScFwILgTN6z32gZzXJ+sMg4PAlzHCjIbuBeHGaep+8uDiOOgoYP82YpK/NqHcpu7xgmyw78iGUPKS6qGpv4xCZ6AB7HWsrXJ6wMRU+Ng3ON8dbVyGKfiyHkm1s1b5Alg7esdq5uZVrohKN/E5TeYENf3JyqTvfFpuuCO3ytAyCO1jUtvZr6h5+WMD4WEI4XICnMp X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:10:03.7774 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab9c6609-372a-47d2-2ee2-08dee6ddf10e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A107.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6882 Content-Type: text/plain; charset="utf-8" Add SETAASA and SETHID to the supported list of CCC commands for DesignWare I3C host controller. SETAASA is a broadcast command that assigns predefined static addresses to all I3C devices on the bus. SETHID is to stop HID bit flipping by the SPD Hub to which the SPD devices are connected. It is a prerequisite command to be sent before SETAASA as recommended by JESD300-5 and JESD403 sideband bus specifications. Reviewed-by: Frank Li Signed-off-by: Akhil R --- drivers/i3c/master/dw-i3c-master.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c= -master.c index 2f8c0c4683e0..29030fd9594a 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -309,6 +309,8 @@ static bool dw_i3c_master_supports_ccc_cmd(struct i3c_m= aster_controller *m, case I3C_CCC_GETSTATUS: case I3C_CCC_GETMXDS: case I3C_CCC_GETHDRCAP: + case I3C_CCC_SETAASA: + case I3C_CCC_VENDOR(0, true): /* SETHID */ return true; default: return false; --=20 2.43.0 From nobody Sat Jul 25 01:35:28 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012062.outbound.protection.outlook.com [52.101.43.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6191B382F1C; Tue, 21 Jul 2026 04:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607024; cv=fail; b=RBFNpyxcteouteQz1KoUvgCMpRvybB7JU4fX+dOOhTRff6vUShOLJdV4lsy9W5NOuq/pNjKzoJTKPDPTevmD0FmJY6XVcQa9mr5Bj57wkENHRS5Tgy3CPNLtNn7Eoaxt9IE+1QkqYqrFVuYISbuSeIflqLt1bQ6zrGOAloJhRio= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607024; c=relaxed/simple; bh=wlF8AkqTq4PWSFfpbhtMsB+YvHGVONpFJg+YZe643UM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ohauCogPtrtAqcCDWyH/KExYepkCesBzJl6S5M3y0e+5x1Ft3CdNZ0XeHr6CWmP6Eb227JxQo4evGOYVXAYsXCBODRyfxDYyKszAjeUpGDFUutOMNJEpejfu5Au2B1ub1EVZFYGDCCjCW7w5SlWc1jsQvFEjOxrcFS71C8e6ILo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=dVGxnie7; arc=fail smtp.client-ip=52.101.43.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="dVGxnie7" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VQIJaVFdE+Fq2Tj3fWWJRugfJOGQw3cUGCcm8t7Oeoy7xiNJE6uShZwPvlRVdJAoNCLol/EsQIEiUWSzzHD8uwLv9wyl2GVMij558TFY5mx5JFISWO3ItkYUL4gfWXR3hX47mRa6BG4sqGj5TLPFPogB3wjJAN4p+HYAGqCoD03q0+dJlOmX6UonFU0t04qNKY2tqN3bUfHhaa+qJbZ/iI7JpXiu2cMGs55b1brnYHu1AJOUCL64V6d0nlAFFUP2gyOhmOmyPFuAo4/tSS3qiLaoqL0tjb8KPCDKNaAcnnCNASqQEL2fDvb7kaMEzfqDTCm46F8s9ty16IW0IfYLhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m8gJs5Sgug3HHxAuVqwc8d8hvADhSGUOv/tXNoHT8jY=; b=N+tfNU6A8zvAG2ynw60p2cFmnnsNlwlQtSIQFr2/4fWuZEQlmQkQwUGdmSXrJ1LoCu5yWkMLgQxWvOtYJZYo8TtzyStdOPsX4Ey0+qIiDGk/bKYjVYRykxqddoKZWjD28QMTYWpN+EcRUzL+6QcvozHGgjKEBmd9LOg7NqwvkinXquS7Wynqgve40Kp7S60r+l4Vx2UBRr+7G8gL+FiBU3Geez0nvv31oSkzo577bKQWL8VfGBxa0nwQ9ee0XrvKHP6TJ/KEoU70D0vyOD/VSlagWDGzycTTtGi05ppqTXYTcUjszxo/CGh32RdtHP7C54onqYiOpocF83frk/DysQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m8gJs5Sgug3HHxAuVqwc8d8hvADhSGUOv/tXNoHT8jY=; b=dVGxnie7vbjAglloG8ngd/H5EFvOfG87w963QummsaHRuJO27ob9FhWhzOl5zRZUVV/6MTPamD6B8GjVVfA7n4ENLIhl1Z4IrvZ46UK5W4j+T4tnZ0qszFZLUnSQhRuc4f6mTJWrTu4gjL/3FCxmCy6pj47VAH2YAZtQgZxM0D81S6tJc1FyEwRDS2mLtny+ADWUzso5z5wLxMneP7F5LAVoWoOrRnSuwSmeSBRN9CpLn/MBdLbygbK56JPg/L6Jsi1W0XKSmxkrqqyGTlSZhvb8ugHAX5XuttCItwpuXEgP3ER+4lloDcfHg8A8DTyKsLaamxdA7eF4cz2dSE5Y1g== Received: from MN2PR01CA0042.prod.exchangelabs.com (2603:10b6:208:23f::11) by PH7PR12MB7378.namprd12.prod.outlook.com (2603:10b6:510:20d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Tue, 21 Jul 2026 04:10:13 +0000 Received: from BL02EPF0001A102.namprd05.prod.outlook.com (2603:10b6:208:23f:cafe::6b) by MN2PR01CA0042.outlook.office365.com (2603:10b6:208:23f::11) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.223.16 via Frontend Transport; Tue, 21 Jul 2026 04:10:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF0001A102.mail.protection.outlook.com (10.167.241.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:10:12 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:10:00 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:10:00 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:09:55 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 08/12] i3c: dw-i3c-master: Add ACPI core clock frequency quirk Date: Tue, 21 Jul 2026 04:07:56 +0000 Message-ID: <20260721040805.1696503-9-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A102:EE_|PH7PR12MB7378:EE_ X-MS-Office365-Filtering-Correlation-Id: 5078e592-2081-439e-95cf-08dee6ddf64c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|1800799024|36860700016|376014|7416014|10067099003|3023799007|11063799006|56012099006|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: 2GMvhaSPuOzwlw/U7nBp7RzyZQzvVM5G5KcyG4/O6G6Yp94QdMMVXoVlx0n8E4e/3Og2sNoXzBH14cfPDfQ7q4ojIbyse6+ZI8T28RcBB8JtWcrhYfdNyKeHHPyV3T9meJ0BgBD7rOdHN7ShqgSez/p59KnE3vijmOFEXOGtIMglZU452WiZtJal2t/7SLqPTLjGSlEY/3E9ugTLPf5/gUVTuDDuNGZ2rYYpu3jbcWfHgpoMdLs5x8cL5+qZT/dwcdxOhnP17v7V+HE8XmqRH5yI/2Rt50nRuEGKdtkBFn9PG5k7ZL8IQGNkKnb0nILvcwvduExQXg+g/vUYV73aSWI7dB4un0T074U0sciVgrqqwuJMzJ7epK4CRhki+nuZh5heTdJXf9gsA2xQ+m0RPa1Hq5XetS3jyVs5SvYuXRRofYbQIz6XIEwui7y7V0/zbftnpau6cAoWg+O+K12Mptx7zOI7Qf/TyPuPBldT36gYBkMd1rWjOyOOYg9bHb/OAD9k5GnaorgjkmDt4vzxE1RYUfmIZTdhbXO+fcf4N07Fo4dpM952tPaBDxx/zbDGMdFZG2OUzrMovmcKBHIA4qvpfdq8RXiZWp2x5NmZaoHSVsOWnv/qD/jOpZdpXHV5kJyIhLYKGGaHZ7NQWSBEw06D5rBX+tiJlNt6cwWC2W4RSG48Ei/rLulTzg+4/dR4a1tLFDkLPvRMqMamyUGE6g== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(1800799024)(36860700016)(376014)(7416014)(10067099003)(3023799007)(11063799006)(56012099006)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: t5fVN7EXt92hd85VYn/8iTCaY8QqaxR1y6WV1Jy4kogKBJllJM23S8EJxdZNFUSW47EDmv6iNaVOpGRGrvgYiY+n/HNRrr2AxGG/NsZTjCwzifud3P8oNhdwaYReUBLznc5cvJAtlpkLu2Nj0WmwH1HW1idGv6NLOUvALD//SElEuIwKNuLBFwnjIU4JYHbMSyUAqX6fZNH97SVvaZWgIGG1edUoffULgMbpw1HzKFQ/0vMZcX3ozAZN08YRXA5hK5yzD4yTemlfcbEPXIAF/zdrFfYCi3N7+MPc13xVC6SG1e/4msmBjEoGRqhdY8eMhmiphjHZSPRzwkzar+gBhkg0nb17fON0lJ83FnOYpNyovPwuTG+hzYnpyY2TnMnkUZNMC9eJeR85rLwca971H+mOIYgmQ8W1afOqDJ0adPq8CrqZxAoYddha9X/WskPZ X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:10:12.5649 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5078e592-2081-439e-95cf-08dee6ddf64c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A102.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7378 Content-Type: text/plain; charset="utf-8" Some ACPI-enumerated devices like Tegra410 do not expose the controller core clock through the clk framework. Unlike device tree, ACPI on Arm does not model clock providers. The hardware is expected to have its clocks enabled by firmware before the OS takes over. Make the core clock optional and allow selected ACPI devices to provide the core clock rate through the "clock-frequency" _DSD property when the core clock is absent. Resolve device quirks before acquiring the core clock so platforms without the ACPI skip-clock quirk still fail probe immediately when the clock is missing, before any MMIO access. Signed-off-by: Akhil R --- drivers/i3c/master/dw-i3c-master.c | 50 +++++++++++++++++++++++------- 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c= -master.c index 29030fd9594a..3ec3ab1c13b4 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -242,6 +242,7 @@ /* List of quirks */ #define AMD_I3C_OD_PP_TIMING BIT(1) #define DW_I3C_DISABLE_RUNTIME_PM_QUIRK BIT(2) +#define DW_I3C_ACPI_SKIP_CLK_RST BIT(3) =20 struct dw_i3c_cmd { u32 cmd_lo; @@ -556,13 +557,33 @@ static void dw_i3c_master_set_intr_regs(struct dw_i3c= _master *master) writel(IBI_REQ_REJECT_ALL, master->regs + IBI_MR_REQ_REJECT); } =20 +static unsigned long dw_i3c_master_get_core_rate(struct dw_i3c_master *mas= ter) +{ + unsigned int core_rate_prop; + + if (master->core_clk) + return clk_get_rate(master->core_clk); + + if (!(master->quirks & DW_I3C_ACPI_SKIP_CLK_RST)) { + dev_err(master->dev, "missing core clock\n"); + return 0; + } + + if (device_property_read_u32(master->dev, "clock-frequency", &core_rate_p= rop)) { + dev_err(master->dev, "missing clock-frequency property\n"); + return 0; + } + + return core_rate_prop; +} + static int dw_i3c_clk_cfg(struct dw_i3c_master *master) { unsigned long core_rate, core_period; u32 scl_timing; u8 hcnt, lcnt; =20 - core_rate =3D clk_get_rate(master->core_clk); + core_rate =3D dw_i3c_master_get_core_rate(master); if (!core_rate) return -EINVAL; =20 @@ -615,7 +636,7 @@ static int dw_i2c_clk_cfg(struct dw_i3c_master *master) u16 hcnt, lcnt; u32 scl_timing; =20 - core_rate =3D clk_get_rate(master->core_clk); + core_rate =3D dw_i3c_master_get_core_rate(master); if (!core_rate) return -EINVAL; =20 @@ -1573,14 +1594,28 @@ int dw_i3c_common_probe(struct dw_i3c_master *maste= r, =20 master->dev =3D &pdev->dev; =20 + if (has_acpi_companion(&pdev->dev)) { + quirks =3D (unsigned long)device_get_match_data(&pdev->dev); + } else if (pdev->dev.of_node) { + drvdata =3D device_get_match_data(&pdev->dev); + if (drvdata) + quirks =3D drvdata->flags; + } + master->quirks =3D quirks; + master->regs =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(master->regs)) return PTR_ERR(master->regs); =20 - master->core_clk =3D devm_clk_get_enabled(&pdev->dev, NULL); + master->core_clk =3D devm_clk_get_optional_enabled(&pdev->dev, NULL); if (IS_ERR(master->core_clk)) return PTR_ERR(master->core_clk); =20 + if (!master->core_clk && !(master->quirks & DW_I3C_ACPI_SKIP_CLK_RST)) { + dev_err(&pdev->dev, "missing core clock\n"); + return -EINVAL; + } + master->pclk =3D devm_clk_get_optional_enabled(&pdev->dev, "pclk"); if (IS_ERR(master->pclk)) return PTR_ERR(master->pclk); @@ -1636,15 +1671,6 @@ int dw_i3c_common_probe(struct dw_i3c_master *master, master->has_ibi_data =3D true; writel(thld_ctrl, master->regs + QUEUE_THLD_CTRL); =20 - if (has_acpi_companion(&pdev->dev)) { - quirks =3D (unsigned long)device_get_match_data(&pdev->dev); - } else if (pdev->dev.of_node) { - drvdata =3D device_get_match_data(&pdev->dev); - if (drvdata) - quirks =3D drvdata->flags; - } - master->quirks =3D quirks; - /* Keep controller enabled by preventing runtime suspend */ if (master->quirks & DW_I3C_DISABLE_RUNTIME_PM_QUIRK) pm_runtime_get_noresume(&pdev->dev); --=20 2.43.0 From nobody Sat Jul 25 01:35:28 2026 Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011055.outbound.protection.outlook.com [40.93.194.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DB903264C8; Tue, 21 Jul 2026 04:10:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.194.55 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607037; cv=fail; b=iPdsrPyzwJExTnizkyFLt0gE7k0IoMRYsqBEl7YaDTiU06aRX3InYTQE3Ow9JANDcCxDid4V0c40G+k//ee2lcGZ2T0lHzsOOgSelxvUKb1mO2Q5ZhefEG4IrctNiRkBAEwnd7TY+FJLTyjEDMK8i9RwFuI9p5hpHa1hAQVJoW0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607037; c=relaxed/simple; bh=i+C5zyKRtOYna5YMeTQKPLCshsb4DdWPM8gqIES5b7c=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mtZNG6E8g/6E4Yk/AG271P2Ik263OvAAFftkMBmgWuCMgwPRiIK2nZXbXBQORRc4PtK9apbSCn8biTbD7yA/bbZ+z7IPmvLWfSpB2GgqigqfKTUigfdXHF8bgCqufY6d5HFkJ/6FYRBWKD3jTLHajAFr7YpKBEqno+3981t/ykc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=c60BejqJ; arc=fail smtp.client-ip=40.93.194.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="c60BejqJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vIQV0GvIaSGB5WVFk/HLCpYvdhxfJGIV5WwAj97AENMHWVqnipa+Kr+pLM2v+st0yckBoQ0gkI+j1iQEqOv08MqAheArHgh77+rWW5HLpH/bn10pcdqtG6kp8aORCFnNIaHw606YXesq1vm9OJnEdP7reqWUH1TgNUYVYnuhg+BdhxQwMK96thUL9d+NVtWs0RWUlxeH8YRI4eIsonuBF0RewY7kbCPiBkJchakoyWcDa9JjT+GaOS+ioJaydCB3Dx4gSj+r78b+HvmWu5Cr4LwYShFcERWHgYATVPFLgd1K6R6VFzskGYAsSXrDEkIf6NrGDnJ3YVwCDaX7UyiB7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E90CpKULU66cA34AC6jiI/LuL0mmi448982dtTO6EKY=; b=kXFatHZ0A9mTw7GrXvmL2OzTusnBngq/U8jOVH9UDSxSOeL6/wuXfFxGMFsZU8eFKZjmfWHo26PaN16ZB6HAacI5MZcFXPESBkSOFq15AmljGTK/WSOzfXk0oo8N3MEpA7qbdqeCBONBK7Lsp/rcFRAOKbNXIXszd1D5Soeh63zPjpolnks+aXZO2nHQ7WjytIaNvRIkQJEu3tRI65PK17LvIE8GXtGT3/QhOgBL9ViZJw5odz3Xe5xkSp01QOOqSA1G+UQyqozHDUI8D1M3nWOuRGPL+ZQ5TxrFsb6WpiVElO8+905+hKlUK7ZGxZlQ0teq4BS7IiTenAoV6VIWyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E90CpKULU66cA34AC6jiI/LuL0mmi448982dtTO6EKY=; b=c60BejqJWGQWHGyvtnp+A5YxvgLXdTMpYLgI+Yj7bLzvnGoksFl77m7HPpQEYO87IigGi9oiKUXMYdOa/Nrwd89nV+5CRTTzxqJ1FM706+mxb52z7xrpxJJQChrUs9W6MMLkHaAm7ETueExhqLdrqx0d3U4K92uusCOcl5VBMDfvOIKcHKvDIRnRD7cI7P/BrqXP6yznstWroU7jawYg1fnAJ2h1BCba0jUAf+SqTOYlANoxzZ8eez3wjbd1+0DRJbtwStPDvgPX30aiSjGFE6Kx+MG09I1TXZI5e0QQNdTtMNglt8a4DbHenmYH1oaDyKlWz8GZbx4Q3jYraBlZhw== Received: from MN0PR05CA0006.namprd05.prod.outlook.com (2603:10b6:208:52c::31) by PH7PR12MB7139.namprd12.prod.outlook.com (2603:10b6:510:1ef::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Tue, 21 Jul 2026 04:10:28 +0000 Received: from BL02EPF0001A101.namprd05.prod.outlook.com (2603:10b6:208:52c:cafe::3a) by MN0PR05CA0006.outlook.office365.com (2603:10b6:208:52c::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Tue, 21 Jul 2026 04:10:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF0001A101.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:10:27 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:10:09 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:10:09 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:10:04 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 09/12] i3c: dw-i3c-master: Add ACPI ID for Tegra410 Date: Tue, 21 Jul 2026 04:07:57 +0000 Message-ID: <20260721040805.1696503-10-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A101:EE_|PH7PR12MB7139:EE_ X-MS-Office365-Filtering-Correlation-Id: dc91438f-f67c-448c-175e-08dee6ddff34 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|7416014|376014|1800799024|36860700016|18002099003|22082099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: dI7e5gOD99EGJkuRZQ57Bhx24OEKfoJDcNT4ItR5Hl2wMqc1vxQpVa+nk9Q0VrHQOCMLAAUR01S9jnoxS54qfxC/3kOAY/4qQzfOJMcRWUJGaXppAUBN3oSgBrNryeg3DGlvob/va61VJV0qjaCJRBiNVqm7KCcEeyegISYAQSwAIDpldYUAZddlZ6QfRGQbSbbPKLCf4qw//RWSttWB1HkqMmnmfWKMJJCSJpS3GLMGrgXfVGmRp8G91oiMPcW07q1BNjIhvZ+IYn7Xzo8GgAyfZ2BPGx9Vy+gWbir5eN/zXq24/xi22tXTjGjm6NU4at68vQRms0VXZY75u8JrYobL8djaMNPy2S7vGC4z8U8H0tQZl9GAxuC8AWc5002qBB4/8T/E1yUXY/vMFiEPLOwNXAI85wFtr8MZ0aL5ELKq3dT+DNvGrA8S3GUDIEAXt/CNfnndjhK+BMTolB8ButqOfoD7gMishKSsTnlPhRedfus43HafzI/9HvRDFPJbS21BZLLETRGhrc1jhz55ukZmuoWV17Nmo+EW3Xou8QfpaKgDVUVpmyALKFa5Vi00W8Gqa/+c7Rj7oUyWgzjPH4aWbmfV4wX0MbQmfT9cLnqPEu9kAmWtE1ih2dfakXopxUA1sxiAyUohmJmE2Czkgl3QYPvqC/jrom0jKKOxl5Z251uEMuJsJiUAxbSkhxjIqKkCzmVXWmBtkxJYYA+ltQ== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(7416014)(376014)(1800799024)(36860700016)(18002099003)(22082099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 546CUBImCkkbAWtxvH+w1Xkb1twlaDQnh+ZkY8kBhNlAc5N5GCAbNz0jkEJOLGmbSyCSCSXEcCowMEeaaKtdb9d+o9bYi8Sw3p+RpFM5VYMMovxfe0kzXRW6bNtuyUznIeZAgrZdY1xeb2TR/x13V78GF8YW+Orjh3xkTh0ROmqggIMbuHtNnK0WeNWkcrKdvbdftJ0vLyoMBNjgdcNqou2kENufEWeK6Ene5wMoGokAZJl+O2c9ZKA4SA1ew5oBun847ZLq+BGdx9TqYQ05a9DabK5vy6MX9lzlcV2fLPD4la5NOdoTUTqY/4Lp4hLI6x17paKe09l9EtEX0WIRV0UEEhFGKL/NNPOieNpVS3ySHh00xM4sk47zT9IqsfO+JZCuJV6LAc6roOm1Fcmkm7ad7INdXyj5GBhObp8sooFsqBz+QaLEJksQLeDm8xZe X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:10:27.5131 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dc91438f-f67c-448c-175e-08dee6ddff34 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A101.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7139 Content-Type: text/plain; charset="utf-8" Update variable names to generic names and add Tegra410 ACPI ID to support the I3C controller in Tegra410, which is a DesignWare I3C host controller. Reviewed-by: Frank Li Signed-off-by: Akhil R --- drivers/i3c/master/dw-i3c-master.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c= -master.c index 3ec3ab1c13b4..efe37f5224c7 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1860,11 +1860,12 @@ static const struct of_device_id dw_i3c_master_of_m= atch[] =3D { }; MODULE_DEVICE_TABLE(of, dw_i3c_master_of_match); =20 -static const struct acpi_device_id amd_i3c_device_match[] =3D { +static const struct acpi_device_id dw_i3c_master_acpi_match[] =3D { { "AMDI0015", AMD_I3C_OD_PP_TIMING }, + { "NVDA2018", DW_I3C_ACPI_SKIP_CLK_RST }, { } }; -MODULE_DEVICE_TABLE(acpi, amd_i3c_device_match); +MODULE_DEVICE_TABLE(acpi, dw_i3c_master_acpi_match); =20 static struct platform_driver dw_i3c_driver =3D { .probe =3D dw_i3c_probe, @@ -1873,7 +1874,7 @@ static struct platform_driver dw_i3c_driver =3D { .driver =3D { .name =3D "dw-i3c-master", .of_match_table =3D dw_i3c_master_of_match, - .acpi_match_table =3D amd_i3c_device_match, + .acpi_match_table =3D dw_i3c_master_acpi_match, .pm =3D &dw_i3c_pm_ops, }, }; --=20 2.43.0 From nobody Sat Jul 25 01:35:28 2026 Received: from BN8PR05CU002.outbound.protection.outlook.com (mail-eastus2azon11011011.outbound.protection.outlook.com [52.101.57.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A13EE302163; Tue, 21 Jul 2026 04:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.57.11 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607052; cv=fail; b=I+pEFcPMnZgNQc7tyftFMpRQOblsMStyUwG95ksG8ZFlEimMkbNqmHfVMVHEhf9q6agtU0mu2bK6U+2eNxwrFW2KSxqP5QQjcbIgw+VJkPBTAox7/+p4XBF8D4PKqvAfzrHA4sh2x4fHkruqP2xUjhA+i4rRnbciwBPPDSqynx0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607052; c=relaxed/simple; bh=cD9GtWbmyjTAeDl0835o/YmYxeOO3qdn37NBB3MlNp4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EZz+FHtJUVcsShl/dmKRfiTGuaoEz9LhvGfFMN6EDfU9pkiujvuZoEFuSkVm2nLSlgxAP/qzD5hrNQtNwt9cTiAmbnlW77TQF9Getwdk6D56oyfgaVvXa8UKBPUYcnO0dhBmQU6466MkedyFx2WhHnf4HitIbya0DW7Hu4PKt8Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=dSOUhbGm; arc=fail smtp.client-ip=52.101.57.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="dSOUhbGm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IUMOqnXDOlPYTactxN5S01b2CKxL0JcWpz4yd4KrRyTPUcha+nyNNCyDsjU2HycnFbXf4u0RHx0nf6gELW6D2HphpykaFrtSx/nxdQ2ex0/ORfqW8oc6y2toZO0g+ske55BfHaO9Dakcyqdnc7WxNr/ZqSnmL4jILGTlTsrq/OQVcwvZbn5GWOfxRsHVSjDiU1R1L+NPQkUUJtZkLUFZW1hg910dZTZdTwyP2TtcQHNsHe4vJKkKTMO6228FwT3GYmw8O2QbE53ZLlGgpCTW5zgryMIt5LyZpwPIoalr/iFeTEAA08G9taDYHRWF3eePScdD8cFVDhYB0ew297hUCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uiQz1AwaYoTlL/V3YQ5qUQZDkSt/CeAD3nwFcrAf5Yg=; b=xLQldvlSb1GfMb9XQ/vWxXugCe8IVh+P8FiFQIYi4akZBSD4hMXYP3HKSmaIaQBHApEalQXV8+pGnW7FcG3G4qYDgVAB+HsVx9GySNpNdZcf/vbRBF20LmGR8KJID0/pHwWJHN3rOFyC4RIUMfyklxA1WpT7r4MxLSuEXutptaYe3tFmEA8JMf53Uk0200nA7GcDfp3Xz77ISEwFz7Vh5tkYPxV1AXz6B+OyLiXz9ZGXg+w53WiqphDkaodVBysk01mbYA91JF9cpJ6GzaGutLGYMoLZaaBdn19Egla6r5LNh7r9Q2BRbJvOzqdi5Sfu+Z0nWPo6/MLyl/7EqNtrsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uiQz1AwaYoTlL/V3YQ5qUQZDkSt/CeAD3nwFcrAf5Yg=; b=dSOUhbGmUkf/Jk3Fw8JgZ4rJWDE8dlm3+CbrRy3ce61Y2TqtyCL0Zyir8PQtDBKuKwydLCoAApYEgQpMA+VFzBp/c99A1n0MJUeHV0IHe6H+5JyBJrskiloqrS1zqPlBRONa8w9cvw279zOmmAVuukCaRMgXqrUtnI7d/+QiPlw8pVcl3jzqZ/RhDNFDSI0fjepkno35VBA82Q8lZ/ffwAId0cOJjXb+A7CzImMFEZC/G/K1ROiGyw+wdwnEuA5P43MfqVfu/5dDeiM56wZEQS2+u4b3ZFVf0x2HreSHUlm9g1cWasIuQVmZMNGckdi+qZaMkC5ZsXSdl10nGf503g== Received: from BL1PR13CA0061.namprd13.prod.outlook.com (2603:10b6:208:2b8::6) by LV8PR12MB9358.namprd12.prod.outlook.com (2603:10b6:408:201::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Tue, 21 Jul 2026 04:10:37 +0000 Received: from BL02EPF0001A104.namprd05.prod.outlook.com (2603:10b6:208:2b8:cafe::46) by BL1PR13CA0061.outlook.office365.com (2603:10b6:208:2b8::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Tue, 21 Jul 2026 04:10:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF0001A104.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:10:37 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:10:17 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:10:17 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:10:12 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 10/12] hwmon: spd5118: Remove 16-bit addressing Date: Tue, 21 Jul 2026 04:07:58 +0000 Message-ID: <20260721040805.1696503-11-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A104:EE_|LV8PR12MB9358:EE_ X-MS-Office365-Filtering-Correlation-Id: 102b5b22-1446-4dd1-e3e8-08dee6de04de X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|23010399003|36860700016|82310400026|7416014|376014|1800799024|56012099006|11063799006|10067099003|6133799003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: skuFhQ92e9xdyZucRy3vdp6t6VjobKqXiQEEBUHU5w3AsATtylBL+O8+iAOSbsnCpciokMoFrl0nCOFgHaf6c8iZ57vqJTdQyCqnDHizVZmQ4s/5Ikkoa72KDHfSVPEj/eCFHNupBUWJ3E0ZM9OIbBi6GSiB763q639ZFu7clWQp5NxrLGRF+kgqYUzLbyktuftt4jr5uoNH2laFQnWGyQf3aEpVJoDIfrpXewC2W7jZdBsjQVrAYuRKRBlqLjKBMc3Ds0hXe8cHvK/0O6yjuCQmTt4CwN7Rfqd6re7V8ompZ/NTMDooiscgS7HDdmnY7JAdIgx4xUc0lXPbmuou8XiWjZlOQKBEvxvFdODNJ8opLkJtDVr409r85RMR7mloOQWAK0yM833zeKep/fdrNXKth/3e32Ue4cqm6EvMFAT7fUoQlhr2Hs23ryO3PLivR7bAWO2gFdI3HiA+P1QKt6MzjNqNrsp2TzalvFKD3XSSvUPkCxw4OKiIlGQL0O/n6gMpM4EcNUpB74kSzRkbSU2KLcRbr2+rWy4QpgJgQJtgzgVE5FatFBVD9KKMPFYNcPTQZsMRQyrjJMNNo+7AuNQLbZ+K0b+0RIFZRQ0W2xnDNEIhKvcaW1GzwI3tGLMSZJd+kXu2exelRlqWxkuu04ScI+VQFhvfSysPuCCBL8+Htusdnik06t+BcBRPqIeaY4mLK65ylFK951dVZ9Wz3g== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(23010399003)(36860700016)(82310400026)(7416014)(376014)(1800799024)(56012099006)(11063799006)(10067099003)(6133799003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oHYIIB/QoxW1iPgyX+KqvKQgCzaNPzLwfxFHsgyc2JVD/Puc9VjhOb4eob6sN4ZDqNSftirmf/GdheStmRrc3cHXm/Fv+eRF/iuI6CAoz949qGiUiZ9vI/f8Ovr3KGgV9MdHQ7oTa7m4IGRZNEffXCY7Ebpmd11j5PczTOG6B4lNvJ3K+fOu8n3jUqbu2RhqucukCChC03BehcDEJpoBFnTzNuIK3J7CPBjA4XNc9soXiTa1alwfCmubyTvMFdCAj0tmG7wEhMKmODtF81iqG0Rz/odbOV+HZFbf99KRXBIqKmOSAh4ZCgR5FlIOzYCTRSNKuIMNasAdFTHs1cyOQfOHNe/SVwIfAsnhGeMdnoqbTgT60Bg+UWKUv+tnN5Kc2hP1Y4wgZrqj/LtBf04WkW61g3kAZ9q7k/31z8M2v030OPvLzsr+wy5tVjO8e6o7 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:10:37.0252 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 102b5b22-1446-4dd1-e3e8-08dee6de04de X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A104.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9358 Content-Type: text/plain; charset="utf-8" The intent of introducing 16-bit addressing was to support I3C, but it turns out that I3C does not require reading the Legacy Mode register, nor any specific encoding for page translation. The testing of 16-bit code was limited and there are no known users for this feature. Remove the sections that support 16-bit addressing and prepare the driver to support I3C appropriately. Suggested-by: Guenter Roeck Acked-by: Guenter Roeck Signed-off-by: Akhil R --- drivers/hwmon/spd5118.c | 79 +++-------------------------------------- 1 file changed, 5 insertions(+), 74 deletions(-) diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c index cc40661cab21..6ba37a719300 100644 --- a/drivers/hwmon/spd5118.c +++ b/drivers/hwmon/spd5118.c @@ -66,9 +66,6 @@ static const unsigned short normal_i2c[] =3D { #define SPD5118_EEPROM_BASE 0x80 #define SPD5118_EEPROM_SIZE (SPD5118_PAGE_SIZE * SPD5118_NUM_PAGES) =20 -#define PAGE_ADDR0(page) (((page) & BIT(0)) << 6) -#define PAGE_ADDR1_4(page) (((page) & GENMASK(4, 1)) >> 1) - /* Temperature unit in millicelsius */ #define SPD5118_TEMP_UNIT (MILLIDEGREE_PER_DEGREE / 4) /* Representable temperature range in millicelsius */ @@ -78,7 +75,6 @@ static const unsigned short normal_i2c[] =3D { struct spd5118_data { struct regmap *regmap; struct mutex nvmem_lock; - bool is_16bit; }; =20 /* hwmon */ @@ -348,12 +344,7 @@ static ssize_t spd5118_nvmem_read_page(struct spd5118_= data *data, char *buf, if (offset + count > SPD5118_PAGE_SIZE) count =3D SPD5118_PAGE_SIZE - offset; =20 - if (data->is_16bit) { - addr =3D SPD5118_EEPROM_BASE | PAGE_ADDR0(page) | - (PAGE_ADDR1_4(page) << 8); - } else { - addr =3D page * 0x100 + SPD5118_EEPROM_BASE; - } + addr =3D page * 0x100 + SPD5118_EEPROM_BASE; err =3D regmap_bulk_read(regmap, addr + offset, buf, count); if (err) return err; @@ -473,15 +464,6 @@ static const struct regmap_config spd5118_regmap8_conf= ig =3D { .num_ranges =3D ARRAY_SIZE(spd5118_i2c_regmap_range_cfg), }; =20 -static const struct regmap_config spd5118_regmap16_config =3D { - .reg_bits =3D 16, - .val_bits =3D 8, - .max_register =3D 0x7ff, - .writeable_reg =3D spd5118_writeable_reg, - .volatile_reg =3D spd5118_volatile_reg, - .cache_type =3D REGCACHE_MAPLE, -}; - static int spd5118_suspend(struct device *dev) { struct spd5118_data *data =3D dev_get_drvdata(dev); @@ -519,8 +501,7 @@ static int spd5118_resume(struct device *dev) =20 static DEFINE_SIMPLE_DEV_PM_OPS(spd5118_pm_ops, spd5118_suspend, spd5118_r= esume); =20 -static int spd5118_common_probe(struct device *dev, struct regmap *regmap, - bool is_16bit) +static int spd5118_common_probe(struct device *dev, struct regmap *regmap) { unsigned int capability, revision, vendor, bank; struct spd5118_data *data; @@ -537,8 +518,6 @@ static int spd5118_common_probe(struct device *dev, str= uct regmap *regmap, if (!(capability & SPD5118_CAP_TS_SUPPORT)) return -ENODEV; =20 - data->is_16bit =3D is_16bit; - err =3D regmap_read(regmap, SPD5118_REG_REVISION, &revision); if (err) return err; @@ -680,69 +659,21 @@ static int spd5118_i2c_init(struct i2c_client *client) return 0; } =20 -/* - * 16-bit addressing note: - * - * If I2C_FUNC_I2C is not supported by an I2C adapter driver, regmap uses - * SMBus operations as alternative. To simulate a read operation with a 16= -bit - * address, it writes the address using i2c_smbus_write_byte_data(), follo= wed - * by one or more calls to i2c_smbus_read_byte() to read the data. - * Per spd5118 standard, a read operation after writing the address must s= tart - * with (Repeat Start). However, a SMBus read byte operation starts w= ith - * (Start). This resets the register address in the spd5118 chip. As r= esult, - * i2c_smbus_read_byte() always returns data from register address 0x00. - * - * A working alternative to access chips with 16-bit register addresses in= the - * absence of I2C_FUNC_I2C support is not known. - * - * For this reason, 16-bit addressing can only be supported with I2C if the - * adapter supports I2C_FUNC_I2C. - * - * For I2C, the addressing mode selected by the BIOS must not be changed. - * Experiments show that at least some PC BIOS versions will not change the - * addressing mode on a soft reboot and end up in setup, claiming that some - * configuration change happened. This will happen again after a power cyc= le, - * which does reset the addressing mode. To prevent this from happening, - * detect if 16-bit addressing is enabled and always use the currently - * configured addressing mode. - */ - static int spd5118_i2c_probe(struct i2c_client *client) { - const struct regmap_config *config; struct device *dev =3D &client->dev; struct regmap *regmap; - int err, mode; - bool is_16bit; + int err; =20 err =3D spd5118_i2c_init(client); if (err) return err; =20 - mode =3D i2c_smbus_read_byte_data(client, SPD5118_REG_I2C_LEGACY_MODE); - if (mode < 0) - return mode; - - is_16bit =3D mode & SPD5118_LEGACY_MODE_ADDR; - if (is_16bit) { - /* - * See 16-bit addressing note above explaining why it is - * necessary to check for I2C_FUNC_I2C support here. - */ - if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { - dev_err(dev, "Adapter does not support 16-bit register addresses\n"); - return -ENODEV; - } - config =3D &spd5118_regmap16_config; - } else { - config =3D &spd5118_regmap8_config; - } - - regmap =3D devm_regmap_init_i2c(client, config); + regmap =3D devm_regmap_init_i2c(client, &spd5118_regmap8_config); if (IS_ERR(regmap)) return dev_err_probe(dev, PTR_ERR(regmap), "regmap init failed\n"); =20 - return spd5118_common_probe(dev, regmap, is_16bit); + return spd5118_common_probe(dev, regmap); } =20 static const struct i2c_device_id spd5118_i2c_id[] =3D { --=20 2.43.0 From nobody Sat Jul 25 01:35:28 2026 Received: from DM5PR21CU001.outbound.protection.outlook.com (mail-centralusazon11011019.outbound.protection.outlook.com [52.101.62.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61800382385; Tue, 21 Jul 2026 04:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.62.19 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607050; cv=fail; b=JJRWWkwENZjHeTM/GyL1bCpeZMtZp1AOm9FRUPs6ZC7LjiaD3bFLW37eebVOjFkoiiQFswRyH3VPUI5ujx1CYMF8B+UgekinXVQ7OM8kCf0wOTWMpekku8YH8iAF35OLjTStMD06wLojopYwuMx3DVJRX+MKpl5UvLfJH4TZ7uY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607050; c=relaxed/simple; bh=vVsb/Q8y6JLjXFAuJgpDFUaQI81ismeyqQBz1UuHI3E=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VLJUKRQhkfR4ZEanhOuDZSOg/5rP0WIxMTx/N+iANs7Mt6PC7DU9toAsMFfHOhzHSNoN3Wg4kMfGNJBXkK5W4OEDDIhSE4Gw+98Iz83zxtzxgERx5reW8Wv6yw73BrdiyavxhmRa8xJawQWPdtxIzyByiqyreTLs4LoRa1/9bVc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=RKtaVWfj; arc=fail smtp.client-ip=52.101.62.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="RKtaVWfj" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EpzprrIcrSplbpd/rONGGY/kJIQsDlEcNbpCN1/5CcSi1OK0QLRFBzxIpgfx4qrP2zc+O4ATYvxgf01W7UI62+5BsyAF7mfuDJIUmk1dFwZItE0K7wIQNdQeg1v2+rzPFyab1pbSH7daLpuL5QyAEUd+ykOF1kQ0UK4sJF/hKbg8TD7ZTE/aoTCixp+GZBW253REIGyzlvVpSMp6pp1R+GOnS1lVHD1mNXakIv3m2Gt8kSFi74F3SDXBxpkGxA6EyjTq5k6t2MHjSoK8loKQauxNeGNKb+xrdB5w6pvBWLqeGCoAG/JNLZsnTRfspPvWtG2X+tYz/yt+3TdRaT5mSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hI+9mD6ce5H56r8WezXH6f5ENrHyw6qsoIIswBxLKAk=; b=Be7XZv5UE+mX9VUVkaP0kPGqXsvcncYuuoBysuek//YcLyeB0+YLRyzAqdx/cQOlE52LrHqYrQkJvb8wfuq+YmGgBisjpRORlHM+gXNqLe9JLcsX1A6IKDyI78MqYYqgOv+9Gq2iKjZgOT/BLYH7pwiArV0rJIxDGrGVIxpm3oxXBReWE+F+Xh1zRzDz9sRptOOfaD3M4f856WEtGVTtoZsQRd0FBGsWxd8n5FQ8RW5VOF9W5/a2OmOlKQO5MlwUex2jf07xZrD2P21EsDxLc/Y0V48iEE2a+bBEWeOnCdTf3IFgUbU14qSuSezrtaDIKw27WDYnn6CUx0bL0uuqNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hI+9mD6ce5H56r8WezXH6f5ENrHyw6qsoIIswBxLKAk=; b=RKtaVWfjsVB6kvkG1cyE9ZA87LMglN4H+ccYBHCJzGxdT8js4Y0PYcEqW0e3vpm9odg9/PdA6rpmwVRBX9ZdZmz8+NvOnT6YRHlPAVc/TgOOO9LmOe9JPc8rYH9scw9J3pPM6hwycsMWqpv9GpVg0pFjKU6l7p+D2O295x7D4eQPeYct/rJtpnHYQl2AjgwiaUZbiPLWd9SbGstHs1n2BoY6O005cOixdKKztmTRk/ANCE9NTBo7wGvLTdujDQRW7cEtCS7mHdKTe7q0Esw2ru0ab2CHqdx3uax6dPUsTuoMeXeiVMn73jnMwAeoMMWaJAF0ilxpu4S8Y2M6aruEhQ== Received: from CH0PR03CA0117.namprd03.prod.outlook.com (2603:10b6:610:cd::32) by IA5PR12MB999277.namprd12.prod.outlook.com (2603:10b6:208:608::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Tue, 21 Jul 2026 04:10:41 +0000 Received: from CH3PEPF00000009.namprd04.prod.outlook.com (2603:10b6:610:cd:cafe::ab) by CH0PR03CA0117.outlook.office365.com (2603:10b6:610:cd::32) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Tue, 21 Jul 2026 04:10:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH3PEPF00000009.mail.protection.outlook.com (10.167.244.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:10:40 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Mon, 20 Jul 2026 21:10:25 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:10:24 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:10:20 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 11/12] hwmon: spd5118: Add I3C support Date: Tue, 21 Jul 2026 04:07:59 +0000 Message-ID: <20260721040805.1696503-12-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000009:EE_|IA5PR12MB999277:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e8667e0-b08a-491f-89ea-08dee6de06ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|23010399003|36860700016|82310400026|1800799024|10067099003|56012099006|11063799006|18002099003|22082099003|3023799007; X-Microsoft-Antispam-Message-Info: K2lWWSGSsXsFQ+yGsFx7fQes7oXg67u9GXDGKgNs6vyPksDAjJ1Jgei+ou9CkjinhJDmgHOA+KHS7NWcWvgN1ERXx/JAIvHBwt3AmF4bLyLE7STrDl3p7VMS/9FY8x6l44+EieVlyc35c/fhtuHrx4WXul0QXqYGwzVCU0tMDMtHE0C64rsQad2E2+nBgggtcGYOjfF2YQSKAMtjhY7dTjURdeOZuw1zNuonmRRKwwRWKukhz3xT76lty//ddjEffMs6XUb+D6VlbRZBiMiDFPw3RY/BawpttVIV3s5WNTSxYiBsbAUU34WPGObw6WoDB0dgdwCul+h6R+/ImRCRBmJmpgKD2AUSyJriFq8w/dWceJYnRG5xSWw4W12qT20O5iHXvxyZ5ZUOtQTFmEw38QdKp9+5U1Sx1PJzmcBHYNtHOT3JJ+2AOFm93UPC18cI6Wk9dRyRo0pdbepWr56J8QsSR8aj+8x2Q2PfW0Eev8bEwki92gwy/uHln6Ci7ssVpxHic+eyKFeE//8559d8ONCDnegzAlfKOkrBu8xGb4sPf/UIxSwIodp/DZLMU1TnGBgh++XC6ziOxfWwjV+dhoWhqY0Cq7YBz6M9aTbbVomf/l9852sex2Wb+24Bk3R9f3X1pHzXpjyMDESPSx1l3JscBQt+WnmA0mKSfGS9uip17bgOYpwFtW4u7P0SxR+7yHimZQN3TcjOJBpypc5lCQ== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(7416014)(23010399003)(36860700016)(82310400026)(1800799024)(10067099003)(56012099006)(11063799006)(18002099003)(22082099003)(3023799007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: WI8DwkUkid8OFMeD9wlECyqqezAHX37Z/UHuEebPElgpHcul7aQqgJui9ojw3RbJYt+qOmClo46FJ1ypfoqKdC6PwHnMzKiU87zAmmvNbGMD2C7FSjPHOnRv9508rot6CTcze9W65D5hyJEkTMxvVNlh2eV2WxZn0/3WBQVojcfheRpzGrcpgS5T25U+FZpnBtZsfXxiBF6nZNgtXcz1Yo3DZeWurizFLNRby1ND+TNACzIh85aZqZSm6ofXwVKhS4FOndL+Bx8uuk90YrxJ1EW6d4VPhXebbQ+DHshGNpyC2BSBhc5UxXNl9JO69TeWaS58Bf7MiSVEk9jW5L5GPRlMNt4KhBGFaE6FFRSxg7ulF4ummSR3+FfxZoKyY5S7kPBgGxk+xI4fCk7YooJnneGcQUKbMPpIZWsQAO6llgLBpwzx8BmV+jVAGk3lRWk3 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:10:40.2736 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e8667e0-b08a-491f-89ea-08dee6de06ca X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000009.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA5PR12MB999277 Add a regmap config and a probe function to support I3C-based communication with SPD5118 devices. On an I3C bus, SPD5118 devices are enumerated via SETAASA and always require an ACPI or device tree entry. Device matching is hence through the OF match tables only and does not need an I3C class match table. The device identity is verified in the type registers before proceeding to the common probe function. Acked-by: Guenter Roeck Signed-off-by: Akhil R --- drivers/hwmon/Kconfig | 9 ++++--- drivers/hwmon/spd5118.c | 56 ++++++++++++++++++++++++++++++++++++++++- 2 files changed, 61 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index b2e445b5536e..d9feba036ba4 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -2370,12 +2370,15 @@ config SENSORS_INA3221 =20 config SENSORS_SPD5118 tristate "SPD5118 Compliant Temperature Sensors" - depends on I2C + depends on I3C_OR_I2C select REGMAP_I2C + select REGMAP_I3C if I3C help If you say yes here you get support for SPD5118 (JEDEC JESD300) - compliant temperature sensors. Such sensors are found on DDR5 memory - modules. + compliant temperature sensors using I2C or I3C bus interface. + Such sensors are found on DDR5 memory modules. + + This driver supports both I2C and I3C interfaces. =20 This driver can also be built as a module. If so, the module will be called spd5118. diff --git a/drivers/hwmon/spd5118.c b/drivers/hwmon/spd5118.c index 6ba37a719300..9724cf70b61d 100644 --- a/drivers/hwmon/spd5118.c +++ b/drivers/hwmon/spd5118.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -464,6 +465,27 @@ static const struct regmap_config spd5118_regmap8_conf= ig =3D { .num_ranges =3D ARRAY_SIZE(spd5118_i2c_regmap_range_cfg), }; =20 +/* + * SPD5118 2-byte register address format (JESD300-5, Tables 7 & 20): + * Byte 1 (on wire first): MemReg | BlkAddr[0] | Address[5:0] + * Byte 2 (on wire second): 0000 | BlkAddr[4:1] + * + * The address byte (with MemReg and lower address bits) must be sent firs= t, + * followed by the upper block address byte. With regmap 16-bit register + * format, this maps to little-endian: the low byte of the 16-bit value is + * transmitted first. No range config is needed since I3C does not use MR11 + * page switching. + */ +static const struct regmap_config spd5118_regmap_i3c_config =3D { + .reg_bits =3D 16, + .val_bits =3D 8, + .max_register =3D 0x7ff, + .reg_format_endian =3D REGMAP_ENDIAN_LITTLE, + .writeable_reg =3D spd5118_writeable_reg, + .volatile_reg =3D spd5118_volatile_reg, + .cache_type =3D REGCACHE_MAPLE, +}; + static int spd5118_suspend(struct device *dev) { struct spd5118_data *data =3D dev_get_drvdata(dev); @@ -701,7 +723,39 @@ static struct i2c_driver spd5118_i2c_driver =3D { .address_list =3D IS_ENABLED(CONFIG_SENSORS_SPD5118_DETECT) ? normal_i2c = : NULL, }; =20 -module_i2c_driver(spd5118_i2c_driver); +/* I3C */ + +static int spd5118_i3c_probe(struct i3c_device *i3cdev) +{ + struct device *dev =3D i3cdev_to_dev(i3cdev); + struct regmap *regmap; + u8 regval[2]; + int err; + + regmap =3D devm_regmap_init_i3c(i3cdev, &spd5118_regmap_i3c_config); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), "regmap init failed\n"); + + err =3D regmap_bulk_read(regmap, SPD5118_REG_TYPE, regval, 2); + if (err) + return dev_err_probe(dev, err, "failed to read device type\n"); + + if (regval[0] !=3D 0x51 || regval[1] !=3D 0x18) + return -ENODEV; + + return spd5118_common_probe(dev, regmap); +} + +static struct i3c_driver spd5118_i3c_driver =3D { + .driver =3D { + .name =3D "spd5118_i3c", + .of_match_table =3D spd5118_of_ids, + .pm =3D pm_sleep_ptr(&spd5118_pm_ops), + }, + .probe =3D spd5118_i3c_probe, +}; + +module_i3c_i2c_driver(spd5118_i3c_driver, &spd5118_i2c_driver); =20 MODULE_AUTHOR("Ren=C3=A9 Rebe "); MODULE_AUTHOR("Guenter Roeck "); --=20 2.43.0 From nobody Sat Jul 25 01:35:28 2026 Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11010005.outbound.protection.outlook.com [52.101.56.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3714B3859EE; Tue, 21 Jul 2026 04:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.56.5 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607058; cv=fail; b=LAxagDDjqBh6N3uY+MSsgzrlW9EYv6Bahcu4r8UIa0d5W/JVpsMmFh65cvcZF5J/BNQiZ5kuLRfbR96PFKiz/oZcUsI0eL724Ktcpj2jJxVsxRBVMNVK8bgtIsY9pIfWOd0zHVrrWwEaYZvdTz5atly9QJ7pazL3RhO1M+LyCuQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784607058; c=relaxed/simple; bh=HTYSPKh/YJxO/T3i6O6HVNW2UdVAKRchrzYqqhRPUZk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dvxFsTU+HxuxK8eroxVTrWMySVmLdC2gqdU2zRqK2Cfmkd2AXO/5bkxsabQDpmrPsRDXvpdQ2odeJ/D8eTbr9TwCczllXkyic2myA5QAuK+wQSRfub9e2iK/aLkdkHitNVGnY4rGYzaoFpKq+X16j6UDqv09/Y3K7S3F6EFdbk0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=fJusGRtT; arc=fail smtp.client-ip=52.101.56.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fJusGRtT" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=uMxPiDhsb7hcFyQrbmXC8REa/T9FdOL1+75QK2mr6PcEuSawkq1ZECRZ91SbzziPwhwcO+PufuVU0Sy4ia5kaFYKWwmuPj95mo0Woft+iVL5IAw8jtwnEi0ipehJIhOTc25lNtKvbnm2NSYuzh4kZyUHF+YAx/78DuHpeFxfZ0yTR0hLijuWdPE3HzJpzUbM1t9MEg1+eAn1DwZx62Lx9aFpaOPDei8m6f+7/IslLELTQikK4bxywWUspZNEkik61yvY/hxCeiAaKnAOjKtfBEqDaCxN4TbrF1XCiA8rOuY5GpepX4NsT0ZDIyURXFG/qEaZ6qh35ZHjFWbUg3f8Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IqPh08Oisk3mf8bmTDDy5gMxs1iAY/8KvvgWhFxFrRw=; b=cTrbX5Dw1HtATmFLZ9Um4cDQspQL+C5sRNQSyu/eGlRoUvK55WWTQGqOrW5vVyc8Mz7GMfPbqYfLsIL3jAiNkWQeGJaMYnCaGmVGwl4XjqWycyNvD5ysEw1BTnBnjjAbiwgIVZUkxcdqistvh7UzhitaD44e3cV1FP6yOkoXxK0BPD2zled8hKA1KcLjBUZ61JrN8103PDCZS9xIR8YlkJtVJ2iP+7mYwHWHVtWvnMSen8NVar3iGLLpHfUqCzbk6qRZJRBv34/560q3NdWndBvb249M6yfD1d9QJypQ0NzxkEb/fqx/peh9EsislilPQRkIvWPRaozpGvvbX5nm1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=bootlin.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IqPh08Oisk3mf8bmTDDy5gMxs1iAY/8KvvgWhFxFrRw=; b=fJusGRtTbIufAmegcPmDVJESDJoVs7/qdrdN6bOzQDd5NNxQUcMYl1ZsJD3i8ZGJC3xM3UcWZ0KtO+KHUxASFdkNrGNM7likuYHuNDdSmMEF7T+jVZCsJoLj2gKIbilAHYQJIVuhdeMnOotnO1y/3mjwAQI4nA3+UEfMZXLpu08V3fkK7YdFXQLJ2/Rw8mWPeXiBsfDcNm5Cpc0r2Ifi3pjOL3J5P4r7GQJjWpIRJ5wkyne6Fq8L3PMBAlHedACM1DvxEzdapv4tMsvTRkSQpH7jibU3Dyw89St/VMNnHFdMfXp8laTVf7js/17LhX0SQbPywlNSlKae45TK1H5p3Q== Received: from MN2PR14CA0013.namprd14.prod.outlook.com (2603:10b6:208:23e::18) by MN2PR12MB4390.namprd12.prod.outlook.com (2603:10b6:208:26e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Tue, 21 Jul 2026 04:10:50 +0000 Received: from BL02EPF0001A106.namprd05.prod.outlook.com (2603:10b6:208:23e:cafe::5f) by MN2PR14CA0013.outlook.office365.com (2603:10b6:208:23e::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.245.10 via Frontend Transport; Tue, 21 Jul 2026 04:10:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF0001A106.mail.protection.outlook.com (10.167.241.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.245.5 via Frontend Transport; Tue, 21 Jul 2026 04:10:49 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:10:31 -0700 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Jul 2026 21:10:31 -0700 Received: from build-akhilrajeev-noble-20260602.internal (10.127.8.11) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server id 15.2.2562.20 via Frontend Transport; Mon, 20 Jul 2026 21:10:26 -0700 From: Akhil R To: Alexandre Belloni CC: Frank Li , Miquel Raynal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guenter Roeck , Philipp Zabel , Jon Hunter , Thierry Reding , , , , , , Akhil R Subject: [PATCH v6 12/12] arm64: defconfig: Enable I3C and SPD5118 hwmon Date: Tue, 21 Jul 2026 04:08:00 +0000 Message-ID: <20260721040805.1696503-13-akhilrajeev@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721040805.1696503-1-akhilrajeev@nvidia.com> References: <20260721040805.1696503-1-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A106:EE_|MN2PR12MB4390:EE_ X-MS-Office365-Filtering-Correlation-Id: d4375b26-b1de-465c-b4e6-08dee6de0c44 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|23010399003|7416014|376014|1800799024|36860700016|18002099003|22082099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: WulHnFTjsoKFJnRgLzZxANrDKO8lIIIYHn/A3619sdQxsrt2kp/RXy6dRQCgnAgRWRL6hx7XVmzfQtl9OfZ6Rmm2WHDLTRhOTMT8q+mixjHiRKbspNgFf1cDun+1hVC1q1fAKTxualYvQ15+2JM/FfjPJV49pMI0DXjs4xVKXXBU+WSz4ErNwp6LAVPsewPlkm/mZRbUxK4kGn7Ss+m8sn9RD5EUwjBJMBUeAM1CwNbLeEFnbNCt/GWhJhsw4gX+CnxhvlNb4F+7IW2442DRqFv9tpkXRuN7s/V4jKi8uGvP+CEtv3qerrkRQ31flfegdD/mYVuX6oZiTg1gQRrTmPKvwNLHNqBJzEcbf1oJ6eS0kih6qaYN0cDTa4co+12+ctGIZ1ggWnuOi+rDhOVojJQsvtVpsWMtZolNgYD+HsztQVoxv1ktunICyje+Ro3PHpuNGRoFUYfXVExbj2eqzsVjC/PMXwu9+Vx8rSkvuWSfsVHITmNEPkmsG5m9kYqP2BDfFqvubxDqGo7MEJ+S09dhihZgiVbSNy0YkHpgQktyZRnqFffKmLCabGaAkX+ciYQQzIvjpdnrnTm5kpBVZH5DGL3hqjbgPUSmKGsl6xb1nnhE28UzNsRri7rA/dxgksaahIDwtFKcIVDKFzJdkyow2gicnAp9IjOnknrLTEbOzpp1jrnlBZWXjDXLksWPyjIPCsaNEqRjpx47HEpr8w== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230040)(82310400026)(23010399003)(7416014)(376014)(1800799024)(36860700016)(18002099003)(22082099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: UWd9qwz3zy+K3uhnDCeDWnsqx6kjlwaTWKTH8TgDEqyeFwLgjNzj83b8Xx01fctYSjR5pKAzXr9nFwVZxDqge9jdyX0NCmyIufHGDqH60GhGpFrVNSCLDIrrb/8Skg37nAmMdBupUujmXVf03j7QEhHeuEWdf0cHj5NnJRMThfiFYp36pEkN8rAdWrNiJ/uYLDZ9BbRet01JNM2/+GGkwjt5cwzRAuUZlvuUvszG2nr0JoiHmrJlpevh8mKqO1MDls0KinIzgceXVVmwMkRp8ryorxmQTzobDxy4GKVUhA39NBjAl2LdVGrkqITvCCVHk1XIfwSsnHRbHKUOTCVuYtdTh0IVg8r8cPpChU41h7G62fVxADIBGAxe6vk3OCU9ohZPg6wis4/4D/OvuZvfknPr/GvNrrU5MZ05SaWXkJCtsjO+uN743guIjXHbKUHY X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2026 04:10:49.4264 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4375b26-b1de-465c-b4e6-08dee6de0c44 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A106.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4390 Content-Type: text/plain; charset="utf-8" Enable I3C subsystem (I3C), Synopsys DesignWare I3C master controller (DW_I3C_MASTER), and SPD5118 hwmon temperature sensor (SENSORS_SPD5118) as modules. The NVIDIA Vera CPU uses SOCAMM LPDDR5X memory module, which contains SPD5118 (JEDEC JESD300) compliant temperature sensor. This sensor is accessible over the I3C bus through the DesignWare I3C controller present on the SoC. Enabling these configs allows monitoring memory module temperatures on platforms such as Vera Rubin. Vera is an ACPI-based platform and does not use device tree. Signed-off-by: Akhil R --- arch/arm64/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index c267f0906460..36a7cafef3a0 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -639,6 +639,8 @@ CONFIG_I2C_UNIPHIER_F=3Dy CONFIG_I2C_XILINX=3Dm CONFIG_I2C_RCAR=3Dy CONFIG_I2C_CROS_EC_TUNNEL=3Dy +CONFIG_I3C=3Dm +CONFIG_DW_I3C_MASTER=3Dm CONFIG_SPI=3Dy CONFIG_SPI_APPLE=3Dm CONFIG_SPI_ARMADA_3700=3Dy @@ -768,6 +770,7 @@ CONFIG_SENSORS_SL28CPLD=3Dm CONFIG_SENSORS_AMC6821=3Dm CONFIG_SENSORS_INA2XX=3Dm CONFIG_SENSORS_INA3221=3Dm +CONFIG_SENSORS_SPD5118=3Dm CONFIG_SENSORS_TMP102=3Dm CONFIG_THERMAL_GOV_POWER_ALLOCATOR=3Dy CONFIG_CPU_THERMAL=3Dy --=20 2.43.0