From nobody Sat Jul 25 01:35:10 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 274BF3FFFA8 for ; Tue, 21 Jul 2026 02:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600095; cv=none; b=q/ACVSBG8io2m/6SbSJSP+Y0mtsbr0aOYcEViXB4iWDB1MChw9g5F7ZyvagSL4QihM7r74EmT5p6hfzecITEmkuAIgGe41Funk9nZWR8ddVNv4GjSaVz8zbp937QwGFoZndcLQs2EzbiQRCuBoMni0TZ9vhXuVGyRr7rOQqoNpc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600095; c=relaxed/simple; bh=tTM7ZUO5l79xlSlAd6AQmfbSdjjCjN8UgweVaG8QZng=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rXwPEF+rXY1T6jUQtLHxuObvORTrCxQr7C0qG7vVI+8ykw9TpsJHOT0pgcZPny2DoE8Eg45csvPExygR88OueMRGLBo3mi37A/8IXTnSSKPg0TRyzNmQL02xyJwIEgpk6n17EHXvBA+BziicIyzwQXPaOMYRLnwI8nbbmmUYdw4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m8iPzetL; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m8iPzetL" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-38e07ebd263so4736059a91.1 for ; Mon, 20 Jul 2026 19:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784600093; x=1785204893; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=z6qD1eCX8UZOQGibHra7bJn3ga0Dq+Abt2SRuAhtEeA=; b=m8iPzetLHIZHb3hYWgzVGq5Ilpn0rizK11Y1TlMJy35+vSkmiDMAsDLsMCqEJFGZsH VfggjzBz1caC67KNOaBT2ZdkdVKk9yPrh/SiNbB9jsbIwtdZoSbumJIkhs0RKOK3pZ4h DjiYMUhfPwKJ46wAcP8G4Z9xbIRIMa3/I3z3mGwgP4xibCZowPJxPZ0Dyv/c0MdGG+we EXn8Omv7wn/m3TtmK2INeL0mZNlJCCEEjh8JQom++/TJXqSz0aKkYfGi11koAah6NyzR tVndwledBRj590bbv+ir+BK/cnjb45jSyis2XtnjAfHyRuyy46hpQnIy7vxuu6CxbCjl 2eBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600093; x=1785204893; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=z6qD1eCX8UZOQGibHra7bJn3ga0Dq+Abt2SRuAhtEeA=; b=VZFFOnT8m9TOfTcWaq3nzLjapmUOd+BkY0ehEUE7ZKe0FL0zFFgONBq2Ud6RL5FDEb QEVUx7tlXAG5bdKIgi2Ywy5XfKIyp7M71ZDN4YVRmMzqVqYBVwswAvuJN3R6xIOVZ1WL 50mVcAkfCCQqX8AgrbCik/h6uLgpPYpbAGR0HoRcxxwzt5/zzEtzoZhNGfta0vCwmTuK E/epppHIKI1lc79NivTu2ZD3jrG2yUrm0RddR+bTpoRJZLIB0mtjVqzJtVIuMivqxobN T0ykvkQF6PkQCWzicF7GJIfyy3CJNeTTxRj/qM/QoL9v36vo4HG3M9A5A2+VDPGiWXB8 cZNQ== X-Forwarded-Encrypted: i=1; AHgh+RqE5HpoDAVwfFLAtrN3FwWSdx+MpyBbegHwqde16chDHFd57HqhfHyk0U88p5OT9FFGWF417ZPXUiCwGLI=@vger.kernel.org X-Gm-Message-State: AOJu0YwE25yOA/ICbjwXQkYowz9Hrgvm1iDw6TTZXbhnKiCLn4w1Zu09 n35lvP4vR5WXS0dfnCsK5YAyGJ/bWepSGtdqxfeIZaHIan25Gq2vIh8w X-Gm-Gg: AR+sD12iq4/pYdRyHxUJCZ/xuYTDL/bXmKUNn7kLbxXevNdAuShSTBo7zS1EkgJRy8I lFNi+bBvo7KZyni8seA6fz2elyF40spLPJNs6603tLDHhaUIRRgEqRAUKeiYo0wrkcx24pbMDX0 rH2bmcydt4swKlZ2fDzET36RYIasAW2eqqAJg9JDz5MQid6jBnqD5OaXyJC6Zus5QBEshnJt2ph lGBrS6q+osA24niQOSIH3qNRKPokivK2mKpe3+xWfUwO5rTfh8LCxc8D/TsajKAU6tTharIpAjA +wO+5PAsESEEowLWMXTKssRTdhRtDTwqb4lvfclCQADs/l3UfZ/qTHuH6woH5PtlRLgiVZL1yDf 4y6nTwdWa08SxFjK3r9hYD6Pju6ez1dasm3YKavwasVaLvRtIID6ZG6ntPsQvdj2SWDg7biLUo+ y7H0f8fEzVGw8TFt08EfbZM/iBsnRde4AALfuAHsOoVNERlcy9FmJw78kBykHxwmI= X-Received: by 2002:a17:90b:3ec7:b0:38e:cb1:8ec9 with SMTP id 98e67ed59e1d1-38e4b585bfcmr17200761a91.42.1784600093473; Mon, 20 Jul 2026 19:14:53 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e9235a4dcsm586241a91.12.2026.07.20.19.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:14:53 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu , Brian Masney Subject: [PATCH v4 1/3] clk: nuvoton: ma35d1: fix ignored div_u64 return values in PLL freq calculation Date: Tue, 21 Jul 2026 10:13:54 +0800 Message-ID: <20260721021356.288506-2-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721021356.288506-1-a0987203069@gmail.com> References: <20260721021356.288506-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" div_u64() does not modify its argument in place; the return value must be assigned. Both ma35d1_calc_smic_pll_freq() and ma35d1_calc_pll_freq() called div_u64() and discarded the result, leaving pll_freq holding the undivided product and thus returning a frequency orders of magnitude too high. Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock contr= oller") Signed-off-by: Joey Lu Reviewed-by: Brian Masney Reviewed-by: Alexandre Mergnat --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk= -ma35d1-pll.c index 4620acfe47e8..bfedd45bd04b 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -92,7 +92,7 @@ static unsigned long ma35d1_calc_smic_pll_freq(u32 pll0_c= tl0, p =3D FIELD_GET(SPLL0_CTL0_OUTDIV, pll0_ctl0); outdiv =3D 1 << p; pll_freq =3D (u64)parent_rate * n; - div_u64(pll_freq, m * outdiv); + pll_freq =3D div_u64(pll_freq, m * outdiv); return pll_freq; } =20 @@ -110,7 +110,7 @@ static unsigned long ma35d1_calc_pll_freq(u8 mode, u32 = *reg_ctl, unsigned long p =20 if (mode =3D=3D PLL_MODE_INT) { pll_freq =3D (u64)parent_rate * n; - div_u64(pll_freq, m * p); + pll_freq =3D div_u64(pll_freq, m * p); } else { x =3D FIELD_GET(PLL_CTL1_FRAC, reg_ctl[1]); /* 2 decimal places floating to integer (ex. 1.23 to 123) */ --=20 2.43.0 From nobody Sat Jul 25 01:35:10 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85913400DFA for ; Tue, 21 Jul 2026 02:14:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600097; cv=none; b=I+zp9mHS3h9lrOj1SiQJS2wL8ORFFdbMYZq3g+Y1wKK2DCsPAqjyBXv9zaWNNQ4PcAS2HndPleJEH27a8YfNhVxz9GfXnHsTIvwBVtW7rZ2WKKs5fiwmy3s3VOvfcRicYbmqJZshDKI5xdMHUCoG77kSu9t7GY73AGAepYTjM+I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600097; c=relaxed/simple; bh=7iYJyleZBwgksxOOmPrkRVeVrn+YU5L3ImQL22TAFUQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=r5CAc6/Y1AI4mKLIosA2F4lnPHzVLhv9rzckr5UrHK64ImW0RGXQ/zmB567LNix0tYh2Tm+TgMP3NvMpAAt+DXC9siXeZvm3YmAanf8hUaVAJIIJRioY7Vs6ng/iP80oEo4kls51Gj4kVvEAUuA6keHdJY4Nm1JdtwQPch+/Uzo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LQCQsRsi; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LQCQsRsi" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ca64c3ce5fso124011635ad.3 for ; Mon, 20 Jul 2026 19:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784600096; x=1785204896; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fUEMfFXXEJWfpYYV6BprYH6yq5tTMFc+tIMi7bPpkS8=; b=LQCQsRsiiES1XpztBA5NE+Cw6bPHZ8kLpKVsWaiMV3iJpH2DB7A06hQx8SvNhtPE9l 3UPwJsxsgfZ9veuLSGoqkiGLGRiwuHzT6ZmZcA66AuoVsuj6v7gKnEAmcFVkmji5hijj G5y8FPax4RPX+sBJEL/GgB43TvXy8ASSH8gvaa6fkctfSMEEO87dpplEsEmK2NGTHyg/ CGkqXiT25hJAig9nT/U5CbWGHc8YBEVNjBaqGQD5MDsMBFEKpbA7t2ePR8QBDXCz2Il7 bb39DRllLOXjbr5xirBWJAOvRoY3NriQu4JDD/cX46NH0TeSVqHiwsAVXZ302v389KiM 59jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600096; x=1785204896; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fUEMfFXXEJWfpYYV6BprYH6yq5tTMFc+tIMi7bPpkS8=; b=BJnyPqEKffyeZjySzHmVfKThgDl4/s2eENdHGHOnQ8G11DMFVTT1UVC/u1MoRvtTTg 0gqwQiEFqNLB/1GWvd56yx+Mn3ko+ng4EivwGOmlQJfQNh9W34PKHXvIIseLx70Ma1zc JfXOIaKfmWFj/jO70uHdMT2JA0mB6K/REjBcfWaL46YewduETJbift6gQCyRHo6A2+BH 9E3qYYISphp+BHvejN/olzNJQdFTC4BZ9wRKlty4TVlRIGh3QyAaZRvBrzoTgMGdLfAj w8I7n3hJYvmBhWBi3aPS+tze/VpAB5+ojLF9p3a83S5/zd7vA2PnKlAEj/qnwuXjlolk YHDg== X-Forwarded-Encrypted: i=1; AHgh+Rqopm3T7wfTNL7gUd5Q20OkOFe9W8OvfE0shZL+g+jDObqF1wImiRVJOaJqt05qthqcRcCU5P0SSaVI0zY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzgaljc7ZcDNZ6SQe9IAExTaAOK9oSc460yA/I+naBO5i3L4nv2 yt2ZlmiaYjzNDHQSf84ATXXwKbaabLs6JQ9C39a299AUZHeBvSaO8TvN X-Gm-Gg: AR+sD10XQzheJJtDHZonSiDXiqzgvKJ1UJyPQQHesyjCD62C7BheoBoK2MH9H6n4UBu O8CZ/2/22ac9nyZ0KwOCgxYpEZeccXJp0GZdAchJQxODZOhakaShwY3KhZCUUdnRnFIUaLLeeFg w+03te8pX3Ew9vrJhlTAVZVo0g/Yr+bxCxjDMqSgm+TgN1iiTJp8GFTl1mX/ZcsbMAaxqI69Qp2 I0rE/IMOdJ5TVRh770TPG0KQAcsKOUQbm66rsK+Q68B0+7G3vG7lqwIEpZ/6BEirJAGJIfM3piS YfveP2UiQTftVe+6kbbhlf5x3xeQcU9dgAnQAzVFaUBFgzOEq3Fy19gJ8mMIK2ALV4N06Kqp2+F wkP5+nMVoYQ/HUD7SJZOc6fM7ZPVHfNxug7OJToOPefBWrZ85Uolfoi5zkhqYbyhSxvp2DLEPpA c7DLpmLjwEFLSRmpaxtqvmvL127jGKL/d+K0z6qhnu7zhlRSlhaQCNF2/0DHguT6g= X-Received: by 2002:a17:90b:56d0:b0:38e:e0b:320d with SMTP id 98e67ed59e1d1-38e4b594707mr17316465a91.41.1784600095935; Mon, 20 Jul 2026 19:14:55 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e9235a4dcsm586241a91.12.2026.07.20.19.14.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:14:55 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu , Brian Masney Subject: [PATCH v4 2/3] clk: nuvoton: ma35d1: fix PLL_CTL1_FRAC bit field width and fractional calc Date: Tue, 21 Jul 2026 10:13:55 +0800 Message-ID: <20260721021356.288506-3-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721021356.288506-1-a0987203069@gmail.com> References: <20260721021356.288506-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" PLL_CTL1_FRAC was defined as GENMASK(31, 24), covering only 8 bits. The hardware fractional field occupies bits [31:8] (24 bits), so the mask must be GENMASK(31, 8). The previous fractional-mode calculation used FIELD_MAX(PLL_CTL1_FRAC) as the denominator to obtain 2 decimal places. With the corrected 24-bit mask the old divisor is wrong; replace the arithmetic with a proper 24-bit fixed-point rounding to 3 decimal places using the kernel's DIV_ROUND_CLOSEST_ULL helper: n_frac =3D n * 1000 + DIV_ROUND_CLOSEST_ULL(x * 1000, 1 << 24) Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock contr= oller") Signed-off-by: Joey Lu Reviewed-by: Brian Masney Reviewed-by: Alexandre Mergnat --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk= -ma35d1-pll.c index bfedd45bd04b..eb9d69d2077b 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -48,7 +48,7 @@ #define PLL_CTL1_PD BIT(0) #define PLL_CTL1_BP BIT(1) #define PLL_CTL1_OUTDIV GENMASK(6, 4) -#define PLL_CTL1_FRAC GENMASK(31, 24) +#define PLL_CTL1_FRAC GENMASK(31, 8) #define PLL_CTL2_SLOPE GENMASK(23, 0) =20 #define INDIV_MIN 1 @@ -113,9 +113,9 @@ static unsigned long ma35d1_calc_pll_freq(u8 mode, u32 = *reg_ctl, unsigned long p pll_freq =3D div_u64(pll_freq, m * p); } else { x =3D FIELD_GET(PLL_CTL1_FRAC, reg_ctl[1]); - /* 2 decimal places floating to integer (ex. 1.23 to 123) */ - n =3D n * 100 + ((x * 100) / FIELD_MAX(PLL_CTL1_FRAC)); - pll_freq =3D div_u64(parent_rate * n, 100 * m * p); + /* convert 24-bit fraction to 3 decimal digits, rounding to closest */ + n =3D n * 1000 + DIV_ROUND_CLOSEST_ULL((u64)x * 1000, 1ULL << 24); + pll_freq =3D div_u64((u64)parent_rate * n, 1000 * m * p); } return pll_freq; } --=20 2.43.0 From nobody Sat Jul 25 01:35:10 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14866401492 for ; Tue, 21 Jul 2026 02:14:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600100; cv=none; b=e2HWC7b2EXiOu3+KszofxEAEwVLRbIcQCAQrnZiELgjqfU50WWPvtKRPn0uAN9A8sdS35FX6bkLyibO5GwsH5IVGVqvMJeMaX7RsPFI5k9ctcH3JusqP+pNK3iJbi4POQDCkR9friJSgkTzi4x7kJjpbkjdjP8xNoSlauzI/pDA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600100; c=relaxed/simple; bh=3QjoFwvYtFGSj7HucuLDgEEIU1vwshWyt15pjIaKNU4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XGzamnw8aRrzvpMPf106WIjbiHFRo9dqmfMf9tE02dGYBZOaoHWQyr/xalQu9qKQe2TbZB0bL4wLYQP3WopoSJ4knKtPfRiCyi/w2IK6fef/255Rhr9TZjU/gmtjMNRAqAjuu1T3Zeu+BwfZZSoLMWJ7lFfhIxwko5TxdgOqfbo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KLqP5wDX; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KLqP5wDX" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38d489b6b71so10206399a91.0 for ; Mon, 20 Jul 2026 19:14:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784600098; x=1785204898; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xBzG8ZBOhqwEqdTqOTAwTbc1kw7Fn4SE9BojLVsipUQ=; b=KLqP5wDXxmuvUbIndpcls6m/QQBkeFrRW/25RM1qMw7z1ZXP/Q6mhS4cw+8OEFjgKG o3AtyPNyvboJHgmytbjYIuq1+6V/c7kDVqh5JIY00CJ+l6ixShohLKjw5EukLVfEZ6cu TIRpM9uZeeoWzKF0M7FnvFbN9nCbN9vUc9JeL90QphhZFaixjKDuv7CT2bhsV3CvtK0M dgmVhmAKgyru2plPncyR/PULsD3NJx1qTr9L865groRP/J/bHnmBCPP3qkygdZz1NHz4 rZRJ+eXb25G9hapmQHX/R8P/hUBJb7UWhN8gSjSRqReDcmjdY+v0SdmFXpPf9tvWeKnU 4fbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600098; x=1785204898; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xBzG8ZBOhqwEqdTqOTAwTbc1kw7Fn4SE9BojLVsipUQ=; b=VkYRvUiLPjR+z4Xr7vjH2nNxa/qZXwnHUGkPmQvuyoc0lbD1kAnrIqpfwW+BOWUyfg XEQBK2FW4puFFNO+1g2rKSZ5zCHHgUfKFy/7G5U1M27qQvZovMxJH7qVnEEFtPB38mPz 1NgAYR1aTEgvfXzNPcoyYdMnuyRe3n3UCkthIK42uPJDimkLXcvXlD5Df/xYCwnjQAom Au5PtBMm5LMIm4amX8Car2KMHgBvDaoiijTs6fgeVv1qUYt7YWIt9B+04NyStCCp1/Ci xz+O/4qrM6COe1xp/BKsOXJIeJgcx6uouxlTst7Dsv5IXUlLJz84tlXNRhOFQ7E9pe3h 5fsQ== X-Forwarded-Encrypted: i=1; AHgh+RppmNlj7yD5F5wFjpJHYwVMyTO3cSYU4zBc/g6NiDTZocJMIU+wOVWE2z+N1XABurLCKknTYSu1DOdSDyU=@vger.kernel.org X-Gm-Message-State: AOJu0YzxMxxdD99hT0aDwBFQJcsjt8NFIrjzb1FP6CfZM8hHHjCchNq0 pG6hnvw80vBLpatzMKeJhdUBfVgsKUsxuvJ3EBXDHnaDIUtAYPy/Q7zw X-Gm-Gg: AR+sD105i2JbW+/1raRdWrBAp6EeArUaxbzx2RMdca/wda4eGTP+WOsSQHWi+BGbp+f pQnoiqWyEUY5j80o8A1HxQ/oIZtQIStKlXRLT7ZoN6HoHMgJMit4F2gHimKGo/22/NgjjutMCgN 5jF+Cr1Sqa+BF47neCowNelwa2uWXsVzlJc21GDAxZpdrR4fF/oMkgXeGg84IN55DxXcA/JVYFs Z3cK/242rct2wxCvqxintxarlHJoUhJjMFwkbImHrcqJipy4ryb6LD2/81QmLLPdb81iVYlFU6G 602kqbIV8YzN9/MCyaD/qUugCL+6uI6Uf96dI43CrtO4NYuVYD2cgvDBxobe8ohO9kWjtLV2ljr zDty8wdju8kOCqhqY9lYVbTGSpDc3969xXOCA1mStzZcQco/4phYd8ZiNGNXHhrG7sH66cjuRvj P6Zw7q5sn9tdsc8u17IHIxqhtFnKFxYigZlKl0BiHlwBfO6M79jVPLvF5Sb9Qqy1g= X-Received: by 2002:a17:90a:c104:b0:38e:679f:3b2a with SMTP id 98e67ed59e1d1-38e679f4dc9mr7825253a91.30.1784600098282; Mon, 20 Jul 2026 19:14:58 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e9235a4dcsm586241a91.12.2026.07.20.19.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:14:57 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v4 3/3] clk: nuvoton: ma35d1: fix ma35d1_clk_pll_determine_rate logic Date: Tue, 21 Jul 2026 10:13:56 +0800 Message-ID: <20260721021356.288506-4-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260721021356.288506-1-a0987203069@gmail.com> References: <20260721021356.288506-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ma35d1_clk_pll_determine_rate() called ma35d1_pll_find_closest() unconditionally before the switch statement, and then every case branch overwrote pll_freq by reading the current hardware registers. For CAPLL and DDRPLL this means find_closest() ran unnecessarily (and incorrectly, since those PLLs are read-only) and its result was silently discarded. Fix by moving the find_closest() call inside the APLL/EPLL/VPLL branch where it belongs. Group CAPLL and DDRPLL together as read-only PLLs that simply report their current rate; handle them with an explicit if/else to keep the CAPLL (SMIC design) and DDRPLL (standard design) paths distinct. Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock contr= oller") Signed-off-by: Joey Lu Reviewed-by: Alexandre Mergnat --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk= -ma35d1-pll.c index eb9d69d2077b..c7c0dc91a012 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -255,32 +255,32 @@ static int ma35d1_clk_pll_determine_rate(struct clk_h= w *hw, if (req->best_parent_rate < PLL_FREF_MIN_FREQ || req->best_parent_rate > = PLL_FREF_MAX_FREQ) return -EINVAL; =20 - ret =3D ma35d1_pll_find_closest(pll, req->rate, req->best_parent_rate, - reg_ctl, &pll_freq); - if (ret < 0) - return ret; - switch (pll->id) { case CAPLL: + case DDRPLL: + /* Read-only PLLs: return current rate */ reg_ctl[0] =3D readl_relaxed(pll->ctl0_base); - pll_freq =3D ma35d1_calc_smic_pll_freq(reg_ctl[0], req->best_parent_rate= ); + if (pll->id =3D=3D CAPLL) { + pll_freq =3D ma35d1_calc_smic_pll_freq(reg_ctl[0], req->best_parent_rat= e); + } else { + reg_ctl[1] =3D readl_relaxed(pll->ctl1_base); + pll_freq =3D ma35d1_calc_pll_freq(pll->mode, reg_ctl, req->best_parent_= rate); + } req->rate =3D pll_freq; - return 0; - case DDRPLL: case APLL: case EPLL: case VPLL: - reg_ctl[0] =3D readl_relaxed(pll->ctl0_base); - reg_ctl[1] =3D readl_relaxed(pll->ctl1_base); - pll_freq =3D ma35d1_calc_pll_freq(pll->mode, reg_ctl, req->best_parent_r= ate); + /* Configurable PLLs: find closest achievable rate */ + ret =3D ma35d1_pll_find_closest(pll, req->rate, req->best_parent_rate, + reg_ctl, &pll_freq); + if (ret < 0) + return ret; req->rate =3D pll_freq; - return 0; } =20 req->rate =3D 0; - return 0; } =20 --=20 2.43.0