From nobody Sat Jul 25 01:35:28 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C61073FFAAA for ; Tue, 21 Jul 2026 01:58:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784599140; cv=none; b=Ywhze4N+upy7r4XY70Rfm3c4M6FXdiw8sGmG2qrakr9HRSG99f1wTqumGBjbAyVntwmKVeWmC5SWWjEQ7Bv/gRGO2TEhlzYMtnvCumxd2oHhJ4+5W9uwULx2yLlxJETEVKV4VjcCX0heNrTinFNuR/ks5SMkvfWhUZt/oYCj5D8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784599140; c=relaxed/simple; bh=64BryWhazFiSQGTHWsvVf9n0qNYmhx/nkK0q5awa1cI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=MyIZgDqee/zmrU9fD3bj1h/opDyez2TbCVSmruPpnzqm3/BeV0J6a6nCf5IuUF3svpSxKXwxGIb5gczjw5ZJ1ZpcICitRiCba/CJSk594SlgqGr+8JwMd6nG32D2U9VDOk18dg3/fnqJWCl9rTwn0/WNZrVUpKKXJ0d4N6Eug8M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VjO3ncyT; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VjO3ncyT" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-38e3efab7e0so3155211a91.0 for ; Mon, 20 Jul 2026 18:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784599139; x=1785203939; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=4L7OFyjs0agWHOOlRPNJjGmbLFr+eh96a4dzibePYvg=; b=VjO3ncyTDuVE1xGsyZN5nIfQDfN3bT9y6xOspNZJar/z8Yho095fy51X2/jgsVCpkX DXUaopXzzJodG2yMaeijLWOccZoYAtFtB79r9xYAo98yOrp/AjgO9km03Q6KrCBd9iSU evvikB/RuotL1XcAGJ+ksk99JU9KI4a/LPy/Mn0gaPBw4t4bqTUk3l9IjFdnVRyiP7W+ Kay78KmuqLQHHdOVW9Kb+VZ23vMY2tHT34cT60o7hPtGoEAyoAOxTUeu2qh4iNMsoGYN sWWrv65mf8lMByZxxIb3//z49rPF/r5tXmtE1k2inwfaGZC5GWrF9jPArc6pHpClDIhy G/8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784599139; x=1785203939; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4L7OFyjs0agWHOOlRPNJjGmbLFr+eh96a4dzibePYvg=; b=OyAqVTIGEXL2JjHkVjJL1lDY+G4RwbnFG+zNRHawH1MVdlBAVkcmb+BvEOl01GfY1d y0+9r2Tq6kApr9HGjNuAX1HOuIbHnUBt+9SSNkvhqcex+Whep+tvbGcbK0zxPDX1sBwO rx9Gac+mE4Ka/0TpdTtxBNNkznrEO+uMtf4LEhkx0Z/WQrmBTpkLaufZKQ2voonVgk4s 0g/pOKPUn2BaZ+rUv6jiopH+7nKzezenUs66RhimWgcm9xpqjPU0U5hstlD1d056PTFb N1yoQt2ctvjdMTsphMWcB3XUUrz2ahiM2q/Ku4NjQEjVoACPjjs1z1S9iS3iTEQeVg3G tT3w== X-Forwarded-Encrypted: i=1; AHgh+Rr5FRcTZUpVws6RApwI6Ez3zpzanO0LTRhcRXkuTQXJZ+7SYTlLVDqfyEOjUa1Su9KxZVESkgRQm1HxzKE=@vger.kernel.org X-Gm-Message-State: AOJu0YwxlaIzRRyd/EwHLF/GvgMpzFftpufV66+5PgAZ9qzUQBCKHLVL VEra5qvSrnzujHzW+U+1LtRRnP3RFiyNKLIWCciLn12qEB8YnhPeGvy6 X-Gm-Gg: AR+sD13hxCG762arh1tgK9iFblXnJ45LSdufWdMlA+5UUYJEpK/tevkgja7m3ngUS4U /qGgm7sntbOJn9m7Mf89gDJCpE82heeGDwilp8jzwiePOW8Y0Mc0MovJxlNLaMSrj4XTSUiTt78 LV1ZhBlQ2ST5etRACFExSJvWFJPHPxJDBzm7zFn2qmyHBN241iozUCwm3OiYVyftnUyHpvTiLm6 DugndcLgFH1KOKLnDrJRe3ClbIriPE0TEWYQIy5GGoKmJ5Tc2GtS4ExtvXltOEJ3EuHZcNZfxSI kRI+fv9VUgJwMg1EukZW3YhwR5/gtmdUAo62UMsFlTB0oe0yVmGT4g2hNAKi2NFZCF4si8uGCSg 1q8Z2ujT0GLsHypci+3Cm+paVex1UXrfXp4NatLYyLbq7JQ6CmbupWysf2IecExA3grGNR9JfGy ZG3Tzi/Ajd6z4a+feEZ5amaxbjJjAY3b6m34tpVjY/IU83rhwgsatBKXz9ZwhSRFqGA1biMA1WQ nHWdftkGMS0YUjMbPun+AxhYXHO+d2PeIrYbo2ukr9zS1v8XcQnEl8= X-Received: by 2002:a17:90b:2891:b0:37f:9e21:91d8 with SMTP id 98e67ed59e1d1-38e4b68268bmr15320913a91.15.1784599138974; Mon, 20 Jul 2026 18:58:58 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38e92064c77sm620646a91.1.2026.07.20.18.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 18:58:57 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-kernel@vger.kernel.org (open list), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCHv2] ata: pata_pxa: use devres for DMA channel management Date: Mon, 20 Jul 2026 18:58:56 -0700 Message-ID: <20260721015856.17503-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the DMA channel request to devm_dma_request_chan() so the channel is released automatically on device teardown. This removes the explicit dma_release_channel() calls in the probe error paths and in pxa_ata_remove(), simplifying the driver. Use ata_platform_remove_one() which is now equivalent to what remains of the remove function after dma_release_channel() removal. Built as a module for arm/pxa_defconfig (CONFIG_PATA_PXA=3Dm) with LLVM=3D1 W=3D1; no new warnings. Assisted-by: opencode:hy3-free Signed-off-by: Rosen Penev --- v2: Use ata_platform_remove_one() drivers/ata/pata_pxa.c | 22 ++++------------------ 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c index c816997dc0a9..a694f6a178e3 100644 --- a/drivers/ata/pata_pxa.c +++ b/drivers/ata/pata_pxa.c @@ -262,40 +262,26 @@ static int pxa_ata_probe(struct platform_device *pdev) /* * Request the DMA channel */ - data->dma_chan =3D dma_request_chan(&pdev->dev, "data"); + data->dma_chan =3D devm_dma_request_chan(&pdev->dev, "data"); if (IS_ERR(data->dma_chan)) return PTR_ERR(data->dma_chan); + ret =3D dmaengine_slave_config(data->dma_chan, &config); if (ret < 0) { dev_err(&pdev->dev, "dma configuration failed: %d\n", ret); - dma_release_channel(data->dma_chan); return ret; } =20 /* * Activate the ATA host */ - ret =3D ata_host_activate(host, irq, ata_sff_interrupt, + return ata_host_activate(host, irq, ata_sff_interrupt, pdata->irq_flags, &pxa_ata_sht); - if (ret) - dma_release_channel(data->dma_chan); - - return ret; -} - -static void pxa_ata_remove(struct platform_device *pdev) -{ - struct ata_host *host =3D platform_get_drvdata(pdev); - struct pata_pxa_data *data =3D host->ports[0]->private_data; - - dma_release_channel(data->dma_chan); - - ata_host_detach(host); } =20 static struct platform_driver pxa_ata_driver =3D { .probe =3D pxa_ata_probe, - .remove =3D pxa_ata_remove, + .remove =3D ata_platform_remove_one, .driver =3D { .name =3D DRV_NAME, }, --=20 2.55.0