From nobody Sat Jul 25 01:34:42 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 211BB3C2BB9 for ; Tue, 21 Jul 2026 02:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600449; cv=none; b=XpHg93YXRR/huEosL9nNrG18vZ1S1zEhtxI/KanUgwVQ8kPSyt8cF3WaWaH1tbXgKjGQE3Dx1I0+OlajF5SoFv3yD0Vqac8QrJk9aZQKEd9JUSlfNRJg0kMkRYLAGJaHFIMUg52N/M1wyx9ZC3QqCsUf8MLCc1T6O768hcQ1TMc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600449; c=relaxed/simple; bh=WdDHQBHuwkLWrlKd7BdIFCJ9Zvz/3V41vXnTS77goz0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fxjfKUs8+KfecTlUGF+TLpqGmDe5QusyjsrDFPVon9wUtm+8BIIj7ZRYBvZDrxrUbfsrChLdSMbArMcz1GDLvi5O7aBk8x8kP3W6wMy5rJdrctUtp9+eSFkkbuvKFQ8nekiRhXlNSXhVyHLA8hVz5l6vXGcfaIFgX1l+VpbGTYA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GiqYmcQ7; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=bMqsIy0I; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GiqYmcQ7"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="bMqsIy0I" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KNCobd4083217 for ; Tue, 21 Jul 2026 02:20:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= XRo02vRtcTIm7JokNSrJVFoyheWv3tJmPNHxvoGvNbE=; b=GiqYmcQ7Ngxq96h1 Jk4VZJnv0UqWGF+6NeywAd/gp/bFfUpRUsdYYpp4IruoqHdBVpSP/VZsY1xOOfYN DsWpBwE89KwWN/WJowNOs6GUgFdlH0a9rIMEqZ72CYISoMNbBWhgGHj6j47lbIuX JcOq50lkxRmtNuj7Th58yXD7hFz6yve77lelu7zrGyImnrRj1zVqriPnCqstYGin iVwzJhrLkMMBVZ2T70alztaJV1kO411t4S3DV2TcdSYRKWyKNE5ef/Z9sqiwJlIj ykNx4TIFkYRIVVJgKgCNz6A5KBveMbdfLyjpr8nNCFelQyfgXOfdQdQZuntTnYeR 3F0ESA== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhgrec30b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 02:20:46 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-caf5fa127d4so11601468a12.0 for ; Mon, 20 Jul 2026 19:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784600446; x=1785205246; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XRo02vRtcTIm7JokNSrJVFoyheWv3tJmPNHxvoGvNbE=; b=bMqsIy0I7/kizkIPYKVEm8QHZrlZVjdhB3YkRx59dWiZDxNWJ51yX5AlESSQelrxaf PaNyqHvtVzfIE9+//t5ztmJ/CavY9qVTR9HwKtOyOYE5RXI1KeLSbM0tDwS9l/2eZikZ vNiqezB44/HiXuR5M5pcfdohhGt2K5u3msafqkl4N1TFgYItrRsliEwwj/cyu1qA6Lm2 1x+U0FUDB7N8qslDKiZl/J3oOloHnjso4nYK2uVD6lwdzHapYPCyymfZpVI2WlhkD0gs p8Xx0Wpbc7QDeHg0iQkkaas78TzbznRN4WT+YjN654z8OBFtO8trF60yIeM+JjYXxu6o 6MUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600446; x=1785205246; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XRo02vRtcTIm7JokNSrJVFoyheWv3tJmPNHxvoGvNbE=; b=aTCV+TqrjdnevkBKZplY0fUKe4c7LyI27WnB3wdXF3GTpYX+0WmBYEOF8X/yuMIwyn 5D6VtdeTEx19+8T7w69GG7iEvjC5SIk91iuuGnXGVarov7jxah+FpM3fl94tTRg+FHjl DxEc8SU5Zx4CfnrRhoUo8IsPZslBUK61oK1XzTMwvGStom3tofqyCqM6pp9ibntS/H8p eebfpi+QGNup9LOafCjNW0EDDcn6w2LN9UUZUE2tICy6DG7Qp7yWee1snxUQhbLG6s2X mLJLCIc6c6V6of+4dQTL1V3K3YRKMm12zpTPdmr6/6UuvKyVLopNi04zkN4bH/dXzGss FWuw== X-Forwarded-Encrypted: i=1; AHgh+RqNU+kcfxxBrui5rp2a/0JpmmVbSJvUfR1Zm2GPMLLf4oheTVfTztYFmv7g+X00Q5bqy+0PdjyrurgVK54=@vger.kernel.org X-Gm-Message-State: AOJu0YzpjqmWkkwqUpqx7cVA4boAN/ptUIX0iNm2HVRNGpTFGKb6L2+1 FZjlzJmmz9z2XrG8NKYX25LUs4AgV4svXcBHNEsUBKl0K4N1G2Ejju9B7zrA2FgRCyI0YocXuhs HOXvuqu5mR6v0BSomFCq6aj3+tFzXuMK+5RYYfM5xToUWPECQHzX9uF6bqTW+oLciFLU= X-Gm-Gg: AfdE7cmgGZ1ZIWtYmVwaQ7Bb7ef210WAOVk+oY43HLmb6vEa5hIRq3vUnLmsW9RMrT/ 7ohxgXlUPStTWZNCHtY8PIuCklx7dulaqDFFIXna4h+iyBjTql+/uTQi7ZmIVlbR7u55wBri9WV K4cNdi793fnRRgV+Tn3XoUKU3bIXuXkaPkTptPwN7ARlEOxnuPqf8pN0Cv7Nh+GREfWFi31zMTJ ngy5wb6nussNbzS90XoaB9n65/tMxW7HbDJz91V9LhKidcroO6h8BYeJo3NNrK4Rt4LlsjwIbYJ nWrha9kfERHM3LgedWXWrFMgKJ/E8GbnzrKwoQggGEnJjgPTnYaw4mxDFkqyCtORKvgVwOv0Tk9 mACnGbCs6RwK7VrEnJ5Faqm3BBscdxoYj3g== X-Received: by 2002:a05:6a21:a382:b0:3c3:89ce:b5bc with SMTP id adf61e73a8af0-3c3ad5f063bmr18226121637.15.1784600445950; Mon, 20 Jul 2026 19:20:45 -0700 (PDT) X-Received: by 2002:a05:6a21:a382:b0:3c3:89ce:b5bc with SMTP id adf61e73a8af0-3c3ad5f063bmr18226085637.15.1784600445453; Mon, 20 Jul 2026 19:20:45 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1de301sm41001457eec.24.2026.07.20.19.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:20:44 -0700 (PDT) From: Vishnu Reddy Date: Tue, 21 Jul 2026 07:50:34 +0530 Subject: [PATCH v4 1/7] media: qcom: iris: Centralize internal buffer table selection Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-iris-code-improvement-v4-1-4395bd8acfbb@oss.qualcomm.com> References: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> In-Reply-To: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784600434; l=8143; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=iZ/+ncvk74wDUkoCuXp/2kLnY5XWoLUzy0kpESV6G+c=; b=laF+pI3Nipf/g4iQ0DNSazcXVlt4MWqECvgCSp/dCafAfzoeag5XLy0YniDqWVjDzOe0MJWHH yOBQvljVkKhBhicDTe1KcRPxZyUvKATrE06SkS+H2HA0+G3djyQ2wMR X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfXwB5qRytNNts0 +0ZfndLpHqcz7vtAVI9t9dWGa4GbTU6+0KZ+TqE/8DlLvawtCk9/yAcUbgKcJ7gnIS6wnSqXbTJ AIpV+nyI5hzkeglFiiFqVe/3FxNXlSc= X-Proofpoint-GUID: DPa6_N_gTXXfdttGb6jL61lnxQCnjXiW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX476aWvoRsGXl XF0MeVD1+s5hfpnEhv/HCCAO+2BpjAGAU+//6hyw6nMQ9rSAkvx1MsN3kAAuH3cq8nHOzLeBQoL 7+phUBwax7FPHVQwxYafods2WB25RnePwNZcwXCn6Ncd8zgHLubNkU0uAVWazxCBda1NU0+sBaN WRZiCJ0l1tIbWnkApZqJi+ECI+0zMm/uHNZ+yJC1K4DkG+/n0/RSuApAiVIpXarISKeIFXKAr9u YL1Q2C0iGbvmTJTFb/t7CYgDGi2EsdE2DoTOnyqYcia4bALyUOuYqy4plUKkUK+SkWcnWnZxuOk Rm8TG9Np1DnxO9wN2gVER8szoUtQbUCR9/NSAmAqoCdQAMgFozXoLGOeR5D5PDIyLGq04QkUyof 5lM14IQGv0y0zItC8IinDgaQe/MEDAxSdg1f7VOXsRHRvoks2f1FZ9Fj2xOJqEhidTogRsTeNis sJp2Vp6VdIB4Zo2JhdA== X-Proofpoint-ORIG-GUID: DPa6_N_gTXXfdttGb6jL61lnxQCnjXiW X-Authority-Analysis: v=2.4 cv=foLsol4f c=1 sm=1 tr=0 ts=6a5ed77f cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=22hBRqbxvLe5Obw_dBcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 priorityscore=1501 spamscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 malwarescore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210020 From: Dikshita Agarwal Internal buffer table dispatch is duplicated across multiple Iris code paths, which is error=E2=80=91prone and makes future changes harder to reas= on about. Consolidate the buffer dispatch logic into a single helper so that table selection is defined in exactly one place and keep call sites minimal. No functional change intended. Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy Reviewed-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_buffer.c | 107 ++++++---------------= ---- 1 file changed, 26 insertions(+), 81 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media= /platform/qcom/iris/iris_buffer.c index 246ad0abbac3..bd922a12045c 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -492,39 +492,41 @@ static void iris_fill_internal_buf_info(struct iris_i= nst *inst, buffers->min_count =3D iris_vpu_buf_count(inst, buffer_type); } =20 -void iris_get_internal_buffers(struct iris_inst *inst, u32 plane) +static void iris_get_int_buf_tbl(struct iris_inst *inst, u32 plane, + const u32 **internal_buf_type, u32 *internal_buffer_count) { const struct iris_firmware_data *firmware_data =3D inst->core->iris_firmw= are_data; - const u32 *internal_buf_type; - u32 internal_buffer_count, i; =20 if (inst->domain =3D=3D DECODER) { if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_ip_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; + *internal_buffer_count =3D firmware_data->dec_ip_int_buf_tbl_size; } else { - internal_buf_type =3D firmware_data->dec_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_op_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D firmware_data->dec_op_int_buf_tbl; + *internal_buffer_count =3D firmware_data->dec_op_int_buf_tbl_size; } } else { if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_ip_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; + *internal_buffer_count =3D firmware_data->enc_ip_int_buf_tbl_size; } else { - internal_buf_type =3D firmware_data->enc_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_op_int_buf_tbl_size; - for (i =3D 0; i < internal_buffer_count; i++) - iris_fill_internal_buf_info(inst, internal_buf_type[i]); + *internal_buf_type =3D firmware_data->enc_op_int_buf_tbl; + *internal_buffer_count =3D firmware_data->enc_op_int_buf_tbl_size; } } } =20 +void iris_get_internal_buffers(struct iris_inst *inst, u32 plane) +{ + const u32 *internal_buf_type; + u32 internal_buffer_count, i; + + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); + + for (i =3D 0; i < internal_buffer_count; i++) + iris_fill_internal_buf_info(inst, internal_buf_type[i]); +} + static int iris_create_internal_buffer(struct iris_inst *inst, enum iris_buffer_type buffer_type, u32 index) { @@ -559,29 +561,12 @@ static int iris_create_internal_buffer(struct iris_in= st *inst, =20 int iris_create_internal_buffers(struct iris_inst *inst, u32 plane) { - const struct iris_firmware_data *firmware_data =3D inst->core->iris_firmw= are_data; u32 internal_buffer_count, i, j; struct iris_buffers *buffers; const u32 *internal_buf_type; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->dec_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->enc_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); =20 for (i =3D 0; i < internal_buffer_count; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -635,30 +620,13 @@ int iris_queue_internal_deferred_buffers(struct iris_= inst *inst, enum iris_buffe =20 int iris_queue_internal_buffers(struct iris_inst *inst, u32 plane) { - const struct iris_firmware_data *firmware_data =3D inst->core->iris_firmw= are_data; struct iris_buffer *buffer, *next; struct iris_buffers *buffers; const u32 *internal_buf_type; u32 internal_buffer_count, i; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->dec_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->enc_op_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &internal_buffer_co= unt); =20 for (i =3D 0; i < internal_buffer_count; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -694,30 +662,13 @@ int iris_destroy_internal_buffer(struct iris_inst *in= st, struct iris_buffer *buf =20 static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane= , bool force) { - const struct iris_firmware_data *firmware_data =3D inst->core->iris_firmw= are_data; struct iris_buffer *buf, *next; struct iris_buffers *buffers; const u32 *internal_buf_type; u32 i, len; int ret; =20 - if (inst->domain =3D=3D DECODER) { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; - len =3D firmware_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->dec_op_int_buf_tbl; - len =3D firmware_data->dec_op_int_buf_tbl_size; - } - } else { - if (V4L2_TYPE_IS_OUTPUT(plane)) { - internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; - len =3D firmware_data->enc_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->enc_op_int_buf_tbl; - len =3D firmware_data->enc_op_int_buf_tbl_size; - } - } + iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &len); =20 for (i =3D 0; i < len; i++) { buffers =3D &inst->buffers[internal_buf_type[i]]; @@ -788,18 +739,12 @@ static int iris_release_internal_buffers(struct iris_= inst *inst, =20 static int iris_release_input_internal_buffers(struct iris_inst *inst) { - const struct iris_firmware_data *firmware_data =3D inst->core->iris_firmw= are_data; const u32 *internal_buf_type; u32 internal_buffer_count, i; int ret; =20 - if (inst->domain =3D=3D DECODER) { - internal_buf_type =3D firmware_data->dec_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->dec_ip_int_buf_tbl_size; - } else { - internal_buf_type =3D firmware_data->enc_ip_int_buf_tbl; - internal_buffer_count =3D firmware_data->enc_ip_int_buf_tbl_size; - } + iris_get_int_buf_tbl(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE, + &internal_buf_type, &internal_buffer_count); =20 for (i =3D 0; i < internal_buffer_count; i++) { ret =3D iris_release_internal_buffers(inst, internal_buf_type[i]); --=20 2.34.1 From nobody Sat Jul 25 01:34:42 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D76E36895D for ; Tue, 21 Jul 2026 02:20:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600454; cv=none; b=a/QSrtRUt9UshgBzjgf2d3fvuy/PlmuQSJz2fCMX4n8VjzK2gPkj6O+/YHx8vLOB3Fz/q+Cnpv+kQzzVUMOSF0Yi/vOj0bWHyC6ORBRfJRGidYmM1F6egqnwYhP4ZzwQgYt6Un4Y1P9P8BK7X9or2ooibSt6qgaJeRB+ayQbSTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600454; c=relaxed/simple; bh=bVPxoi85jbZFO9af2Hg2HjePj0L5XNSg5j6catQYaJw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tGqFW9RPYykxaDAHajA4kxKa0P9CH1IzDglz2Me8NBPOk0Qy7sDcJ+PB6K4WbHFtuiZ4mBqW9gEk0UQ2pvePyUbGyWSjLk3jPUJEWrFKdnq5eMG+FL70rUacoKu7ms/tx8eOE+F0KYgNenOFDwIUkPkoKKz8COdqfsPlA2UIFCg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UVYP/Soi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JVR/r5Q5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UVYP/Soi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JVR/r5Q5" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KNCS5F4107054 for ; Tue, 21 Jul 2026 02:20:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=UVYP/Soi5A18CJYF y0YOOIM5zVWptpkmiEtjoeiT8rWrqEfAXaP71wFjAU+mJfK3K58nV4jUpxTQMqsh YwmDC5PlodIvdYrg+FW8YHiq7y3VDxPziXotDmRDsBUZhaOIKYnIPufkF7WWqxsg tZCkTh+9ojPvH7xOeHyt53CyKCMW3QbUbNEnekooqSOMS3hUzLssWYpMqIrR7FpW YDsLD7emYg1EvNLLG9ehCNrGAlZF2CzHGuz6/6ZCyTooFmhShvsYhpp+kXqPR15/ uDWcj5PhE5GSW+1nli9YJsOf+xIMDr0HyHNFNeUPu/rMAHEH9Ux0Kzja/l8RthHN fDR9Xw== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhvqn8kg3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 02:20:52 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cb711c88f2eso1203430a12.2 for ; Mon, 20 Jul 2026 19:20:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784600452; x=1785205252; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=JVR/r5Q5RQUqY5kyqS1phcx/5Ls75Y8duF93i/6sjYT1DXHEa+pPmHPWiRaZhyWMHm uJO2eFKW8/SZsWz7/EyDGPusqrCGlHeD0lTwlA3y9PVMBcPJ5BITZUTeD7DpoJ/ciI9L vLaM5vnAEdOwihZZ2SuoeWHW3OCCCbpQmmu3Zgy4AXQOQ/qLifeN+dixrpOWQ8/76GAc OAq2+edgLCrYertkJQQE5CVBpaMHH26WRxLwF8QZXie+qYXYZNgu3z+xR3Fu2GlY523p hD54zdaax7pVf2yXFmB3BPOZyJ/YaIvO3/pH8Xi9wNfM/hne+6Tza9741GHQHyX28ca3 8JTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600452; x=1785205252; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0bP38xOel7Wb7+m5gMySSFSDl94pHOR46F+B0I+Gh0Y=; b=R4w71PDJUefUAWB5mwBO3ki8tx0w6CREfdqyJsQOO1dEvEiqho+f+LBphm7iGWn02e /o4lB29pzZ1/S5LuJT86zi0ePFfC+jHv0GBx0TdiR1fqemzZfZEtOi9c48fj0XaCKs21 zOCDpSDO89zIPIQkVnGSHXGxUdFzzjeuDg2I5W+kldU3ngUbOncwx+dohUFkRlX6pU8o samNXY6SR+hcLffNPVKj8kO/EhCMjhwMx6+gWqQRGUf1NqWXr4lRetiK62rr90G6bwFO ZEQEVbrSL3y3/w50GYeIdmvkZ+V/bXeeqV78CyTpxkdRgnw0SfmfG2JwzuufWhtPa6+i ynlA== X-Forwarded-Encrypted: i=1; AHgh+RqG7WXvM3EL0s1XQHbNt/MsRNu4GJDux1ZB/EO+VcVb902IJqONRZIDODcmZqn9u5mP337EhltiQStgRKw=@vger.kernel.org X-Gm-Message-State: AOJu0YyY4BIjV6RTAq0j2EPM3xux/uy4CQiz/8A+xR0jDs1EqrPp3GyL rnixRObhbUKWsuLCX6ezIDVpSpS/EUt99eLThaa/2L9Ik9a+Pac3uww0Fh0/Ksr+MOR9fb6XwSq il+YVkIb5imZmcSSkiGgO6iF1j6S9Dw19rSKSlEozL6V93mRbkPHXI1VBPl2GIojsx1U= X-Gm-Gg: AfdE7cm2HVGnoSguk0lNQmCBuoV4d67h4GK8RDwXrskfg0GV5BVFaz+zMg5D1kFTEab m3jq0FoAodBgJFplAmC2gDMMJBO7jCvgC9Quh8vgBTM3kOfd+JeLMEiQLZR3O5IJf8kNzE30KBH MkSrVZEMi9mwhY5uO00W0jkwkKsFSR2EjOBmQH45reGg8aOwP8WOYGF50pCBuY1aBGpbHAeyPMl ahHpCtKrUlsrM3B/NF0M4BosUC2CfswUa2+zS2HlVOBGygnXYmRHWYtbJlEjiO/MSir01z9WdrD mjDl8IYpNkCf4Z2/lJpTyyNuVPo4Se3iqVo80VNxbwJuJmh4zvMIPosl3VfXcwJ09gvj75cNiNS 0hOpR5qMqTjv8ml4LUbVAHbtRZaO3+P/cPg== X-Received: by 2002:a05:6a20:da14:b0:3bb:2883:a723 with SMTP id adf61e73a8af0-3c3ad973dc7mr18538268637.35.1784600451665; Mon, 20 Jul 2026 19:20:51 -0700 (PDT) X-Received: by 2002:a05:6a20:da14:b0:3bb:2883:a723 with SMTP id adf61e73a8af0-3c3ad973dc7mr18538236637.35.1784600451208; Mon, 20 Jul 2026 19:20:51 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1de301sm41001457eec.24.2026.07.20.19.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:20:50 -0700 (PDT) From: Vishnu Reddy Date: Tue, 21 Jul 2026 07:50:35 +0530 Subject: [PATCH v4 2/7] media: qcom: iris: fix state-change debug log printing stale value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-iris-code-improvement-v4-2-4395bd8acfbb@oss.qualcomm.com> References: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> In-Reply-To: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784600434; l=1345; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=Uq29RriGWpbhBmOAxORGoqBD0WkHutgpBJXYyBKyE+o=; b=XTLDYCz/Ni0F951fPaZ23QYLoqV1QXGrdTx7wwBwLGxBNSb2Y+LYzJlzVrKFarQ0ylG0gxr6T SPUSSWFZLPQCrlT6KOxd8n9SSrfKriYnUkvpQdv9RhL0rKN1CJ7YOrO X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX6sXxd0PJAtg5 L8v6CHiY6kLeItNm8+8bvzPhdfnK3wp2O5W5EyNy5Fptli6cUwkfiVdt9kpZgxUvTxPNEiSbnAD VsfeWY4wCfsm7WZCfAXpufCXD19dtz6Vd/g6IXt9k7xw31hgarRcfygS6IPFW2UXiokVm31I/Re ceOH5y4Cr0aT3PvEoRq+TqWU/NRpzE+U1C/UKAAujlYjCfzBd8xfMuWqgbuW0J5tLTRURgHpMc3 wxAv9J4IO+1KnRnRR9kfGkOwjgifuSUXENirzACnrYVMB8SZEyWyIA089PhcMT4TmMiJNxV59v4 l/6dsGsMRM1tWjos2SZU7jUR8VPtfy+voBu/ko1fexVNbuDmmAUwnDr+adonB3JXXgKEy1ulnK5 pJQrAse6NRaFkGvX6nIRFQ7g4J5BqNDFuVHOW9gKBY7Hn3hWpC/0gTmvQStWm44JxayQgv0nOoQ g0JobcJ1aNB1SJ6D1hw== X-Proofpoint-ORIG-GUID: N3m-O3fO3ocSpAEGL0N79KW_gu0TeCOR X-Proofpoint-GUID: N3m-O3fO3ocSpAEGL0N79KW_gu0TeCOR X-Authority-Analysis: v=2.4 cv=M5F97Sws c=1 sm=1 tr=0 ts=6a5ed784 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=iF4bBz5rOIv4ZkufqEYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX0oPQqRCycN+9 dpZ7/Jk38IFqOl9WVXTOcrMarVrkVdJEED54z1VY8v37a+O6Xl0AF/FCQy531yZ7qpgnG91FDf2 38wrkXj+8WdlQkWf9YzknCAy1wwpNdo= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210020 From: Dikshita Agarwal The state=E2=80=91change debug log in iris_inst_change_state() always print= s the same value for the old and new state, rendering it useless for debugging. This happens because the state is updated before the log is emitted. Log the transition before updating the state so the previous value is preserved, consistent with the existing sub=E2=80=91state handling. Fixes: 11712ce70f8e ("media: iris: implement vb2 streaming ops") Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy Reviewed-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/= platform/qcom/iris/iris_state.c index d14472414750..e991f34916ec 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -60,9 +60,9 @@ int iris_inst_change_state(struct iris_inst *inst, return -EINVAL; =20 change_state: - inst->state =3D request_state; dev_dbg(inst->core->dev, "state changed from %x to %x\n", inst->state, request_state); + inst->state =3D request_state; =20 return 0; } --=20 2.34.1 From nobody Sat Jul 25 01:34:42 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 389DD36895D for ; Tue, 21 Jul 2026 02:20:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600459; cv=none; b=qAMp7lLjl4Mvg3YrGNkzS+sWpw5kPOiV4LiAoMa8l2KKlntKEkewU2Glk65/uL9LT0DauX7X+Gb8BfsVvXsf315xteHIPtfvmdWsBGHXxwhqjbI0Y6GnJBr0xs/C/VrZjcXjX54qyqE9fXJ2bJRkvMZ+WPR2gxIu55o0mOYlmFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600459; c=relaxed/simple; bh=XrExrogGyNY8zefzhUS+pWbzmqCVYgThgf2zASOamL8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QgPgOGFosI0qphht62JIHQHlJ84xUdFiS0hOq+unky6/hXMscYcck7pHQx2rMyNSo/hVVrTUAr8IMLI2jcx3XtKQ9FxWQxvXSSkdRqdxBoZHEne5QBwMA30ib3ebbgh9HRJef3WSZyZ9A5r9LXp6sc3zTL0irpzXojhpMbwgdrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=iyVCAaFW; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UiygL9kz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="iyVCAaFW"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UiygL9kz" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KNCZsi3588316 for ; Tue, 21 Jul 2026 02:20:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=iyVCAaFWYdZ7TVPm HVk1jhPHRX4qIaysp57+ZPjKVBTt86SgHWrC/tr5knUQa3C0IFvuvQUmA72fphi+ Uri9/cdGzel1p8C5Po+qUkHva+WS7TNtkhjmvthdmPeknZIr3MenjXHQ2wJntolu Pexwr4lUipnIQyBJUMdgpmD8pXkCsujVY2n3/LyCxOAQLK3OJEc4TnY3OVA3C7L+ Yb71MvLRltbZSIGEuGc5wz6DOR0ACbCd+Itfjsmn30eCHdPFTGE9XE2fUT95KiNW kw7/s/70RRGqLPJoZTgzX7U0K20VwoS4W95BhI+9voalAOCjHPcbEXhBX8B4Q+6K aqnf6Q== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhgs53ykq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 02:20:57 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c892143db7fso6438644a12.1 for ; Mon, 20 Jul 2026 19:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784600457; x=1785205257; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=UiygL9kzgXHExAjIY2fEOOwZ7dPGKPjVc7+r/GECEZpPq11bgOQ7RkyZa5Czrmy5Fi 4Z/4OS5U7QEj/ZcNgpLHi7hqkLSVwODx+2OR/lNbgxU32pGlgHMLU7cumj4aVWy2OqqM zQYPG+wZbiU+w/JUV2acoEX4SxAQvzqsUfheLkbazFl1fn01XrD6ZOe/Rqj10B1/WaN9 1FjumCJSiQ9O76r5huLSChey4mSvPRR2u1zA14PENMYAsFItn4VPtydQwkCeuHhC6Xlq MrSZvX7oRVCkNRQ6E2aRHbrRM5bg/8nXmFO3MCwgjUNaCF89Vb2uTse4kF+qsYDxTxTz Io8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600457; x=1785205257; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=EdKAn8ifT4fLcJXnkTbDem6y66hxcJsOU6t0kTzLNac=; b=ZcDjsjrcvgsQJ9vMsgmMKx0ZKAiiAs9Ivr95fUrEsxwb5fp7OsSSXrWazDOT3vH78D /6J0LYmPiw+L2JUkJnQhYu16TYC+c/vy8E6TfVT7QR15hjMk5SqGiOSOg/dJOpE2cxK8 Wv8zyIJ5NF4ofmsGiJj4rcyL0O34TPkNgD+1sm+ZSQANyVkqsKy3AxCE1yGjeDz5vTwK tD8YbRrgaxdEntaLUodZhr6DrvR5nc0+krUpRl7XL6e99t+sAKSvyLw+y/lmoRBwyL52 knLFHAHu98F3JNmpio+2h+NlmLnslW8bFAiORMkXlHKWyCi7Tg9tKQ12MMUVTWoBJK/t PN9w== X-Forwarded-Encrypted: i=1; AHgh+RoDBVSYkMsZreTJ+JTshezSKxNGZhPLptPwVmdqeBuNIfZXV5LK56PQCMgbIG3tY7hVv+A1xdUCg2c9ZZg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5eOqty2TS+aDIMIJO5uYI4laYHm8OvSCDJJ6vmPCObZV/ovZ9 Z1ttv+6DyYXtt+IlRU4vIjAe7iHSFybsNcfTrK0rSMkbEbizz61zqHcAauQxYorRsstwVd2KudU j1UsM9fkwyWpzWa/GjlAQHz7rQKaUi9LkkERUXJgOEx+lz3givqJQNqnK8pluYAvVRcwrWVqvRl 0= X-Gm-Gg: AfdE7ck5M3k6e/xT+X2JQnSdjygKiQt7OJyxaT7/JmdIGRMbW8Fgv+y4GMrnucl0fX8 KnpFKDAY9JNpSRmXObmDYivuCcUestPky117k7PGYvnyTThOusHLy79g8kchrF6bZd5VEWMSyST Xdrp5+k/Mos7QwEYVMywZN1QcSrPXOK8cdPvlUgUuqSUNjHB+8Lx5JoNv8+/qEog1g/b1hk9SYw Le28BTmDgrBKAnJ1oqj0KIuVqfRYNWoBd4hbNtc6ds7MWv6DGGLRf45ANSfINSrZSLLsHRcEuQj p07F90qubE8c1ekFjfXaqc8+dlv9BtZau4zsZXR0w1z9OD7m5V645pc/HVObxGuQ59OhEWck4zw Px3JIa5lpNGyTfTPoSVa+VgpG0hwBw44KIQ== X-Received: by 2002:a05:6a21:511:b0:3bf:ab4b:2d34 with SMTP id adf61e73a8af0-3c3ad9dfdf7mr18354269637.53.1784600456836; Mon, 20 Jul 2026 19:20:56 -0700 (PDT) X-Received: by 2002:a05:6a21:511:b0:3bf:ab4b:2d34 with SMTP id adf61e73a8af0-3c3ad9dfdf7mr18354222637.53.1784600456428; Mon, 20 Jul 2026 19:20:56 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1de301sm41001457eec.24.2026.07.20.19.20.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:20:55 -0700 (PDT) From: Vishnu Reddy Date: Tue, 21 Jul 2026 07:50:36 +0530 Subject: [PATCH v4 3/7] media: qcom: iris: Fix bitmask test in iris_allow_cmd() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-iris-code-improvement-v4-3-4395bd8acfbb@oss.qualcomm.com> References: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> In-Reply-To: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784600434; l=1251; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=iUPNcmr9LcDxjiMweUrnUvGUJcwSJce63MellJNuucw=; b=TRScXKpClXiG8jp38leP5YesLIDnBJ2yezJTPZCidndYva2SQvbwWcaFo/W9j9ejxhCybxjYq D/SXwxbbsHdCrbrvl88VnUTMHQVqMA9hUIPth3+E589wDPG4Ef1uBLB X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX7pt2Suwy9syt Aw/11UR0bwp5zmca2ZGGrz6UuZWzioH//2DI65FE1OUlFPqfmI5WJzW+RI1KVaA5JLZLQcvau1u m40dkaYLjq7nqXV+anCNzMG8CSFSCJE= X-Proofpoint-GUID: AIU1WEJCRGosyWwLJE8vmje1vLFZnvvv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX0+18WrLFKmwl +PQJipTUyA7t+hGtHjSZ2NtWqwBO8aL9zbab/aT3z96RxyGmA1MlTDfng+VO/rT2pEQh+IbQPnI /jgc+slGR+0XOh5MF94q531ShZjIOPBayS0k7Hwm0QE3vWCRt8/MBHunK7duuKqbp+1f/g8e8Yz rm/LfiQI2LyNdlD7l2deaFNumK8RUG61B8+Yk/ErIeu5sQ05DfDK5fXBBRaVYph0fHbITg7a780 qb7jHmRCfAUj0jjApoQ5ofH/FgnNB2LN6un8yCkVA7j6MFM0hZO6w1aEG5mQIlYZ4UN2vG/HQaw 6fN0YqXufLAN7mUR5m0lwYcCwrSPX2DB/KREqKsvY9ql05K62Hio7Zsfeuftx3NMY2ocji3y7YY XbWQE0p4kFhzOo+DHh8z2jTzA7cqVqzLh8Vbekaven6g9KXanrgPJr62aVJSabrIYnJzuj32iGn cjpFfN60BykBMO5NOdQ== X-Authority-Analysis: v=2.4 cv=CpiPtH4D c=1 sm=1 tr=0 ts=6a5ed789 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=qiYeaxkneK40FgSAABkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: AIU1WEJCRGosyWwLJE8vmje1vLFZnvvv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210020 From: Dikshita Agarwal iris_allow_cmd() incorrectly checks a sub=E2=80=91state flag using a logical equality comparison. Since sub_state is a bitmask, this allows STOP to pass when IRIS_INST_SUB_DRAIN is set alongside other bits, violating the intended drain semantics. Fix this by using a proper bitmask test. Fixes: d09100763bed ("media: iris: add support for drain sequence") Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy Reviewed-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_state.c b/drivers/media/= platform/qcom/iris/iris_state.c index e991f34916ec..5552725c614e 100644 --- a/drivers/media/platform/qcom/iris/iris_state.c +++ b/drivers/media/platform/qcom/iris/iris_state.c @@ -269,7 +269,7 @@ bool iris_allow_cmd(struct iris_inst *inst, u32 cmd) return true; } else if (cmd =3D=3D V4L2_DEC_CMD_STOP || cmd =3D=3D V4L2_ENC_CMD_STOP) { if (vb2_is_streaming(src_q)) - if (inst->sub_state !=3D IRIS_INST_SUB_DRAIN) + if (!(inst->sub_state & IRIS_INST_SUB_DRAIN)) return true; } =20 --=20 2.34.1 From nobody Sat Jul 25 01:34:42 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 347AA30C15A for ; Tue, 21 Jul 2026 02:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600465; cv=none; b=qYqcqgzmU9zW3Gd5tKOt7aBWArAcLLqeTKQ67r0T0mlcTQNiJ5F5yMHO6CCopn/h68W6nalhoEf3rbQWCm8J78bbWRgmnpECD8CvG8T7xIZ6dSLZlOnZRHsgP3nFTQTi4+6+apAwBObRxQBp6NKDFjJYDurb66Y+KDO+Gbpdu94= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600465; c=relaxed/simple; bh=n4pE/PcvEWZzeTpoSlY6lKxwxe+uSs/55pPo3p5h6bE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=R/m8MCJlO4JfdmfzjSWmPzUju7vPXcPyrY7DtOpydZg9xOuxTryFT9CFihNNCMgNJqyleC3fTQN1psOmWyjU2+tntMT9ZWXARDjnZYOcSeKL8rFQy+LyapqvuOQ6jFMXqEliRsUgm8J7JuFCULefw00IVewfBnSRQ23N+aJY+YI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=C0mCRd5L; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HETeU5Vw; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="C0mCRd5L"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HETeU5Vw" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KNCZ4p3884088 for ; Tue, 21 Jul 2026 02:21:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1dyzeFwy2wmD478Vk6alHIJfSDAHvMfyn/TPlmSNSoA=; b=C0mCRd5Lvcsy75kY g8ipwuENVXrOj9Wff+gTAtG86PdvveZzUhhvkFvZztQDTX/lppkSWA22wnG5U13W fzY59FXA4xkZr87/UHRIwlU/EH2d8F23dAvfy75WXSeSOX7SDYPsPLd+Ni7OHf7Z yC9+q36+DvCsc9oQV+GnABNQpui7o64vl/KTr1Fhna9EI7mXUbPq8WnJWYTwJdqa Bn9gXP8n0ZS43xQiSs22FQTkYgcs68gAqRFTAn8E4yICeYRT+rc/LT9/zgUMcq1z Y9r2U6TdtN18uZQwgdgiDZYHnb3PofZvmviZGmT3tjsKNdHFs4SXvQI4t8xEyHI6 qFsBkg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhqvc9vbe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 02:21:03 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-388b404eaa4so14061340a91.0 for ; Mon, 20 Jul 2026 19:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784600462; x=1785205262; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1dyzeFwy2wmD478Vk6alHIJfSDAHvMfyn/TPlmSNSoA=; b=HETeU5VwZSUwJwtw+GsGW9FgiBYTBKwAobg7DS2YC7ZMnwd89UuOuM0NBzPR+NvuGU BuXNwIv6VL+a7IrxeOLA8nXDZi4g5TOV0cDzYi3Kcbn8Pcq2gjL8OuNE/pHKBsUkESjW Ym/TzFSYzTF03/5AmojI2p7mdPN5eAFaw5QPiX/+z6kctn5KS2fyVM0QvHxLNHfTYqc6 4b8N0QZz2lRlzPXUKfL/2aPbhbLGWQ8IFgE4TXdiZ8kqTleVTeDrOwCp6Vor230yTcat dbHlL3+7dBhVG62US7K9d5HXvdvgUupIrCXcs+aAB3h+8UzVPlubHcwxiVmlKgH3PWzl WeWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600462; x=1785205262; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1dyzeFwy2wmD478Vk6alHIJfSDAHvMfyn/TPlmSNSoA=; b=VSCaSMO+RLFbkOcvoAnQpbKUazfWfp5m0+/to1MZeg3c9/IrJ086NxffAXbn6ox4Ca 6FAxcemWL+PpMOrF61tfaGm6B4T1frKkjdGYzyPmEF+MkdNja7xyRBaHyqgpjb4BF8vW 1W6Xs88CMoaxNajZ9GYdWPrKSZNOGNyhEq5MeammHhCyYBxox9jdgwhgUNaeOdZsP8I6 fEvZdcHrsHiE+sMlnkq4IidBStByWq7SS7LVGvFV96IIH9/masJNQx8TDwbGC28men7a FaPhu5rSv48cmIwbMMPW8sPzCHpGf5J6AMc5/6Aerg0/GnuZmejJw5zMdG+K53MlOMlh pMnA== X-Forwarded-Encrypted: i=1; AHgh+RorehQJ2oXWtivx+HWxJU1KsP2OOuznNTfB/gr50GGehcQWlRiV3Xq09CM0D7Pr0RInBQ6+XtDjHbsfmSg=@vger.kernel.org X-Gm-Message-State: AOJu0YxdmjKKZNvf4AV5QcM1TcIM705nmHqpWCb7GDhK4hVptv2sGp2Q EIksBZroao2rHB9pUo0EMkU7qg83oH11FsXWUVdi5XPjJOf1jhiwh8xDXjIS62ipdKEGi9di50E nwx5+IPTxWv8sJvMbqKyc0KgVt2Sol4XF2BpwaykznURewKoyAAr212v4243Zo2BoeFM= X-Gm-Gg: AfdE7cn0rf8IaqPBn83VREkjZrNe99Io7ja3+Lfdj4EwbGYRDzTrSfSfAysvknziBsq 0sXRHyv3PayuJIr6VycjpCD7ISjbbPavGKmP10Uk6UHPUHkvTaNZvCI4ZzlLAc+5hgBPze5BmZn Kd9t41Y/Q1dxCXWyxe+UcxXkz2g40607J45TOEgWwnZpp2kDeGuQpGgcWDf1sBAMftfVyZEoTn8 bovhE0njwv4AsVxUin3qr+mqnWIGI23VTGguFPcxTC9AYxZeL1CwvcUNuVB+yejVoftwtDCHqWS RUimBxfSKF9KypNC8FMVHxXAKD5TfSx8//fnSq7B9Dbnwr3Tfp43eCmGKOE04hfJvXSpN2n+xL+ 4XbiY9mL15U3FHa79YuxjOUGO+9kEZk7KAw== X-Received: by 2002:a05:6a21:6110:b0:3b4:71a9:cd8f with SMTP id adf61e73a8af0-3c3ad947df1mr19336663637.41.1784600462208; Mon, 20 Jul 2026 19:21:02 -0700 (PDT) X-Received: by 2002:a05:6a21:6110:b0:3b4:71a9:cd8f with SMTP id adf61e73a8af0-3c3ad947df1mr19336624637.41.1784600461732; Mon, 20 Jul 2026 19:21:01 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1de301sm41001457eec.24.2026.07.20.19.20.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:21:01 -0700 (PDT) From: Vishnu Reddy Date: Tue, 21 Jul 2026 07:50:37 +0530 Subject: [PATCH v4 4/7] media: qcom: iris: Remove dead assignment in iris_hfi_gen2_set_tier() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-iris-code-improvement-v4-4-4395bd8acfbb@oss.qualcomm.com> References: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> In-Reply-To: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784600434; l=1375; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=v4TGOIryXJf1jaLweQz1Bljs0ZWldGVTXkq+HRfD3Pc=; b=61Y6QivPlqFo/0AUYQtPBKGHghQ4dCDAQYllnRGuKr/fNysu4E5F6lzkqmBhY/mgktmk/oJvP 0mdHmaq5vzAB+B0HcfBMz9PRgMAhhWiYU0h7uzpw3J6nCwwLdbtNLzc X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX4Cj1Tp1nIz2w a6TbKCG2bfpsLS/wlVyey8A9zhpLYHyuLzbobsDqGVE0G3i/skD2NNcmD4u1zZMIJ9iaBMpE3ec ifrEzMlygm5O2iXkBIszoa5MMBJdDa0= X-Proofpoint-GUID: 4IAldvWJuFWDMboLdlNduBjoNAnF5OT1 X-Authority-Analysis: v=2.4 cv=OMYXGyaB c=1 sm=1 tr=0 ts=6a5ed78f cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=7A-KeLSbcoVXy4yL1OsA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: 4IAldvWJuFWDMboLdlNduBjoNAnF5OT1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX6n8M1fuAe+wO p5Ds5lcCI/L2PIjsQfhmQh3FCPKU6Udvt/6/yInBTZE8rUzcSaMXqt0ZClEVwnSm+mkYkXOm6co NmDwccB1Zow0aSvmGtL/b1r1oWl3ABgAD6LofUZhQ+m42H0lIRAB8bWng79RKNTss+HKwgmFUB3 DRqhRPq+UxLvWohUuXjleHaEKKHku8JBWsD7SUjvWVO2F5wURvVb75FZCZ6IAgWLjahsZEmJioB 2wgcbrQAUxwrtCm4BCwlnmULB0gyKd4aRdO269sBdOSoXdbaqRMn5OZvqhBgdM7AWmPIo2Xry/K WXwiXIohJUPkO157emDJ2hGDNFTyYDcFriqXJZ5Ixzef3MFf6Guf5oJlg0OkQ9qQJ6p+6prUJRr ujKVzy89+9EgBKqMU7iKCGQ/VIQNO6kSRIAmEEOZhbuqUgSZIbWG8s6jfgnEymMZiHZjDYOesVG KpoaokyFDaYlkTgaA1w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 priorityscore=1501 suspectscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 clxscore=1015 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210020 From: Dikshita Agarwal Fold the ternary initialiser directly into the variable declaration, removing the dead store that was immediately overwritten. Reviewed-by: Bryan O'Donoghue Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy Reviewed-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index ca2954f8bd3a..62283bd448dc 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -603,10 +603,9 @@ static int iris_hfi_gen2_set_tier(struct iris_inst *in= st, u32 plane) { u32 port =3D iris_hfi_gen2_get_port(inst, V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLA= NE); struct iris_inst_hfi_gen2 *inst_hfi_gen2 =3D to_iris_inst_hfi_gen2(inst); - u32 tier =3D inst->fw_caps[TIER].value; + u32 tier_cap =3D (inst->codec =3D=3D V4L2_PIX_FMT_AV1) ? TIER_AV1 : TIER; + u32 tier =3D inst->fw_caps[tier_cap].value; =20 - tier =3D (inst->codec =3D=3D V4L2_PIX_FMT_AV1) ? inst->fw_caps[TIER_AV1].= value : - inst->fw_caps[TIER].value; inst_hfi_gen2->src_subcr_params.tier =3D tier; =20 return iris_hfi_gen2_session_set_property(inst, --=20 2.34.1 From nobody Sat Jul 25 01:34:42 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96AE136895D for ; Tue, 21 Jul 2026 02:21:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600470; cv=none; b=i6Tr35NVTSYL97CnzXQWGDpayHEZ8gKn6k5KZWOORtSVbAwoXXebF/Cf3IeP3Tsbye/Bx1BHLPXWK38eKGGaznoQagYFgu7PbyPCvsEJnCBV8Mrr6R+SIbUfdVo0du98aUbUac5mIQXKskk/14TLuuNAPvVYS5ve7mUnDmJF0cg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600470; c=relaxed/simple; bh=ZTYKMsVOnyG8cMZ/TwPFJylCEKFsBz2QGxSy1ViKpAo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TTvbs4pw3b7b1wjre7SU1AjR/Id7CJtxvThqm9wTblKXPWSDynTby3wjsYXW+4ikzITrs69a99soSrD11PyvKWmdlFzqZLIkiBGMM0+m+nEbe8ri7EkNH0M6RMNE1U2W62cKqyY2sVli+1+QKy5rUwaeQeSZeEYKJBbbdW4TW9Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TVKk0ZcA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hRmPcoMD; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TVKk0ZcA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hRmPcoMD" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KNCaJ73588330 for ; Tue, 21 Jul 2026 02:21:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 59w1oo2SNjzeO0tUgvu0vMcI9S3z4tjMujLA8N27Wro=; b=TVKk0ZcAeZ6xY5DP qNRd2ZmwIj0/ZbcPBEK3ygtIiHmucvm0B0pd+f0Ss49LRVdKl6mhXhmo44TER2oy /QmvHoms7/kSRWJL3DXE5z6X112Q5+khLNpj6WaL29gf0rTtI4DqZE2D7niVlZ7n rJE4ZVZ6VQBSHe2QBycCUzQZQVEBwMo/5uD8OHImCKtFXWvW2H+esp4XCA90gWis Mz2lVLRThVki+z4GkxxZhYn4/7ZJ2RQf2FebjDF81XOEwAdGULtLfHkoLmvTC0nw DP4w9qcC1fBjFDIBhE4ajHjt/Ptk//07ytGgv5gGBMPF22P9zWXgMEgO4zswUqMw J7G8cw== Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhgs53ymk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 02:21:08 +0000 (GMT) Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cb5bdd8450dso2150277a12.0 for ; Mon, 20 Jul 2026 19:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784600468; x=1785205268; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=59w1oo2SNjzeO0tUgvu0vMcI9S3z4tjMujLA8N27Wro=; b=hRmPcoMD6orYrfqvVl+ndUH+7PFrccQ2S4WxH6bUubcgyXPRFBWSrUYn9l3+TRxZQY P7u5yQHJjzOGbzbOrVgdnO91mxh2/Ooucp1ycYP3rQWq/uexwCltJhQBdns6yJVeqTHs GWrdnABHhjSTimxeN6cnjAxkfHoxJ0VFSqqjdBnjXHr4HMMzG80BGVWjLB7hfUS6a0ec +GDtipFh7uG+z7XOOThfHtMm1UHSAhrbxusv850BdkzpvFcP40iRJHjh5roxbDBmzlhs 0D5hxCupXH+Fb0fteZ0iy/RxVXWjMVAw0y/olBFCIKx6ibbKhcaL3LYBaLKiqQlG8WFh zp/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600468; x=1785205268; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=59w1oo2SNjzeO0tUgvu0vMcI9S3z4tjMujLA8N27Wro=; b=SJcRVKjYVdcKptv4B9txER3iP50FA7lX32+m6EnLEQco42jaJUnPn6WwSKeU8Zef7e kJ5rw1qza8icWaDdnucfi6hS6Zo3w/i510hkabJHpTIZbzOdx8mCylTAjJO5WVwVN+b5 S92MKwhPQwbofdB1KP/hzhu0JeVyZ63GVgwNfoVa97Q/pxBHnA9H4h9PXnFFguvGjoWc K4wLD/VVMNSYjaCfMWpJEM+qz3W2dncZC4Se36oRc9VaA1KZa+huwOVIxTb18gMWJZ5q JSU0ItRDJdi1Dfy8k1hgge32FB1C2+5r6ooDo0feC7637QI0p1KYLsh6Oqxjl5BxYtmE f/2Q== X-Forwarded-Encrypted: i=1; AHgh+Ro/xSe8ercuaZO0SwXOg0keN3FvzMwinRMvpnX4VTW+tL/yq8M+/9RqRjYypqH+OwxL4LRL9Hk+4bL2+so=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9nXsALeAjH+I2WsfOGryet6AEm7qHs1FPCQ/ilHm330kWB54f z5ooACnHzZBQiPUXyWVRDNJUbzAVP6rQzDFV16Va568wYlbIJ09IvwPOOpZq8Lc3NpSfG1xBjzV wUKl0X493oBZKalANXtOE0jEKgA/7lEtimU37TCm/jEwY0Y22/73PsXxvX4MpSpcQNLA= X-Gm-Gg: AfdE7ckIqTD8gOis8Ud721TVGXpcXL27U4boWaELG1ERBbLIy6mUKO5gWNgrIsv06wM R3oXdYnfnCpCRKhrX1+bR6KEhq7u3XaziQBbHRlzc276k2FvLVlGkK6StBFv+RQc5x7UlRH39gK OdIgPEy+Ivv6LxuNEUPIXNthwVLp7LlV+x6N0H89EkMWPRpSoVHb8+E6hFATCI5oFJqKZIbPxvq C7vaJA9/ZIqg1ufJVuV/i6qMBdnj3LUJnZK+VZPcVPZS5lZJdRmgQwxycvWyLpjxb4Sdy/ypbP2 PdJHHk1IKeG+aXHewRly+FFUNqfvIS2na/bngL/eMiB8daAR18Rdq587D7Btdswbb86MGB9rV0T KCg032nviInNCr+UWbya2j5IQZa30CIbicQ== X-Received: by 2002:a05:6300:2285:b0:3c3:6c90:65b3 with SMTP id adf61e73a8af0-3c3adb086f8mr17720537637.65.1784600467869; Mon, 20 Jul 2026 19:21:07 -0700 (PDT) X-Received: by 2002:a05:6300:2285:b0:3c3:6c90:65b3 with SMTP id adf61e73a8af0-3c3adb086f8mr17720513637.65.1784600467433; Mon, 20 Jul 2026 19:21:07 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1de301sm41001457eec.24.2026.07.20.19.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:21:06 -0700 (PDT) From: Vishnu Reddy Date: Tue, 21 Jul 2026 07:50:38 +0530 Subject: [PATCH v4 5/7] media: qcom: iris: Remove duplicate HFI_PROP_OPB_ENABLE entry Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-iris-code-improvement-v4-5-4395bd8acfbb@oss.qualcomm.com> References: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> In-Reply-To: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784600434; l=1471; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=dQxss1bSYlylmSMgn6m7rVafNWtGTJzyf+ZiN9iZMjs=; b=zBm2ZqiI40uuAazT7h+YeS0ugHr1yyetXq3rFEpTKQ2DjBVobnsoq1U6GtvmG1XcjJmZidr2J S6+K2NL223yDDsNvymZBJxQsqO4r7C+Pp5hp0QJa0xng7kpLHNyUN4Y X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfXxbJGdGe519np PlwrXauLSUdqMPX3vgO8YcDiXhfkxwsplpTRWE5M/96YxR9QwRbH4cJmeKK0uC23SlZJDT3Z4nP S61G6HDk8X0sDipZSNLDRKtPb9rszSk= X-Proofpoint-GUID: HuNHMwKdbOjd5M7KwE0i5Khu_b1MNdtf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX2IesPIBQ81Gz OTpL9C2zbpDApjRd2krJIyBQRgX+Zkh2Vo+Le6Ew2UDEDG6qGcaKf76zNzsCbwq7a9E4Htlsgfw i3awV0QNgvKQyRJB1vtpGMJEZl0mIekBSe5EcLozvXSdbnlQAN0RZVeNrxE5pklacH5zG6KPLTY xTttMnhMb/C+58i8GQQgf1ejbe8+ASz76kftL2NO3sRqJq/W63+Cf3hYxTwLKkv6zb0Y4qL3sqI cNOntSxVST9AHxIswgT7YMHWY0CJDq/IlKRm+WcqEGFmYL17TLkNW4iFIFBkFADL4E3dB+2cYgO PVcQjYZhgYOn8MNI+qLhASYGcFjx1Do2t29Y1zWiXNNP2EawXIY4LLJKUrTGfNHTgok/4PFVrnz vSoWc5QlRUNUBkGw/XbMH806iuEdRqIrMGILeMvO0Kl4Z+a5pjWxpfd5oHH+Aq4wv+zHPMtOklO lhUinmg+byNSvZ5iYfg== X-Authority-Analysis: v=2.4 cv=CpiPtH4D c=1 sm=1 tr=0 ts=6a5ed794 cx=c_pps a=rz3CxIlbcmazkYymdCej/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=1vCIiHQokKioWWC5pcsA:9 a=QEXdDO2ut3YA:10 a=bFCP_H2QrGi7Okbo017w:22 X-Proofpoint-ORIG-GUID: HuNHMwKdbOjd5M7KwE0i5Khu_b1MNdtf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210020 From: Dikshita Agarwal HFI_PROP_OPB_ENABLE/iris_hfi_gen2_set_opb_enable appears twice in the dispatch table. Since the property lookup stops at the first matching entry, the second instance is never reached. Remove the duplicate entry to eliminate the redundant entry from the dispatch table. Fixes: 2af481a459a4 ("media: iris: Define AV1-specific platform capabilitie= s and properties") Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy Reviewed-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index 62283bd448dc..b3496db55ad5 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -691,7 +691,6 @@ static int iris_hfi_gen2_session_set_config_params(stru= ct iris_inst *inst, u32 p {HFI_PROP_FRAME_RATE, iris_hfi_gen2_set_frame_rate = }, {HFI_PROP_AV1_FILM_GRAIN_PRESENT, iris_hfi_gen2_set_film_grain = }, {HFI_PROP_AV1_SUPER_BLOCK_ENABLED, iris_hfi_gen2_set_super_block = }, - {HFI_PROP_OPB_ENABLE, iris_hfi_gen2_set_opb_enable = }, }; =20 if (inst->domain =3D=3D DECODER) { --=20 2.34.1 From nobody Sat Jul 25 01:34:42 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D396E30C15A for ; Tue, 21 Jul 2026 02:21:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600476; cv=none; b=NnjNYJpianHyP6mbzS26DYv+qDEbZiHDbg8qNKLUFQn2af28+6MjE1EBSEKcPLIK5vA03KaizFeIjTObR24h2URlA78q+6AsXWpn+fYQydd6gQPTlsyghAX2qQOy3i7lbM849SacfpLDCojSks6cN1AO0pkndj2tb6lJibsA380= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600476; c=relaxed/simple; bh=P6TnMsUuMSA78Yjeo8YpqUe73vaQ56ywFSdARkxIgIk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XggJxIwmvl0RvAxqD7wcPRNoNPfGxRzG+kdHUQEQBw2ZOLtw21wLyZvoKpBuwm6rAsrmmyIv7YAS8Hn9P2uu1jUe1Lqp/u/n6CgTNS2WAmchyZ28BwvKe/rV7QoLXnHVSArFdnojZ61C6xYiroMvH29b1YWvAll2PcyzqmDlIjI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=C+i8JMQH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YN1Yknj8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="C+i8JMQH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YN1Yknj8" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KNCTDe3768645 for ; Tue, 21 Jul 2026 02:21:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tEfLpQZc0kvFMdKyhBfCbhreCCYuh8w3Y6+3at+mpRU=; b=C+i8JMQHmD638deU OCVz1Y13dkNHHgv1RszzyMVPKz69UDY/cQ1lYKDyHoDZD+TkSQEB6OtpdC4O5Olg eBB+VolIhRp1nYYE6FKowlGBExpZm6MIsOq7UFjHc9A+JIKr3i7fOhQ78YSmwxws xlDYTISu32MZ2SeBlBELeUNgM7jpQJsREAK+a1UHj6+QksTAmHIil14Lf4xuVt1Z 9kjP5oPvFqhpcWgNOK9C1mCLScp9uBLpALhhjmR3E93V1feTFHKLvgq054v+Mrb6 XVexCLCZlVtTyVyZsUo89CKi0Ig2AIDUE29fHAiupE7k2O/G6Pu6N4kvCBPEY81B zlzBYg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhh5y3utc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 02:21:13 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-848662cd2a1so7928913b3a.2 for ; Mon, 20 Jul 2026 19:21:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784600473; x=1785205273; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tEfLpQZc0kvFMdKyhBfCbhreCCYuh8w3Y6+3at+mpRU=; b=YN1Yknj8XL2mdPbDVNwhhzQ/jyuV0+GbCIP5wbaq9VYSxMhb+UrrO6uu5FL+qsCzCH OvAeJKM6rg+thZYGxN+apKnDoDErEMmQfTZvcbdYM5pezdTuaIgpz2W344uP2ZUMB83r Zcz+a8rS0ieKj1cs//QJkugMaNJdYKj9d0TfnXvoWVZ4/Km/S4i3Cpki2Yk/XXDjRigQ IALCaD64zMg8o0JUMhk9g1ebgkTBKBxOQCfItsio6MM/sYV0+sbGE3Vcse5L/cMgzrgS hH4heLhI535hpd/TMJTiss6YWaR0cy7KJBtYbZQDkB7o+yKWvKiIDrZzJrp2bFkATMo8 OKtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600473; x=1785205273; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tEfLpQZc0kvFMdKyhBfCbhreCCYuh8w3Y6+3at+mpRU=; b=PC5SqwzFDD382z8BA65XpOcVdB6iq3handXtaRm9VGJbDc8x9UP/rBLAVlTT/LoC8P GsalBb6tERq0aE8SLiXvvYP3mAykA1G09gQMw7GAxIuWEerN2H1jQohKJfwupjXl2/gA PLFwioXSLA2t/U1RqrZYqIAFqPf8TtKmXlVpOCe7sdkdvd3OicEPFlw3olHYGco3QstK n+4Mf4OPywblRTZWE7nFp715Al3vzsA5Cl7j1+GovwEXFrNkldW2xBj+TOJVZALB4h5S xKJfSpnSwfypMIf7Ukgf9M+qI5I+7Mwp2JnVrhzxBV7fkfb7I7iNHr+FToCgFCpXlOcV SzfA== X-Forwarded-Encrypted: i=1; AHgh+RpX4WlqbuDWdr2pYJ+tgWsLgjTCH0oV8IUi9kiz+vZPONwlW4aJ+8iUWC4/UqbEOI0mnSHLSVNtYm3oufw=@vger.kernel.org X-Gm-Message-State: AOJu0YxEAiOf5uCk/y2WFzb9Nzb2e3d9rDlUTGxqYGIBdizbLPvKOLJD F1npHyHmlE+kWd5rmBqw7TW9BOUHuC0s6czwE9XxFm43RfG7RfsdDrn9eXXMkSMJFyrHyHZQ+WD pX63FIZXnOKhuMhtnV4qO6toIGNDtCqKx9kaleeQ6UXbOHTyNzVeS967qRe54/o2JCWs= X-Gm-Gg: AfdE7clLtqSrVF+x2PjCZiAQe+pFR74fRUWSXLpKP4WBKMR4jwwRH/SxR3eiMXpcdCT y5PCJCUlbf5YhDzbAxJP6qx3ot8g2MVKX8/fpZGeFmDSKVnVWnmZYfJeR+hU1koCgoKk3V3SYAC 2LTLDhYJtTYgWT4MtKGtNFJ6lu0aVIoMCRe0e31GWQQe/dj8laVYFK8amngDenwgk+8pUIXdH7C KvAVHryjNTQhhUxwMsK9zC4BjhPsucYQJpne+j6Y1SHC0PkOe3XfbNkbVg0S8WOCQ1MhDKpU4/T TB/ouBBWxs89Gv8o/6TSljHHKYTVeroGmGao8SB8fIYUkBKnWkp2X98gdSCwhYMXQcKLD1Wkf6g cp0dtfAEKN0QH429bvoXmjKZY7vwmS9fb8g== X-Received: by 2002:a05:6a21:511:b0:3bf:ab4b:2d34 with SMTP id adf61e73a8af0-3c3ad9dfdf7mr18355294637.53.1784600473227; Mon, 20 Jul 2026 19:21:13 -0700 (PDT) X-Received: by 2002:a05:6a21:511:b0:3bf:ab4b:2d34 with SMTP id adf61e73a8af0-3c3ad9dfdf7mr18355265637.53.1784600472818; Mon, 20 Jul 2026 19:21:12 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1de301sm41001457eec.24.2026.07.20.19.21.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:21:12 -0700 (PDT) From: Vishnu Reddy Date: Tue, 21 Jul 2026 07:50:39 +0530 Subject: [PATCH v4 6/7] media: qcom: iris: Add missing break in iris_hfi_gen2_session_set_codec() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-iris-code-improvement-v4-6-4395bd8acfbb@oss.qualcomm.com> References: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> In-Reply-To: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784600434; l=1008; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=3aYgHVIuLblZw7PKl4QOm3dcWSHYUDt30qNdyekWm2Q=; b=armaMMgtODSn3YSPgNsOuOJMe86tCPOlXNKtCy9JWPiLoUZ+kdvpbfbGGzh//IpMVvyNbFnz0 oWGQQHVkrmtDhj+gBIQG7dgPe2XV42/KGqy/gh8GZCz+IqOEBvHsVsL X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX9YF56LOZTVNp N6T7vvIIo1q1SP0tHN5P5CdP8nACHnOS0Yyache0irEPvs7J/0ah6xazu7Cp/M/GF1oYuGDC58a HKv0S8K8k82a7zzN7b8fPOQTXeGPyH4= X-Proofpoint-GUID: TeBo-9r6o1NHbjojBlaOg8zljFrjqgxw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfXxKEYZmcxZlju vHo7n8tjpbG9WMT7/ijqML0jiXDvBex1ipLNhXYi23liRDs9XHymI/gGaCcIn03WpVh7ifKElrK xqwLPQTNkn+UgfSdFn/fInvfP13FRPA4i56nSjB1SnyMLECm0VZBP+w4o9FW/iM1Wry0A0I43dN wjPAxRaCfOtEwbupCowMQJtf4fVQLmMk3A4hSSCwiQBFExCahdFEirPbbUgLC7PRdXcLoz3unHh 1w41v1gXHIBO5cg+ogF1BeAhq1OeCfRlc01JVZ2FnGPiX9enNSIeC4lvDCJelmTlWaoE5XlbpPW FFVy7Z+PzH7gy/TTJZfgz87FlNv2SzqgKlzta+LIBZrI2a8TEJUNBzurSJERQH/m91mQW3awEcs VxLSXhDIJXKl322Y22YhEE4vmeYApg06Xq5BVsQWQ4OOVqzzwIjzViA/qJze6MQEOQU2UT33Pr6 yEiQzC/dUzz4cbwQ52w== X-Proofpoint-ORIG-GUID: TeBo-9r6o1NHbjojBlaOg8zljFrjqgxw X-Authority-Analysis: v=2.4 cv=f/x4wuyM c=1 sm=1 tr=0 ts=6a5ed79a cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=nqERTrTL3htJ2auDmasA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210020 From: Dikshita Agarwal Without the break the AV1 case falls through, risking unintended behaviour if new cases are added after it. Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy Reviewed-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen2_command.c index b3496db55ad5..388a36ff2b07 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_command.c @@ -764,6 +764,7 @@ static int iris_hfi_gen2_session_set_codec(struct iris_= inst *inst) break; case V4L2_PIX_FMT_AV1: codec =3D HFI_CODEC_DECODE_AV1; + break; } =20 iris_hfi_gen2_packet_session_property(inst, --=20 2.34.1 From nobody Sat Jul 25 01:34:42 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B9883EFD05 for ; Tue, 21 Jul 2026 02:21:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600481; cv=none; b=Kwb2hWmhWpap+pSs6KXqCb080nQvcOMf1MHQYfuE59O13TcMn/UqNiGtHXR4ldNstbuQq+bnzyh6bqj1LTs+OHA/0hSZNK0I4TziNq8+N1801X8Qd5yiMkZnQaJ3Nnx+UdvnIFdUoxYL8TG9iX/VGnqHJmLgLxOQ5yiwzcNWJEw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784600481; c=relaxed/simple; bh=s5Zfbo4qdUGGjFW88zzbmy0I4llofaubC03Ctjj+LGo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Eifo6xP/p54EJUDN4UlM7J+mlN8XnpimpJUfYPfyZrE8mc7BXZRrUT5nxJ/wuzVkY6Js9fHqSwEGcpXze8tZXawOnVSjmjT5ctU2xb8CbCvdKeyAIOM9bIvLmGuck1xMDfHciTBWxb90DPfg1D2FR8gRagoTQKuDJCiPkzA53HA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Bsdtinxd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QebLMhjM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Bsdtinxd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QebLMhjM" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66KNCSHa933226 for ; Tue, 21 Jul 2026 02:21:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= kQHGoKLNl2Tfoue/4AF0aGGxJB+gMtGPQ3VGJW3XtEc=; b=BsdtinxdpLRzxTNJ qRps8AH4tD9Dyl8iiTgkwA9oogXGGthwcZzZx/6LytNIbDi7dOr4EfNbmF2tqZF5 3fmUhjdsMo1RmIbtA6k7gD4cPELVzoCc4pXlQEpFVjibpoIp494Vje1xp+Bimh7I I8MDZFPipNfSn2rDWKHyA+e5DVNIUbjxIHMKY3ftrsY/EgbndrsQIyTAXvmYKp1Y OqPpwkW8xY/IGKZQNFP3OGEk721BMqmDlljBy2q21FBmPr826CltYS6KTO2fyu/A prihCgpVvySWrtbvHqC8/SvwHcWD+lE9zhPAkUte+yH8OcaL29E6Zxjc2Yi9l80X pckuCg== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fhqv5st45-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 02:21:19 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cb835525b10so1594416a12.2 for ; Mon, 20 Jul 2026 19:21:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784600478; x=1785205278; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=kQHGoKLNl2Tfoue/4AF0aGGxJB+gMtGPQ3VGJW3XtEc=; b=QebLMhjMSiM7xkK4xcsBDfpLKgraHglUylXQHz2qx/fEvUOG1CLoC0pXsvf/fgnnny I5fa+DktTF8fabsN6OE6DCrjHuE5y6JWZnsLCUU1Gq5KKRqM9O5DU8o9SbYk77jP2elJ 54H9zKUKSL/VQU13lijX1Sk56xdmjvl/1Jb19vOqbuWLxLPzbScvABesVet1IbcmCWvo QjnonVlLsEZpqqY7KmqdH84TFVv7PjNNuzgWBli66WHzD7cGXqhY1/h9sCPu+KgSMxL9 UBq/kYvT2xl+dIAVdHYdzAr/NZtefIG5CB4+UVutn5k+WwZuYHAnmcKs8RNomw7dFCbY 7HlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784600478; x=1785205278; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=kQHGoKLNl2Tfoue/4AF0aGGxJB+gMtGPQ3VGJW3XtEc=; b=oMGqdFh+dUytYEvU/Ck8CwRJH73DAaGNDTAr/cQtkqilK1d2y+qWLt4rl9TSBBYIgY rNR1Vh0F+Dg/F6DAGx1BjE8xFk5Nt49oUaJWoVY+d1jLHCL7u5WzS6ecHfZYysLg4Qxo d8c8+fSmzS9QUJMrJocBSoUS4J23OoncuM2OgEdwANfWq5WH4+wK1o4ehLOjrw5qd9Lx t7IXrkpwwSYxh75avUoMX8fua/IIVw7D1uqWYovLMgVZ4P5gzj71eRr4TQgWe3UEGBjz C7TCoXRYEtOqicuYTCL4ovAqM8H2mDRk22HpIy09Vb5Z33irstBfYd7f5lMfHwVhma2L LXSg== X-Forwarded-Encrypted: i=1; AHgh+Rp9nnNYoNNYb2LoRJByYP6aIjpA/pj5hv20MGpxIO5TUGYJEv4rKKT2oUc01pgPcGf5uH2hOgsEr0T2gYM=@vger.kernel.org X-Gm-Message-State: AOJu0YzIbOlavxMbZenBZ1MIAkGu0OvUpAP7jBff/7gJTzih4eBM8Bc2 FzomELPmwnqX6iUHsx9GCFajiok3s1nvylU/ZlS8W2muKLWowDRtiXVEAsfjEVs1W5k02GhdD6o sCFfEucuUbf72TF6dKKEsxur5gRLfGK1s9NRrpuSR42bLxBfzRN0Hij1BE9sQxQhXUGE= X-Gm-Gg: AfdE7cmMQwKAZNp+xHuCOej+p3NT9Ck/iC0R7/tDRCfZzYdtzpcBVv06VcIVAZW6XUK ytFMzaBRxSqMIWKJv2AFcPaRdLXStNz29p8dCX3vc40tm2dqDzYLBzLTUXOXmojr/w5480JpaFp f+t00jql2yokZT+JYJCyV9Vbbbf+Uv7Ipo5eEAMeiD9V8Tt7bd6zqu7ZfPVxbaODkgxCF5y8oVe EFSt3MQdUUiBGGmzHb3+P3RrmGN/dMD7BkhBFekGjwWwPGfpEtuVGchlVCuwMPJqtNxw3hNTmNR 0BrsHSq/vlSFvv2TcCDID1ScG6OhUpXkh+OlojLxnld2JKhCxiIUO+9MTdSg4iq5cmz9AeiEEPg 5J43hchhB6uLe+J5/YNoUNuSNac0kB64MSA== X-Received: by 2002:a05:6a21:48f:b0:3c0:f772:8128 with SMTP id adf61e73a8af0-3c3ad9afdb9mr16777515637.54.1784600478560; Mon, 20 Jul 2026 19:21:18 -0700 (PDT) X-Received: by 2002:a05:6a21:48f:b0:3c0:f772:8128 with SMTP id adf61e73a8af0-3c3ad9afdb9mr16777489637.54.1784600478113; Mon, 20 Jul 2026 19:21:18 -0700 (PDT) Received: from hu-bvisredd-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1de301sm41001457eec.24.2026.07.20.19.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 19:21:17 -0700 (PDT) From: Vishnu Reddy Date: Tue, 21 Jul 2026 07:50:40 +0530 Subject: [PATCH v4 7/7] media: qcom: iris: Make iris_destroy_internal_buffer() return void Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-iris-code-improvement-v4-7-4395bd8acfbb@oss.qualcomm.com> References: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> In-Reply-To: <20260721-iris-code-improvement-v4-0-4395bd8acfbb@oss.qualcomm.com> To: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Hans Verkuil , Deepa Guthyappa Madivalara Cc: Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , Konrad Dybcio X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1784600434; l=5062; i=busanna.reddy@oss.qualcomm.com; s=20260216; h=from:subject:message-id; bh=NJCVkXVG4kHkHSdORHSkz4ElWt4c51OBpIRD85ii4Us=; b=Ou4Wi3K0YRzMkPAqq777DeNC8zL567ygQ1sli4VuJ5MS82UPzCFKTDNiXAjOPGEIGqe7LntmM ZvVsveVU6HwBUnt4m2t0Xyjvr9+qgtX2pnaiBYjfQ9b237BGcwZ5z4Y X-Developer-Key: i=busanna.reddy@oss.qualcomm.com; a=ed25519; pk=9vmy9HahBKVAa+GBFj1yHVbz0ey/ucIs1hrlfx+qtok= X-Proofpoint-GUID: irabI8C2mBY82WMVPYsicY6CQsx8kWS6 X-Proofpoint-ORIG-GUID: irabI8C2mBY82WMVPYsicY6CQsx8kWS6 X-Authority-Analysis: v=2.4 cv=e+U2j6p/ c=1 sm=1 tr=0 ts=6a5ed79f cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=CWBAsx5YQZKXPYp8bPkA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX7XxKBV9v8I94 P59MmpNvCprviyZXS1rjsYX4eGZO4UjokMBLb6oOewnr8zpi94o+eY3BxwAImqAC0FF6E0AWgxj mPh1rPpFslzywj1JcKvtmX+6Q+K2EPE= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDAyMCBTYWx0ZWRfX2ODUJuR6i5pc cCQKlTLEUriLGUqZt8DZZbYXZK61uPIgqXydAPeTjECb7xBJBapSUWBZDE1akVoqVb5LYK8zZ9i Qnps2k48XfPcQ9hqC5A43JDAJaoPCdq3Qg9p/cogy0EsxHvIkbuEb7FiaQEQ6CCJeMzBAD2cZlW 5Uxk9ucz+SAIju2oxNENJxEVkuPFOhQTQB5+8STldT0CRPEbcNQSNVIthEol1+YjLU11G0Vl+04 SHi2oZtuuL6ZcR8qDFPF/eI3RTQ0NNdSsLvjHMrKjW+/tjYG5ljvp9XyEFzjWQ7djBQU/9X8jko TSUyD2VIfYjFPtx2dnYiWEPd4NQKj5uHntBf3X48K9j31mjvgjgclJWcBaMMJT9GadIUJYWRJj0 LiZ8XQuzFQWBzKAJMbryKR2Vetvsbm0UyEwaJRKB5EwvYftEqyuYAosjrgsm3mezzlCAlRofgwS zH1rXeF9ExNL7BZyF6Q== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 adultscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210020 From: Dikshita Agarwal iris_destroy_internal_buffer() is guaranteed to succeed and never reports an error. Returning an int is misleading and forces callers to handle a meaningless status value. Convert it to return void to match its behavior and simplify callers. Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Signed-off-by: Dikshita Agarwal Signed-off-by: Vishnu Reddy --- drivers/media/platform/qcom/iris/iris_buffer.c | 16 ++++--------= ---- drivers/media/platform/qcom/iris/iris_buffer.h | 2 +- drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c | 2 +- .../media/platform/qcom/iris/iris_hfi_gen2_response.c | 4 +++- 4 files changed, 9 insertions(+), 15 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media= /platform/qcom/iris/iris_buffer.c index bd922a12045c..eb8de60c1177 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.c +++ b/drivers/media/platform/qcom/iris/iris_buffer.c @@ -648,7 +648,7 @@ int iris_queue_internal_buffers(struct iris_inst *inst,= u32 plane) return 0; } =20 -int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffe= r *buffer) +void iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buff= er *buffer) { struct iris_core *core =3D inst->core; =20 @@ -656,8 +656,6 @@ int iris_destroy_internal_buffer(struct iris_inst *inst= , struct iris_buffer *buf dma_free_attrs(core->dev, buffer->buffer_size, buffer->kvaddr, buffer->device_addr, buffer->dma_attrs); kfree(buffer); - - return 0; } =20 static int iris_destroy_internal_buffers(struct iris_inst *inst, u32 plane= , bool force) @@ -666,7 +664,6 @@ static int iris_destroy_internal_buffers(struct iris_in= st *inst, u32 plane, bool struct iris_buffers *buffers; const u32 *internal_buf_type; u32 i, len; - int ret; =20 iris_get_int_buf_tbl(inst, plane, &internal_buf_type, &len); =20 @@ -681,9 +678,7 @@ static int iris_destroy_internal_buffers(struct iris_in= st *inst, u32 plane, bool if (!force && buf->attr & BUF_ATTR_QUEUED) continue; =20 - ret =3D iris_destroy_internal_buffer(inst, buf); - if (ret) - return ret; + iris_destroy_internal_buffer(inst, buf); } } =20 @@ -693,11 +688,8 @@ static int iris_destroy_internal_buffers(struct iris_i= nst *inst, u32 plane, bool else buffers =3D &inst->buffers[BUF_ARP]; =20 - list_for_each_entry_safe(buf, next, &buffers->list, list) { - ret =3D iris_destroy_internal_buffer(inst, buf); - if (ret) - return ret; - } + list_for_each_entry_safe(buf, next, &buffers->list, list) + iris_destroy_internal_buffer(inst, buf); } =20 return 0; diff --git a/drivers/media/platform/qcom/iris/iris_buffer.h b/drivers/media= /platform/qcom/iris/iris_buffer.h index 75bb76776182..ab8e5d953101 100644 --- a/drivers/media/platform/qcom/iris/iris_buffer.h +++ b/drivers/media/platform/qcom/iris/iris_buffer.h @@ -112,7 +112,7 @@ void iris_get_internal_buffers(struct iris_inst *inst, = u32 plane); int iris_create_internal_buffers(struct iris_inst *inst, u32 plane); int iris_queue_internal_buffers(struct iris_inst *inst, u32 plane); int iris_queue_internal_deferred_buffers(struct iris_inst *inst, enum iris= _buffer_type buffer_type); -int iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buffe= r *buffer); +void iris_destroy_internal_buffer(struct iris_inst *inst, struct iris_buff= er *buffer); int iris_destroy_all_internal_buffers(struct iris_inst *inst, u32 plane); int iris_destroy_dequeued_internal_buffers(struct iris_inst *inst, u32 pla= ne); int iris_alloc_and_queue_persist_bufs(struct iris_inst *inst, enum iris_bu= ffer_type buf_type); diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c b/dri= vers/media/platform/qcom/iris/iris_hfi_gen1_command.c index 7674b47ad6c4..1c02f2eebdf7 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen1_command.c @@ -442,7 +442,7 @@ static int iris_hfi_gen1_session_unset_buffers(struct i= ris_inst *inst, struct ir =20 ret =3D iris_wait_for_session_response(inst, false); if (!ret) - ret =3D iris_destroy_internal_buffer(inst, buf); + iris_destroy_internal_buffer(inst, buf); =20 exit: kfree(pkt); diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c b/dr= ivers/media/platform/qcom/iris/iris_hfi_gen2_response.c index 25162ae71357..8c2644c7f6e8 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_response.c @@ -447,7 +447,9 @@ static int iris_hfi_gen2_handle_release_internal_buffer= (struct iris_inst *inst, =20 buf->attr &=3D ~BUF_ATTR_QUEUED; =20 - return iris_destroy_internal_buffer(inst, buf); + iris_destroy_internal_buffer(inst, buf); + + return 0; } =20 static int iris_hfi_gen2_handle_session_stop(struct iris_inst *inst, --=20 2.34.1