From nobody Sat Jul 25 00:56:57 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B876478E57 for ; Tue, 21 Jul 2026 10:14:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784628895; cv=none; b=B4rQNCc9JR5CO1RAq6NFWhEzC0MZ/gHXavBc0ZGddiflCSAiZdPL7vPQN6xSaTttMxyUEPCuarqBtITU2XoH1yclbS4FQDntpparjkSAQOmcm2Itcb18n3qmTmrHTTPRAwsRkhyysWTtE7gzvIIlIB9P0eM/DAEPyeVlrJYOBjI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784628895; c=relaxed/simple; bh=aLBrQpVc3NpMulD1PFp4q1j8NiDItnsuDggSGFg1GKo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uVutml6Pt4HlFnFxG3FgbnvkCJTMikJCTM+Ijt+LFiZswnYaQ/RGxTpgUWWhReXnAO9GOVYvA5C60hNCukKpY1X4/ha5kyQK3CSXEQ6QW9Y2R4hACSNelwaGri7lCaEhVgLJZ5N/JYa25aMh3J0optd3Nebsi+JtO+rH3OZ5wJo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oWYUfBmv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MKSh6dm0; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oWYUfBmv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MKSh6dm0" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LA2JWH2445104 for ; Tue, 21 Jul 2026 10:14:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= B7BTdIi+zh96oXn04/dXzHRMysPQh1wnlTMmkfj/+b0=; b=oWYUfBmv4F0Go0dZ P0TlEHafVhB7FBhvHMo7TJqu+qMzYBzF4lzMxH2dhVZ/SIePC0FkorFwyr8mCzAb X3SLTthB6zqURWDqiUzJ9AJbcn05XYQV+SE1tdJ4V/6oGzcFjNTF4gOvlfAdyQYr DjrHkExiS1ImLes1MgBN0ijCgct3ij/CgDkZD/vtZ33ZgulS5VHoWqvwp1Tt1oEk IvCsCwLjVBJobr6dXFTRteWFEd1DKZ64VbPgojhGlCEAt63ROqlLnBOQyC8vojgf 3FE8Xms1n3yksNKMk4qRCeaq1DgWrNS0rEKL5jhSQJl7na/m90gX9JjpL/hxznnF 1WR8xw== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj6nsr1nn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 10:14:51 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ccbdbeffb9so39440745ad.3 for ; Tue, 21 Jul 2026 03:14:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784628891; x=1785233691; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B7BTdIi+zh96oXn04/dXzHRMysPQh1wnlTMmkfj/+b0=; b=MKSh6dm0dYD2KIGXZ9fm4TlzFrQcp7eQKXJwdS+qUNXE/u2hsNniupKR+BCNQ5i6iz T88Dcs229AXrX5Ep1LelMh9/MjF2ghZUe3Ngo715z1xCrUYoROQeYxSVRNOzufYdc2q8 +925Ov7IDKWxoppEecZKXci4fUkWStuwDzSoSYsgaS3tpoa8fKqTp1bP3OgHVBwPz9Bn LxCgd5VWOXQ2eaG5g6WbHu+XMRNRUGcFZl26u7IyHcXNzI1cuZk4QbtAg8/O9Fd7jBDU u7Ijs+1o1ZIFoxVn5ABsGAxtTagXPqkg3zIP7WzMmiXF9dZUe1CAv9cH2Qb3foQuIZHC 7m4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784628891; x=1785233691; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=B7BTdIi+zh96oXn04/dXzHRMysPQh1wnlTMmkfj/+b0=; b=EEVvzN428DqSWVfyOWPH3dKKiCjv2mbSJNTwpHzXctt1uwuvswm9W78fj+FqZ7znZH ebGMA0Ab4SOKg2HCIpEYNJ7aDa1AbedMkEAEL0v6m+pmVt0vrXLBfqgcQtawQk/3v3J3 t8r9IjELfZ8v5QSpFpntMXalKPyj5WTrFfIccELhdTga01BKgtcqftY0F2pr78+wfq3K kPYz/Rh3x7BVNgTDhSPdGtFA4QzEYTA1TF+t8vRnAbd2Br7a/YYQRllY82DaFkJI0X9U uqEDUtnB0e8xzweR+409DCqbUe0Ntm12fCHp5aQYEu3L9q+0qj/ljB+4ybwAr1C3PTgx Ru8Q== X-Forwarded-Encrypted: i=1; AHgh+RqirMNHK/2b+YoBMbvjW80dDL8xpRAMONw74tXQwPh9UoNfQQ42YeVcEabC2ySX56WNbZ+SC6xrfRROgPM=@vger.kernel.org X-Gm-Message-State: AOJu0YyXm30Y0tsFMoxQFvU4iIIo71C8hn0GzJFVdPRbIGWEabnSEeP9 4RqSM3G1fDku3KA4nOLpi2zqoP4MyOXcxfK3ggiWg6TF/nlS7mVUngGs+WMPPTt1t0uVJvOxL7M 9Ed5kkQ7iqBVpz2iNGEAw9N/opXHaVjwxxMK5/Er3aR+OtOnTGMGAURDasIaNXSQcgWw= X-Gm-Gg: AR+sD13vuVtEfdj+9spwOgut4NG8LBntA0LT4C8wQdRU3bTSak/ICOb9Y1kZN1cV6xR OmFTEWm7ut42nZGr3PDMVATkWfs0Dn7c12DVx+VJgTY3syj17b4Ng18TmS8ze6mnyRieguuM0GM cisMpd1IYRGYC9sSDfzqZSFalOqet/Te6FlyWPY52Y2E9N7+6RTioT5t3o4iA70loEfEeg6B5sl HQbmeZ/k1861rbU0EUmQ9NTD1rfFU18voT+VRNScwbTZLFXtmtBUzB2l8RJizePeh9OQ1Pb9lzd JJjZ/XoZqVfAtR/jaTAtVOVLkuxbH6/Yjwh6wgKBiiglg/AVyWw9XBSgNh/bL8cq0mt2gOKhfBx NuCuMkCxROAHwRuhhqbVqznOwi4bpC2mlZG6uBlnriyhR9X4= X-Received: by 2002:a17:903:3bc8:b0:2c9:d8c6:1db3 with SMTP id d9443c01a7336-2cf80587599mr22627935ad.8.1784628890831; Tue, 21 Jul 2026 03:14:50 -0700 (PDT) X-Received: by 2002:a17:903:3bc8:b0:2c9:d8c6:1db3 with SMTP id d9443c01a7336-2cf80587599mr22627625ad.8.1784628890434; Tue, 21 Jul 2026 03:14:50 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf342e3a8esm73812555ad.0.2026.07.21.03.14.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 03:14:50 -0700 (PDT) From: Zijun Hu Date: Tue, 21 Jul 2026 03:14:40 -0700 Subject: [PATCH v2 1/3] Bluetooth: hci_qca: Replace HCI_VENDOR_PKT usage with HCI_EV_VENDOR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-fix_vendor-v2-1-1977a8c39708@oss.qualcomm.com> References: <20260721-fix_vendor-v2-0-1977a8c39708@oss.qualcomm.com> In-Reply-To: <20260721-fix_vendor-v2-0-1977a8c39708@oss.qualcomm.com> To: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz Cc: Zijun Hu , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu , Bartosz Golaszewski X-Mailer: b4 0.15.2 X-Proofpoint-GUID: GidQ5sNVAtbwG1d7HFnBQ8H44CUZN04N X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDEwOCBTYWx0ZWRfXwrBqL7dqEgXN nSj06cT9xHJ6GRbyN/ioolYUiuXpBMGnViSIDMWfqsUBnuEo5AGk9+TKAPlBrlTXSR6LfYJMNbi JiG4BOlzC6OqXD7kkc0Rv5zleDY87+k= X-Authority-Analysis: v=2.4 cv=ZJjnX37b c=1 sm=1 tr=0 ts=6a5f469b cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=SK-ELO-gduZh6qpZz3UA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: GidQ5sNVAtbwG1d7HFnBQ8H44CUZN04N X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDEwOCBTYWx0ZWRfX7ltDpYcvvey/ 4j3/wJUbqdzTn2Tq9awSSutQ6pFM3noEu+y/F67VYJwXMJN9vbGIw/fpPaJgL2pvhGyWSqELhbD IX+vuwYYkV20+KuUH/5+QvW0wPhm5yAp343ZJjV3c7k/CtnVm4XDVJwJVAnW0juV+bsne+L2RI+ k0DTP/5A/2GluFUBB3XQaaCtqsjutBRgVeypRziXXefTxzRSu3zfHuP+Qkb+ZkqTsZncRcFtItQ jsFNjPJODsoyrI4RMg/BuyU6PqdulnXNzicRsB53aNMvGilR9xFAAitx8ptvhFgxZ7FeltILlJp FpjivWEjOCbK4lVS7Rh2MhXkxBB3YBKvEVPjhyyGZ3gdpFzFkZV24q/UwaLjzV4OQLeXcZ6qr0f P0nHXiQC0w9L4cCuJAvuXTYAZcN2WnYUeYrDSFrmPaaWIF1ijBCUvz3M5/GmBkK5g3xRZd7reM3 9CPOCxjDmCFUKQbOVwg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210108 The macros below have different meanings even though they share the same value 0xff: HCI_VENDOR_PKT: HCI packet indicator or type HCI_EV_VENDOR: event code of a VSE This usage of HCI_VENDOR_PKT is wrongly checking an event code. Fix by using HCI_EV_VENDOR for event code. Also fix warning "CHECK: Unnecessary parentheses around comparison" given by checkpatch.pl. Acked-by: Bartosz Golaszewski Signed-off-by: Zijun Hu --- drivers/bluetooth/hci_qca.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index bd29d422c209..f978087612ee 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -1240,8 +1240,8 @@ static int qca_recv_event(struct hci_dev *hdev, struc= t sk_buff *skb) * received we store dump into a file before closing hci. This * dump will help in triaging the issues. */ - if ((skb->data[0] =3D=3D HCI_VENDOR_PKT) && - (get_unaligned_be16(skb->data + 2) =3D=3D QCA_SSR_DUMP_HANDLE)) + if (skb->data[0] =3D=3D HCI_EV_VENDOR && + get_unaligned_be16(skb->data + 2) =3D=3D QCA_SSR_DUMP_HANDLE) return qca_controller_memdump_event(hdev, skb); =20 return hci_recv_frame(hdev, skb); --=20 2.34.1 From nobody Sat Jul 25 00:56:57 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8335D45BD78 for ; Tue, 21 Jul 2026 10:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784628895; cv=none; b=HZ1v4rVjS4f8RLH7w1Bh63m7lJEJZPnv639nrOcxPlYM6kKZEgU9+5dULh5ULqTJHeyUzCqOTSjjpNHvYrIUaQw1i3Jbxi25eeZbo5YAf/k01IqFfmV9Z11o2ZjjJ5epoo6QhBTTmkIYn6ZfWb4NVSilEGTD14rEBIOcY2VpxrA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784628895; c=relaxed/simple; bh=o9EVa6Ayl99uU/W5Td/prtqNZfPm6oKB3CMaxwDUV74=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zent4EXLF7fJFijqsm3beGccFzMlDFHiPczdI0XsoiDEE2eAxQhTjVvyXEYQxWnS9eC0rmm8AG5l0MIWmGL+DOmJFOkdul+/LDvq22223gTPm78Ps0eutVXc2LZNPUFhOUTJrBCiMuAzcjqzeVnLS666JCHbzI6hEVe4E5T/nug= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AZvdIn/f; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GzaTUW7c; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AZvdIn/f"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GzaTUW7c" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LA7E6Y1564201 for ; Tue, 21 Jul 2026 10:14:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9OKr/yW5NmookCdWgxyMj6JQ3VShNHBjGxnFEyAh0ws=; b=AZvdIn/fAGaDQsjw AXJj+XcacJcHuKNAg+dXi+eUMwRQ4BUuz78pUYZgDj2cFXeJ9gYDfDzl8M2u6Oyb 8eCQMZgNYlLU/HHWcf3XzZt+GxfrK5La1z1U8zo+xjo7IMvhrgLOZGvoSG63/3Gf ResvXFnQh2cRnf/frjaLyMItujoFqTOkOc9EpUFxvA5cb80tCwdfTnHb5fQMWsbN AnTpEaD95LlVviVyRhr2VTdhUyMBESQ26cx9bNu6aGfio/qwrvQw2q/VjFOg/9KM tZsaRnA5NnYS27p+24KNKIzK7ttkzka5AtfRNDkWY3Cy4eAafnm9DvU/lJhGt6jJ Ui/xaQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj6r3g12j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 10:14:52 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ccbdbeffb9so39440785ad.3 for ; Tue, 21 Jul 2026 03:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784628892; x=1785233692; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9OKr/yW5NmookCdWgxyMj6JQ3VShNHBjGxnFEyAh0ws=; b=GzaTUW7cTFNvVySpiWYqWh5jKAy0ywbv2oqiNN0TQ37SoWq7OJ7HIg8XrWeNWh5oEj 02F/Y8Kl6ulgsC4+sow2wE3OYtFft6NlhkwE3Ci4BX5qkG7ca4tCYB0N/CWWyYWmZK6b 2sk+3xAnrnuwXgK+mFyWLZZqhKu5Pwe0mRed+HMEfh2p9qvjtHuTImhPmgJ/OSq/NKm+ 9j8RdLBi/w4NXhGqq6jkd1vjQ2VVZiiuIrFWvZXjMQdf2icGNo2BnvEulEZTn6Hik6IB qOhzu98IJCN5Mjr09E4wH6F3f3repwWFCGfR2f22CueYz8BFYkDccwJepOLXHFWi3ACp Acug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784628892; x=1785233692; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9OKr/yW5NmookCdWgxyMj6JQ3VShNHBjGxnFEyAh0ws=; b=c92m2byxFlx483cB1cMYxjL1HtzGxMppbscUL5sWsGCI1aKTfZIIFU0pr6IxknmQC1 jqIE7O750b0UjbqgQJEkdFgGwnz3csIQQ2cQAmlE6E03pHVfZDq8dpw5ozGB/gf7bYBf n8WsLhfzr5wrJtYbEUFC1VPSZ2TrEUDvQfxagRWrphJZdcvEacDiz70usVbw9oWkmOC0 Y0GA8O3S3Gj1r5shuArUpl1RBaQ5C5aGYUtDocp4EEgWyHXmNV9uEnCnNef2gFn3EMlV MZNqerCjsyRuw0ImqorSjaOLHBawFvnbgxsOU8badV/YTZpbh24IOnzF/U2WlvbCDQs8 zcLQ== X-Forwarded-Encrypted: i=1; AHgh+Rp6kh1KaHc54QxXJeRwaFzEHvJDUxoaSbfrl2H9oxSqrybkpr8SRmxKMzuKnidXBVU/6kAeXTN8GTVgnM8=@vger.kernel.org X-Gm-Message-State: AOJu0YzsYMe5z3bSIkxOyyBgzlTmc0pR90/8Dwl2CWNe3YYMoE3alTLP R4BJZTdrf9AA+laUAz/mJhrVvY12S78XtYgCBhIqfUZGmrjznqSdbaFBGYXcNk6931kbCMCeU4y RpFKdes3DKLIdd/JtqgzDwHL/RkV9Rz4wC+agSKkWOT9nVtt4jVo/Zs4XRY9zsYOhC+Q= X-Gm-Gg: AR+sD12EtpcDAaMxZ8kShcRXBM362LH5L9ZoHImmx6zKEnKBOcWNfy+bHsY49vwyKej BmnmTTB36t/b0Ungy3QmVq4Xe+Q5hlt3ME+t5iOqhLn7OgdPPTQ4LQEBOS2h/O895XUbOIifUma JamUX2V8LVrfRxtD0rrFdw50iG2SYlaS+t09Be6zf2Rl1tUhY3pg12TS4tMj77rsailuYxAKF4T deUH61Lh6V6yZdzgrrw/v36H3KbcfVPBkW6O1pwmbPy5EG9tkSHVSeeWEPmGj3PKHh30l+74/6Y 53s/59gCyMHWNqDt2cSvXBEgZyhcMFYROcpIFYsh8/Vicsu2m66nx5thHSsjTzSVa02aMg0eMI5 6HDa3bVW6mQbEwmBuuNKlgemY5UcQkwamgcCZTI5NU6PxJQc= X-Received: by 2002:a17:903:324d:b0:2ca:ecf6:9115 with SMTP id d9443c01a7336-2cf802b7fcamr18691695ad.2.1784628891823; Tue, 21 Jul 2026 03:14:51 -0700 (PDT) X-Received: by 2002:a17:903:324d:b0:2ca:ecf6:9115 with SMTP id d9443c01a7336-2cf802b7fcamr18691465ad.2.1784628891414; Tue, 21 Jul 2026 03:14:51 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf342e3a8esm73812555ad.0.2026.07.21.03.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 03:14:50 -0700 (PDT) From: Zijun Hu Date: Tue, 21 Jul 2026 03:14:41 -0700 Subject: [PATCH v2 2/3] Bluetooth: btusb: QCA: Replace HCI_VENDOR_PKT usages with HCI_EV_VENDOR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-fix_vendor-v2-2-1977a8c39708@oss.qualcomm.com> References: <20260721-fix_vendor-v2-0-1977a8c39708@oss.qualcomm.com> In-Reply-To: <20260721-fix_vendor-v2-0-1977a8c39708@oss.qualcomm.com> To: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz Cc: Zijun Hu , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.15.2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDEwOCBTYWx0ZWRfXyDYA9tRAmqZk zd+RCxncZjlEiXMxECZrrMiXnW/DADcvlQ/64Cf7i57D+HPgOTu5qLiGMYrD7VLDBwtCEgpSHXB IuX+ZuPM6G/bz+cV0Ypd0dNRIBhdnA4V95Nt9LmECh/RUgyotaUSsMM/iQAgXV4XiLTYDfnDmMq rPHJAjTREYtKOltaHAD+tJvMBRwO301kTt64+ts/+BMWBNeQc+ktl4YN+THunw5eMRNscFlCTBG uw8bOuAb5w0DV6cxiZNbNVpoGrdMGDk+OlUgUDIvJsmEEe8ISIb1R/RCjj21+DpUhyXG7D9ZTSq t/wmmlM8KwIA/mvDx69RcI5nipHCCkyjrHBnD6hzn5y2IVE+h2Ldkt77vESUs795oljP98ynCSr bW8PMh8Uvell7XHi9bleRf96Xbz6TShyX0SggWr3RQy7dinagUPtnsMDDRn0lo7KoLnEGRNb9fA 8ZSmRg8HEmxUhMKdvBg== X-Proofpoint-ORIG-GUID: jylB4iYdror9QQ0z2lmXo7R4dJb9J63M X-Proofpoint-GUID: jylB4iYdror9QQ0z2lmXo7R4dJb9J63M X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDEwOCBTYWx0ZWRfXyMhhKjWd0d1b EmVxNTurZEnrr7WMLLTSPnK5Ohk3g+eGO0Ij1HyrzAEAVku46/3+1gwLGWOvyvevk+BZ6VVLSY2 aRGUcEs/4ZSsHeSmQ02GNoCu+lREMtw= X-Authority-Analysis: v=2.4 cv=SIRykuvH c=1 sm=1 tr=0 ts=6a5f469c cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=_0CnrhXH5lyLv-Mul2kA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 spamscore=0 phishscore=0 clxscore=1015 suspectscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210108 The macros below have different meanings even though they share the same value 0xff: HCI_VENDOR_PKT: HCI packet indicator or type HCI_EV_VENDOR: event code of a VSE These usages of HCI_VENDOR_PKT are wrongly checking an event code. Fix by using HCI_EV_VENDOR for event code. Also fix warning "CHECK: Unnecessary parentheses around comparison" given by checkpatch.pl. Signed-off-by: Zijun Hu --- drivers/bluetooth/btusb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index f7cce0cf472e..3847a0f6d096 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -3278,7 +3278,7 @@ static bool acl_pkt_is_dump_qca(struct hci_dev *hdev,= struct sk_buff *skb) goto out; =20 event_hdr =3D skb_pull_data(clone, sizeof(*event_hdr)); - if (!event_hdr || (event_hdr->evt !=3D HCI_VENDOR_PKT)) + if (!event_hdr || event_hdr->evt !=3D HCI_EV_VENDOR) goto out; =20 dump_hdr =3D skb_pull_data(clone, sizeof(*dump_hdr)); @@ -3304,7 +3304,7 @@ static bool evt_pkt_is_dump_qca(struct hci_dev *hdev,= struct sk_buff *skb) return false; =20 event_hdr =3D skb_pull_data(clone, sizeof(*event_hdr)); - if (!event_hdr || (event_hdr->evt !=3D HCI_VENDOR_PKT)) + if (!event_hdr || event_hdr->evt !=3D HCI_EV_VENDOR) goto out; =20 dump_hdr =3D skb_pull_data(clone, sizeof(*dump_hdr)); --=20 2.34.1 From nobody Sat Jul 25 00:56:57 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE7B53C10AC for ; Tue, 21 Jul 2026 10:14:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784628898; cv=none; b=JnCJOTzZ2sD2HIEtEKj1WngZTi+o7kKtAEhGNL+WtaxnrLbyf6oBAola1bfanLgmcJ7NGu3Jyrmr/ojw58hOB9GUKOxv6fgJKEEL3Rm5HceM7qDaEb9+I5LpU+tYPAiPknZKxHKat19xJXbBzObLfmOoUPW1QKS0C5N0vf19qHE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784628898; c=relaxed/simple; bh=AtofScJ2X8wM4sopKDEEOLqzXEdRIKA+OE6Kub/tWXk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AfJzdTHUCAz3yt3K5j6O2jF4G13T+g+xOlbClACOX9Ut9G6PBTdHSplrncnr/J/zIbA5uoHz3HVCNKPA0q+x27NZm9+1BrQghbH0kKWatB/MipL4tGbmWqVoffP2NYwcroTrRnSu5tLtVuorjpZHwA6EmIWpVYduYaSHXUDdFj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=bj0zckGN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jP47GjE/; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="bj0zckGN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jP47GjE/" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LA2I7n2444869 for ; Tue, 21 Jul 2026 10:14:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HHZqt2fWjXPHPXcHtsaD71amy7pw+6jum6wX0ZmCt1I=; b=bj0zckGNDvjN264q dyAcUFf6Z60JE0tmXx3wE7SgRVXT5TMbpCsXSLdlqtc82rZo9Yi8eXPp24pFQkCp s4Re3zHYWPXLIGnjNjFMVJ/U5cMkmZ1WTzCij5AFuTUciz42Vk8QZSGRsXzSnFtB fYVweziBrkJLA4oaxXYOh1pwUvXOneaOnfIYuQoXC61WCxv/xLLxbAaMmWTEmAHi M6BbAnJ/UFE9VvjdtBXtjPxr7R+ty1re+t3zzKLtVcx8GuwKZSLeJHy1Zpon77rF CibSn6csXZQbTRHx5sUpHCxdK9CQwBSGseU3YiRPshrB0F+8ooS3Z69TwKYniIe7 aYOTBQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj6nsr1nu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 10:14:53 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cc98d6a88bso37343505ad.0 for ; Tue, 21 Jul 2026 03:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784628893; x=1785233693; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HHZqt2fWjXPHPXcHtsaD71amy7pw+6jum6wX0ZmCt1I=; b=jP47GjE/MeMVmZuq4jJdankupNBCUveDpxAICcBUIJXzeNtiodm+FWI8UoqcDihKDV x9e/oSOFBDNGqeqpEpJ/1KTz22C2mZ933bhRkAK5KGdFTCi0I+yVwpJzIUSXVlmN1MlX bRXu4U2CN4ydT2Nh0VT+5ioTvOm/OQYSgCe2j2KXohSFue6kbjlVkjgPqGwkjCDvf1M8 JvVHDIFlGXwiXTDDvWZuTmi6Hz3c3fnCsk7WzZnK1ep99fpjS8Cvuqg1x+FRux8pcXnw kNBK2fI2gSXGnBxhE1JAgAw2mOe4D9uanjNkQ2dJTBkvHBb5rdB63sKoeW0WO0K5/Ebj wJmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784628893; x=1785233693; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HHZqt2fWjXPHPXcHtsaD71amy7pw+6jum6wX0ZmCt1I=; b=HZqR/SIkrvae2cmFscwPjKqyD8LUL6uWizW3qsSBt4w2setQXxcIsYXfdqjNOrbgga 2th57tcZXLkjwTwTWymFhkTT2oTLpZNzf0n28WFfVGEOFN2K088eKbTznQK3C2ZM5lun wBcKO8GDVIJu/RyFWsQAG/IgRL/Noo3xgjhtwwsbiRASi7kaZJoU/QCPQu6AIcPtyoyx AOmeBSnpycrzlI8JcYcYwY2imIVwZiB2vL5Ybw/b4GX2P777+AxR9xgkWieGbxwjXNyg CPR3jnomVYGMzFJB9THspV5LHzHtQ7YHmXvAXTCZtHZfHWul1nMkwTaMDBPcYmgNjP1b AncA== X-Forwarded-Encrypted: i=1; AHgh+RofIejI/41Z+5Fkwj7XPi8zPqVBMjuMky2jzzmvaU9xuNncawgZa7AWc6LiEwO1ZDc6VmEAESb5Lp5hLVQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzQPnTHfq6xQbvPS/mh7muoBKrwmaVnhHf8vo/ufjSxU6V9a5Ho adPFMpgRqH7ou42UlSglABQcKH1+3OFPBsZ2e8Q3Ml2Xt+3JzEG7VZ6yVNe2poGyU81eR+gjYe7 J/mYGlp0JH2oIdUkEWIy12clmKGrlQnFrYjQmGNakgtc/X/bq+OHgG67up7ktd9zPCLM= X-Gm-Gg: AR+sD120vAKwLJ8mKbdpQ8UXM0YHbNoGtdIH/uUKF1fdOKenIa/6pAUALGA1x7tVVc4 RzcaxTdWzn5H4Mf9cP2SYGajBph2b4XV+oOgyEhy0ke4HUyzEMYM+vxKHkcvR+Qkprt3uc2R1if EFK6oyrtzLbReYQmxzxVkQZgHhHPursOmdETe2Xq0ZR7JoPTT1a8yilu92PewM5r6PqyPhhiyh5 jfixyrO2s/WLJaj0ZYR3g2du7XNOub3lCVrbnrBMdQbHEzUhV8kloCxrTcf+Nc1NsdxMWO/ZjcY jnZKP/GzKmQBuM5WO+MfYl+PKnOsaueAZIVNsTJfGqhLjFV+T8OeSrAcJcKDPX4He5Raa1N6m6Y +NpA0v7syVi4T0mCfW6haTtjFQFySYH5HEEfaC/+uSLe4iLg= X-Received: by 2002:a17:903:910:b0:2c7:ef84:c58e with SMTP id d9443c01a7336-2cf802b31e1mr23684565ad.1.1784628892790; Tue, 21 Jul 2026 03:14:52 -0700 (PDT) X-Received: by 2002:a17:903:910:b0:2c7:ef84:c58e with SMTP id d9443c01a7336-2cf802b31e1mr23684375ad.1.1784628892356; Tue, 21 Jul 2026 03:14:52 -0700 (PDT) Received: from hu-zijuhu-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf342e3a8esm73812555ad.0.2026.07.21.03.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 03:14:51 -0700 (PDT) From: Zijun Hu Date: Tue, 21 Jul 2026 03:14:42 -0700 Subject: [PATCH v2 3/3] Bluetooth: btusb: Realtek: Replace HCI_VENDOR_PKT usage with HCI_EV_VENDOR Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-fix_vendor-v2-3-1977a8c39708@oss.qualcomm.com> References: <20260721-fix_vendor-v2-0-1977a8c39708@oss.qualcomm.com> In-Reply-To: <20260721-fix_vendor-v2-0-1977a8c39708@oss.qualcomm.com> To: Bartosz Golaszewski , Marcel Holtmann , Luiz Augusto von Dentz Cc: Zijun Hu , linux-arm-msm@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Zijun Hu X-Mailer: b4 0.15.2 X-Proofpoint-GUID: hr4IB_pIf3OYAniBA7DGG8jb3pDG9r4f X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDEwOCBTYWx0ZWRfX+DPQzv7TYxJs 4zPj0IR4kWI8GVaeihSG0V/98bVj0o9wJQ7JOmsrmFwRyvO2gheKWrkC70WrJVHL9+YJqmvH3Ft FyQ+bEZlwIMGOb4l+MJwA7zA1n9Vkpc= X-Authority-Analysis: v=2.4 cv=ZJjnX37b c=1 sm=1 tr=0 ts=6a5f469d cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=x96CrpYRk5hthMOPTrkA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: hr4IB_pIf3OYAniBA7DGG8jb3pDG9r4f X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDEwOCBTYWx0ZWRfX2DBlccZB69S2 9Zq6sxuLqs5Bd2hJMKP7GXYXG9U3Wa7qBvr6dhwuO2Il6/fohWRlZLxztu1HAxNXJJXBGCHGjGR MJejbJtezIZzOTsTbVK3B3BzQsbgRnh96d91c9Av2kqQRgitVamYjy3XgKSMmtPJWeXaJtIh0Om H31ozyT9JQU6Tf/nBuhtVoA/exO2diMDM2wdPM//IeJ7hevPmg3VNnLP/jWljg/qLtVGk7Ms0l5 37JcuLf//ZpcT9o22FqERUjcledkMFj7adqyRHqFhmiN2EocKPw4r2i6YF1T43aXCdJt8URyFbv X1X5Dj7CSxiZBbvOBSxgxev5ALe5A9nsByC0Y4vAoiZGsYElXtCHsCmvhayJPKdSjOgcAsKYDSZ /UGAsQ/6SIs5UXfDsIVkmp6cWdnxvCnL/xCm/A3dzyy0oS3NmQUOL/x1GpC2XkDXguR7rE7c+Gz y56f8tZ5ll0hZ8P2S5A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-20_06,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210108 The macros below have different meanings even though they share the same value 0xff: HCI_VENDOR_PKT: HCI packet indicator or type HCI_EV_VENDOR: event code of a VSE This usage of HCI_VENDOR_PKT is wrongly checking an event code. Fix by using HCI_EV_VENDOR for event code. Signed-off-by: Zijun Hu --- drivers/bluetooth/btusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 3847a0f6d096..4d59b28ab30f 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -2800,7 +2800,7 @@ static int btusb_setup_realtek(struct hci_dev *hdev) static int btusb_recv_event_realtek(struct hci_dev *hdev, struct sk_buff *= skb) { if (skb->len >=3D HCI_EVENT_HDR_SIZE + 1 && - skb->data[0] =3D=3D HCI_VENDOR_PKT && + skb->data[0] =3D=3D HCI_EV_VENDOR && skb->data[2] =3D=3D RTK_SUB_EVENT_CODE_COREDUMP) { struct rtk_dev_coredump_hdr hdr =3D { .code =3D RTK_DEVCOREDUMP_CODE_MEMDUMP, --=20 2.34.1