From nobody Sat Jul 25 00:44:34 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BC374C8FF7 for ; Tue, 21 Jul 2026 14:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784645909; cv=none; b=NX6ik40HOSQxGlj3FrDgbXnB3hHjjCXP5vi2FNBZdtMDDSnAzuGBP+ZtWUv67S+zOi6UUWQwW+P4v4ibzFWiKS3Xi+JkzSKtNdMTmmWRjSWKuuEUMI2Jaklz3Q9J5OScuR/Aqqg2NMwpMcCvUSpezxOou3a5dyRXESgrX7bdpM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784645909; c=relaxed/simple; bh=wyuCd0m2Tf6gslltmhzVm2PYWYg/TizbC8o2RujD6Jk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tvhn0vj9UOcSuIUXcb8d1m5wDlCo2aHa6Kg8IpqtYZXo1ughbbm004iviHJyUIDeTvAGgLELbn8NHJVwysug8RzCkfzmGQ9Ir7c1N9J6Z1HjiJ/gwmuBGl6PYAacnA2keVfXQustFCKqG+DdbfikVdMdl+ouU61vHuRHp+HSDP4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pT4n0Y2F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CUzzD2aZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pT4n0Y2F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CUzzD2aZ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LDg0WT1912543 for ; Tue, 21 Jul 2026 14:58:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YKmjy7alDb+dpOY/O60rS4xgw0LLuCjkEI8V9VvwZ3k=; b=pT4n0Y2FY2mikl8r mbThfQJ6GaIN1Xyd0013B0mcX1IR+FqXwAE9TvHaXQSg9c7VWRxPM+BU99BBI5a6 wysRY01xt1OYgHWlqX9TMb2Kk9/g/VLwBrrBdFpFu6YD5sIpXVrKN+SudwGZXBv3 S/QYU8JBdwtrdqmf9txP/ctLhCzw20JAgAiw0MP+JPa5NLvsptI5bqaeTb9LONyV pklcqdWY4fCN/Zqlh5pGl/SQHBQawU245KL3BQWnXrTwTzAtVKwcSxOeaDikiuiO UmwP4+/ap4ySuGo5sC0T91kiQe2B+g15PrKIzffSUW4V/cuPlkc1oIUI3CV1mBd8 Ij7CMA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj1duk09g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 14:58:26 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5174a23afcbso100514761cf.3 for ; Tue, 21 Jul 2026 07:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784645906; x=1785250706; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YKmjy7alDb+dpOY/O60rS4xgw0LLuCjkEI8V9VvwZ3k=; b=CUzzD2aZj5uVHqqemepc6nLahQeq8TWnOx5Np8t9g2dt62ZG/E0kIctiShhai64+P9 ImqSDdI0SGL1gDtEzV19OdX+TMdPrwt8nsyu/OQs6zoszj4hVOKY1C+zwUWPdj800SZY qon7UvmWJiKHKVvlvWr0HFDLrZHZnVdBSQKYSVrlzAYqXCCmfDPGjyzrSRMPQpDyc5Ds IW+NSBx41SY+wNEHOSlEHgEniDDsinmGtn/rapTZsJ4iCUcPVyUiwoq4zEr00ufhExtf khXJoqLMRTZg7LFeNYGla0dv5kFw8HuBr4/nP2O8Ih/i9NRA6Xh19tnL6X3vAEwY7zwW yn5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784645906; x=1785250706; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YKmjy7alDb+dpOY/O60rS4xgw0LLuCjkEI8V9VvwZ3k=; b=XWEzhcl7i2jrFtKOfWKUKTJPYDf6hP4BQb9yug0xv18/EK6N3TLP7gK5PChBrUapbi IghiERC+w9gxlR8nJXG/hsqDFKK5bOb1rZJGhTEbMOljlv94ARrXWVLJylJRc7C/yIZd i9cD5ZrGwQNv+y2Cq4XJaHGZ6LfsYWHxbgOI6qmZyXjH/gXgicZomGFYCKenXCh2Byr5 blT668nT7XrOgJFyLbbxzJ5gaOVFSfaBpj+C47fZ6QiR5JGwg48vgy5QxG/2ZbDMZMed pTclYK8VgPKp9m6FQjEATBaWt/V0QuDgzJvdLP3iPMZrDuhVT9804QxqUofZvQGQNNK+ ZBiQ== X-Forwarded-Encrypted: i=1; AHgh+Rpxl6T/8ggDowZ57V8nvgsZYJ3FJBSqS7jPGjGP2cLlW+B28EABr8cRiM8T/uggaxSKit94+j/xl7s1YyE=@vger.kernel.org X-Gm-Message-State: AOJu0YzVxo4YHJCDctqtc5dHI4sbghNqOFSrmvQkXskACxgKmBCCz5wZ lMamSkZZ2JzDM26W6RP80nt1WsDDwOmmSI/CvtDiUfpY6FYv1TGRisrteNErKhL1zqSkAVfB+33 kntB10twn1lvxEIo0As9ul5j9pokmCM0ViV2/+8HHri1TKJZSCHqfZEy5yJoDhKT+c08= X-Gm-Gg: AfdE7cmOIKphXz5KzT6Pcsp/GzZ3bmWGu0ibrxhf6eeyySL5+2b7nKRSdI6RNftZQU6 PkXe9a3B1CQAjp4zLEZf1yUlby7mljhHY7n9QrZbRCXvo/oVM9PjMCpnGnbFEqLfKrzWjtcMEWE DbOQHzSf1KH3Y5/weFQQoDBLCIC62QVYucovo/NCFs+5xh+Qj4lXvodBE75sxyVW4g5k0zjPoNU pvzRWX4Z49JGtjlDGOaqUZEW+OX/vhT5rmRKVay26FqggekeXvGrK+TwgzOOKCyDyc7jvNZhC5B rR/eZ+vURjslIlvyQe+/Qdjo3E0lj/zhN/5L3JKQsrQQPP2u8zQwtVu8J5Xl5IRE9mVhrcglIPv /p3Vgas2FaGle2+T4YzfBbn/u4gUSfekKo5GkG2F683/akxeZ1VlnTOQzS/I/HLKodt8tFlGhdW b3dv74DP5IOJegB9l8N05qzpJvV5NGwFbz9NfYPDF21PjDoQ1QHa0= X-Received: by 2002:a05:622a:83:b0:519:51b1:e764 with SMTP id d75a77b69052e-5213e48be91mr169175771cf.47.1784645905472; Tue, 21 Jul 2026 07:58:25 -0700 (PDT) X-Received: by 2002:a05:622a:83:b0:519:51b1:e764 with SMTP id d75a77b69052e-5213e48be91mr169175331cf.47.1784645904830; Tue, 21 Jul 2026 07:58:24 -0700 (PDT) Received: from QCOM-eG0v1AUPpu.na.qualcomm.com ([2a01:e0a:830:450:751c:d61c:c91:60dd]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69e6ffbba0fsm5875369a12.17.2026.07.21.07.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 07:58:24 -0700 (PDT) From: Loic Poulain Date: Tue, 21 Jul 2026 16:58:19 +0200 Subject: [PATCH 1/3] Revert "i2c: qcom-cci: Remove unused struct member cci_clk_rate" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-cci-clk-fix-v1-1-5eae78700da8@oss.qualcomm.com> References: <20260721-cci-clk-fix-v1-0-5eae78700da8@oss.qualcomm.com> In-Reply-To: <20260721-cci-clk-fix-v1-0-5eae78700da8@oss.qualcomm.com> To: Robert Foss , Andi Shyti , Wolfram Sang , Dmitry Baryshkov , Luca Weiss Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Loic Poulain X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: hJaXO41D4owQnRYt2IibmXT06PvUUSpI X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfX9diGPPCTYuYx tPetNrjoHKV9+X0wuaQWW69RVc899EsqqmJUrfh7lVc3gxf7hGF1AYEezIekdpuyOtcFnq3zDOo Ks/UUPw4Yy3/80bRvxzY9h4IKrNeF2/+sL6YNkiz+zfbbv251WE5FbRN/DoODCDQBeUQxJxMVJ/ Ws322PpFDJ8mIcf8Y5yortHiaGwIFKd2qpFyVr+DLI0WnbAFMQFv/MwmXzETh2P4TLLzIz4kObV flLr0QDppWlroyj4qAc+8NV4q4HxfVtL96qG1nrW3r2pKmuJqDlIAoNuIIlTeqhOWUi3kdfkT++ cKYhQOuNb8hYWhyWrJvt1AJ2aNGdE6Y9gQp+PZY4j0utcKEu12oGA7N+mjUcBnWdrm2ODNRoR28 a+gJhihjaNdRGbbhNSe894Kjbf3VeUulCyX/wlRs6AXYnTaGVauo6pARyaxWrthM3QHWI5ZY7E8 Ie2FY6WTKfHfiYO0hxQ== X-Authority-Analysis: v=2.4 cv=I9JVgtgg c=1 sm=1 tr=0 ts=6a5f8912 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=wn_r6Zk-WEjAk6jVh9gA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: hJaXO41D4owQnRYt2IibmXT06PvUUSpI X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfX08s6uJUASYNk JFerm7ZnOVLe6kIqIFtue5lxMKI7PXmjudYAE62M8+xQ2udic8c568eGaQi29PZAqfQkR3KtSk2 82G5yEmqLkBcrXg+C7Wg6NyGXvdv5jY= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_03,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210158 This reverts commit b641af684fc28a07bee9c808eb6c433f9d9bcec6. The cci_clk_rate field is needed to enforce the correct CCI clock rate at probe time. The hw_params timing values are in clock ticks and were calibrated for a specific frequency per hardware variant, so running at the wrong rate would violate I2C timing specifications. Signed-off-by: Loic Poulain Tested-by: Wenmeng Liu --- drivers/i2c/busses/i2c-qcom-cci.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qco= m-cci.c index 4d64895a9e9e4e0bd5e0ccb5c3cc04b282b1e4d5..19e4719f13b29b2cf60e113565b= 1b63f19d0e669 100644 --- a/drivers/i2c/busses/i2c-qcom-cci.c +++ b/drivers/i2c/busses/i2c-qcom-cci.c @@ -117,6 +117,7 @@ struct cci_data { unsigned int num_masters; struct i2c_adapter_quirks quirks; u16 queue_size[NUM_QUEUES]; + unsigned long cci_clk_rate; struct hw_params params[3]; }; =20 @@ -668,6 +669,7 @@ static const struct cci_data cci_v1_data =3D { .max_write_len =3D 10, .max_read_len =3D 12, }, + .cci_clk_rate =3D 19200000, .params[I2C_MODE_STANDARD] =3D { .thigh =3D 78, .tlow =3D 114, @@ -701,6 +703,7 @@ static const struct cci_data cci_v1_5_data =3D { .max_write_len =3D 10, .max_read_len =3D 12, }, + .cci_clk_rate =3D 19200000, .params[I2C_MODE_STANDARD] =3D { .thigh =3D 78, .tlow =3D 114, @@ -734,6 +737,7 @@ static const struct cci_data cci_v2_data =3D { .max_write_len =3D 11, .max_read_len =3D 12, }, + .cci_clk_rate =3D 37500000, .params[I2C_MODE_STANDARD] =3D { .thigh =3D 201, .tlow =3D 174, --=20 2.34.1 From nobody Sat Jul 25 00:44:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C38B74D2EC2 for ; Tue, 21 Jul 2026 14:58:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784645914; cv=none; b=Gn4MB2FIZyj2ts7fYSP7gzj0+3A0aUtYIfNAEn1eGLQHxI5CUkfVqyCgjygc4DzYY8JBYtyrPtAUdUWlm6hP8dLCsMNWwyymi9jZCBQaEFmCf6OvrS0qFPJWXBe1eZfUGcYm10U20Ckg8lc5uEGXWTW+R3MIqrqGJvfUm7R5pFo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784645914; c=relaxed/simple; bh=IG6nNY2rpLz56Y4qeQC3PTx1SQ0y6+9CgmNeqxv5pFQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fUi4J/ZB2er076BRl6zyTGNNk14wZnE5pxmsq84ZXGqQ3piM6ydteAZ0cUSt+lPHyNGUjFmah5vIXcve8862zKW4dUmbwylUVd7DHBgA83aJ/nKcRLrJAOyNHRjU3F42Be6WGEa9qGJ1PJn3rfna+mCdFlAnWx9DFgT13XeGzf0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CGWhcaWG; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YezOlgww; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CGWhcaWG"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YezOlgww" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LDfv231938701 for ; Tue, 21 Jul 2026 14:58:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /NvVmHEiARXUqdG5xNPL/AxvPN8bY9Ggi2ZtbAMd1uU=; b=CGWhcaWGMDfTYyoN YEsHGIFs3e2TLxnq7jwlxjzEKDT9rFgUnsnfYAG2Umv1c8yeL8vQmXNocNPmkRt3 SFlIoV5iXvb7BeZrplMlc0XhOSZNJNsytnfltarf6fPv5+zlyctwPhdhQbhqJAoX SLLoDt2t04SrTYkM4+IKCLF+9LEWxRh2oFT6l4pqWTmVkqA2OUrozVeZgSDNekZz sks2bG9V1Tl5a+UFg2yvwuDQ2RgDweGbrkOASmODV0wvx+yOYm56iJnLh8zdsOki Zb1Zl0taz9QLoEiWWZ68ZSHdpDM8aBY517akSGE0PbQDtH2TfVOIIJzp705UBI26 +hY8OQ== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj9bs8htk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 14:58:32 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51ebdfceddcso135932381cf.3 for ; Tue, 21 Jul 2026 07:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784645911; x=1785250711; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/NvVmHEiARXUqdG5xNPL/AxvPN8bY9Ggi2ZtbAMd1uU=; b=YezOlgww1EtgGHFyWiP78XSXa7folE/z0UlpTEUUTTBma0aqlq7F9X/W+JihntnZJc FncPHOcEDbBUt1FWUS6HFNmbZnWbiDRy7983nfhJb9hIZ5MkQmc1o3m6DqSFpwFsd5mt z2KZh4zI94lSv6CQQQjoSDCR4jK37ebtpckMx+Ysl33LSKvURDuyK8A0GB+x5k3h4Oo1 +ubOVuSIavM23x9bNlqfR94pHJIuRm3Fb9IkOfNyR0m9cU5eMmr3qwi09vhbvukWI9/L fkaLywRzx5dz5hEbXu4IZMUZ+WEyuPmQKTXrWOxXOM7cMuipNsIJEiYv63jNMacjzGOj u8BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784645911; x=1785250711; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/NvVmHEiARXUqdG5xNPL/AxvPN8bY9Ggi2ZtbAMd1uU=; b=IXVLdM0xQg+g9Y/EcQunYrQ0zakBB7p0I0mDQ3MGu+qW8YquGWmy/vtWBIQCGV/cei RFs/Ou+etRMwC8h+a5ZY1aTKXtntOH3Lf7AS7z6OmkEqFhWTLkP8kpfJssEYWGe1lVtE gBGSzERkus4DIi8Wfk+0LxCZYn+CIeiNSGpmTV6DzKnPPoch3Nf0on9GUk0fDdwMGKqy Q+CQ/OtD/m4nFdfiEqwYZ5gH03pMVOrDyl8nLpW4Rr/3TRHT78EwLikzC/f7EkOwuTkC neVCOgstwp6Q/WwKpdHIjS4CNx3jlyWDnK+6huhng/XkZSKBEQxyhXtB8PolzdA0PUb+ tyFQ== X-Forwarded-Encrypted: i=1; AHgh+RpP4xigDTBT5hiSgtSFSS0WqLZKXr/zfKuzYTAhShobHY9eN6ICsIvE47NOz/ACpeY1QyiE8QfcbwSXLQo=@vger.kernel.org X-Gm-Message-State: AOJu0YwW1bbsRjwMIrNRxET5TxllxWMBO/MRCZ14BUY8Stxl4i8E8nNt UWDuPIkEquZAz9BGnH2c9y6AogjkQYMDpafMLHawVL5K2HssuCmoBZywbO+3/yXYc6SzC0yuIUm g4VBtA0ThwUK9dUH26y8WUP6IB6mkirw8RXSgJHFQGlpTUQwjfriP7OmqLpy8xLe2bZQ= X-Gm-Gg: AfdE7clnVlzSVgd6WbPfVztDrrJbQqKBZh7aip36c8qt0ERSCOs6AFc2+FzWiIPT931 2kd4h6kF0uL9Gxi1oc3eKMk8tF/BVJqdt0t/x85KqFXJgRGyPqk7/6pUnq3WuDwvyFzHTJ9Pbps Iv5xfwzVTly8la50f4O0VW415LLip0WpDfNbC0ozAq9q8tZSxeEIBQhnautT/P7MiZzJ4p+EQ2W FJYUoZ7FX8TGrJVlNl+LKff0pOFsJ3zO1352rI37QnjXJV/Ndosa4xFvrY73YbVi0lBh8LMeowD 1xFfmfUIcxMXKXnykxUWnHOI+blpFCxIDeo6rMCWpldgSKSSHwWWLtQjjGTaGqw8TqwUuCbm27/ V93w4xVfshOd7kz/JfjqnWgYuXVKLarLgg3HpY3FNFzZBg5qutPrR5dF9dTAof2NDMCS8J6Z701 dTehuiHG7uqzbdEyUMYsPPu5Qx1qsfnosL4tp2ekI0vLOEkJ0eGcA= X-Received: by 2002:a05:622a:4ccf:b0:516:e0eb:d7d with SMTP id d75a77b69052e-5213c2028b8mr186792231cf.27.1784645909309; Tue, 21 Jul 2026 07:58:29 -0700 (PDT) X-Received: by 2002:a05:622a:4ccf:b0:516:e0eb:d7d with SMTP id d75a77b69052e-5213c2028b8mr186790761cf.27.1784645906827; Tue, 21 Jul 2026 07:58:26 -0700 (PDT) Received: from QCOM-eG0v1AUPpu.na.qualcomm.com ([2a01:e0a:830:450:751c:d61c:c91:60dd]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69e6ffbba0fsm5875369a12.17.2026.07.21.07.58.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 07:58:25 -0700 (PDT) From: Loic Poulain Date: Tue, 21 Jul 2026 16:58:20 +0200 Subject: [PATCH 2/3] i2c: qcom-cci: Add missing cci_clk_rate for msm8953 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-cci-clk-fix-v1-2-5eae78700da8@oss.qualcomm.com> References: <20260721-cci-clk-fix-v1-0-5eae78700da8@oss.qualcomm.com> In-Reply-To: <20260721-cci-clk-fix-v1-0-5eae78700da8@oss.qualcomm.com> To: Robert Foss , Andi Shyti , Wolfram Sang , Dmitry Baryshkov , Luca Weiss Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Loic Poulain X-Mailer: b4 0.14.2 X-Proofpoint-ORIG-GUID: UOwp-Xovda6PoT7WsTz9RmRrR0uHy2hJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfX09ToVn+dXqPr jW9LQp0go3ITky9V8WBRyK6NSSk/w6NuVwczE5fVhz+HHkmLxrYXq+fEOJwPh9pLEq9vpOlSES7 NMC61bifXcnzG54W70jN/Ym4Cz1b4v59G64zmG5ooq543eHIaKArdglOxUy+BVu746kVI56qlG3 Al+auHweM2kzDfwiHUMzgz21/3fFSSbe2xHUXXk+G+YcBhHlJnuHLu2TJQeRGdDOHJ5w6owGlLa CJ28IUJutSvPsc2AVb6kEqJUZAYKq1yDBqGzUMZeqbSio9AC1B7GVZPxYrbnzpAa24tmdiv95y5 H84a0zoZ7jz47bSMyWMDtwgLgBxEKXayFb4ARBCODcH1FZy8ebxFWRMFXlAqZNXVedgCHKCNFPw ivcV/OSYNgx83kwU3ipmQlpOFQAaioyzYUdEUfFWbLl20pHzinSrWKUkmORGJxBrHWpEUo0sswI 08+KMahdG7fuJhMEc2w== X-Proofpoint-GUID: UOwp-Xovda6PoT7WsTz9RmRrR0uHy2hJ X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfXytf9ZncETEnw 1j+/W8Q1REnnEypa8TKmky/lxxzbPBkZwgUoTH1de13TQEBgQGTADCXOLQ5fw7h9zU6QD+JWtNP JzCGQ945Bj04E6foWsLtUnCgsDO8T3I= X-Authority-Analysis: v=2.4 cv=QK1YgALL c=1 sm=1 tr=0 ts=6a5f8918 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=JZ_a1HBs4gVu24XmFGcA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_03,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 phishscore=0 impostorscore=0 bulkscore=0 suspectscore=0 clxscore=1015 adultscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210158 The msm8953 CCI data was added after cci_clk_rate was removed from the driver, so it never got a clock rate entry. The DT assigns 19.2 MHz to GCC_CAMSS_CCI_CLK and the hw_params values match those of v1/v1.5 which were also calibrated for 19.2 MHz. Fixes: d202341d9b0c ("i2c: qcom-cci: Add msm8953 compatible") Signed-off-by: Loic Poulain Tested-by: Wenmeng Liu --- drivers/i2c/busses/i2c-qcom-cci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qco= m-cci.c index 19e4719f13b29b2cf60e113565b1b63f19d0e669..5f74edde8558382e63e2c3d0fbe= 19489f325e8ce 100644 --- a/drivers/i2c/busses/i2c-qcom-cci.c +++ b/drivers/i2c/busses/i2c-qcom-cci.c @@ -783,6 +783,7 @@ static const struct cci_data cci_msm8953_data =3D { .max_write_len =3D 11, .max_read_len =3D 12, }, + .cci_clk_rate =3D 19200000, .params[I2C_MODE_STANDARD] =3D { .thigh =3D 78, .tlow =3D 114, --=20 2.34.1 From nobody Sat Jul 25 00:44:34 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 491C14CA295 for ; Tue, 21 Jul 2026 14:58:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784645913; cv=none; b=XkTgywx8F13fN92z4iDV8tJE6nPky8MWfW2TCIuK/RS7d28F98B1Apa6+0zEGR51ZWMXQjBqi0uKt68+MGCKpG4wctG9RRLlXXVEIzzOllGi8bLFjWCyFjJWUEaqZ/lsofgRjFTlGWNwnMIBijVNMsRDOdGrQoxCO2QiMrDRT+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784645913; c=relaxed/simple; bh=XceuDuLrzakfs0zugQBbXJa+oizwCWt+Pl0ZpC7HxL4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ixuykkDFh/91RnzHDTNbdbZjk3u9MsZLTDxiPcH8c2LtsuKK/fd9+dwQifVkgA7V8Gi95bFwqTB5yFgMSY5avkVyPSVL0T00om9myyKSd6JnXUM7WV0xelLpiJObVipvjUIlv9qdxyTVV5t/QpFsvtj8OMEtLYMh0RtwhETXLp0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PDQZyP1a; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cttucgpd; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PDQZyP1a"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cttucgpd" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66LDg7FX1687576 for ; Tue, 21 Jul 2026 14:58:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= K+LK8F70ldltnOCivKw+ePZv3anat5mG9iynUsCcEZU=; b=PDQZyP1a+PemFjTw AQhSirae6PXtc2O2DukzeDWgNvycAuO0bHrzkHmSLrye89JVi7vw8X1lMdkd4EI+ cceh01uxqGDQcDrCpWyI2CVe4FWoRZh8a4HmhW9rqf+F/b4/4bgohBvzOESHiVy9 lhrjhfTVgqdU95qzXfXoCQ7C9EvNmIUCiBbynTq/AtNDB0qcFxzCIdeLxiGrWwOV rHub1ktrI+MP9fkmWqioGMWZE5LKKjN0CD8jGm7nFq+E1aXQ4pjbNf+wO16wfUI+ A3n4e6z9MoteF49osiSBFL3YkZ2891JCQSKKJSF0y/Ir+pgIEM2dBa5ZMb6UlLY9 MMUKvA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fj9c40h3r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Jul 2026 14:58:31 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51ebdfceddcso135932201cf.3 for ; Tue, 21 Jul 2026 07:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784645911; x=1785250711; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=K+LK8F70ldltnOCivKw+ePZv3anat5mG9iynUsCcEZU=; b=cttucgpdVfJoF9JdXhXeulndM4X+3SCgEt1z1DOs6BZDHKiYVCoVs0U2FE+wr3ecCU mTrbk7DKv3c/w4FaOFbTGDDZiuwrjYbC0f799Ze8JDRFsbTdQga2Uh4IvElxBeEp2zRw 6K5NwkS/5sp9G/vwWlhtQP0iHAn7rIBHWXpmwZ00WDESOisoACIHchiXfL7y9icM5r5I q7R9575ZiikqSr9F6S67J6zFGdWT+ehrkugQwoqJXQxvHAJ9v60/5AvHNtox7+pJomFH +48PfFVX+3AbvZUvDSX/o0nWrrqCNM9PSFzs4vr8CRD3bsKFRBe64sHMdhNKQgVSk1ox 1+iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784645911; x=1785250711; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=K+LK8F70ldltnOCivKw+ePZv3anat5mG9iynUsCcEZU=; b=Oys4/lWBzHo1cLsE2OX9ZPz0TozsZPFM8SPLYfzKymGM4/dxPaO/SAjvneajszgQCS F6IoHCa9KZnx1/ij/60A8kHGsnSxWjVkbx+YVJ7/q/m+NlN7zb6GI0S/qJ0ADKCJDlAG w/VZjTtQxM+1jQPICQB+r7bIEhDktgMfsCsZREp+qjcnD7yla0Vsh51STCbupoxzoihq 6d5aDB3Lpo33yGHt7FMCUHmVgLz/Zkc8g/Dz97L6mlP5NYEMQutpecPIJRlsCozL35qy TVhKpcmVmFYeVrO6Ogg5fDLvwHNx4iyo1PqYiFah8Khs5D6RkkuAedTS8H03RVY/XR+M cA9A== X-Forwarded-Encrypted: i=1; AHgh+RobGgsgu4xYw34uoPgRoV5bGjiQACe2zYSxvfDGKVNEPcne1SCmWw5F1ln/usnbPWh1HugnK92Qg7XG0IQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz20BbAMsCE3NH1DJ1ol+C8pq7CTGZbg6ZMHnDRkkD3nc4mKERe hHJWJtR5pS8YbyBzEW4pZ62Xuk+FxZn4yduk/L3/PQRBIs5ZoAPJQFErb52rrDHHMpuC6bjl5TQ 0YFllnCGRZpVRa1JIVS8oK0qwNc66uIrCvzeJXMOr6JsWvGV4a7+6FugOiNAPsfTvTZ0= X-Gm-Gg: AfdE7cmFjhvgI704dreRMeCO/REw8EuA/Jpx2oobctlosgjNMABiK/tKiskm5Q8qc4u A+XvWcUUKvs+XT1SIP1L9tetCIlcgE4kylqY572U3UMA2L6IJTJDU4hGGjL17ijXX34RvgVRRtN g+ked+5gC1lhCOYr2Pk1fO965IlQX/K41ITOH82Q4/mQqVIK0kd5Rb+QaN/us3ncDXo/m39k6lt 1V9/KYf5dXzN4pzWNbYBl+WC4dRae4r6WKTJek/JkGs8PSuI53PWhEVmTNaVfBpOBRluODmemeL BBADEjBElbxBcL7hxBeda6wnbuuXtCfTN8UF4qyP+0Tf9AvrPPrfPbQ2FZ6NbEb4G4lUNMeASdr zznVHbpPt7JNJzGEmuG+8FlGL7xyVZWx+kUWZ8fIB1bh9i9PIHyW3HQXxowXbD6ElVAVsNgSwtT 3PlDLlALl1oYn25437Cu9FYtpFqJfDif9sK1bAStjjqO6gG0zBBFg= X-Received: by 2002:a05:622a:909:b0:51a:8c97:938b with SMTP id d75a77b69052e-5213e190f97mr180208091cf.66.1784645909541; Tue, 21 Jul 2026 07:58:29 -0700 (PDT) X-Received: by 2002:a05:622a:909:b0:51a:8c97:938b with SMTP id d75a77b69052e-5213e190f97mr180207641cf.66.1784645909028; Tue, 21 Jul 2026 07:58:29 -0700 (PDT) Received: from QCOM-eG0v1AUPpu.na.qualcomm.com ([2a01:e0a:830:450:751c:d61c:c91:60dd]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69e6ffbba0fsm5875369a12.17.2026.07.21.07.58.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Jul 2026 07:58:27 -0700 (PDT) From: Loic Poulain Date: Tue, 21 Jul 2026 16:58:21 +0200 Subject: [PATCH 3/3] i2c: qcom-cci: Fix CCI clock rate enforcement Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260721-cci-clk-fix-v1-3-5eae78700da8@oss.qualcomm.com> References: <20260721-cci-clk-fix-v1-0-5eae78700da8@oss.qualcomm.com> In-Reply-To: <20260721-cci-clk-fix-v1-0-5eae78700da8@oss.qualcomm.com> To: Robert Foss , Andi Shyti , Wolfram Sang , Dmitry Baryshkov , Luca Weiss Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Loic Poulain X-Mailer: b4 0.14.2 X-Authority-Analysis: v=2.4 cv=I4JVgtgg c=1 sm=1 tr=0 ts=6a5f8917 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=fiHgs4EJ_qdzu2AaPLEA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: Kl9zmli9x4buLTvDoWbq5ilCj7N8gH11 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfXxN0leLySecjg RkOkB/igy5YZBdBDauXe0vV+QTqYf8NxFJnMBc5XWYCAu30+PyA96sWuaAfq3xKDVtjJPsj5Te9 nsTEcxCb50tIpeUMeX1VBV9JE3p7m7w943qyvb8agCZ43eduh+uxWht0r4FAgdWXWrqf/p6vrJr MnA7GS//guLKtG0+/k2CYQK+FI8LCOxcvr3GL6e2mDSC/SsaILawEw9aP7FSlHYalAvmccUhp1A dp0pJT+Xck8OyqSkttxdf60oex0Ahoo6+F8vYfNceum7OzBOMZjI9qLNf/ZygM5TVQWHh/yMFeF fDzlIj34GXNlUc5/hNdoVH2AhGPavdeqr0UoJPiE7dITum+AyjLC+ojDUHV2vFbqcS2JBebjSWj T1lILOqWpwugp+x6TMUtWgWgDqUMp0UevDolYDw5Y2FpM9uArkPA+DrLgtZEoSOiNbTHG/ASh5r 7umNY2VJgY96i0pRryQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzIxMDE1OCBTYWx0ZWRfX6yLj+XA4nmeJ q/XDAiN0v7a7iNRJ/Phfyb+UUq2QHJTaVX3OiugKWXaEpkmPqxzKq3HNdMExVWMvpik57Up2Xoe W94VOyxKbrhPKka+4Yr4OjS1uil1ZmE= X-Proofpoint-GUID: Kl9zmli9x4buLTvDoWbq5ilCj7N8gH11 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-21_03,2026-07-20_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 phishscore=0 bulkscore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607210158 The hw_params timing values (thigh, tlow, etc.) are in CCI clock ticks and were calibrated for a specific clock rate per hardware variant. If the clock is running at a different rate the I2C timings will be wrong, potentially violating the I2C specification. Rather than just warning about a mismatch, actively set the clock to the expected rate at probe time. Warn if the rate could not be applied so the user is informed that timings may be incorrect. Signed-off-by: Loic Poulain Tested-by: Wenmeng Liu --- drivers/i2c/busses/i2c-qcom-cci.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qco= m-cci.c index 5f74edde8558382e63e2c3d0fbe19489f325e8ce..e001c0d565cebd386fd67b1d9d5= 32360b29c67d0 100644 --- a/drivers/i2c/busses/i2c-qcom-cci.c +++ b/drivers/i2c/busses/i2c-qcom-cci.c @@ -519,6 +519,7 @@ static int cci_probe(struct platform_device *pdev) struct device *dev =3D &pdev->dev; struct device_node *child; struct resource *r; + struct clk *cci_clk; struct cci *cci; int ret, i; u32 val; @@ -587,6 +588,15 @@ static int cci_probe(struct platform_device *pdev) return dev_err_probe(dev, -EINVAL, "not enough clocks in DT\n"); cci->nclocks =3D ret; =20 + cci_clk =3D devm_clk_get(dev, "cci"); + if (IS_ERR(cci_clk)) + return dev_err_probe(dev, PTR_ERR(cci_clk), "failed to get CCI clock\n"); + + clk_set_rate(cci_clk, cci->data->cci_clk_rate); + if (clk_get_rate(cci_clk) !=3D cci->data->cci_clk_rate) + dev_warn(dev, "CCI clock is not at expected %lu Hz\n", + cci->data->cci_clk_rate); + ret =3D cci_enable_clocks(cci); if (ret < 0) return ret; --=20 2.34.1