From nobody Sat Jul 25 01:52:31 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C42FA372ECD for ; Mon, 20 Jul 2026 19:39:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576365; cv=none; b=Q6TBIog6GX7MXC/4TqAy52EQ/poL7zA55QaGXK6n56pPJlQJCMz50NH7LEoeDkoFbCb0hWr/mP7BblNhXVwte26Vq9lRfjJgPZPzcU+Hg6i0jGNTwSx4MQ64k0ZNJoTr8cwVIJaR/dKP4TeIzTg7On8v8fvp//SxB7NM+Z99MC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576365; c=relaxed/simple; bh=jzT/6FpjIwHOnd/Ocwox01XayWSBEHvjkvcK93wVLdA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=g/gs16WWL7sy1CW/B3uH+PvlTod1FAgv1BILSu+f0PCdUXq2Q/PYDs7nUMyYEeB1c4/CCOC8JTbig/0Is/MkFHOWMx9qbhxKsk/38QH0AgZYdfN1H/IVocy2NC6J0kOCHf7POUPrNef1sckeC7Kl2LYM8ZuhUKLDt/3c6LFwd5o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hIzJh9Ux; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hIzJh9Ux" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-c9fe3c9bd5fso2673852a12.0 for ; Mon, 20 Jul 2026 12:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784576363; x=1785181163; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qTUe4BSLEWJRqj/YoC7td2ZN8zxIRbPJjN8t5iaBH1w=; b=hIzJh9Uxa4OWq7imQ8VRoylaZGjwzo2HlGtmVMYL2SiDOw6hyTPgqJhGZjiXBmeXi7 wzVl8lCA9vShK41DLuUK3JBaNBVQxjn/btEKtK+dSphc9MNcD5pM1TGkZ8GsS49S5Vrm +DkDesb6xhs2xdGMBtBN8UPBX87H+oW6+/BzZUBJk+t6cp92zcqZRGdsEdjGKPlApl81 a2So04xtGoSV0HrGtpWDN0uNiIWqzgfNn7tvL3NbRxT3ujWrYJ02BGwjh+hN1TkINYqe SFOXTvssiE8I/JnT2mBPtThl/+IaJ7kNwwa5dXQ0SXHmGWp3knfnDMNmwUMsHIQw8Bvu hbFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784576363; x=1785181163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qTUe4BSLEWJRqj/YoC7td2ZN8zxIRbPJjN8t5iaBH1w=; b=b31lsMqu/O2N6huM/IRPDxd2gqlVfHPhJuRyVwwBdcYApQHPLaNS36oDbW6MfjC9fM cXzU5j0CdAnLVv9EDek6vIsNwq3iQKrq85oemcSjpKppRHZCkLsoi2fP5ueFVyEXqkHz C3fHPoINwjP0d9C43b2rtX3DvlPp7A/iPtOCuouXdsSDL1su+Z9SfV5r0zN95eczzDue 6NVazlXalqLRhtFUgFaUXmPqK7dUSZ0WgRP2zxYRQpWuHA59LTb2siOgZ6L5CoFwz2o0 xffOr672WP9I1SG9LvgB0WSFW+JRrcVa94I411SlW7FGD5r6MIM+qUi44X86Xbv8ztG7 D9UQ== X-Forwarded-Encrypted: i=1; AHgh+RoI3p9jNW8+NUuQFp0F0NLscrf7V71r7J3C8xlQH5fyY1A42HTSI0yGsVel5Ri6Zi9XcfWe/brNlhfU3CI=@vger.kernel.org X-Gm-Message-State: AOJu0YwqihLdIHkwh5rgDzTeuudq/MfXKUzf91w/Zm7oAERTPTG7btXF 0lGVmm/Q3swduP8KVQ3163AcadT2BpU6Q3/CT4JEVrvQcoO/enOtgspkraGK5B/WrQ== X-Gm-Gg: AfdE7cnlSqfnGUrrRiDDDE3ZdjNmzE9FnycciOR1mHqWK4Zl3iRofdKmgwejJqGNBzf UA+BykezzvWpppCP+1fCMiY8q8U2si1uB/2G2m0VbTkOafDrtiV+eB7iMPwK3im7vbwwgwJpKQu vvDA/Y5eF6ftWSOQcYNFjULNBUt9Ai2JBsP0ILijVp6bU/8Z8kgGxPSGE/PWhiO5jlmLeIo/suv 68AhZ3W/DyF+dpMOZ9cgkFVosNvidsVML9d/xMPYnRTJbFkhE4q1mxYZGkNn3JlIY9fg4FiiND/ t+mrpcO1orFeSS/AzFeUMpA57otXDIG5nkEPQNlaXiyysUY7VssZELRJIbj6wHQ5hwVoQNFW8bV PiZSRpWGl7yNK6iDpkx/cc9Cd1h3vMgflV9FNZsYgIkvz84Il2ZPS2pZnJ7lMmvgw4vO9eeNzKi EWU/chhH6OvPerWpfOsuPsdfoBw0FRTp6DU3z7piKk X-Received: by 2002:a05:6a20:da08:b0:3bf:b7e8:68ab with SMTP id adf61e73a8af0-3c38d8c9c03mr21850768637.2.1784576362961; Mon, 20 Jul 2026 12:39:22 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.64]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce29ffb13sm33935340c88.6.2026.07.20.12.39.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 12:39:22 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: Linus Walleij , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v1 1/3] iio: light: gp2ap002: Fix unbalanced runtime PM on repeated event writes Date: Tue, 21 Jul 2026 01:09:09 +0530 Message-Id: <20260720193911.74919-2-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260720193911.74919-1-nikhilgtr@gmail.com> References: <20260720193911.74919-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The IIO core does not filter duplicate writes to the event enable attribute, so writing the same value twice invokes write_event_config() twice. Enabling twice leaks a runtime PM reference, preventing the device from ever suspending again; disabling twice underflows the usage count and triggers a "Runtime PM usage count underflow" warning. Bail out early when the requested state matches the current state. While at it, switch to pm_runtime_resume_and_get() so a failed resume is propagated to userspace instead of silently marking the event enabled. Fixes: 97d642e23037c ("iio: light: Add a driver for Sharp GP2AP002x00F") Signed-off-by: Nikhil Gautam --- drivers/iio/light/gp2ap002.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c index 42859e5b1089..ea971fec0b56 100644 --- a/drivers/iio/light/gp2ap002.c +++ b/drivers/iio/light/gp2ap002.c @@ -343,6 +343,10 @@ static int gp2ap002_write_event_config(struct iio_dev = *indio_dev, bool state) { struct gp2ap002 *gp2ap002 =3D iio_priv(indio_dev); + int ret; + + if (state =3D=3D gp2ap002->enabled) + return 0; =20 if (state) { /* @@ -350,14 +354,16 @@ static int gp2ap002_write_event_config(struct iio_dev= *indio_dev, * already) and reintialize the sensor by using runtime_pm * callbacks. */ - pm_runtime_get_sync(gp2ap002->dev); - gp2ap002->enabled =3D true; + + ret =3D pm_runtime_resume_and_get(gp2ap002->dev); + if (ret) + return ret; } else { pm_runtime_mark_last_busy(gp2ap002->dev); pm_runtime_put_autosuspend(gp2ap002->dev); - gp2ap002->enabled =3D false; } =20 + gp2ap002->enabled =3D state; return 0; } =20 --=20 2.39.5 From nobody Sat Jul 25 01:52:31 2026 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FD8344685B for ; Mon, 20 Jul 2026 19:39:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576368; cv=none; b=WBLLO3Nb0YAAyeqn9G+XlQa6hBQ4Ari7z427ZlgU5tXIxBeKaO2F+xEKpMBgICJPu/9iS4o4A+9oczIjDpfmKZ3sspMbQnkRwJe0y0pHbKm5R8GdOjOnnkHXn0sokGMN1d1Pvt7Pt841SCNx29OmAOaZrd0YbYq7rGAyax9BYl8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576368; c=relaxed/simple; bh=BIgF/MBWBkH+YrQaMxoT9KyYaoF+iLuNvKx4PL9FFaQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=f6albZM7LA3eH7ehDH5ozokMgo4jwSq61QwBYBqG80667KmEtEo23voRkJhh30CX90bdJWta3AjPv5lrdQW9cAZhy24ZUndSwJ1nEINZbTfBB4nVBxmAEn1lhZITyXKKq0HW7LldcYyduyETv37D9xuBvo7xsmOrUdRwOy/ABCg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jhgh+rt3; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jhgh+rt3" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-38de840f2f0so6631814a91.0 for ; Mon, 20 Jul 2026 12:39:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784576367; x=1785181167; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G26pkiVGOQfvjhUhovAmEpMH2UgTqMGfpTU7jPDu8MQ=; b=Jhgh+rt3fxUkm4lKjwsoGfrDI/6qQ/27QJgL7mU6LLOFoiwOWzx4YQviwwlmV9hCQz m787Eg9X7GgCi6DlPYNNicHaBZnp3aXuqXguURISm8t2xnqSuyCIVOCmUDiHqsW2W02r bIi2ac93bj4l6xEAmcoZyZi5Z2ugZ7W/V7+UjyaST8Qqyc09cQXnDCeCFf+Nb9nHGwJ8 F3HFM3jwd5wtdA1GDmr1oqF59C4tsUN2iuBuU59A0D/ASjuBecTZM+2bx14g+h+PC3Vu 5SqUcaAkEJTxTYBlpQlWBFkTQ32N1JBaVJppht6aC6tpNa2C8qyYUuc4U8nAfFEod0Co 4Sfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784576367; x=1785181167; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=G26pkiVGOQfvjhUhovAmEpMH2UgTqMGfpTU7jPDu8MQ=; b=bDhIhahLiH1PnomO0uSmtAKkHRFIaPoZ+Yf4G6qnbo95LSODZ8pITrk0fW8xJ6TFPF P0daIr1UsxMr565CbKq9+nVrRwSI1potxqWiVYBmx289v8t68iA0q5bQGG6rPmrHgFQv /fKmbW5GEqnOcdteX14t4Z/RhA2ysH2HX939xf8VbGSlSZZVxYiS1nIWjWDxos0zZovU cXdByMlvttdh4AUhzKvh/lUNxZPd+sKgnyzXl/Bp/9XSGQRuvhTp7wpjW405RBa6B2La pflu9N1DOEK2A5grvH3ZegcqcHquGQzGJp7n8jWx5uOXTtaB4s8ZAKrKlAv3Un9wZLFi lCZQ== X-Forwarded-Encrypted: i=1; AHgh+RoVmy5xpUZj2HNWbJy6IPcB7/Yb24h2ZhUnKslq5wBMW5WNPXAEdubp5YxL82p9q2iIuF19x9F2PN3b/EM=@vger.kernel.org X-Gm-Message-State: AOJu0YxSDe8rUvJh51dFNX/piCu6nX8PmVSfLH8d6nxfGcSz7AU6HRkY Kz/09TkrKeDhsjRabkIF5HFP7MR7JBj14Sh0tAOTFmYDM3ai3Ahzjp0= X-Gm-Gg: AfdE7cmPxqz9ilgVCIhhmn/BKXWfnBs6IIWW/6vcryQ/NDL37Alz14atWCNonm55WRe GBgk4vBr1n0iJIsarII9msloVbFNIW80NXdEdN6iRxdUdV8GyYc6Bx/pn6JANxTYn7APhc7BY9O J2mvJNyqNYbh+JoaUnSQiJCI4qewcDRwRp0jpp1eWNAct4OJ9gQjlIRWJGSoRIeciJ9VCX8AlVp 9QKZbB9WTozM181XWF4YgJoWwytI2JwfbqnrgZApTFyxHVOHs+GgFsQNa31SbQ/Oyl8aYvpuSB3 MS+7x65HMQIBh87PmU9P8VtBpIyJPMe88/mSi4zqaAm3zWiK0YrcBXKm21tV/IZl4UA5I1ONw5z ePYK7h/EdUuBu4mm/7Z2Aqi9i6I1hIKS6Q/WFaZdoCwKR5HjptEXQzx/BvE3Eg4ITDXfofWGvfA zUNaVzxeXFB5DAbEbqyITwpIHv+MOIjjiXTi1g+cB9 X-Received: by 2002:a05:6300:95:b0:3bf:e2f1:1b08 with SMTP id adf61e73a8af0-3c3ad9717d4mr16450850637.40.1784576366686; Mon, 20 Jul 2026 12:39:26 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.64]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce29ffb13sm33935340c88.6.2026.07.20.12.39.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 12:39:26 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: Linus Walleij , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v1 2/3] iio: light: gp2ap002: re-enable irq if runtime suspend fails Date: Tue, 21 Jul 2026 01:09:10 +0530 Message-Id: <20260720193911.74919-3-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260720193911.74919-1-nikhilgtr@gmail.com> References: <20260720193911.74919-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" gp2ap002_runtime_suspend() disables the irq before writing OPMOD. If the write fails, the callback returns an error with the irq still disabled while the PM core marks the device active again. re-enable the irq before returning the error so the irq state matches the active state the PM core restores. Fixes: 97d642e23037c ("iio: light: Add a driver for Sharp GP2AP002x00F") Signed-off-by: Nikhil Gautam --- drivers/iio/light/gp2ap002.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c index ea971fec0b56..96dab4d1d8ac 100644 --- a/drivers/iio/light/gp2ap002.c +++ b/drivers/iio/light/gp2ap002.c @@ -650,6 +650,7 @@ static int gp2ap002_runtime_suspend(struct device *dev) /* Disable chip and IRQ, everything off */ ret =3D regmap_write(gp2ap002->map, GP2AP002_OPMOD, 0x00); if (ret) { + enable_irq(gp2ap002->irq); dev_err(gp2ap002->dev, "error setting up operation mode\n"); return ret; } --=20 2.39.5 From nobody Sat Jul 25 01:52:31 2026 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C0D244E053 for ; Mon, 20 Jul 2026 19:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576373; cv=none; b=LgU+dCsuOP2aZAeyadM6HuiwkKqF6uWIvdVGrlJ52V7E8ycDF6ONY9Uwya/Eui5onsu4CkaWQt9wgryVJvG/GpvkdPV+OlSvV8DFqC926wjNKFtzrMRMJ81HhkGAGIFLXBbbS3Ufo+H0GgbcNahENjh+wxndAiX9kutWv622DFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784576373; c=relaxed/simple; bh=E8m3m8XTS5TIoPN9299SRPXn/mLhXEctm+wdxmEAGyA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=siTkCgwnnT+QeyrE4GfjcCuvoWuVfIhMJgqixqHXs8lHUe8LKG9rJ7PuXxfr4eBk727wT6bhEATLCN7DY5yFX5WBiW+KqkcZq5NPrr7q7BYHFbVPt9yFrOnLqyTAutIOdUuMrqh6IpPkyWK3rUqABLDNhxjPGxFMrQ9Jm+ekvik= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i0Iswoh3; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i0Iswoh3" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-ca12086c06eso8757987a12.0 for ; Mon, 20 Jul 2026 12:39:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784576370; x=1785181170; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JpGuakV6/SQbZZ9011+gRtKsdWAwPDNjjQWuQfdvvoI=; b=i0Iswoh3ci5nQV+u7TDyOKtHPb5fURk0kOLXDygVTDd3/ZmUAtcM0sxmn+T2rM4Ktb G4+oheM37lFeXPdDHR8lIp0IeMke6JLZve2g1T/z0J9SfTnibysH6SJYD8cUKSYI84k8 a6b/L0gboiFMJaj0Otfn1hEr6s3zgKGbWsT2ATEExdJ8v76j5XaQUeC1MRxnRwLX3BDa RUZaWZkNCvqbB7OKKVy6LEuze+iQkOfjd6bly6LaIt9oF3xbHYCNRTT/mP8hKjKaSGnp yF3x7DuQe4YCmcvpu5Mc61jGh1TjjoVCfwFCwYMMujit8eSItKASFEHXS/I5P5ZStb95 R8yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784576370; x=1785181170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JpGuakV6/SQbZZ9011+gRtKsdWAwPDNjjQWuQfdvvoI=; b=M8nES78ux25tecH42TLkiqpnymAIN0xYS2adQK29NPvsT714r0L38kreRmhtULvB4G 7Z1nWAmsFfF8iIQYbkaVnenzDl1gFFbITEpVlNHLO0I4WFiNI8/uSazOrLfkdi0utLpV 3TSRJ84rdhPWl3RgN9Hw3144PiNI3g/WQlL0M9yOdMCyQYbRnYgyf3erQQzv3Y8nAiLM FZhHaXf7yvMMtK/gw4OPFUZMc3zuLqcIR1juOMFzZa0g76piPAo2E+FfNwXbxEnH0xkK mZDo2Sxjg7LCI3q7t9HX456I7mEwSdf/3sUTVhg/4i+MD30kj6sEzGO89qcfHxZXYaFr Ef2g== X-Forwarded-Encrypted: i=1; AHgh+RpkMN3UktGQJD4xMlEN/FSohnJyKgF7fbR9WPm5k+ilvmLF3fw3/uc7IcypErtnT7RTnQCmgEGs5RWK4aE=@vger.kernel.org X-Gm-Message-State: AOJu0YweZsdX+iiC/0KCN+CzSacOqueVo9//5P4CF4E/JaxmtqDIceWn CdqjC8GBrSgB5Z8P738TPNIWXGEGntPOx4fJgiz+JL6/rODy2GxN12LziIRbY5rklg== X-Gm-Gg: AfdE7cm/4FbYjiXKaYNb8FrQc2uiUXSHcb1Ju5fOE7rKQTrkJJH9FV06rikeIsh8vDj CGRnL8iLO4XKmZKQLCzz1zsqSxES0Hob9U3Z9Gj5bf9kKvWv6ECx5GH0lRAvSL3z1XUCWGGsr83 1xBHbUYJEXvKT9xgAWHqG3cjzvg9sDiEj5Q5xAkPqiBf6wdeGBh6POLnPuhAKtCP2lp0KP1hFCr y8kp/TbFaekwE3mwE8Kb6nw5U6gc5tTq17pB4jimVM179UoRIWeJheHSo106EwyNsOvwkTFqnSV 8xTxsA6Q/JpDqOU1jiqryo6BulWpu4cpJjd/DJbG3Pd9051bjQJJOygSSY26JZ8AaUX1NYAPWPD +R3pXRbfcaTLx8C8amlsFgh1mQCtduhhTD3toh4yyezhPOijpsjqENLBwMr25B5KhB0RaatuIW7 E9k4KBF4cgE7ITrnvqhthLKys60E2vmJJCnKRKpv9f X-Received: by 2002:a05:6a20:9397:b0:3bf:6c08:fb94 with SMTP id adf61e73a8af0-3c3ada37416mr16404386637.54.1784576370328; Mon, 20 Jul 2026 12:39:30 -0700 (PDT) Received: from localhost.localdomain ([101.0.63.64]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce29ffb13sm33935340c88.6.2026.07.20.12.39.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 12:39:29 -0700 (PDT) From: Nikhil Gautam To: Jonathan Cameron Cc: Linus Walleij , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Nikhil Gautam Subject: [PATCH v1 3/3] iio: light: gp2ap002: Fix regulator leaks in runtime resume error path Date: Tue, 21 Jul 2026 01:09:11 +0530 Message-Id: <20260720193911.74919-4-nikhilgtr@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260720193911.74919-1-nikhilgtr@gmail.com> References: <20260720193911.74919-1-nikhilgtr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If enabling vio fails, vdd is left enabled; if re-initializing the sensor fails, both regulators are left enabled. unwind previously enabled regulators on failure, mirroring the error handling already used in probe. Fixes: 97d642e23037c ("iio: light: Add a driver for Sharp GP2AP002x00F") Signed-off-by: Nikhil Gautam --- drivers/iio/light/gp2ap002.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/iio/light/gp2ap002.c b/drivers/iio/light/gp2ap002.c index 96dab4d1d8ac..b6dde3dce39a 100644 --- a/drivers/iio/light/gp2ap002.c +++ b/drivers/iio/light/gp2ap002.c @@ -678,7 +678,7 @@ static int gp2ap002_runtime_resume(struct device *dev) ret =3D regulator_enable(gp2ap002->vio); if (ret) { dev_err(dev, "failed to enable VIO regulator in resume path\n"); - return ret; + goto out_disable_vdd; } =20 msleep(20); @@ -686,13 +686,19 @@ static int gp2ap002_runtime_resume(struct device *dev) ret =3D gp2ap002_init(gp2ap002); if (ret) { dev_err(dev, "re-initialization failed\n"); - return ret; + goto out_disable_vio; } =20 /* Re-activate the IRQ */ enable_irq(gp2ap002->irq); =20 return 0; + +out_disable_vio: + regulator_disable(gp2ap002->vio); +out_disable_vdd: + regulator_disable(gp2ap002->vdd); + return ret; } =20 static DEFINE_RUNTIME_DEV_PM_OPS(gp2ap002_dev_pm_ops, gp2ap002_runtime_sus= pend, --=20 2.39.5