From nobody Sat Jul 25 02:13:06 2026 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013037.outbound.protection.outlook.com [40.93.196.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 979A33DFC67 for ; Mon, 20 Jul 2026 15:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784561931; cv=fail; b=fYcPt0CKkNypP8TygvHfL5dtNxZljYPrnFz2iN6eW828quNpq9XEN3QrBg/hUBdJTLZfWRa07LKUnBxfPik2NCAACt95RpWB4oneeeqV9pXiHO+EWjGMgCGiVBGo7Qds3oDsEsooDgKGTEsMzf9lzLs6+Mm7iw+IvEWfcneGrmk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784561931; c=relaxed/simple; bh=aWh1LdvINuRsbFlhH8jOw4zKf9Ygs6OwGuyQEWHIhjA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=d0VWm203nSaFbaVzgwAZ6lEJGP5oZz/yqknhhJaOJLAp6+8zLbpcPqSSVMImj34+2iX0R10ccZG4MFYuBUCCq0KjdAV7Lpf5TJ0LEBdLYpklc6PTyDLWtJ5XmnN46gT4qB873UvbKwHI0XzYt+3jrt74vn0ydJwmgIf0yG7wLjQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=ji05XsFd; arc=fail smtp.client-ip=40.93.196.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="ji05XsFd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=WNFEaDLSOU8cCXs6jaPPZcRXJ9HPQBKB6BtV3ZbwI1QayoDOtQ/pFgoBlkoMRTNLzSQevUC6UVX84/NaizhMJ6b0HPQuzGVc6yskXfGq1BTUjupsoJ0fRlz5LGhVhHpWiJmsW750jwI2ZR9/AQ5pFRajJv0Yj7JSX1yB5gaHTVN3XxwSd6ZWUViCd1Gu/vNys+13fNeQEkv3OwEJxEyd5aC3Agz4Q8nzmbO2hbv3OnnAYeQOiVFNszrwvhJnQ1kNfbQdnAeBwNFlgkPFFoRPLjGoRZY8v9V6FB5oGpI31kWlfH/WPiiLX9QyLN06H6BI0qtwTVvgHVhK4jrVDa7fzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cgF0MEgU/30tU1I7r6J7cVBBky2HrgoOTg461cjGO9E=; b=ueeQpjCY5FiZ4U7Npkzy9LBksrwjb0YyhDPPIEXMbSyzWbpJHhv6wsqM1R2mkG62XmF3KZjwxhZWZxvE3Wl+gtsnE7F9sqR8Fu9QuiPtMoxr4moo4vh1nHk7pDJxYH92BMcxRva/guNouMhCAb1mqafaag9ROPKx21ys/wlX0nOB8YcaGIvI+B77kIUaThuySZ5TTdyBCIHLODzxEBHiEPSvNaPd76PZhIW8O+mWcYJuxsDh8wQJ++4XrwDOFr5tuZedUTV36xe5N70bqVef44hliA4NZxLyMyLigQT6eTfWWpBLSd4qDVxvxL5G1m5e3CE/lxWxjjCNEiLK/D83+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ideasonboard.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cgF0MEgU/30tU1I7r6J7cVBBky2HrgoOTg461cjGO9E=; b=ji05XsFdJ3d4qNIKJUsmz3o9cGOEd+DDkWaPIRSXifi1/qujcwYMzS4MqYmdcuPbs5budYYkFkpAcleOHMYcTcGiJ1OpKK64+zcnSBjWTB1lh9TNbS2FsfmWxR/QYALut0iGWvysymca+9ud8ftnlt+vpue5agtIHbR3UfaoA58= Received: from BN9PR03CA0455.namprd03.prod.outlook.com (2603:10b6:408:139::10) by MN0PR12MB6296.namprd12.prod.outlook.com (2603:10b6:208:3d3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Mon, 20 Jul 2026 15:38:46 +0000 Received: from BN3PEPF0000B370.namprd21.prod.outlook.com (2603:10b6:408:139:cafe::99) by BN9PR03CA0455.outlook.office365.com (2603:10b6:408:139::10) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.223.18 via Frontend Transport; Mon, 20 Jul 2026 15:38:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BN3PEPF0000B370.mail.protection.outlook.com (10.167.243.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.0 via Frontend Transport; Mon, 20 Jul 2026 15:38:46 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 20 Jul 2026 10:38:45 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 20 Jul 2026 08:38:45 -0700 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Mon, 20 Jul 2026 10:38:42 -0500 From: Radhey Shyam Pandey To: , , , CC: , , , , Radhey Shyam Pandey Subject: [PATCH 1/2] phy: zynqmp: fix clock error handling in xpsgtr_phy_init() Date: Mon, 20 Jul 2026 21:08:30 +0530 Message-ID: <20260720153832.1130006-2-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720153832.1130006-1-radhey.shyam.pandey@amd.com> References: <20260720153832.1130006-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B370:EE_|MN0PR12MB6296:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c748e05-6862-42a7-ebc5-08dee674fcb1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|23010399003|376014|36860700016|22082099003|18002099003|3023799007|56012099006|11063799006|10067099003|6133799003; X-Microsoft-Antispam-Message-Info: Hs+80azgXeP9rqC1/NVwuNnpS86ZRhSCf2bVEZgLJ9mkcgs2UZBoin/eyR38ASTbzK9qYRHpJq+YBcZlgtbFU+HDQe1b+zTHNoReo2JtwPGos8/D3tGTR8fN3YcmO1e0BFEb9leyqVvbBv8OlLPF8fXDbEKlTTE+gZl4EcNiJyaqFdQMfds1eB1raNSRmj/5fhayaOmeSdEl8C+sXZy/GQ2ualIiJIMmulI+W53fPxriJPbPp92fgNSvWPDP7Xt/J4CyazLGo2Vq1rnn/9H3Wh4Um9KDEu1VrxU3xps3SkCN13bDByJw1L0S27z/IJEn2+jWGYDhdTswfyoA085j014zht8BE8uCAs1AQHwWNixys8Wh9Uc85iVjhHS16xHB9Jtr6AuY2eaP/Wy9SQcWbG8jC+ChmsYHzHfBCr2pPQ9YmIBJFt12jmVmD8L63HnCgcDnSpCXDC/HTA+tHzmV1Q2TwipuvTAXJcGPy5xADKPeM//Og+cn5quJZNtqlpCOp3rQGNvwTXO1vF7SP0l7/5h2ObeO7HVfZXKrI/jqfzWk12Gdj7Cnfj3uWRXzCGhrOSpG3Yh3daW3FZNKBAkS7so1UJI+tmzLfXO4/t4MpyQ+fCHZWIze9jNhYieSQryPAyS7/3LysylriTXSRc6Z2zYPKZn8pOIabv6IpxPpKuSEoUcwp2QtKZBLJbx7G8J9xLtaw13J9/gY9AfOCigz7g== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(23010399003)(376014)(36860700016)(22082099003)(18002099003)(3023799007)(56012099006)(11063799006)(10067099003)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: D+xEC5Ps1vzhkaX46zuQwupr57YusVGeMGbALvO5O24yweGPdOYXNMwwiTkmSG3yLyfVTuQgT4Pm0XTpFLnFIt9NjE69sYRkAg/av+HW98UUVZqJKTMT84t8+UDcvETHqMYYUU9JuEJHTX6KEJuOqwblaZ0a95t5TQ7aHQqIOz4gLiqwhmoygOvbmcO84+8N0vOLaClQR0SCDlVJSEpjypBLxZ/VTyR9xYl3FCQTFb3892wlWR3ooXme0M4D7FH7Khhs3JIbJqOz24YnZeiI+Jz1e8KUP/kmNsylZt5q4sgVqLq56TLtI+bN9avDcEuaCcP0Xc263DC0EBNpzxx1tBTfdhZtF/N6zBAKcSqaJ/m3gi29pDm18FI6J4RF/Teuf+VQtvUDc8aE/zDgm1GV5ziBExLSvEK1vmzlOHw80aNAg6q1DtXAGOlFKc8BpuH2 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2026 15:38:46.2872 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5c748e05-6862-42a7-ebc5-08dee674fcb1 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B370.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6296 Content-Type: text/plain; charset="utf-8" Propagate clk_prepare_enable() failures to the caller instead of returning success, and disable the reference clock on initialization error paths to avoid leaking clock references when phy_exit() is not called. Fixes: 25d700833513 ("phy: xilinx: phy-zynqmp: dynamic clock support for po= wer-save") Signed-off-by: Radhey Shyam Pandey Reviewed-by: Michal Simek --- drivers/phy/xilinx/phy-zynqmp.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqm= p.c index fe6b4925d166..c8230f2bda62 100644 --- a/drivers/phy/xilinx/phy-zynqmp.c +++ b/drivers/phy/xilinx/phy-zynqmp.c @@ -658,12 +658,13 @@ static int xpsgtr_phy_init(struct phy *phy) { struct xpsgtr_phy *gtr_phy =3D phy_get_drvdata(phy); struct xpsgtr_dev *gtr_dev =3D gtr_phy->dev; - int ret =3D 0; + int ret; =20 mutex_lock(>r_dev->gtr_mutex); =20 /* Configure and enable the clock when peripheral phy_init call */ - if (clk_prepare_enable(gtr_dev->clk[gtr_phy->refclk])) + ret =3D clk_prepare_enable(gtr_dev->clk[gtr_phy->refclk]); + if (ret) goto out; =20 /* Skip initialization if not required. */ @@ -673,7 +674,7 @@ static int xpsgtr_phy_init(struct phy *phy) if (gtr_dev->tx_term_fix) { ret =3D xpsgtr_phy_tx_term_fix(gtr_phy); if (ret < 0) - goto out; + goto out_disable_clk; =20 gtr_dev->tx_term_fix =3D false; } @@ -687,7 +688,7 @@ static int xpsgtr_phy_init(struct phy *phy) */ ret =3D xpsgtr_configure_pll(gtr_phy); if (ret) - goto out; + goto out_disable_clk; =20 xpsgtr_lane_set_protocol(gtr_phy); =20 @@ -705,6 +706,10 @@ static int xpsgtr_phy_init(struct phy *phy) break; } =20 + goto out; + +out_disable_clk: + clk_disable_unprepare(gtr_dev->clk[gtr_phy->refclk]); out: mutex_unlock(>r_dev->gtr_mutex); return ret; --=20 2.43.0 From nobody Sat Jul 25 02:13:06 2026 Received: from SJ2PR03CU001.outbound.protection.outlook.com (mail-westusazon11012001.outbound.protection.outlook.com [52.101.43.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0857D317150 for ; Mon, 20 Jul 2026 15:39:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.43.1 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784561945; cv=fail; b=tbOO2bquPaOqC7tDGDl49uXCGKxKHwCfK0MfBhpUuOF5aiNMYhzAHHnFvj23EKMnUIMkzM3QQUp0Vi9PwOyXrjLRdr9+M8CXvIWIN7IZwrum43nrZD5gCK996u88TrMBGGZON1UK+BNC/KJDcakrc6qsHI3KDyt64u4ZqAEsADo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784561945; c=relaxed/simple; bh=q2v5l76RDomb7RUSlmkNq4qacp+HfAyRAKubGQ3E27U=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qalbcXdU/HzBbpm+LvO3qORCy+5443LBtdjubmIV9SQYY4l77u2fXqXUkIQCrL3QVtWkpyWiRdies87aRuNIhtHH1SZX/t/EtiDBcLdORHqESFi46BVwuCJZ9YTJsWPwqdeyoo2rxzhTf0qEwR7bOBHO2l0g7JtVvuS4LjIvtxI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=pRkkiGlX; arc=fail smtp.client-ip=52.101.43.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="pRkkiGlX" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Uxe9hHmoMONG1lL6HAjPCpXPHlEzqyhExBieP/nofYKC02JwTCL6uI05dJ7xakSAm0jUgntNzq57nD/0hiyh0CeA7aetVvor7Vc/CsDrt/ciN4dj1IK99NASRfQIqUg0SYjP3ethSUxqr7lM0vdsxWEFdmhfR+GDUXcWn78yvrOML6iEORNNjIz6X/SYk8m9qcMxdbNWAeQQgDzcFn9JTr/mapXAOB9DOOv3AHmjnMXQhzT17IQNPjQ+7ot8+EqsRwGLD5ssNkPtcTB6TSH1N61hYJPEPtG+Li4MibIivUCXTrdInrYsQtELFcXMsG7E8Mqh9L9gLpzBs7C42TBuZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZMNOYxUC8kBKSOdWY4LhqBSiknKEQlKBIbq61EienwE=; b=S562hdTY8UWJmyl3nTSknVsxDtvJSd5nDL6oPI8HXsLisQflKasxS73H09+2xXJwoXTm2M9lv+4zMyWfVhti5VE1egbSxekvVIbhjEd7CD1Zo/8VZTjoOqyY0c15zChFh9L4ndH5s8wl6Tc54Jd6P/6meGMQPkht5kIw487rF+FML5odhOHwKfrv4oq8d4cwnYSxUIiCjY08EAI3iwOdOEYX89hg9RlSe1MeR0DNgGZjyn7i6ex+wj23R7oVGjqvxnIwhY6zuFjQDAU4jQwYuT1JmhCAWX4qHna9MuQFwcxAqsOiFGXWBMnBOLFq/8YL4zMhz5My+xpm3u8Yrvnasw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ideasonboard.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZMNOYxUC8kBKSOdWY4LhqBSiknKEQlKBIbq61EienwE=; b=pRkkiGlXOLHvnlQw4LZpEotg+dw8NUpRaJcWYqFULf4F4pJoGk7ukYPBAitnk2mWYlNfJBLEpsJzjb2WcxhT69JIvAUSa7njZR1X+WpIdRrr4L9JOrE4BRqMK4Zd5TSs0VwoJWuf6ZHd5Bq6S/Xx1tKdUhEpCgGrY0XaK11g80M= Received: from MN0P222CA0005.NAMP222.PROD.OUTLOOK.COM (2603:10b6:208:531::8) by DS7PR12MB6094.namprd12.prod.outlook.com (2603:10b6:8:9d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.18; Mon, 20 Jul 2026 15:38:50 +0000 Received: from BN3PEPF0000B371.namprd21.prod.outlook.com (2603:10b6:208:531:cafe::77) by MN0P222CA0005.outlook.office365.com (2603:10b6:208:531::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.223.18 via Frontend Transport; Mon, 20 Jul 2026 15:38:50 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb08.amd.com; pr=C Received: from satlexmb08.amd.com (165.204.84.17) by BN3PEPF0000B371.mail.protection.outlook.com (10.167.243.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.0 via Frontend Transport; Mon, 20 Jul 2026 15:38:49 +0000 Received: from Satlexmb09.amd.com (10.181.42.218) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 20 Jul 2026 10:38:48 -0500 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb09.amd.com (10.181.42.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Mon, 20 Jul 2026 08:38:48 -0700 Received: from xhdradheys41.xilinx.com (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.41 via Frontend Transport; Mon, 20 Jul 2026 10:38:45 -0500 From: Radhey Shyam Pandey To: , , , CC: , , , , Radhey Shyam Pandey Subject: [PATCH 2/2] phy: zynqmp: fix runtime PM leak on probe allocation failure Date: Mon, 20 Jul 2026 21:08:31 +0530 Message-ID: <20260720153832.1130006-3-radhey.shyam.pandey@amd.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260720153832.1130006-1-radhey.shyam.pandey@amd.com> References: <20260720153832.1130006-1-radhey.shyam.pandey@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B371:EE_|DS7PR12MB6094:EE_ X-MS-Office365-Filtering-Correlation-Id: afca6672-7464-4d02-1326-08dee674febb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|23010399003|376014|36860700016|22082099003|18002099003|56012099006|11063799006|10067099003; X-Microsoft-Antispam-Message-Info: FN+yVQTym+mODthaEc7888etRbI1yKKwZWaYk6e+oCel+G1N8sVi8XQKJfFO+dsCOadjeXNxV0dFmOBm5ohAE+vz4E54DJyhECdqTKeIFo6bAmIHkbQyvdhhr+4/rrpYT32e5G8B2CO7r50ZDAauA4jiUY6MvEhFnUFWLzO8JISNfeTbypsj56Rpy7CMQhSqh/KjwFfAIYV+9z6Nb0AiuGz77NII0j5O4Ua9a8wi+HwNupnEtdTPSRa1Xj5Tq02/LjLu8MBSkXkeizyiWYvMDnkBG4xCNu6UERrG2Jf9vD1h1dENPwc9Sq06dBEcbHCOwo1L2CNAasuLL9RNRX0foMH20mnxtlQagw8VGsquH1ZkGpB6VadNvdCuB3Z/noP5YzGwFzgNKzWVGs+iWmDFFgCNvrCCyzR8Mw8JFReyW+ZcYtmCgFnSLONijShkGA10Wwco/AGmyYgoit8EOr/Zty4JuVqOA9Tbq9LGyC0VmXDzfpMsaUvIvUMNBWd3xu5EWL6jFX3ex8IW+uU9XqPNgJj6uewv8JnKPCK3TCaKmZGdseYh0eVNWYw9mQ9TZbV/u0BP5oQC9FNQpYWKe5+WDjDdDEKzH1kAc9yQFRJNsSsWsydyicWv2golPSfN1UK85hEh0dNwSpPg0zdEPbPt7BHic4wIs+I7BswJin5IvgEBRfHSaapUdlZx2ao8a5LzIMaPvyfCr1uup09MPD6/Tw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb08.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(23010399003)(376014)(36860700016)(22082099003)(18002099003)(56012099006)(11063799006)(10067099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: P5Ltnj49SnFVkGD8SH2YDMSqfIYF+l2TdaFcrvPAdkI6052zT889S/ssbhE3iApFemipmdHqm6zseYKSdFk8Okk3rCsWBQAviz48iryyUig/EUacdJqGxDYeZKblpNO4cuwrGFkW+xuLQkUJRro6XHfKIT7wFS5/ZP/GcC++VA2SNrigoidJbl5VzCfD2D3LqaGB8Z90GmgxJT2BtmtCQbLVvCm/Jvmxkn9BU7VfALwXbrIUNENdgt0iWszb0KJNvUv9HPeskartFPRn4MBkoxvikiJNERx2hXwsMnre+7m/tv27gf9S0ptqZmD9J/vVQvSgmjWi26ovhPpz2QGR4scA72NzYLvSK1gyNh9AvODLM2BG2DrJZhGjr9sy5nRqlvQz/1mjy6JJ+kLnf2dS7kklk7xbXXnwfiMnB0N4UjVY3PdGoeyfspPve5bXwX92 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2026 15:38:49.7003 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afca6672-7464-4d02-1326-08dee674febb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb08.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B371.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6094 Content-Type: text/plain; charset="utf-8" Allocate saved_regs before pm_runtime_resume_and_get() so a devm_kmalloc() failure does not leave an unreleased runtime PM usage counter. Fixes: 5af9b304bc60 ("phy: xilinx: phy-zynqmp: Fix SGMII linkup failure on = resume") Signed-off-by: Radhey Shyam Pandey Reviewed-by: Michal Simek --- drivers/phy/xilinx/phy-zynqmp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqm= p.c index c8230f2bda62..2138f5399821 100644 --- a/drivers/phy/xilinx/phy-zynqmp.c +++ b/drivers/phy/xilinx/phy-zynqmp.c @@ -1044,6 +1044,12 @@ static int xpsgtr_probe(struct platform_device *pdev) return PTR_ERR(provider); } =20 + gtr_dev->saved_regs =3D devm_kmalloc(gtr_dev->dev, + sizeof(save_reg_address), + GFP_KERNEL); + if (!gtr_dev->saved_regs) + return -ENOMEM; + pm_runtime_set_active(gtr_dev->dev); pm_runtime_enable(gtr_dev->dev); =20 @@ -1053,12 +1059,6 @@ static int xpsgtr_probe(struct platform_device *pdev) return ret; } =20 - gtr_dev->saved_regs =3D devm_kmalloc(gtr_dev->dev, - sizeof(save_reg_address), - GFP_KERNEL); - if (!gtr_dev->saved_regs) - return -ENOMEM; - return 0; } =20 --=20 2.43.0