From nobody Sat Jul 25 02:36:25 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9A82400DFB for ; Mon, 20 Jul 2026 12:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784549364; cv=none; b=dzhQBvdifqgTJBbm9Pfkb0o3eO9yU0B34QOPAlPYM3SEnGtQpWCr22RTvTeJofksPwGOoFT2DPBLSq2Gp+fvgVLhAVDBrxKe56r3SQLJocxc4iN3IuwxKmDMyFeL0lC9bSPVqL8riMRxFWdLYwx+nK+Q0bKgGEYYplKlUVm5twQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784549364; c=relaxed/simple; bh=FRfkHxPsEAD8IWsYmO1umBKwlvTr0WaVJzxvcIY2new=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ky4Xtqle5mT3jFTmpgTsRPX4wiD1bOqUzDmJLS6xB0K1v3P/PishG2u0Gn5KVIobXXjf85/wVWHQPzYGMNQNlP51UAk2KVvOAkuCbbVuNrdHDRd0tOTcpXm93f20AtjG/8F8gGrRbQ1UC4tqULWgt3f5Jq3K8moSPE4+vzAUs18= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=VhcleCls; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="VhcleCls" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-8453427d3f4so9145253b3a.3 for ; Mon, 20 Jul 2026 05:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1784549359; x=1785154159; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=uRnYHwYM2fL3oV4HDL3np+Jg5FTK6wxzvLlmHP7diCg=; b=VhcleClsU42KNQqckwGMgUmBBdlcb/eb+SJlB8cMxrFHEudULjcRXE6XBWKvEOwptM fStuF7ocK5CMIIKSlekDlFErChZuGiLqQniSZ5OgQu2TBQ9V1ssl+2zKHMdZOxYBJrrv 34dGfwV4nwDbQdsAGbpW8F2vGCxfdZyKUaWiNFEWMVCUhB7KpGxtZP3gYXUELXjwsX45 7ilM4IuU5xWs7EjytVEjUAn27q4W5RQ5gYpKQdQAR7ygN3wSk8tIvgYjohGY+vaxWwhG B2ZoqV9+uXr40Bb6F4nKDXeL/Zx69YT2viGGi8rFr1SePjUMc0ZEdWhSzlxw+tRYlnBY q90g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784549359; x=1785154159; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=uRnYHwYM2fL3oV4HDL3np+Jg5FTK6wxzvLlmHP7diCg=; b=iq0d/4n5RPllc6NPHSyxF76Xwbk2Srb18n2dQgAW+EwYI3yA/LhHcPrNKQtX/LrsJn GgS/OkFUqGZP7qtkHtstvv342DJ8Lrupan0bM9llcfmPkt53xaX3HTE4gS6oXCFNcz53 pRXVPTZMaj+IvKYNX5XA9LDzBmJXda5y0tcCoxi4vJaqCwyFX8NVonuGsxYkLJKBwx/N oR36ng+zx4Td1xDZuPxZRtXfsToGgrsD4V9vhT/e/swiRHe2jvysQS69VSnCB4LEEkId Shtyx0Eot/srTMkFcj7YaXHFpfwWzT762wbDdsUsNbG71gfz1+0PIpGbJvpJolJwjMel x+bA== X-Forwarded-Encrypted: i=1; AHgh+Rq5nhY88lO0fnHI/Zv0p3UQKOOQHGw0T5IS3NFBjE419b5jKQHoF02TsevwtSsHjbmfFeQk1nYE7U4GpEU=@vger.kernel.org X-Gm-Message-State: AOJu0YxCnX+snQ57lYm3MSJhlsOvnzjIiHfGBwR+zIawBEkKKsA5jaZP PTR9L+0FZbEpepHAizVukgULeMSkdv+4iS0h9D0o5gwAVhdFDV5k/Na8+7iOah3CLwQ= X-Gm-Gg: AfdE7cmfxY0jVm7WWxNQoyM7UQAStKgB5DLgom9QJnHTnRBgqp906/bOkTiZEb0L/Kw Oq1NZA63AU9bBWsNItAvh3RJkFK+WZXiMzKuj5Rx/suyXwRF4FizjBZkVlJbjgbEbbTzOWU5aJ2 +6HVX40Q45m6/91youFTJYQNTFHrXbEzuOndlAmfR34ZBH3SXo+GF0g8XJzxspB3xFXRSgKKh0m Pwz1CtQDfzM+UTkyxQj1v04ynK2xuez3cikHcLb9LjfjaieCEgN0wZK9PMfiZE5Se87Cad/OVRf g+bflsRwvdwSukeQG31CdhxuXcWBwtd6y97DgEWxKAY2AAx8ydyTU0L59Fblj7ZgeYAsOdiRhco YU1Z/jxBLbj1j9nsNlssO75OJvJ/g/BsqTwx6OGYUAdgJ3qfqIVVJK0fV9hPWYXOw9QLJlNg7ch 4jaxwYoZlBc8Wyi1JivOixDipdANHjBYK5o9vkih73i+36fqQGsju3uz6WvibSaRLBZclGbMnpr pOVBq4ICpBy29F3S2WiBwRRD3Wpv+X/ X-Received: by 2002:a05:6a00:4d81:b0:84c:4bf4:10c3 with SMTP id d2e1a72fcca58-84c4bf413fcmr4991521b3a.38.1784549359461; Mon, 20 Jul 2026 05:09:19 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-84c2abe3e23sm5554162b3a.0.2026.07.20.05.09.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 05:09:18 -0700 (PDT) From: Abdun Nihaal To: bryan-bt.tan@broadcom.com Cc: Abdun Nihaal , vishnu.dasa@broadcom.com, bcm-kernel-feedback-list@broadcom.com, arnd@arndb.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] misc: vmc_vmci: Fix potential memory leak in vmci_event_subscribe() Date: Mon, 20 Jul 2026 17:39:07 +0530 Message-ID: <20260720120909.80019-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for struct vmci_subscription (sub) is not freed in the error path when have_new_id is false. Fix that by adding a kfree() call, and moving the read of sub->id to a point before freeing. Fixes: 1d990201f9bb ("VMCI: event handling implementation.") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/misc/vmw_vmci/vmci_event.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/misc/vmw_vmci/vmci_event.c b/drivers/misc/vmw_vmci/vmc= i_event.c index fffe068a26eb..a7f7363c577f 100644 --- a/drivers/misc/vmw_vmci/vmci_event.c +++ b/drivers/misc/vmw_vmci/vmci_event.c @@ -181,14 +181,15 @@ int vmci_event_subscribe(u32 event, =20 if (have_new_id) { list_add_rcu(&sub->node, &subscriber_array[event]); + *new_subscription_id =3D sub->id; retval =3D VMCI_SUCCESS; } else { + *new_subscription_id =3D sub->id; + kfree(sub); retval =3D VMCI_ERROR_NO_RESOURCES; } =20 mutex_unlock(&subscriber_mutex); - - *new_subscription_id =3D sub->id; return retval; } EXPORT_SYMBOL_GPL(vmci_event_subscribe); --=20 2.43.0