From nobody Sat Jul 25 02:43:54 2026 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30F2040488E; Mon, 20 Jul 2026 11:49:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784548167; cv=none; b=H8EdySxafgXNDGoaEQ8lvzdjuEDizTFSeiRoexad66HeB9MoNiXKOTU/0afrAni1rDHZgABzd7GvnPXrKIE/lVFCQm8wf5Nj/sZblQes4LwB0nXCFOM5KTZQcQJpfqrWc0HvCIoa1TaV5qLQ9k56wFQmrhBWYJoOvqqctD0NyG8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784548167; c=relaxed/simple; bh=tcbTfr2WNI/JmJx3inxSW7jv1n60dWwlyOH4Wa99Nt4=; h=From:To:Cc:Subject:Date:Message-ID:Content-Type:MIME-Version; b=Ce3GH5IEDZeGy0vUsC0kEhF4jB0ElIhhFq0JFaUOOVODf84u4+E+7qLrTEteylzuWI2Q9Qws2lfhmDsuGhX+Re4fKoV06eqlbBZzXPDpOiYhK6yNuq/4fTfa4+8bJcJmxdpCAfE6BJUJPJPlzyNNW3SxHh4qRthvb7ZB0zLDbEs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from localhost.localdomain (unknown [111.196.245.140]) by APP-05 (Coremail) with SMTP id zQCowAA3pT8+C15qcriIAA--.52006S2; Mon, 20 Jul 2026 19:49:18 +0800 (CST) From: Pengpeng Hou To: Jason Gunthorpe , Leon Romanovsky Cc: Zhu Yanjun , Michael Guralnik , Edward Srouji , Patrisious Haddad , Edward Adam Davis , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Pengpeng Hou Subject: [PATCH v2] RDMA/nldev: validate dynamic counter attribute length Date: Mon, 20 Jul 2026 19:49:18 +0800 Message-ID: <20260720114918.70323-1-pengpeng@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAA3pT8+C15qcriIAA--.52006S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Cw1fGF4UCF4UKFykArW3GFg_yoW8Gw4UpF WYgFy3Kr15JF47Aa1kt3Z7uayagw17JFy7GF95t39rurn0qw1xCr9Y9F1jqF4kJrWvya12 qF1qyrW5WrW5W3DanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9014x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26r4j6ryUM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26F4j 6r4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7x kEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E 67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCw CI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1x MIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIda VFxhVjvjDU0xZFpf9x0JUL0edUUUUU= X-CM-SenderInfo: pshqw1xhqjqxpvfd2hldfou0/ RDMA_NLDEV_ATTR_STAT_HWCOUNTERS is a nested attribute whose children are consumed directly with nla_get_u32(). The top-level policy validates only the container, so it does not establish the fixed shape of each child. Require every child payload to be exactly one u32 before reading it. Fixes: 3c3c1f141639 ("RDMA/nldev: Allow optional-counter status configurati= on through RDMA netlink") Reviewed-by: Zhu Yanjun Signed-off-by: Pengpeng Hou --- Changes since v1: https://lore.kernel.org/all/20260706091243.76784-1-pengpe= ng@iscas.ac.cn/ - require an exact u32 payload instead of only a minimum - carry Zhu Yanjun's Reviewed-by - rebase onto v7.2-rc4 drivers/infiniband/core/nldev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nlde= v.c index 02a0a9c0a4a6..f0f09670956d 100644 --- a/drivers/infiniband/core/nldev.c +++ b/drivers/infiniband/core/nldev.c @@ -2133,6 +2133,11 @@ static int nldev_stat_set_counter_dynamic_doit(struc= t nlattr *tb[], =20 nla_for_each_nested(entry_attr, tb[RDMA_NLDEV_ATTR_STAT_HWCOUNTERS], rem) { + if (nla_len(entry_attr) !=3D sizeof(u32)) { + ret =3D -EINVAL; + goto out; + } + index =3D nla_get_u32(entry_attr); if ((index >=3D stats->num_counters) || !(stats->descs[index].flags & IB_STAT_FLAG_OPTIONAL)) {