From nobody Sat Jul 25 02:39:06 2026 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53D0C404891 for ; Mon, 20 Jul 2026 11:49:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784548165; cv=none; b=jmSxxw9o+OafGoWbU4BLnF/2bOxyhrZon8Y5wAlGRqGNW4GuJZ92KdfII7q5j3aV0H2VmxkQxJp4itiBYBneNO8vpjia/z8fRnOZWW6Plm8joxi8s6D/hdaWsgZvKgPoa7U3z9Rdiilq2z+WC1u/Yafa62s9Pl43sLegd4eTkuI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784548165; c=relaxed/simple; bh=wpIzyFlOayw0t27RZwLxD2uaPShfVF6IYH7nU2klkZo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZBwmYjmzZIdwcHrBcxkZt18zPP1xz9MYjUsw/GHFn4e0vGKy8tOt8mfpsqP0wx/nyqhkl8YtXNq68wrS3XYQzDJ+XUoXylx6/YvrHbavddlhjc7uZKaAq3PuYVpzFUSiPzC/oXpGFwQd3xlLzpbwSR1VsB3v0yqQ2FFPJw80y70= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Mz3G2Dn7; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Mz3G2Dn7" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47f703a9e5dso382759f8f.0 for ; Mon, 20 Jul 2026 04:49:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784548161; x=1785152961; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=qNwj0cy3My+7S0Jfbfh0/9yw10VBWKnPBk+HsO2GxKY=; b=Mz3G2Dn73cx7ALAQthgVtmpotfolQNYxqZus+4711IsZZIcJxSOh2+9ij11ma3uCFw Bf7/wsZYPrFuw42IxzyljZGK2BNH4t1zBGUL2FiFl6kKeNHOsbMyKJ+0CU3xN630LOuU /Y9H+ar8Kl0dChdgAbFLAOaf1D/gaKyTYaFm9YBzb6tNy5NEoW84ZS+LpDWCEizCqw0m +pr826LR/ZUxTcrdWzzYiG9sDkUEOucX/lzQ5G62i+OZNzKFK0Xg4UzBX8Y5KPPndFUf 2PoOEK9DQlDRO+4J5l3NO2ymVeAaH56xN5GylE8mgaOfLuNxIhI2vIFEseUwcAgqxn8+ EM8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784548161; x=1785152961; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qNwj0cy3My+7S0Jfbfh0/9yw10VBWKnPBk+HsO2GxKY=; b=J7ThuGYofAI/y0+nHdpcPXiUuk7xZgPOqaZjLB6xD2E8YO/qymsRsoLnSKXiUpw4xG +sq9HnuF77v3f6EKvAozw7eFP85lexj5J7percxpjDe7TBZneEUVdBUv7x+RTP3nXu1j ioazHPDBq0Qg8LfWzT+a6F+7nVxU8DVobSiMhRg4j344h6HZq8AxPfvOHUofuMKsHOC1 PXcq4oX8e2uTHqUhoUnGKXV6I+GasSb1Nez0sPunYuzYd0eqodItbvuPijhZxa259mpY Fa2r1dcLgikA+pIhpRKK/J051beU5+1fzuV7LGh4RqyApBUUvTJxXJBliBZ7gEX/fw1+ KkJg== X-Forwarded-Encrypted: i=1; AHgh+RqcOE93wao5B81yj71XllM+aLvk4tI9aejTCn8txqutMcRhIvfNbcFnW9GlfpJ793VFr2w/wX3a+UC0gzE=@vger.kernel.org X-Gm-Message-State: AOJu0YyiKEXTPw4dz4Z2hYvaGcM2dNlr88kY5ASI7vEqpjuAqHJEr4ti 2szmDiAaRJFmgsSVqLE99cwpco79+FbPmSKjClASargCLTWu7eoVbXPC X-Gm-Gg: AR+sD12YA4SPio+7CZehG5F/9HrR6RxDb+i4c7YZwveXyKhm9py4renv4hiK2YpKwem ClvORmMqav9mcvs1wEMSNDR/WLXX8JNON2J94ZDeXsRUlHROdDYvlIS4gpqe4aa8IXUOAsRKdnm puvxYdESXTkATGZX6eghEPoToilBDqZ4lPUoBaUGGk9oIWNAVpX+B3kub3W+xGKD8i48v83UwsB CLikhspOhs5EOUaGStlRr3E8/9gxu91cqe+83P8CDscM1iZBXDV5UT09jI0R21mCuXeoohlB/xT PXvr0i6D4sPFrNHXhQQlCJIJXW7XCsB2AtZ/wORcAZCBECn6ulTnuWMYudWhx+SaRYNttPE/A3g zX71LRAffNzb3zH0AsGsBL0efBig2b1QGR6a//KOuldVvBtX6sqH1U2wp2qcpeQNZCsNHxi6XNR vicNpIQElhccu8HVHNTRpp6Z2hvPrAo10xfv8DSxmE5d/rVuh4bAJdInX4wsM= X-Received: by 2002:adf:eb8d:0:b0:478:77c1:7876 with SMTP id ffacd0b85a97d-47f6233d208mr13018808f8f.57.1784548161324; Mon, 20 Jul 2026 04:49:21 -0700 (PDT) Received: from osama.. ([2a02:908:185:7e40:a26b:a888:7408:fac]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f63e499c2sm27588500f8f.4.2026.07.20.04.49.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 04:49:20 -0700 (PDT) From: Osama Abdelkader To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Heiko Stuebner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader , stable@vger.kernel.org Subject: [PATCH] drm/panthor: validate firmware interface structure sizes Date: Mon, 20 Jul 2026 13:49:17 +0200 Message-ID: <20260720114918.15973-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" iface_fw_to_cpu_addr() only checks that the firmware-provided MCU virtual address points inside the shared section. The returned pointer is later used as a full firmware interface structure, so accepting an address near the end of the shared section can still lead to out-of-bounds accesses. Pass the expected object size to iface_fw_to_cpu_addr() and reject ranges that do not fit entirely in the shared section. Fixes: 2718d91816ee ("drm/panthor: Add the FW logical block") Cc: stable@vger.kernel.org Signed-off-by: Osama Abdelkader --- drivers/gpu/drm/panthor/panthor_fw.c | 30 ++++++++++++++++++--------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor= /panthor_fw.c index 9d0e1fafdce2..eee2bc7e8541 100644 --- a/drivers/gpu/drm/panthor/panthor_fw.c +++ b/drivers/gpu/drm/panthor/panthor_fw.c @@ -870,18 +870,24 @@ static int panthor_fw_load(struct panthor_device *ptd= ev) * iface_fw_to_cpu_addr() - Turn an MCU address into a CPU address * @ptdev: Device. * @mcu_va: MCU address. + * @size: Size of the object pointed to by @mcu_va. * - * Return: NULL if the address is not part of the shared section, non-NULL= otherwise. + * Return: NULL if the object is not part of the shared section, non-NULL = otherwise. */ -static void *iface_fw_to_cpu_addr(struct panthor_device *ptdev, u32 mcu_va) +static void *iface_fw_to_cpu_addr(struct panthor_device *ptdev, u32 mcu_va= , size_t size) { u64 shared_mem_start =3D panthor_kernel_bo_gpuva(ptdev->fw->shared_sectio= n->mem); - u64 shared_mem_end =3D shared_mem_start + - panthor_kernel_bo_size(ptdev->fw->shared_section->mem); - if (mcu_va < shared_mem_start || mcu_va >=3D shared_mem_end) + size_t shared_mem_size =3D panthor_kernel_bo_size(ptdev->fw->shared_secti= on->mem); + u64 offset; + + if (mcu_va < shared_mem_start) + return NULL; + + offset =3D mcu_va - shared_mem_start; + if (offset > shared_mem_size || size > shared_mem_size - offset) return NULL; =20 - return ptdev->fw->shared_section->mem->kmap + (mcu_va - shared_mem_start); + return ptdev->fw->shared_section->mem->kmap + offset; } =20 static int panthor_init_cs_iface(struct panthor_device *ptdev, @@ -906,8 +912,10 @@ static int panthor_init_cs_iface(struct panthor_device= *ptdev, =20 spin_lock_init(&cs_iface->lock); cs_iface->control =3D ptdev->fw->shared_section->mem->kmap + iface_offset; - cs_iface->input =3D iface_fw_to_cpu_addr(ptdev, cs_iface->control->input_= va); - cs_iface->output =3D iface_fw_to_cpu_addr(ptdev, cs_iface->control->outpu= t_va); + cs_iface->input =3D iface_fw_to_cpu_addr(ptdev, cs_iface->control->input_= va, + sizeof(*cs_iface->input)); + cs_iface->output =3D iface_fw_to_cpu_addr(ptdev, cs_iface->control->outpu= t_va, + sizeof(*cs_iface->output)); =20 if (!cs_iface->input || !cs_iface->output) { drm_err(&ptdev->base, "Invalid stream control interface input/output VA"= ); @@ -957,8 +965,10 @@ static int panthor_init_csg_iface(struct panthor_devic= e *ptdev, =20 spin_lock_init(&csg_iface->lock); csg_iface->control =3D ptdev->fw->shared_section->mem->kmap + iface_offse= t; - csg_iface->input =3D iface_fw_to_cpu_addr(ptdev, csg_iface->control->inpu= t_va); - csg_iface->output =3D iface_fw_to_cpu_addr(ptdev, csg_iface->control->out= put_va); + csg_iface->input =3D iface_fw_to_cpu_addr(ptdev, csg_iface->control->inpu= t_va, + sizeof(*csg_iface->input)); + csg_iface->output =3D iface_fw_to_cpu_addr(ptdev, csg_iface->control->out= put_va, + sizeof(*csg_iface->output)); =20 if (csg_iface->control->stream_num < MIN_CS_PER_CSG || csg_iface->control->stream_num > MAX_CS_PER_CSG) @@ -1015,8 +1025,10 @@ static int panthor_fw_init_ifaces(struct panthor_dev= ice *ptdev) return -EINVAL; } =20 - glb_iface->input =3D iface_fw_to_cpu_addr(ptdev, glb_iface->control->inpu= t_va); - glb_iface->output =3D iface_fw_to_cpu_addr(ptdev, glb_iface->control->out= put_va); + glb_iface->input =3D iface_fw_to_cpu_addr(ptdev, glb_iface->control->inpu= t_va, + sizeof(*glb_iface->input)); + glb_iface->output =3D iface_fw_to_cpu_addr(ptdev, glb_iface->control->out= put_va, + sizeof(*glb_iface->output)); if (!glb_iface->input || !glb_iface->output) { drm_err(&ptdev->base, "Invalid global control interface input/output VA"= ); return -EINVAL; --=20 2.43.0