From nobody Sat Jul 25 02:39:06 2026 Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEE5A404BF1 for ; Mon, 20 Jul 2026 11:48:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784548122; cv=none; b=uEP3AudwaYk0lmWGyDo0phZKMDmwCdbItnBPQJ6xAOmWxHUMl+TIVDualzrAZe4NRC03tzRyDaYbig6aiGqET3yWAzmhZQdK2bOTdISpg0yxpusmVR768x8JS4CY/WX6/NT2NPdEqfa5KXIRrxEEbOu4r87ze53Ila56VDahbLw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784548122; c=relaxed/simple; bh=xsdmgm6XUHDmG5O6rGroewG6Xg1XPiVD+jxPVRSIuPg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VNbFsnoJdozPfQcvT3/wwO/WEHNg4EaH4fD1S3x1E87JLZBTYATdV11mgdLMoOvu67BY406T/SzDBF9v4TmXZ6xZYTMBViMz8GjH0VG0rnpXgmp3SOIdJDKZuSGibQ5RQQQ7NSqemRwI6XNR7oDG4I8AK/HRnkrrCnvrOZmDho8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CaUIYkcF; arc=none smtp.client-ip=209.85.215.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CaUIYkcF" Received: by mail-pg1-f172.google.com with SMTP id 41be03b00d2f7-c99eaa1f020so6556194a12.2 for ; Mon, 20 Jul 2026 04:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784548119; x=1785152919; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=S4PaMqJeNiC5QfbV3fIyDG7VK1xywrztWMZ9FqDUkIM=; b=CaUIYkcFfbx3JKc0nO6Yo8npgkHp0mbvD75vGnzWX8oJPe0kKI1lhyfOemij+EpQB/ oYkHyIEVls+aIi+cDrAtzsi5hfaMEY9jajivn2VB35pKkeEAtq4yhqByM6zKpsysoe+0 kUM/zUGNcKqqBaMnOnKL+ZBIxnOtITYdrvBRXvDo9wysaZHSOVi/ufeRtLOL7/A+yrxy InJMxNp332CSYXpz4VMEAvfDRG3fHZTMpbshv9IHLxHyUgRKziA/jbbJtAtJn4ov6mhJ OIU9Dq0n43SZWjw+sXMWCJ7cESwyRndUXsXV41Y9dE7WVhOob7qbkTBtUUpjYwQwx32X JZEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784548119; x=1785152919; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=S4PaMqJeNiC5QfbV3fIyDG7VK1xywrztWMZ9FqDUkIM=; b=lyXLK6WCHHSi3/qocUzRh8WiyBBzZXzep95fd1j37dJ1RXZMdOjgVo+iO62fJ5B1iz mRAGpZj4BgJLJ9+jH6v/TbBF3Ij3U6UffxnvPbsMFo6i4UOot12TT2xlxrxYvxrHASRx 7DouPQ5o6/aShrv1iEa/CKoFZvDltwf2Y01hYGmTwoTA7y/q5B7JvNwtSf7nJgfQ/2EA OjW3GBeZk+nAMGy/If3DNDYgoT7mR4B6HEzfWGLkFtX0bsk/fd4EZZrmNNP6vfwVc+TG oKh8VEFsaojBpptPACjzgY9HM67Z+Q5NgMRfnDKkZOSoyvz9qNFet0U3HpOlagsWo4Sb PL+A== X-Forwarded-Encrypted: i=1; AHgh+RomlLCGT58lKeD5G0A9BtR7KJiYZYwE6n8juze3gCBpECr8xYATuc2maqylxU6ia7DwGaRhb+RX6h4+pPY=@vger.kernel.org X-Gm-Message-State: AOJu0YzL/BQelmonmW8pl9YWgRqs+2xBvCCmQgdwh6/9lMCo/hOsya8M yqdZUZU5/1UcsZPSX17Zf2WcNjUt7kQxXVkYCiE9i00knx8HGnBp0aRI X-Gm-Gg: AfdE7cliZtQBMXMseEOE+7eamLsS9OWRu9vgxim2ZJe2k6T743imLcZGLAPjDlj1hvm A7NDEh3Bqaqr9jSKuQ6uS1uK6qzcQpldG687Rg0Gd4qBxJqv/I8iIP8UxVJx6HXEiYBFe1K1qrJ 4H5Pu725qinNMDyejdEL8uDkoTxerCEL3LQ62tmXzQlpQqqfd7qtJMxPY21iow171GIgKv46HVq cI57yQj8TI3x6ITR33gzC5QMGqAIlxa7F0f9aYaw6gwP2hnPt8zeR0lkQ2LYlD/H3M4wTuHa4rE wx/H8iUTB4lPiyvU7JL55o6PwC836JrUH/x5Zfj7C53x6yo5AUFbDIMf4o/r3bdw5LWOkGHTtIm ouufxWerE4DjoWb53QHYgyv5n29uvAHPf2h+hZzsYZoDhWdZjGFuIEoHqFEp3F9VogB8JMbiIMq DrQGuLmjK3kj6VZatDiM6TZyA2/S0wDj3HzDEh0ckbcD8CZQbMzTaEWI1EbEPFjHc= X-Received: by 2002:a05:6a21:7105:b0:3c3:6ea3:f3d9 with SMTP id adf61e73a8af0-3c3ad9ec20dmr15497046637.70.1784548118650; Mon, 20 Jul 2026 04:48:38 -0700 (PDT) Received: from steellegend.taila75641.ts.net ([2405:201:304b:4973:59cd:5c84:346b:aa8e]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3142a1bbda9sm35591141eec.19.2026.07.20.04.48.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 04:48:38 -0700 (PDT) From: Uday Khare To: sakari.ailus@linux.intel.com, jacopo@jmondi.org, mchehab@kernel.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Khare Subject: [PATCH v2] media: i2c: mt9t112: fix incorrect PTR_ERR() call on non-error pointer Date: Mon, 20 Jul 2026 17:18:31 +0530 Message-ID: <20260720114831.33470-1-udaykhare77@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In mt9t112_probe(), the clock error check after devm_v4l2_sensor_clk_get() calls PTR_ERR(priv->clk) unconditionally, before testing IS_ERR(). On a successful lookup, priv->clk is a valid pointer and calling PTR_ERR() on it is incorrect API usage. While the comparison against -ENOENT happens to be harmless in practice (valid kernel pointers never fall in the error range), this is still a violation of the IS_ERR()/PTR_ERR() contract that can mislead readers. Restructure the check to guard PTR_ERR() inside IS_ERR(), using the simpler !=3D -ENOENT form to avoid an unnecessary else clause. Signed-off-by: Uday Khare --- drivers/media/i2c/mt9t112.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/mt9t112.c b/drivers/media/i2c/mt9t112.c index bd2268154ca7..b3a6c6d76632 100644 --- a/drivers/media/i2c/mt9t112.c +++ b/drivers/media/i2c/mt9t112.c @@ -1079,11 +1079,12 @@ static int mt9t112_probe(struct i2c_client *client) v4l2_i2c_subdev_init(&priv->subdev, client, &mt9t112_subdev_ops); =20 priv->clk =3D devm_v4l2_sensor_clk_get(&client->dev, "extclk"); - if (PTR_ERR(priv->clk) =3D=3D -ENOENT) + if (IS_ERR(priv->clk)) { + if (PTR_ERR(priv->clk) !=3D -ENOENT) + return dev_err_probe(&client->dev, PTR_ERR(priv->clk), + "Unable to get clock \"extclk\"\n"); priv->clk =3D NULL; - else if (IS_ERR(priv->clk)) - return dev_err_probe(&client->dev, PTR_ERR(priv->clk), - "Unable to get clock \"extclk\"\n"); + } =20 priv->standby_gpio =3D devm_gpiod_get_optional(&client->dev, "standby", GPIOD_OUT_HIGH); --=20 2.55.0