From nobody Sat Jul 25 02:45:20 2026 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1A023F8238 for ; Mon, 20 Jul 2026 11:38:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784547530; cv=none; b=QswSs79iAQOwN0idTxjWJKPfd6DkFJ80B+knbelqTHA26PEEiOuZ84a1KP5eihFDmsIf+SaiW66/m0W133cjVdiPvYU76OjK5Ly7WTetiOpi6n5CKNQHJ6HGFOrFgNFVgGixUNg8zaynl+zcpkaSAcjMAlQSHRIzFF6tIYqh5Og= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784547530; c=relaxed/simple; bh=dlMTPFtsBeQGxgr2XZu/OGNjGA04J4d1NowoJDCEljU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mWRyfiPnwtqDMZmftw7iz6kOKNCTqlXSijzK2sC/M1mBShgz1ZWj0b4kRc0es1/hN9tyvkpbRAhBqjora6vSpXE70vwTtSWps4cAw5yBUpJ3nI5rVgaTjV0ujJbakBF3l1CaoEWoevRRsioVp8W5CvDpvWqt1rj0EDEHH0hauns= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=I4BP+P4D; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="I4BP+P4D" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cf52d15d88so14089435ad.2 for ; Mon, 20 Jul 2026 04:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1784547525; x=1785152325; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=Nsdh+fwHmWa5XVa73TyuvW6VtjwnCR2ZTFQjARlnTb8=; b=I4BP+P4Dr5IgE7Df+RRWZQN+cERiv2FsBVNeeSrCYYXj7DdhrChveXbV4vPabOcJJQ A5Z3ubtPaJ/1GeoKWTbylWrTGTGEpdZUXIpKCBv4ev0DKisPhaG4m26HCn4j1sijCDH+ iDEhyFrZx4Ks4e5+bAqTNZ0AwXaR3XQW+T8rZPlkdj/GCBhUA1NXjN+N7yRuuS3P/qKd 0u32YjobuT8aXEJaZqKbn0AEeChbbhhdZoyH3TplKBX/2V1XmIp4R0gCnPlNTbXky/ym eIOHf3UgzBUwCL7m/XK/AsGmC9LEO3pSkSiNAUnCxpzfc+ylxRw4fDJ504X8Rwnnwt5g R9CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784547525; x=1785152325; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Nsdh+fwHmWa5XVa73TyuvW6VtjwnCR2ZTFQjARlnTb8=; b=rL9DHTokzl9PkB1DWnQZ8eA6ENK6z1MGBg1Q4OPSSEBapCqLZBPYZtk9R1D+D4jrCZ /Nzdq282ZR5pE94v4Z+u3KkPYLZm4THVMB/1XlQAUJ6xHcFVL6Lwv6EEKaTdIDmMvWEj 9tVJX+ZBnxVqLxWUIlIfPBHfYhclyC8D+TKAOMstt2VMb93kh5rhHu14vYZGnmzJgx8Z 3+KJkdIrQQ81qQ98o8z0ok77n97ZMhbbL62xVl6UIYLKFtXPYD8cAFZRo3rdCMFcd5qP oK22E2i0aMo3DIczOTinKLoHS0hyNtdDRqaUPpPR6DrAjjxsjZJKqEfWmJodiXcg3Xk4 gfog== X-Forwarded-Encrypted: i=1; AHgh+RrzVsb82fRTOczqRiwIFiJJAbNydS5JMe53+Yd+M5L53kiNdLl7InoSmTwHrkw2zEkLpoIzDHpVsONKrrs=@vger.kernel.org X-Gm-Message-State: AOJu0YwiPdsxKTT635EU+0VrX4z9tbLQ+asS0kJRPybqyw3YJkjNQFGf nJKznqvtDUt47C5Oo5H/2abnRrtUD+5XfPYw9aZwi17up9+VbESHQis9O5C+53oGXn8= X-Gm-Gg: AR+sD12ggf8eAeyrA9nJvcyjN6LV5eIzhspJXkBSkMd0DVd4xRzExLd5Mn6BiS8fKeS ymFVZ1nMjdEzycJ3M6gQaCwPtR+dASEhjaNVuu88dE+suy7ZXGd2WPjWiR5bIk/HFCBuKlQ2RzV lfbto5m8prD914JznEGOJcI4ILLJgi2UncsVTphdafKltQhkwVHNGClMLtgtbRkmb8UUPdywpCT Eu2o355smrYvADpxBflyzT7thMKd4HTY5a6s/MZXdTvAencOubOf1ARZY7AidgbGTAeHJazGJM1 gG0DoVB+2Rody6NL+gsZVv2VvnA6nUTf5qWAnSEBzjLFI311PguoUvGIhPFKdZ2UW7fFncYY4k1 hu1S3YyOcfuhDOTFNQu46E9Qbk41UXSTBL5yCPj2xSc25GOcFnMktWVdfMSpKAWJjdMlozRfz48 CFbcrj8NoqcCpwIzSOwja1fsFlIY5ty03UJ3ijprGyPEXt6b5eceDAm+bbnaG0HUvOfpYOF8rkr xvLMBKiu+lEeb11tFMHll79q3sR1IH8 X-Received: by 2002:a17:902:ce04:b0:2ca:52ce:6f91 with SMTP id d9443c01a7336-2cf3496b2ffmr168181275ad.27.1784547524888; Mon, 20 Jul 2026 04:38:44 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2cf3448f91bsm55554995ad.8.2026.07.20.04.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 04:38:44 -0700 (PDT) From: Abdun Nihaal To: lee@kernel.org Cc: Abdun Nihaal , mfd@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] mfd: sm501: Fix potential memory leaks during remove Date: Mon, 20 Jul 2026 17:08:32 +0530 Message-ID: <20260720113836.73133-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for struct sm501_devdata in sm501_pci_probe() and sm501_plat_probe() is not freed by the corresponding remove functions sm501_pci_remove() and sm501_plat_remove(). Fix that by adding a call to kfree(). Fixes: b6d6454fdb66 ("[PATCH] mfd: SM501 core driver") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/mfd/sm501.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 49c6b21a44e8..0b802925d6c2 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -1629,6 +1629,7 @@ static void sm501_pci_remove(struct pci_dev *dev) release_mem_region(sm->io_res->start, 0x100); =20 pci_disable_device(dev); + kfree(sm); } =20 static void sm501_plat_remove(struct platform_device *dev) @@ -1639,6 +1640,7 @@ static void sm501_plat_remove(struct platform_device = *dev) iounmap(sm->regs); =20 release_mem_region(sm->io_res->start, 0x100); + kfree(sm); } =20 static const struct pci_device_id sm501_pci_tbl[] =3D { --=20 2.43.0