From nobody Sat Jul 25 02:43:52 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D736367B86 for ; Mon, 20 Jul 2026 11:28:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784546900; cv=none; b=Tde39Sb87adR7L23+/N/n7NwbLIgr4T0bpv0CdSu387yNm9NcZgdK6XDvdYj0Dx3bVopcfJDQd/QJRrYQBIsD9Hvu7p6e4lnnYXcVN+0/5mcT+24B+ST3WBBtgKeYDchYqOb+X/4x7EpHU7pLXatwG8ffbtCvvN7dGnYUomT5ME= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784546900; c=relaxed/simple; bh=gYqI5EtspGPwx5u8iW3Fmzod1dv9OA0p12udKiIMvME=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=MICggHw4pd3lGNeDTlr3eSddfdnQ5z0uULPcKV1HzGweofjU7eL96k00GnQWkXL9ZUZ45kdA6weTxzMnsf4UFUP0XUoCbbvwFmQKyDXuH32+W+ad7RKcJYnaT/iNblT9nqIq4pWwbFK4hE4P8ddkjkZ2AgK07+LStmzvDN1KXSQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JwamvRO9; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JwamvRO9" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-38e347638adso5062679a91.0 for ; Mon, 20 Jul 2026 04:28:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784546899; x=1785151699; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fQgOhqe+fAH2CG7iQ5S0HRBskMHSjjsvcQe+rh+kcis=; b=JwamvRO9bYgRhU0dL3jEA9yREI3WkzNOPfB8/co0WE8SC/GuJgyOEGpUIPyAc8jSZ1 YxzicDf4mDq8SQCD4adrslZWBnD+yuYRBsezES2m/7tQtv8V6K1pDTxm2GnITJtYf/fY fWzAeGJvuCLhKmS9wEvi7X/J+tU5g0Mv9yTo5r7IyPZ3K3uewBKdxBCaeZ6IuiNQKNQ7 9WdGDX0Pmbvcn+xNOZ4j6uSDm5ONgyLVdhIUmcUTGwowfitT3IZTdMJpyZRhoP+Wn9/G SzdsJoin57MEjwUxpmlnAxB0C6jxQ4Q/sfA1ncgQFZVGg9NNysBAWaE5O94pD+cviGRg vfew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784546899; x=1785151699; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fQgOhqe+fAH2CG7iQ5S0HRBskMHSjjsvcQe+rh+kcis=; b=TR99AT0kPp3uXoLTBKmbENwbfk7lUu5kGmfkwJQCWOMiPfp8QvuNIvi5arFNxCm9kn LtVPJc1SV99LtVk8huJJtyspywISEZHS4PTPFvJNStkd2Hd0t5v7JLdlXr4TywGD8CdF lS4M3gIokD2VIccvrBejp99X7g1tQyZMpwngGo2RnxHwIAsEDOunmCUGr9/zigJlxtob CpvEmSf5SUFHmmFn16fCHZFeghhJ1tDH+QWXQLBpmIayudR+80RdFCMIVNGlG0HUxzZV bLCLmgm75YcHO4hzqrDMV2ph0uR/zkHdaS868hC4zhP+FTrfcQ27tUN0LrCbqK0RBcZ/ egyQ== X-Forwarded-Encrypted: i=1; AHgh+RryeeGoNo6/fLZvIBcScBWjQPdq07bXjjr/IStwBYFToWqRv0BfEpEIBue+gWN9/BmYpAIbGW/gfvGyBKM=@vger.kernel.org X-Gm-Message-State: AOJu0YyJq1TKLM3Et0ciUr/kepHvikUJfhbU28ZB+T2SC2+cei1JVOO8 zOSTKoTAc9uYK9HMh9Ee4o9ViHRruIelx1I8TnHYCF9402aB09xinXbn X-Gm-Gg: AR+sD11hS3iCorUoPACd29fbuykS+rQjz22JXulNQpDYj16QvCxdfGnqunamGDikAWl +mXuO5K9z7QJ4WWTN1jj/+/T7Bq81KooddJLDSjIuhZH2l81dn0ml7HSH9KQdgbBz4DKjc5pEkF A/IkmIUq6EnEK++Y3cQbpm5iRm4hD7FE5ZiWVu40QdZob7Z0gyDi7F+EIUfieiWIrc3NwsGx70O YB/52mAjhyxV1JMdson7JGk/RvG5qXLWVrIvPscaEvNpUGhxPZrf/UogXQeVqWTFwQ0BUOl+boa FYODFiEdIn/3nOB3pp4gMcHs58ryaDJEQQT+psEwu3o7kW/sFaN0/KKIZQiuyIeha8nbW80n677 38JQGLBuA1VjQQNV780aUdFBRXKxvHOMWZlkbU7xg609/eyM5K+90gpdcFn1ElPMDyfA9mQW/R/ daZprb5UjZ+CG3ktoL9tkFPBtxfQ== X-Received: by 2002:a17:90b:58d0:b0:381:c500:b0d1 with SMTP id 98e67ed59e1d1-38e4b530574mr14528440a91.20.1784546898632; Mon, 20 Jul 2026 04:28:18 -0700 (PDT) Received: from UbuntuOS.. ([49.34.174.103]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13ce29ffb13sm30500198c88.6.2026.07.20.04.28.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 04:28:17 -0700 (PDT) From: Prajval Chaudhary To: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org Cc: error27@gmail.com, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, Prajval Chaudhary Subject: [PATCH v3] staging: media: atomisp: Remove pad_w and pad_h module parameters Date: Mon, 20 Jul 2026 16:58:07 +0530 Message-Id: <20260720112807.6348-1-prajvalchaudhari733@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi Andy, Dan, Hans, Thank you for the review and catching this.=20 In this v3, I have completely dropped the changes to the debug=20 parameters to keep the staging debug facilities fully intact as requested. This patch now strictly focuses on removing the 'pad_w' and 'pad_h'=20 module parameters and converting them into internal driver constants. Remove the 'pad_w' and 'pad_h' module parameters to prevent userspace from overriding internal ISP hardware padding boundaries. Convert them into internal driver constants instead. This partially addresses the 'Remove unnecessary/unwanted module parameters' task in the driver's TODO file, while keeping the debug facilities intact as requested by maintainers. Signed-off-by: Prajval Chaudhary --- drivers/staging/media/atomisp/pci/atomisp_common.h | 4 ++-- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 8 ++------ 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_common.h b/drivers/s= taging/media/atomisp/pci/atomisp_common.h index a2462fc306fb..7c6c0124ff72 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_common.h +++ b/drivers/staging/media/atomisp/pci/atomisp_common.h @@ -22,8 +22,8 @@ =20 extern int dbg_level; extern int dbg_func; -extern int pad_w; -extern int pad_h; +extern const int pad_w; +extern const int pad_h; =20 /* Minimum padding requirements for ISP2400 (BYT) */ #define ISP2400_MIN_PAD_W 12 diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/sta= ging/media/atomisp/pci/atomisp_v4l2.c index 812230397409..d117fea2860c 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -64,13 +64,9 @@ MODULE_PARM_DESC(dbg_func, * output res, and isp output res. however since we do not have this yet, * the chosen solution is the next best thing. */ -int pad_w =3D 16; -module_param(pad_w, int, 0644); -MODULE_PARM_DESC(pad_w, "extra data for ISP processing"); +const int pad_w =3D 16; =20 -int pad_h =3D 16; -module_param(pad_h, int, 0644); -MODULE_PARM_DESC(pad_h, "extra data for ISP processing"); +const int pad_h =3D 16; =20 /* * FIXME: this is a hack to make easier to support ISP2401 variant. --=20 2.34.1