From nobody Sat Jul 25 02:49:25 2026 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 700FF349CE4 for ; Mon, 20 Jul 2026 11:25:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784546760; cv=none; b=t4aisgbYoqVUOIQZsV0nev6YVpR37x8N7QgS+462l2LYwlyVVdasyg1eLKj/TKhOJrEJLC01y9bswboTdLSeb9ZHD05NDxfu+LGJPypW4J2pCOhC9vKcVNcKGZgOrnxmunXEYJmck79yKkbVZ7BryZr9BYG7qoijnXuS+QrKyGE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784546760; c=relaxed/simple; bh=MK/EvtItOpT/zgPL5nusrcrvyqvBtj5dEqAmbXtdchU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=bG6yWtEUgnJsesweTMdfuC1TlUK4HleqJtWlLhD2RNpJPzpOPw2Q2oabB9YiR+3wgSe0kW2VUNVJNVW0dpH+kMqq43277rkYOdGra8uf0t0iIT8Clzt9MIMEJwYXw62aCmzxy2aUXSBGVmEAZORPujLp9DpGwp++fPu4ApEjrpE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in; spf=pass smtp.mailfrom=cse.iitm.ac.in; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b=ZzYLsrOX; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cse.iitm.ac.in Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cse-iitm-ac-in.20251104.gappssmtp.com header.i=@cse-iitm-ac-in.20251104.gappssmtp.com header.b="ZzYLsrOX" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2ca64c3ce5fso112603095ad.3 for ; Mon, 20 Jul 2026 04:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cse-iitm-ac-in.20251104.gappssmtp.com; s=20251104; t=1784546755; x=1785151555; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=/f8DL2vIooznsDdQVfwxZs99v9VD407+Uz6ZGQECJlg=; b=ZzYLsrOXWgI/t//OcBM7IkjVk2+QfSAjpGf/m+fqZDmpYtlSde23k8bDD595O87kYt 1H19npplrfZ3NUqikX3L/Qe4EGekvIr61wL233x6+CLNcquvu6x2lgbxIjmAuxm69Sy0 l4jA3p6So6xb/THoiH3tRwLa2jMr65g3SvyGML0oad9KpszwU7UnjabiTVAj3J2QdPMn 9lQDN53iCeFoBFFc4ROSAu3Cx1HSCun4O52k7T/c1OnQafofphegl+oIi38vxq2Ss5T0 0l/VdT/PMrNRrGnvsmD+FIlcKwSNl300h1vNUasaPMKuqm6Wfp82gWwr459GnGL8ZKiN vvNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784546755; x=1785151555; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/f8DL2vIooznsDdQVfwxZs99v9VD407+Uz6ZGQECJlg=; b=tAtrYVNiz7ZijDk+M85JteCIVRBemAWlTISZtaSjLmlJKJTZGatZSK2CbJMGgTjHeZ UBHpYv5xfXE5Svy4jmDrwX+6a2gn1I7LtzHFegHfdhSNsgA3kZbDZN0rSPYSROWkl3tx pvbkf4+pDzqf+f8z5Q7xaMYrwysSH8Q5nueDTVlkbI2tp6PkgcuQNt1Fn9gEGuxW00m5 4esQJLTw1/OycQbW5AP8znSncMYGmCXEzN+XlsDdliuCSNeE86cOYNce5p2tbKYrnFlV ww/zfGp+Gmgr8gMnXwWMAUyJbf1WCXvNQvEqTTq6JjnUCxtnPWOMaoo5WLQQf2MYxCDF AzPg== X-Forwarded-Encrypted: i=1; AHgh+RqgVEWXhjmBrIo+DyOO+vxJfELXHnZ0I6HzFjZgbRqgjnVo6CGLQ6+1BRBoDueui34TtO8bh5TH8u9MCbE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4p6foXFj6wJcQ7fMdFlZspcPRjZ12JqEaVc1080fPVZFsxm/j mMgaYcMzFGu8X5bKnZdwvVOnU3g3cHqy5gSK7yZgKXqB5rUuak0fAAo2/6AQRpzWU9M= X-Gm-Gg: AR+sD132nbOkyZ87AzvfGtgk3HiO3cUZg7RzsjiOZlNrv2HQaSWGw7KGPBkVOmoljS6 1qnugPi2LVuZ8V4xHMCrPt3/z7lRB6alLqU/lqBQTRDbY60KdwBAZy08rKUfqJTyhee6lVGAvDn kWVlnLHfI15cL5WLrw5j59ynRVTnGViw70JvQHwAxUU9WueBioqshkbaI8VQGX/jznbnB3m6V7D lhgA6VPrWkPpwRduzyfEx4iSNG5zMPZOVthIxUzc1o+E2c+qQuifZqMJlUKcMG3f7ae8V2hjH6u +2JDeSia9F2Z/nheaedTmTtSyGg9TrskrN7J26olUnjzzZmMDtPJaAHwwYwygd7kVEeXzFi5dxd bE30OsVRPUJIdqCM7vnnOgPx5wGg598fPqQUIEv02rHDQWfttVD8tPGTrsDqmRseCfRdhx5vLSy vSLSuV1GQZh8zednvwVTJLFaCSkcnC1IQBUKoVeGTxniQ0p2XYjW5BOEC7PyYfUym9mEnKCxLiL 7Nafp35g0s/ySAo3dDLgc5a3xpq58xe X-Received: by 2002:a17:90b:4a08:b0:380:9157:d6c with SMTP id 98e67ed59e1d1-38e4b41043cmr15033493a91.10.1784546755329; Mon, 20 Jul 2026 04:25:55 -0700 (PDT) Received: from Metius.iitm.ac.in ([103.158.43.43]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-13ce2de31a7sm30620268c88.15.2026.07.20.04.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 04:25:54 -0700 (PDT) From: Abdun Nihaal To: lee@kernel.org Cc: Abdun Nihaal , mfd@lists.linux.dev, linux-kernel@vger.kernel.org, gustavo@embeddedor.com, stable@vger.kernel.org Subject: [PATCH] mfd: sm501: Fix potential memory leak in sm501_register_gpio_i2c_instance() Date: Mon, 20 Jul 2026 16:55:31 +0530 Message-ID: <20260720112533.70538-1-nihaal@cse.iitm.ac.in> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memory allocated for pdev in sm501_create_subdev() is not freed in an error path in sm501_register_gpio_i2c_instance(). Fix that by releasing the platform dev in the error path. Fixes: ae7b8eda27b3 ("mfd: sm501: Fix potential NULL pointer dereference") Cc: stable@vger.kernel.org Signed-off-by: Abdun Nihaal --- Compile tested only. Issue found using static analysis. drivers/mfd/sm501.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index b5bda477ebfc..49c6b21a44e8 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -1103,8 +1103,10 @@ static int sm501_register_gpio_i2c_instance(struct s= m501_devdata *sm, /* Create a gpiod lookup using gpiochip-local offsets */ lookup =3D devm_kzalloc(&pdev->dev, struct_size(lookup, table, 3), GFP_KERNEL); - if (!lookup) + if (!lookup) { + platform_device_put(pdev); return -ENOMEM; + } =20 lookup->dev_id =3D "i2c-gpio"; lookup->table[0] =3D (struct gpiod_lookup) --=20 2.43.0